Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1364260 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #175 –
Your software rocks. Seriously. :-)

Thank you for fixing the album-art stuff... !!

If now just all the special character escaping worked a tad better, your plugin should be included in foobar2000 by default ;-)
 

foo_discogs

Reply #176 –
Can you possibly make the fetching of the small album art and the automated search for the album artist optional. I mean when you use your plugin it automatically searches for an artist and if it's the wrong artist or when you already have the url your waiting for nothing.
The same for the small album art in the tagging window, it's nice to have but a possibility to switch this of is nicer for mass tagging.
I have noticed when I get the covers afterwards that the tagging goes a lot quicker.
I'm sorry if I sound demanding but I tagged over 1000 albums with your plugin and I have noticed that these are the things that always keep me waiting.

btw the processbar still hangs sometimes but it isn't that much of a deal anyway

foo_discogs

Reply #177 –
hi; I just tried this plugin.
Seems fine but there's something I don't understand.
Why do I have to re-order discogs tracks manually (to match with files on the right) ?
Why doesn't the plugin automatically guess what is best order ?
(I have ticked "automatically match discogs tracks to local tracks")

foo_discogs

Reply #178 –
Quote from: abducted on
hi; I just tried this plugin.
Seems fine but there's something I don't understand.
Why do I have to re-order discogs tracks manually (to match with files on the right) ?
Why doesn't the plugin automatically guess what is best order ?
(I have ticked "automatically match discogs tracks to local tracks")


The automatic reordering is a bit basic as it will only reorder tracks if the number of local files and number of track in the discogs release is the same.

If its equal first it will match the tracks on trac length if this information is available on discogs (typically for CD but less often for vinyl). If there's no track length it will use %tracknumber% in files if available.
Else it won't go further by comparing track names for example.

Quote from: stampgevaar on
Can you possibly make the fetching of the small album art and the automated search for the album artist optional. I mean when you use your plugin it automatically searches for an artist and if it's the wrong artist or when you already have the url your waiting for nothing.
The same for the small album art in the tagging window, it's nice to have but a possibility to switch this of is nicer for mass tagging.
I have noticed when I get the covers afterwards that the tagging goes a lot quicker.
I'm sorry if I sound demanding but I tagged over 1000 albums with your plugin and I have noticed that these are the things that always keep me waiting.

btw the processbar still hangs sometimes but it isn't that much of a deal anyway



I tagged quite a bit of my own collection (600 release for now) and I arrive to the same conclusion so look for options to disable fetching of small album art and automatic search, in the next version

foo_discogs

Reply #179 –
your component crashes foobar when I try to update a lot of albums with albumart. it says that it let's the runtime act in a unusual way. It doesn't matter if I chose to update all art or just want the missing covers...

If noticed that it happens when the albums are from a lot of different labels, don't know if it has something to do with it...

foo_discogs

Reply #180 –
sometimes when fetching the album art the progress bar fills up 100% but doesn't close, i have to click cancel.

Not sure if this is to do with it being saved as folder.jpg? as i later changed it to album_art

using latest version

foo_discogs

Reply #181 –
Quote from: stampgevaar on
your component crashes foobar when I try to update a lot of albums with albumart. it says that it let's the runtime act in a unusual way. It doesn't matter if I chose to update all art or just want the missing covers...

If noticed that it happens when the albums are from a lot of different labels, don't know if it has something to do with it...


I didn't saw that myself and I update qui a few album with it (over 30Mb of art retrieved)
Can you reproduce on a particular release ? More info on th error that happened ?

Quote from: 2Pacalypse on
sometimes when fetching the album art the progress bar fills up 100% but doesn't close, i have to click cancel.

Not sure if this is to do with it being saved as folder.jpg? as i later changed it to album_art

using latest version


It happens rarely but I think it can happen if the focus window is changed when the progress window is displayed. It's just a display bug : art is retrieved correctly

foo_discogs

Reply #182 –
I had the error 2 times but I can't reproduce it, maybe it wasn't your plugin. If I see it again I will post it

Edit: it happens when I want to update album art on a large number of files. say 10a15 complete labels
I get this error => see picture



only happens when I do the album art update thing it's not my foobar I can give you the labels if you need them but you have to wait a while because there quite a lot.

foo_discogs

Reply #183 –
I like this Plug-in a lot, thanks.
elevatorladylevitateme

foo_discogs

Reply #184 –
Yay,

just checked out the latest version - wicked!

Any chance for a context menu item "Grab Album Art" if Artist and Album tags are present and correct?

Ronny

foo_discogs

Reply #185 –
FB just crashed when I was searching for an artist within the plugin. Then I noticed that right now Discogs is down (for me at least) at the moment - and I think that´s the problem  Is there a timeout in foo_discogs? It would also be nice if one would be able to stop searches - Search button turns into a stop button or similar. Not just to battle the timeout problem but also to speed up when trying to find an artist..

Quote from: Ronny Pries on
Any chance for a context menu item "Grab Album Art" if Artist and Album tags are present and correct?
Would be lovley.


Still THE plugin of 2006 (and probably 2007) 

foo_discogs

Reply #186 –
Have request (don't know if other people are interested but it would be really useful for me) would it be possible to have the artists images (off the artists page - not the release page) downloaded?

also don't know if you've considered my previous request, of adding to your parser the featured artists to a <featured> tag? - it would make me a happy man

Quote from: pawls on
Still THE plugin of 2006 (and probably 2007) 


Agreed along with SCPL, thanks for the great work

foo_discogs

Reply #187 –
Quote from: stampgevaar on
Can you possibly make the fetching of the small album art and the automated search for the album artist optional. I mean when you use your plugin it automatically searches for an artist and if it's the wrong artist or when you already have the url your waiting for nothing.
The same for the small album art in the tagging window, it's nice to have but a possibility to switch this of is nicer for mass tagging.
I have noticed when I get the covers afterwards that the tagging goes a lot quicker.
I'm sorry if I sound demanding but I tagged over 1000 albums with your plugin and I have noticed that these are the things that always keep me waiting.

btw the processbar still hangs sometimes but it isn't that much of a deal anyway


+1
---
its true... when I tagging full label collection with many releases, i dont use internal search engine. i open this page in internet explorer(label or artis page) and copy-paste URLs step-by-step + i have a slow connection so Auto artist searching is really VERY annoying...

and i think for more comfortable work, you need to make the order of buttons more ergonomic:
now i tagging with that way:

1. import folder - all label releases..or artist
2. remove all tags from mp3's (because i dont want to autostart "auto artist searching" - remove it!)
3. select tracks in playlist for tagging
4. press hot key for "Write tags..."    -  "S" (i manually set it)


// now about ergonomic keys, about what I spoke above
5. then,
5.1 i need to press TAB button 3 times, to make focus on URL  - i think this area must be first-focused by default
5.2 press ctrl+v to paste URL
5.3 and then press tab 2 times again to focus on the OK button, to enter... i think buttons should be in that TAB order: 1.URL 2.OK button

(may be this can be automated: if URL, that i manually pasted, have both strings: "http://discogs.com" and "/release/" - then start to search automatically - this checking algorithm will avoid wrong start of searching, in situations when clipboard has some wrong URLs: not on discogs.com, or on discogs.com, but not on release page) so if pasted URL not right i can paste other URL here... so u make script:

when i MANUALLY paste URL to URLstring(default focused), foo_discogs check this pasted URL, and if this right,autostart searching(press ok):

PASTE EVENT:
if (strstr(URL.text,"discogs.com") !=NULL && strstr(URL.text,"/release/") != NULL)
{
    auto press OK
}



6 .....and theen .... i turned off auto track matching, because all tracks in folder and in discogs usually goes alphabetically so i just press enter...  in this window "write tags" - focused by default.. this is good



---
UPD... another IDEA: 

add global static string  "previousURL"
and use it here:
//================================
if (
strstr(URL.text,"discogs.com") !=NULL
&& strstr(URL.text,"/release/") != NULL
&& strcmp(URL.text,previousURL) != 0 //not identical            <<<<  HERE
)
{
    strcpy(previousURL,URL.text);      // previousURL = URL.text          <<<<< and HERE
    auto press OK
}


so if i forget somethink... and trying to paste URL that i already tagged right before -  it dont press OK button automatically, so i will be noticed that somethink wrong  URL is wrong, or previous search was with that URL... so i need to check URL, and if allright, then press enter manually

foo_discogs

Reply #188 –
"5.3 and then press tab 2 times again to focus on the OK button, to enter... i think buttons should be in that TAB order: 1.URL 2.OK button"

Why not just set make the plugin when you press enter it automatically does the ok button. Sort of like a keyboard shortcut in foobar.

I'm also agreed with the automatically searching for artist, this because it isn't handy. Most of the time when your tagging you collection it is because the tags aren't correct and not because you have already did the effort to put a right artist name in the tags.

foo_discogs

Reply #189 –
Quote from: stampgevaar on
"5.3 and then press tab 2 times again to focus on the OK button, to enter... i think buttons should be in that TAB order: 1.URL 2.OK button"

Why not just set make the plugin when you press enter it automatically does the ok button. Sort of like a keyboard shortcut in foobar.


YEAH!  i think too...
-default focus when form loads is on URL
-default action when i press enter is OKbutton.click

so users just need to press ctrl+V and enter (if my script will not operate.. i script is not so hard to realize.. but maybe it will comfortable)    what other ppl think about this script that i explained above?

Quote
I'm also agreed with the automatically searching for artist, this because it isn't handy. Most of the time when your tagging you collection it is because the tags aren't correct and not because you have already did the effort to put a right artist name in the tags.


try to remove %artist% in properties before tagging

foo_discogs

Reply #190 –
Quote
try to remove %artist% in properties before tagging


To much work, then it's quicker to just wait for it

foo_discogs

Reply #191 –
Quote from: Dave_Scream on
YEAH!  i think too...
-default focus when form loads is on URL
-default action when i press enter is OKbutton.click


not sure about default focus i can see your point, sometimes it would be useful but other times i prefer to search through foobar.

Def agree about the "Ok" set to enter key.

I also miss having the "Del" key to remove selected file - currently have to click remove

Also - mass moving eg when u want to move more then 1 file up/down should be able to select multiple tracks and hit move up / down

foo_discogs

Reply #192 –
i ripped one of my vinyls and remembered about foo_discogs on this site. worked great. thanks for your work!

foo_discogs

Reply #193 –
Oh wow. I haven't been on the HA forums in a while and this plugin is a pleasant surprise. Looks fantastic, downloading it now!

foo_discogs

Reply #194 –
Why isn't the various contributing people list downloaded and tagged? What I speak of is, in this example, the

Flugelhorn - Bo Rande
French Horn - Lasse Mauritzen
Soprano Vocals - Rebecca Stark

on track 2.

foo_discogs

Reply #195 –
Quote from: MiSP on
Why isn't the various contributing people list downloaded and tagged? What I speak of is, in this example, the

Flugelhorn - Bo Rande
French Horn - Lasse Mauritzen
Soprano Vocals - Rebecca Stark

on track 2.



It's because the information is not available in a programmer friendly way. That's what discogs call roles or credits, there are like a zillion of them (http://help.discogs.com/wiki/SubmissionGuidelinesCreditList) some of them standard and other not. I'm figuring a way to retrieve a few of them like "Featuring"  or "Vocals" but it's still a hack, that's why I'm a bit reluctant to do it
It'll be written in their own tags (ie %DISCOGS_FEATURING%) and people will have to use the masstager afterwards if they want to put it in %TRACKNAME% for example, using whatever formatting they like.

I'll also probably add a %DISCOGS_CREDITS% tag with all credit per track concatenated which for some track can be huge

foo_discogs

Reply #196 –
You could add them into tags like this:

*person1*: *role1*;*person2*: *role2*;*person3*: *role3*

etc. Personally, I have such lists mapped to INVOLVED PEOPLE LIST, which foobar should map to TIPL, according to the ID3v2.4 standard.

foo_discogs

Reply #197 –
i just plan on displaying %title% then an if statement such as:

$if($meta(discogs_featuring), featuring [%discogs_featuring%],)

foo_discogs

Reply #198 –
v 0.92 is available taking into account a lot of the recent feedback - thanks! :


- add: find release dialog: focus on OK and search buttons is automatically set according to user actions
- add: find release dialog: "auto" option if enabled will auto search for the value of %ARTIST% if the tag has some value
- add: find release dialog: ability to search for non exact artist names, "exact matches" checkbox
toggle display of exact matches and all matches
- add: find release dialog: artist name containing funky characters (&, :, etc) should now return results
- add release dialog: option to display or not the small album art. Allow to gain some time by not fetching it (for display purpose)
- add release dialog: Delete key delete tracks in discogs and local track lists
- chg: connection failure should be more robust if discogs is not responding or no data is received for some time



Next version will fetch some of the track credits!

foo_discogs

Reply #199 –
sensational - I love it