@deathster77, thanks for your interest and yes, you can make a pull request.
---
About your question:
`g_properties` is the playlist panel properties object:
"foobar2000\profile\georgia-reborn\scripts\Playlist\main.js", line ~94
`pref` is the main theme panel properties object:
"foobar2000\profile\georgia-reborn\scripts\Base\gr-settings.js", line ~111
`ppt` is the library panel properties object:
"foobar2000\profile\georgia-reborn\scripts\Library\scripts\properties.js", line ~90
`pptBio` is the biography panel properties object:
"foobar2000\profile\georgia-reborn\scripts\Biography\scripts\properties.js", line ~85
That is because it uses 3 different scripts ( Playlist, Library, Biography ) and the main theme is
"foobar2000\profile\georgia-reborn\scripts\Base"
i.e `pref` object.
If you deactivate top menu Options > Settings > Disable right-click and when nothing plays right click in the left area where the album art is > Panel properties...
or you can also SHIFT + right click in playlist > Panel properties... you will see all theme settings.
These are all options from `pref`, `ppt`, `pptBio` and `g_properties`.
---
So the mod you made is for the playlist and should be put in foobar2000\profile\georgia-reborn\scripts\Playlist\main.js
and used for example as `g_properties.show_PLR`:
show_PLR: ['Panel Playlist - User: Row.peak_loudness_ratio.show', false],
Then you need to put it also in foobar2000\profile\georgia-reborn\scripts\Base\gr-defaults.js, line ~800 in `themePlaylistDefaults`:
show_PLR: false,
and `themePlaylistComments`:
show_PLR: 'Values: true, false - Options > Playlist > Track row > Show PLR value',
This will add new entries in the "foobar2000\profile\georgia-reborn\configs\georgia-reborn-config.jsonc".
You also need to add new entries in function `setThemeSettings` line ~1072:
In save
themePlaylist.show_PLR = g_properties.show_PLR;
and else
g_properties.show_PLR = custom ? themePlaylist.show_PLR : false;
In top menu Options > Playlist > Track row -> gr-menu.js, you already know:
rowsMenu.addToggleItem('Show PLR value', g_properties, 'show_PLR', playlistCallback);
And playlist context menu, right click > Appearance > Rows -> main.js, you also know:
appear_row.append_item('Show PLR value', () => {
g_properties.show_PLR = !g_properties.show_PLR;
}, { is_checked: g_properties.show_PLR });
---
That should be it.
-TT
Topic: Georgia-ReBORN - A Clean foobar2000 Theme (Read 173381 times)
previous topic - next topic