HydrogenAudio

Hosted Forums => foobar2000 => Support - (fb2k) => Topic started by: Pearl051 on 2004-05-19 17:18:45

Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Pearl051 on 2004-05-19 17:18:45
I am running a full install of v0.8.2 special edition with no other components.
I can reproduce this bug everytime.

You need a .SHN file to test this. If you don't have one, download here:
http://www.gdlive.com/shn/ (http://www.gdlive.com/shn/)

1. Make a new playlist and add a single .shn file in it.
2. Set the order to "Repeat"
3. Start playing. When the song ends. The playlist should repeat and the song  should start again. Instead you get this error:

Code: [Select]
INFO (CORE) : opening file for playback :
INFO (CORE) : location: "file://H:\March102000Late\d2t03.shn" (0)
WARNING (foo_shn) : reading data failed: unknown frame type. file is probably corrupt.
INFO (CORE) : opening file for playback :
INFO (CORE) : location: "file://H:\March102000Late\d2t03.shn" (0)
WARNING (foo_shn) : reading data failed: unknown frame type. file is probably corrupt.
INFO (CORE) : opening file for playback :
INFO (CORE) : location: "file://H:\March102000Late\d2t03.shn" (0)
WARNING (foo_shn) : reading data failed: unknown frame type. file is probably corrupt.


And this error goes on as foobar tries to plays the file again and again (repeat mode).

5. Press the stop button and then press play again. The file will again start playing normally.

Notes: You can only reproduce this error with .SHN files, a single mp3 file in a playlist with repeat mode works fine.
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-19 17:35:44
Reproduced with 0.8.2 special (http://www.saunalahti.fi/~cse/foobar2000/foobar2000.exe) on .SHN file made with John33's Shorten V. 3.6.0 (http://www.rarewares.org/files/lossless/shorten3.6.0.zip) via foobar cli.
Seektable seems to be well embedded. (On shortenfiles witout internal or external seektable fb2k gives them up as being 300 hrs or so of length... no matter what actual length is.)
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: foosion on 2004-05-19 17:51:13
Confirmed, I'll see what I can do.

Quote
(On shortenfiles witout internal or external seektable fb2k gives them up as being 300 hrs or so of length... no matter what actual length is.)

I couldn't reproduce this so far, though I'll have yet to try it with files encoded by Shorten 3.6.0.
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: foosion on 2004-05-19 20:23:01
Quote
3. Start playing. When the song ends. The playlist should repeat and the song  should start again. Instead you get this error:

Problem solved. ssamadhi97 will soon upload an updated version of foo_shn.
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-20 02:38:11
Quote
Confirmed, I'll see what I can do.

Quote
(On shortenfiles witout internal or external seektable fb2k gives them up as being 300 hrs or so of length... no matter what actual length is.)

I couldn't reproduce this so far, though I'll have yet to try it with files encoded by Shorten 3.6.0.

Oh that! No problem. Only happens  when you got shortenfiles with no internal or external seektables... and then it still playbacks flawlessly. You just get a sick display and you can't seek... all shortenfiles with (internal or external)  seektables works just fine....
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-20 02:42:54
NOBODY EVER had this issue.

Well, nobody except for you, apparently. WTF. I think it's bad karma.


Edit: And I know a lot of people who love this plugin for being able to play and seek properly in seektable-less files.

Put a file that exhibits this issue somewhere for me to download please.
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-20 02:56:26
Ok. Sorry. It was 3.22 hrs not what I said. I will upload.
OK. Posted. here (http://www.hydrogenaudio.org/forums/index.php?showtopic=21786&view=findpost&p=212549).
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Pearl051 on 2004-05-20 03:29:35
wow a big thanks
a patch in one day! awesome work.

Quote
And I know a lot of people who love this plugin for being able to play and seek properly in seektable-less files.


The most prominent reason i left winamp for foobar. I deal with a lot of shn files and its a blessing to be able to seek without seektables.

Finally don't forget to post the link once the updated foo_shn is up  .
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-20 03:48:59
Quote
NOBODY EVER had this issue.

Well, nobody except for you, apparently. WTF. I think it's bad karma.


Edit: And I know a lot of people who love this plugin for being able to play and seek properly in seektable-less files.

Put a file that exhibits this issue somewhere for me to download please.

And I really don't need advice on my karma in an audio thread, even if latest events gives you some room to gloat. 
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-20 03:57:43
Quote
Ok. Sorry. It was 3.22 hrs not what I said. I will upload.
OK. Posted. here (http://www.hydrogenaudio.org/forums/index.php?showtopic=21786&view=findpost&p=212549).

Heh. wav header of the contained file is broken - not our problem.

Besides, you can seek in that file without any problems using the arrow keys. Of course the seekbar isn't going to help you much when trying to seek around within the first 1:26 of a file that claims to be 3 hours long.

I guess whatever program was used for creating the wav file that's contained in that .shn is severely fuct in a way or two.


Edit: see? must be your karma after all.. 
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-20 04:06:59
Actually I made that file with - %d instead of %s %d i foobar. So it was a construct. But I have had some files from etree.org that was just like that. Only I recoded them and deleted original. Didn't say I thought it was no problem. And uploading my former password basicly marks me as a drunken sod anyways. Which I am. Still, hill Freya, and my taste in music are impeccable, no way to deny that....
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-20 04:24:42
Flame them for spreading broken files, then?

Because technically, your shn contained an incomplete wav file.


(FYI, shntool and shnamp both report the same insane length as well, because they retrieve the wav header info of the contained file for this. decoding to wav using a Shorten executable and dropping the file into a player might or might not give you the correct length, because many players will calculate the correct length from the sample format and the actual file size (instead of using the length of the data riff chunk as reported by the wav header))
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-20 04:28:29
should I upload same file correctly coded? prolly not needed but I can if somebody want to compare....
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-20 13:31:51
Sure, feel free to..
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-20 16:59:56
I guess Shorten simply messes up wav header data when encoding from stdin..
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Mr_Rabid_Teddybear on 2004-05-21 02:35:08
this (http://www.hydrogenaudio.org/forums/index.php?showtopic=21817&view=findpost&p=212764) worked with shorten stdin too....

...and I just thought that it was the *.skt file that didn't get written and embedded when using stdin.... well I'm not too technically savvy, am I....? 
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-23 21:48:32
Quote
Finally don't forget to post the link once the updated foo_shn is up   .

Well, so much for "ssamadhi97 will soon upload an updated version of foo_shn." 

The repeat issue has been fixed, as well as some other stuff.

updated version can be downloaded here: http://www.stud.uni-karlsruhe.de/~uybc/foo_shn.zip (http://www.stud.uni-karlsruhe.de/~uybc/foo_shn.zip)

Case's installer has been updated to use this new version as well.


(just posting here in case someone's subscribed to this thread)
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Pearl051 on 2004-05-24 14:33:19
Is it just me? I am still getting the error after replacing foo_shn with new http://www.stud.uni-karlsruhe.de/~uybc/foo_shn.zip (http://www.stud.uni-karlsruhe.de/~uybc/foo_shn.zip)

Also tried restarting foo bar and creating new playlists. Still getting same error.
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: ssamadhi97 on 2004-05-24 15:21:12
redownload, try again.

It's really fixed now. promised.

($#@%&)
Title: Bug: foo_shn can't repeat playlist with single shn
Post by: Pearl051 on 2004-05-24 17:42:47
Yes now it is fixed 
Thanks!