Still no joy on ssb16 - it rips to wav, but doesn't go any further than that.  For now, I've fallen back to ssb15 as it works correctly as long as the disc remains in the drive.

This  actually got me thinking about another repercussion of doing the disc  numbers of a set dynamically - ssb16 wont process correctly in batch  mode. the interface has to be open with the correct numbers in the  metadata tags in order for it to work. Is there any way to have that  data go into a tag or data file that is persistent until the rip is  processed to flac or ogg or whatever?

I need to hear from dewey1973 to see if b15 works for him

Since switching to EAC 0.99pb1 and ssb16 I am having a problem.  Everything goes great until the extractions is complete.  Nothing happens after the extraction completes.  I use F10 to do an image test & copy.  I get the wav, log, cue, and jpg but none of the other processes begin.  Here is my ini.  Any help would be appreciated.

Quote

I need to hear from dewey1973 to see if b15 works for him

Testing now...

It may be worth hitting  Ctrl-F2 with REACT/EAC open, to let REACT (re-)configure EAC.

It may be worth hitting  Ctrl-F2 with REACT/EAC open, to let REACT (re-)configure EAC.

ssb16 rips and converts only for single disc sets. If any entry is made in the new dialog then the wav file is created and then the process stops. No conversion, no renames, etc.

I also had to use Ctrl+F2 to reset EAC before ssb16 would rip, convert and rename single disc sets.
...
edit 2: I got ssb16 to work, had to reset EAC with Ctrl+F2 and I also had a missing quote mark in one of the track.cfg file. Took some doing, but I tracked it down. Sorry about blaming you for my bad typing.

Would like to suggest as well, that the dialog not be reset when a new disc is inserted. If you are ripping a multi disc set, then two values have to be entered with every disc and if ripping a 6 disc set for example, there is a high probability of making a mistake and having to re-rip a disc. Plus it's lot of extra keystrokes.

Quote from: deltadave on 2007-08-01 02:35:20

Would like to suggest as well, that the dialog not be reset when a new disc is inserted. If you are ripping a multi disc set, then two values have to be entered with every disc and if ripping a 6 disc set for example, there is a high probability of making a mistake and having to re-rip a disc. Plus it's lot of extra keystrokes.

My main concern retaining values is that someone could set totaldiscs to 2, hide the dialogue, and then rip a hundred discs forgetting to set it back.  Single disc albums are far more prevalent than muli-disc albums.  The idea is that the settings refer to default - i.e.: the value they will be for most discs - and therefore I would say that you are minimising typing by not having to reset after multi-disc albums.

That's my contra-argument; however if other users disagree I have no problem changing the logic according to the majority.

Thanks for the feedback anyway, I'll certainly bear it in mind.  I have considered providing options on the dialogue before, and perhaps this could be solved with a checkbox to set user preference - possibly even on  a per token basis.

Also, contrary to my previous remark, I have made some steps towards storing the meta data in an album-specific ini, so that it can be used in batch ripping.  My main concern, however, is that - because the EAC wrapper instance only has access to basic info like artist and album - I am currently using "<artist> - <album>.ini" as the naming scheme; fine most times, but not for multi-disc albums.  I don't know a resolve to this, unless I somehow utilise some (as yet undescovered) command line app to calculate the freedb id, use that, and then use the freedb id passed by EAC in the REACT params to find the ini for the album being processed.  Any thoughts?

code libraries:
http://www.codeproject.com/cs/media/freedb.asp

Thread on this very topic:
http://www.autohotkey.com/forum/topic13706.html

In EAC isn't %f the tag for storing freedb id?  Not usually used from what I can tell, but still available. I think.

I'm also worried about over-complicating my mod, with the need for additional EXEs/DLLs and extra processing time.

I've just thought of a sure-fire way to get the freedb id.  Force EAC to write a "Single WAV File" cuesheet (Alt+S) and then grab the freedb id from the REM statement.  Slightly messy, but no need for additional exes/dlls, and I know the id will be the same.

Of course, this will also rely on the user using unique names for their images when ripping to WAVE with the compression queue on.

After doing this the next set of processes did kick off.  I did however get an error that I'm sure has to do with where the files are saved.  I'm sure I can fix it after reading the log more carefully.

error in tag spec: eaclog=@C:\My Documents\My Music\CD Images\The Police - The Police (Disc 1) [2007].log !

I think that I'm slightly confused as to how EAC/REACT works... would you mind putting up a brief summary or pointing to one? 

My understanding:  REACT opens using the .ini file then rips the files from CD to .wav file.  Once the .wav file(s) are created it uses the .cfg file to create a batch file that processes the wav file(s) by instancing FLAC, LAME or whatever external compression program is desired.  The processing instance would be the REACT that creates the wav files? Wrapper would be the batch file that calls the external processor?

When I set "Test=0" this error does not occur and the process completes successfully with the exception that the log file is not moved to the new directory.  The log is, however, saved in the tag of the wv file.

I'd really like to use Test & Copy.  Any idea what I can do to make this work?

When I set "Test=0" this error does not occur and the process completes successfully with the exception that the log file is not moved to the new directory.  The log is, however, saved in the tag of the wv file.

IF @Debug@==1 (
    PAUSE
    EXIT
)

REM ** Cleanup

DEL "@source@"
DEL "@eaclog@"
DEL "@cuesheet@"
DEL "@albumfile@.[*].cue"
DEL "@cover@"

REM ** Delete this .bat file:
DEL %0

IF NOT @NeroAac@==1 GOTO end_nero_aac_tracks
	SET dest="@TrackDir_AAC@"
	IF NOT EXIST %dest% MKDIR %dest%
	PUSHD %dest%
		IF @various@==1 SET VA_tag=-meta-user:albumArtist=$q@VA@$q -meta-user:compilation=true
		IF %embed_cover%==1 SET Cover_tag=-add-cover:front:$#x
		@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --extra-opt "@cover@" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\neroAacTag.exe $#o %Cover_tag% %VA_tag% -meta:artist=$#a -meta:album=$#T -meta:track=$n -meta:title=$#t -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$q@comment@$q -meta-user:encodingTool=$qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q -meta:totaltracks=$N -meta:label=$q@label@$q -meta:disc=$q@discnumber@$q -meta:totaldiscs=$q@totaldiscs@$q"
		IF @ApplyAlbumGain@==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt
		COPY /Y "@eaclog@" "EAClog.txt"
		IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
	POPD
:end_nero_aac_tracks

Do I take it that you have your images set up to use the scheme "$artist$ - $album$ [$year$]"?

ImageNaming=$artist$ - $album$ [$year$]
ImageDir_Wavpack=@OutRoot@\CD Images\$cdartist$\$album$ [$year$]

I wonder if this is a timing issue with Test & Copy.  If the REACT script tries to access the log and it is not yet saved, wouldn't that cause the error?  I noticed that when using Test & Copy the status bar progress indicator goes from 0% to 50% during the test and then goes back to 0% for the copy.  As the copy completes it goes to 50% again.  It never reaches 100%.  If this somehow delays the saving of the log (like until I hit OK on the viewable log that pops up) then the wavpack command line would be looking for a file that didn't exist yet.  Any thoughts?

 "@sourcecuesheet@"

Just to let you know, as I don't like to say I'll do something and then not:  my wife's ill at the moment (nothing terminal) and I've taken a couple of days off to look after the kids, so I'm afraid I've no time for testing or code changes, and won't have for a few days.

let me know if there is anything I can do to make it easier for to care for your family.  I truly appreciate the work you are doing, thank you!

The pause code worked like a champ!  I guess if someone didn't want to use the pause code they could instead check "Make all compression tasks sleep" in the Compression Queue Control Center.  That way they could make sure nothing happens until the log is ready.

I loaded up the latest, ssb16. The new (XUI) albumart as well. Everything worked GREAT... for one album.

On album #2 I get through the rip->wav part, and then it stops.

Quote from: pholzmann on 2007-08-05 20:40:53

I loaded up the latest, ssb16. The new (XUI) albumart as well. Everything worked GREAT... for one album.

On album #2 I get through the rip->wav part, and then it stops.

Your symptoms don't make any sense to me, so I have to start with the basics:  is this one disc that causes the problems, or have you tried various discs, all with no luck?

rem ECHO OFF
rem CHCP 1252

IF @Debug@==1 (
rem   PAUSE
rem   EXIT
)

REM ** Cleanup

DEL "@source@"
rem DEL "@eaclog@"
DEL "@cuesheet@"
DEL "@albumfile@.

• .cue"
  DEL "@cover@"
  
  REM ** Delete this .bat file:
  DEL %0

I have noticed that my REACT_track.cfg differs from ones others have posted on this thread in that mine has the cover embedding actions under each individual file format heading whereas other posts show a single mention under Post-processing.

I went beack to ssb15... seemed to work better...but still not fully reliable.

* If I leave DEBUG off, the batch file never runs. Is it possible that with DEBUG=1 in the ini file, something inside REACT changes?

* With DEBUG=1, I also made the following changes to the CFG file, and I'm now running reliably:

At the top:

Quote

rem ECHO OFF
rem CHCP 1252

(My guess: echo off doesn't matter. But for some reason, the CHCP command still hangs a lot)