Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1278849 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

REACT 2 Released

Reply #175 –
Thanks for the response.  I do want non-compliant cue sheets.  I had read your prior post and already tried your suggestion without success.  Cuesheets and the eaclog are both created temporarily but they are never copied into flac and mp3 directories.  They are not "rem"ed out.

1.  Is there something wrong with this syntax.

                COPY /Y "@eaclog@" "EAClog.txt"
      IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
      IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"
I don't know what copy/y means but it definately works for @cover@.


2. When I set debug to 1, where should I look for problems with eaclog and cuesheets? 

Thanks again for your help.

REACT 2 Released

Reply #176 –
Code: [Select]
/Y           Suppresses prompting to confirm you want to overwrite an existing destination file.

I can't help thinking that:

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"

... will copy the log into your system32 folder as EAClog.txt.

That doesn't explain your cuesheet going missing though.

I would just be interested to see what those lines look like once the tokens have been replaced, i.e.: the actual command that is run.  The log may well give you this info. Another debug technique I've used before is to copy the temporary batch file that REACT creates while it is present, allowing you to see exactly what is being processed without it disappearing on you.
I'm on a horse.

REACT 2 Released

Reply #177 –
Quote from: Synthetic Soul on
Code: [Select]
/Y           Suppresses prompting to confirm you want to overwrite an existing destination file.

I can't help thinking that:

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"

... will copy the log into your system32 folder as EAClog.txt.

Hi Synthetic Soul

Yes, you are right, but what you didn't get to see in mogorp's quoted part of the cfg.(and of course you can't remember the whole .cfg file in your head ) was that a little above those lines there was this command : "PUSHD %dest%" and at the end of the lines, this command : "POPD", which explains it

Btw, now that i am talking to you...

I'm personally no command-line expert like yourself  So i have been wondering about a line in the .cfg that i don't understand :

IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .

    If the "." at the end wasen't there, then all four cuesheets would be copied into the %dest% directory(because of the above "pushd %dest%" before that...), since only a source file(s) is given, but no destination. Now my question to you is about if the "." is a bug, or if it's something that means anything ? I checked the www.ss64.com site which i previously have read that you have recommended, but i couldn't find any references to using a "." as destination path/name for the "COPY" command ?

    Thank's in advance.

    @mogorp

    I'm sorry, but i don't see why it isn't working and hence, i'm affraid that i can't help you, then  I'm sorry about that, mate 

    CU, Martin.

REACT 2 Released

Reply #178 –
Ah, thanks for the additional info Martin!

I must admit I have never used the dot syntax that Tycho employs.  I have just performed a small test using the batch file below, and it seems to me that it just uses the current directory as the destination.  I assume it is like the "./" syntax sometimes used in other scripting.

Code: [Select]
IF EXIST "C:\Documents and Settings\Neil\Desktop\*.bat" COPY "C:\Documents and Settings\Neil\Desktop\*.bat" .
PAUSE

The result of the script above, which is not on my desktop, is that all batch files on my desktop where copied to the folder in which the script resides.  As you say, removing the dot appears to give the same result.

Edit: I realised that the test above was a little inconclusive, so I amended it slightly:

Code: [Select]
PUSHD "C:\Documents and Settings\Neil\Desktop\Freeview Radio Test"
IF EXIST "C:\Documents and Settings\Neil\Desktop\*.bat" COPY "C:\Documents and Settings\Neil\Desktop\*.bat" .
POPD
PAUSE

Running the script above from a totally different folder the files are copied to the folder "Freeview Radio Test" - i.e.: the current working directory, not the directory in which the script resides.  This is as expected, but clarifies it more than my previous test!
I'm on a horse.

REACT 2 Released

Reply #179 –
Thank you very much for your reply Synthetic Soul and for testing it out for me  When i had read your post i thought to myself how big of an idiot i was for not just thinking about testing it out for myself

Btw, on another thought...

Your nick-name(or what it's called) is a little long to write, so i would like to ask you if you would mind if i used a shorter version of it(e.g. Synthetic or SS or ???), and in which case, what you preffered ? Of course i can continue to write it completely and that is no problem either, but just a thought

Btw, for people seeing this, then if they want to ask me something, then i preffer to be called Martin, and that i only choose Martin H, since the name "Martin" was allready taken  (Btw, My name is Martin Hertz )

REACT 2 Released

Reply #180 –
Anything is fine by me Martin.  "SS", "Synthetic" or, even "Neil" from you.

I should have really gone for a shorter name, and Gambit did offer to have it amended for me, but I'm kind of attached to it now.

That said, I'm not precious about it - so anything that you think will catch my attention, but not violate TOS #2 , is fine by me.

NB: Thank you for your good work in this thread BTW.  I am not as active as I was, as I really have had little chance to play with REACT v2.  My AVG antivirus seems to really hate the EXE, so I've pretty much reverted to ripping to WAV until I can find some time to sort it all out.  Unfortunately I have more pressing things to occupy my time.
I'm on a horse.

REACT 2 Released

Reply #181 –
Quote from: Synthetic Soul on
...
My AVG antivirus seems to really hate the EXE, so I've pretty much reverted to ripping to WAV until I can find some time to sort it all out.  Unfortunately I have more pressing things to occupy my time.


My AVG has no problems with REACT at all. I am using AVG 7.5 free.

And by the way:
Will there be an REACT Update with CueProc instead of acdir?

And finaly:
Great work done on REACT! I like this tool. Thank you very much.

REACT 2 Released

Reply #182 –
So, have we determined where the cuesheets should be getting placed?  EAC has to process the disc and bring up the process bar to create each cuesheet, right?  It can't just magically come up with them.  Based on this, I have had no luck getting it to produce ANY cuesheets with REACT, and I have already tried changing the * to mg.  That would probably work if it was creating them in the first place, but it isn't.
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!

REACT 2 Released

Reply #183 –
@Neil

Thank you very much, my friend  Yeah, i can perfectly imagine that REACT isn't your first priority when dealing with both work, small children and a wife

Btw, if you only want me calling you Neil in PM's, then please let me know, as i don't want to step on your toass(or whatever it's called, - and speeled)

Take care

@mmortal03

I will now test it out for you and report back when i'm done with testing

REACT 2 Released

Reply #184 –
@mmortal03

Okay, i have tested it now and i can tell you that it works perfectly, so it must be something wrong on your end i'm affraid. I ammended the ini file to setup REACT to make WavPack and MP3 track files. When the process had run through, then i had a WV and a MP3 folder in my Testing directory and in the WV folder there where the tracks of the album, four different cuesheet types and an EAC logfile. In the MP3 folder there where the tracks of the album and nothing else. I new that this would happen from reading the config file and when i changed it alittle, and did a re-run, then i had a WV folder with the tracks of the album and one non-compliant cuesheet named "%basename%.cue" and an EAC logfile. In the MP3 folder i had the tracks of the album, a non-compliant cuesheet named "%basename%.cue" and an EAC logfile. The changes i made to achive the latest result was : 

Under the WV tracks section, then change :

Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


To :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


Under the MP3 tracks section, then change :

Code: [Select]
REM COPY /Y "@eaclog@" "EAClog.txt"


To :

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"


And also add this line :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"

REACT 2 Released

Reply #185 –
Quote from: Martin H on
@mmortal03

Okay, i have tested it now and i can tell you that it works perfectly, so it must be something wrong on your end i'm affraid. I ammended the ini file to setup REACT to make WavPack and MP3 track files. When the process had run through, then i had a WV and a MP3 folder in my Testing directory and in the WV folder there where the tracks of the album, four different cuesheet types and an EAC logfile. In the MP3 folder there where the tracks of the album and nothing else. I new that this would happen from reading the config file and when i changed it alittle, and did a re-run, then i had a WV folder with the tracks of the album and one non-compliant cuesheet named "%basename%.cue" and an EAC logfile. In the MP3 folder i had the tracks of the album, a non-compliant cuesheet named "%basename%.cue" and an EAC logfile. The changes i made to achive the latest result was : 

Under the WV tracks section, then change :

Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


To :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


Under the MP3 tracks section, then change :

Code: [Select]
REM COPY /Y "@eaclog@" "EAClog.txt"


To :

Code: [Select]
COPY /Y "@eaclog@" "EAClog.txt"


And also add this line :

Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"


Thanks Martin, I'll try it out.  One thing, though:  What windows does EAC show when it is doing this process?  Does it just show the ripping dialogue, or are you also getting a window pop up that says that it is detecting the gaps and/or creating the cuesheets?
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!
 

REACT 2 Released

Reply #186 –
Martin and Synthetic Soul. 

Thank you as always. I appreciate the fact that you guys are always willing to help others.
I must confess that I am in fact an idiot.  My problem is solved.  I was ripping in track mode and therefore of course using the REACT-track.cfg file.  I was editing the track section of the REACT-image.cfg file.  It is no wonder that this was useless.

Martin,
I added your
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"
change you suggested and ripped in image mode and the non-compliant cuesheet was created. 

I then switched back to track mode (for some reason I like accuraterip) and used
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue"
and this worked.  Thank you guys again.  I am so sorry for wasting your time. 

REACT 2 Released

Reply #187 –
Hi mmortal03

Yeah, sorry - i forgot that you also asked about that in your previous post

When i press F10, then a small window pops up, which displays "Analyzing" and then detects the timings of the pause areas and retrieves the UPC/ISRC codes. Then again this window comes up 4 times, which now only detects UPC/ISRC, as the pause areas already have been determined(REACT uses AutoIT to script the EAC GUI, so it's just like you yourself had choosen to make the 4 cuesheets, one by one). Then you now have several different cuesheets and a bat file in your temp ripping folder and then the ripping starts. Then the image and cuesheets/eaclogs are all processed/copied/moved and all temporary files deleted from the temp folder

Quote from: mogorp on
I am so sorry for wasting your time. 

Hi mogorp

Don't be sorry, it's no problem at all  I'm just glad to hear that you got it sorted out in the end

CU, Martin.

REACT 2 Released

Reply #188 –
Solution: Use F4, don't use the MP3s button.  Problem solved.
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!

REACT 2 Released

Reply #189 –
Bug:  REACT automatically refills the genre box in EAC at rip time, if I blank it.
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!

REACT 2 Released

Reply #190 –
Quote from: mmortal03 on
Bug:  REACT automatically refills the genre box in EAC at rip time, if I blank it.

If you are reffering to there being set an empty genre tag field, if you haven't entered a genre in EAC's main window, then that's not a bug. Either you make sure that a genre is defined, or you remove that part of the command-line in your cfg file which sets the genre tag field.

Edit: I'm sorry, mate  I have just reread your post and saw that i had misunderstood you. What you are reffering to is not a REACT bug, but a bug in EAC. To make sure that this dosen't happen(after a certain time period, the changes you have made is reverted back to it's previous values), then instead of making the changes directly in EAC's main window, then instead press ALT+L and make the changes from there and select "OK".

REACT 2 Released

Reply #191 –
ok...i'm getting myself lost in the config. i want a streamlined react2 config (to place on friend's machines) that will generate *only* --scaled mp3's, eac cue, and eac log. i've set:

[UserTrackFormats]
Flac=0
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0

and get everything except the cue sheet. i suspect i'm getting lost in this section of REACT-image.cfg:

IF NOT @LameMP3@==1 GOTO end_lame_tracks
   SET dest="@TrackDir_MP3@"
   IF NOT EXIST %dest% MKDIR %dest%
   PUSHD %dest%
      IF @various@==1 SET VA_tag=--user-text $q[album artist]@VA@$q --frame $qTPE2:@VA@$q
      IF %embed_cover%==1 SET Cover_tag=--pict $#x
      @tools@\acdir.exe --overwrite --output "%TrackName%.mp3" --extra-opt "{3}@cover@" --pipe "TITLE $n/$N mp3 $#T & @tools@\lame.exe @Opt_LameMP3@ %ApplyAG_Lame% - $#o & @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist $#a --album $#T --title $#t --track $n/$N --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME @Ver_LameMP3@ @Opt_LameMP3@$q $#o" "@sourcecuesheet@"
      IF %add_rg%==1 @tools@\metamp3.exe %RG_MetaMP3% *.mp3
      IF @ApplyAlbumGain@==1 @tools@\metamp3.exe %ApplyAG_MetaMP3% *.mp3
      COPY /Y "@eaclog@" "EAClog.txt"
      IF %have_cover%==1 COPY /Y "@cover@" "folder.jpg"
      IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .
       POPD
    :end_lame_tracks

    should i simply replace "@albumfile@.
  • .cue" with "@cuesheet@" ?
    eg should
    IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .
    be something like
    IF EXIST "@cuesheet@" MOVE /Y "@cuesheet@"  %dest%

    thanks in advance.

REACT 2 Released

Reply #192 –
Quote from: robinpb on
should i simply replace "@albumfile@.
  • .cue" with "@cuesheet@" ?
    eg should
    IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .
    be something like
    IF EXIST "@cuesheet@" MOVE /Y "@cuesheet@"  %dest%

Hi robinpb

You should replace :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


With instead :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"



CU, Martin.

REACT 2 Released

Reply #193 –
Quote from: Martin H on
Quote from: mmortal03 on

Bug:  REACT automatically refills the genre box in EAC at rip time, if I blank it.

If you are reffering to there being set an empty genre tag field, if you haven't entered a genre in EAC's main window, then that's not a bug. Either you make sure that a genre is defined, or you remove that part of the command-line in your cfg file which sets the genre tag field.

Edit: I'm sorry, mate  I have just reread your post and saw that i had misunderstood you. What you are reffering to is not a REACT bug, but a bug in EAC. To make sure that this dosen't happen(after a certain time period, the changes you have made is reverted back to it's previous values), then instead of making the changes directly in EAC's main window, then instead press ALT+L and make the changes from there and select "OK".


Interesting.  I don't remember this happening in EAC before using REACT, because I would always blank the genre information (being that it is too inconsistent), and then rip, and not only would it stay blank, but EAC would remember that it wasn't filled the next time that I inserted that CD.

Yeah, I did already remove -T genre="@genre@" to beat this, before you suggested, actually, so at least it doesn't write the information to the files.  I'm just looking for a way to have EAC remember that it is blank.  I will try what you mentioned.

Btw, is there any variable to represent the track number WITH the zero at the front for 1-9 (how EAC outputs the track number to the filenames prior to encoding)?  I need this to do some find and replace work in the cuesheets, without having to search twice per file.
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!

REACT 2 Released

Reply #194 –
Quote from: Martin H on
Quote from: robinpb on

should i simply replace "@albumfile@.
  • .cue" with "@cuesheet@" ?
    eg should
    IF EXIST "@albumfile@.
  • .cue" COPY /Y "@albumfile@.
  • .cue" .
    be something like
    IF EXIST "@cuesheet@" MOVE /Y "@cuesheet@"  %dest%

Hi robinpb

You should replace :
Code: [Select]
IF EXIST "@albumfile@.[*].cue" COPY /Y "@albumfile@.[*].cue" .


With instead :
Code: [Select]
IF EXIST "@albumfile@.[mg].cue" COPY /Y "@albumfile@.[mg].cue" "@basename@.cue"



CU, Martin.



ok i'm testing that out now.
i do have
CreateAllCuesheets=1
set in react.ini
but during the ripping process i'm only seeing one cue sheet being generated (without any 'mg' naming convention).

REACT 2 Released

Reply #195 –
Quote from: mmortal03 on
Btw, is there any variable to represent the track number WITH the zero at the front for 1-9 (how EAC outputs the track number to the filenames prior to encoding)?

I believe that EAC's track number variable "%n" is returned with the leading zero appended, but it's then up to the app that retrieves this value(for further processing) what they do with it, like e.g. lame.exe cuts the zero of when setting the "Track" ID3v1.1 tag and/or TRCK ID3v2.3 frame.
Quote from: robinpb on
ok i'm testing that out now.
i do have
CreateAllCuesheets=1
set in react.ini
but during the ripping process i'm only seeing one cue sheet being generated (without any 'mg' naming convention).

I'm sorry, mate - I really don't know what's your problem is then, but i can just say that i atleast could get it to work, so i'm affraid that it's something on your end - Again, Sorry for that, mate 

One thing that is important though, is that your pause area(called gap in EAC) settings are matching your drive correctly...

REACT 2 Released

Reply #196 –
Quote from: Martin H on
Quote from: mmortal03 on

Btw, is there any variable to represent the track number WITH the zero at the front for 1-9 (how EAC outputs the track number to the filenames prior to encoding)?

I believe that EAC's track number variable "%n" is returned with the leading zero appended, but it's then up to the app that retrieves this value(for further processing) what they do with it, like e.g. lame.exe cuts the zero of when setting the "Track" ID3v1.1 tag and/or TRCK ID3v2.3 frame.



The point I was making was that REACT does cut the leading zero off the variable @track@.
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!

REACT 2 Released

Reply #197 –
Will REACT2 work with the new flac 1.1.4?    If so, can I just overwrite the flac.exe file in the ...\REACT2\tools\ directory?

REACT 2 Released

Reply #198 –
Quote from: mmortal03 on
The point I was making was that REACT does cut the leading zero off the variable @track@.
Use $track$ to get a leading zero.

Quote from: phaedra on
Will REACT2 work with the new flac 1.1.4?    If so, can I just overwrite the flac.exe file in the ...\REACT2\tools\ directory?
Yes, no reason why not.
I'm on a horse.

REACT 2 Released

Reply #199 –
Quote from: Synthetic Soul on
Quote from: mmortal03 on
The point I was making was that REACT does cut the leading zero off the variable @track@.
Use $track$ to get a leading zero.


Thanks!  The next question is this:  Can we come up with a way to have arguments specific to what characters REACT would write for a folder name, and arguments specific to what characters REACT would write for a filename?  Just one example is where there are periods in an album's name, which will be in a folder name.  "Takk..." becomes "Takk" when written out by REACT into the folder name, but for the track called "Takk...", it leaves the periods in the file name.  I am sure there are other cases of this that can happen.  Is there a way to know how REACT will write out the actual filenames so that I can search and replace my cuesheets accordingly?

Edit:  I think currently, as I just tested it, @-surrounded variables aren't filtered according to what is allowed/outputted in a filename, as they are to become the meta-data.  I assume that $-surrounded variables are what EAC uses to build the filenames and what it passes to REACT*.

*Edit2:  I think I got it to work with a combination of @s and $s surrounding various variables, but it wasn't completely straightforward.  For some reason, with the same name for BOTH the album and the title (Takk...), these are what I get:
$album$="Takk"
$title$= "Takk..."
@album@="Takk..."
@title@="Takk..."

So, it looks as if EAC was specifically coded to pass the album string with the knowledge that album names are generally placed in a folder name, thus filtering it as such, but doesn't touch the track information.  Maybe there are cases where it will alter even the track name -> What isn't allowed in a filename?

For this particular case, another problem was that EAC even STILL will output the album title as "Takk..." in the cuesheet, but only in places where there is no folder structure, so I had to use @album@ in my search and replace string to find these specific cases, even though the @ variable's purpose is generally only to be used in metadata situations.
WARNING:  Changing of advanced parameters might degrade sound quality.  Modify them only if you are expirienced in audio compression!