IF NOT @iTunesAAC@==1 GOTO end_iTunes_aac_tracks
    SET dest="@TrackDir_AAC@%trackDir%"
    IF NOT EXIST %dest% MKDIR %dest%
    PUSHD %dest%
        IF @various@==1 SET VA_tag=-meta-user:$qAlbum Artist$q=$q@VA@$q
        IF %embed_cover%==1 SET Cover_tag=r $q@cover@$q
        @tools@\acdir.exe --overwrite --output "%TrackName%.wav" --extract "@sourcecuesheet@"
        @tools@\acdir.exe --exec "TITLE $n/$N aac $#T && @tools@\iTunesEncode.exe @Opt_iTunesAac@ %Disc_iTunesAAC_acdir% -e $qAAC Encoder$q %Cover_Tag% -x @various@ -a $#a -l $#T -n $n -m $N -t $#t -y $q@year@$q -g $q@genre@$q -c $q@comment@$q -i $q%TrackName%.wav$q -o $q%TrackName%.m4a$q && IF EXIST $q@tools@\NeroAacTag.exe$q @tools@\Neroaactag.exe $q%TrackName%.m4a$q %VA_tag% %Discname_iTunesAAC_acdir% -meta-user:encoded-by=$q%UserName%$q -meta-user:Encoding=$qiTunesEncode/iTunes @Ver_iTunesAac@ @Opt_iTunesAac@$q && DEL $q%TrackName%.wav$q" "@sourcecuesheet@"
        IF @ApplyAlbumGain@==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt
    POPD
    GOTO end_nero_aac_tracks
:end_iTunes_aac_tracks

Code: [Select]

IF NOT @iTunesAAC@==1 GOTO end_iTunes_aac_tracks
    SET dest="@TrackDir_AAC@%trackDir%"
    IF NOT EXIST %dest% MKDIR %dest%
    PUSHD %dest%
        IF @various@==1 SET VA_tag=-meta-user:$qAlbum Artist$q=$q@VA@$q
        IF %embed_cover%==1 SET Cover_tag=r $q@cover@$q
        @tools@\acdir.exe --overwrite --output "%TrackName%.wav" --extract "@sourcecuesheet@"
        @tools@\acdir.exe --exec "TITLE $n/$N aac $#T && @tools@\iTunesEncode.exe @Opt_iTunesAac@ %Disc_iTunesAAC_acdir% -e $qAAC Encoder$q %Cover_Tag% -x @various@ -a $#a -l $#T -n $n -m $N -t $#t -y $q@year@$q -g $q@genre@$q -c $q@comment@$q -i $q%TrackName%.wav$q -o $q%TrackName%.m4a$q && IF EXIST $q@tools@\NeroAacTag.exe$q @tools@\Neroaactag.exe $q%TrackName%.m4a$q %VA_tag% %Discname_iTunesAAC_acdir% -meta-user:encoded-by=$q%UserName%$q -meta-user:Encoding=$qiTunesEncode/iTunes @Ver_iTunesAac@ @Opt_iTunesAac@$q && DEL $q%TrackName%.wav$q" "@sourcecuesheet@"
        IF @ApplyAlbumGain@==1 @tools@\aacgain.exe %ApplyAG_AacGain% *.m4a > gainlog.txt
    POPD
    GOTO end_nero_aac_tracks
:end_iTunes_aac_tracks

Edit: BTW, I would suggest, when the wiki article is  updated, that the SED-specific text is kept, under a "Using SED" subtitle, with the GSAR text added above that section, under a "Using GSAR" subtitle.  The opening passage of the article should then highlight that the GSAR approach is recommended.  I would like to keep the SED text for reference, and it may still be useful to some people.

Quote from: Akkurat on 2008-01-15 20:10:53

But in fact we don't need that in "Amending Cuesheet..." because we can shorten the substitution to:

Code: [Select]

GSAR.EXE "-s@basename@.wav" "-r%TrackName%.wv"

I believe that I had the additional text to ensure that the right part was being acted upon; however, it should be reasonably safe to cut the text down to the above.

ECHO @tools@\GSAR.EXE "-s@basename@.wav""" WAVE" "-r%TrackName%.mp3""" MP3" -o %trackCueFile%>>update-cuesheet.bat

I think I was probably confused as I didn't see it as being a very useful feature, and therefore not a showstopper for GSAR.  I'm glad to hear that it's not to do with the core functionality anyway.  I think GSAR could be useful for some other actions in REACT configs.

Can I get something cleared up in my mind?  Are you using GSAR in place of SED because SED does not handle certain characters well ('&' now that it can be included in track titles for example)?

Yes.
...
As SED could potentially cause problems with a few characters it seems safer to change to GSAR, which will do the job just as well, but should not be affected (so much*) by these issues. 
...
nago highlighted that ampersands could cause an issue with SED

Edit: BTW,  I would suggest, when the wiki article is updated, that the SED-specific text is kept, under a "Using SED" subtitle, with the GSAR text added above that section, under a "Using GSAR" subtitle.  The opening passage of the article should then highlight that the GSAR approach is recommended.  I would like to keep the SED text for reference, and it may still be useful to some people.

I'm currently discussing the problem with the author. If the thing gets resolved, should we update the amending cuesheet wiki to use that feature? IMHO it's nicer way to do things but it's obsolete since there's already a working solution.

It's more than that ampersand character. Mainly the opening square bracket ( [ ) + other characters which have special meanings in the regex (basic/extended). The square bracket is used in ImageNaming INI variable AND also in the various artists filename scheme.

I have to disagree slightly. The SED instructions should be removed since it's very risky to use it now without char escapes (or instructions how to do it). Maybe reference to SED should be left but without any code/instructions to use it AND a warning for the users who are currently using SED...?

Also I would recommend every SED user to check their cuefiles because there's a very high chance that your cuefiles are corrupted!!

I can see that converting "/r/n" (CRLF) to "/n" (LF/newline) is a change, but any text editor worth its salt can open UNIX-style text files, and foobar has no problem with them.

GSAR -ud -o *.cue

Edit: Do I take it from your enthusiasm for this approach that you can have multiple occurences of the -s and -r switches in a file?  If not then I am still finding it difficult to see the appeal.

The ampersand is the only character that will cause a problem in the right side of the expression, and that was the character that nago raised to make me aware of the issue.

Then I guess we'll have to agree to disagree.

Quote from: Akkurat on 2008-01-16 15:51:58

Also I would recommend every SED user to check their cuefiles because there's a very high chance that your cuefiles are corrupted!!

Edit: I'm not really sure what you mean by corrupted.  I can see that converting "/r/n" (CRLF) to "/n" (LF/newline) is a change, but any text editor worth its salt can open UNIX-style text files, and foobar has no problem with them.  That just leaves a handful of cuesheets that may be screwed due to unescaped characters on the left hand side (@basename@), or the ampersand on the right (%TrackName%).

I agree that it would be better for none of this to occur, but stating that "there's a very high chance that your cuefiles are corrupted!!" is a little melodramatic don't you think?

dir /S *^&*.*    = 146
dir /S *.mp3     = 2731
146 * 100 / 2731 = ~5,35 %

Quote from: Synthetic Soul on 2008-01-16 16:08:01

I can see that converting "/r/n" (CRLF) to "/n" (LF/newline) is a change, but any text editor worth its salt can open UNIX-style text files, and foobar has no problem with them.

The good news of course is that GSAR has the ability to convert UNIX ASCII text files to DOS ASCII text files.

Code: [Select]

GSAR -ud -o *.cue

Yes, just like the SED works: one txt file and one gsar command to run all... IF I'm not mistaken.

I don't know why you're so defensive. If you read my comment again you should see that I was talking about the whole sed command, not just the "right side". My motive was merely to pass on information to this subject which was not discussed here before. Nothing personal.

So if I change the wiki, you would revert it back?

No, I don't think so. Why do you like to play down this issue?

Code: [Select]

146 * 100 / 2731 = ~5,35 %

Of course this doesn't count total possible corrupted cuefiles because there can be several filenames w/ ampersand in the filename per directory/album/cuefile. But still. Usually fail rates are counted in "nines": 99,99...% if that kind of thinking/measuring can be adjusted to this issue.

Yes but it's not needed because gsar doesn't change the "newlines".

SET sedTrackName=%TrackName:&=\&%
ECHO s/\Q@basename@\E\.wav"/%sedTrackName%\.wv/>>sedlist.txt

Just tried this out and no dice. The WAVs were extracted however no M4As created.

I'll try this again after work.

-

I do not see how this can work. You are using ACDIR on individual files but import the same source cuesheet. Wouldn't that source CUE point towards the WAV-image?

SET Disc_iTunesAac_acdir=-j @discnumber@ -k @totaldiscs@

I believe you can use \Q@basename@\E to solve this issue just fine. Quoting the RHS in SED still remains an issue though.

Quote from: nago on 2008-01-16 21:08:08

I believe you can use \Q@basename@\E to solve this issue just fine. Quoting the RHS in SED still remains an issue though.

I've tried this, with no success.  Is it possible that these is a Perl-only switches?  I seem to remember seeing that there are different versions of SED; maybe I need an alternative version?  Maybe I'm just being a dimwit.

Oh, I forgot about escaping characters on the LHS.

I believe you can use \Q@basename@\E to solve this issue just fine. Quoting the RHS in SED still remains an issue though.

The only rational solution is to change my name and disappear from the internet.

And if you're keen on keeping the SED in the wiki as a tool which can be used to other things, may I suggest that you take into consideration the other (maybe rare but still) "right side" can-be-a-problem-things? http://sed.sourceforge.net/sedfaq3.html#s3.1.2

SET sedTrackName=%TrackName:\=\\%
SET sedTrackName=%sedTrackName:&=\&%
ECHO s/@basename@\.wav"/%sedTrackName%\.wv/>>sedlist.txt

Quote from: Akkurat on 2008-01-16 17:57:10

Yes, just like the SED works: one txt file and one gsar command to run all... IF I'm not mistaken.

That would be good.  If that is the case I would probably be up for amending the code.

If there's a topic somebody would like me to answer, please ask because I'm going to fade to the background again, thanks.

No go. This is what the author wrote: "When gsar became a win32 app the @ support went away. It was only supported using the Zortech compiler.". The following explains more why I thought that it was a bug: "I thought I had removed the @ from the text files but it seems as if this was not the case. Anyway take it from me that @ is long gone.". And why it was removed: "The @ is not really needed anymore on Win32 due to the length of the command line.". So the current solution is the best we can do with GSAR.

Will you be sharing your work with regard to escaping characters for SED?

Quote from: Akkurat on 2008-01-17 00:48:21

No go. This is what the author wrote: "When gsar became a win32 app the @ support went away. It was only supported using the Zortech compiler.". The following explains more why I thought that it was a bug: "I thought I had removed the @ from the text files but it seems as if this was not the case. Anyway take it from me that @ is long gone.". And why it was removed: "The @ is not really needed anymore on Win32 due to the length of the command line.". So the current solution is the best we can do with GSAR.

That is a shame, it would have been tidier.  Thanks for the info.

gsar.exe "-sAAA é^%&--x'[]!äöå...WAV" "-rAAA é^%&---'[]-äöå...FLAC" -o "test.cue"

C:\>CALL update-cuesheet.bat

C:\>gsar.exe "-sAAA Ú^&---'[]-õ÷Õ...FLAC" -o "test.cue"

gsar: command error, the 'o' or 'f' option is meaningless in 'search' mode

Trust you, eh?

Hmm..  does this mean that GSAR can't handle anything more than basic ANSI?  I must admit that I get very confused about codepages etc., as I am a simple English speaker who listens to UK/US music on the whole (Air is one exception that I can think of).  It appers to me to be a codepage issue of some sort or another, but that's as far as I know.

As you say, the % issue isn't a huge problem - something I should have thought about before - but something that we can deal with.

Well, in answer to your question: I'm fine about switching to another app, as long as it is free, and does the job!  Any suggestions?

Try copying the Codepage Change command into the bat file you are calling-- the one present at the top of both images-cfg and tracks-cfg. Tycho had a reason for putting it in there, it might benefit your child process.

Just a thought!

SET test=%test:a=ab%