HydrogenAudio

Lossy Audio Compression => Ogg Vorbis => Ogg Vorbis - General => Topic started by: Deep_Elem on 2011-09-23 22:53:17

Title: OggEnc v2.87 (aoTuV Beta 6.03) padding switch
Post by: Deep_Elem on 2011-09-23 22:53:17
I noticed some time ago that the --padding switch has disappeared from the various oggenc2.exe builds that I've downloaded from rarewares. I'm currently using OggEnc v2.87 (aoTuV Beta 6.03), still with no padding switch. I've searched and cannot find any thread explaining what happened to this switch.

I liked this switch and would like to have it back. Can anyone explain what happened to it and whether we can expect to see its return in future releases?
Title: OggEnc v2.87 (aoTuV Beta 6.03) padding switch
Post by: john33 on 2011-09-24 09:29:52
The option was removed in November of last year because it caused issues with Windows 7. I've not looked at it since but I'll have another look now.
Title: OggEnc v2.87 (aoTuV Beta 6.03) padding switch
Post by: lvqcl on 2011-09-24 10:01:10
Found the suggestion about padding: http://www.hydrogenaudio.org/forums/index....ost&p=43768 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=4319&view=findpost&p=43768)

But there's a problem with that code because of:

vorbis_analysis_headerout(&vd,opt->comments, &header_main,&header_comments,&header_codebooks);

allocates memory for comments and stores it in 2 variables:  header_comments.packet  and vd.backend_state.header1.
The latter variable is defined in codec_internal.h and should be also updated somehow.
Title: OggEnc v2.87 (aoTuV Beta 6.03) padding switch
Post by: john33 on 2011-09-24 11:13:16
And not a trivial exercise, it would seem.
Title: OggEnc v2.87 (aoTuV Beta 6.03) padding switch
Post by: Deep_Elem on 2011-09-25 19:18:17
John,

Thanks for your prompt reply to my question. I really appreciate it and all the work you've put into oggenc2.
Title: OggEnc v2.87 (aoTuV Beta 6.03) padding switch
Post by: lvqcl on 2011-09-28 17:53:57
http://wiki.xiph.org/Metadata (http://wiki.xiph.org/Metadata) :

Quote
METADATA_BLOCK_PADDING: Nul padding.
...
METADATA_BLOCK_VORBIS_COMMENT: Also known as FLAC tags, the contents of a VorbisComment packet.


Does it mean that padding should have its own block (instead of adding unused space to VorbisComment block)? Or is it true only for FLAC files?

Added: yes it seems to be related to FLAC only