Implemented in 0.5.7. Now RMS+Peak doesn't happen by default, it is instead selectable through the "Levels->Mixed" option. I've added an explanation for it to the documentation.

Also fixed the stop behavior for the LEDs in "Mixed" mode (they "turn off" when player stopped).

Lastly the crash should not happen anymore for the .bin file inside the RAR archive above. The base offset for the second meter when the file includes both sides and also LEDs was calculated incorrectly leading to out-of-bounds accesses.

If there's a way to improve your plugin further, I certainly don't know what that is!

For that reason, I would consider unable to create/acquire the DirectX device a critical issue and stopping the application is the right course of action (maybe could be done in a more informational/user-friendly way though).

Plus, it is the least of your problems since much of the OS shell is hardware accelerated using Direct2D and the like.

I also would assume several of the built-in visualizations use Direct2D so if you include those in the UI, do they cause any issues?

I thought it would be better for the component to fail gracefully and still allow foobar to start up. I'm not sure if the issue lies with foobar itself unable to handle this component failure, or this component fail in such a way that it causes the foobar process to abort (foobar main window does not even show up).

While Windows 10 comes with DirectX 12 software, it doesn't do anything good without new-enough hardware.

Maybe a good time to implement CUI support.

Quote from: Defender on 2024-11-20 12:52:02

Maybe a good time to implement CUI support.

Already done, but I absolutely refuse to support any issues due to it. Plus, since there are no releases for ARM64 architecture for the main CUI component and thus the feature will not be available there until that happens.

Are you sure CUI support is implemented in 0.5.7.0? Maybe I'm stupid, where can I find the new VU panel (DX12) to add as a panel?

i found it in view menu ..visulisation  but I am daft heh

Quote from: Defender on 2024-11-22 18:54:19

Are you sure CUI support is implemented in 0.5.7.0? Maybe I'm stupid, where can I find the new VU panel (DX12) to add as a panel?

It is not activated in 0.5.7. As I said, I do not have the bandwidth to support another UI framework, so finding it requires slightly more legwork and self-sufficiency. I'm being deliberately vague because, in general, users will fail to understand what no technical support really means.

Already done, but I absolutely refuse to support any issues due to it. Plus, since there are no releases for ARM64 architecture for the main CUI component and thus the feature will not be available there until that happens.

Maybe I'm stupid, where can I find the new VU panel (DX12) to add as a panel?

Quote from: Defender on 2024-11-22 18:54:19

Maybe I'm stupid, where can I find the new VU panel (DX12) to add as a panel?

I know nothing about CUI, but in DUI the VU Meter (DX12), if added to your Components (foo_vis_vumeter), will appear as a choice when using Layout Editing Mode to add a panel in the element group "Playback Visualisation."

If oops said he doesn't want to discuss CUI please let it go at that and ask someone in the CUI group, we don't need another disappearing developer (Crossover).

I don't have a problem in case this functionality is not implemented yet, but apparently it is, so I am quite confused.

But alas, since no one has reported finding the "easter egg," I moved the feature from behind the lock a few days ago [and finding the easter egg now unlocks something else]. If you're not seeing it when using the latest version, then I cannot help

• Starting with 0.6.0, you can use this component as a Columns UI panel without unlocking the easter egg.
• 0.6.0 also allows using the WARP rasterizer for virtual machines and the like which do not have a DirectX 12 adapter. However, you need to download the DLL (d3d10warp.dll) from NuGet since I'm not allowed to distribute it. Plus, for security reasons that is best. Place the DLL beside foo_vis_vumeter.dll.
• 0.7.2 is the result of a massive cleanup and reordering of the renderer to be able to have Direct3D elements on top of Direct2D and/or DirectWrite elements.
• 0.6.0 adds reading of RAR archives that contain a BIN file and INI file. 0.7.2 adds ability to override the background color through the INI file to go with 0.6.7's ability to control other settings such as the layout.
• BIN files could be compressed using BZIP2 and LZMA from the start. But if you desire now, also GZip (0.7.2), ZStandard (0.6.0), LZ4 (0.7.2). And all algorithms support concatenating the left/top with the right/bottom panels (using the `cat` command).
• Fixed stuck LEDs, in case you saw that bug prior to 0.6.0.
• 0.6.7 adds a frame counter and video freeze to the "Options" menu.
• There is a new easter egg in case any of you feel like a challenge.

EDIT2: One of the things I don't like is that the your component overwrites the old component, which makes it very hard to test since you cannot compare the old and new component running side by side.

VU Meter (DirectX12) CUI seems to have a one size fits all approach, compared to the old VU Meter.

It also doesn't seem to save settings on exit as I have to set it up again every time I reboot fb2k. (I did not show this behavior in the video)

class DUIPanel : public ui_element_instance, public CWindowImpl<DUIPanel>
{
public:
	ui_element_config::ptr get_configuration() final
	{

	}

	void set_configuration(ui_element_config::ptr data) final
	{

	}

private:
	ui_element_instance_callback::ptr m_callback;
};

Instance data is saved inside theme.fth for default UI.

If you're using cfg_XXX or the configStore APIs inside these then you've seriously fucked up.

Instance data is saved inside theme.fth for default UI.

If you're using cfg_XXX or the configStore APIs inside these then you've seriously fucked up.

Quote from: Defender on 2024-11-22 21:28:40

EDIT2: One of the things I don't like is that the your component overwrites the old component, which makes it very hard to test since you cannot compare the old and new component running side by side.

You can absolutely compare the two versions running side-by-side on the x86 build. Just rename one component folder and DLL to something different. For example I renamed the old component <user components folder>/foo_vis_vu_meter/foo_vis_vu_meter.dll. Been running like that ever since I was able to decode the BIN format.

Quote from: Majestyk on 2024-11-29 04:35:20

VU Meter (DirectX12) CUI seems to have a one size fits all approach, compared to the old VU Meter.

It also doesn't seem to save settings on exit as I have to set it up again every time I reboot fb2k. (I did not show this behavior in the video)

Settings are saved in 0.7.2. Just tested. I stared at the video for a long time trying to decipher what you're doing. Let me try to put it into words and note that what follows applies equally to DUI and CUI: you seem to have several instances running at the same time--more than 2. foobar2000 keeps the configuration in a SQLite database. So, I only hold 2 different sets of configuration settings at runtime because that is generally what fits in a single entry (unless I use blobs which was a pain in foo_vis_milk2 so decided to avoid that here). Basically ping-pong'ing between each new opened instance using the instance id modulo 2 to pick. Settings are then saved in the order of closing; last wins. But since "I think" you have more than 2 running at the same time, you might be saving one of the hidden windows depending on how foobar2000 is pumping the WM_DESTROY messages on exit. Fullscreen is special because in DUI it is associated with a non-fullscreen window which is a completely separate window from the embedded or undocked window which is a huge pain. Oh, and foobar2000 leaks memory when you create new panels; specifically in the settings/preferences data--it is in the proprietary player code--so don't go too crazy.
Surely I got something wrong in my interpretation of what's happening, but your use case is simply not something I envisioned. My setup is less visually impressive.