91
MP3 - General / Re: Resurrecting/Preserving the Helix MP3 encoder
Last post by maikmerten -There are further patches on the dev branch (Case's reworked progress printing, improved help messages, some safeguards against negative array indices in the encoder math), but nothing that invalidates the current builds.
edit: For those wondering why the dev branch isn't yet merged to the main/stable branch: I'm still trying to figure out why *downsampling* doesn't appear to work (in either main or dev). For instance, when requesting downsampling a 44.1 kHz input file to 32 kHz (hmp3 -A32000 test.wav test.mp3), the encoder goes haywire and crashes/segfaults. That's because when computing some array indices in l3math.c, the indices can get negative (the dev-branch guards against those negative array indices). However, that's most likely because the encoder is fed invalid audio data (with the negative-indices guards in place, I get silent mp3 files) and I haven't properly investigated out what's going on there.