Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: NEW ESLyric v0.5 - an alternative lyric show component (Read 33750 times) previous topic - next topic
ngs428 and 1 Guest are viewing this topic.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #75 –
Quote from: sveakul on
As I mentioned previously the metallum.js that comes with 1022's super pack of searcher downloads was written to require an Album title to work, which means it will not function on 99% of radio streams.  Attached is my own mod again that strips that requirement but this time I changed the internal header to not conflict with the supplied version on the sources list and also the file name--a dumb omission on my part previously  :-[ .  Now you can just have both and check/un-check as you will.
https://github.com/ESLyric/feedback/issues/115#issuecomment-1774797322
“Please issue a PR instead, thanks.  ”   This is what the author recommends.
https://github.com/ESLyric/scripts/pulls

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #76 –
Quote from: always.beta on
https://github.com/ESLyric/feedback/issues/115#issuecomment-1774797322
“Please issue a PR instead, thanks.  ”   This is what the author recommends.
https://github.com/ESLyric/scripts/pulls
Thanks always.beta for your reply.  I am uncomfortable with the level of involvement required in creating github "pull requests" (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) and will be sticking with just normal support requests/comments on your github "feedback" area.  TT already commented there on the metallum issue I described and I'll leave it between him and yourself as to whether to carry it any further offically.  I'm perfectly satisfied just using the mod version when dealing with streams.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #77 –
Actually I did not check IF it is the same when removing the album title from the search query but I thought the search results would have better accuracy when it is included
( did not have streams in mind when wrote it ), see here: https://www.metal-archives.com/search/advanced/?searchString=&type=band_name.
If you click on the "Search Songs" tab there is "Release type" ( album, ep, single etc. ) and "Release title" ( the album title sveakul removed ).

If @sveakul can check and confirm on two/three examples that it has the same search results and it fetches the right lyrics,
I can remove it and make a PR. But the majority will not use it for radio streams.

Also if ttsping could make an ESLyric callback that returns if current playback is streaming or not, we could make an if conditional
and merge and use both versions...

-TT

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #78 –
Thanks for the comments.  I believe that metallum.js is unique among the ESLyric scripts in requiring an album title field to match lyrics.  It's similar to the past situation with foo_openlyrics where folks started commenting about never getting a hit with streams from its Musixmatch searcher and it turned out it was because that source had been scripted to require an album title.  Unlike ESLyric where the searcher scripts can be user modified, this is not the case with OpenLyrics and the developer released a new version (1.7+) which removed that requirement for Musixmatch.

People who are using the release metallum.js only with music files including album title metadata in cases where a different release type affected a track title's lyrics, and the site chose to provide those changes in its search results, will need the original metallum.js to provide those results.  On the other hand, people who expect lyric results from the metallum site when listening to radio streams will be disappointed, since 99% of streams do not send album title in their metadata and therefore the searches will fail.

The "quickest" solution is to just provide an alternate mod version of the searcher that doesn't require an album title, while keeping the original for those using music files who may benefit from being able to specify a release type or album title variance.  Granted, the "callback" method would be coolest but require additonal work from the developer.  Here I'm happy with "quickest", already in use.

THANK YOU to both TT and ttsping for the volume of new searchers!

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #79 –
Quote from: sveakul on
Quote from: sveakul on
Note that like with Song Lyrics, which if providing a match may say "We don't have the lyrics for this song yet,"  metallum will do something similar, returning "<em>(lyrics not available)</em>" if the search matches a song at the site but hasn't had lyrics supplied.  In both cases, ESLyric will stop the search progression as if it has supplied lyrics, so keep those sources below others like Genius to ensure best results.
This issue is now manageable with version 1022 by using the Lyric Processor to add wildcard lines that cause the lyrics to be rejected and the searching to continue.  Tested with the Song Lyrics "We do not have the lyrics for.." line which occurs when that site has a reference to the song but not the lyrics.  THANKS, always.beta!
Sorry, that info is wrong.  Apparently those lines are not considered part of the lyrics body so adding them to Lyric Processor has no effect.  I jumped to that conclusion for Song Lyrics on a mis-test.  Searching will indeed stop after results show the "We do not have the lyrics for (song) yet."  This also occurs with OpenLyrics when its metallum searcher returns the (lyrics not available) line.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #80 –
On streaming radio I have been noticing a large amount of lyric hits using ESLyric from the MiniLyrics version .5 searcher that show results bearing no relationship at all to the actual song except for the title.  Taking a look at the script in Notepad I noticed that it is designed to include an Album name in the search, which of course is almost never included in radio stream metadata.  This reflects the situation with the Metallum script, which I commented on earlier in this thread and posted a mod no-album version of the script (https://hydrogenaud.io/index.php/topic,122571.msg1034620.html#msg1034620) for optional use.

I made the same type of modification to the as-is minilyrics.js script and moved it to the top of my searcher list to test with radio streams and haven't had a bad hit yet.  I have attached it here for others who can add it to the ...profile\eslyric-data\scripts\searcher directory then select it optionally in your ESLyric Lyric Sources list.  It has an altered name both file-wise and internally so you won't confuse it with the existing script, which can still be used if you want or un-checked.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #81 –
タイトルに"."(dot)があるとローカル全てのファイルにヒットします。
Search Settingで"."が他のファイルにヒットしないようにできますか？

Please provide English translation in future posts.
TOS 10. All members must post in English. Content in other languages allowed as long as full English translations are provided, or otherwise at the discretion of the staff.

Google Translation:
If there is a "." (dot) in the title, all local files will be hit. Is it possible to prevent "." from hitting other files in Search Settings?

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #82 –
If the title has "." (dot) in the title will hit all local files.
Is it possible to prevent "."(dot) from hitting other files in Search Setting? in the Search Setting so that it does not hit any other files?

For example, if the title is "R.I.P." and ". is removed, it becomes "RIP",
For example, when the title is "R.I.P.", if I delete the ".", it becomes "RIP", but when I search for "RIP", it does not match with files registered with "R.I.P.".
When I search for "R.I.P.", it matches files registered with "R.I.P.", but when I search for "R.I.P.", it does not match files registered with "R.I.P.",
If the title is still "R.I.P.", it will match other local files.
Lyric Show 3 will not match other local files even if the title is still "R.I.P.".

----------------------------------------------------------
タイトルに「.」(dot)があるとローカル全てのファイルにヒットします。
Search Settingで「.」が他のファイルにヒットしないようにできますか？

例えば、タイトルが「R.I.P.」のとき「.」を削除すると「RIP」になりますが、
「RIP」で検索すると「R.I.P.」で登録されているファイルとマッチングしません。
「R.I.P.」で検索すると「R.I.P.」で登録されているファイルとマッチングしますが、
タイトルが「R.I.P.」のままだと、ローカルの他のファイルとマッチングしてしまいます。
Lyric Show 3はタイトルが「R.I.P.」のままでもローカルの他のファイルとマッチングしません。

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #83 –
Quote from: michi777 on
If the title has "." (dot) in the title will hit all local files.
Is it possible to prevent "."(dot) from hitting other files in Search Setting? in the Search Setting so that it does not hit any other files?
What is the filename template for your local lyrics save?

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #84 –
What does "filename template" mean?
I want to leave the file name of the local lyrics unchanged.

Do you mean "file name:  [%artist% - ]%title%" ?

-----------------------------------------
「filename template」とは何のことですか？
ローカル歌詞のファイル名は変更しないでそのままにしたいのですが？

「file name: [%artist% - ]%title%」のことですか？

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #85 –
Quote from: michi777 on
Do you mean "file name:  [%artist% - ]%title%" ?
Lyrics source-local file-configuration, search file name template is consistent with saved file name, did not encounter the problem you said.  You can take a screenshot of the caption.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #86 –
Quote from: always.beta on
Quote from: michi777 on
Do you mean "file name:  [%artist% - ]%title%" ?
Lyrics source-local file-configuration, search file name template is consistent with saved file name, did not encounter the problem you said.  You can take a screenshot of the caption.
The title has a "." in the title, and searching as is will match all local lyrics.
The file name of the local lyrics does not matter.

タイトルに「.」があり、そのまま検索するとローカルの歌詞全てに一致します。
ローカルの歌詞のファイル名は関係ありません。

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #87 –
Quote from: michi777 on
The title has a "." in the title, and searching as is will match all local lyrics.
I also have some songs whose artists contain dot (.) symbols. The lrc lyrics file is saved locally with the file name: [%artist% - ]%title%. The search template is also: [%artist% - ]%title%. It works. Normal matching, no problem as you encountered. You'd better take a screenshot to explain.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #88 –
Often the lyrics do not correspond to the current track, for example the lyrics of the previous song are shown, with time stamps, but another one is played. How to force updating and compliance?

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #89 –
Quote from: Mrakobes on
Often the lyrics do not correspond to the current track, for example the lyrics of the previous song are shown, with time stamps, but another one is played. How to force updating and compliance?
This is the first time I've ever seen someone respond to a question like this. You've provided too little information to reproduce.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #90 –
I understand that there is little information, but I do not know what I could add to this? There is no dependence on events, just the next track is playing, and the lyrics are spinning from the previous one. Does not switch to a new one... An extension of the latest version, the player too

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #91 –
And how I would like the source to be displayed in the panel!!! Users have been waiting for this for many years. I see how well the profile resources work - the early lyrics were complete shit - now I'm saving all the texts, in connection with this confusion - I need a source in the panel header

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #92 –
Quote from: Mrakobes on
And how I would like the source to be displayed in the panel!!! Users have been waiting for this for many years. I see how well the profile resources work - the early lyrics were complete shit - now I'm saving all the texts, in connection with this confusion - I need a source in the panel header
The source is displayed when you right-click the panel and choose "Lyric information", where the source is displayed on the 3rd line; all the lyrics can also be copied from this window.  By adding a hotkey to the "Lyric Information" window (must be done while ESLyric is active) you can display the source in one click:

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #93 –
In Search, if there is "feat." in the title and "-" after it, only until "-" is deleted.
Is it possible to delete everything after "feat."?

Searchでタイトルに"feat."があってそれ以降に"-"があると"-"までしか削除されません。
"feat."以降全てを削除できないでしょうか？

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #94 –
Quote from: michi777 on
In Search, if there is "feat." in the title and "-" after it, only until "-" is deleted.
Is it possible to delete everything after "feat."?
Search settings, customize, adjust rules according to your title format, like this:
$left(%title%,$sub($strchr(%title%,'(feat'),1))

 Or the first rule of the field below, modify it to suit you, because everyone's song name rules are inconsistent.

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #95 –
Quote from: always.beta on
Quote from: michi777 on
In Search, if there is "feat." in the title and "-" after it, only until "-" is deleted.
Is it possible to delete everything after "feat."?
Search settings, customize, adjust rules according to your title format, like this:
$left(%title%,$sub($strchr(%title%,'(feat'),1))

 Or the first rule of the field below, modify it to suit you, because everyone's song name rules are inconsistent.

Thank you.
I can custom search fields.
But,I don't know how to use <Field processing>

Operation : Regax remove string
Parameter 1 : $left(%title%,$sub($strchr(%title%,'feat'),1))
Parameter 2 : <None>

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #96 –
Quote from: michi777 on
Quote from: always.beta on
Quote from: michi777 on
In Search, if there is "feat." in the title and "-" after it, only until "-" is deleted.
Is it possible to delete everything after "feat."?
Search settings, customize, adjust rules according to your title format, like this:
$left(%title%,$sub($strchr(%title%,'(feat'),1))

 Or the first rule of the field below, modify it to suit you, because everyone's song name rules are inconsistent.

Thank you.
I can custom search fields.
But,I don't know how to use <Field processing>

Operation : Regax remove string
Parameter 1 : $left(%title%,$sub($strchr(%title%,'feat'),1))
Parameter 2 : <None>


Sorry I can.
Operation : Regax remove string
Parameter 1 : \s?feat.*
Parameter 2 : <None>

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #97 –
I want to change '词' to '詞' in Lyric Processor, but it is not converted.
Is there something else I need to specify?

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #98 –
Quote from: michi777 on
I want to change '词' to '詞' in Lyric Processor, but it is not converted.
Is there something else I need to specify?
Unable to reproduce your problem, please provide lyrics component version + settings screenshots + song and lyrics samples.
 

Re: NEW ESLyric v0.5 - an alternative lyric show component

Reply #99 –
Quote from: always.beta on
Quote from: michi777 on
I want to change '词' to '詞' in Lyric Processor, but it is not converted.
Is there something else I need to specify?
Unable to reproduce your problem, please provide lyrics component version + settings screenshots + song and lyrics samples.

ESLyric v0. 5.4.1028 (Beta) for foobar2000

Attached is a screenshot of the Lyric Processor settings and the lyrics.
Sorry, I could not attach the song as it is an mp3.