Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1374011 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_discogs

Reply #3150
Component still functions completely fine for me.

Re: foo_discogs

Reply #3151
Thanks for this modernized component

You are welcome  :)

New release v1.0.18 is now available.

This new release contains a new disc/track position parsing algorithm.
It's been rewritten from scratch, some tuning might be needed.

Thanks for testing!

Re: foo_discogs

Reply #3152
For me it seems hit or miss right now, getting the tags written the way i want - or i'm not getting the meaning of the preview window with it's result, difference and original view... at least it's not writing what i'm expecting and set up once. i don't even know how to describe, as i'm not getting what it's doing!?

It shows the result - fine.
It shows the difference to the original tags - even more fine but why is it different to the result?
It writes the result and not the difference... i'm more than confused! See album artist and date for example. I just don't get whats going on here.

(1) file with "original tags"
(2) results after fetching the release from discogs
(3) viewing the differences to original tags (seems the way i want it > "album artist" not as multi value, year 4 digits)
(4) written tags > equivalent to fetched results and not to differences


Edit: Is it that i have to set all tags to "write & update" first and i never noticed it before, cause i was used to delete all tags before tagging with foo_discogger?

Re: foo_discogs

Reply #3153
The preview panel has become hardcore, I know.

All in all, I believe it works.

The Difference View together with the stats option it's mainly aimed to warn you about what differentiates your local tags from Discogs info after taking into consideration the tag mapping definitions (write, update, w/u).

Could you post a screenshot with the stats option turned on before and after writing the tags? It will show which values are being written, updated or skipped.  :-\

Re: foo_discogs

Reply #3154
Thanks for getting back to me that fast. I guess my latest experience came from being way too lang away from tagging my collection and using the last versions of foo_discogger. ;-) Of course it's still a strong tool and time to say thanks again. My troubles seem to come from not erasing all tags first (for a clean start) like i used to do back then. I guess (not tried yet), if i set all tags to "write & update" not only "write" like they are now, it may work as expected (at least seems logic to me now). :-D

Just for supporting a little bit here are the requested screenshots. Oh my dear, i wasn't aware of the stats columns until i maximized the preview window! :-D

Re: foo_discogs

Reply #3155
Write & update is the master key to most issues lately : D

You are welcome and thank you also for your support!

And of course thanks to Bubleguuum and Zoomorph and all collaborators for creating the best and most powerful tagging tool ever.
 :) 

Re: foo_discogs

Reply #3156
No matter what release i choose, but tagging "Paul Van Dyk - The Politics Of Dancing 3" always crashes foobar as soon as hitting preview or write. It's not the file, which can get tagged as another release just fine. ;-)

Re: foo_discogs

Reply #3157
Wondering if it's the ginormous list of "Published by" credits, which surely should be track-by-track rather than for the whole release.
Have you tried tagging it with one of the other versions, which don't split the mix CD up into sub-indexes? (You probably don't want to! Just thought I'd ask.)

Re: foo_discogs

Reply #3158
Wondering if it's the ginormous list of "Published by" credits, which surely should be track-by-track rather than for the whole release.
Have you tried tagging it with one of the other versions, which don't split the mix CD up into sub-indexes? (You probably don't want to! Just thought I'd ask.)

i tried it with https://www.discogs.com/de/release/7030479-Paul-van-Dyk-The-Politics-Of-Dancing-3 too (no sub-index)> same result, crashing. Also https://www.discogs.com/de/release/17194369-Various-Intricate-Sessions-Vol-02 not working (this one has sub-index again).

Re: foo_discogs

Reply #3159
@frogworth, @alexinc

Nice catch alexinc!   :)

None of the releases I've chosen to test the new disk/track detection mod (from v1.0.18) had indexed master releases.
I tested both Paul van Dyk releases without crashing foobar, so it should be fixed now.

foo_discogger v1.0.18.1




Re: foo_discogs

Reply #3160
Wow, that's what i call a fast delivery! Thanks. ;) With Paul Van Dyk's release it's working, but with the second example the index track title seems to get fetched within the track title now. :) I'm just getting warm... :D

Re: foo_discogs

Reply #3161
Wow, that's what i call a fast delivery! Thanks. ;) With Paul Van Dyk's release it's working, but with the second example the index track title seems to get fetched within the track title now. :) I'm just getting warm... :D

 :))

$if(%TRACK_INDEXTRACK_TITLE%,%TRACK_SUBTRACK_TITLE%,%TRACK_TITLE%)

Not sure if that would work in most cases as the TITLE expression though.

Re: foo_discogs

Reply #3162
Wow, that's what i call a fast delivery! Thanks. ;) With Paul Van Dyk's release it's working, but with the second example the index track title seems to get fetched within the track title now. :) I'm just getting warm... :D

 :))

$if(%TRACK_INDEXTRACK_TITLE%,%TRACK_SUBTRACK_TITLE%,%TRACK_TITLE%)

Not sure if that would work in most cases as the TITLE expression though.

That's too easy and the basics of file tagging. ;) I'll see the next days. :)

Re: foo_discogs

Reply #3163
New version available including some Preview panel revisions:

   - 'Write selected tag' support for multiple selections.
   - 'Force Write & Update selected tags' new context menu option.

foo_discogger v1.0.19

Re: foo_discogs

Reply #3164
New version available including some Preview panel revisions:

   - 'Write selected tag' support for multiple selections.
   - 'Force Write & Update selected tags' new context menu option.

foo_discogger v1.0.19


Backup the settings of your tag mappings before upgrading. it reset/messed mines completely.

Re: foo_discogs

Reply #3165
Import of tm-file doesn't work either > "(skipped) Error: Error importing tags: Unsupported format or corrupted file [ESCAPE to close]". File was exported with 1.0.19.

Re: foo_discogs

Reply #3166
Import of tm-file doesn't work either > "(skipped) Error: Error importing tags: Unsupported format or corrupted file [ESCAPE to close]". File was exported with 1.0.19.

NVM! i just noticed i had a typo in one of my re-applied formatting strings and importing seems to check for correct strings? at least after fixing the formatting string, importing that saved file works! :)

 

Re: foo_discogs

Reply #3167
@alexinc

Yes, only some tag names were triggering this error...
v1.0.19 started saving tag mapping GUIDS and the component was failing to detect when map files were already upgraded.

Still don't have a proper explanation about what was causing it.
This quick fix should solve the issue.

Thanks for reporting!  :)


foo_discogger v1.0.19.1

Re: foo_discogs

Reply #3168
@alexinc

Yes, only some tag names were triggering this error...
v1.0.19 started saving tag mapping GUIDS and the component was failing to detect when map files were already upgraded.

Still don't have a proper explanation about what was causing it.
This quick fix should solve the issue.

Thanks for reporting!  :)


foo_discogger v1.0.19.1


confirmed, settings are kept now again.

one more thing i'm failing now, after having rebuild all formatting string... when trying to set %comment% to $unique(%<RELEASE_LABELS_NAME>%): %<RELEASE_LABELS_CATALOG_NUMBER>% i'm always getting error "Error generating tag COMMENT [Tried decoding corrupt string: embedded start]"!? got it working once, but with the next attempt it's failing again. my fault or bug? ;)

Re: foo_discogs

Reply #3169
I believe you need to join the two arrays:

$zip($join(%<RELEASE_LABELS_NAME>%),': ',$join(%<RELEASE_LABELS_CATALOG_NUMBER>%))

Not sure about the $unique part. Please provide some release ID to test multiple values on it if you can.
... or maybe post your solution if you sort it out already :))

Re: foo_discogs

Reply #3170
"Error generating tag COMMENT [Tried decoding corrupt string: embedded start]"!? got it working once, but with the next attempt it's failing again...
Even though it's not likely the cause of your issue, it's worth repeating to those new to the component, don't select [master] releases from the Releases: section of the Find Release window
Neither an audiophile, nor album snob. Why do ratings threads always have someone saying they don't believe in rating music?
Record Label Icons: 600x600 pngs appropriate for any color background:
freeimage.host/johnbuck/?list=images&sort=name_asc&page=1

Re: foo_discogs

Reply #3171
@JohnBuckWLD

Aye... whatever you do... Don't push that button!  :))

A new quick fix is available, still fixing the mess of introducing tag mapping GUIDs too early, should have been included in the forthcoming v1.0.20...

foo_discogger v1.0.19.2


Re: foo_discogs

Reply #3172
Question about the new matching system...

In this release Fall Of Because – Life Is Easy
the last two tracks have multiple titles (10a, 10b, etc..)
I tried with the merge hidden tracks and all I managed to get was



There is something I must change in the setting to get the main title and the a,b,c,... merged?

Re: foo_discogs

Reply #3173
There is no option but a manual merge.
Maybe just discard the first 10 and 11 and fix it in the Preview panel?

Most hidden tracks I merge comply with 12.17.2 use of Hidden tracks.
I am not sure about r1271656 nor if it will be worth the extra elaboration.

Re: foo_discogs

Reply #3174
I believe you need to join the two arrays:

$zip($join(%<RELEASE_LABELS_NAME>%),': ',$join(%<RELEASE_LABELS_CATALOG_NUMBER>%))

Not sure about the $unique part. Please provide some release ID to test multiple values on it if you can.
... or maybe post your solution if you sort it out already :))

so far it's working fine for all tested releases, no need to investigate another solution yet. ;-) tagging strong the last days! :-D