Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1365060 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_discogs

Reply #3050 –
Hi @da yuyu I found a problem with a pair of releases.

Various – The Shadows In Thy Glimpse: Bedouin Records Selected Discography 2016​-​2018
and
Various – Serpent Made of the Snake's Desire: Bedouin Records Selected Discography 2014​-​2016

The component find the releases but when I tried to tag the files nothing happened and the menu to write tag became gray and can not tag any other release.

The console said

Code: [Select]
foo_discogger: https://api.discogs.com/releases/18202627
foo_discogger: Url OAuth enabled
foo_discogger: RateLimit: 60 - Used: 1 - Remaining: 59 - not throttling images

Only way to continue using the component is closing the program

Re: foo_discogs

Reply #3052 –
Thanks @da yuyu!
I was confused initially with this release because it seems like you have to double click on the artist name to get it to load the releases. Is there a way to make it automatic upon selection of the artist, like it was before?

I also had a crash. If that happens again I'll send the crash report.

Re: foo_discogs

Reply #3053 –
Hi @frogworth,

Yes, it interrupts the workflow.

Same sort of thing as the filter auto-fill that took me a while to figure out and which solution was trivial.

As you know the secondary requirement is to avoid loading artist releases when user doesn´t expect it to be done, for my own part, while browsing through artist profiles, or when there is no exact match in the artist search and the first artist in the list published have hundreds of releases.
It should be fixed fairly soon.

Thanks for testing
Regards

Re: foo_discogs

Reply #3054 –
Quote from: lvqcl on
I only enabled Client part of TLS (see below), and foo_discogs now works, thanks!

Code: [Select]
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.1\Client]
"DisabledByDefault"=dword:00000000

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client]
"DisabledByDefault"=dword:00000000


P.S. Yet another reminder that Windows 7 is not exactly an up-to-date system.

Quote from: stevehero on


Quote from: lvqcl on
Code: [Select]
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.1\Client]
"DisabledByDefault"=dword:00000000

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client]
"DisabledByDefault"=dword:00000000

 Thanks, that worked. Just copied the code above into a 'filename.reg' file and run it to add to the registry.


Yaay!  This worked.  Long story short, never had an issue with Win 10, but my company dictated I could no longer use my laptop at work to play music, so I brought in my Win 7 laptop from home (yeah  ...  *that's* secure ...  <rolleyes>), and the Discogs tagger wouldn't work.  Now it does.  :D  Thank you!!

Re: foo_discogs

Reply #3055 –
Hey @da yuyu I'm finding that with the latest discogger I'm getting crashes all the time during tagging. The music glitches and then it crashes.
Quote
Illegal operation:
Code: C0000005h, flags: 00000000h, address: 137E3583h
Access violation, operation: read, address: 00000040h

Call path:
threaded_process thread

Code bytes (137E3583h):
137E3543h:  A5 A5 A5 A5 89 01 8B 4D 10 85 C9 74 05 8B 01 FF
137E3553h:  50 04 8D 85 28 FC FF FF 50 E8 C2 03 00 00 8D 8D
137E3563h:  28 FC FF FF E8 0A 43 FC FF EB 36 8B 8D E0 FC FF
137E3573h:  FF 8B 45 10 56 8B 75 28 83 EC 10 8B FC 8D 34 31
137E3583h:  A5 51 8B CC A5 A5 A5 89 01 8B 4D 10 85 C9 74 05
137E3593h:  8B 01 FF 50 04 8D 85 B4 FC FF FF 50 E8 7F 03 00
137E35A3h:  00 8D 8D B4 FC FF FF E8 C7 42 FC FF 8D 8D 88 FC
137E35B3h:  FF FF C6 45 FC 0F E8 32 42 04 00 8B BD DC FC FF

Stack (2A24EF1Ch):
2A24EEFCh:  FFFFFD34 000002EC FFFFFD34 000002CC
2A24EF0Ch:  00000021 00000000 138EA03F 00000004
2A24EF1Ch:  137E374B 137E34E2 2A24F058 35B24010
2A24EF2Ch:  37A7036C 81B78FF0 2A24F860 00000000
2A24EF3Ch:  37A70360 2A24F040 7758C39C 00000080
2A24EF4Ch:  00000000 138FBD64 138FBD80 00000000
2A24EF5Ch:  00000000 00000000 77672700 774ED1C8
2A24EF6Ch:  146509D0 146509D4 146509D4 00000016
2A24EF7Ch:  139011CC 2A24F860 00000000 00000000
2A24EF8Ch:  2A24EFE8 2A24F444 00000000 00000000
2A24EF9Ch:  00000000 139011A8 37A70360 00000000
2A24EFACh:  00000000 00000000 37C250A8 00000000
2A24EFBCh:  14650A20 14650A24 14650A24 00000016
2A24EFCCh:  00000000 00000000 2A24F838 14650B00
2A24EFDCh:  14650B04 14650B04 00000016 37D4BC14
2A24EFECh:  37D4BC08 00000040 FFFFFFFD 00000001
2A24EFFCh:  00000000 00000000 138FBD64 138FBD80
2A24F00Ch:  00000000 00000000 00000000 00000000
2A24F01Ch:  2A24F858 138FBD64 138FBD80 00000000
2A24F02Ch:  00000000 00000000 00000000 00000020

Registers:
EAX: 0E990EA8, EBX: 37A70360, ECX: 00000040, EDX: 138FA620
ESI: 00000040, EDI: 2A24EF1C, EBP: 2A24F3A4, ESP: 2A24EF1C

Crash location:
Module: foo_discogger
Offset: 43583h

Stack dump analysis:
Address: 137E374Bh (foo_discogger+4374Bh)
Address: 137E34E2h (foo_discogger+434E2h)
Address: 7758C39Ch (ntdll+AC39Ch), symbol: "fltused" (+9D708h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD80h (foo_discogger+15BD80h), symbol: "foobar2000_get_interface" (+CEFA0h)
Address: 77672700h (ntdll+192700h), symbol: "NlsAnsiCodePage" (+AFCh)
Address: 774ED1C8h (ntdll+D1C8h), symbol: "wcstoul" (+6A58h)
Address: 139011CCh (foo_discogger+1611CCh), symbol: "foobar2000_get_interface" (+D43ECh)
Address: 139011A8h (foo_discogger+1611A8h), symbol: "foobar2000_get_interface" (+D43C8h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD80h (foo_discogger+15BD80h), symbol: "foobar2000_get_interface" (+CEFA0h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD80h (foo_discogger+15BD80h), symbol: "foobar2000_get_interface" (+CEFA0h)
Address: 7700A3C0h (ucrtbase+A3C0h), symbol: "strcmp" (+0h)
Address: 77591354h (ntdll+B1354h), symbol: "fltused" (+A26C0h)
Address: 13906480h (foo_discogger+166480h), symbol: "foobar2000_get_interface" (+D96A0h)
Address: 77591354h (ntdll+B1354h), symbol: "fltused" (+A26C0h)
Address: 77672A80h (ntdll+192A80h), symbol: "NlsAnsiCodePage" (+E7Ch)
Address: 77590A6Ch (ntdll+B0A6Ch), symbol: "fltused" (+A1DD8h)
Address: 77539D8Ch (ntdll+59D8Ch), symbol: "fltused" (+4B0F8h)
Address: 77591354h (ntdll+B1354h), symbol: "fltused" (+A26C0h)
Address: 77672A80h (ntdll+192A80h), symbol: "NlsAnsiCodePage" (+E7Ch)
Address: 77539D8Ch (ntdll+59D8Ch), symbol: "fltused" (+4B0F8h)
Address: 77591354h (ntdll+B1354h), symbol: "fltused" (+A26C0h)
Address: 77176000h (ucrtbase+176000h), symbol: "EH_prolog" (+5830h)
Address: 77672A80h (ntdll+192A80h), symbol: "NlsAnsiCodePage" (+E7Ch)
Address: 7761D304h (ntdll+13D304h), symbol: "fltused" (+12E670h)
Address: 7761D304h (ntdll+13D304h), symbol: "fltused" (+12E670h)
Address: 77176000h (ucrtbase+176000h), symbol: "EH_prolog" (+5830h)
Address: 774E1BB0h (ntdll+1BB0h), symbol: "RtlAcquireSRWLockExclusive" (+0h)
Address: 6B720DD1h (MSVCP140+30DD1h), symbol: "Concurrency::details::_ReportUnobservedException" (+321h)
Address: 137B928Bh (foo_discogger+1928Bh)
Address: 6B707B09h (MSVCP140+17B09h), symbol: "Thrd_yield" (+D9h)
Address: 137B928Bh (foo_discogger+1928Bh)
Address: 6B7211F6h (MSVCP140+311F6h), symbol: "_crtIsPackagedApp" (+36h)
Address: 6B7211F6h (MSVCP140+311F6h), symbol: "_crtIsPackagedApp" (+36h)
Address: 6B707D50h (MSVCP140+17D50h), symbol: "Thrd_yield" (+320h)
Address: 6B707D59h (MSVCP140+17D59h), symbol: "Thrd_yield" (+329h)
Address: 138E7932h (foo_discogger+147932h), symbol: "foobar2000_get_interface" (+BAB52h)
Address: 137CE865h (foo_discogger+2E865h)
Address: 137E4289h (foo_discogger+44289h)
Address: 138E9FEDh (foo_discogger+149FEDh), symbol: "foobar2000_get_interface" (+BD20Dh)
Address: 137E2A72h (foo_discogger+42A72h)
Address: 137E2A00h (foo_discogger+42A00h)
Address: 139011CCh (foo_discogger+1611CCh), symbol: "foobar2000_get_interface" (+D43ECh)
Address: 774F2030h (ntdll+12030h), symbol: "fltused" (+339Ch)
Address: 139011A8h (foo_discogger+1611A8h), symbol: "foobar2000_get_interface" (+D43C8h)
Address: 77537D38h (ntdll+57D38h), symbol: "fltused" (+490A4h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 77674000h (ntdll+194000h), symbol: "NlsAnsiCodePage" (+23FCh)
Address: 13906480h (foo_discogger+166480h), symbol: "foobar2000_get_interface" (+D96A0h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 77116824h (ucrtbase+116824h), symbol: "wctype" (+101CB4h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138FBD64h (foo_discogger+15BD64h), symbol: "foobar2000_get_interface" (+CEF84h)
Address: 138E9EBAh (foo_discogger+149EBAh), symbol: "foobar2000_get_interface" (+BD0DAh)
Address: 137FEF5Eh (foo_discogger+5EF5Eh)
Address: 77176BD0h (ucrtbase+176BD0h), symbol: "mbcasemap" (+78h)
Address: 138FBDF8h (foo_discogger+15BDF8h), symbol: "foobar2000_get_interface" (+CF018h)
Address: 138FBDF8h (foo_discogger+15BDF8h), symbol: "foobar2000_get_interface" (+CF018h)
Address: 138ED116h (foo_discogger+14D116h), symbol: "foobar2000_get_interface" (+C0336h)
Address: 137FE7A4h (foo_discogger+5E7A4h)
Address: 77176BD0h (ucrtbase+176BD0h), symbol: "mbcasemap" (+78h)
Address: 00C201FEh (foobar2000+101FEh)
Address: 138ECFE4h (foo_discogger+14CFE4h), symbol: "foobar2000_get_interface" (+C0204h)
Address: 00D2BF4Bh (foobar2000+11BF4Bh)
Address: 77176BD0h (ucrtbase+176BD0h), symbol: "mbcasemap" (+78h)
Address: 6BBF7276h (shared+7276h), symbol: "uCallStackTracker::uCallStackTracker" (+D6h)
Address: 00DE0DF0h (foobar2000+1D0DF0h)
Address: 77176BD0h (ucrtbase+176BD0h), symbol: "mbcasemap" (+78h)
Address: 00DBABA9h (foobar2000+1AABA9h)
Address: 00D2BF01h (foobar2000+11BF01h)
Address: 00DAA1F1h (foobar2000+19A1F1h)
Address: 77126798h (ucrtbase+126798h), symbol: "wctype" (+111C28h)
Address: 770628ECh (ucrtbase+628ECh), symbol: "wctype" (+4DD7Ch)
Address: 77176BD0h (ucrtbase+176BD0h), symbol: "mbcasemap" (+78h)
Address: 77062820h (ucrtbase+62820h), symbol: "wctype" (+4DCB0h)
Address: 7650012Ch (KERNEL32+1012Ch), symbol: "timeGetTime" (+97BCh)
Address: 77062820h (ucrtbase+62820h), symbol: "wctype" (+4DCB0h)
Address: 77566750h (ntdll+86750h), symbol: "fltused" (+77ABCh)
Address: 77566708h (ntdll+86708h), symbol: "fltused" (+77A74h)
Address: 76BEB6E0h (KERNELBASE+25B6E0h), symbol: "PackageSidFromProductId" (+2532E0h)
Address: 77622C3Ch (ntdll+142C3Ch), symbol: "fltused" (+133FA8h)
Address: 7766E044h (ntdll+18E044h), symbol: "RtlCaptureContext" (+E4h)
Address: 77062820h (ucrtbase+62820h), symbol: "wctype" (+4DCB0h)

Environment:
App: foobar2000 v1.6.11 beta 2
UI: Default User Interface 1.6.11 beta 2

Re: foo_discogs

Reply #3056 –
Yes, I also encountered new crashes running the current release. I temporarily focused on the Linux issues while doing some parsing code revisions and some of that code might have slipped out into v1.07... now track parsing will take all developing and testing efforts for the time being.

Thanks for your noticing

Re: foo_discogs

Reply #3057 –
Version 1.0.11 is now available for download.

Whats new:

    Some bug fixes related to multiple artist releases
    32/64 bits and dark mode (excl. artwork panel)

Re: foo_discogs

Reply #3060 –
I went through the steps on the UI to authorize the component. The test button says OAuth is working yet the console reports "foo_discogger: Url OAuth disabled" and obv I can't access Discogs with the component. Got it working!

Re: foo_discogs

Reply #3061 –
 ... verbose outputs to the console should be revised, OAuth disabled just tells about access to an url not needing it.

Discogger v1.0.12

Change log:

- Refurbished artwork panel (libPPUI drag and drop, dark mode)

Re: foo_discogs

Reply #3062 –
Hi
A quick fix has been released, with a fix for arwork columns not being saved.
Discogger v1.0.12.2:

Re: foo_discogs

Reply #3063 –
Hi, a new release is out... Discogger v1.0.13:

Whats new:

multi-artist artwork pre-loads (match track panel).
removed 'oauth disabled', 'throttle disabled' and image throttle console logs.
improved url data access saving artwork.

Re: foo_discogs

Reply #3064 –
Hi.
Re v1.0.14.8 - which I installed recently.
For me, this now formats incoming multi value fields as a single string values on flac files (due to, from what I see, a ";" instead of  "; " as an input separator).
i.e. it used to be this pre v1.0.14.8 (in foobar tag editor) [correctly getting set as 3 separate genre values]:
"UK Garage; Techno; Dubstep"
i.e. whereas it now  in v1.0.14.8 is set as this (in foobar tag editor) [incorrectly getting set as 1 single genre values with literal ";"s....]:
"UK Garage;Techno;Dubstep"

Is anyone else seeing this ?

Cheers.
c.

Re: foo_discogs

Reply #3065 –
(odd, I can't edit the above to add a ps. - so here as a new post...)
I rolled back to the last version I had downloaded - 1.0.13.1 - and with that foobar / foo_discogger formats the multi-value discogs genres & styles metadata correctly again into multiple fields.
Churs.
c.

Re: foo_discogs

Reply #3066 –
Hey @alec.tron yes I had noticed this too, but hadn't worked out what was going on! Thanks for raising it.

Re: foo_discogs

Reply #3067 –
Hi,
It works for me, the values are correctly separated. The separator is "; ", in Mp3tag it is "\\".
I bothered da yuyu with this on the previous version.  https://github.com/ghDaYuYu/foo_discogs/issues/79
It was doing this to me when I added a value manually. But now it works for me.
My version of Discogger is 1.0.14.8pv in Preferences > Components, with foobar 2.0 beta 12 x86.
I remapped to DISCOGS_GENRE and DISCOGS_STYLE. I always use the Preview window. Sometimes I add genres from another release.

 

Re: foo_discogs

Reply #3068 –
Quote from: Terence on
Hi,
It works for me, the values are correctly separated. The separator is "; ", in Mp3tag it is "\\".
I bothered da yuyu with this on the previous version.  https://github.com/ghDaYuYu/foo_discogs/issues/79
It was doing this to me when I added a value manually. But now it works for me.
hm, thanks for the info!
I switched back to the newest version, and added all fields that I deem possible to hold multi-value in the discogger & main pref (as per Da yuyu's recommendations in the git issue).
So they now look like:
Code: [Select]
ARTIST;ALBUM ARTIST;PRODUCER;COMPOSER;PERFORMER;GENRE;instruments;DISCOGS_RELEASE_GENRES;DISCOGS_STYLES;style;DISCOGS_RELEASE_CREDITS;DISCOGS_TRACK_CREDITS;DISCOGS_CREDIT_FEATURING;DISCOGS_ARTISTS_ALL_NAME_VARIATIONS;DISCOGS_ARTISTS_ALIASES;DISCOGS_ARTISTS_MEMBERS;DISCOGS_ARTISTS_INGROUPS;DISPLAY_ARTIST

But no luck. It's still writing my custom fields, DISCOGS_RELEASE_GENRES &  DISCOGS_STYLES in the example below (with the missing space, i.e. ";" instead of "; " to trigger foobars fields separation for flac/vorbis) as a single string.
Interestingly, in the preview pane, it gets' shown as correctly, and deemed to need to be written anew -  see:

But when written, these are still incorrect and get picked up in the preview pane as different indefinetely :/

Also, another observation - with mp3s/id3, all is fine with foo_discogger 1.0.14.8, and they come out with correct "; " seperators (in foobar) being written as a NUL seperator in file...

Oh well. Back to 1.0.13.1 I go.
No drama.

Churs.
c.

Re: foo_discogs

Reply #3069 –
Quote from: alec.tron on
Oh well. Back to 1.0.13.1 I go.
One side effect - when switching back - I now seem to have a new issue that I haven't had before, where this error is thrown:
"(skipped) Error: Image URLs unavailable - Is OAuth working?
(skipped) Error [Fetching small album art]: (empty url)

[ESCAPE to close]"
When tagging a release; even though OAuth works fine (with the small oddity that I need to reset the OAuth token when reverting to 1.0.13.1 from 1.0.14.8)

Just as info / observations.

Churs.
c.

Re: foo_discogs

Reply #3070 –
Hi, I´ve been reading from #3064...
I am not getting notified by mail of changes in this thread despite the fact that I am subscribed it. Sorry for the late response.

First of all, I would not recommend downgrading from v1.0.14.8 to any previous version, as 14.8 is by far the best (most bug free, accurate, crash free) foo_discogger version released this far.
Also downgrading component config files is not supported, so a backup/config deletion/reset will be required.

As for the issues mentioned above:

- Incoming multi value fields written as single strings on flac files

This can now be verified/troubleshooted by activating the new Log updates feature (Preferences->Tagging)

v1.0.13.1 (and all versions below 1.0.14.8) might write multi value metadata incorrectly, either producing too much multi value metadata or erroneously writing metadata as single values.

For overall troubleshooting, I would recommend temporarily activating the new Log update feature and inspecting its console output. I will also verify that custom values title format definitions are really producing multi values (not single values including semi-colons). For example, creating custom columns  ej. $meta_sep(DISCOGS_GENRE,*)

Re: foo_discogs

Reply #3071 –
Is there a way to set "DISCOGS_RELEASE_ID" to "Disabled?" I use this componenent just to write the genres to tags so I don't need or want it to be required to add this field. Another solution would be to just allow for the master/"All Versions of This Release" to be written to tags.

Re: foo_discogs

Reply #3072 –
crtla, none for DISCOGS_RELEASE_ID as enabling that option will be somehow against the concepts of how the software is conceived.

There is an 'extended mode' combination, Shift + Right clicking protected items, in this case, currently offering either 'Write' or 'Write and Update'.

Not saying that the option is not useful or that it will never be implemented, just wondering if it's worth the effort and more importantly, if anybody will be happy with the end result.
About the Master/All versions tag, I would say that it won´t help much as it has no genres associated with it.
For now, there should be some fair way to automate the clearing by other means, but will keep it mind for future releases.

Re: foo_discogs

Reply #3073 –
Hi there,
There is a new Discogger release available.
It should help mitigate some of the multi-value bugs mentioned above.
Thanks again for reporting!

Release and change log:

Discogger v1.0.15

Re: foo_discogs

Reply #3074 –
This fixes my multi-value field issues. Very nice thank you!