Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Crash playing a missing item (Read 1233 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Crash playing a missing item

Attached 2 crash reports, but I can reproduce it anytime playing a missing item on a playlist. Have not been able to reproduce it on a clean install, but also zero clues about the problematic component.

Foobar 1.6.17

EDIT: removed logs.

Re: Crash playing a missing item

Reply #1
Both textual logs show foo_openlyrics activity right before the crash.

Re: Crash playing a missing item

Reply #2
Had a quick glance and it uses get_full_info_ref without try/catch. The SDK does warn that it will throw exceptions on failure...

https://github.com/jscript-panel/foobar2000-sdk/blob/8203adcce8efe20815d0dd93f5f48be5371a5aa4/foobar2000/SDK/metadb_handle.h#L131-L134




Re: Crash playing a missing item

Reply #4
In case someone more has this problem and can't wait for a fix, if you are also using dead items daily. Here it is an updated version:

This one uses 1.8.1 version number
https://github.com/regorxxx/foo_openlyrics/releases/tag/c
And this one maintains the 1.8 version number
https://github.com/regorxxx/foo_openlyrics/releases/tag/b

Re: Crash playing a missing item

Reply #5
Version 1.9 is out now (https://github.com/jacquesh/foo_openlyrics/releases/tag/v1.9) but besides providing Regor's fix is a huge disappointment.  After waiting since October for a new version, still no requested additional sources added and no source ID option for found lyrics.  I've posted before to github but the developer does not seem overly concerned with user requests there.  Well, what is provided, is free and does work very well.