HydrogenAudio

void SubclassDialog(HWND);

3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): warning C4003: not enough arguments for function-like macro invocation 'SubclassDialog'
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): warning C4003: 	void SubclassDialog(HWND);
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): warning C4003: 	     ^
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): error C2059: syntax error: 'constant'
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): error C2059: 	void SubclassDialog(HWND);
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): error C2059: 

Yay, I was able to make my Preferences go dark with 5 lines of code. Great stuff!

Please don't make these statements. You just release the SW. We are people with anxiety problems. Don't add more to us.

I'll wait for it.

I had to comment out line 104 of DarkMode.h though...

Code: [Select]

void SubclassDialog(HWND);

If present, it won't compile.

Code: [Select]

3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): warning C4003: not enough arguments for function-like macro invocation 'SubclassDialog'
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): warning C4003: 	void SubclassDialog(HWND);
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): warning C4003: 	     ^
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): error C2059: syntax error: 'constant'
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): error C2059: 	void SubclassDialog(HWND);
3>Z:\Git\foo_jscript_panel3\foobar2000-sdk\libPPUI\DarkMode.h(104,7): error C2059: 

Quote from: koupa on 2022-08-11 15:53:23

Please don't make these statements. You just release the SW. We are people with anxiety problems. Don't add more to us.

I'll wait for it.

[attach type=image]23039[/attach]

IDR_MENU MENU
BEGIN
    POPUP "DUMMY"
    BEGIN
        MENUITEM "DUMMY", IDC_STATIC
    END
END

class CDialogConfigure : public CDialogImpl<CDialogConfigure>, public fb2k::CDarkModeHooks
{
};

auto menu = wil::unique_hmenu(GetMenu());
auto file = wil::unique_hmenu(CreateMenu());
auto samples = wil::unique_hmenu(CreateMenu());
auto licenses = wil::unique_hmenu(CreateMenu());
auto help = wil::unique_hmenu(CreateMenu());

// append stuff goes here

I do have a question for @Peter : Is it possible to switch between 32-bit floats and 64-bit floats internally in the 64-bit version or is 64-bit version only 64-bit float?  Moving stuff between some effect and conversion DSPs and certain freeware DAWs that top out at 32-bits floats comes to mind.

I do have a question for @Peter : Is it possible to switch between 32-bit floats and 64-bit floats internally in the 64-bit version or is 64-bit version only 64-bit float?  Moving stuff between some effect and conversion DSPs and certain freeware DAWs that top out at 32-bits floats comes to mind.

So these dark mode helpers have it ridiculously easy to implement dark mode for all my dialogs so huge thanks to Peter for that.

But I'm a bit stumped with this menu/toolbar because it doesn't appear as any kind of window when checking it out with Spy++?? I don't even what kind of control it is??? It's fair to say I have no idea what I'm doing....  :))  :))

Does this effect the current state of Visual Studio Compatibility at all?

IIUC, there will be 3 builds. 32bit, 64bit and ARM64.

	void run(threaded_process_status& status, abort_callback& abort) override
	{
		auto recs = metadb_v2::get()->queryMultiSimple(m_handles);
		const size_t count = m_handles.get_count();

		for (size_t i = 0; i < count; ++i)
		{
			do_something_new(handles[i], recs[i]);
			
			/*
			or nuke the auto recs...
			and
			
			auto rec = handles[i]->query_v2_();
			do_something_new(handles[i], rec);
			*/
		}
	}

If iterating a handle list in a threaded_process_callback, is there any point in using metadb_v2::get()->queryMultiSimple up front??

for (auto ptr : track_property_provider::enumerate())
{
	ptr->enumerate_properties_helper(m_handles, nullptr, callback, fb2k::noAbort);
}

   //! Helper; calls modern versions of this API where appropriate.
   //! @param items List of tracks to enumerate properties on.
   //! @param info Callback object to fetch info from. Pass null to use a generic implementation querying the metadb.
   //! @param callback Callback interface receiving enumerated properties.
   //! @param abort The aborter for this operation.
   void enumerate_properties_helper(trackListRef items, track_property_provider_v3_info_source * info, track_property_callback_v2 & callback, abort_callback & abort);
   void enumerate_properties_helper(trackListRef items, track_property_provider_v5_info_source* info, track_property_callback_v2& callback, abort_callback& abort);

Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1120	5 unresolved externals	foo_ext	K:\foo_ext\foobar2000\foo_ext\Release\foo_ext.dll	1	
Error	LNK2001	unresolved external symbol "bool __cdecl listview_helper::select_single_item(struct HWND__ *,unsigned int)" (?select_single_item@listview_helper@@YA_NPAUHWND__@@I@Z)	foo_ext	K:\foo_ext\foobar2000\foo_ext\config.obj	1	
Error	LNK2001	unresolved external symbol "bool __cdecl listview_helper::set_item_text(struct HWND__ *,unsigned int,unsigned int,char const *)" (?set_item_text@listview_helper@@YA_NPAUHWND__@@IIPBD@Z)	foo_ext	K:\foo_ext\foobar2000\foo_ext\config.obj	1	
Error	LNK2001	unresolved external symbol "unsigned int __cdecl listview_helper::insert_column(struct HWND__ *,unsigned int,char const *,unsigned int)" (?insert_column@listview_helper@@YAIPAUHWND__@@IPBDI@Z)	foo_ext	K:\foo_ext\foobar2000\foo_ext\config.obj	1	
Error	LNK2001	unresolved external symbol "unsigned int __cdecl listview_helper::insert_item(struct HWND__ *,unsigned int,char const *,long)" (?insert_item@listview_helper@@YAIPAUHWND__@@IPBDJ@Z)	foo_ext	K:\foo_ext\foobar2000\foo_ext\config.obj	1	
Error	LNK2001	unresolved external symbol "void __cdecl WIN32_OP_FAIL(void)" (?WIN32_OP_FAIL@@YAXXZ)	foo_ext	K:\foo_ext\foobar2000\foo_ext\foobar2000_sdk_helpers.lib(win32_dialog.obj)	1	

Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1120	169 unresolved externals	foo_ext	K:\foo_ext\foobar2000\foo_ext\x64\Release\foo_ext.dll	1	
Error	LNK2001	unresolved external symbol "bool __cdecl __ExceptionPtrToBool(void const *)" (?__ExceptionPtrToBool@@YA_NPEBX@Z)	foo_ext	K:\foo_ext\foobar2000\foo_ext\foobar2000_SDK.lib(input.obj)	1	
Error	LNK2001	unresolved external symbol "class ATL::CAtlBaseModule ATL::_AtlBaseModule" (?_AtlBaseModule@ATL@@3VCAtlBaseModule@1@A)	foo_ext	K:\foo_ext\foobar2000\foo_ext\config.obj	1	
Error	LNK2001	unresolved external symbol "const type_info::`vftable'" (??_7type_info@@6B@)	foo_ext	K:\foo_ext\foobar2000\foo_ext\config.obj	1	
Error	LNK2001	unresolved external symbol "void * __cdecl operator new(unsigned __int64)" (??2@YAPEAX_K@Z)	foo_ext	K:\foo_ext\foobar2000\foo_ext\foo_ext.obj	1	

class MetadbDisplayFieldProvider : public metadb_display_field_provider_v2
{
public:
	bool process_field_v2(uint32_t index, metadb_handle* handle, const metadb_v2::rec_t& rec, titleformat_text_out* out)
	{
		// rec.info was empty so I added a check but is this expected?? if (rec.info.is_empty()) return false;
		const auto hash = get_hash(rec, handle->get_location());
		...
	}

	bool process_field(uint32_t index, metadb_handle* handle, titleformat_text_out* out) override
	{
		return process_field_v2(index, handle, handle->query_v2_(), out);
	}
}

metadb_index_hash get_hash(const metadb_v2::rec_t& rec, const playable_location& location)
{
	return g_client->transform(rec.info->info(), location);
}

	HashSet get_hashes(metadb_handle_list_cref handles)
	{
		HashSet hashes; // std::set<metadb_index_hash>
		auto recs = metadb_v2::get()->queryMultiSimple(handles);
		const size_t count = handles.get_count();

		for (size_t i = 0; i < count; ++i)
		{
			// recs[i].info was null again - this method is only triggered after running menu commands so sometime after startup
			const auto hash = get_hash(recs[i], handles[i]->get_location());
			hashes.emplace(hash);
		}
		return hashes;
	}

Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK2038	mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in bpm_auto_analysis.obj	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(threads.obj)	1	
Error	LNK2001	unresolved external symbol __imp__lround	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(other.obj)	1	
Error	LNK2001	unresolved external symbol __imp__llround	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(other.obj)	1	
Error	LNK2001	unresolved external symbol __imp___aligned_malloc	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(other.obj)	1	
Error	LNK2001	unresolved external symbol __imp___aligned_realloc	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(other.obj)	1	
Error	LNK2001	unresolved external symbol __imp___aligned_free	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(other.obj)	1	
Error	LNK2001	unresolved external symbol __imp___strdup	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(string_base.obj)	1	
Error	LNK2001	unresolved external symbol __imp__rand	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(sort.obj)	1	
Error	LNK2001	unresolved external symbol __imp__srand	foo_bpm	e:\foobar2000\foo_bpm\pfc.lib(sort.obj)	1	
Error	LNK2001	unresolved external symbol __imp__strcat_s	foo_bpm	e:\foobar2000\foo_bpm\foobar2000_SDK.lib(file_info.obj)	1	
Error	LNK2001	unresolved external symbol __imp___wfopen	foo_bpm	e:\foobar2000\foo_bpm\foobar2000_SDK.lib(filesystem.obj)	1	
Error	LNK2001	unresolved external symbol __imp__llroundf	foo_bpm	e:\foobar2000\foo_bpm\foobar2000_SDK.lib(audio_chunk.obj)	1	
Error	LNK2001	unresolved external symbol __imp__lroundf	foo_bpm	e:\foobar2000\foo_bpm\foobar2000_SDK.lib(audio_chunk.obj)	1	
Error	LNK2001	unresolved external symbol __except_handler4_common	foo_bpm	e:\foobar2000\foo_bpm\MSVCRT.lib(chandler4gs.obj)	1	

Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK1120	13 unresolved externals	foo_bpm	E:\foobar2000\foo_bpm\Release\foo_bpm.dll	1	

SDK 2022-10-20 released
https://www.foobar2000.org/SDK

p_fromhook arg, noted.

auto apm = autoplaylist_manager::get();
auto plm = playlist_manager::get();
playlist = plm->get_active_playlist();
apm->add_client_simple(query, sort_pattern, playlist, autoplaylist_flag_sort);
if (apm->is_client_present(playlist))
    apm->remove_client(playlist);

class CDialogBlah : public CDialogImpl<CDialogReport>, public cfg_window_placement_v2
{
public:
	CDialogBlah() : cfg_window_placement_v2(guids::window_placement) {}

	BEGIN_MSG_MAP_EX(CDialogBlah)
		MSG_WM_INITDIALOG(OnInitDialog)
		COMMAND_ID_HANDLER_EX(IDCANCEL, OnCancel)
	END_MSG_MAP()

	enum { IDD = IDD_DIALOG_BLAH };

	BOOL OnInitDialog(CWindow, LPARAM)
	{
		apply_to_window(*this, false);
		return TRUE;
	}

	void OnCancel(uint32_t, int nID, CWindow)
	{
		read_from_window(*this);
		EndDialog(nID);
	}
};

Re listview dark mode,

My implementation of this is even crazier than the rest of dark mode stuff -
MS listview outright defies proper darkening, so instead of rewriting every use case to use something else, I wrote a wrapper to drop CListControl in place of each one... and make it interop with listview API. So, issues are to be expected. I just had to add basic custom draw support to it because spectrogram colors dialog needed it.

apm->add_client_simple(param1.toString(), cfg.query.sortpattern, playlist, autoplaylist_flag_sort);
// force sort so results are always returned sorted, and then clear so user can reorder if needed
apm->set_client_flags(playlist, 0);

cfg.query.sortpattern infers you have a preference for the sort pattern. Add a new force sort checkbox next to and you don't need to change the flags.

Make sure the configuration is Release and platform combo box is set to all platforms because you want the same for 32bit/64bit.

Then check Runtime Library and make sure it's Multi-Threaded DLL (/MD). This corresponds with the default settings of the current SDK.

1>D:\Source\foo_httpcontrol\foo_httpcontrol\lib\foobar2000\helpers\foobar2000_sdk_helpers.vcxproj(607,5): error : 
This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\wtl.10.0.10320\build\native\wtl.targets.

I've got a listview with multiple columns. The list gets populated using ListView_InsertItem and ListView_SetItemText. When dark mode has been applied, it won't show the text that was added using ListView_SetItemText. Any chance for a fix?

Implementing list views with libPPUI ensures dark mode works. Look at the three files prefixed with listcontrol in the foo_sample folder.

BTW, you typically want m_hooks.AddDialogWithControls(*this); as the last line before the return statement in your OnInitDialog.

Well here's a real world example from one of my components...

You should call CoInitialize() + CoUninitialize() yourself if you need COM. As far as I can see, everything in my code matches CoInitialize() with CoUninitialize(), so you worker thread clients should always assume that COM hasn't been initialized on entry.

const auto pSearchFilter = search_filter_manager_v3::get()->create( query.c_str() );
const auto pSearchIndex = search_index_manager::get()->get_library_index();
const auto pArray = pSearchIndex->search( pSearchFilter, nullptr, 0, fb2k::mainAborter() );
// Per docs: "Safe to use arr->as_list_of<metadb_handle>() to get a pfc::list_base_const_t<metadb_handle_ptr>"
auto handles = pArray->as_list_of<metadb_handle>();

1>X:\git\foo_spider_monkey_panel\foo_spider_monkey_panel\js_backend\objects\fb2k\library.cpp(158,22): error C2259: 'pfc::list_base_const_t<metadb_handle_ptr>': cannot instantiate abstract class
1>X:\git\foo_spider_monkey_panel\submodules\foobar2000\SDK\metadb_handle.h(189,14): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>'
1>X:\git\foo_spider_monkey_panel\foo_spider_monkey_panel\js_backend\objects\fb2k\library.cpp(158,22): message : due to following members:
1>X:\git\foo_spider_monkey_panel\foo_spider_monkey_panel\js_backend\objects\fb2k\library.cpp(158,22): message : 't_size pfc::list_base_const_t<metadb_handle_ptr>::get_count(void) const': is abstract
1>X:\git\foo_spider_monkey_panel\submodules\pfc\list.h(63,17): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>::get_count'
1>X:\git\foo_spider_monkey_panel\foo_spider_monkey_panel\js_backend\objects\fb2k\library.cpp(158,22): message : 'void pfc::list_base_const_t<metadb_handle_ptr>::get_item_ex(T &,t_size) const': is abstract
1>        with
1>        [
1>            T=metadb_handle_ptr
1>        ]
1>X:\git\foo_spider_monkey_panel\submodules\pfc\list.h(64,15): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>::get_item_ex'
1>X:\git\foo_spider_monkey_panel\foo_spider_monkey_panel\js_backend\objects\fb2k\library.cpp(158,22): error C2248: 'pfc::list_base_const_t<metadb_handle_ptr>::list_base_const_t': cannot access protected member declared in class 'pfc::list_base_const_t<metadb_handle_ptr>'
1>X:\git\foo_spider_monkey_panel\submodules\pfc\list.h(142,2): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>::list_base_const_t'
1>X:\git\foo_spider_monkey_panel\submodules\foobar2000\SDK\metadb_handle.h(189,14): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>'
1>X:\git\foo_spider_monkey_panel\foo_spider_monkey_panel\js_backend\objects\fb2k\library.cpp(158,59): error C2248: 'pfc::list_base_const_t<metadb_handle_ptr>::~list_base_const_t': cannot access protected member declared in class 'pfc::list_base_const_t<metadb_handle_ptr>'
1>X:\git\foo_spider_monkey_panel\submodules\pfc\list.h(140,3): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>::~list_base_const_t'
1>X:\git\foo_spider_monkey_panel\submodules\foobar2000\SDK\metadb_handle.h(189,14): message : see declaration of 'pfc::list_base_const_t<metadb_handle_ptr>'

@Peter I'm trying to use new search api, but either I'm doing something wrong or there are missing

Hence `auto` does not work here, `metadb_handle_list handles = pArray->as_list_of<metadb_handle>();` should be used instead

auto& handles = pArray->as_list_of<metadb_handle>();

metadb_handle_list handles;
handles.add_items(arr->as_list_of....)

@Peter, I think there's a bug with get_sort_priority in contextmenu_item_lambda . It should return m_sortPriority but currently returns 0.

Fixed poor performance of adding lots of items to Playback Queue.

I'd like to request the ability to bulk add playlist queue items. It seems the only way to re-order the current queue or insert new items at a given point is to flush the queue and then add them back one at a time which triggers the callback more than is necessary. If I missed a way to do this, I'll take any pointers.