Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1361123 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

foo_discogs

Reply #550 –
When I fetch an album, why is the track order from discogs often messed up?? Did I miss some obvious config setting, or could it be sorted properly in a future release?

The "auto" setting is nice, but could the filter automatically be filled with %album%? That would indeed speed up the search process.

Also it would be nice if the filter works as seperate strings - Say I want to filter CD's and a particular album, this is not possible today (or I haven't figured it out yet).

Could you show a similarity percentage comparison of the discogs tracks and filenames (like php's similarity_text() )? Some releases have the same number of tracks, but may have a few tracks swapped and therefore not be the correct release, but just looking at the two lists, such small difference is hard to see.

As I mentioned in another thread, I think it needs a little more automation: Allow multiple release selection (it could group them internally) and make it traverse through all matching releases for each group. Any release that has matching tracknumbers has a high probability that it's the correct release. It could even compare the track name from discogs and %track% for similarity to further improve automatic detection. Results should be reviewed just like today. Of course it's not perfect, and it won't work everytime, but it would certainly speed up tagging multiple albums at once. Especially with such a large collection as mine 

But...! This has certainly evolved into something extremely useful from last time i checked it! Thumbs up bg
Can't wait for a HD-AAC encoder :P

foo_discogs

Reply #551 –
Quote from: odyssey on
When I fetch an album, why is the track order from discogs often messed up?? Did I miss some obvious config setting, or could it be sorted properly in a future release?

Sharing delusions since 1991.

foo_discogs

Reply #552 –
I have problem, when I try to download artist art (haven't tried with album art thou...) and save it to path that doesn't exist previous to download. I've set directory for artist art as "E:\MP3\artwork\%artist%". It's empty, I try to download artist art for _some_artist_ and get error:
Code: [Select]
foo_discogs: error: problem creating file E:\MP3\artwork\_some_artist_\_some_artist_ID__1.jpg [Object not found], skipping...

If I create directory named _some_artist_ and try to download artist art everything goes smoothly, but manual creating directories for every artist is somewhat counter-automatic
 

foo_discogs

Reply #553 –
Thats a great plugin! Great ! Great ! Great !

But I have a small feature request:

is it possible to make the relase dates (which seems to be stored at discogs in different formats) change into one (best self formated) format.

Example: I need every release date (which is stored in the field <ORIGINAL RELEASE DATE>) in the format YYYY-MM-DD (e.g. 2008-05-02) but sometimes I get DD MMM YYYY (e.g. 02 May 2008). But Traktor needs YYYY-MM-DD.

THX

Btw: did I say that this is a great plugin ?

foo_discogs

Reply #554 –
Quote from: ZYPHLiX on
Example: I need every release date (which is stored in the field <ORIGINAL RELEASE DATE>) in the format YYYY-MM-DD (e.g. 2008-05-02) but sometimes I get DD MMM YYYY (e.g. 02 May 2008). But Traktor needs YYYY-MM-DD.

Hi, you can try to use masstagger for this job.

Menu -> Tagging -> Manage Scripts -> Clear -> Add -> Format Value From Other Fields
destination field:  ORIGINAL_RELEASE_DATE
formatting pattern: %date%[-$num(%discogs_release_month%,2)[-$num(%discogs_release_day%,2)]]

then u can save it and bind hotkey to this script... (Preferences -> General -> Keyboard Shortcuts)

foo_discogs

Reply #555 –
Quote from: ZYPHLiX on
is it possible to make the relase dates (which seems to be stored at discogs in different formats) change into one (best self formated) format.

Example: I need every release date (which is stored in the field <ORIGINAL RELEASE DATE>) in the format YYYY-MM-DD (e.g. 2008-05-02) but sometimes I get DD MMM YYYY (e.g. 02 May 2008). But Traktor needs YYYY-MM-DD.

Hi, I did it like this:
1) Store the *raw discogs release date* to your %date% tag, not the extra month, year etc. entries! (to do this, you have to go to Discogs->Edit tag mappings... and choose the "Release raw" entry in the Discogs information quite at the end of the list and map it to "Date". If done you get the date already in format YYYY-MM-DD from now on.
2) You need some scripting afterwards though as Discogs sets the day and/or month to 00 if there's none given by the submitter which means you have to remove all "-00" from the string. You can easily do this with the masstagger -> format "DATE" using "[$replace(%date%,-00,)]"

HTH

foo_discogs

Reply #556 –
Most proably a stupid question but I didn't figured it out: how can I fetch the album art without doing any tagging? So just create an folder.jpg and nothing else?

Another question: Why does foo_discogs use only the artist name, not the album name to get the albums from discogs? Or did I miss some option?

foo_discogs

Reply #557 –
Hi! Thx 2 dancehool and Dave_Scream for their help!!! I took dancehools version

Quote from: dancehool on
2) You need some scripting afterwards though as Discogs sets the day and/or month to 00 if there's none given by the submitter which means you have to remove all "-00" from the string. You can easily do this with the masstagger -> format "DATE" using "[$replace(%date%,-00,)]"


Why ? Is the 00 a problem for Traktor?

Anyway, a the moment it still doesnt work anyhow. Traktor can read the Artist Name and Title and so on created by the FOO_DISCOGS Plugin, but not the Tags like CATALOG # ... but im also in contact wih the NativeInstruments Support


Another question: is there still development for this plugin ? My feature-request would be to have a option to add the releases from tagged songs to your discogs-collection? Or does anyone have a workaround for this ,too?

Thx guys, have a wunderful monday!

foo_discogs

Reply #558 –
Quote from: ZYPHLiX on
Quote from: dancehool on

2) You need some scripting afterwards though as Discogs sets the day and/or month to 00 if there's none given by the submitter which means you have to remove all "-00" from the string. You can easily do this with the masstagger -> format "DATE" using "[$replace(%date%,-00,)]"


Why ? Is the 00 a problem for Traktor?

I don't use Traktor so I don't know if it's a problem. Of course you don't have to do the second step - but I found it more convenient to have, for example "2003-04" instead of "2003-04-00" or "2000" instead of "2000-00"/"2000-00-00" but if you don't have a problem with these "-00"s just let them in your data.

foo_discogs

Reply #559 –
Quote from: ZYPHLiX on
Another question: is there still development for this plugin ? My feature-request would be to have a option to add the releases from tagged songs to your discogs-collection? Or does anyone have a workaround for this ,too?

As far as I know the Discogs API does not support such feature unfortunately and as foo_discogs is based on the API it's not possible at the moment...if I am wrong somebody should correct me!

foo_discogs

Reply #560 –
How do you handle "Various Artist" albums with this plugin?

Right now I use my browser to search for the album title and simply paste the release number from their website into the plugin. It's just not a very elegant way to do it. Would be nice if we could search for album-titles as well.

foo_discogs

Reply #561 –
Quote from: front243 on
How do you handle "Various Artist" albums with this plugin?

Right now I use my browser to search for the album title and simply paste the release number from their website into the plugin. It's just not a very elegant way to do it. Would be nice if we could search for album-titles as well.

I'm searching for one of the artists on the album, then in the fetched list for the album title.

Anyway it would be a great feature if one could search also directly for the release title and maybe even cat#/label etc. If the record for example is a white label with no information on it (means main artist is "Unknown Artist", release title is "Untitled") and you only know the cat# it's not possible to find it with the plugin. For this one still has to look on the website and copy/paste the release number/release link.

foo_discogs

Reply #562 –
Quote from: dancehool on
For this one still has to look on the website and copy/paste the release number/release link.

For this reason would be cool to have a "free"-search field like on he websie, and then all releases to your search appear ....

anyway, is it a bug that in releases with non-standard-characters ( here is an exaple where i discovered it : http://www.discogs.com/release/182444 ) the non-standard-things are returned as HTML code ? als also had the same problem with a release of <SIE>
Give it a try and see what i mean ...

THX, great plugin ... (and the question is still not aswered if the plugin is still developed. i think its interessting, because i dont want to ride a dead horse)

foo_discogs

Reply #563 –
Quote from: ZYPHLiX on
anyway, is it a bug that in releases with non-standard-characters ( here is an exaple where i discovered it : http://www.discogs.com/release/182444 ) the non-standard-things are returned as HTML code ?

It's not a bug as foo_discogs just fetches what Discogs offers. In your case for example track 1 is actually stored (and submitted by original submitter of the release) with HTML tags: "1<sup class="exposant">er</sup> Tournée" (If you try to edit the release in Discogs you can see the actual HTML code in the tracklisting). This is interpreted by your browser so you see what you see (the upper "er"). Foobar does not interpret HTML (maybe there's a plugin for this - anyone?) so these tags stay as they are. To remove it you need a masstagger script.

Quote
(and the question is still not aswered if the plugin is still developed. i think its interessting, because i dont want to ride a dead horse)

I think it's still developed by bubbleguuum.

foo_discogs

Reply #564 –
Quote from: ZYPHLiX on
THX, great plugin ... (and the question is still not aswered if the plugin is still developed. i think its interessting, because i dont want to ride a dead horse)


I will not add any significant feature at this point (alternate search system, etc...) but will fix any problem if Discogs change/update their API. And a recompile against the new SDK is due soon + a code source release if anyone wants to make enhancements.

foo_discogs

Reply #565 –
This plugin simply does not work for me. Not at home (with or without firewall disabled), and not at work (completely different PC, no firewall, different internet access). Each time I try to do a search, it pauses for one or two seconds then comes back with absolutely nothing in the results list. I have tried removing the application rules for FOOBAR2000.EXE in my firewall then triggering the search to see if it's actually trying to connect at all. It is, but the connection goes nowhere. Tried removing the plugin (all config removed) then reinstalling and trying again. Nothing. I have seen this reported by other users in this thread.

Is there some sort of debug version that can be provided so we can understand what the problem is that the plugin is encountering during the connect phase? I really enjoyed this plugin back when it worked for me (something like six months ago now).

Edit: And when I punch in a valid Discogs release ID (such as 872895) into the appropriate field then click OK, I get discogs error: release id=872895: XML API error.



Cheers
Dhry

foo_discogs

Reply #566 –
872895 works for me with discogs 1.13.

Must be something on your end.
elevatorladylevitateme

foo_discogs

Reply #567 –
Hi to everybody,

I've been using fb2k for some months now and tried the discogs plugin today for the first time but unfortunately without any success. Basically I encounter the same behaviour like posted above by Dhry. As soon as I try to fetch the discogs data from the server by clicking "write tags", nothing happens. There is no result shown in the windows.

installed fb2k version: 0.9.5.6 (default installation)
foo_discogs.dll: 1.13
windows xp (sp3, fully updated)

As far as I was able to narrow down the problem, it seems to be the connection between the client and server. Below I'll append the network-communication, sniffed by wireshark:

Request from client
Code: [Select]
GET /search?type=artists&q=Buena%20Vista%20Social%20Club&f=xml&api_key=df4f42ee8c HTTP/1.1
Host: www.discogs.com
Accept: */*


Answer from server
Code: [Select]
HTTP/1.0 400 Bad Request
Date: Sat, 27 Sep 2008 11:15:56 GMT
Server: Apache
Set-Cookie: sid=fa09e6236ebf4e5558a97aae5385f5c6; path=/; expires=Tue, 25-Sep-2018 11:15:56 GMT; domain=.discogs.com
Content-Type: text/xml
Connection: close

<resp requests="None" stat="fail"><error>Client does not accept gzip encoding.</error></resp>


Using the complete url: h**p://www.discogs.com/search?type=artists&q=Buena%20Vista%20Social%20Club&f=xml&api_key=df4f42ee8c the same error comes up in the browser window.

So for my understanding there seems to be some issues with the compression of the data(?) Hence the question: if it is correct, that this is the problem, is there any possibility to change the config client-side?

greetings
thehuh

edit: typo
Una salus victis, nullam sperare salutem

foo_discogs

Reply #568 –
Quote from: thehuh on
I've been using fb2k for some months now and tried the discogs plugin today for the first time but unfortunately without any success. Basically I encounter the same behaviour like posted above by Dhry. As soon as I try to fetch the discogs data from the server by clicking "write tags", nothing happens. There is no result shown in the windows.




Pfft. This is possibly the reason:

http://www.discogs.com/help/api



Quote
API usage is limited to 5,000 requests per 24-hour period, per IP address.

Clients must send the "Accept-Encoding: gzip" header. The service will gzip most API responses so your application must be able to decode gzipped data.

Clients must supply an API Key with each request.




I wonder whether it's because I/we are on major US providers and Discogs is simply denying API calls because there have been over 5,000? It says it's per IP address but I wonder whether it's instead actually by ISP?



I noticed that the df4f42ee8c API key is hardcoded into the foo_discogs.dll file. Any way of making this configurable so we can try it with different API keys and see whether that's the problem?



The other thing that the API page states is that the client must send the "Accept-Encoding: gzip" header. From what thehuh posts, the call out to Discogs does not contain this in the header and the resulting error from Discogs confirms this. Defect?



I cannot explain why it works for some people but not others. Thehuh, could you install MP3Tag (free from www.mp3tag.de), activate Wireshark, and capture the callout to Discogs from that program pls? MP3Tag discogs calls work perfectly fine for me, so I'm assuming the API key or something about the external call is different enough to make the system work. With that info, I'd try hexediting the discogs dll with a new key..



Dhry

foo_discogs

Reply #569 –
Quote from: thehuh on
Request from client
Code: [Select]
GET /search?type=artists&q=Buena%20Vista%20Social%20Club&f=xml&api_key=df4f42ee8c HTTP/1.1
Host: www.discogs.com
Accept: */*



You should see "Accept-Encoding: deflate, gzip" in the request. If you don't, and the request in a www browser fails, it is probably a firewall or proxy getting in the way. It's not the per IP limit giving problems here.
If you are using a HTTP proxy you can set it in the plugin configuration (network tab). The plugin will not automatically use the system proxy if there is one (set in Control Panel / Internet Options).  Maybe mp3tag does.

foo_discogs

Reply #570 –
Hi,

Quote
I wonder whether it's because I/we are on major US providers and Discogs is simply denying API calls because there have been over 5,000? It says it's per IP address but I wonder whether it's instead actually by ISP?

Well, personally I don't think that discogs is filtering by ISP, because I installed mp3tag only a a minute later and it works.

Quote
If you are using a HTTP proxy you can set it in the plugin configuration (network tab). The plugin will not automatically use the system proxy if there is one (set in Control Panel / Internet Options). Maybe mp3tag does.

Nope, there is no HTTP proxy in use. Firewall or VirusScanner is deactivated on the pc.


Please find below the output using mp3tag:

Request to server
Code: [Select]
GET /artist/Buena+Vista+Social+Club HTTP/1.1
Host: www.discogs.com
User-Agent: Mozilla/5.0 (compatible)
Accept:*/*


Answer from server
Code: [Select]
HTTP/1.0 200 OK
Date: Sun, 28 Sep 2008 05:20:41 GMT
Server: Apache
Set-Cookie: sid=cd079b4f512b00034c8d1b62e933f65e; path=/; expires=Wed, 26-Sep-2018 05:20:41 GMT; domain=.discogs.com
Content-Type: text/html; charset=utf-8
Content-Length: 13926
Connection: close

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta name="verify-v1" content="kZg16KbGVgtSrBuoDcwAKBKYVvDb26lnudxP3FMOcoE=" />
<meta http-equiv="content-type" content="text/html;charset=utf-8" />
<title>Buena Vista Social Club</title>
<link rel="icon" href="/images/favicon.ico" />
<link rel="stylesheet" href="/css/main.css?v=001d" />
<!--[if IE 7]>
<link rel="stylesheet" href="/css/nav_ie7.css?v=001b">
<![endif]-->
<!--[if lte IE 6]>
<link rel="stylesheet" href="/css/nav_ie.css?v=001b">
<![endif]-->
<script type="text/javascript" src="http://yui.yahooapis.com/2.5.0/build/utilities/utilities.js"></script>
<script type="text/javascript" src="/js/global.js?v=001b"></script>
</head>
<body>

[...]


If needed I can put the complete conversation log online or pm/mail it. 


greetings
tehuh
Una salus victis, nullam sperare salutem

foo_discogs

Reply #571 –
mp3tag do not use the Discogs XML API, but HTML page scraping, that's why it works.
EDIT: there is probably a stupid firewall on your PC or some security software that analyse HTTP requests, that remove the "Accept-Encoding: deflate, gzip" line:
http://schroepl.net/projekte/mod_gzip/firewalls.htm

foo_discogs

Reply #572 –
Hi,

you're right; the comparison to mp3tag doesn't seem to be really helpful in that case. I should have recognized it before posting... 

Quote
EDIT: there is probably a stupid firewall on your PC or some security software that analyse HTTP requests, that remove the "Accept-Encoding: deflate, gzip" line:
http://schroepl.net/projekte/mod_gzip/firewalls.htm


Nope, firewall is deactivated; meaning application is not running, service is disabled, driver is unloaded. Same for the virusscanner. There is nothing in between from foobar on my pc until the isp-modem which might alternate the traffic. Data-stream was captured on on lan port of the modem.

On the api-page of discogs posted by Dhry (h**p://www.discogs.com/help/api) there is written
Quote
Restrictions:
    * Clients must send the "Accept-Encoding: gzip" header. The service will gzip most API responses so your application must be able to decode gzipped data.

Quiz question: is there any posibility to modify foo_discogs.dll to send this header because obviously it is lacking in Dhry's and of my installation? As far as I could see in the source code, there is no such code implemented? (but to be honest I'm no programmer so please excuse my assumption if I'm wrong  ).


greetings
thehuh


Supplement: Test on the linked website for checking the HTTP-request shows the following output (everything fine so far):
Code: [Select]
[ 35] GET /cgi-bin/http_trace.pl HTTP/1.1
[ 61] REFERER: http://schroepl.net/projekte/mod_gzip/firewalls.htm
[ 30] ACCEPT_ENCODING: gzip,deflate
[ 23] CONNECTION: keep-alive
[ 72] ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
[ 48] ACCEPT_CHARSET: ISO-8859-15,utf-8;q=0.7,*;q=0.7
[103] USER_AGENT: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
[ 32] ACCEPT_LANGUAGE: en,en-us;q=0.5
[ 16] KEEP_ALIVE: 300
[ 23] HOST: www.schroepl.net
Una salus victis, nullam sperare salutem

foo_discogs

Reply #573 –
Isn't work for me no error (checked console)
I can fetch the artist art
But I see nothing in the preview or the album art panel, Also I see the on the web the album images

Also the panel works fine because I see old album arts ( I didn't get those with discogs neither)

Im using discogs 1.13 and foobar 0.956


THanks

foo_discogs

Reply #574 –
just wanted to say, everything is working 100% correct here on 9.5.6, album art and everything else