Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1358843 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

foo_discogs

Reply #500 –
Quote from: bubbleguuum on
Finally, a new release! 1.13 (download link in first post):

1.13

+ add: update album/artist art dialog now has settings that overrides those of the configuration tab to force retrieval of art.
This is convenient when art retrieval is always disabled at tag time, and later updated.
+ chg: find release dialog: if a searched artist is an ANV, display all of it's ANVs and non-ANVs releases. Try it with trentemoeller!

yeah! thanks a lot!!! 

as for the tape thingy: i've just noticed that i am able to fetch DISCOGS_TRACK_POSITION - don't know why i've overlooked this before. anyway, all perfect now!

foo_discogs

Reply #501 –
wow now thats fast service
loving your work and the artist art feature

just to be greedy I would  like to request one last thing...
I find quite regularly that when I get my discog results for an album the tracks are out of order and require me to manually re-sort them

would it be possible to have a button that does this automatically once i realise they are not sorted correctly.. I had some large tracked albums with like 30 tracks which took a long time to reorder everything one by one with the move up and down button...

as always your hard work and skillz are greatly appreciated.

foo_discogs

Reply #502 –
just wanna say thx for the new release and testing it to the bones now!

cheers!

foo_discogs

Reply #503 –
Quote from: 4nt1 on
I find quite regularly that when I get my discog results for an album the tracks are out of order and require me to manually re-sort them


This can happen occasionally when two tracks have the same length. If that annoys you can disable auto-match in the Configuration/Tagging tab. That way, the tracks will always be in the order of the playlist

foo_discogs

Reply #504 –
ah perfect this will do nicely

foo_discogs

Reply #505 –
 But not so long all was fine.
PLZ hellp

foobar2000 0.9.5.1
foo_discogs.dll - 1.13 (this problem with all versions).

foo_discogs

Reply #506 –
This error happens when I had a well formed XML response from discogs, but some XML tags  I expect are not there or have an unexpected value (for example if you hit the 5000 request per day per IP). Try to disable temporary your firewall to see if it helps.

foo_discogs

Reply #507 –
Quote from: bubbleguuum on
Try to disable temporary your firewall to see if it helps.

  OMG, now all work fine! Thank you for your plugin and for advice!

BTW, were now "Discogs_Rating" & "Discogs_Votes"?

foo_discogs

Reply #508 –
Quote from: bubbleguuum on
1.13

+ chg: find release dialog: if a searched artist is an ANV, display all of it's ANVs and non-ANVs releases. Try it with trentemoeller!


Hm. This seems not to work properly. I tried to search for "Teckno Bross" who's an ANV of "Techno Bros" and this is what the release dialog shows:

foo_discogs

Reply #509 –
Quote from: dancehool on
what went wrong?


Looks like you found a disccogs API bug: doing the API request in Firefox and all releases are there while in IE some of them are missing, exactly the same that are missing in foo_discogs.
I'll update the Agent string to be firefox in a future release.

foo_discogs

Reply #510 –
Quote from: bubbleguuum on
Quote from: dancehool on

what went wrong?


Looks like you found a disccogs API bug: doing the API request in Firefox and all releases are there while in IE some of them are missing, exactly the same that are missing in foo_discogs.
I'll update the Agent string to be firefox in a future release.

Hmm. I think that's not the reason. I've just figured out that it depends on whether im logged in or not in discogs. When I'm logged in it's finding all releases, when I'm logged out only the non-ANV ones. Very strange. In any case it's a discogs problem, not foo_discogs.

foo_discogs

Reply #511 –
I keep getting the "discogs error release id=xxx: html parse error" too. Just updated and no change whatsoever.
Any ideas?




EDIT: It seems that it was partially my fault. I installed the new version but for some reason the file was saved as foo_discogs(2).dll keeping the older version running too. I removed it and now, with the latest version, everything is OK.
 

foo_discogs

Reply #512 –
Once again it's not working. Running v1.13 - trying a search brings back no results for any artist. I also note that in 1.13 you can no longer choose either "API" or "Parse HTML". Used to be able to in the previous version.



Dhry

foo_discogs

Reply #513 –
Quote from: Dhry on
Once again it's not working. Running v1.13 - trying a search brings back no results for any artist. I also note that in 1.13 you can no longer choose either "API" or "Parse HTML". Used to be able to in the previous version.



Dhry


works fine here! HTML method has been removed as it was super clunky  and probably did not work anymore.

foo_discogs

Reply #514 –
ok i have seen this a couple times but never cared enough to mention it

I have a cd that is 18 tracks long but according to discogs in the component it is 25 tracks long...

on the release page on the website it is also 18 tracks long with some 1a \ 1b type tracks throughouts the album...

here is an example of the release

http://www.discogs.com/release/750847

see for your self. I do not know how to tag this correctly... perhaps discogs and recognise the a/b/c setup and add all into one track?

not sure what your thoughts are

foo_discogs

Reply #515 –
http://www.discogs.com/release/38741

In tracks 6 & 10b I have a "<sub>2</sub>" in titles. I think the same problem will be with a <sup></sup>, maybe just replace this tags?
Thinking Outside The Box

foo_discogs

Reply #516 –
Quote from: 4nt1 on
see for your self. I do not know how to tag this correctly... perhaps discogs and recognise the a/b/c setup and add all into one track?


I think this has been discussed before. It's a rare case with sub-tracks that does not physically exist on the CD... There's not much to do instead select one of tose subtrack for your track and then manually edit the title if you want after tagging.



@Kyria: it's a Disocgs API bug: they have left some html for those special characters instead of converting them to UTF-8.

foo_discogs

Reply #517 –
Quote from: bubbleguuum on
Quote from: Dhry on

Once again it's not working. Running v1.13 - trying a search brings back no results for any artist. I also note that in 1.13 you can no longer choose either "API" or "Parse HTML". Used to be able to in the previous version.

Dhry

works fine here! HTML method has been removed as it was super clunky  and probably did not work anymore.

Okay, now I have a problem. It works on my f2k install at work, but does not work on my home machine. Whenever I select a group of tracks in an album to tag (regardless of the artist) I get nothing back from Discogs. I've tried checking the auto box, and the Exact Matches box. Tried resetting all Discogs plugin settings to default too. Had a look in my firewall and Foobar is definitely attempting to make a connection out to www.discogs.com, I just get buggerall back in the results window. Turned off firewall completely. Didn't help. Have gdiplus.dll in my foo main dir. I actually have several different copies of it scattered in various directories for some reason. Tried copying about three different versions into foo dir, restart, try again, nothing.

Apart from the [Default] button in the discogs config, is there any way that I can completely remove the discogs settings and then reinitialize or whatever, the plugin? I know that discogs.com works from my machine because I just installed and tried MP3Tag and it worked fine pulling references from discogs as expected. Pinged discogs and get back the proper IP address. Not jacked up in my hosts file, in other words. Heelp. 

Edit: Worked out that if you remove the plugin then restart foobar it asks to remove preferences. Did that. Installed v1.12 to test. Set it to "parse HTML" and finally, I see results. Of course I can't use it because the minute I try to retrieve a result I get an error, as seen previously. Remove v1.12, restart foo to remove settings, reinstall v1.13, restart foo, try to retrieve results, nada. Is there some component I need to update that controls the "web api" access functionality or whatever? It's driving me crazy because while I can use Freedb to tag, I want to grab album art thumbnails for PrettyPop too.

Dhry

foo_discogs

Reply #518 –
@Dhry: I have no idea exactly what's wrong but it's probably something (a firewall, a proxy) filterin the result from discogs. You could try to create an API key on discogs (on your profile page) and try an API request in your browser to see if it replies some valid XML:

http://www.discogs.com/help/api

foo_discogs

Reply #519 –
Quote from: bubbleguuum on
@Dhry: I have no idea exactly what's wrong but it's probably something (a firewall, a proxy) filterin the result from discogs.

Can't be. MP3Tag v2.40b works perfectly fine, and it uses Discogs to retrieve results.
One other thing I noticed. Most of my Discogs menu items are greyed out. For everything I select. Just the bottom two options are available. Are we now talking about a DLL problem? Could you tell me what DLL dependencies (apart from GDIPLUS) Discogs has? I tried reinstalling vcredist thinking that might be it, but still nothing.



Dhry

foo_discogs

Reply #520 –
mp3tag may still parse HTML pages, that's why it works.
It's not a dll pbm : if it was it wouldn't even launch.
All items are greyed except the last two and "write tags" if the files you selected haven't been tagged with the plugin yet.

I still think the XML  answer form discogs gets modified by something in the middle.

foo_discogs

Reply #521 –
bubbleguuum, thanks for this great component! Without it I would be lost...

A small suggestion:

Sometimes I don't know the exact version of an album that I have so I usually just get the tags from the one with the most album art available. Could you perhaps add some text that displays how many cover images there are for the selected release (perhaps next to the small cover art image)? As it is now I have no way of knowing this unless I apply the tags or go to the release page and check, this would speed up my tagging.

Thanks
bitbot

foo_discogs

Reply #522 –
Quote
Quote

then a seperator or space in (DISCOGS_TRACK_CREDITS) would be usefull, if credits contain more than one artist.

They are now separated by ";"

just one minor thing i noticed since using 1.13. the seperator u included for discogs_track_credits and discogs_release_credits could be followed/completed by/with a space, like in the other fields?!  that would make it xyz; xyz and would help to better view the contents of this fields...

also i noticed that many brand-new releases are not shown, even they are already on the page of artist.
e.g. http://www.discogs.com/release/1279556 dj trenix - let the world fall apart... i noticed that behavior on many releases, that didnt recieve any votes on discogs yet! could this be a possible reason???  cheers

foo_discogs

Reply #523 –
Quote from: alexinc on
also i noticed that many brand-new releases are not shown, even they are already on the page of artist.
e.g. http://www.discogs.com/release/1279556 dj trenix - let the world fall apart... i noticed that behavior on many releases, that didnt recieve any votes on discogs yet! could this be a possible reason???  cheers


That's a known and annoying bug of the Discogs API: When you're not logged in discogs you don't see the releases in yellow. Obviously you can't log in using the XML API so you don't see these releases...


@bitbot: I won't implement it

foo_discogs

Reply #524 –
I have been having some problems getting the album art for some albums. One example is this album http://www.discogs.com/release/136452. foo_discogs will fail to download the two first images which will appear as 0 byte files.

Here's the console output:
Code: [Select]
foo_discogs: error: could not save url=http://www.discogs.com/image/R-6462-001.jpg, skipping...
foo_discogs: error: could not save url=http://www.discogs.com/image/R-136452-002.jpg, skipping...


Edit:
Here's another album that doesn't work: http://www.discogs.com/release/3234. This album only has 2 images, but foo_discogs created 6! The first three were 0 byte jpgs, the fourth was an image that did not appear on the page and the last two were the images on the page but in reverse order... 
bitbot