HydrogenAudio

Hydrogenaudio Forum => Site Related Discussion => Topic started by: probedb on 2018-01-31 08:32:03

Title: Theme change?
Post by: probedb on 2018-01-31 08:32:03
So what's happened guys?

Theme has turned to some God awful fixed width thing and even if I try and set it back to Forum Default it won't change back?
Title: Re: Theme change?
Post by: probedb on 2018-01-31 08:33:43
OK this is awful. Is there any reason why the old theme has been removed completely?
Title: Re: Theme change?
Post by: robert on 2018-01-31 09:35:17
I would like to get back the old theme too.
Title: Re: Theme change?
Post by: soundping on 2018-01-31 09:49:55
The ElkArte board is a lot better.  :) 
Title: Re: Theme change?
Post by: Funkstar De Luxe on 2018-01-31 10:37:29
I like the new one.
Title: Re: Theme change?
Post by: carpman on 2018-01-31 11:40:32
I would like to get back the old theme too.
Same.

C.
Title: Re: Theme change?
Post by: TheQwertiest on 2018-01-31 12:08:44
Same.

C.
Same.

Reasons:
- Posts in 'Recent topics' section don't have 'new' tags anymore.
- Different behavior when clicking on topic from 'Recent topics' section and when clicking directly from forum: the former always goes to the latest post, which is annoying.
- 'Recent topics' section is not displayed in mobile view.
- Subjective: green color is meh... Also mismatches with HA logo color.
Title: Re: Theme change?
Post by: Porcus on 2018-01-31 12:31:01
Count me in the pack of old grumpy cats / other animals who frown at change.
Title: Re: Theme change?
Post by: robert on 2018-01-31 12:45:21
Count me in the pack of old grumpy cats / other animals who frown at change.
I like change, but only if it is a change for the better. Right now, the design is ugly, the flavicon isn't HA anymore, and most important, functionality of the board is lacking.
Title: Re: Theme change?
Post by: TheQwertiest on 2018-01-31 13:34:27
Darn... Colors are getting worse... Check out that yellow in the post meter >_<

[EDIT]: Aliased icons in the header do not help either...
Title: Re: Theme change?
Post by: ajinfla on 2018-01-31 13:50:46
Russians?
Title: Re: Theme change?
Post by: punkrockdude on 2018-01-31 14:56:05
I would like any theme that let's you choose what page of a topic you want to go to instead of just landing on page one. This hasn't been possible in a couple of years.
Title: Re: Theme change?
Post by: carpman on 2018-01-31 14:56:43
Russians?
It's the only rational explanation.

C.
Title: Re: Theme change?
Post by: MordredKLB on 2018-01-31 16:02:48
Yeah, not a fan of the new look either.
Title: Re: Theme change?
Post by: eldarien on 2018-01-31 16:06:57
OMG. Color is obviously horribly wrong, but fixed width on a 27'' monitor? C'mon admins...
Title: Re: Theme change?
Post by: eahm on 2018-01-31 16:12:02
...I really like the new style but I would change the colors to the old blue and you need to make the logo clickable, that's how I go back to the home page ON EVERY WEBSITE.
Title: Re: Theme change?
Post by: fuflo on 2018-01-31 17:24:34
I would like the dark theme back, or something of the sort  :(
Title: Re: Theme change?
Post by: Case on 2018-01-31 17:26:10
I can only assume kode54 updated the forum without having HA theme working to fix some serious security issue. No other reason for this hideous and unusable theme.
Title: Re: Theme change?
Post by: jazzthieve on 2018-01-31 18:21:56
Not a fan of this new theme too. Can't distinguish between newly responded topics anymore.
Title: Re: Theme change?
Post by: zeremy on 2018-01-31 18:33:47
Probably updated ElkArte to v1.1.1....  or an early St Patrick's day
Title: Re: Theme change?
Post by: Wombat on 2018-01-31 21:37:22
It is almost the same as lately when the forum software had the big change. Guess kode54 was happy enough to got it upgraded last night. Now it simply is pretty default and banner action, colors, go to last post and other tunings will come back as soon kode54 finds the time.
Title: Re: Theme change?
Post by: includemeout on 2018-01-31 22:51:13
....  or an early St Patrick's day
Yeah, of this kind:
(http://www.therooster.com/sites/default/files/styles/hero/public/wwstpattysday.jpg?itok=yyVuVa7P)
Title: Re: Theme change?
Post by: includemeout on 2018-01-31 22:52:49
Also it's been madening to quote someone and write after said quote, on account of the cursor on either Chrome or Firefox not showing up outside the quotation. Had to resort to the 'View source' option for the quote above.
Title: Re: Theme change?
Post by: kode54 on 2018-02-01 00:24:00
I updated the forum. Thanks to the no-support design of this lovely FOSS forum, I have to redo the theme from scratch every time they decide to rearrange the theme format. This also means that the old "dark" theme, Silence, is completely broken, even though I updated it to the latest version before giving up and removing it.

I'll have to redo the colors, and bug the developers about why they hard coded a fixed width into the forum theme even though I have it configured to 100% in the settings.

And the cursor works fine here.

I'll upload the theme files to a Git repository again, and welcome pull releases for changes to fix things, since it's painful for me to even think in CSS, much less work with the code at all.

Here's the mess, anyone want to help restoring the altered colors and other theme bits?

https://github.com/kode54/hydrogenaudio-elkarte-theme
Title: Re: Theme change?
Post by: Makaki on 2018-02-01 06:59:48
I don't exactly visit every day, and I have a short memory. So it's kind of hard to compare the current theme to what is left in my head. I know it looks uglier, but I don't know exactly why?

Could you list a set of goals you want to achieve while we transition the current theme to our liking? And then we can tackle them one at a time. Maybe we won't get 100% to where we were, but somewhere everybody can feel comfortable.

I hear width as a priority? How wide?
And Colors? maybe we could do some simple swaps?
Title: Re: Theme change?
Post by: jsrtheta on 2018-02-01 07:47:27
Now my eyes hurt.
Title: Re: Theme change?
Post by: carpman on 2018-02-01 14:20:55
This kind of theme audit might be handy:
(https://s10.postimg.org/k5nxq74wp/ha-theme-restore.jpg)

C.
Title: Re: Theme change?
Post by: carpman on 2018-02-01 14:28:11
Here's the old site:
https://web.archive.org/web/20170317233436/http://www.hydrogenaud.io/

Attached are the css files related to the above theme.

C.
Title: Re: Theme change?
Post by: TheQwertiest on 2018-02-01 17:01:21
I updated the forum. Thanks to the no-support design of this lovely FOSS forum, I have to redo the theme from scratch every time they decide to rearrange the theme format.
Glad to hear that design change was not intentional! Hopefully it won't take to long to transform it back =)
Title: Re: Theme change?
Post by: Case on 2018-02-01 18:45:48
I made a quick greasemonkey hack to restore the logo as a working button and change some colors to more familiar look.
Code: [Select]
// ==UserScript==
// @name          Hydrogenaudio
// @description   Slightly improve the looks and usability of current HA
// @version       1.0
// @namespace     https://hydrogenaud.io
// @include       https://hydrogenaud.io/*
// @run-at        document-start
// @grant         none
// @noframes
// ==/UserScript==

(function(){
  var css = `
    #forumtitle a, #forumtitle a:link, #forumtitle a:hover {
      padding: 0 !important;
      margin: 0 !important;
      border: 0 !important;
    }
    body {
      color: #000 !important;
    }
    #top_section {
      border: #555 !important;
      border-top: 1px solid !important;
      border-bottom: 1px solid !important;
      border-radius: 0 !important;
      background: #fafafa !important;
      box-shadow: none !important;
    }
    #footer_section {
      border-top: 1px solid #555 !important;
      box-shadow: none !important;
    }
    #footer_section a, #footer_section a:link, #footer_section a:hover, #footer_section a:visited {
      color: #bbb !important;
    }
    #wrapper {
      border: 1px solid #555 !important;
      border-radius: 0 !important;
      box-shadow: none !important;
    }
    .wrapper {
      max-width: 90% !important;
    }
    a, a:link, a:link, a:visited, a.new_win:link, a.new_win:visited {
      color: #000 !important;
    }
    .listlevel1 { margin: 0 !important; padding: 0 !important; }
    #menu_nav .linklevel1, #menu_nav .linklevel1:link, #menu_nav .linklevel1:visited, #menu_current_area > strong > .linklevel1 {
      color: #000 !important;
      border-color: #555 !important;
      background: #f4f4f4 !important;
    }
    #menu_nav .linklevel1:hover, .listlevel1:hover .linklevel1, .linklevel2:hover, .listlevel2:hover .linklevel2, .linklevel3:hover, .listlevel3:hover .linklevel3, #menu_sidebar .linklevel1:hover, #menu_sidebar .listlevel1:hover .linklevel1 {
      color: #000 !important;
      border-color: #555 !important;
      background: #fafafa !important;
    }
    #menu_nav .linklevel1.active, .buttonlist .linklevel1.active, #collapse_button .linklevel1, .pm_indicator, .likes_indicator {
      color: #fff !important;
      border-color: #555 !important;
      background: #5176b5 !important;
    }
    #menu_nav .linklevel1.active:hover, .buttonlist .linklevel1.active:hover, .listlevel1:hover .linklevel1.active, #collapse_button .linklevel1:hover, .linklevel1:hover .pm_indicator, .listlevel1:hover .active {
      color: #fff !important;
      border-color: #555 !important;
      background: #6186c5 !important;
    }
    .linktree:last-child, .linktree:last-child::after, .linktree:last-child a, .linktree:last-child a:link, .linktree:last-child a:visited {
      color: #fff !important;
      background: #5176b5 !important;
    }
    .linktree:hover, .linktree:hover::after, .linktree:last-child:hover, .linktree-last-child:hover::after, .linktree:last-child a:hover {
      color: #fff !important;
      background: #6186c5 !important;
    }
    .category_header, .content_category .category_header {
      color: #fff !important;
      background: #5176b5 !important;
      text-shadow: none !important;
    }
    .category_header a:link, .category_header a:visited, .category_header a:hover {
      color: #fff !important;
    }
    ::selection {
      color: #fff !important;
      background: #5176b5 !important;
    }
  `;

  function addStyle(css) {
    let node=document.createElement("style");
    node.type="text/css";
    node.setAttribute("id", "custom_style");
    node.appendChild(document.createTextNode(css));
    let heads=document.getElementsByTagName("head");
    if (heads.length > 0) {
      heads[0].appendChild(node);
    } else {
      document.documentElement.appendChild(node);
    }
  }

  addStyle(css);

  function main() {
    let logo=document.getElementById("logobox");
    if (logo) {
      let link=document.createElement("a");
      link.href="/";
      link.innerHTML=logo.outerHTML;
      logo.parentNode.replaceChild(link, logo);
    }
  }

  function checkreadiness() {
    let ready=false;
    if (document.readyState === "interactive" || document.readyState === "complete") {
      ready=true;
    } else {
      let logo=document.getElementById("logobox");
      if (logo) ready=true;
    }
    if (ready) {
      main();
    } else {
      window.setTimeout(checkreadiness, 10);
    }
  }

  window.setTimeout(checkreadiness, 1);
})();
Title: Re: Theme change?
Post by: probedb on 2018-02-01 21:13:41
I'll see if I have time this weekend to check it out and play. Maybe I can use my Friday afternoon learning time at work to do it ;)
Title: Re: Theme change?
Post by: 2tec on 2018-02-02 23:11:36
I updated the forum.
Yea, thanks for all your time and effort.

I'm also looking forward to when HA looks dark again. ;-)
Title: Re: Theme change?
Post by: Coreda on 2018-02-03 00:24:53
I updated the forum. Thanks to the no-support design of this lovely FOSS forum, I have to redo the theme from scratch every time they decide to rearrange the theme format. This also means that the old "dark" theme, Silence, is completely broken, even though I updated it to the latest version before giving up and removing it.

I'll have to redo the colors, and bug the developers about why they hard coded a fixed width into the forum theme even though I have it configured to 100% in the settings.

Do you know which elements changed/were affected by the update? Wondering how usable would be to retain the original stylesheets and just adjust for the changed elements from the update.
Title: Re: Theme change?
Post by: Alexander Ostuni on 2018-02-03 12:08:20
only bad thing for me is the fixed widht. The monitors get bigger and the result is wasted space to the left and right ?
Title: Re: Theme change?
Post by: LordWarlock on 2018-02-03 13:19:52
Well, the problem with long lines in multiline text is that it substantially lowers readability once over the recommended threshold (60 - 75 chars). Although forums are a bit specific, since the posts are usually very short, it's still not a good idea to have the lines overly long.
Title: Re: Theme change?
Post by: Apesbrain on 2018-02-06 00:32:47
Nice to have the blue back, thanks.
Title: Re: Theme change?
Post by: andy o on 2018-02-06 03:34:23
Highlighting text is dark-on-dark, can't see anything. Otherwise, the colors don't really bother me, besides the HA blue branding issue.

But since you're redesigning things, would it be possible to have back the multiple pages of "recent topics" that was on the front page of the old-old theme? If I don't log in for a few days, I have to go hunt into each individual forum for recent posts that I might have missed, where before one could just click on subsequent pages of recent topics right from the front page.
Title: Re: Theme change?
Post by: kode54 on 2018-02-06 07:22:49
The forum still has recent posts on the main page, and on the foobar2000 subforum. I guess they removed pagination from the portal?

You could do like I do and hit up the New Posts button every few days, but that may include forums you don't care about.
Title: Re: Theme change?
Post by: Pusherman on 2018-02-06 11:54:54
Blue is better. Bit more contrast for texts would be good.
Title: Re: Theme change?
Post by: includemeout on 2018-02-06 14:44:57
Yay! Blue is back! Thanks @kode54‍  and others for all the effort you've been putting in.

I wish my web designing skills weren't still at Khan Academy level, so I could chip in somehow.
Title: Re: Theme change?
Post by: soundping on 2018-02-06 21:43:43
It ain't easy being green.
Title: Re: Theme change?
Post by: TheQwertiest on 2018-02-08 08:59:54
@zeremy @kode54 :
Great job restoring the colors!

Remaining bugs that I've encountered:
- Missing forum icon (both in desktop and mobile view): https://imgur.com/8ksqbls
- White border around avatar in mobile view (the easiest workaround is to center image, to make the border less prominent): https://imgur.com/HX9btpx

Missing features from the old skin: recent posts panel in mobile view.

Also text color on quick reply buttons and post edit buttons should be probably black for consistency with other buttons.
Title: Re: Theme change?
Post by: TheQwertiest on 2018-02-09 11:09:18
FYI: new icons are borked in mobile view: https://imgur.com/XINbRn5
Title: Re: Theme change?
Post by: kode54 on 2018-02-09 23:21:18
They're borked on desktop view, too. I think @zeremy missed that FontAwesome is not imported by the forum, but rather, that the existing icons are inlined SVG symbols.
Title: Re: Theme change?
Post by: zeremy on 2018-02-10 10:15:10
@kode54

The "button_forum" seems to attempt to load an extra icon .

Code: [Select]
<li id="button_forum" class="listlevel1">
<a class="linklevel1" href="https://hydrogenaud.io/index.php?action=forum"><i class="icon icon-menu icon-lg " title="Forum"></i> <span class="button_title" aria-hidden="true">Forum</span></a>
</li>

I'll try to fix the icons using this reference.
https://www.elkarte.net/community/index.php?topic=2497.msg27780#msg27780
Title: Re: Theme change?
Post by: zeremy on 2018-02-11 16:01:02
Also the "Wiki" and "foobar2000 Forums" icons are not visible, in either desktop or mobile mode.

PR up  ;)
Title: Re: Theme change?
Post by: polemon on 2018-02-11 17:22:13
I'm trying the  "lite" theme right now, and the buttons at the top are also broken in the "mobile" version (narrow aspect).

In general it seems things stopped being visible, etc. The scroll-arrows on the left are now just outlines of the clickable areas, and pretty much all buttons seems to be kinda miss-aligned or something. In the mobile version, the button for the Wiki is not present at all, while the icon for the Forum is just an empty box, but at least it's clickable.
Title: Re: Theme change?
Post by: Apesbrain on 2018-02-12 17:34:18
favicon is back! Site looks good. Thanks.
Title: Re: Theme change?
Post by: davideleo on 2018-02-19 09:42:17
I used to be able to search by keyword within a single thread. Now, as far as I can see, it is only possible to narrow the search down to sub-boards. Did I overlook some menu item or command button? If not, is there any plan to restore the functionality or is it a permanent change?
Search by thread is extremely important, I'd dare say vital, for foobies browsing the jscript support thread, to give but one example.
Title: Re: Theme change?
Post by: zeremy on 2018-02-19 10:57:02
I used to be able to search by keyword within a single thread. Now, as far as I can see, it is only possible to narrow the search down to sub-boards. Did I overlook some menu item or command button? If not, is there any plan to restore the functionality or is it a permanent change?
Search by thread is extremely important, I'd dare say vital, for foobies browsing the jscript support thread, to give but one example.
Go the topic that you want to search in first and then define the search term.
The search will display entries from that topic.
Title: Re: Theme change?
Post by: davideleo on 2018-02-19 11:15:03
Go the topic that you want to search in first and then define the search term.

Thanks zeremy, but where am I supposed to define the search term? The only search command I can find is the one in the "Community" menu (see attached pic), which leads to the general search settings page.
Title: Re: Theme change?
Post by: zeremy on 2018-02-19 11:31:25
Say you want to search the Topic: JScript Panel script discussion/help
Go to the topic click https://hydrogenaud.io/index.php/topic,110516.0.html and display the topic.

At the top right corner of the page is the search box.
Enter the term to search in the topic.

Title: Re: Theme change?
Post by: davideleo on 2018-02-19 11:38:54
At the top right corner of the page is the search box.

 :o That's how it used to be, but I see no search box anymore in the top right corner.
Title: Re: Theme change?
Post by: davideleo on 2018-02-19 11:44:35
Alright, I get it now. I was using the "light" variant, changed it to the "be social". Sorry I just learned about this option. I guess I was totally missing the point of the whole discussion thread!  :))
Title: Re: Theme change?
Post by: Alexander Ostuni on 2018-02-19 19:32:37
So it stays now that left and right is a huge unused space although I have bought extra a wide monitor ?
Thats progress....
Title: Re: Theme change?
Post by: rutra80 on 2018-02-27 21:08:34
Shouldn't the ability to update the engine without massive handcraft be a lil bit higher on requirements priority list of forum software to use?
Title: Re: Theme change?
Post by: kode54 on 2018-02-28 01:06:17
And which forum are you suggesting I spend weeks migrating to, that isn't going to be a headache some time down the line when a major upgrade comes along?
Title: Re: Theme change?
Post by: rutra80 on 2018-02-28 01:36:38
I didn't have anything particular in mind, sorry. Maybe pull some average of how much your time is worth and invest into some payware? Or revive some kind of donations?
Title: Re: Theme change?
Post by: kode54 on 2018-03-02 02:20:31
As if any payware forum is any less of a hassle. Unless you were suggesting also hiring someone to handle the migration, and paying someone to keep the theme up to date. I'm sure that would be a great reason to open up donations again, especially since the current system involves me donating my time to maintain this server, with Spoon donating the actual (virtual) server.
Title: Re: Theme change?
Post by: TheQwertiest on 2018-03-24 16:00:45
@kode54 :
A small bug: "You have new private messages" icon on the top panel is empty in mobile view