Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1373670 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #1650 –
impatiently awaiting next version as i'm planning to rebuild my complete database with anv disabled!  there were some cases i found that plugin was fetching eg. 4 tracks although release had only 2 and the last "2" tracks were empty lines in left window. if i remember right it happend to vinyl releases. i'll try to find some examples again. all in all its really awesome that you got your hands on further development of foo_discogs. THX

got one: http://www.discogs.com/release/3431794

foo_discogs

Reply #1652 –
Quote from: protopoint on
You just need to update discogs release - delete empty tracks.


thx, so i did. first active contribution to discogs!  quite hard to find out whithout going into edit mode of the release...

foo_discogs

Reply #1653 –
Quote from: zoomorph on
[..]
In 1.5.3, "Replace ANVs" in the Update Tags dialog will be linked with "Replace ANVs" for the Release and Configuration dialogs, so they will all carry the same value.

Thanks! While you're at it, it would be useful to me if the cache could be cleared from the update dialogue as well. Cheers.

foo_discogs

Reply #1654 –
Here is a preview of the next release:
https://www.sendspace.com/file/ydhhm7

Apart from bug fixes, it now attempts to handle hidden tracks. All of the releases supplied by protopoint should be parsed correctly (in terms of track numbers -- 5450552 doesn't take the titles/durations from the indexes which maybe it should).

Future work:
* Sum up the track durations of hidden tracks. Perhaps take duration from previous index track.
* Add tags for information about hidden tracks.

Hidden tracks are currently shown in the track list like "Artist - Track  [+1 hidden track]"

Please test it out and let me know if there are any bugs (any releases that are wrongly parsed should be considered bugs).

Thanks!

foo_discogs

Reply #1655 –
Quote from: zoomorph on
Here is a preview of the next release:
https://www.sendspace.com/file/ydhhm7

Apart from bug fixes, it now attempts to handle hidden tracks. All of the releases supplied by protopoint should be parsed correctly (in terms of track numbers -- 5450552 doesn't take the titles/durations from the indexes which maybe it should).

Future work:
* Sum up the track durations of hidden tracks. Perhaps take duration from previous index track.
* Add tags for information about hidden tracks.

Hidden tracks are currently shown in the track list like "Artist - Track  [+1 hidden track]"

Please test it out and let me know if there are any bugs (any releases that are wrongly parsed should be considered bugs).

Thanks!


so no plans for adding "series"-tag?

foo_discogs

Reply #1656 –
Quote from: zoomorph on
Please test it out and let me know if there are any bugs (any releases that are wrongly parsed should be considered bugs).

Please take a look at this release: http://www.discogs.com/Various-Pulp-Fictio...release/3279180

Discogs lists among others the following tracks:

[blockquote]1-1a    No Artist                Pumpkin And Honey Bunny    0:11
1-1b    Dick Dale & His Del-Tones    Misirlou                2:16
[/blockquote]
Discogs tagger will list this track as:

[blockquote]No Artist - Pumpkin and Honey Bunny [+1hidden] 0:11[/blockquote]

Aside from that it seems to work great!

I noticed a bug with the tracklisting of some releases though, where Discogs tagger adds two empty tracks to the listing. This bug was already present in the previous version. Examples:
http://www.discogs.com/Quest-Vampires/release/6515401
http://www.discogs.com/release/2472199

I also have a few unrelated suggestions for this plugin:

  • Rename the 'Write tags' context menu item to something more intuitive for new users like 'Select/Find Release & Write Tags'.
  • make the 'Find Release/Release' dialogs resizable. This would make using the scrollbar on the listboxes a lot less neccesary.
  • make the filter box in the 'Find Release' more robust; allow searching for multiple words for example...
  • add reset button in the 'release' dialog to restore everything to the initial dialog state. ( re-add deleted tracks and such )


Thank you for the continued development of this great plugin!

foo_discogs

Reply #1657 –
Quote from: dumbnumbscum on
I noticed a bug with the tracklisting of some releases though, where Discogs tagger adds two empty tracks to the listing. This bug was already present in the previous version. Examples:
http://www.discogs.com/Quest-Vampires/release/6515401
http://www.discogs.com/release/2472199


same "problem" as previously mentioned. if you edit this releases directly on discogs you'll see that those 2 "hidden" tracks got created for whatever reason. you can delete them @discogs if you want! so no bug of foo_discogs!

foo_discogs

Reply #1658 –
Quote from: alexinc on
so no plans for adding "series"-tag?

I'm not against it, it's just difficult to add tags as it currently works.

Quote from: dumbnumbscum on
Please take a look at this release: http://www.discogs.com/Various-Pulp-Fictio...release/3279180

That's intentional. Hidden tracks (part a, b in the same audio file) is what the latest release is designed to handle.

Quote from: dumbnumbscum on
I noticed a bug with the tracklisting of some releases though, where Discogs tagger adds two empty tracks to the listing. This bug was already present in the previous version. Examples:
http://www.discogs.com/Quest-Vampires/release/6515401
http://www.discogs.com/release/2472199

That's more like a bug with Discogs IMO, but I've made foo_discogs ignore empty tracks now since it's been brought up many times. :-)

Quote from: dumbnumbscum on
  • Rename the 'Write tags' context menu item to something more intuitive for new users like 'Select/Find Release & Write Tags'.
  • make the 'Find Release/Release' dialogs resizable. This would make using the scrollbar on the listboxes a lot less neccesary.
  • make the filter box in the 'Find Release' more robust; allow searching for multiple words for example...
  • add reset button in the 'release' dialog to restore everything to the initial dialog state. ( re-add deleted tracks and such )

Thanks for the feedback!

foo_discogs

Reply #1659 –
1.
Quote from: dumbnumbscum on
I noticed a bug with the tracklisting of some releases though, where Discogs tagger adds two empty tracks to the listing. This bug was already present in the previous version. Examples:
http://www.discogs.com/Quest-Vampires/release/6515401
http://www.discogs.com/release/2472199


When you create new release at Discogs it always comes with 4 tracks by default which are empty. For 2 tracks Vinyl releases users fill only first two and forget to delete other two.

2.
Bug with ANVs check buttons doesn't fixed well. They are still disabled for http://www.discogs.com/release/3279180.

3.
Hidden tracks issue doesn't work always well (depend on track style numbering). http://www.discogs.com/release/1485101.

4.
But one more thing that wasn't mentioned before. There are some releases which has hidden track in first pregap of CD. In Discogs they are numbered as track #00 ( http://www.discogs.com/release/3185, http://www.discogs.com/release/205516). In plugin now it started with 1 and Disc total tracks also counted +1. For instance audioCD has 14 tracks but release has 15 tracks in discogs and we have 15 audio files ripped.
Dear Zoomorph, could you update DLL to handle these issue either?

5.
artist naming ‘abc pres. def feat. xyz' always becomes ‘abc pres. def pres. xyz' is fixed.

Zoomorph, tnx for updating!

foo_discogs

Reply #1660 –
Quote from: alexinc on
same "problem" as previously mentioned. if you edit this releases directly on discogs you'll see that those 2 "hidden" tracks got created for whatever reason. you can delete them @discogs if you want! so no bug of foo_discogs!


Quote from: zoomorph on
That's more like a bug with Discogs IMO, but I've made foo_discogs ignore empty tracks now since it's been brought up many times. :-)


Ah, now that I see where the error comes from I have to agree that Discogs is where this should be fixed. Either way, thank you for the reponse guys.

foo_discogs

Reply #1662 –
Quote from: protopoint on
2.
Bug with ANVs check buttons doesn't fixed well. They are still disabled for http://www.discogs.com/release/3279180.

No ANV = disabled. In this case, there's an ANV in a hidden track (which currently doesn't do anything), but I've fixed it to enable the buttons anyway.

Quote from: protopoint on
3.
Hidden tracks issue doesn't work always well (depend on track style numbering). http://www.discogs.com/release/1485101.

I don't think that formatting is valid as per Discogs guidelines, but I know a few releases have used it, so I'll restore support for it.

Quote from: protopoint on
4.
But one more thing that wasn't mentioned before. There are some releases which has hidden track in first pregap of CD. In Discogs they are numbered as track #00 ( http://www.discogs.com/release/3185, http://www.discogs.com/release/205516). In plugin now it started with 1 and Disc total tracks also counted +1. For instance audioCD has 14 tracks but release has 15 tracks in discogs and we have 15 audio files ripped.

15 total files sounds correct. foo_discogs always starts track numbering at 1, ignoring Discogs' track numbering. Would you prefer it to start at zero in this case?

Quote from: a3aan on
I just tried to tag http://www.discogs.com/release/421431. The plugin concludes it is a two disk release with the audio tracks on one disc, and the video track on the other disc.

Thanks... I've fixed that. :-)

Updated version with these fixes:
https://www.sendspace.com/file/l0kvdj
 

foo_discogs

Reply #1663 –
Firstly thanks for an amazing plugin! I've been using this for sometime now and am appreciating all the work you have put into it.
I'm still trying to trawl through my years of digital music collecting and I'm still having trouble getting ontop of it all.

Is there any way I can batch process the music tagging and quickly review the matches? Doing album's one by one is killing me!

foo_discogs

Reply #1664 –
Quote from: party on
Firstly thanks for an amazing plugin! I've been using this for sometime now and am appreciating all the work you have put into it.
I'm still trying to trawl through my years of digital music collecting and I'm still having trouble getting ontop of it all.

Is there any way I can batch process the music tagging and quickly review the matches? Doing album's one by one is killing me!

There's currently nothing like that in foo_discogs. Anything that has multiple versions on Discogs, which is the majority of releases, will require manual review one way or another if you want to get the right version.

foo_discogs

Reply #1665 –
Quote from: party on
Is there any way I can batch process the music tagging and quickly review the matches? Doing album's one by one is killing me!


not a foobar component but a separate application can do that.

https://picard.musicbrainz.org/

obviously this uses musicbrainz as the source rather than discogs.

foo_discogs

Reply #1666 –
Hi Zoomorph!
Bugs report once again))

1. One more issue - firstly I faced with it early but couldn't reproduce. When you update DLL some Configuration settings changed automatically but not to defaults:
- You should oAuth DLL again (i beleive this is how it should work as DLL changed) but when I replace current file with the same copy you should authorize again (DLL stays the same)
- Tagging tab
[blockquote]  - field Album artist tag for compilations field becoming empty,
  - check buttons Replace ANVs, Move 'The', Format disc numbers on 2 digits, Automatically match tracks becoming unchecked (were checked),
  - check buttons Discard suffixes, start track at 1, show Length column becoming checked (were unchecked),[/blockquote]
- Album/Artist art tab
[blockquote]  - Directory and File prefix fields becoming empty,
  - all check buttons becoming empty (were checked),[/blockquote]
2. ANVs check buttons are always enabled. Good to see this! Issue is closed.
3. Hidden track issue works well with releases I checked. Even Yes release http://www.discogs.com/release/5450552 looks pretty well. I believe DLL can use total discs number from discogs to match it with track numbering.
4. Total tracks number for CDs with hidden pregaps and data/video files. I believe that it should be exact as CD player shows. As for me I keep releases like http://www.discogs.com/release/3185 with , http://www.discogs.com/release/205516 with 14 total tracks both, http://www.discogs.com/release/421431 with 3 tracks. I imagine there are releases with other hidden pregaps between tracks, users could keep them as separate audio files but they shouldn't have affect on total tracks counting. So yes for releases with hidden 1st pregap I'd like they would be counted starting from 0 and don't count hidden pregaps in total tracks number.

Regards!

foo_discogs

Reply #1667 –
Thanks again for the feedback.

Quote from: protopoint on
1. One more issue - firstly I faced with it early but couldn't reproduce. When you update DLL some Configuration settings changed automatically but not to defaults:

Fixed!

I've been busy converting the GUI to use WTL, which means that the find_release and release dialogs can now be resized.

Here's a preview if anyone would like to test it:
https://www.sendspace.com/file/65ta04

(Note: using this version could mess up your conf settings for future versions.)

foo_discogs

Reply #1668 –
Quote from: zoomorph on
Thanks again for the feedback.

Quote from: protopoint on
1. One more issue - firstly I faced with it early but couldn't reproduce. When you update DLL some Configuration settings changed automatically but not to defaults:

Fixed!

I've been busy converting the GUI to use WTL, which means that the find_release and release dialogs can now be resized.

Here's a preview if anyone would like to test it:
https://www.sendspace.com/file/65ta04

(Note: using this version could mess up your conf settings for future versions.)


Thanx! As for resizing - works great except positioning window after resizing - it always in the middle of the screen based on default window size as it was in previous DLL version. I believe it should be centralized based on new window size.

And after all I suppose you can publish new DLL version officially))

Regards!

foo_discogs

Reply #1669 –
Quote from: zoomorph on
I've been busy converting the GUI to use WTL, which means that the find_release and release dialogs can now be resized.


Yes... This works great. Thank you for implementing this!

Maybe it is a good idea to give the "edit tag mappings" dialog the same treatment?
Another small improvement to this dialog would be moving the "default mappings" button to below the divider. This way the listbox would be a little bit bigger and thus more useful, even without the window resizing...

Keep up the good work!

foo_discogs

Reply #1670 –
it would be nice if you could edit the year field like the genre/style - or, even more better an option to use always the year of the master release.

i know that many people use the release date of various editions, but i always use the releaseyear of the initial release and i bet that's not that uncommon. 

keep up the good work

foo_discogs

Reply #1671 –
Quote from: protopoint on
Thanx! As for resizing - works great except positioning window after resizing - it always in the middle of the screen based on default window size as it was in previous DLL version. I believe it should be centralized based on new window size.

Fixed. New version is now public.

Quote from: dumbnumbscum on
Maybe it is a good idea to give the "edit tag mappings" dialog the same treatment?
Another small improvement to this dialog would be moving the "default mappings" button to below the divider. This way the listbox would be a little bit bigger and thus more useful, even without the window resizing...

I'd like to rework the tag mappings dialog completely. I'd like to replace hard-coded tag mappings with titleformatting-like strings so that users can change and add their own arbitrary tag mappings. This will be difficult so don't hold your breath for it.

Quote from: Der Internet on
i know that many people use the release date of various editions, but i always use the releaseyear of the initial release and i bet that's not that uncommon.

I'm thinking that exposing the release date of the master release (already in the backlog) could work for this. Usually, the master release version is set as the earliest version.

foo_discogs

Reply #1672 –
The new version not work in my XP.
When i start search the Discogs window become semi-transparent and unusable.

foo_discogs

Reply #1673 –
Quote from: Forfit on
The new version not work in my XP.
When i start search the Discogs window become semi-transparent and unusable.

Thanks for the report. Please try version 1.54. I believe this should be fixed.

foo_discogs

Reply #1674 –
1.54 keeps updating.