Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1373675 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #1400 –
Hello, I get error "discogs error: release id=2437847: problem connecting to discogs.com" with new version. Has anybody handled this?

foo_discogs

Reply #1401 –
Quote from: Anakunda on
Hello, I get error "discogs error: release id=2437847: problem connecting to discogs.com" with new version. Has anybody handled this?


no, but it must be mapping related. if you delete any old foo_discogs.cll.cfg (back it up before) then there won't be an error anymore but only a few discogs 
tags are written to the file. didn't have time nor patience to try which attribute makes it fails (must be at least one)

* you can edit mappings in the write tag window which appears once you've selected a release.

foo_discogs

Reply #1402 –
If I apply default mappings it writes tags but gives another error foo_discogs: error: could not save url=, skipping...
Plugin needs a fix

foo_discogs

Reply #1403 –
It turns out the artist-related tags weren't working and were causing that error message. Hopefully your old discogs.dll.cfgs will work now.

Fixed the composition artist names.

No idea why "CD, Album" gets written in the tag as "CD, @lbum". "CD, Album, <something>" works fine.

v.134 - https://www.sendspace.com/file/yed26y

foo_discogs

Reply #1404 –
I still'm getting the foo_discogs: error: could not save url=, skipping...

foo_discogs

Reply #1406 –
Probably
Turning ON Artist art: Fetch or Fetch all available art causing this
Album art: Fetcg doesnot causing this but neither does fetch album art

foo_discogs

Reply #1407 –
Quote from: zoomorph on
Is that related to fetching artwork? I haven't looked into that yet...


First of all thank you very much zoomorth for picking this up again and bubbleguum for providing the sources!

I am more than delight to see this work continued.

Concerning album art: Regardless of what I set in the properties it won't fetch anything.
- enabling "fetch" only: No album art gets downloaded and no error message appears
- Enabling "Display  preview in release dialogue" and / or "Fetch all  available art" gives the error "foo_discogs: error: could not save url=, skipping..."

As for the tags everything looks good. The only thing I found is that the tag for "Unmodofied  track position" = "DISCOGS_TRACK_POSITION" does not get written.

Thanks again.
 

foo_discogs

Reply #1408 –
Just another remark:

I don't know if this plugin releated: a search for any artist with a longer discography will be incomplete in search, e.g. "björk" releases will stop in the year 2000.

foo_discogs

Reply #1409 –
Apparently album art access requires OAuth, which is why it's now broken.

foo_discogs

Reply #1410 –
Quote from: Chris Norman on
Just another remark:

I don't know if this plugin releated: a search for any artist with a longer discography will be incomplete in search, e.g. "björk" releases will stop in the year 2000.

I've added support for grabbing multiple pages of releases (may take a long time, but they should be cached for the future):
https://www.sendspace.com/file/s8qs6a

foo_discogs

Reply #1411 –
Quote from: zoomorph on
I've added support for grabbing multiple pages of releases (may take a long time, but they should be cached for the future):
https://www.sendspace.com/file/s8qs6a


zoomorph thank you for quick updates. Some other points:
- somehow %style% tag was misspelled - for this release tag was written as "Abstqact" instead of "Abstract". Another release, %style% was written as "Expeqimental" instead of "Experimental". Looks like we have pqoblem with R pqonounciation  At the same time, "Techno; UK Garage; IDM; Abstract" for this was written with no mistakes;
- same release, now it's about format - tag was written as "CDr, Album, Album" instead of "CDr, Album, Promo". Another release, format tag was written as "27 x File, Album" instead of "27 × File, MP3". Looks like all text (non-linked) words (e.g. Reissue, Remastered, MP3) are replaced with "Album";
- now Lamar's release, %DISCOGS_FORMAT% was written as "2 x BD, Album" instead of "2 × CD, Album, Deluxe Edition" (Deluxe Edition was omitted);
- "CD, @lbum" problem still persists.


I really appreciate your help, please let me know how I can buy you a beer via PP 

foo_discogs

Reply #1412 –
Thanks for the bug reports. I'm really not sure what's causing those odd typos but I'll look into it.

PP: jsilver.pmc@gmail.com 

OAuth support is almost done. It's been a royal pain in the ass as expected.

foo_discogs

Reply #1413 –
Quote from: zoomorph on
Thanks for the bug reports. I'm really not sure what's causing those odd typos but I'll look into it.


I'd look first if the json data is not buggy itself on the release having this issue. It wouldn't be the first time that json / xml data does not match the web site.

Quote from: zoomorph on
OAuth support is almost done. It's been a royal pain in the ass as expected.


Nice!

foo_discogs

Reply #1414 –
Quote from: bubbleguuum on
Quote from: zoomorph on
Thanks for the bug reports. I'm really not sure what's causing those odd typos but I'll look into it.


I'd look first if the json data is not buggy itself on the release having this issue. It wouldn't be the first time that json / xml data does not match the web site.

Quote from: zoomorph on
OAuth support is almost done. It's been a royal pain in the ass as expected.


Nice!

+1

EDIT: @zoomorpth, when the album art thing is ready will this require a new version of the plug-in?

foo_discogs

Reply #1415 –
OK, here it is... first attempt at OAuth support.
https://www.sendspace.com/file/j3mjo5

You have to set up OAuth in the configuration tab. In the future this should probably be made easier.

By default it uses OAuth for everything if a token/key is configured.

Album art works. :-)

Also, the problem with corrupted strings ("CD, @lbum", etc) might be fixed (fingers crossed).

Please try it out and, if no problems are found, upload it to the components site. I'm away for the next week so I won't be around to fix bugs but the source is available if anyone else is interested: https://bitbucket.org/zoomorph/foo_discogs

P.S. - If anyone knows of an *easier* way to use OAuth, let's hear it. Will users really need a Discogs account to use foo_discogs as of Oct. 14? I've thought of shipping it with a built-in token/secret that would all go through my account, but I think Discogs might not like that, and everyone might be rate-limited as though they were one user (not sure if it would actually work, either).

foo_discogs

Reply #1416 –
Quote from: zoomorph on
...snip...

You have to set up OAuth in the configuration tab. In the future this should probably be made easier.

...snip...

Does anyone know how to setup OAuth in the configuration tab? I have been holding off updating the plug-in...

foo_discogs

Reply #1417 –
Quote from: TheEmpathicEar on
Quote from: zoomorph on
...snip...

You have to set up OAuth in the configuration tab. In the future this should probably be made easier.

...snip...

Does anyone know how to setup OAuth in the configuration tab? I have been holding off updating the plug-in...


Simply follow the instructions written on the OAuth configuration tab in the plugin. You only need a Discogs account. Very easy. Thank you zoomorph. Check your PayPal for a sweetie treatie.

foo_discogs

Reply #1418 –
Quote from: zoomorph on
OK, here it is... first attempt at OAuth support.
https://www.sendspace.com/file/j3mjo5


works like a charm    most of issues I wrote earlier were fixed. However:
- this release, %DISCOGS_FORMAT% tag was written as "CDr, Album, Album" instead of "CDr, Album, Promo". Another release, format tag was written as "27 x File, Album" instead of "27 × File, MP3". Another example, format tag was written as "CD, Album, Album, Album" instead of "CD, Album, Reissue, Remastered". Looks like all text (non-linked) words (e.g. Reissue, Remastered, MP3) are replaced with "Album";
- now Lamar's release, %DISCOGS_FORMAT% was written as "2 x CD, Album" instead of "2 × CD, Album, Deluxe Edition" (Deluxe Edition was omitted). At this page Deluxe Edition was in italic, that's the only difference I spotted in comparison with this page.

foo_discogs

Reply #1421 –
Quote from: zoomorph on
Thanks for the report PWSteal.

This update fixes that bug:
https://www.sendspace.com/file/aphg6y

Bonus - unicode HTML entities are now decoded. For example, the beta symbol in track 1 of http://www.discogs.com/release/59116


great! Now there is no more "Album, Album, Album" thing.
For format where part of text is formatted in italic, that particular part is not written. Examples:
- Kendrick Lamar - Deluxe Editioin is missed;
- Beware Of Safety - Pilsner is missed;
- Luke Slater - Slipcase is missed.

Not sure if this italic issue persists for tags other than Format,cannot find pages to test it.

foo_discogs

Reply #1422 –
Quote from: PWSteal on
Quote from: zoomorph on
Thanks for the report PWSteal.

This update fixes that bug:
https://www.sendspace.com/file/aphg6y

Bonus - unicode HTML entities are now decoded. For example, the beta symbol in track 1 of http://www.discogs.com/release/59116


great! Now there is no more "Album, Album, Album" thing.
For format where part of text is formatted in italic, that particular part is not written. Examples:
- Kendrick Lamar - Deluxe Editioin is missed;
- Beware Of Safety - Pilsner is missed;
- Luke Slater - Slipcase is missed.

Not sure if this italic issue persists for tags other than Format,cannot find pages to test it.

I don't think that italic bit (custom format fields) was ever gathered by foo_discogs. It could be added though.

foo_discogs

Reply #1423 –
thx for keeping the plugin updated!

just noticed, that using v1.36 the field DISCOGS_ARTIST_ID isn't written anymore and its content gets written to DISCOGS_ARTIST_LINK which overwrites the name of the artist with its id. artist art doesn't get fetched anymore and "view artist art page" from conext menu leads to error 404.