HydrogenAudio

Hosted Forums => foobar2000 => Support - (fb2k) => Topic started by: EpicForever on 2019-03-27 20:20:22

Title: 1.4.3 bug - playing track from search flushes queue
Post by: EpicForever on 2019-03-27 20:20:22
Hi,
Just wanted to report following bug, that I have never seen before upgrade to 1.4.3. It might happened also in 1.4.2, as I used it for very short time and could possibly not trigger specific scenario in 1.4.2. Here it goes:
- add some tracks to queue, watch the queue as additional playlist
- open media library serach, type something, play something directly from search results
- you will see playback queue flushes after playback starts

Playlist search and playing from there also flushes queue.

OS: Windows 7 x64 PL SP1 MSDNAA with most WU installed, DS output (Juli@ PCI), f2k 1.4.3 with bunch of input plugins installed:

Code: [Select]
Core (2019-03-11 14:06:10 UTC)
    foobar2000 core 1.4.3
foo_abx.dll (2017-08-23 09:35:38 UTC)
    ABX Comparator 2.0.4
foo_ac3.dll (2018-01-26 03:07:58 UTC)
    AC3 decoder 0.9.10
foo_adpcm.dll (2018-01-17 07:27:55 UTC)
    kode54's ADPCM decoders 1.13
foo_albumlist.dll (2019-03-11 14:05:38 UTC)
    Album List 4.6
foo_asap.dll (2014-06-23 12:43:41 UTC)
    ASAP 3.2.0
foo_beatit.dll (2014-07-10 16:08:18 UTC)
    Beat It 0.3
foo_bestversion.dll (2014-02-07 20:54:54 UTC)
    Best Version Picker 1.0.1
foo_bitcompare.dll (2017-04-11 11:11:04 UTC)
    Binary Comparator 2.1.1
foo_cdda.dll (2019-03-11 14:05:44 UTC)
    CD Audio Decoder 3.0
foo_converter.dll (2019-03-11 14:05:40 UTC)
    Converter 1.5.3
foo_convolve.dll (2013-03-27 21:18:27 UTC)
    Convolver 0.3
foo_cuefilter.dll (2009-04-28 14:09:44 UTC)
    CUE Playlist Filter 0.1.7.0
foo_devconsole.dll (2014-02-09 23:19:27 UTC)
    DevConsole 1.0.4async
foo_disccache.dll (2015-08-23 03:52:50 UTC)
    Disc cache warmer 0.2
foo_discogs.dll (2018-05-05 12:35:56 UTC)
    Discogs Tagger 2.14
foo_dsp_deemph.dll (2018-02-09 17:44:07 UTC)
    De-emphasis postprocessor and DSP set 0.2
foo_dsp_effect.dll (2018-11-17 15:29:01 UTC)
    Effect DSP 0.35
foo_dsp_meiercf.dll (2018-01-06 22:27:18 UTC)
    Meier Crossfeed 1.1.1
foo_dsp_mm.dll (2008-06-06 05:29:12 UTC)
    Matrix Mixer 0.3
foo_dsp_multiresampler.dll (2017-06-02 01:41:49 UTC)
    MultiResampler 1.1.2
foo_dsp_prvb.dll (2017-02-04 02:01:05 UTC)
    Programmable reverb DSP 1.3
foo_dsp_std.dll (2019-03-11 14:05:30 UTC)
    Standard DSP Array 1.3.2
foo_dsp_vlevel20080302.0.dll (2008-03-02 22:42:06 UTC)
    VLevel 20080302.0
foo_dsp_xgeq.dll (2012-02-05 12:11:22 UTC)
    Graphic Equalizer 0.3.7
foo_dynamicdsp.dll (2018-04-21 21:46:56 UTC)
    Dynamic DSP 2.1
foo_enhanced_spectrum_analyzer.dll (2018-05-26 09:34:03 UTC)
    Enhanced Spectrum analyzer 0.9.4.2
foo_file_datetime.dll (2016-01-16 03:01:45 UTC)
    File Date Time 1.02
foo_fileops.dll (2019-03-11 14:05:36 UTC)
    File Operations 2.3
foo_freedb2.dll (2019-03-11 14:05:44 UTC)
    Online Tagger 0.7
foo_gep.dll (2018-01-17 07:34:23 UTC)
    Game Emu Player 1.213
foo_hdcd.dll (2017-02-04 02:14:16 UTC)
    HDCD decoder 1.19
foo_input_adplug.dll (2018-01-20 03:08:47 UTC)
    AdPlug 1.50
foo_input_caf.dll (2017-05-05 01:00:35 UTC)
    CAF Decoder 0.2.1
foo_input_celt.dll (2011-05-16 12:21:00 UTC)
    CELT Decoder 0.1.2
foo_input_dts.dll (2018-07-10 10:13:44 UTC)
    DTS decoder 0.5.4
foo_input_dtshd.dll (2011-03-19 22:41:12 UTC)
    DTS-HD Decoder 0.1.3
foo_input_dvda.dll (2012-03-16 16:30:28 UTC)
    DVD-Audio Decoder and Watermark Detector 0.4.11
foo_input_exe.dll (2018-01-18 13:43:52 UTC)
    Command-Line Decoder Wrapper 0.5.3
foo_input_ffmpeg.dll (2018-03-21 10:58:32 UTC)
    FFmpeg Decoder Wrapper 0.5.4
foo_input_monkey.dll (2017-11-27 14:18:46 UTC)
    Monkey's Audio Decoder 2.1.9
foo_input_ofr.dll (2011-03-15 22:43:46 UTC)
    OptimFROG Lossless/DualStream Decoder 1.31
foo_input_reverse.dll (2009-01-05 19:47:00 UTC)
    Reverse Playback 0.1.4 (SSE)
foo_input_sacd.dll (2012-08-25 19:03:10 UTC)
    Super Audio CD Decoder 0.5.11
foo_input_shorten.dll (2014-01-03 19:46:18 UTC)
    Shorten decoder 0.4.2.3
foo_input_std.dll (2019-03-11 14:06:02 UTC)
    FFmpeg Decoders 3.4.5
    Standard Input Array 1.4.3
foo_input_tak.dll (2018-01-30 08:27:34 UTC)
    TAK Decoder 0.4.8
foo_input_tta.dll (2018-01-30 08:48:19 UTC)
    TTA Audio Decoder 3.5
foo_input_vgmstream.dll (2018-08-26 18:43:52 UTC)
    vgmstream plugin r1050-1636-g72d0b7a3
foo_input_zxtune.dll (2017-07-20 08:39:31 UTC)
    ZXTune Player 0.0.7
foo_jesus.dll (2010-09-23 01:34:06 UTC)
    Autosave & Autobackup 10
foo_keep_queue.dll (2010-11-12 03:28:46 UTC)
    Keep Queue 0.3.5
foo_lnk.dll (2010-01-07 18:57:56 UTC)
    Shell Link Resolver 1.3.1
foo_lock.dll (2017-02-04 04:49:15 UTC)
    Pause on Lock 0.6
foo_midi.dll (2018-08-28 12:23:25 UTC)
    MIDI Player 2.1.4
foo_musical_spectrum.dll (2012-11-21 07:00:00 UTC)
    Musical Spectrum 0.9.1
foo_nds.dll (2018-01-06 22:02:56 UTC)
    No Display Standby 1.1.2
foo_openmpt54.dll (2018-07-29 02:12:22 UTC)
    OpenMPT component (kode54 fork) 0.3.11
foo_out_asio.dll (2012-06-06 13:19:14 UTC)
    ASIO support 2.1.2
foo_out_upnp.dll (2018-01-09 12:31:44 UTC)
    UPnP MediaRenderer Output 1.0 beta 17
foo_playcount.dll (2011-07-13 10:47:18 UTC)
    Playback Statistics 3.0.2
foo_psf.dll (2018-01-30 10:09:17 UTC)
    Highly Experimental 2.2.3
foo_queuecontents.dll (2011-12-31 13:30:56 UTC)
    Queue Contents Editor 0.5
foo_r128norm.dll (2017-02-04 05:02:13 UTC)
    EBU R128 Normalizer 1.12
foo_random_pools.dll (2015-04-04 20:32:52 UTC)
    Random Pools 0.1.5
foo_rgscan.dll (2019-03-11 14:05:40 UTC)
    ReplayGain Scanner 2.3
foo_run.dll (2018-03-21 20:07:41 UTC)
    Run services 0.3.8
foo_scrobble.dll (2017-11-21 17:47:40 UTC)
    Scrobble 1.1.0
foo_seek_box.dll (2010-04-21 14:03:30 UTC)
    Seek box 0.0.3
foo_sid.dll (2018-06-14 02:13:46 UTC)
    sidplay2 1.43
foo_skip.dll (2018-01-06 22:59:20 UTC)
    Skip Track 1.9.10
foo_snesapu.dll (2018-01-30 10:29:50 UTC)
    SNESAPU input 0.83
foo_stnaa.dll (2016-05-28 04:58:04 UTC)
    Search tracks with no album art 1.00_beta3
foo_stop_on_current.dll (2018-01-06 22:14:22 UTC)
    Stop on Current 0.6.1
foo_stop_on_error.dll (2018-05-06 11:16:48 UTC)
    Stop on Error 0.6
foo_textdisplay.dll (2011-05-29 15:03:58 UTC)
    Text Display UI Element 1.1 beta 1
foo_timebomb.dll (2009-12-20 21:40:00 UTC)
    Timebomb 0.0.2
foo_ui_std.dll (2019-03-11 14:05:46 UTC)
    Default User Interface 1.4.3
foo_verifier.dll (2017-11-28 12:13:46 UTC)
    File Integrity Verifier 1.2.1
foo_video.dll (2018-04-15 04:19:51 UTC)
    Chimera 0.5.0.0
foo_vst.dll (2011-03-05 07:19:04 UTC)
    VST 2.4 adapter 0.9.0.3
foo_wave_seekbar.dll (2014-02-08 21:37:10 UTC)
    Waveform seekbar 0.2.45
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: Case on 2019-03-28 15:00:12
Actually queue is supposed to be flushed when you manually select unrelated track to be played. Your Keep Queue component has tried to prevent queue from working the way it's supposed to but it must fail with the new version.
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: EpicForever on 2019-03-28 16:18:41
I don't understand your answer. Is this wrong or right behavior? And is this intended change in v 1.4.3?
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: Case on 2019-03-28 17:26:44
Queue getting flushed when you manually override the queue and pick a new track is what is supposed to happen.

You have a component that tries to prevent that (foo_keep_queue). There have been no API changes in 1.4.3 that affect queue handling. That component is a hack and doesn't seem to work correctly. I just performed your media library search playback test in foobar2000 v1.3.20 with Keep Queue installed and the queue got flushed.
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: EpicForever on 2019-03-28 17:38:23
Fcuk... I would swear that it worked differently not longer ago than when first 1.4 were out... But after reading above I think I change my mind. Looks like I haven't tried that exact scenario for a long time.

Sorry for false report. I feel stupid...
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: Peter on 2019-04-03 11:57:39
Just a heads-up: a future update will add an option for this so foo_keep_queue will not be needed.
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: EpicForever on 2020-04-14 08:34:04
Just a heads-up: a future update will add an option for this so foo_keep_queue will not be needed.
Hi @Peter ,
Are there any news regarding this statement?
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: Case on 2020-04-14 10:54:06
It was added in version 1.5 (http://www.foobar2000.org/changelog#section3).
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: EpicForever on 2020-04-14 12:36:45
Hm, is it this one?
Added Advanced Preferences option for flushing playback queue on manual track change (default: on).
So I can delete old foo_keep_queue now?
Title: Re: 1.4.3 bug - playing track from search flushes queue
Post by: anamorphic on 2020-04-14 13:57:55
Unless you want to keep the queue on restart, which was one of its options, if I recall. (I ended up removing it)