Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Album Art Downloader XUI (Read 2055772 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Album Art Downloader XUI

Reply #475 –
Hi Alex. Thanks for the great program!

Couple of questions:

1) Shouldn't the "File path pattern matching can be made to match folders instead of files, by ending the pattern with "\."" introduced in 0.19 be added to "Command Line Reference -> /localImagesPath"?

2) Why does the "c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe" (Visual C# Command Line Compiler) run everytime I start and close XUI? Is it really needed? After I updated to 0.22 version (installer, previously I used the zipped 0.18), the "csc.exe" starts twice before XUI opens (+ once when closing XUI), how come? I thought that the .NET 3.5 was required, so why is the csc.exe from .NET 2.0 SP1 ran? I'm really not into the deep technical side of this thing, this just seemed a bit odd to me.

3) How come the Discogs search is so awfully slow compared to others? In example, Cover-Paradies gets 15 results when searching "Pearl Jam / Ten" rather quickly (and images are really large compared to Discogs results), Discogs gets 36 and it's REALLY slow.. about 6 (or more) times slower. I tried Discogs webpage search and it's quick, and so is the image loading from the results. The "automatically download full-size images" was set to "never".

I tried to optimize the script by changing:
Code: [Select]
query as string = artist + " " + album

to this:
Code: [Select]
query as string = "\"" + artist + " - " + album + "\""

but it only helps little to weed out the not relevant artist releases (but still improvement nonetheless). I noticed that only the first page of the results (20 items) is used in the script.. which is quite ok since how many albums have over 20 different releases.

Bottom line: I didn't quite understand why the Discogs search is so slow.. do you know?

P.S. You really should be brave and push the versioning to 1.0 since your program is so damn excellent.  Thanks again!
 

Album Art Downloader XUI

Reply #476 –
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading? It's really annoying to set everything again after updating. Or does this happen only when using the zipped XUI (I just installed the XUI for the first time)?

Look at the picture below:

Is the "Url_..." in folder names an indicator of a path where the program lies? Seems rather messy to me. Also, a new folder for every new version?! Is there so many/big changes to the user.config file that it's not possible to merge the old and the new one automatically?

Thanks again.

Album Art Downloader XUI

Reply #477 –
Quote from: Akkurat on
1) Shouldn't the "File path pattern matching can be made to match folders instead of files, by ending the pattern with "\."" introduced in 0.19 be added to "Command Line Reference -> /localImagesPath"?
The file path pattern matching referred to here is for the file browser, not the local image search. It doesn't make much sense to search for folders instead of files, if searching for images, as images are files, not folders.

Quote from: Akkurat on
2) Why does the "c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe" (Visual C# Command Line Compiler) run everytime I start and close XUI?
I believe csc.exe is called to perform dynamic compilation to assist with XmlSerializer, and XmlSerializer is used to read and write configuration settings. That would explain why it is being called at loading and closing. I don't know why version 2 is being called, this is not something that is under my direct control. Is it causing a problem?

Quote from: Akkurat on
3) How come the Discogs search is so awfully slow compared to others?
Discogs is slow for a couple of reasons. Firstly, it doesn't have thumbnails, so the full-sized image is downloaded for every result. Secondly, the images can't be obtained directly from the search results page, so for each result, another page must be fetched to obtain the image url from. Thirdly, Discogs is just quite slow, compared to other sites.

Quote from: Akkurat on
P.S. You really should be brave and push the versioning to 1.0 since your program is so damn excellent.  Thanks again!
Thanks for the vote of confidence! I'm actually quite happy with the code now, but a 1.0 release also requires user documentation and a proper website, both of which I've been far too lazy to do so far!

Alex

Album Art Downloader XUI

Reply #478 –
Quote from: Akkurat on
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading?
This should already be happening. If the upgrade isn't working properly, I'll look into it, but it is definitely supposed to keep existing settings.

Everything past the AlumArt.exe_ in the folder name is not under my control. This is handled automatically by the .net configuration settings / isolated storage mechanism, but yes, I think it relates to the folder the .exe file is in.

The installer will automatically delete all the ApplicationData\AlbumArtDownloader\AlbumArt.exe_* and aad.exe_* folders on uninstall, but has no special behaviour on install. Merging of old settings is done the first time a new version of the application is run.

I could, I suppose, write my own custom configuration system and store the configuration files wherever I wanted, in whatever format I wanted, but as .net provides a ready built configuration file system, I choose to use that. There are usually good, if obscure, reasons for the strange things it does - someone has put a great deal of thought and work into it - that I do not intend to duplicate.

Alex

Album Art Downloader XUI

Reply #479 –
Thank you for your superior tool. It's a great help. But I have 1 Problem and 1 suggestion

The Problem: When I open AAD xui and search for the first time, the search will last unbelieveable long for all internet searches.
AND if you choose to many search plugins, you will get 0 results (even searching google images for "foobar" will result in no picture at all)
after the first search was successfull i can make as many searches as i want, all of them really fast and accurate with all plugins. But if i close all aad xui windows, i have to wait again.

I use xp sp3 and no software(windows) firewall

and my sugesstion: could you (or somebody else) add an itunes plugin? you could steal the code from "itunesstorevalidator" 

Album Art Downloader XUI

Reply #480 –
Quote from: Goesen on
Thanks for your comments. I can't reproduce the problem you have described - do you think you could check if it is any particular source that is causing it? If you have only one source selected, the next time you start AAD, does it still go slow? Does it matter which source?

We used to have an iTunes image script, but since they started encrypting their images, it can't be used any more.

If you meant some sort of integration with the iTunes client, then no, that's not going to happen. Not unless someone else writes it, anyway, as I won't be installing that junk on my PC. As you say, there is already an itunesstorevalidator, which I believe already integrates with Album Art Downloader in some way.

Alex

Album Art Downloader XUI

Reply #481 –
Hi Alex
Yes i would like some tool which uses i tunes.
And i'd rather use a plugin for your code, because each time i use itsv i get the feeling it destroys more than it fixes.
Is here anyone who has free time and nothing to do?


But Alex, if you like, you could add the Encyclopedia Metallum (should be very similar to discogs)
http://www.metal-archives.com/
(registration requiered for the advanced search


Quote
do you think you could check if it is any particular source that is causing it

any script which is using the internet

Quote
If you have only one source selected, the next time you start AAD, does it still go slow

yes. choosing only googleimages for artist "foobar" takes around 15 sek. if i pick more sources it will take even longer or give no images at all. But as soon as i get the first pictures, i can choose "select all", search again and get nearly instantly all images.

Quote
Does it matter which source

any script which is using the internet

I just played a bit with your command line tool and got nearly the same results
aad "foobar" spend 15 sek for the first source (Album Art Exchange)
after the first source was done, it works pretty fast

if i set other sources i spend it's 15 sec on the first other source.

maybe tomorrow i will try this on another pc, but not today

Album Art Downloader XUI

Reply #482 –
Quote from: AlexVallat on
I believe csc.exe is called to perform dynamic compilation to assist with XmlSerializer, and XmlSerializer is used to read and write configuration settings. That would explain why it is being called at loading and closing. I don't know why version 2 is being called, this is not something that is under my direct control. Is it causing a problem?

No problems. But remember when I PM'd you about the slow startup of XUI when run for the first time after reboot? I just realized (thou not 100% sure) that part of the slowdown is because the csc.exe is searched from the HD. Why it settles for the "version" (not really versions which makes this even odder) 2 csc.exe, no idea. In fact, I renamed the csc.exe in "v2.0.50727" dir and ran XUI; errorlog.txt pops up:
Code: [Select]
...
App version: 0.18.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.ArgumentException: The property 'SearchPathPatternHistory' could not be created from it's default value. Error message: Compiler executable file c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe cannot be found.
...

So it seems that the .NET 2.0 is also required... or does the installer of 3.5 add the "2.0" if it does not exist? The csc.exe of v1.1 and v3.5 is not accepted (again it's the "not versions even if they're named as versions..?). I also noticed that, when running these test in VPC, that the csc.exe runs cvtres.exe (Microsoft® Resource File To COFF Object Conversion Utility) from the same directory.

Is the "property 'SearchPathPatternHistory'" relating straight to your code? I mean, I just wondered if you could try to avoid running the csc.exe (&cvtres.exe) automatically.. maybe not possible at all but doesn't hurt to ask you.  Though this is quite clearly related to the ".net provides a ready built configuration file system" you wrote, right? And thus nothing can be done about it.

And could it be possible to speed up the process by "telling" in your code where the 2.0 csc.exe is? I tried to add the directory to the PATH and rebooted but that had no effect at all.. so it may be that the csc.exe isn't searched after all and it's something else that slows down the startup..

Quote from: AlexVallat on
Quote from: Akkurat on
Oh, almost forgot; would it be possible to keep the settings (window size, "MaximumResults", etc.) when upgrading?
This should already be happening. If the upgrade isn't working properly, I'll look into it, but it is definitely supposed to keep existing settings.

I tested by installing 0.18, changed some things, installed 0.21 over (and finally also 0.22) = all changes (I made, to the options, group by, sort by & maximum results) were kept, except window size. So it's not so big of a deal..

P.S. I saved my testbed in VPC, so if you like me to test something out relating to these conversations..

Album Art Downloader XUI

Reply #483 –
Quote from: Akkurat on
I think the slower startup after reboot is due to initialising WPF. This can be tested by running another WPF application after reboot, before XUI, then running XUI and seeing if it is as fast as usual.

If it was csc.exe causing the problem, then it would happen on every run, not just the first one.

It would be interesting to uninstall the .NET Framework (all versions), then install only version 3.5, and check to see whether that includes csc.exe under the v2.0.50727 dir, or whether it would then start using the one under the v3.5 dir. I don't think it really matters, but it might be good to know.

SearchPathPatternHistory is one of my settings, yes. It is only one of many settings that are stored in XML serialized format though, so I expect it was just the first one to be read. To avoid XML configuration altogether would be a far larger change than just one stored property.

Quite apart from that, I've yet to become convinced that there is any harm in it. I don't think it is searching the hard disk for csc.exe - it knows exactly where to find it, as demonstrated by the fact that if it isn't there, it throws an exception stating where it thought it was. This is just internal functionality of the .net framework, and not something that needs worrying about. I had to switch the timing resolution of process explorer down to 0.5s just to see the thing appear and disappear!

Thanks for the information about the upgrading. It seems that the upgrade process is working, but isn't upgrading the window size (and position?) settings - I'll see if I can figure out why.

Alex

Album Art Downloader XUI

Reply #484 –
Quote from: AlexVallat on
It would be interesting to uninstall the .NET Framework (all versions), then install only version 3.5, and check to see whether that includes csc.exe under the v2.0.50727 dir, or whether it would then start using the one under the v3.5 dir. I don't think it really matters, but it might be good to know.

It does install some (basic required?) of the 1.0, 1.1, 2.0 & 3.0 stuff along with the 3.5. I used the setup installer (which downloads only needed stuff), not the full ~200 MB package. The 2.0 csc.exe is still used like I suspected.. because it's a different product although it's named like a version.. stupid Microsoft. So, no need to change the requirements.

Quote from: AlexVallat on
Thanks for the information about the upgrading. It seems that the upgrade process is working, but isn't upgrading the window size (and position?) settings - I'll see if I can figure out why.

Yes, it's also the position which is not retained. Not a biggie but thanks for checking it out.

Album Art Downloader XUI

Reply #486 –
This program is fantastic. Works beautifully!

If I have art already downloaded in some files but it is small in size (200 pixels) can I overwrite this with 500 pixel selections in AAD? How would this work because doesn't it just seek out files that don't have the album art attached to it?

Thanks again!

Album Art Downloader XUI

Reply #487 –
Quote from: ameliajune on
How would this work because doesn't it just seek out files that don't have the album art attached to it?
The file and foobar browsers will list all albums found, whether or not they have image files. It will also list the image file size of those albums for which it is found, so if it looks too small, you can choose to download new art for them too.

Of course, you can always search directly for artist and album name, regardless of whether that album was found by the file or foobar browsers or not!

Alex

Album Art Downloader XUI

Reply #488 –
Thanks, but here's an anomaly I found that I don't understand.

I ripped two tracks to MP3 using dbpoweramp, Lame 3.97

Both tracks ripped using artwork from the various databases at 310 x 310.
On first look, the file sizes were #1 - 13kb and #2 - 12kb

I then used AAD to select 300 x 300 files from Google, and the sizes changed to #1 - 2kb and #2 - 20kb

I then used AAD to select 400 x 400 files from Google and/or Discogs and the sizes changed to #1 - 117kb and #2 4kb

What is causing the erratic file size change? I thought all files that were 310 x 310 etc. equaled 10kb (or said standard size)?

Album Art Downloader XUI

Reply #489 –
Quote from: ameliajune on
What is causing the erratic file size change? I thought all files that were 310 x 310 etc. equaled 10kb (or said standard size)?
File size depends on more than just pixel size. For a start, it depends on the format, so a .jpg will be a different size from a .png. For formats other than .bmp, the size also depends on the quality of the image - a more highly compressed image will have a smaller file size, but more noticeable compression artefacts.

Alex

Album Art Downloader XUI

Reply #490 –
Quote
a .jpg will be a different size from a .png.


Ah, ok. When I'm selecting is there a ladder of smallest to largest, i.e., go for a png, then a jpg, etc. or no because I'd have no idea the compression factor? (I'm trying to get the best quality around 500 without too much of an increase if at all possible).

Album Art Downloader XUI

Reply #491 –
Quote from: ameliajune on
(I'm trying to get the best quality around 500 without too much of an increase if at all possible).
For photo-style images (which artwork tends to be), jpg is probably best. The thing is, if it's been poorly scanned, while it might technically be a high quality image, it could still look bad! I would use Google Images as a last resort, really - I find the quality of the other sources to be more reliable. In any case, it's probably best to preview before finally accepting an image, just in case.

Alex

Album Art Downloader XUI

Reply #492 –
Quote
The thing is, if it's been poorly scanned, while it might technically be a high quality image, it could still look bad!


Yes I found that out! I was testing and saved a 600x600 picture from Amazon of all places and when I imported it and took a look it was blurry! Might've been an anomaly, as you said usually Amazon is a good resource.

The feature to enlarge the pictures before saving is excellent. Thanks again.

Album Art Downloader XUI

Reply #493 –
Does this not allow you to embed album art in mp3 files? I seem to remember the old version allowing it... I may be thinking of another similar program though.

Album Art Downloader XUI

Reply #494 –
Quote from: Vermelhu on
Does this not allow you to embed album art in mp3 files? I seem to remember the old version allowing it... I may be thinking of another similar program though.
No, neither this version, nor any previous version of Album Art Downloader XUI, Album Art Downloader or Cover Downloader ever allowed embedding of album art in mp3 files, or finding art already embedded. As far as I'm concerned, it won't in the future either - having a copy of the album art embedded in each file of the album is not a system I consider worth supporting.

Alex

Album Art Downloader XUI

Reply #495 –
Quote from: AlexVallat on
having a copy of the album art embedded in each file of the album is not a system I consider worth supporting.

Alex


I don't see why not... Many players (notably iTunes) don't look in the album folder for art, instead opting for their own database of downloaded album art. However this is non-portable... When moving your music to other machines or re-installing your OS, all the art is lost and must be re-download. And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

With embedded album art in tags, none of this is an issue.

Album Art Downloader XUI

Reply #496 –
Quote from: Vermelhu on
And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

Just to nit-pick, this is NOT true. I've seen albumart in iTunes for albums in my collection that were not for sale.

But still they also miss a lot and many covers are very poor quality.
Can't wait for a HD-AAC encoder :P

Album Art Downloader XUI

Reply #497 –
Quote from: Vermelhu on
I don't see why not... Many players (notably iTunes) don't look in the album folder for art, instead opting for their own database of downloaded album art. However this is non-portable... When moving your music to other machines or re-installing your OS, all the art is lost and must be re-download. And again, regarding iTunes, the iTunes Store only has album art for the music which it sells, which is far from comprehensive.

With embedded album art in tags, none of this is an issue.
Yes, a proprietary database is an even worse solution. Just another reason not to use iTunes, really, as if we needed another. Apple do make a whole lot of technically inferior rubbish in pretty boxes, and iTunes is just another shining example of the genre.

If you have to use iTunes, then [a href='index.php?showtopic=51708']iTSfv[/a] will probably help.

Alex

Album Art Downloader XUI

Reply #498 –
iTSfv looks handy, but iTunes was just one example among many. It just happened to be the most familiar one. My main point was the fact that if the album art is contained within the file, any similar issues would not be experienced.

I don't see any compelling reason not to embed art - the only one I can think of is storage, and considering the price of storage these days it's not much of an excuse. Feel free to enlighten me if there are others though.

In general, I tend to have the album art both in the folder and in the files... Personal preference. I just think it would be a nice feature to have as an option.

Album Art Downloader XUI

Reply #499 –
GREAT program and this is one of those nit picky questions, but I see that the default for naming the pictures is Folder.jpg. Is there any way to change that to folder.jpg... lowercase? How would I do that program wise so I wouldn't have to do it on each individual one?

Thanks! 

Edit: One other thing - Is there a way to search for album only? Meaning, say I have a compilation cd ripped in FLAC with all of the files in the same folder. I noticed that AAD brings up each song (because it's a compilation they are by different artists) rather than find the album art for the album and then move on.

2nd Edit: Woohoo! I think I did it... I marked the "use file path pattern matching" set to \%artist%\%album%\* and it only brought up or seemed to.. the albums... did I do it?

3rd Edit: Wow, I'm on a roll. I seem to have fixed the naming part too... maybe when I open a blank File Browser and made changes to that it affected the rest?

Excellent. I love it when things work out.