Nice find, Ben Dodson has made his source available too, so I can use the same logic to get the original file when available. It will then fall back on all the existing fall-backs if that isn't there. Please give the attached itunes.boo 0.6 a try to compare with the results you had noticed were different, and see if the quality now matches? Or more importantly if there are any where it gives a worse result!

I've checked out the example of Sun Jamming on Discogs, and this isn't showing up because it doesn't have a Master Release (for some reason). The Discogs script searches for Master releases so as not to return a lot of duplicates. You could change that by editing discogs.boo in notepad and on line 28 replacing searchType=master with searchType=release, but you may find a lot of duplicates in your results.

Secondly, there was a bug with the discogs script that would stop it from working on pages where there was not a "More images" link beneath the album artwork. I've fixed that here: discogs.boo v0.27.

As far as the relevance of the search, there's not really much I can do about that. Album Art Downloader sends the search query "" "Sun Jamming" to Discogs (first "" because there is no artist), and those are the results it returns.

I expect better results could be obtained using the API, but they have gated this behind requiring an API key, which is not suitable for an open source application.

I expect better results could be obtained using the API, but they have gated this behind requiring an API key, which is not suitable for an open source application.

they dropped the need for an API key when they went from 1.0 to 2.0

Quote from: PaciPag on 2023-05-31 13:01:13

they dropped the need for an API key when they went from 1.0 to 2.0

For access to image URLs it still requires a "consumer" key (as you mention). Whatever they call it, it's still a key I need in order to access the API, which has to be kept secret. Looks like an API key to me! Keeping a key secret is not an option for AAD, so I'm not going to write a script that requires it. I do take your point that users with registered discogs accounts could generate their own keys and then supply them in some sort of config file, or by editing the script, but that's not really a model I'm interested in putting much work into.

If anyone else wants to write a discogs-api script based on this principle, I'd be happy to include it in the list of scripts, though,

# refs: System.Web.Extensions

import System
import System.Text.RegularExpressions
import System.Web.Script.Serialization
import AlbumArtDownloader.Scripts
import util

class Discogs(AlbumArtDownloader.Scripts.IScript):
	def constructor():
		// Discogs requires TLS 1.1 or greater
		Tls12 = Enum.ToObject(typeof(System.Net.SecurityProtocolType), 3072);
		Tls11 = Enum.ToObject(typeof(System.Net.SecurityProtocolType), 768);

		System.Net.ServicePointManager.SecurityProtocol = Tls12 | Tls11 | System.Net.SecurityProtocolType.Tls
	Name as string:
		get: return "Discogs"
	Author as string:
		get: return "Alex Vallat"
	Version as string:
		get: return "0.27"
	def Search(artist as string, album as string, results as IScriptResults):
		//artist = StripCharacters("&.'\";:?!", artist)
		//album = StripCharacters("&.'\";:?!", album)
		//Discogs lists Various Artists compilations under "Various", many collections term these "Various Artists" or "VA"
		if (artist = "Various Artists"):
			artist="Various"
		if (artist = "VA"):
			artist="Various"
		json = JavaScriptSerializer()

		resultsInfoJson = GetDiscogsPage("https://www.discogs.com/search/ac?searchType=release&q=" + EncodeUrl("\"${artist}\" \"${album}\""))
		resultsInfo = json.Deserialize[of (Result)](resultsInfoJson)
		
		results.EstimatedCount = resultsInfo.Length;
		
		for result in resultsInfo:
			// Get the release info from api
			title = result.GetString(result.artist) + " - " + result.GetString(result.title);
			url = result.GetString(result.uri);
			//id = url.Substring(url.LastIndexOf('/'));

			releasePage = GetDiscogsPage("https://www.discogs.com" + url)

			releasePageImagesMatches = Regex("\"Image:{[^{]+}\":(?<json>{.+?}})", RegexOptions.IgnoreCase | RegexOptions.Singleline).Matches(releasePage)
			for match as Match in releasePageImagesMatches:
				imageInfo = json.Deserialize[of ImageInfo](match.Groups["json"].Value)
				if (imageInfo.fullsize != null and imageInfo.thumbnail != null):
					fullInfo = json.Deserialize[of ImageRef](imageInfo.fullsize.__ref.Substring(10))
					thumbInfo = json.Deserialize[of ImageRef](imageInfo.thumbnail.__ref.Substring(10))

					results.Add(thumbInfo.sourceUrl, title, "https://www.discogs.com" + url + "/image/" + imageInfo.id, -1, -1, fullInfo.sourceUrl, CoverType.Unknown)

	def RetrieveFullSizeImage(fullSizeCallbackParameter):
		return GetPageStream(fullSizeCallbackParameter, null, true);

	def GetDiscogsPage(url) as string:
		request = System.Net.HttpWebRequest.Create(url) as System.Net.HttpWebRequest

		request.Accept = "*/*"
		request.UserAgent = "Mozilla/5.0 (AAD on " + System.Environment.MachineName + ")"
		
		try:
			response = request.GetResponse()
		except ex as WebException:
			exResponse = ex.Response as System.Net.HttpWebResponse
			if (exResponse != null and exResponse.StatusCode == 308):
				return GetDiscogsPage(exResponse.GetResponseHeader("Location"))
			raise

		stream = response.GetResponseStream()
		try:
			return GetPage(stream)
		ensure:
			stream.Close()
	
	class Result:
		public artist as object
		public title as object
		public uri as object

		def GetString(value):
			result = value as string;
			if result is null:
				result = (value as (object))[0] as string;
			return result;

	class ImageInfo:
		public id as string
		public thumbnail as ImageRefJson
		public fullsize as ImageRefJson

		class ImageRefJson:
			public __ref as string
	
	class ImageRef:
		public sourceUrl as string

Thanks, I will include the "Various Artists" => "Various" thing in the next release.

def Search(artist as string, album as string, results as IScriptResults):
		//artist = StripCharacters("&.'\";:?!", artist)
		//album = StripCharacters("&.'\";:?!", album)
		//Discogs lists Various Artists compilations under "Various", many collections term these "Various Artists" or "VA"
		if (artist == "Various Artists"):
			artist="Various"
		if (artist == "VA"):
			artist="Various"
		json = JavaScriptSerializer()

I'm not convinced about "VA", though, I've not encountered that before and it unlike "Various Artists" it isn't unambiguous enough that I could be certain that you would never want to search for "VA" itself.

".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe"
 /ar "$cut(12345678901234567890123456789012345,34)" 
 /al "$cut(12345678901234567890123456789012345,34)"
 /p "$replace(%_path%,%_filename_ext%,)%%artist%%%%album%%'~'%%type%%%%size%%%%source%%.%%extension%%"

".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe"
 /ar "$cut(12345678901234567890123456789012345,35)" 
 /al "$cut(12345678901234567890123456789012345,35)"
 /p "$replace(%_path%,%_filename_ext%,)%%artist%%%%album%%'~'%%type%%%%size%%%%source%%.%%extension%%"

Hi,
I'm using AAD 1.05 with fb2k 64bit latest preview via run_services on Windows 11 and get crashes IF artist or album is longer than 34 chars

I'm not seeing any crash when I pass parameters of more than 34 characters. What is the error message you get? Is an ".\user-components\AlbumArtDownloaderXUI\errorlog.txt" file created? Or an "%temp%\AAD_Errorlog.txt" file?

Is it possible that the full path including artist and album name ends up being more than 256 characters long? That's a windows limitation.

AAD already replaces invalid characters in placeholders (like %artist% and %album%). If you expand the Options area, there's a box to say which character to replace them by ("-" by default).

Perhaps there is an invalid character in part of the path you are specifying directly? Try leaving placeholders in the path instead of having them resolved before they are sent to AAD.

".\user-components\AlbumArtDownloaderXUI\AlbumArt.exe" 
$puts(AR,$cut($replace(%ARTIST%,' - ',+, ,+,'_',+,'&',+,'(',+,')',+,'[',+,']',+,':',+,';',+,',',+,'.',+),70))

$puts(AL,$cut($replace(%ALBUM%,' - ',+, ,+,'_',+,'&',+,'(',+,')',+,'[',+,']',+,':',+,';',+,',',+,'.',+),70))

 /ar "$replace($get(AR),++, ,+, )"

 /al "$replace($get(AL),++, ,+, )"

 /p "$replace(%_path%,%_filename_ext%,)%%type%%%%source%%%%size%%.%%extension%%"