Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1460523 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Re: foo_discogs

Reply #3200 –
Quote from: ms1602 on
Thanks for your help so far! One more question - what to do so that when the issue has only a year and month, it does not display something like - 1990-09-00, only 1990-09. I've had several situations like this. "00" is added unnecessarily when a release has no release day.

Edit: One more thing - using your suggestion for guest appearances, in a situation where there is no guest appearance - nothing is tagged in the artist name tag. This causes a problem in particular when I want to tag a Various Artists release like this: https://www.discogs.com/release/1127053-Various-CMJ-Presents-Certain-Damage-Volume-38

Wouldn't it be better if it tagged the name of the artist and the guest appearance next to it?

The full date is a bit tricky because not all releases have it.

My routine for tagging is first tagging with MusicBrainz that write date and original date. I uncheck write original release date to date and use year instead of full date. That write full date when available in %DATE% and %ORIGINAL RELEASE DATE%.

Second step with discogger. I have disabled %DATE% to not overwrite the previous. I write the tags

Code: [Select]
DISCOGS_RELEASE_MONTH                    %RELEASE_MONTH%
DISCOGS_RELEASE_DAY                           %RELEASE_DAY%
DISCOGS_RELEASE_YEAR                          %RELEASE_YEAR%
DISCOGS_RELEASED                                 %RELEASE_DATE_RAW%
DISCOGS_MASTER_RELEASE_YEAR           %MASTER_RELEASE_YEAR%

Then I fill the %DATE%, %RELEASE DATE% and %ORIGINAL RELEASE DATE% manually with that info. It is not always available, even using the 2 taggers, so I use the https://github.com/Wil-B/Biography to get info from wikipedia, last.fm and allmusic.

As %DATE% is the most normal tag used for others programs I like that it have the original release date but that a personal taste.

A Various Artist release




The code in the Title + Trcak Artist field is

Code: [Select]
%TITLE%[' ['%SUBTITLE%']'][' ('$meta_sep(REMIXED BY,', ',' & ')' Remix)'][>>' | '$if(%TRACK ARTIST%,$meta_sep(ARTIST,', ',' & ')[' Featuring '$meta_sep(FEATURING,', ',' & ')],)<<]

Note the %TRACK ARTIST% tag. This is a foobar internal mapping. It is present when %ALBUM ARTIST% is present and is different for the %ARTIST% tag. With this the artist is only displayed when is different from the album artist

I like to have the %album artist%, %artist% and %title% write as tis released and in a single value. This is useful with other players (like car player) and for scrobbling to last.fm. Then I used other tags like %artists%, %featuring%, % remixed by%, %producer%, etc as separate multivalues. Mostly to display in facets, make auto-playlists, google searching and uses it in the bio panel.



The decision to add the remixer to tiitle or the featuring to artist is a personal taste, but the way is displayed depend on the component that is used for the playlist. You must search a way to modifies the playlist component you are using to your personal taste.





Re: foo_discogs

Reply #3201 –
Quote from: paregistrase on
Quote from: ms1602 on
Thanks for your help so far! One more question - what to do so that when the issue has only a year and month, it does not display something like - 1990-09-00, only 1990-09. I've had several situations like this. "00" is added unnecessarily when a release has no release day.

Edit: One more thing - using your suggestion for guest appearances, in a situation where there is no guest appearance - nothing is tagged in the artist name tag. This causes a problem in particular when I want to tag a Various Artists release like this: https://www.discogs.com/release/1127053-Various-CMJ-Presents-Certain-Damage-Volume-38

Wouldn't it be better if it tagged the name of the artist and the guest appearance next to it?

The full date is a bit tricky because not all releases have it.

My routine for tagging is first tagging with MusicBrainz that write date and original date. I uncheck write original release date to date and use year instead of full date. That write full date when available in %DATE% and %ORIGINAL RELEASE DATE%.

Second step with discogger. I have disabled %DATE% to not overwrite the previous. I write the tags

Code: [Select]
DISCOGS_RELEASE_MONTH                    %RELEASE_MONTH%
DISCOGS_RELEASE_DAY                           %RELEASE_DAY%
DISCOGS_RELEASE_YEAR                          %RELEASE_YEAR%
DISCOGS_RELEASED                                 %RELEASE_DATE_RAW%
DISCOGS_MASTER_RELEASE_YEAR           %MASTER_RELEASE_YEAR%

Then I fill the %DATE%, %RELEASE DATE% and %ORIGINAL RELEASE DATE% manually with that info. It is not always available, even using the 2 taggers, so I use the https://github.com/Wil-B/Biography to get info from wikipedia, last.fm and allmusic.

As %DATE% is the most normal tag used for others programs I like that it have the original release date but that a personal taste.

A Various Artist release




The code in the Title + Trcak Artist field is

Code: [Select]
%TITLE%[' ['%SUBTITLE%']'][' ('$meta_sep(REMIXED BY,', ',' & ')' Remix)'][>>' | '$if(%TRACK ARTIST%,$meta_sep(ARTIST,', ',' & ')[' Featuring '$meta_sep(FEATURING,', ',' & ')],)<<]

Note the %TRACK ARTIST% tag. This is a foobar internal mapping. It is present when %ALBUM ARTIST% is present and is different for the %ARTIST% tag. With this the artist is only displayed when is different from the album artist

I like to have the %album artist%, %artist% and %title% write as tis released and in a single value. This is useful with other players (like car player) and for scrobbling to last.fm. Then I used other tags like %artists%, %featuring%, % remixed by%, %producer%, etc as separate multivalues. Mostly to display in facets, make auto-playlists, google searching and uses it in the bio panel.



The decision to add the remixer to tiitle or the featuring to artist is a personal taste, but the way is displayed depend on the component that is used for the playlist. You must search a way to modifies the playlist component you are using to your personal taste.







Thanks for the answer. I also use musicbrainz in the first place, if only because of the more faithful representation of the case (Discogs has a scheme for naming everything in capital letters), I use Discogger only for releases that are not found on Musicbrainz. As for remixes - I decided to add them manually (the number of albums that contain remixes and are not on Musicbrainz is a really rare situation).

When it comes to Discogger, I want this effect: https://imgbox.com/Vy84jJFh

Is it possible to set tag mapping like this?

Re: foo_discogs

Reply #3202 –
Quote from: ms1602 on
Thanks for the answer. I also use musicbrainz in the first place, if only because of the more faithful representation of the case (Discogs has a scheme for naming everything in capital letters), I use Discogger only for releases that are not found on Musicbrainz. As for remixes - I decided to add them manually (the number of albums that contain remixes and are not on Musicbrainz is a really rare situation).

When it comes to Discogger, I want this effect: https://imgbox.com/Vy84jJFh

Is it possible to set tag mapping like this?

Transform a multi value in a single value?

Format from other tags in artist

$meta_sep(artist,', ')

for existing tags

In discogger

ARTIST                 $joinnames(%<ARTISTS_NAME>%,%<ARTISTS_JOIN>%) to join the artist with the discogs joiner (+, &, with, etc)

or $join(%<ARTISTS_NAME>%) to joint with ', '


You have all the functions in Help-Title formating help and in the discogger help in tag mapping

Re: foo_discogs

Reply #3203 –
Thank you very much!





MOD edit: Removed unnecessary full quote

Re: foo_discogs

Reply #3204 –
I don't know how to do it, I try different variants, for example: $joinnames(%<ARTISTS_NAME>%,%<ARTISTS_JOIN>%,%<DISCOGS_CREDIT_FEATURING>%) or $join(%<ARTISTS_NAME>%,'Featuring') and either an error pops up when trying to tag or it doesn't work. I don't know, I'm probably not able to understand it :D - I'll write directly what should I enter in the "Artist" tag to display the name of the artist and the guest appearance next to it (if there is)? Sorry for bothering you, but I really don't know anything about it, plus my English is very bad and I can't handle it.

Re: foo_discogs

Reply #3205 –
Quote from: ms1602 on
I don't know how to do it, I try different variants, for example: $joinnames(%<ARTISTS_NAME>%,%<ARTISTS_JOIN>%,%<DISCOGS_CREDIT_FEATURING>%) or $join(%<ARTISTS_NAME>%,'Featuring') and either an error pops up when trying to tag or it doesn't work. I don't know, I'm probably not able to understand it :D - I'll write directly what should I enter in the "Artist" tag to display the name of the artist and the guest appearance next to it (if there is)? Sorry for bothering you, but I really don't know anything about it, plus my English is very bad and I can't handle it.

In the tag mapping dialog in the upper left corner, there is a ? that open the formatting help.


DISCOGS_CREDIT_FEATURING is the name you give to the fields to be written, not an internal discogger variable.
There is no specific featuring variable in discogs. This makes almost impossible to make a script that fit all variations because you must search for all the possibilities in the credits roles and release roles.

For example in John Mayall's Bluesbreakers* Featuring Walter Trout – Life In The Jungle the featuring comes with the artists_name, No problem with the $joinname script.

But in others, like 7 Notas 7 Colores – 77 the featured artists are in the track roles as Vocals [Featuring] , Rap [Featuring]
In this one the featuring that search for 'featuring' in the roles didn't catch it, but is found by the one that search for 'vocals' and the one that have rap is not cached at all
There are a lot of different scenarios and it is almost impossible to cover all.
That is basically why I used different tags mapping to search for specific strings in the credits roles like featuring, vocals, chorus, orchestra, etc. and tried to uses alternatives tags for the data written for the different sources.
First I get all the info then II apply a masstager script with all the common scenarios that I have found over time to format the data.
This cover almost 99%, But even with that, there are always releases that need a last manual intervention.

There is also a version of discogger in UI integration and credit templates that add an experimental mode to deal with credit tags that Includes public release v1.0.18 updates. Maybe in the future it will be included in the normal release.

I tried to make a tag formatting that search for various strings (for example featuring, rap, Scratches, etc i) in a single one allowing strings to be added as needed but I can't find a way to do it.
If anyone know how to do it, it will be very appreciated








Re: foo_discogs

Reply #3206 –
Thank you!





MOD edit: Removed unnecessary full quote

Re: foo_discogs

Reply #3207 –
Quote from: paregistrase on
...
There is also a version of discogger in UI integration and credit templates that add an experimental mode to deal with credit tags that Includes public release v1.0.18 updates. Maybe in the future it will be included in the normal release.

I tried to make a tag formatting that search for various strings (for example featuring, rap, Scratches, etc i) in a single one allowing strings to be added as needed but I can't find a way to do it.
If anyone know how to do it, it will be very appreciated

I hope the credit template feature can be included reasonably soon, but the concept is still quite unclear to me.
I will try to continue updating it to match the changes from the public releases.
In the meantime, the discussion is open to collaborations at the github repo.
Regards!

Re: foo_discogs

Reply #3208 –
Hey dear @da yuyu,
I have a couple of things I'd like to raise.

The first, and main, one is to do with filtering releases in the Find Releases dialog.
It seems like *some* details of the individual releases, when inside a master release, are accounted for in the filter, and some make it display no results.
For instance, I might want to be searching for ALBUM NAME but I only want releases from 2013, or I only want ones that match a particular catalog number, etc. I think this is how the old foo_discogs component worked, although it's been a while :)
It may be hard to make the filter apply to all details listed, given that we can use an arbitrary titleformatting string for each level of the releases window. But it would make a massive difference when there are a lot of variants!

The second one is that sometimes the component does switch to "skip artwork" even though I always have that unselected. I'm not quite sure under what circumstances it defaults to "skip artwork" I'm afraid.
I do want to skip cover.jpg if the file already exists, but that's a difference preference to the "skip artwork" checkbox.

Re: foo_discogs

Reply #3209 –
Hi @frogworth,
I am not sure about the arbitrary format part.
Is the filtering not already applying to all fields (all details listed) included in the master and release formatting strings?

Just as a refresher, here are the requirements to enable master version filtering:
- The search value should be included in the titleformat expression.
- The 'filtered versions' option should be enabled.
- The master (tree node) should have been previously loaded. On tree node expansion, the Discogs database is queried and the results are then added as master releases/versions. All branches already loaded are marked with a dot icon.

Are you suggesting modifying these requirements? In which way specifically? If this is just a case of a bug you found in the filtering, please provide test data so I can reproduce it.

About the second issue, Discogger v1.0.20.3 should fix it.

Re: foo_discogs

Reply #3210 –
Ahhhh thanks so much. I had missed part of that, or forgotten! Yes, with "filtered versions" checked, it does indeed filter like I was wanting!

And thanks for quickly releasing the fix for "skip album art". I'll test it over the next few days.

Re: foo_discogs

Reply #3211 –
you are welcome  :)
thanks for reporting!

Re: foo_discogs

Reply #3212 –
Since the last update, Discogger doesn't overwrite any existing values anymore. How do I fix this?

Re: foo_discogs

Reply #3213 –
@n99
I didn´t encounter any problem.
It could help providing some screenshots, maybe the preview panel displaying the stat columns.

Re: foo_discogs

Reply #3214 –
Discogger v1.0.20.4

Fixes:

    Mismatched master/release tree crash.
    Enter/Double click artist when preference option 'Auto-load releases opening Find Release' is disabled.

Re: foo_discogs

Reply #3215 –
Quote from: n99 on
Since the last update, Discogger doesn't overwrite any existing values anymore. How do I fix this?
I could solve the issue just moving the edge of the headlines in the panel of the tagging information because the information was hidden to the far right of the panel

Re: foo_discogs

Reply #3216 –
Hi @da yuyu
I want to show the number of discs in the search dialog for sub-releases. I've been tagging deluxe editions and the like, where the original is a single disc but the deluxe is multiple discs, and currently there's no way to tell in the search results.

However, I really don't understand the formatting for search. In the Master sub-release formatting string field, whenever I try to add anything like %RELEASE_FORMAT_QUANTITY% or %DISC_QUANTITY% or variants with SEARCH_ prepended, anything I add just makes foobar crash when opening up a master release.
I even tried %DISCOGS_FORMAT% which was referenced way up in this thread in the @zoomorph days, but... it crashed foobar too.
The included HTML help page is no help for this section of the config.

Can you shed any light?

Re: foo_discogs

Reply #3217 –
Hi @frogworth,
Check the default search formatting strings for reference, they make use of most available fields.
You can also open foo_discogger-cache\artist\12345\releases\page-0\root.json files. Each record contains the fields available at that stage. Currently, format quantities, as tracks, are unknown until the release referenced by each listed version is loaded individually.
I don't know if this might change in the future, as far as I know, is a Discogs API endpoint limitation.

Titleformat crashes should be addressed at some point. It might require a new preference option depending on what's the performance penalty, if any.

Re: foo_discogs

Reply #3218 –
Thanks @da yuyu
Weirdly, even though New Order's releases were cached, initially I had no 3909 folder in my foo_discogger_cache\artist folder.
So I deleted the whole thing and restarted foobar2000, and then it did appear.

I've also now made some direct API queries, and yes I can see that there is nothing in the JSON response that refers to the number of discs or anything like that. (Not that I mistrusted you!)
It's strange as I do recall being able to scroll through the sub-releases in the past and see something that indicated something was a multi-disc set. I must have imagined it!

It's frustrating then, because on the master release on the Discogs site, you get this kind of thing, e.g. for https://www.discogs.com/master/4071-New-Order-Power-Corruption-Lies
CD, Album, Reissue; CD, Compilation; All Media, Remastered

More starkly, AFX SAW II:
https://www.discogs.com/master/481-Aphex-Twin-Selected-Ambient-Works-Volume-II
All the versions have something like:
2XCD, Album, Reissue

If I did use to see that in the foo_discogs search results, I guess it was either returned in format, which currently just holds "Album, Reissue", or somehow in the major_formats array.
But nope. The info's just not available from the masters endpoints.
Geez, Discogs.

Re: foo_discogs

Reply #3219 –
I'm trying to migrate to 64 bit and am trying out discogger.  Everything works as expected except the track title field is not being written correctly.  All I'm getting is 01, 02, 03... instead of the actual track titles.  Discogger appears to have the correct mapping, TITLE is set to %TRACK_TITLE% but no joy.  What am I missing?

Re: foo_discogs

Reply #3220 –
You could try adding a new tag MYTITLE also as %TRACK_TITLE% and check the result in the preview panel.
Is it also failing in a new portable installation?

Re: foo_discogs

Reply #3221 –
I tried your suggestion and got the same result as the TITLE field.  So I tried this script which grabs the text after the last " - ":

$trim($right(%TRACK_TITLE%,$sub($len(%TRACK_TITLE%),$strrchr(%TRACK_TITLE%,'-'))))

It works, but not if the field is called TITLE.  I have to call it something else.  I tried pasting the script into the TITLE Formatting String field and it didn't work, the results were still 01, 02, 03...  This seems like a bug, but I don't feel qualified to say for sure.

Re: foo_discogs

Reply #3222 –
So with the script still in the TITLE field, the next disc I did did load the titles correctly.  Apparently when you hit Apply in the Tag Mapping window not everything is actually applied to the current preview.  It seems my problem has been solved.  Thanks!

Re: foo_discogs

Reply #3223 –
I was wrong, my problem still exists.  When I tried tagging again with the script in the TITLE field it was a disc that had already been done.  I had removed the tags with MP3Tag but apparently Foobar remembered what they were.  When I tried it on a new disc I got the same results - 01, 02, 03...  While I can move the MYTITLE field to the TITLE field by using Format from other fields... and entering %MYTITLE% it's a couple extra steps since I then have to delete the MYTITLE field.  So, I'm going back to thinking this is a bug.

Re: foo_discogs

Reply #3224 –
@xsdaver This sounds like there's something else janky with your foobar config. Is there any chance you have something setup unusually? e.g. in the Advanced section of Preferences, there's a Standard fields section, which I have as:
Code: [Select]
Artist Name=ARTIST;Track Title=TITLE;Album Title=ALBUM;Date=DATE;Genre=GENRE;Composer=COMPOSER;Performer=PERFORMER;Album Artist=ALBUM ARTIST;Track Number=TRACKNUMBER;Total Tracks=TOTALTRACKS;Disc Number=DISCNUMBER;Total Discs=TOTALDISCS;Comment=COMMENT;
Probably a red herring, but worth checking.
Also, as @da yuyu suggested, can you try installing a new portable installation, separately so that it's got default Preferences, install foo_discogger and setup the mappings the same, and see if the problem is still there?