Very interesting project, congratulations!
Thank you
- mp3 - seeking does not work, ape2 tags are not recognized. This is not important at all, because I doubt that somebody will replace the original nullsoft plugin, but might give you some hints if something is not working as expected;
This plug-in is heaviliy based on FFmpeg. The idea ist to let all this decoding stuff done by FFmpeg and only use FFmpeg's format independent API. Put into other words, all these features depend on what is implemented in FFmpeg.
FFmpeg's MP3 demuxer doesn't provide seeking yet:
AVInputFormat mp3_demuxer = {
"mp3",
NULL_IF_CONFIG_SMALL("MPEG audio layer 2/3"),
0,
mp3_read_probe,
mp3_read_header,
mp3_read_packet,
.flags= AVFMT_GENERIC_INDEX,
.extensions = "mp2,mp3,m2a", /* XXX: use probe */
.metadata_conv = ff_id3v2_metadata_conv,
};
The OGG demuxer instead does:
AVInputFormat ogg_demuxer = {
"ogg",
NULL_IF_CONFIG_SMALL("Ogg"),
sizeof (struct ogg),
ogg_probe,
ogg_read_header,
ogg_read_packet,
ogg_read_close,
ogg_read_seek,
ogg_read_timestamp,
.extensions = "ogg",
.metadata_conv = ff_vorbiscomment_metadata_conv,
.flags = AVFMT_GENERIC_INDEX,
};
The MP3 demuxer's "metadata_conv" is set to "ff_id3v2_metadata_conv", obviously only ID3v2.
FFmpeg is a very vital project. Propably someday all the missed features will be implemented. The FFSoX Player plug-in is only some kind of glue bringing FFmpeg into Winamp.
- ogg (with tags) crash the WA 5.581, didn't crash 5.71. Not a big issue since there is an official plugin from nullsoft;
- both musepack sv7 and sv8 formats crash WA at EOF (with WA 5.71 only sv8 format had problems). This is important, because there is no official stable plugin from nullsoft.
First I have to have a closer look at this.
- rg data ae not recognized for any file I've tested.
I run this plug-in myself using replay gain, especially for FLAC and MP3, and it seems to work. Which formats are you using?