[POINTLESS] adplug component: many formats can't be played

Topic: [POINTLESS] adplug component: many formats can't be played (Read 2777 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

[POINTLESS] adplug component: many formats can't be played

2020-08-02 13:46:59

Attached a zip file which contains files that don't play in adplug component.
I can successfully play those files in another windows player and in an android player that both use adplug (latest version).

There is nothing wrong with the files, they are downloaded from a music FTP server, so "Unsupported format or corrupted file" is definitely not correct.
They are all supported by adplug but don't work in the component but other players play them correctly!

The log of the files that don't play:

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\allfaith.rol"

Unable to open item for playback (Unsupported file format):
"C:\Users\gebruiker\Desktop\files\files\authentic adlib attempt.as3m"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\ballad.a2m"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\ballad.a2m"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\cc1 arabic.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\cc1 fastmarch.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\cc1 fastmarch.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\ice think2.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\ken's labyrinth - begin.ksm"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\ken's labyrinth - labsng05.ksm"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\ken's labyrinth - labsng05.ksm"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\kq1 dance.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\kq1 dance.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\kq1 title.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\kq1 title.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\larix - cmus01.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\larix - cmus01.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\larix - lmus03 d.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\larix - lmus03 d.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\lb1 entertainer5.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\lb1 entertainer5.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\lb1 mushy.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\lb1 mushy.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\lb1 revere.sci"

Unable to open item for playback (Unsupported file format):
"C:\Users\gebruiker\Desktop\files\files\logical - 13310.plx"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\files\files\song1.sng"

Re: adplug component: many formats can't be played

Reply #1 – 2020-08-02 13:48:35

In addition, as you can see in the log, the component reports error message TWICE for the same file.
This is another bug

Re: adplug component: many formats can't be played

Reply #2 – 2020-08-03 00:17:51

Please report all file format bugs to AdPlug team, as I do not use any altered reading routines. Unless you are implying that 100% of this archive is playable with the Winamp plugin in its current state.

The .as3m could be played with foo_openmpt54 as well, if named simply .s3m.

Re: adplug component: many formats can't be played

Reply #3 – 2020-08-03 02:17:00

Sorry but you suggest I verify if the formats play using an outdated winamp plugin (who knows what adplug version it uses) on a player that is terminated (winamp)?!?

Not really a 'reference' way for adplug according to me?
First the winamp plugin is probably not up to date and second I'll have to use a winamp version somewhere on some archive site or a leaked beta on winamp.com. The player is dead.

So since I don't want to do this, you think all problems are inside adplug because you just use their reading routines return code?

Is it correct you just write the error message to the console in foobar when adplug's reading routine returns 'false'?

If yes, accept my apologies and I'll report all this on adplug's github!

I think it are a lot of formats that don't play correctly. Adplug is very buggy it seems?

thx

Re: adplug component: many formats can't be played

Reply #4 – 2020-08-03 02:18:39

Additional question which has nothing to do with adplug: why are the errors reported twice for most of the files and for some (see screenshot) only once?

Could this be a bug in your component code?

Thx

Re: adplug component: many formats can't be played

Reply #5 – 2020-08-03 04:43:20

Sorry, once again, being rude. I thought there was an up to date official plugin or player binary from AdPlug. If there is not, there's not much I can do to ask you to verify errors.

For now, you can also check the Console: Open the View menu, and select Console. Monitor this log for any errors emitted by AdPlug.

Some of those files may not work as-is. For one thing, I don't know if the extension I created to make AdPlug play S3M files was as3m, or s3ma. Please try them both, or also try plain .s3m. Do note that both of my plugins which support .S3M files, AdPlug and OpenMPT, support FM modules.

Also, some of those files, like .rol files, require an instrument bank file to be located in the same directory as the .rol files.

I'll look into all of these later.

Re: adplug component: many formats can't be played

Reply #6 – 2020-08-03 13:49:47

Thx! I try, but as you can see, it's not easy because there is no "reference" player for AdPlug...

I'm also comparing with an Android player AndPlug which I help to test/request features which is based on very latest AdPlug:

https://play.google.com/store/apps/details?id=com.omicronapplications.andplug

I try to find out which files behave the same across foobar2000 and AndPlug.

Re: adplug component: many formats can't be played

Reply #7 – 2020-08-03 16:05:14

Quote from: kode54 on 2020-08-03 04:43:20

Some of those files may not work as-is. For one thing, I don't know if the extension I created to make AdPlug play S3M files was as3m, or s3ma. Please try them both, or also try plain .s3m.

This problem is already solved! You made a typo in the code, it really must be as3m because when I rename it to s3ma, the file plays correctly.
Also on all FTP servers I used, they all have extension as3m. I never saw s3ma.

According to this website, a Scream Tracker 3 Adlib module has extension .as3m (and s3ma is not used):

http://fileformats.archiveteam.org/wiki/Audio_and_Music

Can you add (or replace) the as3m extension?

Re: adplug component: many formats can't be played

Reply #8 – 2020-08-03 16:18:29

Hi

Did you change anything else then the removal of 0-length songs in version 1.54?

- Because compared to 1.53, this file now plays (suddenly): logical - 13310.plx
while it didn't play in 1.53!

- also the double errors in playback error window are gone too: each file is reported once now

Here is the new log (ignoring the as3m file extension, because this problem is identified now):

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\allfaith.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\ballad.a2m"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\cc1 arabic.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\cc1 fastmarch.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\ice think2.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\ken's labyrinth - begin.ksm"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\ken's labyrinth - labsng05.ksm"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\kq1 dance.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\kq1 title.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\larix - cmus01.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\larix - lmus03 d.rol"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\lb1 entertainer5.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\lb1 mushy.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\lb1 revere.sci"

Unable to open item for playback (Unsupported format or corrupted file):
"C:\Users\gebruiker\Desktop\test\song1.sng"

Re: adplug component: many formats can't be played

Reply #9 – 2020-08-03 19:47:45

Hi

More weird problems.

If you drag-and-drop a file from windows explorer into the foobar playlist, all files can be added to the playlist.

However if I choose File -> Add folder, the as3m files are NOT added to the playlist.
Does this mean file extensions in foobar are set by the installed components?
If this is true, the adplug component does not set the as3m extension in current version.

I also found a weird thing in the console (after renaming as3m to s3ma in order to add it to the playlist) when trying to play a s3ma file (which plays correctly):

Opening track for playback: "C:\Users\gebruiker\Desktop\test2\authentic adlib attempt.s3ma"
*** CAdPlug::factory("file://C:\Users\gebruiker\Desktop\test2\authentic adlib attempt.s3m",opl,fp) ***
Trying direct hit: Scream Tracker 3
got it!
--- CAdPlug::factory ---

It changed the s3ma to s3m extension when passing it the the CAdPlug::factory()
No idea why an extension should be changed?

thx

Update: please ignore "Because compared to 1.53, this file now plays (suddenly): logical - 13310.plx while it didn't play in 1.53!".
This is an unsupported format in Adplug I think (Palladix module).

Re: adplug component: many formats can't be played

Reply #10 – 2020-08-04 01:17:27

AdPlug doesn't register the .as3m or the .s3ma extensions, I had to add that to the plugin myself. For such extensions, it has to fool the AdPlug library with the extension, and transparently add the extra letter when opening the file.

I don't know why anyone needs to rename their Adlib S3Ms any more anyway, libOpenMPT supports them fully as well, as does OpenMPT the tracker. foo_dumb is an exception, it never properly supported AdLib modules, my attempt to add support for them was a bit of a hack.

Edit:

ballad.a2m: AdPlug supports AdLib Tracker 2 version 1, 4, 5, and 8. This file is version 9. I have no idea what to do with that.

*.rol: These are Adlib ROL format, and require an instrument bank in the same directory as the song files. It needs to be called "standard.bnk". AdPlug's source code comes with a usable copy from its "test" folder.

*.sci: These are MIDI files that require their specific games' Adlib patch banks. Each game's files should be separated into its own folder, and a "???PATCH.003" file ripped from their game should be placed in the same folder as that game's files. AdPlug comes with a copy for "ice*" whichever game that is. For instance, cc1*.sci needs cc1patch.003, kq1*.sci needs kq1patch.003, lb1*.sci needs lb1patch.003.

*.ksm: Ken's synthesizer music format. These need the "insts.dat" file ripped from Ken's games, or supplied from his web site, since I think he used a single large instrument bank for all of his compositions. AdPlug source comes with a copy, not sure how complete it is.

*.as3m: AdPlug neither supports ".as3m" nor ".s3ma", I merely transparently support these decorated extensions. OpenMPT would be a better player for these files, because you never know if you'll run into a file that also has samples, and yes, Scream Tracker 3 did support simultaneous use of samples and AdLib instruments. I'll see about adding this extension to both OpenMPT and my AdPlug plugins.

*.plx: No idea what format this is, AdPlug doesn't support it.

*.sng, size 36000 bytes: These appear to be the original AdPlug Tracker. filename.sng needs a 468 byte file accompanying it, called filename.ins. So, song1.sng needs song1.ins.

That about covers all of the files in that archive which don't work.

Re: adplug component: many formats can't be played

Reply #11 – 2020-08-04 12:26:13

Quote from: kode54 on 2020-08-04 01:17:27

ballad.a2m: AdPlug supports AdLib Tracker 2 version 1, 4, 5, and 8. This file is version 9. I have no idea what to do with that.

ADT2Plug (scroll down to PC/OPL3 section) for Winamp/XMplay supports this format/file version among many others. Its replay core is far more accurate and closer to the original trackers than AdPlug. Unfortunately the author never released a foobar2000 compatible version due to issues related to foobar2000's SDK (his words).
Download: ADT2 input plugin v2.4.24

Also you could try the original Adlib Tracker II, a Windows compatible version is available for download, too.
Download: AdlibTracker2_SDL_2.4.24 for Windows

Quote from: kode54 on 2020-08-04 01:17:27

*.plx: No idea what format this is, AdPlug doesn't support it.

PLX is an AdLib music format called Palladix and was used in the game Logical by Rainbow Arts.

Re: adplug component: many formats can't be played

Reply #12 – 2020-08-04 15:58:26

To kode54: how do you find out all the instrument banks and their names?
Are you using a tool for this?

I have no idea how to verify what each file needs.

Or is your music file format knowledge so advanced you just open a file in an editor and you can see inside what it needs?

Re: adplug component: many formats can't be played

Reply #13 – 2020-08-05 00:27:29

By reading the AdPlug source code.

Binaries for other players are also useless, unless you want to use another player. Have fun with that.

Re: adplug component: many formats can't be played

Reply #14 – 2020-08-05 08:03:35

Quote from: kode54 on 2020-08-05 00:27:29

Binaries for other players are also useless, unless you want to use another player. Have fun with that.

AdPLug does not support AdLib Tracker 2 file version 9 and up. I provided alternatives so jessicaj and other interested users would be able to actually listen to them. My suggestions weren't necessarily addressed to you, I think you would know your way around.

Re: adplug component: many formats can't be played

Reply #15 – 2020-08-05 13:37:14

To kode54: could you also write to the foobar console (for adplug and openmpt component) if an instrument bank is missing (when a file can't play) and the name of the instrument bank?

thx

Re: adplug component: many formats can't be played

Reply #16 – 2020-08-07 03:17:29

To kode54

Is it possible to add the as3m file extension to your adplug and openmpt components, please?

I can't add them using 'add folder' now and need to drag and drop them from windows explorer because the extension is not in your components.

thx in advance!!!

Notice