Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1281247 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

REACT 2 Released

Reply #850 –
Aaarghhh! I'm sure that I'm going to get hanged from doing the following:

Possible *ahem* problem in REACT 2.0.ssb16k.au3.
Code: [Select]
Line #928: If $hasCue Or $g_track = $g_numtracks Then'

Again, it's the DATA track in cd problem; EAC reports wrong last track number thru command line options. The $g_numtracks variable is read from the command line options ($g_numtracks = Int($CmdLine[9])). So, the line above works only if the first condition is met. If I'm reading it right.. strange to see comparisons with only one "=" char.

Possible solution:

Make a temp cue file also in track mode and read the REAL last AUDIO track number like in my solution: FINDSTR /R "TRACK.[0-9][0-9].AUDIO" "@albumfile@.[mg].cue". Delete temp cue file. Assign the new value to $g_numtracks_fn which is the $numtracks$ in bat-file. Strip leading zeros from the new value and assign the value to $g_numtracks which is the @numtracks@ in bat-file.

OT: And Synthetic Soul, if you're reading this.. I didn't push the On-button yet in my "your-pc-remote-controller" ™.

REACT 2 Released

Reply #851 –
Quote from: Akkurat on
LINE #1025 : $str = fStringReplaceForDOS($str, "@albumfile@", StringReplace($g_albumfile, "'", " "))
   LINE #1027 : $str = fStringReplaceForDOS($str, "@cover@", StringReplace($g_cover, "'", " "))
   LINE #1028 : $str = fStringReplaceForDOS($str, "@eaclog@", StringReplace($g_eaclog, "'", " "))
   
   Would that suffice? Only changes these variables in bat-file.
No.  That's the point: with such code you are blanket-replacing all apostrophes with a space (as per 2.0.ssb16j).  That's OK if the apostrophe began life as a double quote, but what if it really is an apostrophe and therefore should stay as such?

There is no simple answer, we must make a few checks to see what actually exists.

Edit: if you're still confused about the problem, try testing (which you appear to enjoy) both j and k with artist/album names with both an apostrophe and a double quote.  This is what you find:

Code: [Select]
Artist: ab'de"g
Album:  ab'de"g

EAC    ab'de g - ab'de g
b16j   ab de g - ab de g
b16k   ab'de'g - ab'de'g
I'm on a horse.

REACT 2 Released

Reply #852 –
Quote from: Synthetic Soul on
Quote from: Akkurat on
LINE #1025 : $str = fStringReplaceForDOS($str, "@albumfile@", StringReplace($g_albumfile, "'", " "))
   LINE #1027 : $str = fStringReplaceForDOS($str, "@cover@", StringReplace($g_cover, "'", " "))
   LINE #1028 : $str = fStringReplaceForDOS($str, "@eaclog@", StringReplace($g_eaclog, "'", " "))
   
   Would that suffice? Only changes these variables in bat-file.
No.  That's the point: with such code you are blanket-replacing all apostrophes with a space (as per 2.0.ssb16j).  That's OK if the apostrophe began life as a double quote, but what if it really is an apostrophe and therefore should stay as such?

There is no simple answer, we must make a few checks to see what actually exists.

Edit: if you're still confused about the problem, try testing (which you appear to enjoy) both j and k with artist/album names with both an apostrophe and a double quote.  This is what you find:

Code: [Select]
Artist: ab'de"g
Album:  ab'de"g

EAC    ab'de g - ab'de g
b16j   ab de g - ab de g
b16k   ab'de'g - ab'de'g


Yes, I do get it finally.. my test values had no apostrophes at all, just double quotes. That's why my perception to this issue was flawed. This is pretty confusing problem like you said earlier.

Did you test with those values yourself? I stumbled into another problem with your test set. With those values 2.0.ssb16j runs first normally the gap detection, then EAC/REACT creates this file "ab'de g.cue" (very strange) and then everything stops! Also the REACT info text vanishes from the EAC window title. When I close EAC, REACT doesn't close itself.

Same thing when album=ab'de"g & artist=abde"g. BUT everything works with album=abde"g & artist=ab'de"g.

BUT this doesn't happen with 2.0.ssbb16k. It works fine.

(I restarted EAC/REACT between tests. And all tests were made with track mode)

This observation is of course obsolete since the 2.0.ssb16j changes are not implemented in the future. Still it leaves me somewhat baffled.. maybe you should take a look what caused it.. just in case?

REACT 2 Released

Reply #853 –
Quote from: Synthetic Soul on
Quote from: Synthetic Soul on
I am currently thinking of a few options:
  • Record the true value from the wrapper instance (grabbed directly from the main dialogue) in the INI to read later.  This may have issues when considering the compression queue or dual processors.
  • Trawl the working directory for any ".log" file - if there's only one assume it is ours.  If there's more than one use an algorithm to detirmine which is most likely ours.  Yuck.
  • Maybe the processing instance can re-grab the value from the EAC dialogue... unsure.  Yuck II.
  • I'm sure  had another one, but it's gone...
I think I remember #4, and it's the likely candidate at the moment.

Currently, due to the change in log file naming EAC introduced in 0.99 the code checks for both expected formats in a loop, and exits when one is found.  Using a couple of loops I could check each permutation of the filename with apostrophes replaced or not replaced.  If a match is found we have a winner.  Alternatively, and preferably, I would hope that I should be able to use a regular expression to match the filename, replacing ' with [' ], e.g.:

Code: [Select]
Synthetic 'Saddo' Soul

... to:

Code: [Select]
  Synthetic [ ']Saddo[ '] Soul


I'll let you know how I get on.

Bubblegum solution #2 - A New Hope:

Use EACs menu: Database -> Export CD Information To -> Text File...

It should be "really easy" to read that file and get all proper values for album, artist and tracknames. The only true problem is to detect the (example) "CD: ab'de"g - ab'de"g" line in the file. How do we know where the "-" breaker for the artist & album really is if there's more than one "-" char in that line. Solution: we certainly know the EAC escaped values, so, compare the lengths of both and "explode" (PHP func., don't know the proper one in autoit) that line into proper artist & album variables. Tadaaaa. It's not elegant solution but I think that it should work. Plus, this way we could use proper tracknames (with double quotes) in tagging (implies that the double quotes should be escaped). This though won't solve the "DATA track in CD numtracks variable" problem, you can't tell the difference if the last track is or is not a data track.

I'm in no hurry to solve this, just trying to help.

OT: About me enjoying to test; actually I don't. It's just a hurdle when I try to reach my goal, which is in this case to get the REACT work like I want it to work. I just take a program and use it, if it doesn't work the way it is supposed, I might drop the program or I take the long and time consuming road to report problems. I can honestly say that I will find a bug in 99% of programs I try, and I usually find them in 15 minutes or less. Without bug seeking that is. And I'm not boasting.. mostly it's a drag.

REACT 2 Released

Reply #854 –
It is possible to setup a profile for REACT in EAC, and then I can just switch between REACT and my other profiles using the dropdown at the bottom of the EAC screen.

Currently I have an EAC icon and a REACT2 icon on my desktop. If I want to revert back to EAC without REACT I have to load the EAC icon and then (even though its already loaded) load say an MP3 or FLAC profile in order to clear REACT2 settings.

Of course when I want to go back to REACT2 I have to come out of this and load the REACT2 icon. Hit CtrlF2 to reset things. It would be easier to just have a single EAC icon and switch between profiles as needed

REACT 2 Released

Reply #855 –
Quote from: gsa999 on
Of course when I want to go back to REACT2 I have to come out of this and load the REACT2 icon. Hit CtrlF2 to reset things. It would be easier to just have a single EAC icon and switch between profiles as needed


I'm not entirely sure why you need to switch back to the plain EAC if you don't want to use REACT, just launch it with react and use it as normal. You shouldn't need to use the ctrl+f2 every time, just hit ctrl+f2 and then save all options as the "react profile", and then fill in your own settings and save it as the 'regular' profile.

1) If there are functions you wish to access that REACT hotkeys over, just use the functions from the dropdown menus.
2) OR, you can reassign the hotkeys that react overwrites in the .ini file, or edit them in the sourcefile included, recompile with autoit3 if needed.
3) Or you can "pause" the REACT script by clicking the EAC icon in the toolbar, this will stop react from interfering with anything at all as far as I'm aware-- this is probably the easiest option.

So you can just launch EAC+React, then if you want to switch to a "regular" eac profile, just click pause and load the profile, do what you need to, switch the profile back, unpause, etc. It's still not a remarkably brilliant solution, but it beats having to close and reload the program a lot...

REACT 2 Released

Reply #856 –
Quote from: Akkurat on
Did you test with those values yourself? I stumbled into another problem with your test set. With those values 2.0.ssb16j runs first normally the gap detection, then EAC/REACT creates this file "ab'de g.cue" (very strange) and then everything stops! Also the REACT info text vanishes from the EAC window title. When I close EAC, REACT doesn't close itself.

Same thing when album=ab'de"g & artist=abde"g. BUT everything works with album=abde"g & artist=ab'de"g.
Remember, EAC uses the album name to name the cuesheets that REACT then tries to indentify and move.  This is all linked to the double quote/apostrophe issue.

I believe I have worked around the issue now, you will find 20.0ssb16l on the mods wiki page.  The log file should be identified in all (known!) situations now.  You will note that the cuesheets and cover art will replace double quotes with an apostrophe rather than a space.  This was to make things easy for the processing instance which cannot rely on a cuesheet or image to detirmine EAC's format, unlike the the log file, which we know will exist.  This is not an issue, as users will no doubt be renaming these files anyway. As long as REACT is consisent, and can always identify these files, everything is just fine.

Quote from: Akkurat on
Bubblegum solution #2 - A New Hope:

Use EACs menu: Database -> Export CD Information To -> Text File...
Yes, this information could potentially be useful.  I have previously toyed with the DB Text File option: the export format can be set by REACT making it easy to extract useful values like the artist, album, and disc CRC (which could be useful for the compression queue - see posts RE: b17).

I have been thinking recently (again) about the prospect of forcing a cuesheet to be generated, irrespective of the CreateAllCuesheets value, when a user rips to tracks.  I wonder now whether forcing a cuesheet, and/or the DB Text File would be prudent.  These files could contain all the information that is currently not satisfactorily retrieved from EAC.

That said, I am thinking more about rewriting, than hacking about with the existing source any further.  Unfortunately I just don't think I can find the time.  I'm losing interest in hacking the source further though, especially considering that I rip to images and REACT will perform absolutely fine in 99.5% of situations.  Resolving those other 0.05% of issues seems to call for a re-think of the way that REACT interacts with EAC, and I'd feel happier working from the ground up than hacking the source any further.

I can see why tycho often spoke of dropping track-ripping from REACT.  At one point, IIRC, he was very close to creating a cut down version of  REACT that only worked with image ripping.

Quote from: Akkurat on
OT:  About me enjoying to test; actually I don't. It's just a hurdle when I  try to reach my goal, which is in this case to get the REACT work like  I want it to work. I just take a program and use it, if it doesn't work  the way it is supposed, I might drop the program or I take the long and  time consuming road to report problems. I can honestly say that I will  find a bug in 99% of programs I try, and I usually find them in 15  minutes or less. Without bug seeking that is. And I'm not boasting..  mostly it's a drag.
I assume that you must have had some problem while ripping normally that I have not seen, and then decided to test fully.  None of the reports that you have made to me have come from normal CD ripping.  You have been testing illegal filename characters, checking the source code, and ripping in both track and image mode - with all values of RunCoverDownloader set!  That's not normal.

As far as I can think, your reports have enabled me to resolve the log file naming bug (I hope), the album art command line bug, and the RunCoverDownloader settings bug.  Whatever you're doing, it's been useful.
I'm on a horse.

REACT 2 Released

Reply #857 –
I'll post this first and then I'm going to test the new version and I'll answer your last post Synthetic Soul (almost used "SS" abbr., you may not like that ). (btw. what "see posts RE: b17" means? b17?)

I bumped on to something peculiar when I was creating my "data track backup to \data subfolder" feature to REACT. Here's my notes:

Now I'm getting little frustrated myself, I'm seriously thinking about ditching REACT.. but I can't, already used so much time for this. The new "PROBLEM" is that I noticed that EAC/REACT sometimes creates wrong cuefiles! Yes! Jippikaijei*********. I'm so happy now.  And of course I can't reproduce this properly, it behaves randomly.. again.  Sometimes I see that M, MC & MG cues are exatly the same. Sometimes MG is same as the S cue, sometimes all are different. Sometimes some cuefile(s) is/are missing. Sometimes S cue file has only 2 lines (REM DISCNUMBER 1 ... REM TOTALDISCS 1), etc. Sometimes I do think that my head is going to explode. As you can see, there are multiple variations and they appear randomly.

Tested with same CD w/ data track in track mode with 2.0.ssb16k. At least, to my understanding, S and MG cues should be different from M and MC cues (should there be always a difference between M and MC cues?) everytime if there's a data track on CD. If I manually create the cuefiles from EAC menu, I get different S, MG and M/MC (both same, no special gaps/indexes(?) and that's why they're same?) cuefiles. I really don't understand what's going on. Any tips how to test this more?

REACT 2 Released

Reply #858 –
Quote from: Akkurat on
(btw. what "see posts RE: b17" means? b17?)
It means: if you want to know more about the subject, read the posts in this thread discussing 2.0ssb17.

Quote from: Akkurat on
I bumped on to something peculiar when I was creating my "data track backup to \data subfolder" feature to REACT. Here's my notes:

Now I'm getting little frustrated myself, I'm seriously thinking about ditching REACT.. but I can't, already used so much time for this. The new "PROBLEM" is that I noticed that EAC/REACT sometimes creates wrong cuefiles! Yes! Jippikaijei*********. I'm so happy now. wink.gif And of course I can't reproduce this properly, it behaves randomly.. again. sad.gif Sometimes I see that M, MC & MG cues are exatly the same. Sometimes MG is same as the S cue, sometimes all are different. Sometimes some cuefile(s) is/are missing. Sometimes S cue file has only 2 lines (REM DISCNUMBER 1 ... REM TOTALDISCS 1), etc. Sometimes I do think that my head is going to explode. As you can see, there are multiple variations and they appear randomly.

Tested with same CD w/ data track in track mode with 2.0.ssb16k. At least, to my understanding, S and MG cues should be different from M and MC cues (should there be always a difference between M and MC cues?) everytime if there's a data track on CD. If I manually create the cuefiles from EAC menu, I get different S, MG and M/MC (both same, no special gaps/indexes(?) and that's why they're same?) cuefiles. I really don't understand what's going on. Any tips how to test this more?
I can see how this might happen (for you).  EAC creates all of the four cuesheets as "<album>.cue" and REACT renames them.  Presumably a cuesheet is not getting renamed, or created, so REACT is renaming the wrong cuesheet, expecting it to be a different cuesheet than it actually is.  I can't tell you how this is happening, or whether b16l will resolve it, but I can see how it could happen.  And if it's going to happen, it seems that it is going to happen to you.

I think you are right regarding the M and MC cuesheets being the same on occassion.
I'm on a horse.

REACT 2 Released

Reply #859 –
Quote from: Synthetic Soul on
Quote from: Akkurat on
I bumped on to something peculiar when I was creating my "data track backup to \data subfolder" feature to REACT. Here's my notes:

Now I'm getting little frustrated myself, I'm seriously thinking about ditching REACT.. but I can't, already used so much time for this. The new "PROBLEM" is that I noticed that EAC/REACT sometimes creates wrong cuefiles! Yes! Jippikaijei*********. I'm so happy now. wink.gif And of course I can't reproduce this properly, it behaves randomly.. again. sad.gif Sometimes I see that M, MC & MG cues are exatly the same. Sometimes MG is same as the S cue, sometimes all are different. Sometimes some cuefile(s) is/are missing. Sometimes S cue file has only 2 lines (REM DISCNUMBER 1 ... REM TOTALDISCS 1), etc. Sometimes I do think that my head is going to explode. As you can see, there are multiple variations and they appear randomly.

Tested with same CD w/ data track in track mode with 2.0.ssb16k. At least, to my understanding, S and MG cues should be different from M and MC cues (should there be always a difference between M and MC cues?) everytime if there's a data track on CD. If I manually create the cuefiles from EAC menu, I get different S, MG and M/MC (both same, no special gaps/indexes(?) and that's why they're same?) cuefiles. I really don't understand what's going on. Any tips how to test this more?
I can see how this might happen (for you).  EAC creates all of the four cuesheets as "<album>.cue" and REACT renames them.  Presumably a cuesheet is not getting renamed, or created, so REACT is renaming the wrong cuesheet, expecting it to be a different cuesheet than it actually is.  I can't tell you how this is happening, or whether b16l will resolve it, but I can see how it could happen.  And if it's going to happen, it seems that it is going to happen to you.

LOL! LOLAIAFOTC (...And I Almost Fell Off The Chair).  Funny stuff. Rather perceptive of you, it certainly happens to me if it's going to happen at all.. I don't know whether to cry or laugh.

But, dear Watson, the worrying part is that I used "abdegg" (w/o quotes) in album name. So the new version should not correct this.. it might but I think it's fair to say that most probably it wont.

REACT 2 Released

Reply #860 –
Quote from: Akkurat on
But, dear Watson, the worrying part is that I used "abdegg" (w/o quotes) in album name. So the new version should not correct this.. it might but I think it's fair to say that most probably it wont.
I hadn't actually presumed that this was the double quote issue rearing its head again.

I just think that something is interrupting the normal process, causing your issue.  Somehow the process is getting confused, or out of synch.

As I previously asked nago: do you set REACT going and then leave the PC alone, or do you start switching windows, etc.?  Given REACT's requirement to interact with EAC via key strokes and menu commands it is always best to just leave it be - certainly until the CD has started ripping.

As you can imagine, I have never noticed this issue myself.  I did a test when you posted and all cuesheets were as expected.  And again, this is the first report.
I'm on a horse.

REACT 2 Released

Reply #861 –
Quote from: Synthetic Soul on
Quote from: Akkurat on
But, dear Watson, the worrying part is that I used "abdegg" (w/o quotes) in album name. So the new version should not correct this.. it might but I think it's fair to say that most probably it wont.
I hadn't actually presumed that this was the double quote issue rearing its head again.

I just think that something is interrupting the normal process, causing your issue.  Somehow the process is getting confused, or out of synch.

That's what I'm wondering too, but I can't pinpoint the true culprit.

Quote from: Synthetic Soul on
As I previously asked nago: do you set REACT going and then leave the PC alone, or do you start switching windows, etc.?  Given REACT's requirement to interact with EAC via key strokes and menu commands it is always best to just leave it be - certainly until the CD has started ripping.

Yes, I thought of this, I have read every post in this thread. I just press F4 and let it do the gap analyzing and cuesheet creation. I always wait until the actual ripping window starts.

Quote from: Synthetic Soul on
As you can imagine, I have never noticed this issue myself.  I did a test when you posted and all cuesheets were as expected.  And again, this is the first report.

I know, I have read all the posts as I said. This problem is hard because sometimes the proper cuesheets are created. I usually don't want to report problems if I can't reproduce them everytime with same settings/steps.
 

REACT 2 Released

Reply #862 –
And for those who want multiprocess support, I've applied my changes to ssb16l for react20ssb16kl+n2 .. full list of edits (there aren't very many) included for those who have modified their cfgs and au3 files in other ways already.

Synthetic Soul: Sorry it's been such a hassle for you lately, but I thought I'd chip in my two cents again and let you know that your support of tracks extraction mode has been fantastic and I'm very glad you haven't dropped it yet. If you do decide to do a ground-up recode of REACT, I'd be more than willing to help you test it. Please let me know if there is anything I can do for you as repayment for this last week. Please.

--N

REACT 2 Released

Reply #863 –
Quote from: nago on
Synthetic Soul: Sorry it's been such a hassle for you lately, but I thought I'd chip in my two cents again and let you know that your support of tracks extraction mode has been fantastic and I'm very glad you haven't dropped it yet. If you do decide to do a ground-up recode of REACT, I'd be more than willing to help you test it. Please let me know if there is anything I can do for you as repayment for this last week. Please.
It's only been a problem as it's come at a time when I have various other things on my mind.  Bug-fixing REACT is a love/hate thing with me.  As you pointed out, I should really just give myself more time to tackle things, than feel that I need to do them immediately.  It's a dichotomy: I really enjoy the challenge of problem-solving, but I don't really have the free time to spend the time that I need to, so I feel pressured and frustrated.

I'm not sure that I will ever find time to rewrite REACT unfortunately.

Good work with the dual processor changes.  At this time I see no need to incorporate them into my mod.  As you have upgraded to the b16l code users can simply use your EXE.  As I say, I am losing interest in stretching REACT 2 any further.  Maybe that will change in the future when I feel less busy.
I'm on a horse.

REACT 2 Released

Reply #864 –
Quote from: Synthetic Soul on
I'm not sure that I will ever find time to rewrite REACT unfortunately.


Ah, just trying to offer repayment for driving you nuts. If you ever need a guinea pig just give me a ring. =) I'll be looking into autoit code and seeing if I can't patch up a few things on my own, I'll post some changes to the wiki if you'd like, though I doubt I have the capacity to do any serious bugfixes at the moment.

Cheers!

REACT 2 Released

Reply #865 –
Hello everyone,
I just reinstalled my XPs and my EAC/REACT system, and have trouble running the metadata Alt-F5dialogue. I have the 16l version from SynthS's site, linked from HA wiki:
http://www.synthetic-soul.co.uk/temp/REACT_2.0.ssb16l.zip
When I press Alt-F5, the screen blinks for a while, and that's it.
My intuition: I missed something evident.


EDIT: A year and a day have passed, and I figured what the problem was.
It turned out it has nothing to do with REACT/EAC. It's rather the ATI control panel that hijacks Alt-F5 for "switch the monitors" command. As soon as I switched it to alt-f7 the React mod works as it should.

REACT 2 Released

Reply #866 –
I haven't run into this myself.. Does this happen with other releases, or just the l?
When you reinstalled, did you clear the previous react installation? maybe some conflicting files?

REACT 2 Released

Reply #867 –
I'm trying to save my flac files to a folder on a network (or, actually, a shared network folder under Parallels). My .ini file reads as follows:

[UserOutputNames]
ImageDir_Flac=@Z:\Music@\Flac\$cdartist$\$album$ ($year$)

I'm getting a error however. I assume it has something to do with the "@" sign. The full network path is

Z:\Music\Flac (the path I see in windows explorer)

or

\\.PSF\.Home\Music\Flac (the path I see if I click on my "parallels shared folder" shortcut on my desktop.

REACT 2 Released

Reply #868 –
@dakoet-
You only use @...@ when you are using a variable name. Your INI lines should read:
Code: [Select]
[UserOutputNames]
ImageDir_Flac=Z:\Music\Flac\$cdartist$\$album$ ($year$)


An example of when you use @...@:
Code: [Select]
[UserOutputNames]
RootFolder=G:\MEDIA\CDDA_ARCHIVE
OutRoot=@RootFolder@\$genre$\$cdartist$\$album$ [$year$]
OutRoot_sndtrk=@RootFolder@\Soundtrack\$album$ [$year$, $cdartist$]

I only use @...@ to call the variable RootFolder.

Off Topic: Is "call" the right term?
OP can't edit initial post when a solution is determined  :'-(

REACT 2 Released

Reply #869 –
Quote from: SamHain86 on
@dakoet-
You only use @...@ when you are using a variable name. Your INI lines should read:
Code: [Select]
[UserOutputNames]
ImageDir_Flac=Z:\Music\Flac\$cdartist$\$album$ ($year$)


Thanks! That did the trick 

REACT 2 Released

Reply #870 –
@Dakoet-

Just another tip: you ought to use [] instead of () in your directory hierarchy. I think there is a discussion and it was explained that () is treated as a part of code instead as a text variable... Not too sure what was actually up, but I use [] and haven't had any problems related to that.

Sorry, please ignore this. I couldn't find the posts related to what I was describing.
OP can't edit initial post when a solution is determined  :'-(

REACT 2 Released

Reply #871 –
Hello! It's time for more REACT questions! Answer Riddles, Win fabulous prizes!

1) Why does the ACDIR track split section of images.cfg have its own ini settings? ($n $~t [$~a]) -- My take is that these are used internally by ACDIR and not replaced by REACT. Do they offer some significant benefit over using something like $track$ - $title$ [$artist$]?

2) Does TAK not support ReplayGain? Is there a reason TAK RG is absent from the tracks.cfg in ssb16l?

3) What does the DebugMode setting in the .ini do? Why's it separate from the regular 'Debug' setting?

REACT 2 Released

Reply #872 –
Hi,

Thanks SS for all you work on this REACT mod.

Possible mismatch between REACT_2.0.ssb16l, metamp3v0.91 and Latest beta: metamp3v092b5 if using additional meta tag DISCNAME with DISCNUMBER and TOTALDISCS:
[Current]
discnumber=4
totaldiscs=6
discname=CD4 name test

Using REACT_2.0.ssb16l with metamp3v0.91 No MP3 tags are written:
error: --frame: bad argument: TXXX[setsubtitle]:CD4

If DISCNAME is not used, but only TOTALDISCS and DISCNAME are specified - MP3 tags written O.K.

Using REACT_2.0.ssb16l with metamp3v092b5 WITH album art get:
An unrecognized option: --pict
Using REACT_2.0.ssb16l with metamp3v092b5 WITHOUT any album art get:
An unrecognized option: --user-text

As documented, the metamp3v092b5 command line options have changed, and are not backward compatible.

Possible tested workaround using metamp3v0.91 is to change the "SET Disc_MP3=--frame "TXXX[setsubtitle]:@discname@" to SET Disc_MP3=--frame "TIT3:@discname@" in REACT-track.cfg

Regards,
Pete

REACT 2 Released

Reply #873 –
Hi shinyspoon

I would myself stick to using the newest metamp3 beta and then change the following in the track-cfg :
Code: [Select]
IF NOT @LameMP3@==1 GOTO end_lame_tracks
[...]  
IF @various@==1 SET VA_tag=--user-text "[album artist]@VA@" --frame "TPE2:@VA@"

Into :
Code: [Select]
IF NOT @LameMP3@==1 GOTO end_lame_tracks
[...]
IF @various@==1 SET VA_tag=--frame "TXXX[album artist]:@VA@"

The above is best for foobar2000. If you e.g. use winamp or wmp, then instead use :
Code: [Select]
IF NOT @LameMP3@==1 GOTO end_lame_tracks
[...]
IF @various@==1 SET VA_tag=--frame "TPE2:@VA@"


Of course you could also leave both of them in, but i just don't like that myself, but just in case, then here's the syntax for that :
Code: [Select]
IF NOT @LameMP3@==1 GOTO end_lame_tracks
[...]
IF @various@==1 SET VA_tag=--frame "TXXX[album artist]:@VA@" --frame "TPE2:@VA@"


Then also change the following line from :
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--pict "{3}@cover@"

Into :
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--frame "APIC{3}:@cover@"

REACT 2 Released

Reply #874 –
Sorry for the late response, I got so frustrated myself that I had to take a long break.

"RunCoverDownloader" setting works now perfectly.

Log filename problem in track mode still exist, cover & cuefiles are working fine now.
Related to problem I reported a while ago(?); wrong numtracks when CD with DATA track (If $hasCue Or $g_track = $g_numtracks Then) in line #925.
Code: [Select]
Album & Artist = te'stin"g
- Track mode: logfile = te'stin g - te'stin g.log ... Batch var = te'stin'g - te'stin'g.log
- Image mode: logfile = te'stin'g - { 2004 } te'stin'g.log ... Batch var = te'stin'g - { 2004 } te'stin'g.log
(Tested with CD which had a DATA track ... stripped folder paths)

Tested A LOT the cuefile problem I had and I can't trust the cuefile generation at all; the problem is most probably a combination of cd-drive which has problems to read certain "difficult" CDs / EAC gap detection / REACT way of creating cuefiles (timing(?) &/ not stopping when some cuefiles are not created).
- Fixes/mods which I found that lowered problematic cases:
 1. Stop extraction when cuefile is not found and give warning message.
 2. Use "WinMenuSelectItem($g_eacTitle, $g_eacText, "&Action", "&Detect Gaps")" (also wait "Analyzing" window close) before calling "ControlSend()" functions to create different cuefiles.
- Here's my test notes (if somebody is interested) in codebox to minimize the post size:
Code: [Select]
- Timing issue? Analyzing window takes its time (sometimes fast, sometimes slow) REACT doesn't wait properly but instead tries constantly to "access" cuesheets??? Sometimes REACT hits correctly but sometimes not???? Too fast cuefiles creation and then move and next cuefile creation... and so on.. maybe needs little pauses?

- So, if the gap analyzing has been done, it seems that everything works fine. It's just the first rip which is problematic (sometimes!) when EAC/REACT is started. Any following rips seems to produce proper cuesheets (not closing EAC), EVEN if the first rip produced bad cuefiles. Tested with EAC "Gap Detection->Detection Accuracy" setting set to "Secure" (extracts the index several times) or "Inaccurate", no difference. Lots of "it seems". Pretty vague.

- One possible factor: cd-drive which has problems to read certain difficult CDs?! This one particular CD I'm testing gives sometimes "Detection mode not possible with this drive" error messages, and almost every time the only solution is to eject & insert it again and then try again. Sometimes some cuefiles are not created and there's NO error messages from EAC?!

- Hmm, when I start EAC/REACT and choose "Detect Gaps" manually from the menu AND after analyzing has stopped, I press F4; it seems that cuefiles are created properly everytime. Also using these steps, the gap column values in EAC window change from "Unknown" to numerical values. They don't change if I just start EAC/REACT and press F4. Maybe here's a clue how to nail this "twilight zone" phenomenon?

- All current problems were tested with A-gap setting, it works only after the first rip (which fails everytime). NOW trying B-setting: DOESN'T WORK AT ALL. What about the last one? C-setting: SEEMS TO WORK OK!? EVEN WITH ORIGINAL k-version. UPDATE ON C-setting: doesn't work; almost everytime the first cuefile (S) is NOT created but instead the second cuefile (MG) contains S-cuefile data.. M & MC are fine.

- OK, now it gets even more stranger; just witnessed cuefiles with additional pregaps & index 00's after over 200 tests with consistent cuefile contents! And this with the same CD I'm using in testing. Time to quit and give up.

- I made a difficult decision: I'm going to wait that EAC gets updated with char conversion & other requested features/fixes and use my own pre-processing batch file (or "real" program made with AutoIt or Visual Basic) for covers and other small things. I've wasted so much time and nerves testing, solving problems, reading & modifying source & cfg files that it's hard to walk away now, but I got to. Thanks a million to everyone who helped me. For those who rock (and you lot just rock), I salute you!  I'm going to watch this thread for a while if you have any questions for me. Otherwise, I'm done here. May you all have a happy and long future ahead with REACT and everything else. Peace Love & Understanding. Bye.