Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1281377 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

REACT 2 Released

Reply #350 –
@Synthetic Soul: Thanks for working and supporting REACT. I have been very silent in this thread - sorry. Please release the new version, including source code. I am slowly working on a new version, but it's not a major upgrade. If you have the new GUI code fairly separated from the rest (in functions), it should be easy for me to integrate it in my code later.

REACT 2 Released

Reply #351 –
OK tycho, will do.

Where possible I have functionalised all new code and put it in a new au3 file which is in turn included by REACT.au3.  I have then had to amend REACT.au3 just to add calls to those functions where relevant.

I'll make sure that it's all in a good state and upload later on.

Thanks again.

Edit: Ah, I just remembered a key point.  I have utilised the new regular expression functionality in the latest version of AutoIt, so it will not compile with earlier versions.  I'm using the stable 3.2.2.0.  Not sure if this is an issue with you.

FYI: The system utilises it's own INI file (metadata.ini) in the REACT directory, to achieve persistence.  The INI has two sections: "Default" sets the default token/value pairs available upon initialisation (which also occurs when a new disc is inserted, or drive changed) while "Current" stores the active token/value pairs for the current run.  The INI is created if not present, and neither the REACT.ini or CFG files are touched.
I'm on a horse.

REACT 2 Released

Reply #352 –
OK, REACT_2.0.ssb5.zip has been uploaded.

The zip contains the EXE, a readme, the original source and icon, and the new source files.

The readme is a hastily-put-together document describing the new functionality.

A few points:
  • The Additional Meta Data dialogue is non-modal, but does stay on top of all windows.  My preference would be to act as it currently does, but stay on top of EAC only; however I don't think I can do this.
  • The dialogue will revert to the default values any time the EAC window title changes - which should be on disc or drive change.  I did this as I saw little point in retaining, e.g., discname=Jupiter, if the disc has changed.  It's possible this may confuse or annoy people.
  • I hadn't finished messing around with the cuesheets.  Currently these (non-empty) token/value combinations will be added to the cuesheet when an image is ripped; however track cuesheets are currently not processed.
  • All feedback and suggestions for improvements and additions welcome.
  • Enjoy!
Edit: And remember: running this new version (2.0.ssb5) will result in your REACT.ini file being rewritten!  Either amend the first line to "Version=2.0.ssb5" in your ini, or make a backup!
I'm on a horse.

REACT 2 Released

Reply #353 –
Quote from: Synthetic Soul on
The Additional Meta Data dialogue is non-modal, but does stay on top of all windows.  My preference would be to act as it currently does, but stay on top of EAC only; however I don't think I can do this.
I'm really pleased to say that I have resolved this.  I can't  believe that it was such an easy fix  - I'm kicking myself.  The  dialogue now stays on top of the EAC window, but not other windows (it is a child of the EAC window).

I have also made the dialogue disabled as soon as ripping begins, and re-enabled when ripping finishes, to save any confusion.

Source-wise, to save confusion, I have renamed the functions to begin "fDiag..." rather than "fGUI...", as that prefix has already been used by the main source when referring to the main window.

REACT 2.0.ssb6

Quote from: Synthetic Soul on
The dialogue will revert to the default values any time the EAC window title changes - which should be on disc or drive change. I did this as I saw little point in retaining, e.g., discname=Jupiter, if the disc has changed. It's possible this may confuse or annoy people.
I noticed another, unwanted, side of this tonight.  As the function looks for a change in the window title amending the CD Artist or CD Title will cause the dialogue to reset.  With this in mind the basic idea is to just deal with the dialogue as the last step, after you have ensured that the main meta data is correct.

As I say, and depending on what Tycho chooses to do with this, if you give this a try maybe you'll come up with a better way for the dialogue to work.  It needs some proper user testing to come up with the optimum resolve for the majority... personally, as it stands, I intend to just remember to work with the dialogue as the last step before hitting F10 - once the main dialogu is "stable" (disc inserted, freedb data down and checked).
I'm on a horse.

REACT 2 Released

Reply #355 –
If anyone is testing my REACT mod, 2.0.ssb6, they may want to read the wiki article REACT:Adding Support For Disc Information.  I've gotten around to updating my config files to use the @discname@, @discnumber@ and @totaldiscs@ tokens provided by 2.0.ssb6 to set folder paths and tags.  I thought I may as well document the changes, so here they are.

@Tycho

Given the underwhelming response to 2.0.ssb6 I wonder whether it is worth your time integrating my changes into your core release.  I am happy to maintain a mod for those that want it... if we can agree on a sensible version string, or something...
I'm on a horse.

REACT 2 Released

Reply #356 –
Quote from: steve3386 on
3) How do I get ReplayGain track values written into the MP3 files? I want both the album and track gain values written to the MP3 files, but without applying the gain to the files (no scaling).


I would like to know about this also.

How can this be done?

REACT 2 Released

Reply #357 –
This really isn't my field, but as no-one else is answering...

I believe that you simply need to rip to an image (even though you want MP3 tracks), and amend yor INI so:

Code: [Select]
ImageExt=wav
...
LameMP3=1
...
ReplayGain=1
ApplyAlbumGain=0
...
UseWaveGainAG=1

This should create a WAVE image from which WaveGain can calculate album gain.  It will then split that into track MP3s, write the RG tags, and eventually delete the WAVE image file.
I'm on a horse.

REACT 2 Released

Reply #358 –
Yeah, that writes the album RG to each track but not the track RG.

I've tried adding "--replaygain-accurate" to my "Opt_LameMP3=" line but it won't write the track RGs for some reason.

Or maybe it does and metamp3.exe erases them when it updates the files?

REACT 2 Released

Reply #359 –
Again, not my field, but I think the RG tags that LAME writes are not compatible with "normal" RG tags anyway.

I'll try to have a think about the track gain.

I don't use it generally, certainly not through REACT, so I'm not really up on it I'm afraid.
I'm on a horse.

REACT 2 Released

Reply #360 –
OK, inputs are noted. To tag both AG and TG but not apply them, you must set

ReplayGain=1
ApplyAlbumGain=0
UseWaveGainAG=0  ; when 1, it computes AG scale value to apply on lame while encoding. 

I will rethink how to organise the RG options in future releases.

REACT 2 Released

Reply #361 –
I need 'big-up' the above, since I pushed for its development (and did diddly-squat else).

Eac can only add ARTIST, ALBUM and TRACKNAME.
What about Two Disc albums?  You could put (disc2) in the name, then you need to adjust the tags to get foobar to list the two discs together
Wouldn't it be great if you could tell REACT the DISCNUMBER, TOTALDISCS and maybe add a tag for the type (Single, Album, Live etc)
Synthetic Soul's Mod allows you to do just this by creating REACT variables that you can add to your REACT config.  The possibilities are endless (well, maybe not endless and I think I might have borrowed that slogan and....ahem)

REACT 2 Released

Reply #362 –
 Thank lipidicman!

I must admit that I am slightly bemused by the lack of interest... but if the two of us find it useful then that's something.  It was an interesting project to undertake regardless - I needed to get it out of my system.

I will reiterate that I see no point in merging this with the core REACT dist until a lot more people show interest!

With that in mind, I suppose the following question is moot, but, meh:

What additional tokens/tags/meta data do people think would be useful to submit from EAC?

My mod has DISCNUMBER, TOTALDISCS and DISCNAME by default, and I'm finding them useful.  I have amended my conf to add disc-related tags, and to use a "Artist\Album\Disc" folder structure where relevant.  I previously had to do this manually, and only bothered with the MP3s, not the WavPack images, so it's saving me time and hassle.

I did consider including ALBUM SUBTITLE in the defaults, but they so infrequently have one; I may adapt my config to be able to cope with one though, in the unlikely event.  I know lipidicman was talking of using a DISCTYPE token, which could process discs differently, according to whether they were albums, singles, EPs, etc.

I just wondered whether anyone else could see a really useful addition to the tokens, out of curiosity.  Bear in mind that the token value can be yes/no, a number, or a string, and you can even set a token for an individual track (I have used the example "@composer@" previously)...
I'm on a horse.

REACT 2 Released

Reply #363 –
The users who would really benefit (as already recognised by the 'COMPOSER' idea) are Classical fans.

I am leaving my classical albums until I find a decent guide.  Tagging these properly seems like a minefield

REACT 2 Released

Reply #364 –
Quote from: lipidicman on
The users who would really benefit (as already recognised by the 'COMPOSER' idea) are Classical fans.

I am leaving my classical albums until I find a decent guide.  Tagging these properly seems like a minefield
True on all accounts.

NB: I have now uploaded beta 9.  Here's the revamped readme.

Changes:
  • Moved default values into REACT.INI as I figured the user should only have to deal with one INI file.  On first run it will create the new section "[DefaultMetaData]".
  • Fixed the code that writes track-level meta data to the cuesheet (image- and track-level).
  •   Track cuesheets are now supported.
  • Current token values are now stored in "meta.ini", not "metadata.ini".
  • Moved a little more code from the main source file into the include.
Remember to set Version to 2.0.ssb9 in your REACT INI before running, if you don't want to lose the contents.

Edit: Updated to beta 9  - track cuesheets now supported.
I'm on a horse.

REACT 2 Released

Reply #365 –
I am having trouble with CoverDownloader and REACT2. I want to be able to select a folder.jpg from an existing folder on my hard disc rather than go out to the web. Is this possible. If not can I disable it altogether in REACT2.
If I do this is there a tool that I can use later on to batch add albumart to flac and mp3 tracks and a flac image.

Rgds
G

REACT 2 Released

Reply #366 –
You can disable it by setting RunCoverDownloader=0 in your REACT.ini file.

To use existing artwork you would need to amend your config to stop relying on CoverDownloader and to point to the existing image.  Edit: Actually, if you put the cover in the working directory, with the same name as the EAC log (album name, with illegal chars replaced with spaces), it would work as is (still setting RunCoverDownloader to 0).

How are your existing covers filed?
I'm on a horse.

REACT 2 Released

Reply #367 –
I want to try your mod on my main ripping machine (been trialling it on my laptop till now)
Can I just copy my REACT directory apply it there and run it without affecting my tweaked setup?  I think this will work but wanted to check.

REACT 2 Released

Reply #368 –
The only issue I can see is a potential difference in paths used in your REACT ini ([UserOutputNames] section).

As for the mod, it won't be affected.

To confirm my understanding: if you copy REACT.ini, REACT.exe, REACT-image.cfg and REACT-track.cfg from your laptop to the PC then the INI will remain as it is, REACT will still be modded, and everything should run as it did on the laptop.
I'm on a horse.
 

REACT 2 Released

Reply #369 –
Quote from: Synthetic Soul on
How are your existing covers filed?

Hi, thanks for the info.
All my images are stored in a single folder in the following format  "Artist - Album Title". I have used a program called Catraxx to catalog my music collection for the last 10 years or so and having all the cover art in a single folder was the best way to organise things. Now I want to embark on ripping my entire collection but using the coverart I already have becuase (a) they are all the same size and (b) they are all good quality.

Are you saying that if I copy all the images to my working directory (which one is this?) it will pick them up automatically. When I rip to image I use the format "artist - year - album title"; for tracks it is "artist - album title - trackno - tracktitle"

G

REACT 2 Released

Reply #370 –
Quote from: gsa999 on
All my images are stored in a single folder in the following format  "Artist - Album Title".
...
Are you saying that if I copy all the images to my working directory (which one is this?) it will pick them up automatically. When I rip to image I use the format "artist - year - album title"; for tracks it is "artist - album title - trackno - tracktitle"
REACT looks for an image with the same name as the EAC log, which is the album name with all illegal characters replaced with spaces.  Your naming scheme is irrelevant.

I see two options:
  • You create a script to rename all your images using REACT's format (as described above).  You put all the images in the working folder, and off you go.
  • You amend your config to look for the images where they reside, using their existing naming scheme.  This wouldn't be too much of a problem, except that you need to make sure that REACT uses the same illegal character replacement scheme as you did when naming the images - which could actually be a problem.  That said, there should only be a few albums where that's an issue, so you could deal with those manually afterward.
I'm on a horse.

REACT 2 Released

Reply #371 –
Quote from: Synthetic Soul on
I see two options:
  • You create a script to rename all your images using REACT's format (as described above).  You put all the images in the working folder, and off you go.
  • You amend your config to look for the images where they reside, using their existing naming scheme.  This wouldn't be too much of a problem, except that you need to make sure that REACT uses the same illegal character replacement scheme as you did when naming the images - which could actually be a problem.  That said, there should only be a few albums where that's an issue, so you could deal with those manually afterward.

Hi again.
I am not at all familiar with scripting and am not sure where to start with option 1. Option 2 looks a little more manageable to me. Could you give me an example of what I would need to put in the config file and whereabouts assuming my files are in folder "c:\my documents\catraxx\cover art\*.jpg" in the format "artist - album title"

Many thanks
G

REACT 2 Released

Reply #372 –
I don't have time to test this, but here's a start: From a previous post I am assuming that you are ripping to FLAC image with FLAC and MP3 tracks.

In your REACT.ini ensure the settings below:

Code: [Select]
[Settings]
...
ImageExt=flac
RunCoverDownloader=0
...
[UserTrackFormats]
Flac=1
Wavpack=0
LameMP3=1
NeroAac=0
iTunesAac=0
OggEnc2=0
...
[UserSettings]
...
EmbedCover=1
...

In your config (REACT-image.cfg), presuming it has not been edited previously, on line 49 you will see:

Code: [Select]
IF EXIST "@cover@" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
)

Change that code to:

Code: [Select]
SET cover = C:\My Documents\Catraxx\Cover Art\$cdartist$ - $album$.jpg
IF EXIST "%cover%" (
    SET have_cover=1
    SET embed_cover=@EmbedCover@
) ELSE (
    ECHO.
    ECHO WARNING: '%cover%' does not exist!
    ECHO.
)

Then, find and replace any instance of the text "@cover@" in the subsequent code with "%artist%". E.g. on line 108, change:

Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||@cover@"

... to:
Code: [Select]
IF %embed_cover%==1 SET Cover_tag=--picture="|image/jpeg|||%cover%"

Pay particular attention to lines 108, 150 and 180.
I'm on a horse.

REACT 2 Released

Reply #373 –
Another option for you - upgrade to the latest version of Albumart Downloader (find the thread in the Uploads forum).  It is version XUI 0.4.1; this is the continuation of the original CoverDownloader project.  In the options you can set a location for local files (you an then disable all the online searches).  The XUI version will accept the same parameters as the old CoverDownloader, so you just need to amend the path in your react.ini.

You need .NET 3 for this to work.

If you do it this way, you don't have to worry about editing all the stuff above, and naming issues shouldn't be a problem.

REACT 2 Released

Reply #374 –
Synthetic Soul and Wraithdu
Thanks for both of your tips on this  . I am going to have a go with both options over the weekend to see how I get on before going for one of them. I'll let you know which one I ended up with.

Just one thing re Synthetic Souls code. You say I should replace all instances of @cover@ with %artist% but the line 108 example replaces it with %cover%. I think the example is probably correct, but could you just confirm that please. Thanks