Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1362196 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

foo_discogs

Reply #326 –
Quote from: bubbleguuum on
Quote from: kcay on

http://www.discogs.com/release/95720 this causes a


I couldn't make it crash. Where you writing tags for the first time (what I tested) or updating (if so which tags) ?

Actually, hmm, I stripped the mp3s of tags, then made sure I reset foo_discogs default tagging options, and removed the 'auto match discogs tracks to local tracks' setting, and now it works!
It appears that by replying you somehow magically fixed the problem! 

foo_discogs

Reply #327 –
Spoke too soon: found another crash-causer!
Trying to tag http://www.discogs.com/release/946231 results in

Code: [Select]
Illegal operation:
Code: C0000005h, flags: 00000000h, address: 00033981h
Access violation, operation: read, address: FFFFFFFFh
Call path:
entry=>app_mainloop
This is the first crash logged by this instance.
Code bytes (00033981h):
00033941h:  F0 46 24 68 F6 1D 00 66 07 02 00 48 E0 80 7C B0
00033951h:  02 00 00 10 F9 1D 00 A8 02 00 00 14 39 03 00 A8
00033961h:  9A 83 7C 04 3A 03 00 A8 9A 83 7C 78 E3 80 7C FF
00033971h:  FF FF FF DC E3 80 7C 00 00 15 00 38 E0 80 7C 40
00033981h:  07 02 00 00 00 00 00 00 00 00 00 F0 CA 38 00 11
00033991h:  57 01 00 44 3A 5C 74 6F 6F 6C 73 5C 66 6F 6F 62
000339A1h:  61 72 32 30 30 30 5C 66 6F 6F 62 61 72 32 30 30
000339B1h:  30 2E 65 78 65 00 7C 00 00 15 00 00 00 00 00 F6
Stack (00033900h):
000338E0h:  00000000 0012F8A4 0012F87C 00000000
000338F0h:  92412B28 00000001 804DA3EE 92412B60
00033900h:  00383432 00033980 00000001 00033AAC
00033910h:  000339A8 00000000 003828E3 00033934
00033920h:  00033980 00001404 00E3F688 0E6FFFF8
00033930h:  00000000 7FFDF000 7FFDF000 7FFDF000
00033940h:  2446F008 001DF668 00020766 7C80E048
00033950h:  000002B0 001DF910 000002A8 00033914
00033960h:  7C839AA8 00033A04 7C839AA8 7C80E378
00033970h:  FFFFFFFF 7C80E3DC 00150000 7C80E038
00033980h:  00020740 00000000 00000000 0038CAF0
00033990h:  00015711 745C3A44 736C6F6F 6F6F665C
000339A0h:  32726162 5C303030 626F6F66 30327261
000339B0h:  652E3030 7C006578 00150000 00000000
000339C0h:  7C801BF6 00033B5C 0038CAF0 00000000
000339D0h:  02A802A6 001DF668 001A0018 7FFDFC00
000339E0h:  00000018 77DD2BE4 00033AB6 77DD16A4
000339F0h:  0000022F 00033A44 7C919BD3 00033AB6
00033A00h:  000002A3 77DD0000 77DD2158 77DD2BE4
00033A10h:  00000000 00000001 00033AB4 00000000
Registers:
EAX: 00000001, EBX: 00033980, ECX: 0038C8FC, EDX: 00036172
ESI: 00033980, EDI: 00033980, EBP: 0E710AA8, ESP: 00033900
(do you actually need the crash log to help fix foo_discogs bugs?)

[!--sizeo:1--][span style=\"font-size:8pt;line-height:100%\"][!--/sizeo--]Moderation: Wrapped the crashlog into a codebox.[/size]

foo_discogs

Reply #328 –
[edit]
nevermind... found my answers.

Still usin' and lovin' this component.
elevatorladylevitateme

foo_discogs

Reply #331 –
Hi bubbleguuum,

Firstly, thanks for a wonderful plugin! It's made such a difference being able to tag from discogs vs. the rubbish that you get from freedb.

I've just had problems recently with html parse errors on the following two releases: 204297 and 228716.

I hope you'll be able to help with these.

Thanks,
Will

foo_discogs

Reply #332 –
Quote from: Will Ellis on
Hi bubbleguuum,

Firstly, thanks for a wonderful plugin! It's made such a difference being able to tag from discogs vs. the rubbish that you get from freedb.

I've just had problems recently with html parse errors on the following two releases: 204297 and 228716.

I hope you'll be able to help with these.

Thanks,
Will



good spot, it is fake artists "Various" and "No Artist" that make the artist parser barf. Will have to filter those.
Also cause of the parse error on 336752.

In the mean time, for these pages disable every tag that parse artist pages: that would be artist id, artist members etc. Oh and also artist art.

foo_discogs

Reply #333 –
Quote from: bubbleguuum on
Quote from: stampgevaar on

http://www.discogs.com/release/336752

html parse error :S


Works here using 1.0 ! Try again? maybe discogs was down or sth


Still getting the error, when I click write tags it first searches for the artists information and then gives a dialog box with html parse error.

foo_discogs

Reply #334 –
How do you use this component?

I'm somewhat new to foobar.

I put it in my components folder but I don't know how to access it from within foobar.

foo_discogs

Reply #335 –
Quote from: BPinard on
How do you use this component?

I'm somewhat new to foobar.

I put it in my components folder but I don't know how to access it from within foobar.


select the songs you want to tag, right click and choose discogs and write tags and then just search for the release etc etc



oooh and bubblegum, if your planning on releasing a next version could you please seperate the update album/ artist art this because there's not always the need to also update the artist art.

And could you make it back possible to overwrite files when you just click update album /artist art (with a checkbox like it was in an older version). So I don't have to go to the configuration menu everytime. I am asking this because if you have a new release the first weeks there's always a very low resolution picture on discogs but after a month or so the picture is always updated to a higher quality so...

foo_discogs

Reply #336 –
Quote from: stampgevaar on
Still getting the error, when I click write tags it first searches for the artists information and then gives a dialog box with html parse error.


See the anwer I made to Will Ellis just above for a workaround


Quote
oooh and bubblegum, if your planning on releasing a next version could you please seperate the update album/ artist art this because there's not always the need to also update the artist art.

And could you make it back possible to overwrite files when you just click update album /artist art (with a checkbox like it was in an older version). So I don't have to go to the configuration menu everytime. I am asking this because if you have a new release the first weeks there's always a very low resolution picture on discogs but after a month or so the picture is always updated to a higher quality so...


No promise but I'll think about it as it make sense

foo_discogs

Reply #337 –
Speaking of album art - could you include an option to embed it to file tags? Would be of great help, seeing as of how iTunes is programmed so users can't configure. =_=; And Foo_Dop is a great plug-in, but it seems to mess up my ipod at times.

But many thank for such a marvelous plug-in! =D

foo_discogs

Reply #338 –
my foobar crashes when i try to tag this release: http://www.discogs.com/release/891416

this was my first crash with foo_discogs after using it for a long time. keep it up the good work

foo_discogs

Reply #339 –
hi, just noticed something - when I download my artist art images - they download fine to a folder I have created - but the files themselves are names exactly what they are called on the discogs page and not by the artist name.

How can I change this because I notice the options say no %TAGZ% supported for artist art... any suggestions...

foo_discogs

Reply #340 –
Quote from: 4nt1 on
hi, just noticed something - when I download my artist art images - they download fine to a folder I have created - but the files themselves are names exactly what they are called on the discogs page and not by the artist name.

How can I change this because I notice the options say no %TAGZ% supported for artist art... any suggestions...


For artist art I chose not to include tagz in the naming of the files because there was some annoying corner cases to cover. For example, what you do if two artists have the same name ? There's also the pain in the ass of special characters that are not valid in filenames.
That's why I chose to name files using Artist Id only, and that completely non ambiguous (and simple).
Now the code is available and if anyone want to hack on it, he's welcome!
 

foo_discogs

Reply #343 –
Quote from: locutus on
Quote from: Dave_Scream on

Quote from: bubbleguuum on

Now the code is available and if anyone want to hack on it, he's welcome!


we need you 


Go on with your work, please.
I love this tool. Only one major problem, everytime i want to tag a song from a album it takes the first song from the album to write the tag! My fault or a bug?


I'm not sure I understand your problem, can you redescribe it precisely step by step ?

Since a few days discogs offer a web API (yay). I'll probably rewrite the plugin in Java, use the web API and support fetching of notes and roles (remixer, featuring, etc), along with some enhancements.

foo_discogs

Reply #344 –
weeeehev!!!!!!

and about api  - i think it was all this time!

because when you click at "update release information"  some java scripts in page that opens  get all needed info from their server!!!
i tryed to learn how it works but it was time with null results)

well ... api = rulez... can u give the link?
------
i found it: http://www.discogs.com/forums/topic?topic_id=141878
very good)
probably this will give greater features. let's together to think at their possible use in combination with powerful functions of foobar.

foo_discogs

Reply #345 –
Quote from: bubbleguuum on
Quote from: locutus on

Quote from: Dave_Scream on

Quote from: bubbleguuum on

Now the code is available and if anyone want to hack on it, he's welcome!


we need you 


Go on with your work, please.
I love this tool. Only one major problem, everytime i want to tag a song from a album it takes the first song from the album to write the tag! My fault or a bug?


I'm not sure I understand your problem, can you redescribe it precisely step by step ?

Since a few days discogs offer a web API (yay). I'll probably rewrite the plugin in Java, use the web API and support fetching of notes and roles (remixer, featuring, etc), along with some enhancements.


OK, i wiill try to make it easy;)
When i took a single song and search it in discogs, i get one or more albums to select. Next select a album and look for the correct song from the album.
Now when i use this entry to tag the file, he doesn´t use this one. Instead of this it uses always the first song of the selected album to tag the file.
I tested it with different files, always the same result. Hope know it is clear what i mean.

foo_discogs

Reply #346 –
Quote from: locutus on
Quote from: bubbleguuum on

Quote from: locutus on

Quote from: Dave_Scream on

Quote from: bubbleguuum on

Now the code is available and if anyone want to hack on it, he's welcome!


we need you 


Go on with your work, please.
I love this tool. Only one major problem, everytime i want to tag a song from a album it takes the first song from the album to write the tag! My fault or a bug?


I'm not sure I understand your problem, can you redescribe it precisely step by step ?

Since a few days discogs offer a web API (yay). I'll probably rewrite the plugin in Java, use the web API and support fetching of notes and roles (remixer, featuring, etc), along with some enhancements.


OK, i wiill try to make it easy;)
When i took a single song and search it in discogs, i get one or more albums to select. Next select a album and look for the correct song from the album.
Now when i use this entry to tag the file, he doesn´t use this one. Instead of this it uses always the first song of the selected album to tag the file.
I tested it with different files, always the same result. Hope know it is clear what i mean.


Checked it again. If i use the "move up" feature, when i selected the right track out of a album and move it to the top of the album list, it works correctly.

foo_discogs

Reply #347 –
Feature Request:

I just love this plug-in! But there is one small thing annoying me. The "Move Up"-feature works great with few-tracks albums, but when there's more than 20 tracks for a single album(For instance http://www.discogs.com/release/329644), it's rea-hea-heally inconvenient. Is there any way to implant a "drag & drop"* or a "bring to selected file"** feature?

* = If possible, to drag a release track to its corresponding file and move it so that they match.

** = A button bringing the selected release track to the selected file.


EDIT:
I just noticed when trying to update album/artist art; after ending up with a parse error in the middle of a run, foo_discogs terminated rather than jumping past the release with the parse error.
(Small batch run on files both with/without Discogs information in tags; "Update only releases for which there is no art" unchecked.)

foo_discogs

Reply #348 –
feature request:

use new discogs-API in foo_discogs...

it uses clear XML without spare HTML tags and(!!!!)
it natively with GZIP supporting!!!
sooo

it will be very fast!!! even on slow connections... (like mine)

---
and some feature... wich will use

<Artist1>
<Artist2>
<Artist3>

in XML ... and will convert it to MULTIVALUED artist TAG...

foo_discogs

Reply #349 –
Quote from: locutus on
Quote from: locutus on

Quote from: bubbleguuum on

Quote from: locutus on

Quote from: Dave_Scream on

Quote from: bubbleguuum on

Now the code is available and if anyone want to hack on it, he's welcome!


we need you 


Go on with your work, please.
I love this tool. Only one major problem, everytime i want to tag a song from a album it takes the first song from the album to write the tag! My fault or a bug?


I'm not sure I understand your problem, can you redescribe it precisely step by step ?

Since a few days discogs offer a web API (yay). I'll probably rewrite the plugin in Java, use the web API and support fetching of notes and roles (remixer, featuring, etc), along with some enhancements.


OK, i wiill try to make it easy;)
When i took a single song and search it in discogs, i get one or more albums to select. Next select a album and look for the correct song from the album.
Now when i use this entry to tag the file, he doesn´t use this one. Instead of this it uses always the first song of the selected album to tag the file.
I tested it with different files, always the same result. Hope know it is clear what i mean.


Checked it again. If i use the "move up" feature, when i selected the right track out of a album and move it to the top of the album list, it works correctly.


No one else having this problem? I have just tested MP3Tag using discogs. Same problem!