Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Album Art Downloader XUI (Read 2054514 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Album Art Downloader XUI

Reply #175
Sorry if this has already been posted, but since I don't see it mentioned anywhere I noticed that Clamwin is reporting adware when I scan the installer of 0.12, is this a known issue?

No, not a known issue. I can assure you that I have not put any adware in it, if that's any help. I think it's a false positive with ClamWin, and have submitted it to them for analysis. Meanwhile, I've uploaded a repackaging of the installer (which also includes a minor uninstall bugfix) and ClamWin seems happy with it.

Thanks for reporting it,

Alex

Album Art Downloader XUI

Reply #176
I have run into a little problem with using album art downloader and foo run.  I have set up my run command to be. 
Code: [Select]
P:\Program Files '('x86')'\foobar2000\AlbumArtDownloaderXUI-0.12\AlbumArt.exe "%artist%" "%album%" "$replace(%path%,%filename_ext%,folder.jpg)"

The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.
Can you guess what the problem is?  For example a song with

album : Wishes In The Night "Part Two: Of Passion and Serenity"

When i run the script the Album Art Command Line Parameters window opens up and says
Quote
>"P:\Program Files (x86)\foobar2000\AlbumArtDownloaderXUI-0.12\AlbumArt.exe" "Nightwish" "Wishes In The Night "Part Two: Of Passion and Serenity"" "U:\Audiopholder\Metal, Rock, Alternative etc\__Metal\_Symphonic Power Metal\Nightwish\Of Passion and Serenity\folder.jpg"

Album Art Downloader XUI version 0.12.0.0

**** Only the first three parameters may be un-named ****


The problem is that albumart.exe thinks part of the album is a paremeter.

Any ideas on how I can solve this to make my albumart.exe handle these cases properly?

Album Art Downloader XUI

Reply #177
The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.

If parameters have " marks in them, then those marks must be escaped. I think this can be done by using $replace(%artist%,",\"), but someone with better titleformatting skills might be able to give you a better answer. In any case, you are looking to add a \ before every " in the artist and album.

Alex

Album Art Downloader XUI

Reply #178
Alex,

thank you very much for this wonderful utility... it's very useful and it's saved me countless hours. The integration with foobar through COM Automation is fantastic (I can't believe I just discovered it), but i have a couple of suggestions which would make it even better:

1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

2. Would it be possible for you to cache the results so that the next time the foobar browser is run, it doesn't recheck all the albums for which art exists?


Thanks again for this wonderful utility.

Album Art Downloader XUI

Reply #179
Alex,

thank you very much for this wonderful utility... it's very useful and it's saved me countless hours. The integration with foobar through COM Automation is fantastic (I can't believe I just discovered it), but i have a couple of suggestions which would make it even better:

1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

2. Would it be possible for you to cache the results so that the next time the foobar browser is run, it doesn't recheck all the albums for which art exists?


Thanks again for this wonderful utility.

Good suggestions. I'm not sure how well populated Album Artist is, but if I can get it in a way that will fall back to Artist if it isn't, it's probably safe to use that instead. I can't think of a good reason to prefer Artist over Album Artist if both are populated.

I'll look into caching, but it would probably not make a huge amount of difference if you have a strict image path format, as it would still have to check for the existence of the last known image file (to see if it had been moved or deleted since caching), and that would take just as long as checking for 'folder.jpg', for example. It would help a lot for fuzzy image path formats, like c:\art\unsorted\**\*.jpg, though...

Alex

Album Art Downloader XUI

Reply #180
The problem is that some of my songs are tagged with " " (quotation marks) in the title, artist or album tags.

If parameters have " marks in them, then those marks must be escaped. I think this can be done by using $replace(%artist%,",\"), but someone with better titleformatting skills might be able to give you a better answer. In any case, you are looking to add a \ before every " in the artist and album.

Alex


I have the same problem but with hyphen "-". Using the same trick it passes \- over too, any idea?

Album Art Downloader XUI

Reply #181
I have the same problem but with hyphen "-". Using the same trick it passes \- over too, any idea?

Hyphens should not need any escaping. Could you give me an example of a command line that fails, and I will look into it.

Alex

Album Art Downloader XUI

Reply #182


1. It'd be better if the utility checks "album artist" instead of artist. This will help prevent Various artist albums from appearing multiple times on the same list.

Good suggestions. I'm not sure how well populated Album Artist is, but if I can get it in a way that will fall back to Artist if it isn't, it's probably safe to use that instead. I can't think of a good reason to prefer Artist over Album Artist if both are populated.



Alex,

By default in titleformatting if %album artist% is not populated it will fall back to %artist%, so I would assume this will be no problem, and would be a useful enhancement.

Thanks for all your work on this component.

Album Art Downloader XUI

Reply #183
Here you are:
Code: [Select]
"D:\Program Files\AlbumArtDownloader\AlbumArt.exe" /artist "-zann-" /album "Samurai from East" /path "D:\Music\Game Music\01\_Touhou_related\-zann-\Samurai from East\front.jpg"


and your program gave this error "**** Unexpected command line parameter: zann- ****"

EDIT: It crashes with this command line
Code: [Select]
D:\Program Files\AlbumArtDownloader\AlbumArt.exe /artist "一青窈" /album "受け入れて" /path "***\front.jpg"
and here's the log in event log
Code: [Select]
EventType clr20r3, P1 albumart.exe, P2 0.12.0.0, P3 479cc933, P4 system, P5 2.0.0.0, P6 471ebf0d, P7 1be, P8 15, P9 system.argumentoutofrange, P10 NIL.

Well this is likely AmazonJPMultithread fault though as it doesn't crash when I disable it.

Album Art Downloader XUI

Reply #184

Thanks. I can confirm this bug as occurring with parameter values starting with a hyphen, or a /. Hyphens elsewhere are not a problem. I will fix this for the next release.

Album Art Downloader XUI

Reply #185
Is there a way to handle compilations with different track-artists?

IMO the file-browser should look first if album-artist is present, and if not, than take the artist.

BTW: Great application

 

Album Art Downloader XUI

Reply #186
Is there a way to handle compilations with different track-artists?

IMO the file-browser should look first if album-artist is present, and if not, than take the artist.

BTW: Great application


I don't think I tag any of my various artist albums to indicate that they are various artists.  I mainly use SlimServer against my music, and it manages to work out that all the tracks belong to one album.  I'm guessing it does this either by the fact that the album name is the same (could easily go wrong) or by the fact that the tracks all live in the same directory.  Could Album Art Downloader employ similar logic?

By the way, would it be possible to add a mode that ran simply from the directory structure, rather than the files within it?  I'm running across a wireless network, so the program is having to pull all my flac files across to examine their tags.  However, the information it needs is mainly in the directory structure.  For example:

Music
- CDs
- - The Beatles
- - - Revolver
- - - - 01.flac
- - - - 02.flac

From the above, you can deduce that I have Revolver by The Beatles without having to examine the flac files themselves.  The presence of flac files in a directory shows that it's an album.  There are obviously situations when the user would want you to look at the tags themselves, but this option would greatly speed things up for me at least, as well as opening up currently unsupported formats a bit.

Max

Album Art Downloader XUI

Reply #187
IMO the file-browser should look first if album-artist is present, and if not, than take the artist.
I've already got this on the list to look into. It seems certainly possible for the foobar browser, but it isn't looking likely for the file browser. There does not appear to be any standard Album Artist tag.

Would it be possible to add a mode that ran simply from the directory structure, rather than the files within it?
I've posted earlier about the possibility of adding a new browser which works on pattern matching the file paths rather than reading the tags from them. You would specify something like "%artist%\%album%\*.flac", for example. It gets trickier if you have paths which include other data, like the year. You might need "%artist%\(*) %album%\*.flac", for example. I'm really hoping not to have to extend it to regular expressions, hopefully wildcards would suffice.

It would be a fairly large piece of work, though, so I probably won't get round to it for a while - I'd rather get all the little things (like the album artist stuff, and hyphen parameter bug) sorted and released before considering a new feature like that.

Alex

Album Art Downloader XUI

Reply #188
AlbumArt Downloader XUI v0.13 Released

This release is mostly a bug-fixing update. The following issues have been fixed:
  • Changed foobar browser to use %album artist% instead of %artist%
  • Fixed bug with parameter values starting with -
  • Upgraded to MediaInfo version 0.7.5.9
  • Fixed rare GUI freezing bug
  • Fixed minor uninstaller bug (not removing aad.exe cached script file)
Download:
AlbumArtDownloaderXUI.exe (Installer. Recommended)
AlbumArtDownloaderXUI.zip (zip archive for those who don't like installers)
.NET Framework 3.5 (required)

Album Art Downloader XUI

Reply #189
Thanks for the great program Alex. The latest version and also the last few versions have been working beautifully. %AlbumArtist% organization is a nice change. That way it will not scatter for a multi-artist disc. I believe this is how the Folder.jpg is also saved in My Pictures, in Album Art\%AlbumArtist%\%Album% structure? 

In an attempt to show my appreciation of the program, I have added support in iTSfv to look for AAD saved artwork so iTunes/iTSfv users have another automatic artwork source for adding Artwork to iTunes.

5.40.1.0 iTSfv will look for artwork saved using Album Art Downloader

Code: [Select]
20080211T094900 Job Started: VALIDATE_TRACKS_SELECTED
20080211T095116 Found 1 sources of Artwork
20080211T095121 Artwork from [b]AAD[/b] as G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg with 1620x1579
20080211T095129 Choosing G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg as the best Artwork
20080211T095131 Added Artwork to D:\Music\Da Buzz\Greatest Hits\01 Alive.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095133 Added Artwork to D:\Music\Da Buzz\Greatest Hits\02 Take All My Love.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095135 Added Artwork to D:\Music\Da Buzz\Greatest Hits\03 Dangerous.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095136 Added Artwork to D:\Music\Da Buzz\Greatest Hits\04 Do You Want Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095138 Added Artwork to D:\Music\Da Buzz\Greatest Hits\05 Tonight (Is The Night).mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095139 Added Artwork to D:\Music\Da Buzz\Greatest Hits\06 Wonder Where You Are.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095141 Added Artwork to D:\Music\Da Buzz\Greatest Hits\07 Without Breaking.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095143 Added Artwork to D:\Music\Da Buzz\Greatest Hits\08 Last Goodbye.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095144 Added Artwork to D:\Music\Da Buzz\Greatest Hits\09 Wanna Be With Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095146 Added Artwork to D:\Music\Da Buzz\Greatest Hits\10 How Could You Leave Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095148 Added Artwork to D:\Music\Da Buzz\Greatest Hits\11 Paradise.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095149 Added Artwork to D:\Music\Da Buzz\Greatest Hits\12 Let Me Love You.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095151 Added Artwork to D:\Music\Da Buzz\Greatest Hits\13 Baby Listen To Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095152 Added Artwork to D:\Music\Da Buzz\Greatest Hits\14 Take A Chance.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095154 Added Artwork to D:\Music\Da Buzz\Greatest Hits\15 Don't You Ever Leave Me.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Added Artwork to D:\Music\Da Buzz\Greatest Hits\16 Da Buzz Club Mix.mp3 from G:\Users\McoreD\Pictures\Album Art\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Folder.jpg
20080211T095156 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Artwork.jpg
20080211T095157 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\AlbumArtSmall.jpg
20080211T095157 Saved Track Artwork as D:\Music\Da Buzz\Greatest Hits\Da Buzz - (2007) Greatest Hits.jpg
20080211T095157 Export Artwork Pass 2 Finished.
20080211T095158 .
20080211T095158 Log saved in G:\Users\McoreD\Documents\iTSfv\Logs\tracks-200802-artwork-added.txt
20080211T095158 Duration: 0 Hours 02 Minutes 58.025715 Seconds
20080211T095158 Cleaning Temporary Files... in G:\Users\McoreD\AppData\Roaming\iTSfv\
20080211T095159 Job Finished: VALIDATE_TRACKS_SELECTED

Keep up the great work!

Cheers,
McoreD

Album Art Downloader XUI

Reply #190
Hi Alex,



If AAD is supposed to work with fb2k, then why are you using "albumartist" instead of "album artist", which is a fb2k tag? Is there any chance of adding it, along with "date"? Thanks for all of your work on AAD, it is much appreciated.
Surf's Up!
"Columnated Ruins Domino"

Album Art Downloader XUI

Reply #191
Hi McoreD, thanks for your comments, and for adding support to your excellent iTSfv! I should point out that the  syntax for specifying where to save images to hasn't changed, though, it is still just %artist%, meaning the artist that was searched for in Album Art Downloader (which may or may not be an album artist, no distinction is made).

If AAD is supposed to work with fb2k, then why are you using "albumartist" instead of "album artist", which is a fb2k tag? Is there any chance of adding it, along with "date"? Thanks for all of your work on AAD, it is much appreciated.

I'm not. The foobar browser reads the result of titleformatting "%album artist%". Date is not read - what would you want it to do with it, just display it in a column in the browser?

Alex

Album Art Downloader XUI

Reply #192
the newst version 0.13 just refuses to start for me  (0.12 worked fine with same settings)

this error msg i get (but there are some localized strings in it so it will be probably hardly readable )

Code: [Select]
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: c:\Program Files\___mp3\foobar2000\albumart\errorlog.txt

App version: 0.13.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.IO.FileNotFoundException: Nelze načíst soubor nebo sestavení System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 nebo jeden z jejich závislých prvků. Systém nemůže nalézt uvedený soubor.
Název souboru: System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
  v AlbumArtDownloader.Arguments..ctor(String[] args, IEnumerable`1 valuedParameters)
  v AlbumArtDownloader.App.ProcessCommandArgs(String[] args)
  v AlbumArtDownloader.App.OnStartup(StartupEventArgs e)
  v System.Windows.Application.<.ctor>b__0(Object unused)
  v System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  v System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  v System.Windows.Threading.DispatcherOperation.InvokeImpl()
  v System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
  v System.Threading.ExecutionContext.runTryCode(Object userData)
  v System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
  v System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  v System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  v System.Windows.Threading.DispatcherOperation.Invoke()
  v System.Windows.Threading.Dispatcher.ProcessQueue()
  v System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  v MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  v MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  v System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
  v System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
  v System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
  v System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
  v MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  v MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  v System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  v System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
  v System.Windows.Threading.Dispatcher.Run()
  v System.Windows.Application.RunInternal(Window window)
  v System.Windows.Application.Run(Window window)
  v System.Windows.Application.Run()
  v AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
  v AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
  v AlbumArtDownloader.App.Main(String[] args)

WRN: Protokolování vazeb sestavení je VYPNUTO.
Chcete-li povolit protokolování chyb vazeb sestavení, nastavte hodnotu registru [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) na hodnotu 1.
Poznámka: Protokolování chyb vazeb sestavení ovlivňuje výkon systému.
Chcete-li tuto funkci vypnout, odeberte z registru hodnotu [HKLM\Software\Microsoft\Fusion!EnableLog].

ive tried windows update but there arent any .net updates i dont have... any help?

Album Art Downloader XUI

Reply #193
ive tried windows update but there arent any .net updates i dont have... any help?

This looks a lot like not having .net framework 3.5 installed - perhaps you have only 3.0? Try installing 3.5 from here.

Alex

Album Art Downloader XUI

Reply #194
This looks a lot like not having .net framework 3.5 installed - perhaps you have only 3.0? Try installing 3.5 from here.

Alex


thx for quick help. i was almost sure that i have .net 3.5 installed so i tried to reinstall it and now everything is working thx.
probably i smehow damaged it and didnt even know about it.

Album Art Downloader XUI

Reply #195
Hi Alex,

I discovered some unexpected behavior which you can easily fix.

I searched:

Artist: Raff
Album: Self Control / Running Away


The results are fine. I managed to find the artwork!

The folder path where the Folder.jpg is saved is however

Pictures\Album Art\Raff\Self Control\Running Away\Folder.jpg

Expected Output:

Pictures\Album Art\Raff\Self Control _ Running Away\Folder.jpg



So it seems to me the illegal characters in Album Name string are not replaced to File System friendly characters.

Double checked with another test:

---------------------------
Album Art Downloader
---------------------------
Could not save image 'G:\Users\McoreD\Pictures\Album Art\ABBA\Gold: Greatest Hits\Folder.jpg':

The given path's format is not supported.
---------------------------
OK 
---------------------------

Here is a function that you could use for the Album Name, (may be also for Artist Name) just prior to saving the Image to File System.

Code: [Select]
     public string mfGetLegalTextForDirectory(string txt)
{
    
     txt = txt.Replace("/", "_");
     txt = txt.Replace(":", "_");
     txt = txt.Replace("*", "_");
     txt = txt.Replace("?", "_");
     txt = txt.Replace(Strings.Chr(34), "_");
     txt = txt.Replace("<", "_");
     txt = txt.Replace(">", "_");
     txt = txt.Replace("|", "_");
    
     return txt;
    
}


iTunes replaces all the illegal characters to "_" so to maintain interoperability could you also please use underscore to replace illegal characters?

Thanks,
McoreD


Album Art Downloader XUI

Reply #197
illegal characters in Album Name string are not replaced to File System friendly characters.
<snip/>
iTunes replaces all the illegal characters to "_" so to maintain interoperability could you also please use underscore to replace illegal characters?

Yes. I'll do that this weekend.

Thanks,

Alex

Album Art Downloader XUI

Reply #198
I can't seem to figure out why after updating my album art, my previously working foo_run command doesn't seem to work:

"C:\Program Files '('x86')'\AlbumArtDownloader\AlbumArt.exe" /ar %artist%" /al "%album%" /p "$replace(%_path%,%_filename_ext%,)cover.'%extension%'"


Every time I do that the "Album Art download command parameters" pops up.

Album Art Downloader XUI

Reply #199
Hi Alex,

thanks for adding album artist support .

I have one question regarding COMServer: Can you use it to query the contents of a playlist in foobar (instead of querying the media library)? If this was possible, i could just have it query the contents of the "new albums" playlist and automatically get art for them.

If this is not possible (or is too much work to implement), please disregard the request.