Georgia-ReBORN - A Clean foobar2000 Theme

Topic: Georgia-ReBORN - A Clean foobar2000 Theme (Read 223054 times) previous topic - next topic

Andu and 2 Guests are viewing this topic.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #900 – 2024-11-28 23:17:46

Quote from: regor on 2024-11-28 22:26:59

JSplitter is not a floating window like foo flowin but a window within the same panel entirely controlled by JS, so I see no reason (except difficulty) to not use it as a layer for images... in fact that solves some current RAM problems you got with disc art animations, since it would split the RAM usage between 2 SMP instances. But respect your design choices.

I don't think we will ever see SMPx64 unless the dev contacts the ru dev to share the fork as is. And there is no much reason for that since we already have a SMPx64 version within JSplitter.

To tell you the truth, I am not sure how to handle this situation and I've spent so much time on this project people would not believe...
Let's be realistic, there is no future for SMP x86 and its current state.

I think if next year there is no further development for SMP I call it quits and stop development.
I'll release version RC3 soon and see how it goes next year, but I am pretty sure and think you have the similar thoughts!?
I am not the type to point fingers at someone but I think you also need to be realistic, time is precious after all...

P.S Also I can not switch and use JSplitter x64 because I am still dependent on this UI Hacks crap

It would help a lot if we had an UI Hacks user-component alternative in x64 with its fundamental UI Hacks features, then I would be happy again... It would also solve the memory issues in fb2k x86, users music collections are growing rapidly and occasionally I get memory issue reports.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #901 – 2024-11-29 08:46:34

I think the only thing you missed was the title bar? The menus bar can be removed on CUI, the panel size can be managed by JSplitter.

I think you should ask Peter or CUI dev to implement a setting to remove/auto-hide the window title bar. I would go farther and just ask to implement all UI hacks natively. Even the window size could be managed via CMD.

Quote

Let's be realistic, there is no future for SMP x86 and its current state.

I'm fine using JSplitter x64 though. I don't need anything more, and have zero interest on recreating VU meters and things like that in SMP... there are other components already doing that.

Therefore, while I continue using it myself, I will continue developing my scripts. I do them for myself anyway, I just share them in case someone finds them useful.

EDIT: also about the window title, I know there are multiple methods out there to hide it.
https://www.youtube.com/watch?v=KTChbqsRV0k
https://superuser.com/posts/1775135/revisions

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #902 – 2024-11-29 13:19:35

Quote from: regor on 2024-11-29 08:46:34

the panel size can be managed by JSplitter.

Do you have an example/sample?

I've just tried this JSplitter x64 component for the first time and removed UI Hacks.
When there is no UI Hacks, all of these are not working anymore:
- Player sizes
- Layout sizes
- Display resolution checks
- Display scaling

Plus the ugly top window caption bar is displayed.
That was just quick checks, didn't test all thorough but that is pretty important missing core features...

Quote from: regor on 2024-11-29 08:46:34

I think you should ask Peter or CUI dev to implement a setting to remove/auto-hide the window title bar.

Peter does not want that, it actually violates ( I do not understand whats the problem but whatever ) the fb2k license when removing the window title bar. He knows about UI Hacks and it is actually banned from this forum. Many SMP/JSP themes
are using it, so I think he and the mods are closing eyes and ignoring this, it is just not welcome to talk about it here...

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #903 – 2024-11-30 10:35:07

Quote from: TT on 2024-11-28 23:17:46

To tell you the truth, I am not sure how to handle this situation and I've spent so much time on this project people would not believe...
Let's be realistic, there is no future for SMP x86 and its current state.

I've spent a couple of days hacking away at it. Finished the entire conversion to x64. Still crashes (on close during GC). But I hope it is a start.

I started from the HEAD of the repo and also had to update SpiderMonkey to 115ESR because 102ESR refused to even configure. I'm putting together a patch or PR. Please be patient on that last part because it involves changes over hundreds of files across several repositories.

Putting this here since it appears to have the more active discussion on the current situation. So, I need some help. I'm not THE developer and have little idea of how the internals are put together. Not sure how to root cause the crash and what a good set of tests to use would be.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #904 – 2024-11-30 11:20:31

For reference, this dev managed to somehow build it with 102ESR (not that I would say that's preferable)
https://foobar2000.ru/forum/viewtopic.php?t=6378&start=420

There is also a crash on close
https://foobar2000.ru/forum/memberlist.php?mode=viewprofile&u=19600

marc gave some hints about it.

I have an account there, so I can ask the dev for help to somehow get a working repo without duplicating work (?)

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #905 – 2024-11-30 11:23:53

Quote from: TT on 2024-11-29 13:19:35

Peter does not want that, it actually violates ( I do not understand whats the problem but whatever ) the fb2k license when removing the window title bar. He knows about UI Hacks and it is actually banned from this forum. Many SMP/JSP themes
are using it, so I think he and the mods are closing eyes and ignoring this, it is just not welcome to talk about it here...

-TT

External programs may do the same as shown.

Quote

- Player sizes
- Layout sizes
- Display resolution checks
- Display scaling

I don't understand your reply TT. Obviously you can not use the old activeX and methods, you have to use the new ones as shown in the new component changelog. Anyway even some of those can also be covered with autohotkey, and since it allows to create a portable executable... you would not need anything more.

About display resolution/scaling, I don't think that has been ported. Just use Registry entries or other external software for that. Or we may ask for a new method for that, JSP has one for sure. I think you have to accept that UI hacks is gone at some point and look for other solutions which may not be obvious.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #906 – 2024-11-30 11:57:03

@oops,

wow that's a great surprise someone is willing to help!
Thank you so much for your effort, you're giving SMP theme developers hope again!

I'll try your SMP x64 version asap. I have tried the JSplitter x64 version and it seems its JS engine ESR102 is
more efficient. I guess the code optimization is better handled and improved compared to the old ESR68 engine.
So 115ESR is a nice bonus, thanks!

Also I didn't like the Autohotkey script hack regor proposed, it works, but it is bugged and an ugly hack.
I decided to install Visual Studio and trying to learn C++ writing user-components, it is so hard lol!
For now, I try to write a basic user-component to hide the window title bar, resize and move the window.

These are the core JS features:
Spoiler (click to show/hide)

And here is the full feature UI Hacks menu list:
Spoiler (click to show/hide)

TheQwertiest wanted to implement this directly into SMP.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #907 – 2024-11-30 12:19:16

Quote from: regor on 2024-11-30 11:23:53

External programs may do the same as shown.

Yes I know, I think Peter's reasoning was the UI Hacks was somehow reported as buggy in the past ( never had a crash in the past years! )
and he didn't want these reports on these forums or do extra work?
I am not sure how hiding and manipulating the window would violate fb2k license anyways, whatever...

Quote

I don't understand your reply TT. Obviously you can not use the old activeX and methods, you have to use the new ones as shown in the new component changelog. Anyway even some of those can also be covered with autohotkey, and since it allows to create a portable executable... you would not need anything more.

Yes, that is exactly what I was asking and looking for: in the component changelog, thanks for the info.

Quote

About display resolution/scaling, I don't think that has been ported. Just use Registry entries or other external software for that. Or we may ask for a new method for that, JSP has one for sure. I think you have to accept that UI hacks is gone at some point and look for other solutions which may not be obvious.

Actually I have implemented the display resolution check and display scaling, these are Georgia-ReBORN features.
I am achieving this with the UI Hacks window resize feature. It's also independent of DPI, just checking maximum achievable
screen resolutions on users displays. Based on the result, it will adjust its settings to HD, QHD or 4K.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #908 – 2024-11-30 22:28:38

Quote from: oops on 2024-11-30 10:35:07

Still crashes (on close during GC). But I hope it is a start.

I tested and switched the panel through Columns UI layout switcher ( from JSplitter x64 panel to your SMP x64 panel )
and got an immediate crash when it tries to reload, so it is not just during GC. The JSplitter does not have this issue.
Thanks for your effort though =)

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #909 – 2024-12-01 06:25:53

Quote from: TT on 2024-11-29 13:19:35

Do you have an example/sample?

I've just tried this JSplitter x64 component for the first time and removed UI Hacks.
When there is no UI Hacks, all of these are not working anymore:
- Player sizes
- Layout sizes
- Display resolution checks
- Display scaling

Although I don't understand the code, this is a good reference based on JSplitter64, https://github.com/dream7180/foobox-en

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #910 – 2024-12-01 08:39:53

Quote from: oops on 2024-11-30 10:35:07

I've spent a couple of days hacking away at it. Finished the entire conversion to x64. Still crashes (on close during GC). But I hope it is a start.

I started from the HEAD of the repo and also had to update SpiderMonkey to 115ESR because 102ESR refused to even configure. I'm putting together a patch or PR. Please be patient on that last part because it involves changes over hundreds of files across several repositories.

Putting this here since it appears to have the more active discussion on the current situation. So, I need some help. I'm not THE developer and have little idea of how the internals are put together. Not sure how to root cause the crash and what a good set of tests to use would be.

oops : people have been waiting for years for someone with the time and the chops to do a 64-bit conversion of SMP, now you come along after foo_vis_vumeter and BANG here it is!! Unbelievable. Thank you!

Why not create a new thread for it, "Spider Monkey Panel 64-bit", so the news is not "hidden" here? It would be easier to attract assistance, discussion, testing report submission, etc. Just a suggestion!

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #911 – 2024-12-01 09:42:32

@always.beta
Thanks for this info (foobox-en).

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #912 – 2024-12-02 10:48:10

Thanks for the info guys,

I am going the hard and better way and try to write user-components in x64 for UI Hacks and peakmeter bar dependencies.
Already have the real time monitoring of levels and peaks for the peakmeter bar, but I need to implement the COM interface
in the user-component and it's a pain in the ass.

@always.beta,
it would help a lot if you could ask ttsping ( ohyeah ) how to do that?
He has the COM interface implemented in his ESLyric component to be able to communicate user-component with JavaScript
via ActiveX, because I am using it in Georgia-ReBORN.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #913 – 2024-12-02 11:41:58

Quote from: TT on 2024-12-02 10:48:10

@always.beta,
it would help a lot if you could ask ttsping ( ohyeah ) how to do that?

If you can register a QQ account, I can add you as friends, which is the fastest and most direct way to communicate with ttsping. Or create an issue on the GitHub page of ESLyric for communication. ttsping rarely visits HA. I don't understand the code, and I spread the words in the middle, and the expression is not clear, and it is not direct.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #914 – 2024-12-03 23:53:39

Hi everyone, I recently switched to the new version of Fb2K (Georgia-REBORN) I used DARKONE before, since I am an old man and i don't understand english i need a couple of tips, how can i have in the background in the "tracklist the image of the artist/group instead of the wikipedia images of the artist/group i'm listening to? another thing in every folder/album of my music collection (about 500GB) i inserted the images: Front, Back, Disc.png and Artist in "details" i only see the images Front Back and Artist but i don't see the image Disc.png why? in Preferences>Display>Album art>Disc in Search Patterns i put Disc* but its Image is not displayed. Thanks @TT for Georgia-Reborn

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #915 – Today at 08:32

What does it mean? Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
include failed: ActiveXObject_Constructor failed: Invalid CLSID: VUMeter
File: gr-main-components.jsLine: 3614, Column: 38
Stack trace: PeakmeterBar@gr-main-components.js:3614:38 @gr-initialize.js:49:16
loadAsyncFile/</<@gr-async-loader.js:182:5

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #916 – Today at 08:38

Quote from: UMBY71 on Today at 08:32

What does it mean? Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
include failed: ActiveXObject_Constructor failed: Invalid CLSID: VUMeter
File: gr-main-components.jsLine: 3614, Column: 38
Stack trace: PeakmeterBar@gr-main-components.js:3614:38 @gr-initialize.js:49:16
loadAsyncFile/</<@gr-async-loader.js:182:5

Did you install a different VU Meter?

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #917 – Today at 10:37

@always.beta,

thanks for your offer and sorry for the late reply. I am pretty busy and focused with this COM interface stuff.
If I fail, I'll contact ttsping on his ESLyric Github then.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #918 – Today at 11:01

Quote from: UMBY71 on 2024-12-03 23:53:39

Hi everyone, I recently switched to the new version of Fb2K (Georgia-REBORN) I used DARKONE before, since I am an old man and i don't understand english i need a couple of tips, how can i have in the background in the "tracklist the image of the artist/group instead of the wikipedia images of the artist/group i'm listening to? another thing in every folder/album of my music collection (about 500GB) i inserted the images: Front, Back, Disc.png and Artist in "details" i only see the images Front Back and Artist but i don't see the image Disc.png why? in Preferences>Display>Album art>Disc in Search Patterns i put Disc* but its Image is not displayed. Thanks @TT for Georgia-Reborn

Hi @UMBY71,

are you talking about the new implemented background image feature that is in the DEV version?
This here:
Spoiler (click to show/hide)

If so, the image source for the "Artist" is the biography cache:

Code: [Select]

foobar2000\profile\cache\biography\biography-cache\art_img

The biography fetches the images from last.fm, AllMusic and Wikipedia.
In general, you do get the artist images and I am not sure what you mean.
If for a particular artist there are no images for last.fm, it tries the next source which is AllMusic and then Wikipedia.
You could try to delete the Wikipedia images for that particular artist and try to fetch again from the Biography panel.
Maybe it will download now images from the other sources, if not, you would need to manually replace them with your custom artist images.

The default filename for the disc art png images is cd.png, cd1.png, cd2.png etc. and vinyl.png, vinyl1.png, vinyl2.png etc.
You can change that to disc.png in your georgia-reborn-config.jsonc file:

Code: [Select]

foobar2000\profile\georgia-reborn\configs\georgia-reborn-config.jsonc

Open your config file in a text editor and go to section "discArtPaths" and then rename *cd to *disc
Save and restart foobar.

Also you should try the latest DEV version from here and replace your files:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

-TT

Notice