HydrogenAudio

Hosted Forums => foobar2000 => 3rd Party Plugins - (fb2k) => Topic started by: Dremora on 2009-03-23 03:31:49

Title: foo_musicbrainz
Post by: Dremora on 2009-03-23 03:31:49
Allows tagging files using data from MusicBrainz (http://musicbrainz.org/).

Features:

For the list of planned features, see issue tracker (https://github.com/Dremora/foo_musicbrainz/issues?milestone=&sort=created&direction=desc&labels=&state=open).

Any feedback or suggestions are appreciated!

Download foo_musicbrainz 0.3.1 (http://www.foobar2000.org/components/view/foo_musicbrainz) | Join Last.fm group (http://www.last.fm/group/foo_musicbrainz) | Get source on Github (https://github.com/Dremora/foo_musicbrainz)

(http://pics.dremora.com/foo_musicbrainz.png)

Note regarding TOC submission:
Submit new TOCs to MusicBrainz only if you know what you are doing. Use only full rips from trusted sources (so, most likely, the files should orignate from a CD of your own). Choose release wisely — if your version of an album doesn't exist, add a new one. That means, if you don't know the version, don't submit.
To submit TOC, select all tracks belonging to a single disc and choose “Tagging → Add TOC to MusicBrainz” from the context menu. This feature is available only for registered MusicBrainz users.

Version history
Code: [Select]
v0.3.1 (2015-12-07)
-------------------
* Fix ORIGINAL RELEASE DATE tag (thanks lvqcl for the build)

v0.3 (2012-06-24)
-----------------
* Fixed crash when metadata has different track count
* New tag: original release date

v0.3 beta 2 (2011-06-03)
------------------------
* NGS support;
* New tags: musicbraiz_releasegroupid, label, catalognumber, barcode, totaldiscs;
* Proxy support;
* Option to convert punctuation to ASCII;
* Open-sourced.

v0.2.1 (2011-05-21) (requires foobar2000 1.1 or newer)
------------------------------------------------------
* Added ability to submit new TOCs from the context menu;
* CDStubs are excluded from search;
* Preferences page is now using latest API;
* foo_musicbrainz has been added to the components repository, so from now on in can be updated automatically.

v0.2 (2009-04-10)
-----------------
* Added preferences page;
* Added ability to edit queries.

v0.1 (2009-03-23)
-----------------
* Initial release.
Title: foo_musicbrainz
Post by: wortels on 2009-03-23 04:29:29
I have been using Picard for a long time...integration with foobar is great...


EDIT: This is very good and simple...excellent job sir. My only suggestion would be to use proper message boxes instead of text boxes for messages like files have different musicbrainz tags...but that is a very very minor thing
Title: foo_musicbrainz
Post by: novembre on 2009-03-23 09:38:18
Interesting!  Thanks!
Title: foo_musicbrainz
Post by: smkk on 2009-03-23 09:58:19
Very nice. Thank you.
Title: foo_musicbrainz
Post by: qwertz on 2009-03-23 10:22:06
Looks very good, thank you. Though I had never heard of MusicBrainz, I just tried a few artists, which weren't on discogs and MusicBrainz had them in the database. Very nice.
Title: foo_musicbrainz
Post by: FavioD on 2009-03-23 10:42:52
this is so great, thanks a lot! hopefully this will replace picard.
Title: foo_musicbrainz
Post by: Andu on 2009-03-23 15:14:27
Would it be possible to add just the year to date? Having the full date prevents Kameleon from displaying the year :[
Title: foo_musicbrainz
Post by: Lucky Luciano on 2009-03-23 15:33:08
What do TOC and MBID mean?
Title: foo_musicbrainz
Post by: grimes on 2009-03-23 16:06:37
Nice plugin! Thanks.

Would it be possible to add just the year to date? Having the full date prevents Kameleon from displaying the year :[
+1
(1973 instead of 1973-12-20)

Another suggestion: Would be nice to tag more than one single album at once.
Title: foo_musicbrainz
Post by: anishbenji on 2009-03-23 16:24:59
Really useful plugin. I like the interface alot, nice and simple and clean. You might want to look at the discogs plugin for some ideas for further development.

For me, it would be nice if you could support custom tag mapping including not saving certain information as tags. For example, I like putting the full date in the %release date% tag and keeping the default date tag a four digit year value.

Anish
Title: foo_musicbrainz
Post by: unabatedshagie on 2009-03-23 16:59:33
Would it be possible to add just the year to date? Having the full date prevents Kameleon from displaying the year :[
If falstaff changed the date display code to
Code: [Select]
// ----> date (year) -1 

$ifequal($len($year(%date%)),4,
  $puts(nb1,$left($year(%date%),1))
  $puts(nb2,$left($right($year(%date%),3),1))
  $puts(nb3,$left($right($year(%date%),2),1))
  $puts(nb4,$right($year(%date%),1))
  $if(%el_is_collapsed%,
     $puts(digits.y,7)
  ,
     $puts(digits.y,7)
  )
it would solve all the issues.

I have asked a couple of times but as yet gotten no response.
Title: foo_musicbrainz
Post by: ExUser on 2009-03-23 17:34:14
Would it be possible to add just the year to date? Having the full date prevents Kameleon from displaying the year :[
This is Kameleon's problem, not foo_musicbrainz's. The format foo_musicbrainz is returning is the standard foobar2000 date format, and is superior to the 4-digit format. Fixing the longer version is as easy as "Format from Other Fields" using $left(%date%,4) in the Properties dialog.

Yet another reason to stick with the Default UI...
Title: foo_musicbrainz
Post by: Talion on 2009-03-23 17:36:50
Very nice, thank you!

The plugin seems to use slightly different tags than picard, e.g. MUSICBRAINZ_ALBUMID instead of MUSICBRAINZ_ALBUM_ID. Is this intentional? I'd prefer to keep it consistently.

Another suggestion: Would be nice to tag more than one single album at once.

+1

Title: foo_musicbrainz
Post by: ExUser on 2009-03-23 17:37:09
I have asked a couple of times but as yet gotten no response.
I just asked for you. This bug is making users want silly misfeatures.
Title: foo_musicbrainz
Post by: Falstaff on 2009-03-23 18:40:24
I have asked a couple of times but as yet gotten no response.
I just asked for you. This bug is making users want silly misfeatures.


my answer : http://www.hydrogenaudio.org/forums/index....st&p=623267 (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=69485&view=findpost&p=623267)

btw, not very complicated to change in K for those who can't live without a full date format.

Regards,
Title: foo_musicbrainz
Post by: hick on 2009-03-23 19:19:10
I use picard, but I use it starting with only the simple song information of the artist and song name, and it works fine for me that way.  It would be nice if this component would be able to do this as well, without requiring an album name or other information.  That's the main ability (for me anyhow) that's missing from other info grabbers as well, and the reason why I have been using picard to tag my songs.
Title: foo_musicbrainz
Post by: TehNomad on 2009-03-23 20:12:27
Great plugin, MB is easily my favorite database (it actually has classical music tagged in a standardized way for most releases!)

One suggestion I have is to make a custom search function, since a lot of the stuff I need to tag have no tags to start with or I have to sift around the site to find the right album.
Title: foo_musicbrainz
Post by: bubbleguuum on 2009-03-24 00:09:43
I couldn't get any result (using the 'by tags' method) on properly tagged files. It always return "No Release". Disabled the firewall just in case. Any idea ?
Title: foo_musicbrainz
Post by: d0ng on 2009-03-24 01:36:02
What do TOC and MBID mean?


Table of Contents and MusicBrainz IDentifiers
Title: foo_musicbrainz
Post by: wortels on 2009-03-24 02:01:01
Regarding the date thing, I would rather have the option of tagging as year only. There is an inconsistency across the musicbrainz database where some albums have year only and others have year-month-day. This leads to a lot of problems in mobile music players. Also can you keep the tag names same as Picard please.
Thanks
Title: foo_musicbrainz
Post by: shakey_snake on 2009-03-24 02:30:15
Thank you very much for this component, it is something foobar has been missing, IMO.

Also can you keep the tag names same as Picard please.
Thanks
Meh, Picard does some rather stupid things like creating nonstandard ID3 frames for an iTunes-like Band-as-Album-Artist. AFAIK, a foobar2000 component couldn't do this if it tried.

I'd say the best thing to do would be to keep the field names the same where reasonably possible.
Title: foo_musicbrainz
Post by: tehfuzz on 2009-03-24 02:44:12
Hey all, just registered here (and started using foobar a few days ago),

Something I noticed with this plugin, it's very temperamental in regards to finding artist/albums. I had a bunch of discs that were missing track numbers, but otherwise were correct tagged... or so I thought.

Turns out, if for example, you have "System Of A Down", musicbrainz has this as "System of a Down". It wouldn't find it with the "improper" title. Changing the capitalization allowed it to be found via musicbrainz. I would think capitalization would be something to easily overcome when searching.

Still, even with that, beat manually adding track numbers.
Title: foo_musicbrainz
Post by: ExUser on 2009-03-24 03:00:32
tehfuzz, I take it you've never noticed the Tools button on the Properties dialog? There's an option to Auto Track Number, which reasonably intelligently adds track numbers.
Title: foo_musicbrainz
Post by: tehfuzz on 2009-03-24 03:21:03
Well crap. So there is. Thanks.

This plugin was still useful some ones that needed some more help, but yeah, that would have made it a lot easier.
Title: foo_musicbrainz
Post by: Falstaff on 2009-03-24 10:14:37
I have asked a couple of times but as yet gotten no response.
I just asked for you. This bug is making users want silly misfeatures.


give a look to Kameleon v1.2.2 (just released) :

Change log :

1.2.2 :
- Bug fixed : sometimes playlist switcher left panel had bad refresh (very annoying) => no more now (btw no more reproduced with the fix)
- Bug fixed : buttons + / - to expand or collapse the playlist ativated too the 'Show now playing command' => removed
- YEAR display in the playlist header : now, long dates are accepted but it still display only the Year (it take by default the 4 digits on the left : 2005-07-24 => 2005)
- Tweaks
Title: foo_musicbrainz
Post by: Anas on 2009-03-26 11:08:00
I did know of muscibrainz before, but didn't use it and not that I am using it I must say, it's extremely useful. Thanks a lot.
I've got one request, though. It would be nice if I was able to have the musicbrainz album status and album type saved in a custom (ie user definable) field (I'm using release type for this purpose).
Title: foo_musicbrainz
Post by: Zarggg on 2009-03-26 16:39:19
Regarding the date thing, I would rather have the option of tagging as year only. There is an inconsistency across the musicbrainz database where some albums have year only and others have year-month-day. This leads to a lot of problems in mobile music players.


My thought on the matter is that the onus should be on the player, not the tagger. Since the date format lists the year first, it seems trivial for the player to read only the first four characters of the tag. iTunes actually does this (I tag/convert in Picard/Foobar then use iTunes to load my iPod.)

Edit: It's actually not an "inconsistency". In MusicBrainz, the year section is required, with the month and day optional.
Title: foo_musicbrainz
Post by: 2E7AH on 2009-04-03 08:31:13
i like musicbrainz way of tagging mainly because of it consistency in metadata formatting (style)
then i use my way of dealing with %album artist% tag which isn't mapped in this component (according it's display dialog) but nonetheless it's wiped out when i use this tagger
can this be changed?
Title: foo_musicbrainz
Post by: Andu on 2009-04-03 14:09:30
I like this plugin. It would be great if I could mark several albums and the plugin would find the information for each and update that info for every one. My library is rather extensive and it would take ages to do this for every album individually.

The discogs plugin can do something like that iirc.
Title: foo_musicbrainz
Post by: odyssey on 2009-04-03 14:35:22
I like this plugin. It would be great if I could mark several albums and the plugin would find the information for each and update that info for every one. My library is rather extensive and it would take ages to do this for every album individually.

OH YES!!!

The discogs plugin can do something like that iirc.

Umm.... I don't think so - If it does, please tell me how to. Even finding the correct album with foo_discogs is quite trivial
Title: foo_musicbrainz
Post by: Andu on 2009-04-03 15:10:45
You are right. Discogs can't do that. Only ReplayGain knows to identify albums by tags and then analyses them separately
Title: foo_musicbrainz
Post by: vogliadicane on 2009-04-04 12:14:26
I like this plugin. Would be nice if it would also show up at the Rip-Audio-CD dialog under 'Information lookup' 
(I also don´t find it under Prefs/Tools/Tagging...)
Title: foo_musicbrainz
Post by: odyssey on 2009-04-04 13:50:22
(I also don´t find it under Prefs/Tools/Tagging...)

I was annoyed a bit by this too... It really do belong in the Tagging group. Can you please fix that?
Title: foo_musicbrainz
Post by: foolver on 2009-04-04 16:47:05
it would be nice if we could choose the default values for date. aka not to put full release date, but only the year
Title: foo_musicbrainz
Post by: odyssey on 2009-04-04 19:13:47
All you people bitching about the full date, why don't you just create a masstagger script to cut anything but the first 4 digits? Then anyone who is unhappy about foobar2000 default date format can be satisfied...
Title: foo_musicbrainz
Post by: Anas on 2009-04-05 12:15:09
Or why not keep the additional data and just display only the first four digits? I really don't see the problem here and I like having the full release date.
Title: foo_musicbrainz
Post by: Nemphael on 2009-04-05 16:37:26
Musicbrainz's Picard has some scripting abilities, for instance to remove " (disc 2)" and set discnumber to "2". I suggest something like this, or alternatively, if possible, a way of automatically calling Masstagger scripts.
Title: foo_musicbrainz
Post by: vogliadicane on 2009-04-05 19:20:44
it would be nice if we could choose the default values for date. aka not to put full release date, but only the year


you can delete what you don´t want before writing tags. I really don´t see a problem here...
Title: foo_musicbrainz
Post by: Chaser on 2009-04-05 20:49:52
Thank you. The component works very nicely. I have one proposal: Add the option to add the information for a given Album-ID. What I did is, that I searched for that album on the musicbrainz-website and created a tag "MUSICBRAINZ_ALBUMID" by hand and then performed again the action "Get Tags from ....". That worked fine. But it took some time...

edit:
May be even do the following. If I want to tag "by Tag" and no matches were found display a list of all releases of the artist (if the artist-tag is present). This way the user could select the fitting release.
Title: foo_musicbrainz
Post by: Dremora on 2009-04-10 21:18:13
Thanks everybody for your feedback. I've implemented some of your suggestions, enjoy version 0.2!

P.S. As topic title is not editable, can a moderator remove version number from it?
Title: foo_musicbrainz
Post by: Anas on 2009-04-11 11:16:08
Thanks a lot for the update, Dremora. The new version works flawlessly and behaves just the way I wished for.
Title: foo_musicbrainz
Post by: Olaf on 2009-04-12 10:22:19
Thanks for this component and for the new version, it's working pretty good.

I just found a little bug in the context menu labels, it's really not important but well... Still worth fixing for the next release (see here (http://img407.imageshack.us/img407/8960/capturefte.png)).
Title: foo_musicbrainz
Post by: atzaus on 2009-04-12 10:34:01
Thanks for the update but I have one issue. For albums with multiple CDs Picard had the option to add (Disc 1) etc to the end of the album title but the only option with this component is disc number. Can you please add the other option as well. Picard uses the format
%album%[ '('Disc %discnumber%')'][, %discsubtitle%]
i.e.
The Greatest Album (Disc 1), Live Songs

Great Work!
Title: foo_musicbrainz
Post by: vogliadicane on 2009-04-16 17:54:07
Thanks for the update Dremora! I like the features in the preference page.

Is it possible to add a musicbrainz search also when opening/ripping a CD for the next version?
Title: foo_musicbrainz
Post by: Yirkha on 2009-04-16 17:58:25
Hint: [font= "Courier New"]info_lookup_handler[/font]
Title: foo_musicbrainz
Post by: Fractal_Mortality on 2009-04-17 17:09:17
Hey guys, in order to use the "Album ID" function, what value do we actually implement? I tried finding "Album IDs" on the musicbrainz site, but couldn't for the life of me.
Title: foo_musicbrainz
Post by: Dremora on 2009-04-18 07:47:47
In URL http://musicbrainz.org/release/2c54468a-de...2c4c6c5dd7.html (http://musicbrainz.org/release/2c54468a-dedf-4ac9-a358-562c4c6c5dd7.html) Album ID is 2c54468a-dedf-4ac9-a358-562c4c6c5dd7. It's actually called ReleaseID, but Picard uses MUSICBRAINZ_ALBUMID tag to store this value, so it may be confusing.
Title: foo_musicbrainz
Post by: dannymichel on 2009-04-24 12:00:43
can u make a mirror? this server keeps disconnecting
Title: foo_musicbrainz
Post by: rekees on 2009-05-01 10:48:12
Hey can someone with 0.2 reupload it? Thanks.
Title: foo_musicbrainz
Post by: dreadroach on 2009-05-01 10:56:59
foo_musicbrainz 0.2 (http://rapidshare.com/files/227844132/foo_musicbrainz.dll)
Title: foo_musicbrainz
Post by: M@d Man on 2009-05-07 19:43:48
First of all, thank you for this great plug-in! I thought about to write such plug-in for quite some time, but I couldn't have done it better.

One thing which would be cool is to use the audio fingerprinting method from MusicBrainz to identify the tracks and albums. You probably know that PUID (http://en.wikipedia.org/wiki/Portable_Unique_IDentifier)s can identify songs and it would be possible to tag songs without ANY different data but the audio data itself. Combining the PUIDs it should be possible to get the album information too. There is an open source library called libofa (http://musicbrainz.org/doc/libofa) provided by MusicIP (http://www.musicip.com/) which could do the fingerprinting job.

I don't know much about the licensing stuff but I think you'd have to use the GPL for foo_musicbrainz if you use libofa with the GPL. (It's also possible to use libofa with the APL which I don't know at all.) There is to mention that the fingerprinting algorithm is a patented (U.S. Patent #7013301) and I don't know if MusicIP owns this and allows you to use this technique ( would be logical if they do if they provide a library to do this, but who knows).
If you don't want to use the GPL it could be possible to write another plug-in (foo_puid?) which creates PUIDs and is licensed under the GPL.

With PUID support foo_musicbrainz would be my tagger of choice and I wouldn't have to use freedb so extensively (or anymore :-) ). 

But perhaps you have had such thoughts already and this feature is planned to surprise us.

P.S.: another useful link: http://code.google.com/p/musicip-libofa/ (http://code.google.com/p/musicip-libofa/)
Title: foo_musicbrainz
Post by: fbuser on 2009-05-07 20:07:19
It's a license violation to use GPL libraries for fb2k plugins. So it is not possible. See here (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=36153&view=findpost&p=337520).
Title: foo_musicbrainz
Post by: M@d Man on 2009-05-07 21:18:59
It's a license violation to use GPL libraries for fb2k plugins. So it is not possible. See here (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=36153&view=findpost&p=337520).

Thank you for the link.
I didn't know that. I always thought it's valid to link against the BSD-like SDK but ist seems I'm smarter now (aren't there GPLed components out there?). Anyway the APL (http://en.wikipedia.org/wiki/Adaptive_Public_License) might be the solution.
Would be a pity if we couldn't use this library and PUIDs to identify and tag audio data.
How I hate this licensing stuff 
Title: foo_musicbrainz
Post by: locutus on 2009-05-15 15:15:12
When we don't have fingerprint support here the tool will be not so useful. I am using Jaikoz since a long time and it does a real great job even on single files. Everyone who does tagging(even in masses) should have a look on it. Highly customizable in all kind of features.
OK you have to pay for it, but 22 $ for the program with lifetime upgrades? Not so much and the programmer is highly engaged, quick responces and so on ...

http://www.jaikoz.net (http://www.jaikoz.net)

Don't missunderstand it, i would really prefer to have these features in foobar2000.
Title: foo_musicbrainz
Post by: shakey_snake on 2009-05-15 16:01:18
It's a license violation to use GPL libraries for fb2k plugins. So it is not possible. See here (http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=36153&view=findpost&p=337520).
I'd take what you read in that thread with a grain of salt.

We could never compile GPL'd code for the Windows platform if we want to use the draconian, backwards logic applied in that thread.
Title: foo_musicbrainz
Post by: 2E7AH on 2009-05-31 04:39:37
Musicbrainz context menu entry disappears when more then 99 playlist items are selected (I had some compilation)
Title: foo_musicbrainz
Post by: fbuser on 2009-05-31 08:26:19
It's probably intented, because the menu entries are all for tagging albums, and a (physical) album cannot have more than 99 tracks.
Title: foo_musicbrainz
Post by: 2E7AH on 2009-05-31 10:52:23
Yes, that's true, but I thought that something is wrong because I can't find musicbrainz context menu entry and then just realised that I had selected 101 tracks (http://www.discogs.com/Various-The-Old-Europa-Cafe/release/1319841)
Title: foo_musicbrainz
Post by: mudlord on 2009-07-30 11:54:16
Anyone could upload foo_musicbrainz 0.2 to the fb2k Upload forum? The current link seems down.
thanks.
Title: foo_musicbrainz
Post by: Case on 2009-07-30 20:36:17
Here.
Title: foo_musicbrainz
Post by: mudlord on 2009-07-30 22:43:31
Brilliant.

Thanks for that.
Title: foo_musicbrainz
Post by: 2E7AH on 2009-10-01 20:01:45
When tagging Various Artists releases, MusicBrainz tagger fills both tags: MUSICBRAINZ_ARTISTID and MUSICBRAINZ_ALBUMARTISTID with 89ad4ac3-39f7-470e-963a-56509c546377, which is MB_ID for Various Artists, so MUSICBRAINZ_ARTISTID doesn't corespond to %artist% as it should.

The XML response from musicbrainz.org in such releases contains this information.
Can this be corrected?
Title: foo_musicbrainz
Post by: labou on 2009-10-05 19:34:12
thanks. this works well
Title: foo_musicbrainz
Post by: itisljar on 2009-10-05 19:57:54
I would like to ask proxy support, like Discogs plugin has.
Title: foo_musicbrainz
Post by: Kuraj on 2009-10-24 15:49:15
I would love to see a couple of things in the next releases:

An option to write a Release Group tag rather than Release (so an album and it's bonus disc are not treated as separate albums)

An option to write an original release date, rather than re-releases (so an old album doesn't figure as new on my list, just because of those two additional tracks)
Title: foo_musicbrainz
Post by: Dremora on 2009-10-30 14:11:48
An option to write a Release Group tag rather than Release (so an album and it's bonus disc are not treated as separate albums)

An option to write an original release date, rather than re-releases (so an old album doesn't figure as new on my list, just because of those two additional tracks)


I'm planning to implement all these things, but I'm waiting for NGS
Title: foo_musicbrainz
Post by: Kuraj on 2009-10-30 15:52:05
An option to write a Release Group tag rather than Release (so an album and it's bonus disc are not treated as separate albums)

An option to write an original release date, rather than re-releases (so an old album doesn't figure as new on my list, just because of those two additional tracks)


I'm planning to implement all these things, but I'm waiting for NGS

Awesome. Take your time
Title: foo_musicbrainz
Post by: Crossbar on 2009-11-24 06:06:47
It works really well, thanks so much, no idea why freedb can't be accessed here anymore.
Title: foo_musicbrainz
Post by: mudlord on 2009-11-25 09:58:16
Strange, using freedb works here fine for disc tagging o.o
Title: foo_musicbrainz
Post by: Keesface on 2010-01-07 13:51:31
Musicbrainz's Picard has some scripting abilities, for instance to remove " (disc 2)" and set discnumber to "2". I suggest something like this, or alternatively, if possible, a way of automatically calling Masstagger scripts.

Indeed, picardtagger's most powerful feature is the scripting imo. Any chance this is going to be implemented in a future version? I'd really love to have more control over the tags it writes.
Title: foo_musicbrainz
Post by: u-neeks on 2010-01-22 08:51:36
I hope nobody uses the option to remove the (feat. artist), it's always annoying to fix, Musicbrainz use the right title for the tracks, dunno why change it.
Title: foo_musicbrainz
Post by: radu on 2010-02-02 23:59:27
First of all thanks for the plug-in, it's great.

Can you also include in the tags the personal ratings? I think that you have to log in for that, or at least provide the e-mail address of the user's ratings you want. It would be great if you cold make it to submit ratings to MB and to synchronize the local library with "My Collection", right now there are no tools for that http://musicbrainz.org/doc/Music_Collection_Tool (http://musicbrainz.org/doc/Music_Collection_Tool)

Something similar is done with this plug-in for Song Bird: http://addons.songbirdnest.com/addon/1800?id=1800 (http://addons.songbirdnest.com/addon/1800?id=1800) But Song Bird is so slow for my large collection that it's unusable

Thanks.
Title: foo_musicbrainz
Post by: kitzik on 2010-02-09 07:38:32
Must have plug-in! Thanks!
Could I ask you to add proxy support or at least use foobar2000 network settings?
Title: foo_musicbrainz
Post by: Bryan in Hawaii on 2010-02-16 20:10:57
OK I'm between jobs again so that means I have time to play with (aka screw up) my music. Bear with me as I undoubtedly ask a stupid question. But if you are going to throw me up against a wall, send me a private email

I've got thousands of music files. I've moved from MP3s to HC-AAC (M4As) due to reduced file size. I am very critical of how my music sounds, but I wanted to find a balance with quantity vs. quality, especially with mobile devices, namely my wife's and my cell phones as we are both HC-AAC friendly. I'm also trying to move away from iTunes (thank goodness they finally acknowledge HC-AAC M4As), but still need to use it because of this problem.

The question is - when I update tags in iTunes, most of the time they show up in Foobar correctly, or visa versa. But I notice that [sometimes] certain fields are either not there or incorrect, such as Date (I like just the year of release), or comments, or track information may be missing.

Yeah I know - why use iTunes and fb2k ... it's not so much that I use both, it's so that when I share a file or two with my iEquip'd friends, I would like them to also see the tagged data I updated. When I get a song, I try to update it with the original release information (the album that it was originally released on, the year and the album artwork). Most of my stuff are 60's and 70's stuff.

So, any feedback would be appreciated. (Also any help in how to save album artwork to the MP4/M4A in fb2k would be nice, too!)

And apologies if I've entered this in the wrong area.
Title: foo_musicbrainz
Post by: 2E7AH on 2010-03-01 12:01:25
entering: "foobar musicbrainz tagger" on forum search you can't find this topic on the result first page
heh, you can't find this component even on foobar2000.org components page
Title: foo_musicbrainz
Post by: Ross1 on 2010-04-08 17:54:16
Seems to be fairly successful at finding the right album, nice work.

Just one suggestion, can you give the option to wipe previous tags when applying the new musicbrainz tags?
Title: foo_musicbrainz
Post by: ankurtg on 2010-04-19 19:59:27
Proxy support please!
Title: foo_musicbrainz
Post by: Benji99 on 2010-04-23 16:51:32
I hope this plugin is still being developed!

I have a few suggestions:
1.) Support for more information such as composer info or Label or any information available from musicbrainz
2.) Ability to manually set which information we want to tag, which not and allow us to change the way info is tagged on the files (ie: I use %album_relasedate% instead of %date% for the album release date)

I have another question, I'm not familiar with the Musicbrainz API but is it possible to update the Musicbrainz DB from within Foobar? For example to make corrections or add albums. Can Picard or any other musicbrainz tagger program do that? I'd love to contribute more to Musicbrainz but I cringe at the possibility of editing everything by hand on the site...
Title: foo_musicbrainz
Post by: innou on 2010-08-14 11:26:49
Hi,

It seems that lookup by Album ID does not work anymore. It uses the following URL segment for release - /ws/1/release/{release_id}, while it should be ws/1/release-group/{release_id}.

Could you please fix it?

Thanks.
Title: foo_musicbrainz
Post by: Zarggg on 2010-08-15 14:31:17
Second this. Musicbrainz has changed their URI scheme since the last version of the plugin was released.
Title: foo_musicbrainz
Post by: ghostly on 2010-10-07 10:53:46
Hey,

I use EAC to rip CDs to FLAC image + CUE sheet (with default gap detection). When the CD has HTOA:

Code: [Select]
REM DISCID 3A0B4D05
FILE "image.flac" WAVE
  TRACK 01 AUDIO
    INDEX 00 00:00:00
    INDEX 01 00:00:32
  TRACK 02 AUDIO
    INDEX 01 05:33:20
  TRACK 03 AUDIO
    INDEX 00 13:21:65
    INDEX 01 13:22:65
  TRACK 04 AUDIO
    INDEX 00 16:14:57
    INDEX 01 16:16:57
  TRACK 05 AUDIO
    INDEX 00 19:26:05
    INDEX 01 19:28:05


and I use foobar2000 to convert this image to separate tracks (gaps appended I assume) then I can't use TOC lookup in MusicBrainz:

Code: [Select]
URI: /ws/1/release/?type=xml&discid=sYIYkpYbJjZvvemDRl7NpWAFM0k-&count=5


If I try on CUE sheet tracks, everything is fine:

Code: [Select]
URI: /ws/1/release/?type=xml&discid=WbnYzKGBYkSS1_hcICed9K2nxZQ-&count=5


The files produced this way, have valid DISCID (FreeDB ID) tag as showed by CUE sheet

Thanks for your attention, and hope it's worth adding couple of code lines
Title: foo_musicbrainz
Post by: Purple Monkey on 2010-10-07 12:43:26
I suspect that it is the gap detection that is causing this. Foobar only converts what is played so in this case, no gaps are not appended. The original TOC contains 2 second silence, however since the index00s are not part of the disc and are created by EAC the "TOC" of the new files is different to the original. So when looking up this new TOC it is not found in the database.

Removing all the index 00s should work.
Title: foo_musicbrainz
Post by: ghostly on 2010-10-07 17:45:34
I think we misunderstood because I used CueTools terminology. I'm trying to remove all .NET/Java apps from my system (more from practical then puritan reasons) which would mean removing also CueTools

I would say that foobar2000 converter splits tracks by appending gaps, which is done by not considering INDEX 00. Gaps are not prepended nor left out, while foobar2000 does not care about. HTOA is generally pregap on Track 01 for CueTools users.

Removing INDEX 00 does not solve the problem obviously as foobar2000 does that for me while converting

Trying to guess what this component is doing by manually calculating MusicBrainz Disc ID (http://musicbrainz.org/doc/Disc_ID_Calculation#Calculating_the_Disc_ID) is not worth the effort as I'm afraid I wont be able to resolve it automatically in later time. I thought problem must be start offset, but after your reply I tried on couple of other disc images and now I really can't think of it. Here is example of CUE sheet from flac image that does TOC lookup even when converted to separate tracks:
Code: [Select]
REM DISCID 75104C09
FILE "The Balanescu Quartet - Possessed.flac" WAVE
  TRACK 01 AUDIO
    INDEX 00 00:00:00
    INDEX 01 00:00:42
  TRACK 02 AUDIO
    INDEX 00 08:41:12
    INDEX 01 08:42:45
  TRACK 03 AUDIO
    INDEX 01 12:26:72
  TRACK 04 AUDIO
    INDEX 00 18:46:32
    INDEX 01 18:49:27
  TRACK 05 AUDIO
    INDEX 00 25:06:55
    INDEX 01 25:09:40
  TRACK 06 AUDIO
    INDEX 00 28:55:40
    INDEX 01 28:58:70
  TRACK 07 AUDIO
    INDEX 00 45:50:60
    INDEX 01 45:53:30
  TRACK 08 AUDIO
    INDEX 00 53:34:15
    INDEX 01 53:35:70
  TRACK 09 AUDIO
    INDEX 00 64:34:65
    INDEX 01 64:37:05
Here is another one that does not, but resolves by TOC only on CUE sheet tracks:
Code: [Select]
REM DISCID C9119F0F
FILE "The Legendary Pink Dots - Asylum.flac" WAVE
  TRACK 01 AUDIO
    INDEX 00 00:00:00
    INDEX 01 00:00:33
  TRACK 02 AUDIO
    INDEX 01 04:49:13
  TRACK 03 AUDIO
    INDEX 01 07:18:58
  TRACK 04 AUDIO
    INDEX 00 10:04:28
    INDEX 01 10:05:60
  TRACK 05 AUDIO
    INDEX 00 13:39:33
    INDEX 01 13:41:05
  TRACK 06 AUDIO
    INDEX 00 18:01:28
    INDEX 01 18:03:55
  TRACK 07 AUDIO
    INDEX 01 20:39:28
  TRACK 08 AUDIO
    INDEX 00 25:49:10
    INDEX 01 25:50:63
  TRACK 09 AUDIO
    INDEX 00 37:02:33
    INDEX 01 37:04:18
  TRACK 10 AUDIO
    INDEX 00 45:03:00
    INDEX 01 45:05:23
  TRACK 11 AUDIO
    INDEX 00 48:51:33
    INDEX 01 48:54:40
  TRACK 12 AUDIO
    INDEX 01 54:44:35
  TRACK 13 AUDIO
    INDEX 01 59:37:68
  TRACK 14 AUDIO
    INDEX 01 63:44:28
  TRACK 15 AUDIO
    INDEX 01 67:09:63

I could only think that there is some kind of threshold when generating this ID, as by looking at the TOC from MusicBrainz TOC page for the release in my previous post, I can see that none of the three different TOCs provided are same as TOC generated by EAC for my CD. Also not all track have pregap on problematic CUE sheets whatever that can mean for ID generator. But this is just guessing when I don't know what really is happening

Also I thought that MusicBrainz can be looked up upon DISCID aka FreeDB ID: http://musicbrainz.org/bare/cdlookup.html?id=FREEDB_ID (http://musicbrainz.org/bare/cdlookup.html?id=FREEDB_ID), but the system provided is reduced, to say at least.

After all, this is not some big problem, but effort to understand what I can do with this software, although I can't write MusicBrainz data to CUE sheet and then convert it as not all tags are written
Title: foo_musicbrainz
Post by: Purple Monkey on 2010-10-07 19:40:31
Yes you are right index 00s are ignored, foobar only looks at 01 indexes. However the cue-sheets and separate tracks still produce a different DiscID.

In both cases the first track is shortened by 00:42 and 00:33 respectively (pre-gap), however if you check the release (http://musicbrainz.org/release/c18b8cbc-49d9-4c26-a031-f15cc8153a4d.html) pages (http://musicbrainz.org/release/f8fa1353-4501-4908-b2ae-04782365643b.html) you will see the first disc has more than one DiscID, one of which matches a change of 00:42 (so MB returns the album.) However the second album only has one DiscID so is not matched at all. The component has no way of knowing what the pre-gap size was and so has to use 0.

Solution: If looking up by TOC fails: try by Artist/Album, and if that fails: look it up on the site and use by AlbumID.
Title: foo_musicbrainz
Post by: ghostly on 2010-10-07 21:18:46
In both cases the first track is shortened by 00:42 and 00:33 respectively (pre-gap), however if you check the release (http://musicbrainz.org/release/c18b8cbc-49d9-4c26-a031-f15cc8153a4d.html) pages (http://musicbrainz.org/release/f8fa1353-4501-4908-b2ae-04782365643b.html) you will see the first disc has more than one DiscID, one of which matches a change of 00:42 (so MB returns the album.) However the second album only has one DiscID so is not matched at all. The component has no way of knowing what the pre-gap size was and so has to use 0.

Non of linked CD TOCs (Balanescu) has 42 frames as start sector, it's either 150, 182 or 190 frames. But if sector values are shifted to match those start sectors, then there is match in 1st, 3rd and 5th CD TOC, all with difference of 1 CD frame. And indeed this component matches on first CD ID. This also applies to the CD from my first post

I tried to rip this CD with foobar2000 ripper and CUE sheet produced this way is with pregap only to first track (others appended). It's the same result as flac images produced by EAC. Now it seems, that really first track pregap is blocking the way to TOC lookup in some way
Title: foo_musicbrainz
Post by: Sandrine on 2010-10-07 21:37:37
and I use foobar2000 to convert this image to separate tracks (gaps appended I assume) then I can't use TOC lookup in MusicBrainz:


And why would you do that? There is no better rip than a complete image. Just embed the cuesheet instead and no more trouble with online databases.
Title: foo_musicbrainz
Post by: ghostly on 2010-10-07 21:56:35
I use images for backup and separate tracks for playing. Using images with embedded CUE sheets has its benefits, but I just want separate tracks for regular usage, easily editable and no problem with other software
Title: foo_musicbrainz
Post by: jesus2099 on 2011-01-05 14:06:59
Dremora, thank you so very much for your awesome plug-in !
I've been using it for almost a year now (http://www.hydrogenaudio.org/forums/index.php?showtopic=79027&view=findpost&p=700345) without meeting any difficulties, ever.
foo_musicbrainz is just the best foobar2000 plug-in in the universe.
Title: foo_musicbrainz
Post by: Kuraj on 2011-03-20 16:27:14
Is the author still planning to work on this plugin or release the source?

I just need it to apply original release date instead of subrelease date, and that'd probably be a matter of 1 variable change...
Title: foo_musicbrainz
Post by: mudlord on 2011-03-21 08:51:01
Quote
release the source


why. >_>
Title: foo_musicbrainz
Post by: Kuraj on 2011-03-21 09:31:21
I only meant to ask whatever the author was up to, not that he should release it if he's not going to develop it anymore (as it may have sounded?)

No harm done.
Title: foo_musicbrainz
Post by: mudlord on 2011-03-21 09:37:16
I was asking whats the point in releasing source.

If its GPLed, its useless, and thats a fact.
Title: foo_musicbrainz
Post by: thuan on 2011-03-21 09:55:18
I think release the source does not equal GPLed it, look at WSH Panel mod.
Title: foo_musicbrainz
Post by: mudlord on 2011-03-21 13:16:14
Again, depends on licensing. It should be LGPL or better pretty much. GPL for closed sourced apps == not work.
Title: foo_musicbrainz
Post by: klonuo on 2011-03-21 13:22:44
hey mudlord, can you stop spoiling threads with you licensing BS?
Title: foo_musicbrainz
Post by: mudlord on 2011-03-21 16:15:16
If you ever bothered to check the GPL licensing, you will find I am correct.

GPL is viral. So anything it touches, must be GPL too.
Title: foo_musicbrainz
Post by: RastaMan on 2011-05-14 20:32:11
The link to this extension no longer works. Here's another one I found via Google:

http://chomikuj.pl/File.aspx?id=186135575 (http://chomikuj.pl/File.aspx?id=186135575)
Title: foo_musicbrainz
Post by: jesus2099 on 2011-05-14 23:29:11
The link to this extension no longer works.


The original link still works for me.
Title: foo_musicbrainz
Post by: Szekely on 2011-05-18 20:35:22
Musicbrainz rollout of NGS has broken this plugin. The returned results do not always match and sometimes it capitalizes everything or can't determine the year,etc. Hopefully the author will take this opportunity to update the plugin with support for more fields, options, etc. I believe he posted somewhere that he was waiting to update until NGS was released, and now it has been.
Title: foo_musicbrainz
Post by: Dremora on 2011-05-20 16:52:06
First I want to thank everybody for your attention and support of this component!
I also want to inform you that I've started working on a new version of foo_musicbrainz, which is going to be released somewhere in June.

Regarding Szekely's issues: component behaviour shouldn't have been changed a lot due to NGS, as the old web service is still working. The only exception are old release events now being represented as separate releases. Can you please be more specific and give me examples of situations where these things happen? It may as well be a bug of MusicBrainz.
Title: foo_musicbrainz
Post by: Szekely on 2011-05-21 08:02:49
Just a few issues I've encountered.

(http://i.imgur.com/sK4kF.png)
This was encountered when looking up the album by TOC. I've never had this problem before.

(http://i.imgur.com/RdBJ3.png)
This the same album when looking up by Artist/Album.

It's not a big deal really, I'm just super glad to hear you are working on a new version!
Title: foo_musicbrainz
Post by: Dremora on 2011-05-21 16:09:35
Szekely, the first bug occurs due to CDStubs being included in the results. Second issue shows a new nature of MusicBrainz being now release-centric instead of disc-centric. Release groups will be used in future versions of foo_musicbrainz to present results in a less distractive way.

I've just released a new version, which excludes CDStubs from search results and adds a couple of other small improvements.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-05-21 20:23:28
Hi Dremora !
When I “saw” you in MB IRC I didn’t realize you were the one who wrote foo_musicbrainz !
Thank you so much for this component, sincerely !
The new add TOC to MB function is marvellously welcome.
Title: foo_musicbrainz
Post by: refresh on 2011-05-22 11:01:41
I would really much appreciate a future option that would not combine multiple cd releases into one when trying to tag music ;) (maybe tagging not only by album id but also by disc id?)
Title: foo_musicbrainz
Post by: jesus2099 on 2011-05-22 19:17:17
It seems that “Get tags from Musicbrainz (by Musicbrainz album ID)” tagging context menu was kind of removed.
Would it be possible to have it back ?
It was quite handy and faster than typing (or pasting) both artist and album name fields, in many cases.

I still see it checked in the foobar2000 context menu settings but it doesn’t actually show up.
Title: foo_musicbrainz
Post by: igitur on 2011-05-23 14:47:15
Like many other users, I'm desperately requesting proxy support. I can't do much with this plugin because I'm behind a corporate firewall / proxy.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-05-23 14:50:19
Like many other users, I'm desperately requesting proxy support. I can't do much with this plugin because I'm behind a corporate firewall / proxy.


Did you try the proxy setting in foobar2000’s networking preferences ?
Title: foo_musicbrainz
Post by: Dremora on 2011-05-28 17:17:57
It seems that “Get tags from Musicbrainz (by Musicbrainz album ID)” tagging context menu was kind of removed.
Would it be possible to have it back ?
It was quite handy and faster than typing (or pasting) both artist and album name fields, in many cases.

I still see it checked in the foobar2000 context menu settings but it doesn’t actually show up.

It is now only shown when option “Write MusicBrainz IDs” is enabled. As this is causing troubles, I'll restore the original behavior in the next version.
Like many other users, I'm desperately requesting proxy support. I can't do much with this plugin because I'm behind a corporate firewall / proxy.


Did you try the proxy setting in foobar2000’s networking preferences ?

Unfortunately it won't work this way. I'd be happy if someone showed me how to grab this option from the player configuration (couldn't find anything in SDK, although foo_audioscrobbler has somehow managed to use this preference).
Title: foo_musicbrainz
Post by: lvqcl on 2011-05-28 17:33:25
Probably it uses http_* interfaces from http_client.h ?
Title: foo_musicbrainz
Post by: Dremora on 2011-05-28 17:38:59
Probably it uses http_* interfaces from http_client.h ?

Thanks! I was searching for “proxy” or “networking”, bug haven't noticed that foobar has its own http client interface
Title: foo_musicbrainz
Post by: Dremora on 2011-05-29 21:15:05
I would really much appreciate a future option that would not combine multiple cd releases into one when trying to tag music  (maybe tagging not only by album id but also by disc id?)

I agree, this is a serious issue and it will be addressed in the next update.
Title: foo_musicbrainz
Post by: Szekely on 2011-05-31 05:07:49
I have a feature request for the next version. Please provide the ability to convert Unicode symbols to their (universally used ASCII) equivalents. I also recommend having this enabled by default. Most (all?) programs correctly see common symbols such as ' and ’ as different characters and Musicbrainz's new insistence to used all Unicode all the time causes a host of problems and inconveniences with many applications. More info here: http://forums.musicbrainz.org/viewtopic.php?id=2495 (http://forums.musicbrainz.org/viewtopic.php?id=2495)
Title: foo_musicbrainz
Post by: ProphetOfFrivolity on 2011-05-31 07:09:59
First off thank you for this component.

I have a request, don't know whether this has already been mentioned. if so, sorry for the duplication.

Is it possible to add an option to change artist names from languages like Russion (for instance, Rachmaninoff saves as Сергей Васильевич Рахманинов) to their English form? In Picard there exists a script for this, which you may be aware of.

Thanks.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-05-31 10:52:03
Those two feature requests are beginning to complexify foo_musicbrainz IMO.
Anyway my feeling is that they shouldn’t be the new defaults as most people just want the titles and artist names in their genuine form.
Title: foo_musicbrainz
Post by: Dremora on 2011-05-31 12:45:04
Actually, both features are quite important and already are in the todo-list. Regarding the first one (ASCII punctuation), I even had a small discussion here (http://musicbrainz.org/edit/14431115), and it will probably even make it right into the next version.
Default settings should present data it its purest form, so both features are gonna be opt-in.
Title: foo_musicbrainz
Post by: Szekely on 2011-06-01 06:27:55
Coolio.

Just a general question: what "advanced" fields are you planning on supporting, if any, with the NGS version? Things such as track relationships, artist and track sort orders, etc.
Title: foo_musicbrainz
Post by: Dremora on 2011-06-01 23:06:44
In the upcoming version not much, actually — barcode, label, catalognumber and musicbrainz_releasegroupid. But in the future versions more fields will be supported.
Title: foo_musicbrainz
Post by: Zarggg on 2011-06-01 23:51:34
Unicode in tags should not be an issue with modern operating systems, particularly Windows (which you are most likely using if you're running foobar2000). Unicode in filenames is the bigger concern with use of the Musicbrainz database, as programs such as Picard can rename files based on metadata.

Transliteration to the Latin alphabet, however, would be an excellent feature to have. However, if (when?) these features are implemented, I would suggest leaving them off by default.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-06-02 17:51:15
Use [font= "Courier New"]$ascii(%artist% _ %title%)[/font] function in foobar2000 for filenames.
Title: foo_musicbrainz
Post by: Dremora on 2011-06-03 02:37:20
0.3 beta 1 is out. Remember, it's only beta, so there still may be bugs.
Title: foo_musicbrainz
Post by: Szekely on 2011-06-03 06:34:44
Stupendous, magnificent, amazing!

Well done.

Bug report: tagged the Black Box by Black Sabbath. http://musicbrainz.org/release-group/bf70c...48-f67065409b1b (http://musicbrainz.org/release-group/bf70c36b-6f8f-31d1-b348-f67065409b1b) Discs 1, 4 and 8 did not receive disc numbers or disc subtitles when tagged. In fact, the other discs list "totaldiscs" as 5, although they are tagged with the correct disc number, 6, 7, etc.
Title: foo_musicbrainz
Post by: Dremora on 2011-06-03 14:06:53
Bug report: tagged the Black Box by Black Sabbath. http://musicbrainz.org/release-group/bf70c...48-f67065409b1b (http://musicbrainz.org/release-group/bf70c36b-6f8f-31d1-b348-f67065409b1b) Discs 1, 4 and 8 did not receive disc numbers or disc subtitles when tagged. In fact, the other discs list "totaldiscs" as 5, although they are tagged with the correct disc number, 6, 7, etc.

Fixed in beta 2.
Title: foo_musicbrainz
Post by: q-stankovic on 2011-06-03 19:37:49
Although i am not able to explain what a TOC is, however i have an imagination what it is. Since i am not familiar with musicbrains can someone explain why not "get tags from TOC" is vailable in context menu on all selections of an album. Actually there are only few albums where i see this context menu at all.

dremora, do you plan to implement something like this (https://bitbucket.org/Novakov/foo_musicdns/wiki/Home) at some point?
Title: foo_musicbrainz
Post by: lvqcl on 2011-06-03 20:01:11
Quote
Although i am not able to explain what a TOC is, however i have an imagination what it is.

It's CD Table of Contents:

http://en.wikipedia.org/wiki/Optical_disc_authoring#TOC (http://en.wikipedia.org/wiki/Optical_disc_authoring#TOC)
Quote
The Table of Contents (TOC) is the area where the layout of the tracks on the disc is described. [...] The TOC on discs is in principle similar to partition table on hard drives.


Quote
Actually there are only few albums where i see this context menu at all.

I think that the length (in samples) of every selected track should be a multiple of 588.
Title: foo_musicbrainz
Post by: q-stankovic on 2011-06-03 20:44:05
I think that the length (in samples) of every selected track should be a multiple of 588.
The only conclusion that now comes to my mind is to use freedb if i like to fetch data based on track length rather than album/artist tag
Title: foo_musicbrainz
Post by: Dremora on 2011-06-03 22:53:00
dremora, do you plan to implement something like this (https://bitbucket.org/Novakov/foo_musicdns/wiki/Home) at some point?

Last time I checked, it was illegal to use libofa with foobar2000 (cause it's GPL). It has even been discussed in this topic. Moreover, I was told PUIDs are going to be replaced with some other audio fingerprinting library.

I think that the length (in samples) of every selected track should be a multiple of 588.
The only conclusion that now comes to my mind is to use freedb if i like to fetch data based on track length rather than album/artist tag

Well, you sure can if you don't care about the quality of your tags
Title: foo_musicbrainz
Post by: q-stankovic on 2011-06-03 23:24:03
No, i have to because i have "get tags from TOC"only in rare cases in my context menu. That was the initial point of my posting.
Title: foo_musicbrainz
Post by: Dremora on 2011-06-03 23:39:54
Sorry, I didn't understand you. Do you mean there are cases when “Get tags from freedb” returns correct results, but MusicBrainz TOC menu command isn't displayed?
Title: foo_musicbrainz
Post by: q-stankovic on 2011-06-03 23:54:06
First of all let me say sorry for a wrong information from me: as i started to play around with musicbrains i tested with 10 or 11 albums. It was a coincidence that almost none of them didn't had the TOC command. After having a look in in more albums it appears often enough. 

But apart from that: yes, there are some cases there freedb return correct results but the musicbrains toc command isn't displayed.
From what does it depend whether the command is shown? How has a album to be ripped?
Title: foo_musicbrainz
Post by: Dremora on 2011-06-04 00:27:25
From what does it depend whether the command is shown? How has a album to be ripped?

I think that the length (in samples) of every selected track should be a multiple of 588.

This and no more than 99 tracks should be selected.

What's funny, I've just chosen a random album from my media library (where TOC command is missing) and tried tagging using freedb — to my surprise, the album was recognized. I've studied the request made by foo_freedb2 — it just rounds the number of samples to the nearest multiple of 588. That's going to be implemented in the next version of foo_musicbrainz, thanks for the observation
Title: foo_musicbrainz
Post by: q-stankovic on 2011-06-04 00:41:05
So that means that the command won't be missing then? Happy that i helped although what you called observation was more absolute helplessness.

Edit

From what does it depend whether the command is shown? How has a album to be ripped?

I think that the length (in samples) of every selected track should be a multiple of 588.

This ...

My question was more like: From what does it depend whether length in samples is a multiple of 588?
Title: foo_musicbrainz
Post by: Dremora on 2011-06-04 02:39:43
My question was more like: From what does it depend whether length in samples is a multiple of 588?

Generally all music ripped from CDs should obey the rule of 588 samples (as it is the size of a CD sector). There are some lossy formats, though, which for some reasons change the length of a track by adding or removing several samples. In case of MP3 it also depends on the version of encoder and its settings. Default MP3 conversion settings in foo_converter combined with lame.exe yield tracks with no length changes.
Title: foo_musicbrainz
Post by: lvqcl on 2011-06-04 10:55:30
My question was more like: From what does it depend whether length in samples is a multiple of 588?

Do you use some lossy encoder (what settings)?

WMA?  LAME with -t or -nogaps switch?
Title: foo_musicbrainz
Post by: smkk on 2011-06-04 11:39:53
One of my favourite foobar components. Thanks for the update.
Title: foo_musicbrainz
Post by: dubwai on 2011-06-08 07:06:34
Dremora it's possible to make in future sync between fb2k ratings and MB ratings. Both uses 5 star system. I think it's possible because as I know Picard can do this. 95% of music have MB ids and will pretty cool if we have possibility to automatic send ratings to MB if it have MBIDs. For example album ratings may calculated by middle ratings of all it songs. Artist rating may be calculated by middle rating of all it albums.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-06-08 13:49:37
Dremora it's possible to make in future sync between fb2k ratings and MB ratings. Both uses 5 star system. I think it's possible because as I know Picard can do this. 95% of music have MB ids and will pretty cool if we have possibility to automatic send ratings to MB if it have MBIDs. For example album ratings may calculated by middle ratings of all it songs. Artist rating may be calculated by middle rating of all it albums.


I found this thread about ratings (http://www.hydrogenaudio.org/forums/?showtopic=59187) as well as this stat and rating component (http://www.foobar2000.org/components/view/foo_playcount) but I don’t know if there actually is a native foobar2000 ratings functionality at all.
Title: foo_musicbrainz
Post by: dubwai on 2011-06-08 17:24:19
as well as this stat and rating component (http://www.foobar2000.org/components/view/foo_playcount) but I don’t know if there actually is a native foobar2000 ratings functionality at all.

This plugin by "Peter". As I know this is author of fb2k. Yes it's optional component, but and Monkey's Audio Decoder is also optional. But I can't imagine fb2k without this plugins and I think 95% of users use this plugins. I think that Peter add support of MB to his foo_playcount (http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Components/Playback_Statistics_v3.x_%28foo_playcount%29) component very tiny. So it will be awesome to add support of submission rating from foo_playcount component to foo_musicbrainz.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-07-15 16:14:49
I think 95% of users use this plugins


Sorry I was 5% of users then

Hey Dremora, it seems that the plugins is tagging using the recording names instead of tracklist’ track names.
It might be a wanted feature for some people but maybe it could be switchable for people wanting tracklist’s track names instead ?
Or we could have the choice at tagging time (if they differ), or something like that…

EDIT: Same for track artists, it’s currently fetching the recording artist instead of track artist.
Title: foo_musicbrainz
Post by: smkk on 2011-07-27 08:13:04
Recently "Get tags by TOC" stopped working for me, I always get "Response from MusicBrainz: Not Found". However "Get tags by Artist & Album / MusicBrainz AlbumID" still work np. Anyone else having this issue?
Title: foo_musicbrainz
Post by: jesus2099 on 2011-07-27 09:57:04
Recently "Get tags by TOC" stopped working for me, I always get "Response from MusicBrainz: Not Found". However "Get tags by Artist & Album / MusicBrainz AlbumID" still work np. Anyone else having this issue?


I confirm it doesn’t work any more for me either.
If we click add TOC to MB we can see the TOC is correct. It’s just the WS that’s not working for the get tags from MB by TOC.
It’s very recent (maybe 1 or 2 days only), they might have changed something in the Web Service…
Title: foo_musicbrainz
Post by: Sixth Street on 2011-07-27 19:57:44
I am getting the same behavior.
Title: foo_musicbrainz
Post by: natrixx on 2011-07-28 00:56:19
Confirmed. Using foobar2000 v. 1.1.8 beta 2 with MusicBrainz Tagger v. 0.3 beta 2.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-07-29 10:01:27
Because of this bug we’ve been intesively using the Get tags from Musicbrainz (by Musicbrainz album ID).
For this we usually copy a URL (like “musicbrainz.org/release/64ba9c60-c71e-47fc-bfef-9b58c3ddf7bd/*”).
So could you allow the pasting of any such URL in the text field and automatically trim it to only keep the MBID with the following matching regular expression for instance :
Code: [Select]
([a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12})


This would accelerate things by only having to do CTRL+V, ENTER instead of editing out the URL stuff.
Title: foo_musicbrainz
Post by: Sixth Street on 2011-08-07 15:22:48
TOC lookup is working fine for me again, so it must not have been component related.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-08-07 19:22:23
Isn’t it strange that TOC commande appears even for non Audio CD playing ?
Title: foo_musicbrainz
Post by: soulsearchingsun on 2011-09-30 15:54:03
Isn’t it strange that TOC commande appears even for non Audio CD playing ?

What do you mean? I'm using '...by TOC' with image rips and it works perfectly as it should. Are you talking about non-44.1kHz files or about files that don't match the Red Book sector size?
Title: foo_musicbrainz
Post by: Andu on 2011-10-18 21:16:22
I just ran an Artist/Album search and got an XML parsing error.
Title: foo_musicbrainz
Post by: Wirrunna on 2011-11-06 02:36:09
Newbie question - how do I list albums/tracks that I have added MUSICBRAINZ tags to ?
Title: foo_musicbrainz
Post by: Emerelle on 2011-11-06 11:54:52
Wirruna, you can do that by doing a Library search like: MUSICBRAINZ_TAG PRESENT
(insert the tag you are searching for). Similarly, you could use foo SQL Tree, which also offers such searches.
Title: foo_musicbrainz
Post by: Wirrunna on 2011-11-06 20:41:47
Emerelle, thank you, MUSICBRAINZ_TRACKID PRESENT worked perfectly. I had tried Library Searches before asking but couldn't get them to work.

Dremora, thank you for MusicBrainz Tagger, it is a great plugin.

Title: foo_musicbrainz
Post by: Emualynk on 2011-11-09 00:05:03
Thanks Dremora for the plugin, I've been using it for quite a while now and find it very useful.
I still have a little "problem" with it though :
Would it be possible to add the Release Group date of an album to a specially created field in addition to the print date?
I'm asking this because it makes more sense for me, in a musical logic, to have the date of when the music was first released instead of when the record was made and since I'm using foobar to sort and move my music it would help a lot.
Title: foo_musicbrainz
Post by: somy on 2011-11-30 09:52:11
Thanks for the great plugin!
I'd like to ask whether it will support download of album art from musicbrainz in the future?
Title: foo_musicbrainz
Post by: jesus2099 on 2011-12-15 17:32:42
Hello again Dremora.
I know I’ve already said it but it seems you are not around these months.



There is a problem with foo_musicbrainz as it currently takes the recording names instead of the track names.
Take this LATIN release (http://musicbrainz.org/release/8444dd3a-e91c-4eab-9e9d-9ae62703a779) for instance (pseudo release). Usually people chossing this one would like to have LATIN track names and artists.
It would be nice to have foo_musicbrainz take the track names instead of recording names (it could also be in settings).



The other minor stuff is that, rather than exact MBID paste in Get tags from Musicbrainz (by Musicbrainz album ID), we could paste a full MB URL.
URL from which the MBID would be caught by a regex match :
Code: [Select]
([a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12})


I hope you don’t drop this wonderful component.
Title: foo_musicbrainz
Post by: innou on 2011-12-15 18:01:43
There is a problem with foo_musicbrainz as it currently takes the recording names instead of the track names.
Take this LATIN release (http://musicbrainz.org/release/8444dd3a-e91c-4eab-9e9d-9ae62703a779) for instance (pseudo release). Usually people chossing this one would like to have LATIN track names and artists.


Oh really? Have you made a poll for people across the world so now you know what they prefer? If not, please use statements as "I would like".
Title: foo_musicbrainz
Post by: jesus2099 on 2011-12-15 18:09:23
Are you kidding?
Look at the LATIN RELEASE (http://musicbrainz.org/release/8444dd3a-e91c-4eab-9e9d-9ae62703a779) and then look at the ORIGINAL RELEASE (http://musicbrainz.org/release/c3b2cac6-0da4-42d3-b40f-edbe7a2e1f2b) (and for your information, this is the latter that I would want anyway).
They are looked up by the same TOC, the aim of this is to choose what you want.
I was just pointing out a flaw in the component that makes that whichever release you choose, you will get the same recording names. ← UC?
Title: foo_musicbrainz
Post by: innou on 2011-12-18 13:46:12
Are you kidding?
Look at the LATIN RELEASE (http://musicbrainz.org/release/8444dd3a-e91c-4eab-9e9d-9ae62703a779) and then look at the ORIGINAL RELEASE (http://musicbrainz.org/release/c3b2cac6-0da4-42d3-b40f-edbe7a2e1f2b) (and for your information, this is the latter that I would want anyway).
They are looked up by the same TOC, the aim of this is to choose what you want.
I was just pointing out a flaw in the component that makes that whichever release you choose, you will get the same recording names. ? UC?


Okay. So this is just a bug but not the matter of user preference. I mean bug assuming MusicBrainz API works in the same way their UI works.
Title: foo_musicbrainz
Post by: jesus2099 on 2011-12-18 19:49:30
Well, their API returns both track names and recording names (cf. MB web service call for this release (http://musicbrainz.org/ws/2/release/8444dd3a-e91c-4eab-9e9d-9ae62703a779?inc=recordings)).
I think Dremora might have taken the recording names instead of the track names.
The fix could be quite easy and fast.
Title: foo_musicbrainz
Post by: Szekely on 2012-02-01 00:22:12
Hi Dremora

I recently have encountered a weird situation with featured artists. Sometimes foo_musicbrainz will write the "feat. artist" to the artist tag for the track resulting in "artist feat. artist." I'm not sure if this a problem because of something with NGS or what, but it does not do that all the time. For example, with this release (http://musicbrainz.org/release/14a5c8d1-37ec-4124-b988-30bdacbc0cc4) foo_musicbrainz tags the first track artist as Alan Menken feat. Charles Heston and the track title as Long Ago... If I tag the same album with Picard, the artist for the first track is just Alan Menken and the track title is Long Ago... (feat. narration Charles Heston). I do not have Remove feat. artists from track titles checked. I assume this is unintended because it doesn't do it all the time, but if you could make it configurable that would be excellent as it saves a bit of work on my part to correct it.
Title: foo_musicbrainz
Post by: jesus2099 on 2012-02-01 08:26:27
Hi Dremora

I recently have encountered a weird situation with featured artists. Sometimes foo_musicbrainz will write the "feat. artist" to the artist tag for the track resulting in "artist feat. artist." I'm not sure if this a problem because of something with NGS or what, but it does not do that all the time. For example, with this release (http://musicbrainz.org/release/14a5c8d1-37ec-4124-b988-30bdacbc0cc4) foo_musicbrainz tags the first track artist as Alan Menken feat. Charles Heston and the track title as Long Ago... If I tag the same album with Picard, the artist for the first track is just Alan Menken and the track title is Long Ago... (feat. narration Charles Heston). I do not have Remove feat. artists from track titles checked. I assume this is unintended because it doesn't do it all the time, but if you could make it configurable that would be excellent as it saves a bit of work on my part to correct it.


Hi, it’s the exact problem I was saying above (http://www.hydrogenaudio.org/forums/index.php?showtopic=70623&view=findpost&p=779085), but Dremora seems away from the project for a while…
«??. foo_musicbrainz takes the recording name, not the tracklist track name. It should be either the opposite or configurable.
In this case?:
Recording name (the one foo_musicbrainz gets)?: Long Ago... (http://musicbrainz.org/recording/af8bcbda-fbc4-4830-b09a-7e7e34599b01) by Alan Menken feat. Charlton Heston.
Track name (the one you want)?: Long Ago... (feat. narration Charles Heston) (http://musicbrainz.org/release/14a5c8d1-37ec-4124-b988-30bdacbc0cc4) by Alan Menken
Title: foo_musicbrainz
Post by: Szekely on 2012-02-01 23:02:26
Ah, I did not realize we were describing the same thing! Some good news is that Dremora as posted code updates within the last few days!
Title: foo_musicbrainz
Post by: jesus2099 on 2012-02-02 09:21:58
Wow, Szekely… I wondered how you would know that…
Then I found this GIT (http://github.com/Dremora/foo_musicbrainz/commits) thing !
It’s awesome ! It is over there that I should leave my comments and everything.
Here is a foo_musicbrainz user conversation, but over is the bug reports and everything ! 
Title: foo_musicbrainz
Post by: mezuss on 2012-02-22 21:59:40
I'm dreaming of a plugin ("foo_discbrainz"?) which would take info from artist discogs page and transfer it to musicbrainz. I have a problem with Molly Nilsson - she's already present in discogs database and not existent at musicbrainz.
Title: foo_musicbrainz
Post by: Dremora on 2012-02-22 22:35:45
I'm dreaming of a plugin ("foo_discbrainz"?) which would take info from artist discogs page and transfer it to musicbrainz. I have a problem with Molly Nilsson - she's already present in discogs database and not existent at musicbrainz.

You might be interested in this Greasemonkey plugin (http://userscripts.org/scripts/show/36376).

To everybody: thanks for your comments, suggestions and bug reports! I've already started working on a new version, but due to very tight schedule can't promise any dates. The list of planned features is on the Github page (https://github.com/Dremora/foo_musicbrainz/issues?sort=created&direction=desc&state=open).
Title: foo_musicbrainz
Post by: jesus2099 on 2012-02-23 09:56:39
To everybody: thanks for your comments, suggestions and bug reports! I've already started working on a new version, but due to very tight schedule can't promise any dates. The list of planned features is on the Github page (https://github.com/Dremora/foo_musicbrainz/issues?sort=created&direction=desc&state=open).


Thanks very much for your great work Dremora?!
I was scared you dropped the plugin until I eventually was pointed to something called github by Szekely.
Is there an easy way to see where a plugin version applies, what are fixes waiting for next release??
For instance, current version is 0.3 beta 2, what line does match this version/date in commit history (https://github.com/Dremora/foo_musicbrainz/commits/master) or in another view maybe??
Title: foo_musicbrainz
Post by: Dremora on 2012-02-23 10:43:41
Sure, git has tags (https://github.com/Dremora/foo_musicbrainz/tags) for this
Title: foo_musicbrainz
Post by: mezuss on 2012-02-23 13:40:09
You might be interested in this Greasemonkey plugin (http://userscripts.org/scripts/show/36376)


Thanks a lot !
Title: foo_musicbrainz
Post by: jesus2099 on 2012-02-23 17:14:49
Sure, git has tags (https://github.com/Dremora/foo_musicbrainz/tags) for this

So I go to tags page, I copy the last commit for 0.3-beta-2 version (which is 50cdeb59f8) and then go to commits page and look for this ID??
Is there a faster click?? It’s already quite cool anyway, thanks?!
This way I saw that Total medium count is now actually used (2011-06-03) was the last commit included in release so all the later commits (2012-01-29 and upcoming) are the ones that are waiting for the next release. Did I understand it correclty??
Title: foo_musicbrainz
Post by: dubwai on 2012-04-04 16:47:07
Dremora plz can you add function, similar to picard: "Use standardized artist names". It's very useful, because in MB a lot of compilation have artist name titles how in cover, but in my library to easy navigation (and autoplaylist stuff) I wanna to have only one artist name variant. Thx.
Title: foo_musicbrainz
Post by: kitzik on 2012-07-18 07:34:41
still beta status
is development dead already?
Title: foo_musicbrainz
Post by: Dremora on 2012-07-24 01:01:08
I must apologize for a long delay of a new release. I've been quite busy lately finishing my master's degree. The component development, apart from a couple of fixes, hasn't been progressing, as you may have seen on GitHub (https://github.com/Dremora/foo_musicbrainz). The fact that I've switched to Mac as my main machine only adds to it (but I still use foobar2000 under VirtualBox). Nevertheless, I'm planning to continue development as soon as I get proper internet connection (my Windows 7 development machine is located in another country and can only be accessed remotely).
Regarding the beta status, there's only been one bug discovered (https://github.com/Dremora/foo_musicbrainz/issues/30) (and fixed), and for some reason I didn't want to release a new version of the component just with one fix 6 months after the beta version. However, I'm changing my mind, as having this fix now (and a small feature) is better than sometime in the future. The source code is available on GitHub (https://github.com/Dremora/foo_musicbrainz/zipball/0.3), I'll provide a binary version ASAP (or you can build it manually). Thanks for the patience!

Update: binary component is there, enjoy!
Title: foo_musicbrainz
Post by: Zageron on 2012-07-25 07:18:56
Finally!  I've been waiting for some progress on this for ages!~ Thank you very much.
I might fork at some point in the future and help you out, if you don't mind that is.
Title: foo_musicbrainz
Post by: KarnEvil9 on 2012-07-25 07:21:47
Longtime Picard user here, and I'm loving this as a replacement.  Thanks!
Title: foo_musicbrainz
Post by: Dremora on 2012-07-25 12:11:41
Finally!  I've been waiting for some progress on this for ages!~ Thank you very much.
I might fork at some point in the future and help you out, if you don't mind that is.

Sure I wouldn't mind, that's why the project is on GitHub
Title: foo_musicbrainz
Post by: kitzik on 2012-07-25 13:14:33
binary component is there, enjoy!

Thank you, Dremora! Glad to see you here again! 
Title: foo_musicbrainz
Post by: dubwai on 2012-07-25 16:29:43
I use this plugin almost every day. My workflow consist from 1. download release from what (yarrr) 2. make APL files for album by script (it's unbelievability good solution for fb2k library and unique, because i can seed data and edit tags in my own way, collect statistic and even sync stats and files with automatic conversation to iPod)  3. Take tags from MB by TOC (or add it, if it miss).
And I collect to notebook all usability issues and features what I miss. I think future developers must take look to foo_discogs for some good solution for such kind of plugin. Here my list:

I know that place of all writing above at github, but with my english spell... may be I don't correct explain my thoughts. Also someone said something about fork, so I think this thread good place for such discussion. In this post I wrote what I really miss, also i have many diffent other thoughts about not primary features. Some of them require account connection:
1). send ratings (with auto calculation overall release rating) 2). add to personal MB collection (I heard that in summer google code, them will add possibility to get notification about release in personal collections, primary it done for VA releases, but I think it will be nice, if you get tags automatic by foo_musicbrain  add to "My Collection" (with checkbox in getting tag window) to get emails about changes concrete release what you have, and not tons of spam about artist edits) 3). Import fb2k tags to MusicBrainz, like "Import to MB from Discogs" usersript, because it's really fast to edit data with masstager scripts in fb2k, rather then site editing 4). Getting CoverArt to customizable folders and name files, and ability to choose what type of cover you whant (may be only "Front"). For example i use temple "_cover_art" in files folder, because in separate path, it boring to rename folder if you change tags.

P.S. I am glad to help in anyway to anyone who continue to work with plugin. Of course with my knowledges I can't develop, because I am not coder, but I can wrote simple scripts, find and analyses information  But I think the main help, that I can give is TESTING. Anyway you are welcome to PM or mail me.
Title: foo_musicbrainz
Post by: noiselab on 2012-07-29 20:24:50
When trying to retrieve tags by TOC, the track length in samples must be divisible by 588. Can support for files encoded at 48000hz (eg Opus files) be implemented for when retrieving tags by TOC?
Title: foo_musicbrainz
Post by: The Seeker on 2012-08-21 14:18:58
Does foo_musicbrainz write ID3v2.4 tags? If so, can it be changed to write ID3v2.3?
Title: foo_musicbrainz
Post by: Rarn on 2012-08-28 08:21:14
I believe this plugin is writing MusicBrainz IDs to the incorrect tags. At the very least it is writing them differently than Picard, and I believe Picard is the reference standard.


The full tag mappings are here:
http://musicbrainz.org/doc/MusicBrainz_Picard/Tags/Mapping (http://musicbrainz.org/doc/MusicBrainz_Picard/Tags/Mapping)

As you can see, Picard tags Album ID in ID3v2.3 in "TXXX:MusicBrainz Album Id"
However, foo_musicbrainz tags Album ID to MUSICBRAINZ_ALBUMID

this also occurs with Artist IDs (though not Track IDs strangely)


This can be tested easily by tagging an album in foobar first with foo_musicbrainz, and then tagging the album again in Picard (make sure to not have it delete all prior tags before writing). You'll have redundant tags, with both "MUSICBRAINZ ALBUM ID" and "MUSICBRAINZ_ALBUMID" populated with the same data.

I'm not sure which is correct, but I would lean toward Picard. Regardless they should be doing the same thing.

What should I do if I want to adhere to musicbrainz standards?
Title: foo_musicbrainz
Post by: marc2003 on 2012-08-28 14:30:41
Does foo_musicbrainz write ID3v2.4 tags? If so, can it be changed to write ID3v2.3?


i don't use this but i'm guessing it uses the foobar core to write tags. check the settings under file>preferences>advanced>tagging>mp3>id3v2 revision and quirks.

(these days foobar writes id3v2.3 by default but if you've continuously upgraded from older versions it may have remembered the old default of using 2.4)
Title: foo_musicbrainz
Post by: skrech on 2013-01-12 14:33:20
Hey,
Does this plug-in do a fingerprint of the track? I think it should do, but I can't manage to find the option/button for this.
As it is written in the first post:
Quote
Fetches data by automatically calculated MusicBrainz Disc ID


The only musicbrainz related buttons are in RMB->Tagging->Get Tags From MusicBrainz (artist and album tags // musicbrainz album id). My understanding is that the music album id option should calculate the fingerprint and querry the server, but instead it just ask me to manually enter the ID. Is this the intended behaviour?
Title: foo_musicbrainz
Post by: jesus2099 on 2013-01-12 19:01:59
Just insert your cd and it will find it in MB instead of using FreeDB or CDDB for instance.
Title: foo_musicbrainz
Post by: soulsearchingsun on 2013-02-06 13:25:38
Does this plug-in do a fingerprint of the track? I think it should do, but I can't manage to find the option/button for this.
No, it doesn't. If you want full musicbrainz features, use Picard or any of the provided third party alternatives (see mb homepage).

Quote
Fetches data by automatically calculated MusicBrainz Disc ID
Yes, but only for lossless sources. You can't derive disc ID's from sources that don't preserve the 588 sample sector layout of Redbook-CDs, as do most (all?) lossy codecs.

My understanding is that the music album id option should calculate the fingerprint and querry the server, but instead it just ask me to manually enter the ID. Is this the intended behaviour?
Yes, as said above, the plugin doesn't support fingerprinting. Additionally you're misunderstanding said option. It only works if either the album ID is present already or you can provide it manually. Fingerprinting has nothing to do with album IDs, because fingerprinting can only identify tracks, not albums. It's up to the application to use a smart algorithm for clustering single tracks to albums.
Title: foo_musicbrainz
Post by: skrech on 2013-02-11 22:10:54
Thanks, soulsearchingsun

Title: foo_musicbrainz
Post by: dannymichel on 2013-08-10 06:30:09
Does this plugin still work? I'm getting "Nothing Found" even when i manually use the musicbrainz ID.
Title: foo_musicbrainz
Post by: marc2003 on 2013-08-10 06:38:56
it's working fine for me. i normally just use the artist/album lookup but i did a quick test of searching with the album ID and that worked ok as well.

are you definitely using the album ID and not release group?
Title: foo_musicbrainz
Post by: dannymichel on 2013-08-10 08:38:30
Yup
(http://thumbnails108.imagebam.com/26976/bf199b269751996.jpg) (http://www.imagebam.com/image/bf199b269751996) (http://thumbnails103.imagebam.com/26976/0acc61269751997.jpg) (http://www.imagebam.com/image/0acc61269751997) (http://thumbnails106.imagebam.com/26976/322803269751998.jpg) (http://www.imagebam.com/image/322803269751998) (http://thumbnails105.imagebam.com/26976/063344269752000.jpg) (http://www.imagebam.com/image/063344269752000) (http://thumbnails105.imagebam.com/26976/b79f4a269752003.jpg) (http://www.imagebam.com/image/b79f4a269752003) (http://thumbnails102.imagebam.com/26976/684862269752004.jpg) (http://www.imagebam.com/image/684862269752004)
Title: foo_musicbrainz
Post by: lvqcl on 2013-08-10 08:50:39
It is necessary to select all the tracks from an album.
Title: foo_musicbrainz
Post by: dannymichel on 2013-08-10 10:31:02
Thanks. I'll try that.
Title: foo_musicbrainz
Post by: Bratman on 2013-08-19 00:52:24
I don't get the point of this? seems just for people who have a ton of music with no/poor tags.
Title: foo_musicbrainz
Post by: db1989 on 2013-08-19 02:54:24
Quote
I don't get the point of this?
Quote
[states a main point of it]
Erm, OK then. Yes, foo_musicbrainz and similar are for people who, for whatever reason(s), feel their tags could be improved by an automatic look-up. Please do not portray a lack of interest to you as evidence of a lack of usefulness overall.
Title: foo_musicbrainz
Post by: dannymichel on 2013-08-19 08:33:34
I don't get the point of this? seems just for people who have a ton of music with no/poor tags.

MusicBrainz is a community of people who are dedicated to just the opposite. However, for me, it's a starting point. My first reference. I use it then check with rateyourmusic, discogs, then the back of the album cover. I started communities on Last.fm; according to Hoyle Tagger's Society, Foobar Audiophiles. I take my music seriously http://www.last.fm/user/lancerocke/journal...ble_artist_tags (http://www.last.fm/user/lancerocke/journal/2009/04/15/2neo2l_proper_or_acceptable_artist_tags) , as do they. Check my tags for yourslef buddy http://d.pr/f/sYHz (http://d.pr/f/sYHz)
Title: foo_musicbrainz
Post by: TheNeo75 on 2013-08-22 14:03:46
Hello, i have an issue with the musicbrainz plugin in foobar2000.


When it's import the informations from musicbrainz to foobar2000, some discs was replaced "feat." etc with a "," in the artist-field.

In Musicbrainz:  " Abc feat. def - songtitle" shows in foobar2000 as "Abc,def - songtitle".


I'm use the buildin foo_musicbrainz plugin. is it newer, older, or the same as the 0.3?
Title: foo_musicbrainz
Post by: marc2003 on 2013-08-22 14:34:19
they are 2 different things. the musicbrainz support built into foobar is only part of the CD rip dialog. if your problem is with that, this thread isn't the place to discuss it.

then you have this totally separate 3rd party component which is activated by right clicking selected files in a playlist and using the musicbrainz items under the tagging submenu.
Title: foo_musicbrainz
Post by: demonboy on 2014-03-11 12:41:15
Hi, nice plugin. Does it automatically scrape the album art and save it locally or will it only display the artist/album artwork whilst online? Whilst playing on random it's displaying an image for every track, but I can't find where it's saving them. If it's not saving them, is there an option to do so? I only ask because I am often not online, and rarely on a decent connection. Thanks.
Title: foo_musicbrainz
Post by: marc2003 on 2014-03-11 14:54:55
AFAIK, this component doesn't support downloading album art at all. whatever you're seeing is probably in the folder along side your audio files or embedded in it. double clicking the artwork panel should open explorer and locate it for you.

you might look at picard (http://musicbrainz.org/doc/MusicBrainz_Picard) if you want to download album art from musicbrainz. or there is album art downloader XUI (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392) which uses musicbrainz as just one of many sources,
Title: foo_musicbrainz
Post by: demonboy on 2014-03-12 13:15:31
AFAIK, this component doesn't support downloading album art at all. whatever you're seeing is probably in the folder along side your audio files or embedded in it. double clicking the artwork panel should open explorer and locate it for you.

you might look at picard (http://musicbrainz.org/doc/MusicBrainz_Picard) if you want to download album art from musicbrainz. or there is album art downloader XUI (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392) which uses musicbrainz as just one of many sources,


Thank you, I shall look into both your suggestions.
Title: foo_musicbrainz
Post by: TheEmpathicEar on 2014-07-24 00:57:09
AFAIK, this component doesn't support downloading album art at all. whatever you're seeing is probably in the folder along side your audio files or embedded in it. double clicking the artwork panel should open explorer and locate it for you.

you might look at picard (http://musicbrainz.org/doc/MusicBrainz_Picard) if you want to download album art from musicbrainz. or there is album art downloader XUI (http://www.hydrogenaudio.org/forums/index.php?showtopic=57392) which uses musicbrainz as just one of many sources,


I just started looking at this. Picard is a standalone tagging solution? And, it is not available as Foobar plug-in?
Title: foo_musicbrainz
Post by: Zarggg on 2014-07-24 21:06:36
Picard is a stand-alone tagging program written by MusicBrainz to access its database, yes.
Title: foo_musicbrainz
Post by: TheEmpathicEar on 2014-07-25 00:16:20
My example:
I have a bunch of albums tagged "Tom Petty & The Heartbreakers" and another bunch tagged as "Tom Petty & the Heartbreakers". WiKiPedia (http://wiki.hydrogenaud.io/index.php?title=Foobar2000:Titleformat_Reference) seems to suggest that the lowercase "the" is correct?
So, what's the best approach to changing this? Foobar built-in access to freedb? Musicbrainz plug-in? Or, a standalone solution?
Title: foo_musicbrainz
Post by: TheEmpathicEar on 2014-07-26 02:05:58
Well, no one jumped in here...

I went album to album using Tag&Rename changing "The" to "the". There must be a better way to do a conditional change like this?
Title: foo_musicbrainz
Post by: apastuszak on 2014-12-29 20:28:26
I've been using this tagger and have been quite happy with it.  Only problem I am having is with the "Original Release Date" tag.  I went to tag the 2013 remaster of Aladdin Sane by David Bowie.  The MusicBrainz window that pops up shows the original release date as 1973, but the tag is written as 2013.  Anyone else seeing this?
Title: foo_musicbrainz
Post by: marc2003 on 2015-01-02 09:36:06
edit: i completely missed the first release date box in the dialog. it does appear to be a bug that this is not written as the original date.
Title: foo_musicbrainz
Post by: lvqcl on 2015-01-02 09:54:20
In my case, the plugin shows "Date: 2007" and "First Release: 1994". Then it writes tags "DATE" and "ORIGINAL RELEASE DATE" that are both equal to 2007.

One may think that the value of the "ORIGINAL RELEASE DATE" tag should be equal to 1994.
Title: foo_musicbrainz
Post by: Lashiec on 2015-01-04 04:25:52
That's a bug Dremora fixed a long time ago (https://github.com/Dremora/foo_musicbrainz/commit/8154c9aa3e2f03bec1d1636c782082e889007de6). He just never got around to push a plugin update.
Title: foo_musicbrainz
Post by: Kuraj on 2015-01-18 22:44:46
That's a bug Dremora fixed a long time ago (https://github.com/Dremora/foo_musicbrainz/commit/8154c9aa3e2f03bec1d1636c782082e889007de6). He just never got around to push a plugin update.


I would build it myself but it doesn't compile against any of the 3 versions of the SDK available on http://www.foobar2000.org/SDK (http://www.foobar2000.org/SDK) :/
Title: foo_musicbrainz
Post by: lvqcl on 2015-01-18 23:18:45
I would build it myself but it doesn't compile against any of the 3 versions of the SDK available on http://www.foobar2000.org/SDK (http://www.foobar2000.org/SDK) :/

You also need WTL (http://wtl.sourceforge.net/) library.

Meanwhile I compiled this plugin using the sources from github. Try it if you want.
I pushed its version from 0.3 to 0.3.1.
Title: foo_musicbrainz
Post by: darklinkpower on 2015-01-29 06:32:16
Am I the only one having problems? I can't get it to work, neither by Album ID, Artist and album search and also TOC give me this error: Nothing found, I have tried with different songs/albums but it's the same, even with properly tagged files with musicbrainz tags an IDs, but it seems it's not working. Any clues why?
Title: foo_musicbrainz
Post by: marc2003 on 2015-01-29 12:26:44
it's working fine for me. do other internet features from within foobar work? for example, can you use the Help menu to check for new versions or updated components?
Title: foo_musicbrainz
Post by: darklinkpower on 2015-02-07 17:08:15
it's working fine for me. do other internet features from within foobar work? for example, can you use the Help menu to check for new versions or updated components?


yeah, working properly. sigh, I wonder what could be the problem
Title: foo_musicbrainz
Post by: marc2003 on 2015-02-07 17:55:07
are you selecting a whole album at once? the track count needs to match what is being asked for.
Title: foo_musicbrainz
Post by: lvqcl on 2015-02-07 22:23:15
"the track count needs to match", also the track order, and lengths of all tracks of an album.
Title: foo_musicbrainz
Post by: marc2003 on 2015-02-07 22:42:40
if you use the artist/album dialog, the component couldn't care less about existing tags/order/length. try it and see. you can type in any old album so long as the track count matches your selection.
Title: foo_musicbrainz
Post by: lvqcl on 2015-02-07 22:57:09
Yes, you are right. Apparently it only matters for "Get tags by TOC" command.
Title: foo_musicbrainz
Post by: fohrums on 2015-02-20 15:15:14
when using foo_musicbrainz I don't get the option to see the matching tracks that I have to the one presented for output. 

I went ahead and continued with an example album I have tested it with and the tracklisting was wrong.

Any options for matching the tracklist?
Title: foo_musicbrainz
Post by: fuffi on 2015-03-31 20:02:08
Am I the only one having problems?

Nope. I had tried it some years ago and it never did anything useful for me (unfortunately, I was too lazy to ask here, so I just blame myself for being too dumb).

Today, I tried it again with f2k 1.3.8 on Windows7 64Bit german language, but the result is just the same...
I was testing with 0.3 (from 2011) and the nicely offered 0.3.1 (from 2015).

All testing was done by selecting a single song, the whole album, or some random songs from it.

usecase1:
I go to the website https://musicbrainz.org/release-group/89dac...7da1950/details (https://musicbrainz.org/release-group/89dacf8b-51a3-3abd-84fa-df14b7da1950/details)
I copy the MBID 89dacf8b-51a3-3abd-84fa-df14b7da1950
I paste it in the "Query MusicBrainz by MBID" popup, it gives: Response from MusicBrainz: Not Found

usecase2:
I chose the "by TOC" thing.
it gives things like: Track length in samples must be divisible by 588.
and/or Response from MusicBrainz: Not Found

Funny thing btw,
I have bound a keyboard shortcut for this, because I never found this option in the f2k menus or context menus, but only in the Keyboard Shortcuts Dialogue.
After executing the usercase2, I go to the Keyboard Shortcuts Dialogue again and see Action not found E6B33D29-4C0C-47F2-A844-0488A6109FC0 on my bounded key......but the shortcut is working (anyhow...)

usercase3:
I chose "by Artist/Album".
I copy the Infos (i.e. "Ben Daglish" and "The Last Ninja") to the corresponding fields and it gives Nothing found.

So I got 3 different failures from the plugin while trying the 3 different ways it offers me.

I too think the usability is very inconvenient/poor in comarisson with the DiscoGS (http://www.foobar2000.org/components/view/foo_discogs), which is in development again (fortunately!). Autofilling the corresponding Tags into the "by Artist/Album" popup-fields, when available in the file, would be nice. Its 2015 :-) And while I'm listening to music from the 80s, I'd love to have the comfort of the actual time ;->

But instead of just complaining and whining, I'd like to ask somebody here to recheck/confirm my usercases, so I can be sure, its not my fault.
Maybe I'm doing something wrong or have no meeting dependencies.... I just don't know.

Cheers.


Title: foo_musicbrainz
Post by: lvqcl on 2015-03-31 20:43:59
But instead of just complaining and whining, I'd like to ask somebody here to recheck/confirm my usercases, so I can be sure, its not my fault.
Maybe I'm doing something wrong or have no meeting dependencies.... I just don't know.

Too exotic albums, IMHO.
Title: foo_musicbrainz
Post by: fuffi on 2015-03-31 20:57:18
But instead of just complaining and whining, I'd like to ask somebody here to recheck/confirm my usercases, so I can be sure, its not my fault. Maybe I'm doing something wrong or have no meeting dependencies.... I just don't know.

Too exotic albums, IMHO.
Hmmm....that album is listed on the MB site, so its known by MB.
Why should it be too exotic? 
That opinion doesn't make sense to me.
Title: foo_musicbrainz
Post by: lvqcl on 2015-03-31 21:10:40
Hmmm....that album is listed on the MB site, so its known by MB.

You mean "C64 Hits..." album? You posted the link to a "Release group". I don't know what it means, but apparently it's not an album.

The correct link is http://musicbrainz.org/release/463f2410-19...185985f/details (http://musicbrainz.org/release/463f2410-1958-4174-a3bb-63520185985f/details)  and its ID is 463f2410-1958-4174-a3bb-63520185985f
Title: foo_musicbrainz
Post by: fuffi on 2015-03-31 21:32:18
The correct link is http://musicbrainz.org/release/463f2410-19...185985f/details (http://musicbrainz.org/release/463f2410-1958-4174-a3bb-63520185985f/details)  and its ID is 463f2410-1958-4174-a3bb-63520185985f
Now your opinion makes sense to me %-)
I'm sorry for the confusion and thanks for pointing out! (the album name "C64 Hits, Volume 1: Back to the Roots" is the same on both of the links, so I guess, it shouldnt be a problem, tough)

Anyways, hopefully somebody will try my usercases and tell if its working the way its expected by the user.
Title: foo_musicbrainz
Post by: yeeeargh on 2015-03-31 23:44:10
usecase1:
I go to the website https://musicbrainz.org/release-group/89dac...7da1950/details (https://musicbrainz.org/release-group/89dacf8b-51a3-3abd-84fa-df14b7da1950/details)
I copy the MBID 89dacf8b-51a3-3abd-84fa-df14b7da1950
I paste it in the "Query MusicBrainz by MBID" popup, it gives: Response from MusicBrainz: Not Found

since lvqcl doesn’t know about this too … a release-group groups releases (duh) which are alike but not exactly the same. let’s say there is a normal version and a deluxe edition with some bonus tracks of the “same” release. both of them would be grouped together in this release-group. in case there would be a single or ep or something with the same name, but totally different content, it would go into a different release-group.

while it is understandable that you didn’t get any results while pasting the mbid of a release-group into a field which demands a release mbid, from a usability standpoint this isn’t great. it would be better if it would show all or at least some of the releases of this release-group the way it does for the other two query methods.

usecase2:
I chose the "by TOC" thing.
it gives things like: Track length in samples must be divisible by 588.
and/or Response from MusicBrainz: Not Found

Funny thing btw,
I have bound a keyboard shortcut for this, because I never found this option in the f2k menus or context menus, but only in the Keyboard Shortcuts Dialogue.
After executing the usercase2, I go to the Keyboard Shortcuts Dialogue again and see Action not found E6B33D29-4C0C-47F2-A844-0488A6109FC0 on my bounded key......but the shortcut is working (anyhow...)

that’s probably some technical thing concerning audio-cd formats or something. https://en.wikipedia.org/wiki/Compact_Disc_...o#Data_encoding (https://en.wikipedia.org/wiki/Compact_Disc_Digital_Audio#Data_encoding) at least that’s what I guess. i tried it with a few albums and it looks like the context menu entry wont be shown for files which don’t met this criteria. i don’t know if this is over-engineering in this case and i haven’t done a lookup with disids myself. anyway here’s the documentation for that part in case someone want’s to tinker with it: https://musicbrainz.org/doc/Development/XML...ersion_2#discid (https://musicbrainz.org/doc/Development/XML_Web_Service/Version_2#discid)

usercase3:
I chose "by Artist/Album".
I copy the Infos (i.e. "Ben Daglish" and "The Last Ninja") to the corresponding fields and it gives Nothing found.

that might be a release which isn’t added to the database yet. https://musicbrainz.org/artist/017495e8-ceb...?va=1&all=1 (https://musicbrainz.org/artist/017495e8-ceb1-4ce3-a025-af24ff73871f?va=1&all=1) at least it’s not listed on the page of the artist

I too think the usability is very inconvenient/poor in comarisson with the DiscoGS (http://www.foobar2000.org/components/view/foo_discogs), which is in development again (fortunately!). Autofilling the corresponding Tags into the "by Artist/Album" popup-fields, when available in the file, would be nice.

+1
just keep the feedback constructive. i would like to see this plugin getting some much needed maintenance/love  especially because of all those discogs shenanigans in the last few months.
and while i can’t help with programing – at least on a this level – if you do have any questions about the web service or the structure of mb data itself, just let me know
Title: foo_musicbrainz
Post by: marc2003 on 2015-04-01 09:15:16
All testing was done by selecting a single song, the whole album, or some random songs from it.


so much fail right here. the selection must match the release you're trying to lookup. how else could you possibly expect it to work? it could be one track if it's a single on MB but in most cases you'll be  looking up whole albums.

if looking up by TOC then the number of tracks AND length of tracks has to match. obviously they need to be in the right order too.

if looking up by artist/album then the only restriction is on the number of tracks. it won't care about track length or order so this is something you must manage yourself.

really this component is for albums that are in the right order with incomplete tags. it's not for managing cluster****s of files you might have.
Title: foo_musicbrainz
Post by: fuffi on 2015-04-01 11:25:22
Thank you for reading *and* clarifying some things here!
its now clear to me, that this component is too complicated and restricted for me.

so much fail right here.
yes, out of an ordinary view of a common user, this component could be less picky and more communicative, IMHO.

So the TOC thing works like the freedb component then, if I understand it correctly. Ok. Makes sence to me now.

Other things like "artist/album" should work simple too.

why does the user has to enter "artist/album" when the component is not able to give back a list with matches from the MB-DB?

From my point of view, the component should *support* the user who likes to tag his files.
support is something like helping with suggestions. or give hints how the userimput could be improved or more unerring.

if looking up by artist/album then the only restriction is on the number of tracks.

When I'd like to tag an album which has originally 12 tracks but I decided to delete 5 tracks from it, because I don't like to listen to the tracks anymore, does that mean, the component will not match my input of "artist/album" ? seems to limit the usage of the component way too much.

really this component is for albums that are in the right order with incomplete tags. it's not for managing cluster****s of files you might have.

Ok, thats a point now. I'd like to tag my files/music. And there are a lot of clustered albums I own. I.e. when buying music (mostly single tracks of an album) from iTunes/beatports/etc this component cannot help me.

Title: foo_musicbrainz
Post by: marc2003 on 2015-04-01 11:53:27
When I'd like to tag an album which has originally 12 tracks but I decided to delete 5 tracks from it, because I don't like to listen to the tracks anymore, does that mean, the component will not match my input of "artist/album" ? seems to limit the usage of the component way too much.


i don't think my previous post could have been any clearer. sorry to be so blunt but i think your expectations are ridiculous. 

good luck finding any other internet tagger that caters for your needs.
Title: foo_musicbrainz
Post by: Jalan on 2015-04-01 15:08:44
I'd like to tag my files/music. And there are a lot of clustered albums I own. I.e. when buying music (mostly single tracks of an album) from iTunes/beatports/etc this component cannot help me.
This - http://picard.musicbrainz.org/ (http://picard.musicbrainz.org/) - would accomplish that, would it not? Or is there some fundamental piece of information missing that prevents use of it for such a scenario? Beyond the obvious answer of some album/track/etc. not existing in Musicbrainz as a whole, which would not be the fault of the program.
Title: foo_musicbrainz
Post by: metal_termite on 2015-04-04 01:44:34
If anyone is willing to continue the development of this plugin, may I suggest the following features:

* Option to specifically toggle what tags the plugin writes (list of MusicBrainz tags (https://picard.musicbrainz.org/docs/tags/)). It currently does not write many available tags.
* A field in the option dialog to remap/merge the MusicBrainz tags to user specified tags, using titleformating.
Title: foo_musicbrainz
Post by: ForestD on 2015-07-22 23:13:11
This may seem odd but I've noticed that any songs with an apostrophe use a different apostrophe (’) than the one found on musicbrainz ('). Obviously not an issue in and of itself, but since I scrobble to last.fm the tags end up being wrong. Is there any way to fix it manually without having to change each individual apostrophe?
Title: foo_musicbrainz
Post by: marc2003 on 2015-07-23 01:27:14
file>preferences>tools>tagging>musicbrainz tagger>convert unicode punctuation characters to ascii
Title: foo_musicbrainz
Post by: ForestD on 2015-07-23 02:23:20
Simple as that. Thank you.
Title: foo_musicbrainz
Post by: neothe0ne on 2015-07-23 14:45:20
This may seem odd but I've noticed that any songs with an apostrophe use a different apostrophe (’) than the one found on musicbrainz ('). Obviously not an issue in and of itself, but since I scrobble to last.fm the tags end up being wrong. Is there any way to fix it manually without having to change each individual apostrophe?


I believe you're mistaken - MusicBrainz has an official policy of preferring (’) over (') (https://musicbrainz.org/doc/Style/Miscellaneous#Use_of_special_characters).  (I think this is stupid.)

foo_musicbrainz is therefore probably pulling in exactly what's found on MusicBrainz.
Title: foo_musicbrainz
Post by: MordredKLB on 2015-07-31 16:42:37
I believe you're mistaken - MusicBrainz has an official policy of preferring (’) over (') (https://musicbrainz.org/doc/Style/Miscellaneous#Use_of_special_characters).  (I think this is stupid.)

foo_musicbrainz is therefore probably pulling in exactly what's found on MusicBrainz.

I hate that preference so much. I wrote my own tagger which uses MB (outside of foobar so wouldn't be of interest to anyone else probably) and that was one of the first issues I fixed.
Title: foo_musicbrainz
Post by: megane68 on 2015-09-03 17:57:47
Instead, First release date <ORIGINAL RELEASE DATE>, duplicated <DATE>.
Title: foo_musicbrainz
Post by: lvqcl on 2015-09-03 20:56:13
Instead, First release date <ORIGINAL RELEASE DATE>, duplicated <DATE>.

See posts #204 - #206 (http://www.hydrogenaud.io/forums/index.php?s=&showtopic=70623&view=findpost&p=887441)
Title: foo_musicbrainz
Post by: megane68 on 2015-09-04 10:06:58
Instead, First release date <ORIGINAL RELEASE DATE>, duplicated <DATE>.

See posts #204 - #206 (http://www.hydrogenaud.io/forums/index.php?s=&showtopic=70623&view=findpost&p=887441)

Thank you!!!
Title: foo_musicbrainz
Post by: Dremora on 2015-11-23 21:35:49
Hi everyone! You've probably noticed that there was no updates in the last couple of years to foo_musicbrainz. The explanation is quite simple: I have switched from Windows to Mac, and from foobar2000 to cloud-based music players. I should have announced this mush earlier, but better late than never: I won't be supporting this plugin anymore. The good news is that the source code is on Github (https://github.com/Dremora/foo_musicbrainz), and whoever wants to take ownership of the project will get my blessing.
There's actually an unreleased patch (on the master branch on Github), so simply building and releasing the new version with this patch would mark a new beginning
Title: foo_musicbrainz
Post by: kode54 on 2015-11-24 09:45:45
Meanwhile, I experimented with Hackintosh on my previous desktop, which is now a dedicated Windows machine, and moved to a Retina 5K iMac, where I use OS X most of the time now.

But I pay about $84/mo for a Windows VPS with a Visual Studio license, so I can continue to maintain my Windows projects, regardless of which operating system or computer I am using, or even wherever I happen to be in the world at the time. Which shows dedication, considering I probably have pumped out about 5-10 updates since switching to this system many months ago. Expensive, but I can currently afford my expenses.
Title: foo_musicbrainz
Post by: marc2003 on 2015-11-24 10:55:48
There's actually an unreleased patch (on the master branch on Github), so simply building and releasing the new version with this patch would mark a new beginning


lvqcl has already provided a component built from master some months ago..

https://www.hydrogenaud.io/forums/index.php...st&p=887441 (https://www.hydrogenaud.io/forums/index.php?s=&showtopic=70623&view=findpost&p=887441)
Title: foo_musicbrainz
Post by: Dremora on 2015-11-24 15:44:51
Meanwhile, I experimented with Hackintosh on my previous desktop, which is now a dedicated Windows machine, and moved to a Retina 5K iMac, where I use OS X most of the time now.

But I pay about $84/mo for a Windows VPS with a Visual Studio license, so I can continue to maintain my Windows projects, regardless of which operating system or computer I am using, or even wherever I happen to be in the world at the time. Which shows dedication, considering I probably have pumped out about 5-10 updates since switching to this system many months ago. Expensive, but I can currently afford my expenses.

It's good that you are dedicated to the software you've written. However, the fact that I'm not using the plugin or foobar2000 anymore made me realise it would be better for someone else from the community to take over. Even if I were to continue maintaining the plugin I wouldn't be able to put as much effort into it as someone who's actually using it.

lvqcl has already provided a component built from master some months ago..

https://www.hydrogenaud.io/forums/index.php...st&p=887441 (https://www.hydrogenaud.io/forums/index.php?s=&showtopic=70623&view=findpost&p=887441)

Good, didn't know about that!
Title: foo_musicbrainz
Post by: marc2003 on 2015-11-24 16:30:15
Since I forgot to say it in my last post, thanks for the making the component. I like the consistency it offers compared to picard when handling files with different tag specifications.
Title: foo_musicbrainz
Post by: Dremora on 2015-11-25 13:24:28
Since I forgot to say it in my last post, thanks for the making the component. I like the consistency it offers compared to picard when handling files with different tag specifications.

You're most welcome!
Title: foo_musicbrainz
Post by: Dremora on 2015-12-07 10:04:45
I've updated the component to 0.3.1 using the build provided by lvqcl.
Title: foo_musicbrainz
Post by: marc2003 on 2015-12-08 05:54:15
If anyone is interested, I've made some minor tweaks to the main dialog. I've added country to the date column and increased the height a tiny bit just so we can see 12 tracks without a scrollbar.

(http://i.imgur.com/OeBuUTN.png)

https://github.com/19379/foo_musicbrainz/releases (https://github.com/19379/foo_musicbrainz/releases)

The changes can be viewed in this commit: https://github.com/19379/foo_musicbrainz/co...3a13b48a80eb5a6 (https://github.com/19379/foo_musicbrainz/commit/585fdd94eb31f992f43dc39f03a13b48a80eb5a6)

At least Windows Vista and foobar2000 v1.3 is required. I've bumped the version to 0.3.2.
Title: foo_musicbrainz
Post by: marc2003 on 2015-12-09 00:22:39
I've tried compiling this with VS2015 Update 1 to support Windows XP but for some reason the date and first release date aren't showing??

)

date (doesn't work with XP)
Code: [Select]
uSetWindowText(date, static_cast<pfc::string8>(release->get_date()));


album (works with XP)
Code: [Select]
uSetWindowText(album, release->get_title());


Any ideas??



Title: foo_musicbrainz
Post by: zeremy on 2015-12-10 10:35:41
I've tried compiling this with VS2015 Update 1 to support Windows XP but for some reason the date and first release date aren't showing??

Any ideas??


Compiled with VS2010 it works fine in XP / win10.
https://www.dropbox.com/s/njjm8zzhjuka1yr/f...brainz.dll?dl=0 (https://www.dropbox.com/s/njjm8zzhjuka1yr/foo_musicbrainz.dll?dl=0)

I can't though help you why it doesn't in VS2015.
I'm a complete beginner .   

(http://i.imgur.com/qpHLOwP.png)
Title: foo_musicbrainz
Post by: metal_termite on 2015-12-11 04:54:02
I believe this plugin is writing MusicBrainz IDs to the incorrect tags. At the very least it is writing them differently than Picard, and I believe Picard is the reference standard.


The full tag mappings are here:
http://musicbrainz.org/doc/MusicBrainz_Picard/Tags/Mapping (http://musicbrainz.org/doc/MusicBrainz_Picard/Tags/Mapping)

As you can see, Picard tags Album ID in ID3v2.3 in "TXXX:MusicBrainz Album Id"
However, foo_musicbrainz tags Album ID to MUSICBRAINZ_ALBUMID

this also occurs with Artist IDs (though not Track IDs strangely)


This can be tested easily by tagging an album in foobar first with foo_musicbrainz, and then tagging the album again in Picard (make sure to not have it delete all prior tags before writing). You'll have redundant tags, with both "MUSICBRAINZ ALBUM ID" and "MUSICBRAINZ_ALBUMID" populated with the same data.

I'm not sure which is correct, but I would lean toward Picard. Regardless they should be doing the same thing.

What should I do if I want to adhere to musicbrainz standards?


I have just noticed this too, all the tags are mapped differently, and I'm not sure if or how this affects other software that reads MusicBrainz tags, such as Beets. I suspect the fix [assuming the fb2k plugin is incorrectly mapping the tags] is to make a fb2k masstagger script. For example, to remap the MUSICBRAINZ_ALBUMID tag:

Format value from other fields where destination field name is MUSICBRAINZ ALBUM ID, and the formatting pattern is %MUSICBRAINZ_ALBUMDID%. Then add another action to the script to remove the MUSICBRAINZ_ALBUMID field. I would repeat the same thing in the same script for each tag, and attach the masstagger script to a keyboard shortcut. At least that would make remapping the MusicBrainz tags painless.

Title: foo_musicbrainz
Post by: Dremora on 2015-12-12 03:48:09
I have just noticed this too, all the tags are mapped differently, and I'm not sure if or how this affects other software that reads MusicBrainz tags, such as Beets. I suspect the fix [assuming the fb2k plugin is incorrectly mapping the tags] is to make a fb2k masstagger script. For example, to remap the MUSICBRAINZ_ALBUMID tag:

Format value from other fields where destination field name is MUSICBRAINZ ALBUM ID, and the formatting pattern is %MUSICBRAINZ_ALBUMDID%. Then add another action to the script to remove the MUSICBRAINZ_ALBUMID field. I would repeat the same thing in the same script for each tag, and attach the masstagger script to a keyboard shortcut. At least that would make remapping the MusicBrainz tags painless.

This is by design. I've used names from the “Internal name” column from Picard documentation.
Picard establishes mappings between these internal names (what is shown to the user in Picard) and how the tags are actually stored. The names of stored tags are dependant on the tag format — for instance, musicbrainz_trackid is stored as TXXX:MusicBrainz Release Track Id in id3 and as MusicBrainz/Release Track Id in Windows Media. Unfortunately, it's impossible to override these mappings in foobar2000. That is, if you open a Picard-tagged file in foobar2000, you'll see different tags depending on the tag format. In case of ID3, foobar2000 will display TXXX:MusicBrainz Album Id as MusicBrainz Album Id (because it's not aware that it should be called musicbrainz_albumid), but in case of APE it will show MUSICBRAINZ_ALBUMID as it is. This is not helpful for titleformat scripts. Even worse, certain tags won't even be readable in fb2k, such as (I believe) UFID:http://musicbrainz.org in ID3.
Title: foo_musicbrainz
Post by: zeremy on 2015-12-12 18:29:41
For those who have setup a musicbrainz mirror server ( as described @ https://musicbrainz.org/doc/MusicBrainz_Server/Setup (https://musicbrainz.org/doc/MusicBrainz_Server/Setup) ) here is a modified version to use it.
The server's address must be http://musicbrainzvm:5000/ (http://musicbrainzvm:5000/)

https://www.dropbox.com/s/ygbdw882flmmbno/f...inz_vm.dll?dl=0 (https://www.dropbox.com/s/ygbdw882flmmbno/foo_musicbrainz_vm.dll?dl=0)

(http://i.imgur.com/HUW1K2e.png)
Title: Re: foo_musicbrainz
Post by: oyvindo on 2016-03-24 18:02:36
Why is it that I get the error message 'MusicBrainz Server is busy, try again later' about 85% of the times I try to use the tagger?
If I keep on trying over and over again and again on the same album, eventually, it will work in the end (I did this just to test), but surely it isn't meant to be this bad?  If I try with Picard, it hits dead on 99% of the time, but I find FB2k preferable for many other reasons.
I have a feeling the script is not tuned properly or something? At least, the error message is not accurate as the MusicBrainz server definitely is not that busy - always.

Ideas anyone?
Title: Re: foo_musicbrainz
Post by: innou on 2016-03-24 18:19:34
At least, the error message is not accurate as the MusicBrainz server definitely is not that busy - always.

What makes you think so? The plugin uses MB API which might have its own level of service, including "busy 85% of time" for particular requests. You can't know for sure the problem is solely at the client side.

It might be, however, that API usage pattern employed by the plugin is suboptimal. This can lead to the situation when requests are dropped by the server.
Title: Re: foo_musicbrainz
Post by: oyvindo on 2016-03-25 12:44:59
What makes you think so? The plugin uses MB API which might have its own level of service, including "busy 85% of time" for particular requests. You can't know for sure the problem is solely at the client side.
I agree, I can't know for sure. The reason I said that, is because if I turn to Picard, I almost never ever get a server busy error, while in Foobar I get this most of the time. Doesn't that lead you to think the problem is on the client side?
Title: Re: foo_musicbrainz
Post by: oyvindo on 2016-03-25 12:49:59
When using this "tagger", I discover that most of the time the field "Album Artist" is deleted (or filled with "nothing"). In addition, leading zeroes in the track numbers are stripped. This is annoying, cause it takes too much effort to edit and correct these things after tagging. Is this behaviour a client side effect, or is it because all fields are filled with whatever it finds at MB? (regardless of whether a tag that already holds data is overwritten with nothing (deleted)?
Is there a way to modify/configure this whithout having to modify the actual code of the plugin by me (as I am no programmer)?
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-03-25 13:07:26
Album artist is only written when it is necessary - that is when each track has a different artist. There is no need for it on single artist albums. If I buy music from amazon and this tag is filled, I clear it.

As for tracknumbering, that will behave exactly the same as if you used to foobar to auto-track number - no leading zeroes. I'm sure foobar is following whatever the recommended specs are for all the different tag types it supports.

Also, I had a quick poke around the source and it looks the value is coming from whatever position the track is in...

https://github.com/Dremora/foo_musicbrainz/blob/ca2afd28d97cf3ffd76d607020dcf6b9d569ffe2/FileTagMap.cpp#L24L25
Title: Re: foo_musicbrainz
Post by: innou on 2016-03-25 13:23:33
I agree, I can't know for sure. The reason I said that, is because if I turn to Picard, I almost never ever get a server busy error, while in Foobar I get this most of the time. Doesn't that lead you to think the problem is on the client side?

When there are two or more interacting parties, the quirks at each side might lead to cumulative effect which is unexpected.
Title: Re: foo_musicbrainz
Post by: innou on 2016-03-25 13:25:42
Album artist is only written when it is necessary - that is when each track has a different artist. There is no need for it on single artist albums.

I don't agree. It is common and natural practice for media library to list albums using Album Artist.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-03-25 13:30:52
That's what foobar2000 title formatting is for. Using %album artist% displays the album artist tag if it is present and falls back on artist if it isn't.

http://wiki.hydrogenaud.io/index.php?title=Foobar2000:Title_Formatting_Reference#.25album_artist.25

If you don't like that sort of thing, you can always use custom views with $meta(album artist) which will only display the actual tag contents.
Title: Re: foo_musicbrainz
Post by: innou on 2016-03-25 13:44:00
I didn't mean only foobar2000. It was about common practice (and sense, if you wish).
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-03-25 13:49:17
Even the evil that is itunes and windows media player have no problems following the same conventions. They will group by album artist if present and use artist if it is missing.

You can see that here (just ignore the fact WMP has no concept of discnumbers  ::) )

(https://i.imgur.com/xrFivgk.png)
Title: Re: foo_musicbrainz
Post by: innou on 2016-03-25 13:50:52
Good for them.
Title: Re: foo_musicbrainz
Post by: Dremora on 2016-03-26 12:45:48
Why is it that I get the error message 'MusicBrainz Server is busy, try again later' about 85% of the times I try to use the tagger?
If I keep on trying over and over again and again on the same album, eventually, it will work in the end (I did this just to test), but surely it isn't meant to be this bad?  If I try with Picard, it hits dead on 99% of the time, but I find FB2k preferable for many other reasons.
I have a feeling the script is not tuned properly or something? At least, the error message is not accurate as the MusicBrainz server definitely is not that busy - always.

Ideas anyone?

This might be the issue with the plugin. MusicBrainz API has a limit of 1 request per second, which, when I started working on the plugin, didn't seem to be enforced (or perhaps calculated in a different way, e.g. with a longer sliding window), so I didn't implement this. As far as I remember, each release is fetched in a separate request (at least for certain types of search). This could be the reason for the API returning its status as busy.

I can't provide you with a solution unfortunately, as I don't maintain this plugin anymore, and no one so far has stepped up to take over it.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-03-26 13:10:47
I just tested my own script which fetches release group info for a given MB artist id and hit the busy message on my very first request. Subsequent retries are 50/50. Because I have cached data for most artists in my collection, I didn't notice it until now.

Clearly MB have some issues that need addressing at the moment. I will go check their forums/tickets/docs to see if I can find out any more.

edit: It seems they have a global limit for everyone to share so if this is being hit, I guess they aren't going to do anything about it??

Quote
We allow through 300 requests each second (on average), and decline (http 503) the rest.

edit2: Just got a dump of the response headers on a 503 response. I guess that last line is the issue...

Code: [Select]
Date: Sat, 26 Mar 2016 13:33:04 GMT
Content-Type: application/json; charset=utf-8
Content-Length: 81
Connection: keep-alive
Keep-Alive: timeout=15
Server: nginx/1.4.6 (Ubuntu)
ETag: "d16d9f06dc7063a665e0dcb2ce1c62b5"
Access-Control-Allow-Origin: *
X-Rate-Limited: 2500.1 2500.0 10
Title: Re: foo_musicbrainz
Post by: zeremy on 2016-03-26 16:25:12
FYI

http://musicbrainz.org/doc/XML_Web_Service/Rate_Limiting
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-03-27 05:36:21
Yes, the quote in my previous post about the global limit being surpassed came from that page.

I can tell it's the global limit and not an issue with any one user-agent from looking at their source code.

https://github.com/metabrainz/musicbrainz-server/blob/bda94b26672a8f645fa1a6947d57d9be2f278b9f/lib/MusicBrainz/Server/ControllerBase/WS/2.pm#L75L89
Title: Re: foo_musicbrainz
Post by: Dremora on 2016-03-27 17:52:44
It might be the case that upon receiving such response from a server, Picard retries after a short while. No such logic is present in foo_musicbrainz.
Title: Re: foo_musicbrainz
Post by: oyvindo on 2016-04-02 19:12:57
I can't provide you with a solution unfortunately, as I don't maintain this plugin anymore, and no one so far has stepped up to take over it.
Why did you stop maintaining this fine plugin? What should we be using instead?
Title: Re: foo_musicbrainz
Post by: Dremora on 2016-04-04 18:20:36
I've stopped maintaining the plugin because I've stopped using Windows and foobar2000. The plugin is open source though, so I still hope that someone will take over. Until this happens, you can still use the plugin as it is, since it does its job.
Title: Re: foo_musicbrainz
Post by: jesus2099 on 2016-04-04 18:50:50
I tried to go on with the code but I didn’t manage with the environment, I tried a free dot net IDE, and tried and tried, but I was really clueless, unfortunately...
Title: Re: foo_musicbrainz
Post by: Fladder72 on 2016-05-08 13:00:06
I've stopped maintaining the plugin because I've stopped using Windows and foobar2000. The plugin is open source though, so I still hope that someone will take over. Until this happens, you can still use the plugin as it is, since it does its job.
Sad to hear. Because actualy I almost got "Error parsing XML."...
Title: Re: foo_musicbrainz
Post by: Intruder66 on 2016-05-08 14:46:47
Yes, sadly broken, works about one out of 20 times. "Error parsing XML." or "MusicBrainz server busy."
Unfortunately I am not experienced enough to fix it on my own...
Title: Re: foo_musicbrainz
Post by: foosion on 2016-05-08 18:38:14
I agree, I can't know for sure. The reason I said that, is because if I turn to Picard, I almost never ever get a server busy error, while in Foobar I get this most of the time. Doesn't that lead you to think the problem is on the client side?
The reason might be that the level of service is different for different applications. This might include rate limiting (https://musicbrainz.org/doc/XML_Web_Service/Rate_Limiting), i.e. restricting the number of requests per time interval. Since Picard is MusicBrainz' own tagger it might have a higher rate limit than third party applications or it might be smarter about spreading them out to stay below the rate limit.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-08 19:39:53
I don't think picard is getting any special treatment. There are users here having problems...

https://community.metabrainz.org/t/rate-limiter-has-changed/14253/7

It's just that overall API usage has increased beyond what they can currently handle.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-10 01:09:50
I've compiled an updated component which allows you to set a custom server in the preferences.

(https://i.imgur.com/Iulr1eM.png)

A couple of different ones to try...

Code: [Select]
http://beta.musicbrainz.org
http://musicbrainz-mirror.eu:5000

Requires Vista or above and foobar2000 v1.3 or above.

https://github.com/19379/foo_musicbrainz/releases

I don't have the skills to make it retry but if anyone else fancies it, I've added all the pre-requisites to my github repo so it should compile with VS2015 as-is.
Title: Re: foo_musicbrainz
Post by: zeremy on 2016-05-10 11:09:23
Well done marc2003.

Here is another mirror to try :
Code: [Select]
http://musicbrainz.fin-alice.de:5000/

p.s. You might consider adding the option to select a server in your js scripts also... instead of you know...
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-10 11:41:16
p.s. You might consider adding the option to select a server in your js scripts also... instead of you know...

I haven't bothered because it retries up to 5 times and is mostly successful.

And thanks for the mirror whether it's yours or just one you know of. More choice is always good.

edited: some wrong info removed.

another edit: just realised the uploaded DLL didn't have the version number bumped. It's been updated but no functional change.
Title: Re: foo_musicbrainz
Post by: zeremy on 2016-05-10 12:15:07

And thanks for the mirror whether it's yours or just one you know of. More choice is always good.


The mirror is not mine.
My crappy DSL connection forbids me to share my VM mirror.

edit: I'm on a Non-commercial / Personal usage of metabrainz.
https://metabrainz.org/supporters/account-type
Title: Re: foo_musicbrainz
Post by: Intruder66 on 2016-05-10 21:42:10
Thanks marc2003, works like a charm!
Is there a list of public musicbrainz mirrors others than the ones you two mentioned?
Title: Re: foo_musicbrainz
Post by: jesus2099 on 2016-05-11 04:04:08
Hi Marc2003.
It is great that you achieved to fork and compile!
Shouldn't we PR back to Dremora, so that we would keep enhancements and so the official component would be updated and also visible by all foobar2000 users?
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 01:51:30
Dremora might find my requirements are too restrictive and depending on how the components site/update mechanism works, it may break for people running older versions of foobar2000 or are on windows XP.

I did mention before that Vista or later and foobar2000 v1.3 or later are required but I didn't explain why. Here is my reasoning...

Quote from: https://github.com/19379/foo_musicbrainz/blob/master/README.md
Remove deprecated metadb lock/unlock methods and use get_info_ref() from the
current SDK (2015-08-03). Now requires foobar2000 v1.3 or above.

Updated for Visual Studio 2015. I tried building to support Windows XP but failed
therefore Windows Vista or later is required.

I'm sure someone competent could make it work on XP but I'm a total noob whose main area of expertise is copy/paste!!
Title: Re: foo_musicbrainz
Post by: kode54 on 2016-05-12 03:15:20
Compiling for XP is supposed to be as easy as changing the SDK from v120 to v120_xp, but there's no guarantee that it will work. And even then, I had problems getting foo_midi to even build a crash-free binary, so I switched back to using 2010.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 04:03:47
Yep, I did try that and while the component loaded fine, not everything would display properly in the main dialog. I did take a screenshot but the link appears to have been lost in the forum upgrade.

https://hydrogenaud.io/index.php/topic,70623.msg912619.html#msg912619

edit: Being the buffoon I am, I didn't even check if the values were populated. If not, that would be a more serious underlying issue that I would have even less chance of fixing. Anyway, isn't it about time foobar itself dropped support for XP?  :D

Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 06:38:06
Just a little more confirmation of my incompetence!

Quote
0.3.3.1
Fix bug where the "Apply" button in the "Preferences" didn't become active when the
"Custom server" checkbox state had changed.

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: jesus2099 on 2016-05-12 08:24:47
Dremora might find my requirements are too restrictive and depending on how the components site/update mechanism works, it may break for people running older versions of foobar2000 or are on windows XP.

Oh yes, sure, indeed.
As a matter of fact, I do use XP. :)
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 10:14:28
I'll try setting up an XP virtual machine and see if I get anywhere but I highly doubt it.

Also, I have yet another update.....and this time, it's not my fault. This bug is present in the original component.

Quote
0.3.3.2
Fix bug where "Reset page" button in the "Preferences" didn't work on all fields.

https://github.com/19379/foo_musicbrainz/releases

Specifically, if you disable the album type/status checkboxes, the text boxes remain disabled when you reset.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 11:20:18
Right, the problem I'm having with XP seems directly linked to using this static_cast thingy...

Code: [Select]
static_cast<pfc::string8>(release->get_date())

It works with VS2010 and any OS.
It works with VS2015 and Vista or later
With VS2015 and XP, the value gets nuked.

All other fields which don't need it show up correctly.

http://i.imgur.com/PmNxTcs.jpg

I have no idea how to fix that so if anyone has any ideas??
Title: Re: foo_musicbrainz
Post by: lvqcl on 2016-05-12 17:18:05
Maybe this will help?
http://forum.doom9.org/showthread.php?p=1763240#post1763240
Quote
Unfortunately, XP support is partialy broken in VS2015, and it's still the case with Update 2.
 For having a proper support of XP, as it's explained here (https://connect.microsoft.com/VisualStudio/feedback/details/1789709/visual-c-2015-runtime-broken-on-windows-server-2003-c-11-magic-statics), you have to compile with the /Zc:threadSafeInit- option, otherwise it will not work.
also:
https://msdn.microsoft.com/en-us/library/y5f6w579.aspx
http://stackoverflow.com/questions/32517234/access-violation-on-static-initialization

but seriously, just let WinXP die.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 17:59:04
That has done the trick (https://i.imgur.com/x1l0tfN.png), thanks.

I've already kicked XP to the kerb with my own component but I thought I'd give this one last try.


Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-05-12 19:12:27
Quote
0.3.4
Restore Windows XP support with /Zc:threadSafeInit- compiler option.

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: NoahTheDuke on 2016-05-13 03:58:39
Thanks for all the hard work, marc2003. Much appreciated.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-06-02 07:29:05
Quote
0.3.5
Defaults to https.

Display a more helpful message when errors occur.

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: kitzik on 2016-06-07 14:26:57
Thanks, marc2003! Is it possible to force http somehow? I work behind corporate http-proxy, it doesn't allow https traffic from unknown  sources (I if understand correctly, anyway https-version of plugin doesn't work for me anymore)
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-06-07 15:35:22
Sure. Just use the custom server option in the preferences...

(https://i.imgur.com/Iulr1eM.png)
Title: Re: foo_musicbrainz
Post by: noiselab on 2016-08-08 00:49:13
When trying to retrieve tags by TOC for Opus files, this comes up: "Track length in samples must be divisible by 588."

Can support for Opus files (sample rate at 48000Hz) be implemented for retrieving tags by TOC?
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-08-09 12:08:05
What version are you using?

In the last official component and source for my mod, I see the code for popup dialog in the source but I don't see how it gets triggered because there are other checks in place that won't even show the TOC menu items when any track length in samples isn't divisible by 588.
Title: Re: foo_musicbrainz
Post by: noiselab on 2016-08-10 02:04:34
The most recent one from you, 0.3.5. And 0.3.1 before that.

The only thing I can surmise is that this plugin is incompatible with files at sample rates of 48,000Hz, and any other files at sample rates not divisible by 588. And AFAIK, Opus is 48,000Hz by default.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-08-10 11:44:09
I can attempt to make it work but I don't understand how you were getting the error you reported because when I right click any tracks with a 48000 sampling rate, the TOC menu items are hidden...

(https://i.imgur.com/R4lw9cr.png)
Title: Re: foo_musicbrainz
Post by: noiselab on 2016-08-10 23:43:58
Oh sorry, I see what you mean now. I've always been using a custom keyboard shortcut for the action "Get tags from MusicBrainz (by TOC).

I just noticed that getting tags by TOC seems to only work for Vorbis and FLAC. MP3 or AAC trigger "Track length in samples must be divisible by 588", regardless of sample rate.

Thanks for the effort you're putting in!
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-08-11 00:44:39
Ah yes, that explains it. I should be able to fix this but it won't be immediately. I'm spending a lot of my spare time watching the Rio Olympics on TV!!
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-08-11 08:56:14
MP3 or AAC trigger "Track length in samples must be divisible by 588", regardless of sample rate.

This should not happen if they are sourced from CD rips. I'm not able to test any AAC at the moment but I have mp3 albums which work fine. You can search your collection to find lossy files that would allow TOC lookups with this query

Code: [Select]
%__encoding% IS lossy AND "$mod(%length_samples%,588)" IS 0

If I use this query to find tracks that I can't lookup, most of mine are from amazon/itunes.

Code: [Select]
%__encoding% IS lossy AND NOT "$mod(%length_samples%,588)" IS 0

These shouldn't be on musicbrainz because it is for CD sourced discids only. In fact, the next version will only allow TOC submissions from lossless files.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-08-11 09:46:55
Well I did it quicker than expected.

Code: [Select]
0.3.6

Allow TOC lookups from files with a sample rate of 48000 Hz such as Opus. Track sample
count must still match CD frame boundaries.

Enforce stricter checks for TOC submissions so only lossless files are supported. This
affects MusicBrainz editors only.

Prevent background lookups if above TOC checks fail.

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: noiselab on 2016-08-11 10:06:33
Thanks so much! This update is very helpful and saves me so much time

MP3 or AAC trigger "Track length in samples must be divisible by 588", regardless of sample rate.

This should not happen if they are sourced from CD rips. I'm not able to test any AAC at the moment but I have mp3 albums which work fine. You can search your collection to find lossy files that would allow TOC lookups with this query
You're right; the files need be sourced from CDs. That makes sense.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-08-11 16:00:56
Code: [Select]
0.3.6.1
Ensure sample rate of all tracks are identical for TOC lookups.

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: kitzik on 2016-12-19 07:27:34
Somehow Musicbrainz context menu doesn't show up for releases with more than 99 tracks
Title: Re: foo_musicbrainz
Post by: marc2003 on 2016-12-23 04:29:25
@kitzik, yes it was intentional, presumably based on the max number of tracks a CD supports. Since digital releases can contain many more tracks, I've removed the restriction.

Quote
0.3.7
Remove 99 track limit for artist/album and MBID lookups.

https://github.com/19379/foo_musicbrainz/releases

Windows XP users will need to add musicbrainz.org under File>Preferences>Advanced>Networking>Suppress HTTPS certificate checks for domains.

Title: Re: foo_musicbrainz
Post by: kitzik on 2016-12-23 12:31:30
Thank you, marc  ;D
Title: Re: foo_musicbrainz
Post by: tanjidoor on 2017-01-05 14:31:15
Please add support for custom label, catalog number, and barcode tag! We can set one already for album type and album status, so it'll be nice to have the same for the rest! Thank you! Amazing component!
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-01-06 09:53:22
It would be easy enough to add but I'm not sure there is any need for this. I guess the reason this option exists for album type is because Picard can use entirely different names depending on file type but the name is always consistent for label, barcode and catalognumber. I'll think about it.
Title: Re: foo_musicbrainz
Post by: jesus2099 on 2017-01-24 08:47:33
Marc2003, Dremora,
It wouldn’t be possible to merge all the stuff back to original plugin (https://github.com/Dremora/foo_musicbrainz) at some point ?
Enabling the update from foobar2000, etc. ?
I don’t feel confortable installing from another place.
I should really try though, but I’m unsure what issues (https://github.com/Dremora/foo_musicbrainz/issues) are fixed or not, etc.
What would prevent Marc’s latest version to be a pull request for Dremora’s, fixing some open issues at the same time ?
Title: Re: foo_musicbrainz
Post by: lvqcl on 2017-01-24 10:29:15
Why should marc2003 develop the plugin in the way you like?
Title: Re: foo_musicbrainz
Post by: zeremy on 2017-01-24 11:03:38
Hi everyone! You've probably noticed that there was no updates in the last couple of years to foo_musicbrainz. The explanation is quite simple: I have switched from Windows to Mac, and from foobar2000 to cloud-based music players. I should have announced this mush earlier, but better late than never: I won't be supporting this plugin anymore. The good news is that the source code is on Github (https://github.com/Dremora/foo_musicbrainz), and whoever wants to take ownership of the project will get my blessing.
There's actually an unreleased patch (on the master branch on Github), so simply building and releasing the new version with this patch would mark a new beginning
Title: Re: foo_musicbrainz
Post by: jesus2099 on 2017-01-24 12:59:24
Thanks for your citation, zeremy.
Maybe marc2003 could take ownership of the project ?
Dremora said that.
It was the meaning of my question and I did remember what Dremora said.

Or if it cannot be, maybe link marc2003’s code to foobar2000’s auto‐updating component system (http://www.foobar2000.org/components/view/foo_musicbrainz) instead of Dremora’s, with both person’s agreement.

It’s not just the way I like, lvqcl, it’s the usual way foobar2000 components run.

:)
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-01-24 15:53:14
I don’t feel confortable installing from another place.

I've had an account on these forums for 12 years and as you know from having your own repositories on github, every single change I've made is viewable via the commit history...

https://github.com/19379/foo_musicbrainz/commits/master

If that's not enough to earn your trust, so be it.



Title: Re: foo_musicbrainz
Post by: jesus2099 on 2017-01-24 16:16:34
Sorry it’s not that I don’t trust you.
Confortable was probably not well translated.
I meant convenient.
The components update automatically and are publically visible, if they are in the official components page.
I thought it was a pity to publically promote an outdated version and not providing easy update to your fixed versions.
Title: Re: foo_musicbrainz
Post by: tanjidoor on 2017-02-09 01:30:04
It would be easy enough to add but I'm not sure there is any need for this. I guess the reason this option exists for album type is because Picard can use entirely different names depending on file type but the name is always consistent for label, barcode and catalognumber. I'll think about it.

This actually makes more sense, and as I personally have followed foo_mb's standard tag for them instead of my own now I don't think it matters anymore for me :D

Anyways is it also possible to fetch (and write) the metadata for release media, like Vinyl/CD/Cassette/Digital? Being able to write the "country of origin" metadata, like DE/US/XE might also be helpful.

Thanks again for everything!
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-02-09 03:32:37
Handling the country should be easy enough because it's already displayed in the tagger dialog. Looking at the existing code, I think writing it to tags should be easy enough.

As for the media type, that's more tricky because it doesn't exist as a supported field and I'm not sure how to add new ones. I can try but I'm not sure I'll get very far.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-02-09 15:20:39
Quote
0.3.8
Add preferences to write release country (RELEASECOUNTRY) and release format (MEDIA).
They're both enabled by default so check File>Preferences>Tools>Tagging>
MusicBrainz Tagger if you wish to turn them off.

https://github.com/19379/foo_musicbrainz/releases

edit: I'm only realising now there is no way to view the MEDIA tag before it is written. I'll tweak the tagger dialog so it's visible in the next release.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-02-10 00:33:13
Quote
0.3.8.1
Rework tagger dialog layout

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-02-14 11:03:53
Quote
0.3.9
We now obey the rate limit rules with a delay inbetween each request so any lookup
with more than several releases should complete.

You can now paste full release URLs like

https://musicbrainz.org/release/76a601d9-a1a6-4112-aad5-d63bc85db9b6

in to the MBID query dialog and it will automatically strip the URL so you're left with
just the MBID like 76a601d9-a1a6-4112-aad5-d63bc85db9b6. This is useful if a
given artist/album has many releases and you find it easier to find the correct one
on the musicbrainz.org website. This will only work with "release" URLs and
not "release-group" and the track count must always match the selection.

Using the artist/album lookup dialog will populate the album field with the "TITLE"
if there is no album tag present and the track count is one. There are some
releases with just one track on Musicbrainz so this should make them easier to find.

https://github.com/19379/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: Neurot79 on 2017-04-27 22:06:31
I think I've found a bug in this component. It looks like the component uses the title of the MusicBrainz recording for tagging, instead of the title given in the track list of the release.

For example, in this release:
https://musicbrainz.org/release/434315fa-c033-43dc-b3b4-7b218941b4d6
track 6 is shown in the track list as "3 Olden Style Pieces: III.". But if you try to tag this release using foo_musicbrainz it's tagged as "3 Utwory w dawnym stylu (3 Pieces in Old Style), No. 3". This is the title of the recording associated with track 6:
https://musicbrainz.org/recording/baa09475-4a84-4881-b958-41de9bdc16fb

Also, could I make a feature request? Is it possible to add an option to tag single disc releases with a disc number? Currently only multi-disc releases are tagged with a disc number.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-04-28 21:01:02
1) I'd like to fix it but I have no idea how. The underlying code is too hard for me to understand.  :'(

2) Nope, I'm not changing this. This was obviously a design choice added by the original developer and it's one I agree with. I think writing disk 1 of 1 is pointless.
Title: Re: foo_musicbrainz
Post by: Kraeved on 2017-05-24 08:16:55
Thank you for continuing to work on the plugin.
Title: Re: foo_musicbrainz
Post by: Fladder72 on 2017-05-27 11:06:22
Something strange... foo_musicbrainz don't use Album-ID's tagged with Musicbrainz Picard. See attached Screenshot...
ID #1-7 from Picard, no tagging by ID in foo_musicbrainz possible!
ID #8-14 from foo_musicbrainz, tagging by ID is working...
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-05-27 14:10:45
The code that checks MBIDs are valid expects lower case characters. The first 7 begin with a capital F.
Title: Re: foo_musicbrainz
Post by: Fladder72 on 2017-05-28 15:57:29
The code that checks MBIDs are valid expects lower case characters. The first 7 begin with a capital F.

The MBIDs I've got from Picard...
Anyway, I've changed "some" MBIDs by using Mp3Tag formatting all to lower case Characters, it counts up to 217 changes...
Now foo_musicbrainz work as as expected  :)

Is it possible to make the Script work with upper and lower case characters in MBIDs?
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-05-28 20:42:31
I've made the changes (https://github.com/19379/foo_musicbrainz/commit/53bcf77c7fa80e8209ce722b94d49e003bde731f) but I'm not sure when the next component release will be.
Title: Re: foo_musicbrainz
Post by: 2tec on 2017-05-29 21:06:12
Is Tagging>Get tags from MusicBrainz (by Discogs release #) possible?
Title: Re: foo_musicbrainz
Post by: alec.tron on 2017-05-30 00:56:57
Is Tagging>Get tags from MusicBrainz (by Discogs release #) possible?
Oh.... I have not tried this plugin... mostly due to the additional steps involved in finding the correct release for picard when I have everything set up for the discogs tagger (via ID field). So IF this is possible (from the wording above, I'm not 100% if this does exist as a menu entry for this plugin already or if is this a suggestion for a feature), I would be very keen to use this too (and will grab the component the next days to test around with this).
Also - can this component be configured to write the incoming data to custom/user-defined metadata fields ? i,e, instead of TPOP/Genre, use 'MSUCIBRAINZ_Genre' or some such ?

Cheers.
c.
Title: Re: foo_musicbrainz
Post by: 2tec on 2017-05-30 02:02:19
So IF this is possible (from the wording above, I'm not 100% if this does exist as a menu entry for this plugin already or if is this a suggestion for a feature),

No, it's not a real menu choice, I meant it as both a question and a request.
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-06-10 00:55:17
Only just noticed this had new posts....

Well I don't think that discogs lookup is at all possible. Even if it was, I wouldn't be adding it. Also, the MB webservices have been severely overloaded over recent weeks meaning it's barely even usable at the moment.

Tbh, I don't think I'll be working much on this any more because I don't have the skills to make any significant changes.
Title: Re: foo_musicbrainz
Post by: zeremy on 2017-09-07 14:26:44
A feature request.

Currently the component writes multiple %musicbrainz_artistid% for feat.  artists , but keeps the artist name to "xxx xxx feat. yyy yyy"
e.g
%artist% Justin Timberlake feat. JAY Z
%musicbrainz_artistid% 596ffa74-3d08-44ef-b113-765d43d12738; f82bcf78-5b69-4622-a5ef-73800768d9ac

In my opinion it would be better to remove the feat. and seperate the artist field.
e.g
%artist% Justin Timberlake; JAY Z
%musicbrainz_artistid% 596ffa74-3d08-44ef-b113-765d43d12738; f82bcf78-5b69-4622-a5ef-73800768d9ac
Title: Re: foo_musicbrainz
Post by: marc2003 on 2017-09-09 10:58:57
^If that was aimed at me, see the last sentence of the post directly above yours.  :))

I should probably remove the GH repo so I no longer give the false impression that I'm able to do anything with it.
Title: Re: foo_musicbrainz
Post by: Fladder72 on 2017-10-03 11:35:47
Sad to hear...   :o
Title: Re: foo_musicbrainz
Post by: Sandrine on 2018-11-19 19:24:46
This add-on works pretty well for me. Sure, Picard adds richer tags but is far from easy to handle. The only thing that this plugin doesn't get right is to add the "albumartist" tag always. At the moment, when "artist" is found, "albumartist" is left empty. This leads to problems with other software.

If this small change were possible, that would be great!
Title: Re: foo_musicbrainz
Post by: lvqcl on 2018-11-20 15:33:04
The only thing that this plugin doesn't get right is to add the "albumartist" tag always. At the moment, when "artist" is found, "albumartist" is left empty. This leads to problems with other software.
For me, the current behaviour (don't duplicate %artist% into %albumartist%) is correct, and I never had any problems with it.
Title: Re: foo_musicbrainz
Post by: Sandrine on 2018-11-21 18:40:20
Picard tags it that way (doubled) and when reading a file in Kodi that has an MB artist but no MB albumartist tag, Kodi sorts it under [Missing]. Yeah, Kodi could be more lenient, but this here fix would be faster  :-[
Title: Re: foo_musicbrainz
Post by: katieinthecoconut on 2019-05-29 10:55:18
I'd love to see some development of this tool, but I guess it's abandoned by all parties now? I use it regularly but do wish it could be customised more in terms of what it retrieves and the tags it writes. The original date issue (it'll just give you the earliest date on their system which is often not the accepted release date) and "error parsing XML" issue when there's lots of results are two things that'd be nice to see improved. Obviously this is wishful thinking while it's not in development, but just in case work resumes or someone makes a replacement...
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2019-05-29 17:20:14
I agree I kind of which someone responsible like @kode54 would take it on and update it as a little side project or @Peter   would just port and update the tagger and make it into the core since even though being outdated and some what broken its still the best tagger component we have available
Title: Re: foo_musicbrainz
Post by: Sandrine on 2019-08-24 20:48:27
I. Album Artists

I would like to give my request another try => always write "album artist" + "musicbrainz_albumartistid".
There are 2 main reasons to do this:

1) Keep compatibility with other software
The official musicbrainz tagger, Picard, tags files this way and other software may expect the requested tags to be always present. From a purely economical point of view, these tags are not requiered when no split artists or various artists are present on an album. However, there is software which aims to hide those artists in user's library which only appear on compilations. That only works programmatically if "album artist" is the starting point for such a check.

2) Keep behaviour consistent within foobar2000
The "Discogs" tagger always seems to write an "album artist" even when there are no split or various artists. I am guessing that is recommended bevavior at Discogs, same as at Musicbrainz.

I usually write both tags to my file, Discogs first and then Musicbrainz, because I like their capitalization schemes better and they usually get diacritics etc. right (even though Musicbrainz uses lots of non-ascii characters which annoy me to no end and which the foobar2000 implementation doesn't replace correctly with ASCII characters). The foobar2000 MB tagger implementation doesn't leave well alone, however, as it actively clears some fields which the Discogs tagger writes, namely "album artist" in the cases mentioned above, and "disc".

II. Disc subtitles

At last, I would plead for the Discogs tagger and the Musicbrainz tagger to use the same tag for "disc subtitle". This tag is especially important when dealing with multi-disc releases of an artists complete works under a new name and the release titles are only written to "disc subtitles". Examples for this are Pink Floyd's "Oh by the way", Yes' "High Vibration", Manfred Mann's' "40th Anniversary", to name a few. The foobar2000 Discogs tagger uses "DISC_SUBTITLE" and the Musicbrainz tagger uses "DISCSUBTITLE". Using the same tag would make things easier to maintain.
Title: Re: foo_musicbrainz
Post by: Rollin on 2019-08-24 21:35:24
@Sandrine , original developer is not on hydrogenaudio anymore and doesn't maintain component anymore. Component is maintained by marc2003 - https://github.com/marc2k3/foo_musicbrainz/releases , but marc2003 also left  hydrogenaudio. So you better try to contact him on github.
Title: Re: foo_musicbrainz
Post by: Sandrine on 2019-08-25 18:30:04
Thanks marc2k3, that was really swift!
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2019-08-25 21:39:57
so is this under active development once again https://github.com/marc2k3/foo_musicbrainz makes it look  so its one of my favorite rags and if its being updated agian it needs to be on the cponents repo please !
Title: Re: foo_musicbrainz
Post by: jesus2099 on 2019-09-16 06:36:08
@Sandrine, @marc2k3 is now seen in MusicBrainz forum https://community.metabrainz.org/t/a-new-version-of-foo-musicbrainz-has-been-released/442446?u=jesus2099
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2019-09-18 22:53:07
just a reminder the original version of this plugin is retired and should NOT  be used or recommended    the only proper place to stay updated on this plugin is the thread linked to by @jesus2099  above^ or  via https://github.com/marc2k3/foo_musicbrainz/releases
Title: Re: foo_musicbrainz
Post by: Sandrine on 2020-01-06 10:45:45
Just to make you aware: If you use foobar2000's function to rewrite MP3 tags, this can lead to corrupt tags in certain situations. This component writes VORBIS comments, which is fine. BUT if you want to copy those tags to ID3 please be aware that those will be incorrect/corrupt. This is due to some ancient Picard convention which uses underscores for tags in VORBIS comments but spaces in ID3 tags. A more in-depth explanation can be found here: https://marc2k3.github.io/foo_musicbrainz.html#tag-mapping

If you need MBIDs in your ID3 tags you must use Picard or a different external software that is capable of correct tagging. Marc2k3 has stated that he will not change the current behaviour.
Title: Re: foo_musicbrainz
Post by: Sandrine on 2020-01-07 10:43:41
@Peter In light of the previous post, maybe it would be a good idea to make foobar2000 aware of specific tag requirements for different tag formats when converting? A good overview is available at https://picard.musicbrainz.org/docs/mappings/
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2020-01-26 17:51:13
@Sandrine  check under nerdy stuff
https://marc2k3.github.io/foo_musicbrainz.html
Title: Re: foo_musicbrainz
Post by: MojoBass on 2020-02-07 05:40:06
Marcs link to his foo_musicbrainz seems to be dead  :(
Title: Re: foo_musicbrainz
Post by: TheQwertiest on 2020-02-07 10:02:54
@MojoBass , it seems that marc2003 deleted (or moved to private) both his foo_musicbrainz and foo_listenbrainz2 repositories.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-12 21:32:13
@MojoBass , it seems that marc2003 deleted (or moved to private) both his foo_musicbrainz and foo_listenbrainz2 repositories.
Marc2003 pointed me to a fork of his repo, and I'll most likely be taking over development and maintenance of this shortly. I've got a lot of experience querying musicbrainz for stuff, so should be relatively painless for me I hope.
Title: Re: foo_musicbrainz
Post by: 2tec on 2020-02-12 22:16:49
... it seems that marc2003 deleted (or moved to private) both his foo_musicbrainz and foo_listenbrainz2 repositories.
Yah, I saw that. I had hoped it was only temporary.

Marc2003 pointed me to a fork of his repo, and I'll most likely be taking over development and maintenance of this shortly. I've got a lot of experience querying musicbrainz for stuff, so should be relatively painless for me I hope.
Excellent news. Thanks! You developers are all remarkably amazing.  :)

I'd use this plugin a lot more if it would find and tag files with MusicBrainz tags, based upon the presence of a Discogs Release ID tag. Does anyone know if that's already possible somehow?
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-12 22:21:32
I'd use this plugin a lot more if it would find and tag files with MusicBrainz tags, based upon the presence of a Discogs Release ID tag. Does anyone know if that's already possible somehow?
As far as I know it's not possible to query the MB API by discogs tag. It's easy enough to get external links from a known release_MBID, but not the other way around. Someone can correct me if I'm wrong.
Title: Re: foo_musicbrainz
Post by: 2tec on 2020-02-12 22:34:40
As far as I know it's not possible to query the MB API by discogs tag. It's easy enough to get external links from a known release_MBID, but not the other way around. ...
Thanks, I assumed as much, hopefully the API can manage this someday.
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2020-02-12 22:48:15
@MojoBass , it seems that marc2003 deleted (or moved to private) both his foo_musicbrainz and foo_listenbrainz2 repositories.
Marc2003 pointed me to a fork of his repo, and I'll most likely be taking over development and maintenance of this shortly. I've got a lot of experience querying musicbrainz for stuff, so should be relatively painless for me I hope.
No disrespect meant to Marc but he seems to have some issues he brought back a amazingly useful tool only to hide it when people took notice most of us were proud to have it back he has his reasons i guess i find it bad that this keeps happening to this tagger @MordredKLB please give it some love and a more stable home 
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-13 16:43:26
Dealing with open source projects and demands of your "customers" can be daunting, plus a huge time suck. We do this stuff for fun, and for free. When it no longer becomes fun, maybe it's best for your sanity to just cut the cord and make sure you aren't tempted to work on it anymore. We're all in a better off shape for the effort he put in on this, and there's literally no point in speculating on his reasons for removing the repo.

I'm swamped with other projects and work I actually get paid to do, but probably in the next week I'll start a new thread and do a new release. Unsure on whether I should start fresh from an unforked repo, or keep the fork of a fork status I currently have which is a little confusing from a "source of truth" standpoint. Curious to hear what you guys would prefer.
Title: Re: foo_musicbrainz
Post by: zeremy on 2020-02-13 17:23:21
I'd use this plugin a lot more if it would find and tag files with MusicBrainz tags, based upon the presence of a Discogs Release ID tag. Does anyone know if that's already possible somehow?
As far as I know it's not possible to query the MB API by discogs tag. It's easy enough to get external links from a known release_MBID, but not the other way around. Someone can correct me if I'm wrong.

Something like this?
https://musicbrainz.org/ws/2/url?inc=release-rels&fmt=json&resource=https://www.discogs.com/release/14692
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-13 18:19:17
As far as I know it's not possible to query the MB API by discogs tag. It's easy enough to get external links from a known release_MBID, but not the other way around. Someone can correct me if I'm wrong.

Something like this?
https://musicbrainz.org/ws/2/url?inc=release-rels&fmt=json&resource=https://www.discogs.com/release/14692
Well now I just look silly. Thanks! I'll add that as a TODO
Title: Re: foo_musicbrainz
Post by: 2tec on 2020-02-13 18:31:42
Well now I just look silly. Thanks! I'll add that as a TODO
:) It's good news to hear that's possible. I look forward to have mega metadata, thanks to both of you.

As for the fork, I'd let it depend on how much you want to start all over. I'd also like to thank marc for getting the ball rolling. I often wish more people would try to start things like this. It takes courage and ambition to wade into public open development.
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2020-02-14 19:54:27
@MordredKLB  I get that pressures both real and persevered can get to  people I just dont like the fact that he seems tp just nuke  everything when he feels that way its unfair to those who appreciate the plugin id rather something remain functional and get the occuational update when possible rather then disappear  at least give folks heads up write a note something so even if your swamped and dont give it attention often id be happy if its just readily available  as for forking  I would make it what you want just promise to maintain it is emough  
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-14 20:15:17
As for the fork, I'd let it depend on how much you want to start all over. I'd also like to thank marc for getting the ball rolling. I often wish more people would try to start things like this. It takes courage and ambition to wade into public open development.

It can definitely be daunting.

My thoughts are two fold. I don't want it to seem like my work is based off the work of someone who didn't actually contribute anything (except make a fork at recent time!), but I also don't want it to look like I'm taking credit for anything dremora or Marc did. I'll probably just get git to move my fork out to the top level which should allow me to keep git history and everything. I will probably not rename the repo which might be a little confusing from a source-of-truth perspective, but we'll see how it goes.
Title: Re: foo_musicbrainz
Post by: snotlicker on 2020-02-15 13:07:11
@MordredKLB, the component in the upload section has a TOC fix described in this post...

https://community.metabrainz.org/t/a-new-version-of-foo-musicbrainz-has-been-released/442446/43?u=marc2k3

Your fork doesn't have it so I've attached a patch.

Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2020-02-15 17:36:44
Hi guys I just want to know what is the new centralized home of this component and where i can download  the component file? 
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-15 17:46:23
@MordredKLB, the component in the upload section has a TOC fix described in this post...

https://community.metabrainz.org/t/a-new-version-of-foo-musicbrainz-has-been-released/442446/43?u=marc2k3

Your fork doesn't have it so I've attached a patch.
Thanks! I'll get that integrated shortly.

Hi guys I just want to know what is the new centralized home of this component and where i can download  the component file? 
For the next day or so, the upload forum. You'll have to be patient.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-16 23:32:00
Official releases are available here (https://github.com/kbuffington/foo_musicbrainz) now. Expect further development to start up in the next week or so.
Title: Re: foo_musicbrainz
Post by: phw on 2020-02-17 13:17:39
MordredKLB: Thanks a lot for taking this up. Do you also have access to the sources of foo_listenbrainz2 or is this one gone for good?
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2020-02-17 14:09:22
@MordredKLB  thanks for this maybe I am inexperienced but i only see the source code and no working component file or dll?
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-17 21:25:16
MordredKLB: Thanks a lot for taking this up. Do you also have access to the sources of foo_listenbrainz2 or is this one gone for good?
I don't. That wasn't a component I ever used, and unfortunately have no interest in managing that one either. Hopefully someone else has a fork of that one.

@MordredKLB  thanks for this maybe I am inexperienced but i only see the source code and no working component file or dll?
Check the releases tab.
Title: Re: foo_musicbrainz
Post by: phw on 2020-02-17 23:39:57
I don't. That wasn't a component I ever used, and unfortunately have no interest in managing that one either. Hopefully someone else has a fork of that one.

That's a real pitty :( I even would have considered maintaining this. I had an older fork of foo_musicbrainz, but unfortunately I don't have a fork of foo_listenbrainz2. And I can't find one either. Hopefully somebody else has.
Title: Re: foo_musicbrainz
Post by: MJmusicguy on 2020-02-18 00:48:25
ah I see have you just not compiled .4.4 yet?  as .4,3 is the only one with a usable file
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-18 02:32:11
ah I see have you just not compiled .4.4 yet?  as .4,3 is the only one with a usable file

Sorry, guess I forgot to add the component when I created the release. Fixed now.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-22 18:28:17
New beta release up for testing. Should be good speed improvements with more to come soon.

Release notes are here (https://github.com/kbuffington/foo_musicbrainz/releases/tag/v0.4.5b1). I'll keep updating that page as new changes are made.

Edit: Beta 2 now available.
Title: Re: foo_musicbrainz
Post by: JohnBuckWLD on 2020-02-24 22:26:34
Small issue, perhaps caused by my Windows resolution settings:
Clicking [Update Files] from the the MusicBrainz tagging window (via TOC) can only be done by maximizing the window and hiding the Windows taskbar because the window is oversized and can not be reduced on the non-maximized setting.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-24 23:02:04
Small issue, perhaps caused by my Windows resolution settings:
Clicking [Update Files] from the the MusicBrainz tagging window (via TOC) can only be done by maximizing the window and hiding the Windows taskbar because the window is oversized and can not be reduced on the non-maximized setting.
What resolution are you running at?
Can you share a screenshot of what it looks like maximized with the windows taskbar visible? I can shrink the window down slightly, but I'd prefer not to change it too much for those of us who are running at larger resolutions.
Title: Re: foo_musicbrainz
Post by: JohnBuckWLD on 2020-02-25 05:45:13
What resolution are you running at?
Can you share a screenshot of what it looks like maximized with the windows taskbar visible? I can shrink the window down slightly, but I'd prefer not to change it too much for those of us who are running at larger resolutions.
1600x900 on a Sony 48" flat screen TV monitor

Video showing musicbrainz tagging window size (and inability to resize it):
https://youtu.be/ESlHUlPncV0
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-25 07:53:52
Let me know if this is any better for you. The dialog was 850 pixels high. I shaved off 26 pixels so I think it should fit (or mostly fit), even on your ridiculously small size screen :D
Title: Re: foo_musicbrainz
Post by: JohnBuckWLD on 2020-02-26 05:21:45
Let me know if this is any better for you. The dialog was 850 pixels high. I shaved off 26 pixels so I think it should fit
Bingo. On maximize, it fits poyficktly. I do have another elusive musicbrainz/picard type question. Do you mind it being posed here even though it is technically a hijack away from the script @ hand?

Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-26 22:28:08
Let me know if this is any better for you. The dialog was 850 pixels high. I shaved off 26 pixels so I think it should fit
Bingo. On maximize, it fits poyficktly. I do have another elusive musicbrainz/picard type question. Do you mind it being posed here even though it is technically a hijack away from the script @ hand?

Perfect!

I don't use Picard, so I might not be able to answer, but you're welcome to ask away. You might have better luck over on the musicbrainz forum itself though.
Title: Re: foo_musicbrainz
Post by: JohnBuckWLD on 2020-02-26 23:52:15
Perfect!
Just noticed another resizing issue within a fixed sized window. In the Releases section of the MusicBrainz Tagger window, where the numerous release variants are listed, it is very difficult (i.e. have to make the other columns narrower in order) widen the Label / Cat # column to see the Cat # to choose the correct variant.  Sometime the 'robbing peter's with to pay paul' widening process works, other times, every column snaps back to its default width.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-27 05:43:36
Perfect!
Just noticed another resizing issue within a fixed sized window. In the Releases section of the MusicBrainz Tagger window, where the numerous release variants are listed, it is very difficult (i.e. have to make the other columns narrower in order) widen the Label / Cat # column to see the Cat # to choose the correct variant.  Sometime the 'robbing peter's with to pay paul' widening process works, other times, every column snaps back to its default width.
Unfortunately, that's just a standard Visual Studio control. AFAIK, there's nothing actually handling the resize handles. Have you tried double clicking on the edge of the column? I would assume that grows to fit the content, but I'm out of town and don't have a foobar instance in front of me to check.
Title: Re: foo_musicbrainz
Post by: snotlicker on 2020-02-27 06:30:41
There is nothing standard about the list view controls at all. They're implemented using Peter's rather excellent libPPUI library bundled with the fb2k SDK.

You can see how some columns are auto-sizing and some aren't here...

https://github.com/kbuffington/foo_musicbrainz/blob/d91a77ef3d1f7a05dfe6c30a19d77007683fd03b/src/dialog_tagger.h#L119L125

You can change it if you want to.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-02-29 23:52:50
There is nothing standard about the list view controls at all. They're implemented using Peter's rather excellent libPPUI library bundled with the fb2k SDK.

You can see how some columns are auto-sizing and some aren't here...

https://github.com/kbuffington/foo_musicbrainz/blob/d91a77ef3d1f7a05dfe6c30a19d77007683fd03b/src/dialog_tagger.h#L119L125

You can change it if you want to.
Yes, that's true. What I meant was that the program doesn't alter the behavior when a user attempts to adjust the width of a column using the sizing handles between columns.

0.4.5b4 released (https://github.com/kbuffington/foo_musicbrainz/releases/tag/v0.4.5b4)
Title: Re: foo_musicbrainz
Post by: Rhand on 2020-04-03 13:44:07
I really like this component, only thing what is missing for me is the field GENRE.
Maybe you can add this to, if you want.

Keep this component alive it's the best.
Title: Re: foo_musicbrainz
Post by: TheEmpathicEar on 2020-04-03 15:06:15
Is this a plugin or standalone? I have been using the built-in tagger - freedb sometimes. But, I would like try something different just for comparison.
Title: Re: foo_musicbrainz
Post by: MojoBass on 2020-04-04 06:19:28
It's a plugin. Just download the file 'foo_musicbrainz-0.4.5b4.fb2k-component' attached in MordredKLBs post (second post above) and install it in the usual foobar component way.
Title: Re: foo_musicbrainz
Post by: TheEmpathicEar on 2020-04-09 21:25:32
I just used this for the first time. What I got was a zip file containing a DLL. It installed w/o incident. I was just wondering what caveats to watch out for? How does it compare with FreeDB Tagger? I noticed that they are two date fields?
EDIT: I used this for artist "Doja Cat" and album "Hot Pink" which FreeDB could not find.
Title: Re: foo_musicbrainz
Post by: kode54 on 2020-04-10 02:22:03
FreeDB will not find anything unless you supply a substitute FreeDB server, since the official service was taken down on March 31st.
Title: Re: foo_musicbrainz
Post by: TheEmpathicEar on 2020-04-10 03:05:16
FreeDB will not find anything unless you supply a substitute FreeDB server, since the official service was taken down on March 31st.
https://hydrogenaud.io/index.php?topic=119006.0
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-05-17 06:10:41
Finally officially released 0.4.6 (https://github.com/kbuffington/foo_musicbrainz/releases/tag/v0.4.6).

Changes from last beta were to add some new preferences options to give you some control over which MB IDs you want to write, and to fix some bugs when searching by ReleaseGroup ID.

It's also available in the components registry now so you can update through foobar if you like.
Title: Album Type always set to Album; Featured Artists
Post by: bkh on 2020-05-17 10:06:02
Hello, I hope this is the right place.

1st:
When I request compilations or live albums etc. the dialog box always shows 'Album', although in MB Album + Compilation/Live/...
Is there a trick?

2nd:
Is there a way to set featured artists in a selectable tag (%feature% or %featured artist%?

3rd:
The same applies to artists who are connected by join (x, presents, with, ...). These artists are listed as multiple artists and are connected manually with a tag %join%.

It would be nice if such features (multiple artists, user-tags and joins) could be added and optionally enabled.

Muchas Gracias for the work on it, it's very useful for me.

bkh

P.S.: I use 0.4.6
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-05-17 17:36:54
Hello, I hope this is the right place.
It is. To answer your questions:

1. Wow, I hadn't noticed that before. I do agree it should show the secondary release type. That needs to be fixed.
2. Not currently. Are you saying you'd still want it in the track artist, but also in a user configurable %featured% type tag too?
3. Are you saying you'd want those split in their own fields as well, or changing what the JOIN text is, or something else?

Title: Re: foo_musicbrainz
Post by: bkh on 2020-05-18 15:20:15
Hello MordredKLB,

thx for your hard work on it.

My 'problem' are the featured artists. At the moment i put them, via "automatically fill values", in a user defined tag %feature%.
I don't know how it is organized in MB.

The real prob is, that some players cannot show user defined tags, of course.

So, i am searching for a way to make them usable as one separate artist.

Maybe i change it to: %mega(artist,0) %join% %mega(artist,1), but this scheme couldn't act with:

artist1, artist2 & artist3 feat. artist4 & artist5 etc.

Or, i couldn't find a solution in the title formating help

THX

bkh
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-05-18 18:01:16
Interesting. This is a pretty corner case, and not sure it would be applicable to much of anyone besides you (I have my own schema for being able to search artists throughout my library but I'm not hung up on feat/&/vs./etc. that I can't use this component for either).

What I'd suggest for you is using %join% as a multi-value field. Then you could do $meta(artist,0)$meta(join,0)$meta(artist,1)$meta(join,1)$meta(artist,2)

I'll have to think about whether this has broader application, and whether it's worth the effort to add to the component.

Title: Re: foo_musicbrainz
Post by: bkh on 2020-05-18 18:19:01
Many thanks for this

I just noticed that the artists are separated in MB and thought that there could be a direct takeover.

I think it's great that you have taken over the maintenance of the component.

bkh
Title: Re: foo_musicbrainz
Post by: alec.tron on 2020-05-22 12:31:03
Many thanks for maintaining this component!

A few noob-ish questions (as I rely on discogs IDs & data to tag things mostly, but would like to also incorporate a few MusicBrainz bits...):
- is it possible to re-route the MusicBrainz tags to custom metadata fields ?  (I'd want MusicBrainz (Track) ID / MusicBrainz Release ID / MusicBrainz Artist, plus a few others most likely - but only ever to their own custom frames... never the standard ID3/Vorbis Frames, which seems to be the un-editable default atm in foo_musicbrainz ?)
- and additionally, but this is probably beyond the scope - also add AcoustID & AcousticBrainz ID plus some of the AcousticBrainz  data...?

Churs.
c.
Title: Re: foo_musicbrainz
Post by: JohnBuckWLD on 2020-05-22 15:27:29
- is it possible to re-route the MusicBrainz tags to custom metadata fields ?  (I'd want MusicBrainz (Track) ID / MusicBrainz Release ID / MusicBrainz Artist, plus a few others most likely - but only ever to their own custom frames... never the standard ID3/Vorbis Frames, which seems to be the un-editable default atm in foo_musicbrainz ?)
- and additionally, but this is probably beyond the scope - also add AcoustID & AcousticBrainz ID plus some of the AcousticBrainz  data...?
I have tried the same thing sans AcousticID and AcousticBrainz ID, and to the best f my knowledge, you can't, unfortunately.

If you uncheck every metadata tag in Preferences > Tool > MusicBrainz Data, with Write MusicBrainz IDs enabled you get MUSICBRAINZ_...
ALBUMARTISTID
ALBUMID,
DISCID
RELEASEGROUPID
RELEASETRACKID
TRACKID
WORKID

But it will overwrite Album, Album Artist, Song, Date (and maybe genre). The only work around I have come up with is to call up Properties dialog for release you're tagging, then run Tagging > Get tags from MusicBrainz by TOC. After updating, cross-paste the overwritten tags from that propeties dialog window manually
Title: Re: foo_musicbrainz
Post by: alec.tron on 2020-05-22 21:01:57
But it will overwrite Album, Album Artist, Song, Date (and maybe genre)
Thanks for the info!
Unfortunately each of the above is a no-go...

Question for @MordredKLB I'd guess:
Is this - making the fetched MusicBrainz  (& potentially AcoutsticBrainz) data map-able to custom ID3 & Vorbis fields/tags - planned already by chance or potentially an option for the long run ?

Churs.
c.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-05-23 00:26:09
But it will overwrite Album, Album Artist, Song, Date (and maybe genre)
Thanks for the info!
Unfortunately each of the above is a no-go...

Question for @MordredKLB I'd guess:
Is this - making the fetched MusicBrainz  (& potentially AcoutsticBrainz) data map-able to custom ID3 & Vorbis fields/tags - planned already by chance or potentially an option for the long run
I have no plans to add AcousticBrainz support. That's a completely separate backend/API and seems out of scope to this component.

Can I ask what the reason is you want to adjust those property names? It definitely adds some complexity to the component, but I'm struggling to see why you're fine getting MUSICBRAINZ_ALBUMID, but you just want it stored in CUSTOM_ALBUMID.
Title: Re: foo_musicbrainz
Post by: alec.tron on 2020-05-23 09:22:07
Thanks for the reply!
I have no plans to add AcousticBrainz support. That's a completely separate backend/API and seems out of scope to this component.
Understandable, and with the MusicBrainz ID I might be able to bash something together myself.

Can I ask what the reason is you want to adjust those property names? It definitely adds some complexity to the component, but I'm struggling to see why you're fine getting MUSICBRAINZ_ALBUMID, but you just want it stored in CUSTOM_ALBUMID.
My reason being that I have a tag nomenclature & tool set I am fairly happy with, and which is Discogs based.
What I would be interested in is some of the MusicBrainz data... to give 2 different use case examples:

MUSICBRAINZ_ALBUMID, as it is a unique/proprietary tag name, I have no problem with and could use it right away... as for what - in MusicBee one can dynamically string together URLs based on Discogs and similarly, with Musicbrainz data too, and display them within the UI as a direct link to Discogs/MusicBrainz/Wikipedia/LastFM pages for the playing song. For this the existing ID tags would be interesting, and to evaluate the AcousticBrainz relation, which uses the same ID as MusicBrainz for their URLs (and API as well I would assume).

More problematic - and the reason I would not be able to use foo_musicbrainz as is unfortunately:
I would also like to use some of the default field info - like Artist, Release Date, Genre, Tags etc - but as these are only writeable to default fields (which are and will need to stay discogs data populated for me), I would need/want to re-route these to custom fields - i.e. "MUSICBRAINZ_GENRE" (or whatever name I decide on),  "MUSICBRAINZ_ALBUM", etc.

Hope that makes sense - not sure if this is a recurring request (for the more music geeky users) though, as most probably stay with whatever tagging system they decided on at some point.

Chur.
c.

ps. another question as well - is there a list for all tags/fields/data that foo_musicbrainz is currently capable of retrieving & writing ? One thing I would love to grab from MusicBrainz is Track-relative instrument credits (where available), but from what I've seen so far, these are not accessible, correct ?
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-05-24 05:43:11
My reason being that I have a tag nomenclature & tool set I am fairly happy with, and which is Discogs based.
What I would be interested in is some of the MusicBrainz data... to give 2 different use case examples:

MUSICBRAINZ_ALBUMID, as it is a unique/proprietary tag name, I have no problem with and could use it right away... as for what - in MusicBee one can dynamically string together URLs based on Discogs and similarly, with Musicbrainz data too, and display them within the UI as a direct link to Discogs/MusicBrainz/Wikipedia/LastFM pages for the playing song. For this the existing ID tags would be interesting, and to evaluate the AcousticBrainz relation, which uses the same ID as MusicBrainz for their URLs (and API as well I would assume).

More problematic - and the reason I would not be able to use foo_musicbrainz as is unfortunately:
I would also like to use some of the default field info - like Artist, Release Date, Genre, Tags etc - but as these are only writeable to default fields (which are and will need to stay discogs data populated for me), I would need/want to re-route these to custom fields - i.e. "MUSICBRAINZ_GENRE" (or whatever name I decide on),  "MUSICBRAINZ_ALBUM", etc.

Hope that makes sense - not sure if this is a recurring request (for the more music geeky users) though, as most probably stay with whatever tagging system they decided on at some point.

Chur.
c.

ps. another question as well - is there a list for all tags/fields/data that foo_musicbrainz is currently capable of retrieving & writing ? One thing I would love to grab from MusicBrainz is Track-relative instrument credits (where available), but from what I've seen so far, these are not accessible, correct ?
Okay, so just to restate, you're fine with the MB ID's being pre-fixed with MUSICBRAINZ_, you'd just like option to prefix every other field that would be updated with "MUSICBRAINZ_" or some other custom string, so that the tags you've already specified aren't overwritten. Is that correct?

I don't believe all the fields are documented anywhere currently, but I can work on that.
Title: Re: foo_musicbrainz
Post by: alec.tron on 2020-05-24 19:57:07
Heya, thanks for the info.
And yes, if there would be an option to prefix ALL tag-/field-names for MusicBrainz metadata (in ID3 & vorbis container), then this could work for me (and others who have an established tagging system, and want to enhance their files with MusicBrainz info).

Curious question or 2 re non-documented fields (might actually be some general MusicBrainz questions too...):
- can you retrieve instrument credits/tags via foo_musicbrainz as is (and can this be done on an album and/or per track basis) ?
- is the (discogs) URL exposed/query-able, in your component and/or in the DB/API ? (it's possible via the web component. i.e. see: https://community.metabrainz.org/t/query-release-musicbrainzid-via-a-discogsid-url/478327 - but the replies indicate that this is not easily queryable through the api/db...).

To make sure - these are not requests, merely curious questions & suggestions, and should you think this might be worthwhile for other users as well and worth considering or even implementing, perfect (as I have been looking for a usable musicbrainz auto-tagging solution for a while)...! :D

Churs.
c.
Title: Re: foo_musicbrainz
Post by: katieinthecoconut on 2020-05-24 22:18:35
It's great that this has been updated! It's so much better than the old component now that it doesn't throw out lots of errors, import tags with weird hyphen and apostrophe characters, and actually finds stuff consistently.

One idea I do have, which would be cool: Could the tagger window have an autofill dropdown when editing the track artist field, based on the artists in your foobar2000 library? This works in the foobar2000 default properties window and it'd be great to have the option to do this, it'd make tagging tweaks in the MusicBrainz Tagger window a lot easier.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2020-05-28 04:20:02
It's great that this has been updated! It's so much better than the old component now that it doesn't throw out lots of errors, import tags with weird hyphen and apostrophe characters, and actually finds stuff consistently.

One idea I do have, which would be cool: Could the tagger window have an autofill dropdown when editing the track artist field, based on the artists in your foobar2000 library? This works in the foobar2000 default properties window and it'd be great to have the option to do this, it'd make tagging tweaks in the MusicBrainz Tagger window a lot easier.
I'll have to look into that. Not a bad idea.
Title: Re: foo_musicbrainz
Post by: globalnomad on 2020-12-10 08:31:29
So for a long while now the tagger hasn't been working for me. Did the API change? I'm copy and pasting IDs from musicbrainz.org and none of them work.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-08 14:41:55
Just started to get this error message after I try to tag via artist & album. If I close the error window, it sometimes crashes Foobar - error report submitted

HTTP/1.1 500 Internal Server Error

I'm using v0.4.6 and Foobar core 1.6.5
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-09 16:21:45
Just started to get this error message after I try to tag via artist & album. If I close the error window, it sometimes crashes Foobar - error report submitted

HTTP/1.1 500 Internal Server Error

I'm using v0.4.6 and Foobar core 1.6.5
Could you provide the exact artist name and album title you're using when you get these (if it's reproducible this way)?

Since it's a 500 error, I'm presuming that's just a server issue on the musicbrainz side though. I use this once or twice a day and don't think I've seen a 500 come up on my end.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-10 08:19:10
You are right, it's not reproducible. What I have seen is that if I use the album ID it always works, if I use the tag by TOC on an album with only a few releases it works almost first time - if I retry I would normally get a result. The worst case is where there is an album with 20+ releases and I use artist+album. If I retry, sometimes upto 5 times, I mostly get results to choose from (if foobar doesn't crash!).

It seems like a time-out problem as it's not  reproducible but it has only recently started and I cannot correlate it with any software/component updates. As you say, it may be a change on their server.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-11 03:13:23
You are right, it's not reproducible. What I have seen is that if I use the album ID it always works, if I use the tag by TOC on an album with only a few releases it works almost first time - if I retry I would normally get a result. The worst case is where there is an album with 20+ releases and I use artist+album. If I retry, sometimes upto 5 times, I mostly get results to choose from (if foobar doesn't crash!).

It seems like a time-out problem as it's not  reproducible but it has only recently started and I cannot correlate it with any software/component updates. As you say, it may be a change on their server.
The crash is the worrisome part. Do your crash dumps seem to indicate it was in foo_musicbrainz when it died?
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-11 12:30:50
See below last failure.txt. I've had to trim the module list.

Code: [Select]
Illegal operation:
Code: C0000005h, flags: 00000000h, address: 0000073Ch
Access violation, operation: write, address: 0000073Ch

Call path not available.

Stack (3979F6B0h):
3979F690h:  4DD58010 00000000 00000000 00E10000
3979F6A0h:  00000002 00000003 00000017 00E10000
3979F6B0h:  00EE3BA4 4A244A84 4CE5C5D8 27ED5A53
3979F6C0h:  00000000 015A0000 00E16468 00000000
3979F6D0h:  3979F6F4 77DE5C7E 4CE5C830 77DE5C7E
3979F6E0h:  00000000 00000000 000000A9 00000000
3979F6F0h:  4CE5C6B8 3979F710 76000166 015A0000
3979F700h:  00000000 000000A9 4CE5C834 4CE5C834
3979F710h:  3979F768 00E49816 000000A9 3979F6B4
3979F720h:  3979F77C 00FE8A58 00000001 3979F768
3979F730h:  00F7A110 01017608 4CE5C5D8 00000098
3979F740h:  00E491D4 00000099 4A244A84 4CE5C5D8
3979F750h:  27ED5A53 00F7A0F7 3979F734 3979F984
3979F760h:  4CE5C5D8 4CE5C500 3979F788 00F7B976
3979F770h:  4883BD98 4A244A84 4CE5C5D8 3979F82C
3979F780h:  00FDFCE8 00000000 3979F838 6CA8ADD0
3979F790h:  3979F820 4883BD98 4A244A84 C533018B
3979F7A0h:  3979F83C 49F99628 2928BF01 3979F984
3979F7B0h:  6CAC5618 00000000 00000000 00000000
3979F7C0h:  00000015 6CA771F1 3979F7D4 6CA773B0

Registers:
EAX: 0000073C, EBX: 27ED5A53, ECX: 4A244A84, EDX: 00000000
ESI: 4A244A84, EDI: 4A244A84, EBP: 3979F72C, ESP: 3979F6B0

Unable to identify crash location!

Loaded modules:
foobar2000                       loaded at 00E40000h - 010A1000h
foo_dsp_replaygain               loaded at 6EAD0000h - 6EAE3000h
foo_dsp_nogaps                   loaded at 6EAB0000h - 6EACB000h
foo_onewaysync                   loaded at 10000000h - 10494000h
oledlg                           loaded at 6EA80000h - 6EAAC000h
WINSPOOL                         loaded at 6EA10000h - 6EA7D000h
foo_discogs                      loaded at 06510000h - 065BE000h
foo_musical_spectrum             loaded at 04250000h - 0426C000h
foo_dsp_src_resampler            loaded at 6E890000h - 6EA09000h
foo_input_dts                    loaded at 6E860000h - 6E885000h
avformat-foodts-58               loaded at 6E620000h - 6E68E000h
avcodec-foodts-58                loaded at 6E690000h - 6E851000h
avutil-foodts-56                 loaded at 6E570000h - 6E61F000h
foo_external_tags                loaded at 6E4C0000h - 6E570000h
foo_enhanced_playcount           loaded at 04290000h - 042C5000h
foo_uie_console                  loaded at 6E470000h - 6E4B9000h
foo_acfu                         loaded at 042F0000h - 04357000h
foo_skip                         loaded at 6E440000h - 6E46B000h
foo_dsp_delta                    loaded at 04370000h - 0438F000h
foo_runcmd                       loaded at 6E400000h - 6E433000h
foo_dsp_resampler_mod            loaded at 6E2C0000h - 6E3F7000h
foo_playcount                    loaded at 6E290000h - 6E2B7000h
foo_input_std                    loaded at 6E130000h - 6E28B000h
avcodec-fb2k-58                  loaded at 6DF10000h - 6E127000h
MSACM32                          loaded at 6DEF0000h - 6DF09000h
winmmbase                        loaded at 6DED0000h - 6DEED000h
avutil-fb2k-56                   loaded at 6DC20000h - 6DEC5000h
bcrypt                           loaded at 76D10000h - 76D29000h
foo_jscript_panel                loaded at 6DA60000h - 6DC15000h
foo_out_upnp                     loaded at 6D9F0000h - 6DA60000h
WS2_32                           loaded at 75DB0000h - 75E13000h
IPHLPAPI                         loaded at 75A80000h - 75AB2000h
foo_dsp_std                      loaded at 6D9C0000h - 6D9ED000h
foo_quicksearch                  loaded at 6D960000h - 6D9B7000h
WindowsCodecs                    loaded at 6D7F0000h - 6D960000h
foo_bitcompare                   loaded at 6D7D0000h - 6D7ED000h
foo_mouse_gesture                loaded at 06890000h - 068BE000h
foo_out_wasapi                   loaded at 068D0000h - 068E2000h
foo_cdda                         loaded at 6D790000h - 6D7C9000h
foo_wave_minibar_mod             loaded at 6D6E0000h - 6D781000h
foo_httpcontrol                  loaded at 6D660000h - 6D6D4000h
foo_spider_monkey_panel          loaded at 6D410000h - 6D65B000h
foo_unpack                       loaded at 6D0B0000h - 6D11E000h
foo_uie_panel_splitter_mod       loaded at 06960000h - 069B9000h
foo_texttools                    loaded at 6D070000h - 6D0A4000h
foo_spotify                      loaded at 6CF00000h - 6D06E000h
credui                           loaded at 73B70000h - 73B7D000h
HTTPAPI                          loaded at 710B0000h - 710BB000h
urlmon                           loaded at 71AB0000h - 71C59000h
iertutil                         loaded at 73070000h - 7329B000h
libspotify                       loaded at 04D10000h - 05091000h
DPAPI                            loaded at 710C0000h - 710C8000h
foo_dsp_xgeq                     loaded at 6CAE0000h - 6CB1C000h
foo_misc_addons                  loaded at 04CB0000h - 04CDB000h
foo_musicbrainz                  loaded at 6CA70000h - 6CAE0000h
foo_converter                    loaded at 6C9E0000h - 6CA6E000h
foo_masstag                      loaded at 05180000h - 051BD000h
foo_ui_columns                   loaded at 6C800000h - 6C9DE000h
USP10                            loaded at 6C7E0000h - 6C7F7000h
foo_queuecontents                loaded at 052C0000h - 0532E000h
foo_audioscrobbler               loaded at 05340000h - 05375000h
foo_playlist_attributes          loaded at 053D0000h - 0540B000h
foo_sanitizer                    loaded at 6C7C0000h - 6C7DF000h
foo_dsp_effect                   loaded at 05460000h - 054E3000h
foo_jesus                        loaded at 6C7A0000h - 6C7BA000h
foo_rgscan                       loaded at 6C750000h - 6C79D000h
foo_tfsandbox                    loaded at 6C700000h - 6C742000h
foo_cover_info                   loaded at 6C6D0000h - 6C6F3000h
foo_random_pools                 loaded at 054F0000h - 05528000h
foo_fileops                      loaded at 6C680000h - 6C6C2000h
foo_verifier                     loaded at 07B10000h - 07B53000h
foo_ui_std                       loaded at 6C560000h - 6C671000h
foo_run                          loaded at 07B70000h - 07BAA000h
foo_freedb2                      loaded at 6C520000h - 6C551000h
foo_playlist_manager             loaded at 07BB0000h - 07BF4000h
foo_dsp_vocal_exciter            loaded at 6C500000h - 6C514000h
foo_lastfm_playcount_sync        loaded at 6C4C0000h - 6C4F8000h
foo_input_sacd                   loaded at 6A840000h - 6ACCA000h
foo_dbsearch                     loaded at 07CB0000h - 07D20000h
foo_dsp_eq                       loaded at 6C490000h - 6C4B8000h
foo_run_group                    loaded at 6C460000h - 6C48C000h
foo_uie_playlists_dropdown       loaded at 07D20000h - 07D5C000h
foo_albumlist                    loaded at 6C410000h - 6C459000h
foo_dsp_resampler                loaded at 6C2D0000h - 6C407000h
foo_input_dsdiff                 loaded at 6C220000h - 6C24F000h
foo_masstag_addons               loaded at 07DB0000h - 07DCF000h
foo_utils                        loaded at 6A7F0000h - 6A834000h
foo_vis_vumeter                  loaded at 6A740000h - 6A7E5000h
foo_input_monkey                 loaded at 0FE50000h - 0FEA9000h
foo_dsp_fsurround                loaded at 154C0000h - 15599000h
foo_burninate                    loaded at 6A6C0000h - 6A6FE000h
foo_enhanced_spectrum_analyzer   loaded at 0FF10000h - 0FF53000h
foo_dsd_processor                loaded at 6A250000h - 6A608000h
foo_uie_elplaylist               loaded at 6A640000h - 6A6B3000h
foo_beefweb                      loaded at 6A0D0000h - 6A241000h

<snip>

Stack dump analysis:
Address: 00EE3BA4h (foobar2000+A3BA4h)
Address: 77DE5C7Eh (ntdll+45C7Eh), symbol: "RtlAllocateHeap" (+3Eh)
Address: 77DE5C7Eh (ntdll+45C7Eh), symbol: "RtlAllocateHeap" (+3Eh)
Address: 76000166h (ucrtbase+30166h), symbol: "malloc_base" (+26h)
Address: 00E49816h (foobar2000+9816h)
Address: 00FE8A58h (foobar2000+1A8A58h)
Address: 00F7A110h (foobar2000+13A110h)
Address: 01017608h (foobar2000+1D7608h)
Address: 00E491D4h (foobar2000+91D4h)
Address: 00F7A0F7h (foobar2000+13A0F7h)
Address: 00F7B976h (foobar2000+13B976h)
Address: 00FDFCE8h (foobar2000+19FCE8h)
Address: 6CA8ADD0h (foo_musicbrainz+1ADD0h)
Address: 6CAC5618h (foo_musicbrainz+55618h), symbol: "foobar2000_get_interface" (+23408h)
Address: 6CA771F1h (foo_musicbrainz+71F1h)
Address: 6CA773B0h (foo_musicbrainz+73B0h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC5618h (foo_musicbrainz+55618h), symbol: "foobar2000_get_interface" (+23408h)
Address: 6CAC2AE0h (foo_musicbrainz+52AE0h), symbol: "foobar2000_get_interface" (+208D0h)
Address: 01052E4Ch (foobar2000+212E4Ch)
Address: 6CABED70h (foo_musicbrainz+4ED70h), symbol: "foobar2000_get_interface" (+1CB60h)
Address: 6CABED3Ah (foo_musicbrainz+4ED3Ah), symbol: "foobar2000_get_interface" (+1CB2Ah)
Address: 6CA971F7h (foo_musicbrainz+271F7h)
Address: 77DDED10h (ntdll+3ED10h), symbol: "RtlLeaveCriticalSection" (+0h)
Address: 6CAC56DCh (foo_musicbrainz+556DCh), symbol: "foobar2000_get_interface" (+234CCh)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 77E277B4h (ntdll+877B4h), symbol: "RtlGetNtGlobalFlags" (+7B4h)
Address: 77E277B4h (ntdll+877B4h), symbol: "RtlGetNtGlobalFlags" (+7B4h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 77DE3AB6h (ntdll+43AB6h), symbol: "RtlFreeHeap" (+46h)
Address: 76003C9Bh (ucrtbase+33C9Bh), symbol: "free_base" (+1Bh)
Address: 76003C68h (ucrtbase+33C68h), symbol: "free" (+18h)
Address: 6CAC4474h (foo_musicbrainz+54474h), symbol: "foobar2000_get_interface" (+22264h)
Address: 6CABFC23h (foo_musicbrainz+4FC23h), symbol: "foobar2000_get_interface" (+1DA13h)
Address: 6CAA1027h (foo_musicbrainz+31027h)
Address: 6CABA760h (foo_musicbrainz+4A760h), symbol: "foobar2000_get_interface" (+18550h)
Address: 6CAC02B8h (foo_musicbrainz+502B8h), symbol: "foobar2000_get_interface" (+1E0A8h)
Address: 6CABA69Ah (foo_musicbrainz+4A69Ah), symbol: "foobar2000_get_interface" (+1848Ah)
Address: 6CABA760h (foo_musicbrainz+4A760h), symbol: "foobar2000_get_interface" (+18550h)
Address: 6CAC14B0h (foo_musicbrainz+514B0h), symbol: "foobar2000_get_interface" (+1F2A0h)
Address: 6CABA769h (foo_musicbrainz+4A769h), symbol: "foobar2000_get_interface" (+18559h)
Address: 76014F9Fh (ucrtbase+44F9Fh), symbol: "o_iswdigit" (+5Fh)
Address: 76014F60h (ucrtbase+44F60h), symbol: "o_iswdigit" (+20h)
Address: 76014F60h (ucrtbase+44F60h), symbol: "o_iswdigit" (+20h)
Address: 76031FD0h (ucrtbase+61FD0h), symbol: "crt_debugger_hook" (+C0h)
Address: 767DFA29h (KERNEL32+1FA29h), symbol: "BaseThreadInitThunk" (+19h)
Address: 767DFA10h (KERNEL32+1FA10h), symbol: "BaseThreadInitThunk" (+0h)
Address: 77E07C7Eh (ntdll+67C7Eh), symbol: "RtlGetAppContainerNamedObjectPath" (+11Eh)
Address: 777ADAE0h (KERNELBASE+1BDAE0h), symbol: "UnhandledExceptionFilter" (+0h)
Address: 7529BBCCh (MSWSOCK+BBCCh), symbol: "WSPStartup" (+21ECh)
Address: 77E1AF00h (ntdll+7AF00h), symbol: "wcstombs" (+70h)
Address: 77E07C4Eh (ntdll+67C4Eh), symbol: "RtlGetAppContainerNamedObjectPath" (+EEh)
Address: 77E288C2h (ntdll+888C2h), symbol: "RtlCaptureContext" (+F2h)
Address: 76014F60h (ucrtbase+44F60h), symbol: "o_iswdigit" (+20h)

Environment:
App: foobar2000 v1.6.5
UI: Columns UI 1.6.0

Components:
Core (2021-04-06 09:16:06 UTC)
    foobar2000 core 1.6.5
foo_acfu.dll (2019-01-12 12:00:54 UTC)
    Auto Check for Updates 0.3
foo_albumlist.dll (2021-04-06 09:15:10 UTC)
    Album List 1.6.5
foo_audioscrobbler.dll (2012-08-20 15:49:44 UTC)
    Audioscrobbler 2.3.1
foo_beefweb.dll (2020-02-02 06:11:58 UTC)
    Beefweb Remote Control 0.4
foo_bitcompare.dll (2021-03-04 17:26:38 UTC)
    Binary Comparator 2.2
foo_burninate.dll (2011-02-26 09:00:52 UTC)
    Audio CD Writer 3.0.3
foo_cdda.dll (2021-04-06 09:15:08 UTC)
    CD Audio Decoder 1.6.5
foo_converter.dll (2021-04-06 09:15:14 UTC)
    Converter 1.6.5
foo_cover_info.dll (2021-04-07 04:53:48 UTC)
    Cover Info 0.1.0
foo_dbsearch.dll (2007-01-25 20:58:48 UTC)
    Database Search 1.4
foo_discogs.dll (2020-04-11 05:21:32 UTC)
    Discogs Tagger 2.23
foo_dsd_processor.dll (2017-11-14 08:46:24 UTC)
    DSD Processor 1.0.2
foo_dsp_delta.dll (2008-10-24 15:57:16 UTC)
    Noise Sharpening DSP 1.0.0
foo_dsp_effect.dll (2021-03-21 09:36:00 UTC)
    Effect DSP 0.47
foo_dsp_eq.dll (2021-04-06 09:15:06 UTC)
    Equalizer 1.2.2
foo_dsp_fsurround.dll (2012-07-08 08:20:57 UTC)
    FreeSurround 0.9.0
foo_dsp_nogaps.dll (2017-04-22 08:30:04 UTC)
    Gap Killer DSP 0.4
foo_dsp_replaygain.dll (2021-03-27 18:57:44 UTC)
    ReplayGain DSP 0.2.6
foo_dsp_resampler.dll (2018-09-14 22:38:36 UTC)
    SoX Resampler 0.8.4 beta 2
foo_dsp_resampler_mod.dll (2018-11-17 08:31:30 UTC)
    SoX Resampler mod 0.8.4 mod
foo_dsp_src_resampler.dll (2021-02-20 11:50:06 UTC)
    SRC Resampler 1.0.12
foo_dsp_std.dll (2021-04-06 09:15:06 UTC)
    Standard DSP Array 1.6.5
foo_dsp_vocal_exciter.dll (2018-01-07 08:57:19 UTC)
    Vocal Exciter 1.0.1
foo_dsp_xgeq.dll (2012-07-07 17:49:02 UTC)
    Graphic Equalizer 0.3.7
foo_enhanced_playcount.dll (2021-03-20 22:33:38 UTC)
    Enhanced Playback Statistics 4.3.3
foo_enhanced_spectrum_analyzer.dll (2018-05-26 09:34:03 UTC)
    Enhanced Spectrum analyzer 0.9.4.2
foo_external_tags.dll (2020-09-20 15:53:32 UTC)
    External Tags 1.5.11
foo_fileops.dll (2021-04-06 09:15:16 UTC)
    File Operations 1.6.5
foo_freedb2.dll (2021-04-06 09:15:14 UTC)
    Online Tagger 0.8
foo_httpcontrol.dll (2013-04-26 16:12:30 UTC)
    HTTP Control 0.97.14-fb2kc
foo_input_dsdiff.dll (2018-01-24 21:59:23 UTC)
    DSDIFF Decoder 1.6
foo_input_dts.dll (2019-02-21 08:16:56 UTC)
    DTS decoder 0.6.8
foo_input_monkey.dll (2019-11-21 08:24:36 UTC)
    Monkey's Audio Decoder 2.3.1
foo_input_sacd.dll (2018-01-24 10:56:10 UTC)
    Super Audio CD Decoder 1.0.11
foo_input_std.dll (2021-04-06 09:15:36 UTC)
    FFmpeg Decoders 4.3.1
    Standard Input Array 1.6.5
foo_jesus.dll (2010-09-23 01:34:06 UTC)
    Autosave & Autobackup 10
foo_jscript_panel.dll (2021-04-01 16:06:56 UTC)
    JScript Panel 2.5.4
foo_lastfm_playcount_sync.dll (2020-02-08 22:29:20 UTC)
    Last.fm Playcount Sync 1.0.1
foo_masstag.dll (2019-08-17 07:30:18 UTC)
    Masstagger 1.8.5
foo_masstag_addons.dll (2009-02-10 22:54:08 UTC)
    Masstagger Addons 0.3.5 (SSE)
foo_misc_addons.dll (2010-01-14 21:06:10 UTC)
    Misc. Addons 1.1.6
foo_mouse_gesture.dll (2010-01-18 21:20:04 UTC)
    Mouse Gesture Host 0.5.2
foo_musical_spectrum.dll (2015-10-03 18:38:25 UTC)
    Musical Spectrum 0.9.1
foo_musicbrainz.dll (2020-05-17 02:05:44 UTC)
    MusicBrainz Tagger 0.4.6
foo_onewaysync.dll (2020-04-20 23:19:28 UTC)
    One Way Sync 0.7.0
foo_out_upnp.dll (2019-06-16 16:11:49 UTC)
    UPnP MediaRenderer Output 1.3.2
foo_out_wasapi.dll (2020-12-30 13:08:46 UTC)
    WASAPI output support 3.4
foo_playcount.dll (2020-07-01 22:00:50 UTC)
    Playback Statistics 3.0.4
foo_playlist_attributes.dll (2019-02-03 07:54:06 UTC)
    Playlist Attributes 0.5.5
foo_playlist_manager.dll (2007-01-22 13:05:12 UTC)
    Playlist Manager 1.0.2
foo_queuecontents.dll (2015-10-04 08:39:16 UTC)
    Queue Contents Editor 0.5.1
foo_quicksearch.dll (2015-10-15 16:15:54 UTC)
    Quick Search Toolbar 3.6
foo_random_pools.dll (2017-05-01 19:40:40 UTC)
    Random Pools 0.1.5
foo_rgscan.dll (2021-04-06 09:15:16 UTC)
    ReplayGain Scanner 1.6.5
foo_run.dll (2018-03-22 17:25:48 UTC)
    Run services 0.3.8
foo_run_group.dll (2017-07-03 20:12:33 UTC)
    Run services per group 1.01
foo_runcmd.dll (2010-01-07 19:32:34 UTC)
    Run Command 1.1
foo_sanitizer.dll (2021-02-15 14:49:24 UTC)
    Tag Sanitizer 1.3
foo_skip.dll (2021-03-21 07:25:50 UTC)
    Skip Track 1.33
foo_spider_monkey_panel.dll (2021-02-18 19:57:28 UTC)
    Spider Monkey Panel 1.4.2-dev+ce39bb09
foo_spotify.dll (2021-02-18 18:14:12 UTC)
    Spotify Integration 1.1.3
foo_texttools.dll (2010-09-12 17:33:56 UTC)
    Text Tools 1.0.5
foo_tfsandbox.dll (2016-12-14 21:48:26 UTC)
    Title Formatting Sandbox 1.0.3
foo_ui_columns.dll (2020-09-03 20:55:18 UTC)
    Columns UI 1.6.0
foo_ui_std.dll (2021-04-06 09:15:20 UTC)
    Default User Interface 1.6.5
foo_uie_console.dll (2020-04-11 11:10:10 UTC)
    Console panel 1.0.1
foo_uie_elplaylist.dll (2010-10-30 21:51:16 UTC)
    ELPlaylist 0.6.9.1.2(beta)
foo_uie_panel_splitter_mod.dll (2012-10-05 08:02:11 UTC)
    Panel Stack Splitter 0.3.8.3(alpha)
foo_uie_playlists_dropdown.dll (2009-09-23 23:44:46 UTC)
    Playlists Dropdown 0.7.6
foo_unpack.dll (2021-04-06 09:15:24 UTC)
    ZIP/GZIP/RAR/7-Zip Reader 1.6.5
foo_utils.dll (2008-02-08 23:26:58 UTC)
    Playlist Tools 0.6.2 beta 6
foo_verifier.dll (2020-07-02 11:34:34 UTC)
    File Integrity Verifier 1.4
foo_vis_vumeter.dll (2016-10-26 17:10:21 UTC)
    VU Meter 2013-02-16
foo_wave_minibar_mod.dll (2020-11-22 18:12:22 UTC)
    Waveform Minibar (mod) 1.0.43

Recent events:
MusicBrainz Tagger: Musicbrainz query failed.


Machine specifications:
OS: Windows 10.0.19042 x64
CPU: Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz, features: MMX SSE SSE2 SSE3 SSE4.1 SSE4.2
CPU threads: 4
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-13 18:08:32
See below last failure.txt. I've had to trim the module list.
Doesn't seem good. How comfortable are you with attaching to the debugger in Visual Studio (https://stackoverflow.com/questions/3841577/how-to-use-pdb-file-to-debug-the-application/37347438)?  :)

I include a .pdb file in the repo (https://github.com/kbuffington/foo_musicbrainz/tree/master/src/Release/foo_musicbrainz) so that you can actually get line numbers for some of these crashes. It either needs to be placed in the same folder as foobar.exe or in the same folder with the foo_musicbrainz.dll. I honestly can't remember which at the moment.

Barring your ability to do that, I'm not sure how to track this down if I can't replicate it. I'll let you know, but unfortunately my schedule is pretty busy at the moment and it may be a couple weeks before I can spend significant time on this.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-14 15:14:03
Okay, I'll experiment with Visual Studio. The main problem I see is that my music pc is a different pc to my development pc.
Title: Re: foo_musicbrainz
Post by: neothe0ne on 2021-04-14 15:49:44
FYI, Peter seems to have added this component to the online troubleshooter, so maybe he has logs too:
Quote
foo_musicbrainz.dll : MusicBrainz Tagger 0.4.6
Reason: Repeated crash reports.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-14 22:17:23
Okay, I'll experiment with Visual Studio. The main problem I see is that my music pc is a different pc to my development pc.
Yeah, that adds an unnecessary variable unfortunately. I've tried a bunch of different ways to replicate this, but I just can't figure out how it's happening. For testing I've been randomly making a call to a server that always returns 500, but the code handles that just fine. If you see the error dialog popup it means that the exception handling happened correctly, and it resolves gracefully (by throwing out all results... which isn't exactly ideal). I'll keep plugging away, but any other input you have would be appreciated.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-15 01:52:40
Tried a couple more things, still can't get it to error the way you're seeing. From the date you reported this it seems like it started happening once you upgraded to 1.6.5, is that right? Also, is this a portable install or regular?

I rebuilt the component with the latest SDK just in case there's some weirdness there, so let me know if the issue is still reproducible. There are currently no other changes here.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-19 18:01:53
0.4.7b2
- Now writing multi-value fields for labels
- More efficient use of space on tagger dialog
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-19 23:18:59
@MordredKLB
Many thanks for keeping trying to fix this. Yes, it did happen with 1.6.5 but not immediately, maybe 1-2 days after so I didn't link the two. Also, it's a regular installation. I have just updated to 1.6.6 b1 and not seeing the problem anymore - after extensive usage with both via album ID and artist & album name. I'll try your new version,  hopefully it doesn't return!.

PS. Now you have the code on your mind, any chance of sorting the Date problem ie option to use the ORIGINAL RELEASE DATE year?
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-21 05:24:27
PS. Now you have the code on your mind, any chance of sorting the Date problem ie option to use the ORIGINAL RELEASE DATE year?
Are you meaning sort first by ORIGINAL RELEASE DATE and then regular date? In normal use when searching for an artist/album the original release date is always going to be the same and just sorting on that would result in all releases for the same album essentially being random.

I get that in the case of the first four Peter Gabriel albums and other similar scenarios it could make sense though.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-21 08:17:13
Basically I'd like the option to use the year part of the ORIGINAL RELEASE DATE to populate the field obtained by %date%. This date seems to be the date of the first ever release. Currently it is populated with the date of the selected release.
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-04-21 10:09:27
Are you meaning sort first by ORIGINAL RELEASE DATE and then regular date? In normal use when searching for an artist/album the original release date is always going to be the same and just sorting on that would result in all releases for the same album essentially being random.

Black Sabbath: "Black Sabbath" was released in 1970.
The 2019 repackaging of the 2016 reissue series of the 2012 remaster of the 1970 album is still Black Sabbath: "Black Sabbath" from 1970.

Sorting that after all the other Black Sabbath: "Black Sabbath"? Through a secondary tag.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-21 14:52:57
Basically I'd like the option to use the year part of the ORIGINAL RELEASE DATE to populate the field obtained by %date%. This date seems to be the date of the first ever release. Currently it is populated with the date of the selected release.
I see, so you want to ignore the selected release date and always use the ORIGINAL RELEASE DATE (in 4 or 8 digit format).

Just in case you weren't aware you can cut/copy the text from Orig. Release date and paste it in the Date text field and it will do what you want right now. I think it's a smart option though because lots of people don't need the release date.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-21 14:58:20
Black Sabbath: "Black Sabbath" was released in 1970.
The 2019 repackaging of the 2016 reissue series of the 2012 remaster of the 1970 album is still Black Sabbath: "Black Sabbath" from 1970.

Sorting that after all the other Black Sabbath: "Black Sabbath"? Through a secondary tag.
It already is though:
(https://user-images.githubusercontent.com/2282004/115563812-86233c80-a27d-11eb-93fa-04e9560b8874.png)

There's no way to get that kind of granular information on a release though.
This is what you get for an individual release: https://musicbrainz.org/ws/2/release/?limit=100&query=reid:4cdc74f0-c13e-4019-9907-0fdf54f22205

Now some of those releases might have multiple release events & dates for different countries, but typically a remaster's reissue would get a different release group, and there's nothing tying it to a different one. We also can't split out by individual release events because some releases will have 100 release events (one for each country the album was available in), all with basically identical information. Not super helpful.
Title: Re: foo_musicbrainz
Post by: Mrakobes on 2021-04-22 15:51:03
If the title of the album (which is very common) contains notes (CD1), (Limited Edition), (Instrumental) extension issues "No matching results were found". how to reconfigure the script to cut off the tail of the phrase?
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-04-22 16:37:41
It already is though:
%date% should be the original date, is it?

No need to go as extreme as the ID3 standard, which was written so as to put the recording date in those tags (that is information often not even available anymore).
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-22 17:53:05
It already is though:
%date% should be the original date, is it?

No need to go as extreme as the ID3 standard, which was written so as to put the recording date in those tags (that is information often not even available anymore).

In the datagrid "Date" is the date of that release (the "release-event" in musicbrainz terms). When you select a row, what will be written to the tags for %date% is again the date of that specific release, and %original release date% is the earliest release event for any release in that musicbrainz release group.

The datagrid needs to be sorted that way otherwise (in the example of the first Black Sabbath album) you'd have 30 releases all with a date of 1970 and no way to easily tell which was the 2016 Warner remaster. I'm going to add an option to always write "original release date" into the %date% field though as lots of people probably want that and don't want to copy/paste the fields manually.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-22 17:56:01
If the title of the album (which is very common) contains notes (CD1), (Limited Edition), (Instrumental) extension issues "No matching results were found". how to reconfigure the script to cut off the tail of the phrase?
In my own personal tagger I do something similar, and can look at doing that in this component as well.
Title: Re: foo_musicbrainz
Post by: Mrakobes on 2021-04-23 07:22:09
@MordredKLB very interesting what is your tagger? The link under your post leads to this topic, please share
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-23 16:29:10
@MordredKLB very interesting what is your tagger? The link under your post leads to this topic, please share
Haha, should have expected that.

It's a tagger (https://github.com/kbuffington/mp3renamer) I started writing 16 years ago in a basically defunct programming environment that I no longer have access to, thanks to a change in jobs. I haven't been able to maintain it in at least 3 years. The only person it's useful to is me (or someone who likes my exact tagging scheme). I'm sorta working on rewriting it (https://github.com/kbuffington/mp3renamer2) in Angular/electron, but that project is verrrrry slow going cause I always find more pressing stuff to work on.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-04-24 11:56:24
It already is though:
%date% should be the original date, is it?

No need to go as extreme as the ID3 standard, which was written so as to put the recording date in those tags (that is information often not even available anymore).

I'm going to add an option to always write "original release date" into the %date% field though as lots of people probably want that and don't want to copy/paste the fields manually.
Thank you.
Title: Re: foo_musicbrainz
Post by: j7n on 2021-04-24 12:14:01
Can you make it easier to look up by TOC with a pregap? Perhaps look up a few common pregaps, 33, 31, 25.
Title: Re: foo_musicbrainz
Post by: Mrakobes on 2021-04-24 17:03:42
@MordredKLB I realized that it is impossible to use it without instruktion

... "how to reconfigure the script to cut off the tail of the phrase? "
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-25 08:30:48
@MordredKLB I realized that it is impossible to use it without instruktion

... "how to reconfigure the script to cut off the tail of the phrase? "
It's not a script. There's nothing you can change to fix this on your own. I'll have to push a new version to fix it.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-25 08:34:39
Can you make it easier to look up by TOC with a pregap? Perhaps look up a few common pregaps, 33, 31, 25.
Can you explain the issue a little bit more? I honestly never use the TOC lookup, but it seems to be working pretty well in my library.
Title: Re: foo_musicbrainz
Post by: j7n on 2021-04-25 12:05:14
If I load tracks from a CD into Foobar, it is not aware of the pregap duration. This results in a different TOC and lookup on MusicBrainz may not find results ("No matching results were found."), unless a disc ID with 0 pregap has also been added to the database by someone. The IDs are not reliable anyway, and often occur on multiple editions. The best way is to see all slightly relaxed matches and make a choice. An alternative is to go through CueTools to get the right ID, but it takes more steps and manual tagging. Typical pregaps (http://db.cuetools.net/stats.php) on old CDs.

I have version 0.4.6 from the Foobar repository. I don't know if there is a later update.
Title: Re: foo_musicbrainz
Post by: snotlicker on 2021-04-25 16:40:47
If I load tracks from a CD into Foobar, it is not aware of the pregap duration.

If the tracks are ripped from CD to standalone tracks then of course pregap info is lost but fb2k is more than capable of reading pregap info from an actual CD in the drive or a cuesheet.

(https://i.imgur.com/040Xlgq.png)

foo_musicbrainz has always been able to detect this and apply it correctly.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-25 19:54:49
snotlicker is right. The code to apply the pregap to the discid before submitting is still there and seems to be working correctly. "Relaxing" the pregap values essentially means trying with the original pregap (if one even exists) and then creating a disc id with several other pregaps. I'd need to check, but I assume that would require multiple musicbrainz calls, and doesn't seem like something you'd necessarily always want to do.

I don't have a disc drive in my computer anymore and all my media was ripped to mp3 long ago so I'm not sure I even have CUE files to do extensive testing of this with.
Title: Re: foo_musicbrainz
Post by: j7n on 2021-04-25 22:56:11
Tagging existing files without CD or cue is exactly the use case I'm thinking of. I also don't maintain cue files with correct filenames that could be loaded into Foobar.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-26 00:43:34
Tagging existing files without CD or cue is exactly the use case I'm thinking of. I also don't maintain cue files with correct filenames that could be loaded into Foobar.
I guess it comes down to the user's intention. If you're looking up by TOC the component assumes you want that EXACT release. If you don't have a pregap, then the only exact match is probably a web release, but it's also probably more frustrating to get no results than an extra result that isn't a perfect match.

If we don't find a pregap at all, loose matching seems most beneficial, whereas if you have one changing it to return more results seems... counterintuitive. I'll have to think about this some more and see what's possible.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-26 01:15:54
Actually after doing a little more reading, I think this is kind of moot issue. Sorry, it's been a little while since I've looked at this stuff so my memory needed some refreshing.

Standard pregap for REDBOOK is 2 seconds. That's required. If there is no pregap foo_musicbrainz defaults to 150 (2 seconds * 75 samples/s). The pregap can be longer than 2 seconds, but this typically only happens in cases where there's a hidden pregap track. There is no chance that the "32" value you shared is the initial pregap in 44% of all albums (32 samples is not a valid initial pregap which must be at least 150, and 32 seconds is a really odd number for a pregap).

The numbers your link seems to be showing must be pregaps "between" tracks, which aren't typically found anymore. If the album was ripped correctly then it's my understanding that those pregap samples would already have been included in the sample. If that's the case then there's nothing to do. I don't want to play around adding random extra samples in the hopes we find a match. Also, given how this functionality is written, there's not a clean way to make multiple requests at this stage. It would require substantial refactoring of the code for what I'm assuming would be low/no benefit.

Unless I'm substantially misunderstanding the issue I don't think there's really anything to do here.
Title: Re: foo_musicbrainz
Post by: snotlicker on 2021-04-26 09:21:45
The 31, 32 examples are additional sectors to be added to the default of 150 so you'd try with with 181, 182 etc. My screenshot of 2seconds above equates to 150 sectors on top of the default 150 so you'd start with 300 as per the detail shown here...

https://musicbrainz.org/cdtoc/cnzqAtpXYHa_LF9hj6j1AuYggz8-
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-27 01:23:18
The 31, 32 examples are additional sectors to be added to the default of 150 so you'd try with with 181, 182 etc. My screenshot of 2seconds above equates to 150 sectors on top of the default 150 so you'd start with 300 as per the detail shown here...

https://musicbrainz.org/cdtoc/cnzqAtpXYHa_LF9hj6j1AuYggz8-
Ahhhh... I missed the pregap += in the code.

In the case I'll take a look and see what can be done, but if it's going to require a substantial refactor then I think it's probably not worth the effort and mucking up the code significantly.
Title: Re: foo_musicbrainz
Post by: snotlicker on 2021-04-27 10:07:48
Well you know if I were still maintaining this, I'd have said nope owing to my laziness and/or miserableness.  :D
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-04-28 05:05:44
:D
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-05 05:15:47
If the title of the album (which is very common) contains notes (CD1), (Limited Edition), (Instrumental) extension issues "No matching results were found". how to reconfigure the script to cut off the tail of the phrase?
I did this. It attempts to remove a number of common edition or descriptor strings (CD1, Limited Edition, Deluxe Edition, 10th Anniversary, etc.) from the ends of albums. It does a case insensitive search and then lops off everything after that in the album field. It also recognizes that it can guess wrong so I added a checkbox to quickly get the original value back:

(https://user-images.githubusercontent.com/2282004/117095430-fcb74400-ad2b-11eb-82a5-5786dd074edf.png)
(https://user-images.githubusercontent.com/2282004/117095446-06d94280-ad2c-11eb-8018-25992e1a90d5.png)

Some album tag examples:
"Master of Puppets" -> No special text found so the check box will be hidden
"Master of Puppets Deluxe Edition" -> Will become "Master of Puppets"
"Master of Puppets [DELUXE EDITION]" -> "Master of Puppets"
"Master of Puppets {deluxe edition} Elektra Records 1986 Hetfield/Ulrich/Hammett/Burton" -> "Master of Puppets"
"Master of Puppets - 20th Anniversary" -> "Master of Puppets -" since I only strip [{( from the start of the search text
"Big in Japan (Japan Edition)" -> "Big in Japan"
"Big in Japan" -> No change
"Hellbilly Deluxe" -> No change

I tried to err on the side of caution, so usually "Edition" will need to be in the album title unless I'm reasonably confident that it wouldn't typically be part of a title. Test it out and if you've got some suggestions of other strings to search for (https://github.com/kbuffington/foo_musicbrainz/commit/8db0b0c28aa78cb6275175b42bf0bf7386d949fe#diff-df4b399d3da9b5ee446e9d1aab37b33a4fbd6a74652e2e86b0599d9cf9441d2eR313) let me know and I might add them.
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-05-05 07:33:50
Myself I have thrown all those descriptors into a custom tag and stripped them from album in order to avoid the problem, but:
* There is "version" where you would put "edition"
* there are users who remove that word ("version"/"edition") because it is redundant
* there are "digipak" and "promo" and "limited edition bonus" and "mispress" and ...
* "CD1" and "CD 1" and "CD#1" and "CD #1" ...

So what about a checkbox to disregard everything from "("? That would technically be everything from "(" or " (" I guess.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-05 17:23:34
Myself I have thrown all those descriptors into a custom tag and stripped them from album in order to avoid the problem, but:
* There is "version" where you would put "edition"
* there are users who remove that word ("version"/"edition") because it is redundant
* there are "digipak" and "promo" and "limited edition bonus" and "mispress" and ...
* "CD1" and "CD 1" and "CD#1" and "CD #1" ...

So what about a checkbox to disregard everything from "("? That would technically be everything from "(" or " (" I guess.
So to take a step back, the whole point of this is to make searching for results easier and save the user having to manually remove text when from the album name when needed so as to provide a proper match. Regardless of whether the component automatically does it for them, or they have to manually make edits, the end result will be that whatever is currently in the ALBUM field will be overwritten, so it doesn't really matter if there are redundant words or if "version" instead of "edition". I want to filter out the most common use-cases and be done with it. I could create a phrase list 100 long, but at some point utility begins to diminish. I've also seen lots of examples of files where these types of edition naming schemes come in, so I've got some idea of what's reasonably likely to be encountered by the average user. I don't want to try and predict how user Porcus tags his stuff, unless Porcus is distributing files to a whole bunch of people who will then be running this component on them. Hopefully that makes sense.

I don't want to add a checkbox for "(" because it's not uncommon to be used in album names (I have 70 in my library). It might make more sense for "[" (7 in my library) or "{" (0!), but again I'm not trying to hit every corner case. Also every little checkbox adds extra complexity to a dialog that should ideally just be "hit okay" 90% of the time.

That said, "digipack", "promo", "mispress" are all great. "limited edition" is already picked up, but "bonus tracks" would be good too. I'll add some extra CD variations as well.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-05-05 21:02:17
Am I missing something obvious? I've just eagerly installed 0.4.7 b3 thinking that my issue with using the Original Release date would be addressed but I can't see any changes.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-05 21:32:16
Am I missing something obvious? I've just eagerly installed 0.4.7 b3 thinking that my issue with using the Original Release date would be addressed but I can't see any changes.
It's done, but not in beta 3. Planning to release 0.4.7 tonight if there aren't any other issues found.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-05-05 21:53:11
Oh, okay I'll wait a wee while!

Just a small remark re trimming edition text. I'm seeing increasing downloads having  [Shm-cd] appended to the album title. Any chance of trimming it out?
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-05 21:58:24
Oh, okay I'll wait a wee while!

Just a small remark re trimming edition text. I'm seeing increasing downloads having  [Shm-cd] appended to the album title. Any chance of trimming it out?
Nevermind. Merry christmas. :)

Also, I added SACD, but should definitely do SHM-cd as well.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-05-05 23:04:34
Many thanks. Date handling now meets my needs - great.

But... [SACD] is trimmed but [SHM-CD] isn't.
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-05-05 23:27:40
So to take a step back, the whole point of this is to make searching for results easier and save the user having to manually remove text when from the album name when needed so as to provide a proper match.[...]
I might have gotten it wrong: Is this about searching, i.e. making queries MusicBrainz, or is it about what is written back to files after a search proved fruitful?

Both 0.4.7.b3 and 0.4.7.b4 as posted here, cause immediate crashes, so I cannot test. However. 0.4.6 gives zero hits when searching for my Master of Puppets using artist "Metallica" and album "Master of puppets ("
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-06 00:52:53
Many thanks. Date handling now meets my needs - great.

But... [SACD] is trimmed but [SHM-CD] isn't.
Yeah, it's not in the b4 build since I was already posting when I saw your response.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-06 04:18:57
I might have gotten it wrong: Is this about searching, i.e. making queries MusicBrainz, or is it about what is written back to files after a search proved fruitful?
It's just searching to get results back. Very rarely will musicbrainz ever have "Limited Edition" or whatever in the album titles.

Quote
Both 0.4.7.b3 and 0.4.7.b4 as posted here, cause immediate crashes, so I cannot test. However. 0.4.6 gives zero hits when searching for my Master of Puppets using artist "Metallica" and album "Master of puppets ("
That's not good. Did beta 1 or 2 (not sure I posted 2) cause any crashes? What version of foobar are you on? Also, when you say immediate crash do you mean on foobar startup or when performing some operation with the component?

Are you able to debug using the pdb file (beta4 (https://github.com/kbuffington/foo_musicbrainz/raw/054cd6a85ada894be60a64925672385eb1ec3440/src/Release/foo_musicbrainz/foo_musicbrainz.pdb))?
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-05-06 10:13:25
Just noticed that with latest beta, if I overtype the date field if there is no date given in any of the releases, it is ignored and a blank date is written to the tags on exit.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-06 16:52:25
Just noticed that with latest beta, if I overtype the date field if there is no date given in any of the releases, it is ignored and a blank date is written to the tags on exit.
Good catch. I'll fix that.
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-05-08 22:54:25
All right, so time for the most boring annoying reply: Got home, rebooted the computer, downloaded the betas, tried to get into precisely where it crashes - and am totally unable to reproduce. Damn ...

I might have gotten it wrong: Is this about searching, i.e. making queries MusicBrainz, or is it about what is written back to files after a search proved fruitful?
It's just searching to get results back. Very rarely will musicbrainz ever have "Limited Edition" or whatever in the album titles.
That's what I thought. This is for getting (more) hits. And because you will get the right hits - and then some - if you cut it off after some whole word, then there is not so much damage done by cutting off after "(" or "[" or "{"; at worst you get too many.

But likely the best would be to go for the full title first, and then a "found nothing, trying to find more"?
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-09 07:46:05
All right, so time for the most boring annoying reply: Got home, rebooted the computer, downloaded the betas, tried to get into precisely where it crashes - and am totally unable to reproduce. Damn ...
I can't decide if I should be happy or sad about that. :)

Quote
But likely the best would be to go for the full title first, and then a "found nothing, trying to find more"?
This is one of those things that is easier said than done. The problem is the multi-threaded nature. Essentially what happens is that regardless of search type (MBID, Artist/Album, TOC) we build out a request, and then it's handed off to another thread which makes the call and then a catchall callback takes the results and makes a request for each album in the results.

From this callback there's no non-hacky way to know what the original search type was, or how to get back to the original calling code block. Without some significant refactoring it becomes kind of a big mess of global variables and "if (callWasMadeAndNoResultsTryThis)".

I don't disagree with you that that's the way things should operate, but we're mostly stuck with trying to fix things up pre-search rather than post. I welcome all PRs though.
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-05-09 12:41:35
More happysadness coming up, I managed to provoke crashes. Will PM you.

As for functionality ... what about a button with "for more hits, try instead [box pre-filled with]"? Then it will do the full routine first, and if the user is dissatisfied, re-run the whole routine with a shorter album title. Point is, user won't have to go back to the list of
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-09 16:48:44
Mostly happiness since people are reporting crashes but I hadn't seen them. Squashed two of them. Try out the new beta5 and let me know if you have issues.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-11 20:14:50
Beta 6 fixes issues with dumb popups when aborting a search. It does not solve the odd crash when aborting, that I think is an foobar issue. Will be opening another thread for Peter to take a look at that.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-05-12 09:02:35
@MordredKLB
Thanks for your continued work on this component. I use it several times a day, I love it!

For a while I've been puzzled by this scenario: I try to tag an album by TOC..it fails. I then try using the artist/album and select the edition/release I want. The component then makes whatever adjustment to the tag contents, particularly title. However I have never been able to go back and try to retag this album using TOC. I would have thought that the first use would have adjusted the TOC to match the edition I chose. Any idea why this should be?
Title: Re: foo_musicbrainz
Post by: Porcus on 2021-05-12 09:54:52
TOC needs track lengths (as read from files) to accurately match the TOC in MusicBrainz. Those are unaffected by updating tags.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-12 19:14:07
Peter helped me track down the last crash when aborting a search, I did a little more cleanup and have officially released 0.4.7. Doing a component update will pull it down for you.
Title: Re: foo_musicbrainz
Post by: Sue Dunham on 2021-05-24 20:47:01
If you uncheck every metadata tag in Preferences > Tool > MusicBrainz Data, with Write MusicBrainz IDs enabled you get MUSICBRAINZ_...
ALBUMARTISTID
ALBUMID,
DISCID
RELEASEGROUPID
RELEASETRACKID
TRACKID
WORKID

But it will overwrite Album, Album Artist, Song, Date (and maybe genre). The only work around I have come up with is to call up Properties dialog for release you're tagging, then run Tagging > Get tags from MusicBrainz by TOC. After updating, cross-paste the overwritten tags from that propeties dialog window manually
I too would like to use this component just to get MBIDs, barcodes, and the like while leaving the rest of my tags unchanged. So let me echo this as a feature request to disable the overwriting of artist, title, etc.

I did find a different workaround, using masstagger (https://www.foobar2000.org/components/view/foo_masstag) to write artist, album artist, album, date, genre, and title to new tags: pre_artist, pre_albumartist, etc. I run the before_musicbrainz script first, do my musicbrainz stuff, and then copy everything back with the after_musicbrainz script. I suppose I could add actions to remove the "pre_" tags to the latter script, but I haven't; I figure I'll use tag sanitizer (https://www.foobar2000.org/components/view/foo_sanitizer) to do that and other things eventually.
Title: Re: foo_musicbrainz
Post by: 2tec on 2021-05-24 22:37:30
also would be great if it could load the relevant MusicBrainz web page if an id is present
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-25 00:36:48
I too would like to use this component just to get MBIDs, barcodes, and the like while leaving the rest of my tags unchanged. So let me echo this as a feature request to disable the overwriting of artist, title, etc.

I did find a different workaround, using masstagger (https://www.foobar2000.org/components/view/foo_masstag) to write artist, album artist, album, date, genre, and title to new tags: pre_artist, pre_albumartist, etc. I run the before_musicbrainz script first, do my musicbrainz stuff, and then copy everything back with the after_musicbrainz script. I suppose I could add actions to remove the "pre_" tags to the latter script, but I haven't; I figure I'll use tag sanitizer (https://www.foobar2000.org/components/view/foo_sanitizer) to do that and other things eventually.
I've been thinking about this for a while because there are obviously some tags a user will probably never want to write, and then some tags a user may want to write sometimes and not others.

I can obviously expand the properties page out to include every. single. tag. but for plenty of fields (artist/album/song title in particular) users will commonly want to opt-in/opt-out of those on a case by case basis. There is a lot of information conveyed on the current tagger dialog but space is very limited (and the size can't be expanded due to small screen size issues) so I'm struggling with the best way to address this.

Masstagger is a smart solution, but also unfortunately it's the only halfway decent one you've got right now. Anyway, it's on the todo list.
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-25 00:37:47
also would be great if it could load the relevant MusicBrainz web page if an id is present
Do you mean a right-click: "Open MB Release-Group page", "Open MB Recording page" option? Cause I like that idea.
Title: Re: foo_musicbrainz
Post by: 2tec on 2021-05-25 04:14:07
also would be great if it could load the relevant MusicBrainz web page if an id is present
Do you mean a right-click: "Open MB Release-Group page", "Open MB Recording page" option? Cause I like that idea.
Yes, exactly like the Discogs tagger does it, because I can then bind it to a button and open the appropriate page easily.
Title: Re: foo_musicbrainz
Post by: Sue Dunham on 2021-05-27 17:11:54
I've used foo_run for something like that. Add any service labels you want and put in a path that resembles whatever address a successful search result has. I have a few other services as well, since I usually end up searching for the album I want to tag there and tagging by album ID when I've found it.

Code: [Select]
Label               Path
MB Album ID         https://musicbrainz.org/release/%musicbrainz_albumid%
MB Artist + album   https://musicbrainz.org/taglookup/index?tag-lookup.artist=$replace(%artist%, ,+)&tag-lookup.release=$replace(%album%, ,+)
MB Barcode          https://musicbrainz.org/search?type=release&query=barcode%%3A$if2(%barcode%,%upc%)&advanced=1
MB Catalog no.      https://musicbrainz.org/search?query=catno%%3A$replace(%catalognumber%, ,+)&advanced=1&type=release

They're also then available for use in buttons under the context menu commands as "Run service/MB Album ID", or what have you.
Title: Re: foo_musicbrainz
Post by: Black_Over_Bills_Mothers on 2021-05-28 08:22:10
@MordredKLB
Since it sounds like you may be considering a few modifications to this component...

Would you please consider a fall-back mechanism where-by if tag by TOC fails rather than report no matches could you display the usual tag by artist & album window. If the user doesn't want that he can close it or he can proceed as normal.

Also, in the tagging window - bottom pane where you display: Filename, number and Title, could you make these columns auto size. In most cases there seems to be enough room. This would also be nice in the upper releases pane but there may not be enough room there.

Thanks
Title: Re: foo_musicbrainz
Post by: MordredKLB on 2021-05-29 07:01:00
Would you please consider a fall-back mechanism where-by if tag by TOC fails rather than report no matches could you display the usual tag by artist & album window. If the user doesn't want that he can close it or he can proceed as normal.
If it were easy I would have done it already. With the async nature and multi-threadedness of it there's not a "clean" way to do it. It bugs the hell out of me too (enough that I never use TOC) so maybe I can think of something.

Quote
Also, in the tagging window - bottom pane where you display: Filename, number and Title, could you make these columns auto size. In most cases there seems to be enough room. This would also be nice in the upper releases pane but there may not be enough room there.
I noticed this the other day. Will see why it's not autosizing like I'd expect it should. I think it's because there's a max size on filename and the rest are auto, but I'd need to confirm. If that's the case, it may not change since I just set the column attributes and PPUI (?) does the work and filename is the least important of those columns.
SimplePortal 1.0.0 RC1 © 2008-2021