Skip to main content

Topic: aoTuV Patches, Vorbis 1.3.5 and Lancer (Read 19821 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • Isayama
  • [*]
Re: aoTuV Patches, Vorbis 1.3.5 and Lancer
Reply #75
I am using the Archlinux AUR package. After updating the pkgsums to match the updated patch, the build fails on:

Code: [Select]
gcc: error: xmmlib.o: No such file or directory
(Full build log)

The build function uses:
Code: [Select]
./configure --prefix=/usr --disable-static

I removed "--disable-static" and then it worked.
Any insight?
  • Last Edit: 18 October, 2017, 12:15:02 PM by Isayama

  • Triza
  • [*][*][*][*]
Re: aoTuV Patches, Vorbis 1.3.5 and Lancer
Reply #76
Hello Isayama,

Great that few of us still enjoy this good mature format.

I have not looked into this in detail, but I have the old working version. The difference between old and new is this
Code: [Select]
diff libvorbis-aotuv_b6.03_2015-lancer.patch libvorbis-aotuv_b6.03_2015-lancer-v2.patch 
141c141
< +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.am 2015-09-11 15:18:53 +0000
---
> +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.am 2016-12-17 11:46:45 +0000
163c163
< +test_sharedbook_LDADD = @VORBIS_LIBS@ .libs/xmmlib.o
---
> +test_sharedbook_LDADD = @VORBIS_LIBS@ xmmlib.o
169c169
< +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.in 2015-09-11 15:12:20 +0000
---
> +++ aotuv-b6.03_20110424-20150808-lancer/lib/Makefile.in 2016-12-17 11:46:31 +0000
200c200
< +test_sharedbook_LDADD = @VORBIS_LIBS@ .libs/xmmlib.o
---
> +test_sharedbook_LDADD = @VORBIS_LIBS@ xmmlib.o

Enzo made the change for a guy who wanted to compile with 
Code: [Select]
--disable-shared --enable-static
parameters and for that we need this change. See Enzo's Edit3. Sounds like no-one tested that it does not work with original settings. Better would have been to version the patches.

Having said that if you patch the patch backward using this diff it should be good.

Having said that I am not sure... maybe even your current compile is just as good.

Triza
  • Last Edit: 19 October, 2017, 07:00:49 PM by Triza

  • Triza
  • [*][*][*][*]
Re: aoTuV Patches, Vorbis 1.3.5 and Lancer
Reply #77
They are great patches (thanks Enzo). I did not spot any issues with the encodes. I did not train my ears for artifacts (deliberately) and I enjoy quality 3. Amazing that ~100 kbps produces quality which feels like transparent. Obviously this could not be the case without Aoyumi's tireless efforts.

  • enzo
  • [*][*]
  • Developer
Re: aoTuV Patches, Vorbis 1.3.5 and Lancer
Reply #78
The first patch has been updated again to fix the issues when compiling with different --[dis|en]able-[shared|static] options.

I regenerated lib/Makefile.in this time instead of modifying it by hand. This should fix all potential issues caused by the inclusion of new files in the patch (cpu.c and xmmlib.c).

  • Isayama
  • [*]
Re: aoTuV Patches, Vorbis 1.3.5 and Lancer
Reply #79
Thanks a lot Triza & enzo, I confirm the build is successful after the fix with the aforementioned AUR package. Cheers!