Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Georgia: A dynamically generated fb2k theme (Read 48098 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Georgia: A dynamically generated fb2k theme

Reply #275
Just a heads up, the png artist logo for Tame Impala caused georgia to crash for me.
Not sure if it's something on my end but I fixed it by deleting the (corrupted?) png file.

Re: Georgia: A dynamically generated fb2k theme

Reply #276
Just a heads up, the png artist logo for Tame Impala caused georgia to crash for me.
Not sure if it's something on my end but I fixed it by deleting the (corrupted?) png file.
Weird, same thing happened to me. Created a new one which will be in the next image pack update.

Re: Georgia: A dynamically generated fb2k theme

Reply #277
Hello Mordred, thanks for the new release of Georgia. I'm getting crashes with v2.0.1 and fed with this error:

Error: Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred)
DrawLine failed:
GdiPlus error: DrawLine failed with error (0xb): ValueOverflow

File: ui-components.js
Line: 219, Column: 24
Stack trace:
  draw@ui-components.js:219:24
  draw_ui@georgia-main.js:556:18
  on_paint@georgia-main.js:949:2

This crash happens when I click on the show/hide playlist on many of my tracks. Hope you would be able to help me out.
Thanks again!





Re: Georgia: A dynamically generated fb2k theme

Reply #278
File: ui-components.js
Line: 219, Column: 24
Stack trace:
  draw@ui-components.js:219:24
  draw_ui@georgia-main.js:556:18
  on_paint@georgia-main.js:949:2

This crash happens when I click on the show/hide playlist on many of my tracks. Hope you would be able to help me out.
Thanks again!
This looks like it's going to be specific to your library (and probably will always happen on the same songs for you) so I'll need some help debugging. Can paste this line into ui-components.js, directly before the gr.DrawLine currently on 219.
Code: [Select]
					console.log(`>>> x: ${x}, y: ${this.y}, h: ${this.h}, col: ${this.playCol}`);
Then replicate the crash with the console open, and paste just the last output of that line (there will be a bunch!) before the crash occurs.

Re: Georgia: A dynamically generated fb2k theme

Reply #279
Hello, I did as you said, this is what i got

Code: [Select]
Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred): initialized in 1 ms
in on_init()
in on_size() => width: 2560, height: 1104
Playlist initialized in 93ms
Fetching new art
on_metadb_changed()
lastfm: []
foobar: [1833029933771000, 1603800926000, 1605000650000, 1605006123000, 1605024247000, 1605604803000, 1605959717000, 1606415664000, 1608378028000, 1613116067000, 1613668340000, 1615289295000, 1615290057000]
Georgia loaded in 464ms
>>> x: -15915, y: 175, h: 18, col: 1275068415
>>> x: -20629, y: 175, h: 18, col: 1275068415
>>> x: -21724, y: 175, h: 18, col: 1275068415
>>> x: -22577, y: 175, h: 18, col: 1275068415
>>> x: -23971, y: 175, h: 18, col: 1275068415
>>> x: -24015, y: 175, h: 18, col: 1275068415
>>> x: -24028, y: 175, h: 18, col: 1275068415
>>> x: -3206, y: 175, h: 18, col: 1275068415
>>> x: -26910, y: 175, h: 18, col: 1275068415
>>> x: -4533, y: 175, h: 18, col: 1275068415
>>> x: 688, y: 175, h: 18, col: 1275068415
>>> x: 690, y: 175, h: 18, col: 1275068415
>>> x: 4399524046, y: 175, h: 18, col: 1275068415
foo_spider_monkey_panel:
Error: Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred)
DrawLine failed:
GdiPlus error: DrawLine failed with error (0xb): ValueOverflow

File: ui-components.js
Line: 220, Column: 24
Stack trace:
  draw@ui-components.js:220:24
  draw_ui@georgia-main.js:556:18
  on_paint@georgia-main.js:949:2


Re: Georgia: A dynamically generated fb2k theme

Reply #280
Thanks so much! Here's the issue:
foobar: [1833029933771000, 1603800926000,

>>> x: 688, y: 175, h: 18, col: 1275068415
>>> x: 690, y: 175, h: 18, col: 1275068415
>>> x: 4399524046, y: 175, h: 18, col: 1275068415
That 1833029933771000 timestamp = Sun May 28 60056 00:36:11 GMT-0500 (Central Daylight Time). Presumably you did not change your system time to be 58k years in the future, so the file is corrupted or there's a bug in the foo_enhanced_playcount component.

For now you can do 1 of 2 things: uninstall foo_enhanced_playcount, or more simply, just change the following line in ui-components.js:
Code: [Select]
if (!isNaN(x)) {
to
Code: [Select]
if (!isNaN(x) && x <= this.w) {
That should completely prevent the crash. I'll send you a PM about the foo_enhanced_playcount issue because currently there's no way to reset the foobar plays that it knows about.

Re: Georgia: A dynamically generated fb2k theme

Reply #281
Replied to your PM, thanks again!

Also want to add that I am Japanese and my PC is using the Japanese locale, I'm not sure if that has any issues with the system time because I have encountered some programs that didn't work well with Japanese system time as well.

Re: Georgia: A dynamically generated fb2k theme

Reply #282
Could be that playcount stores play times in a different timestamp format now?

Re: Georgia: A dynamically generated fb2k theme

Reply #283
Could be that playcount stores play times in a different timestamp format now?
foo_playcount_enhanced has always stored the full, down-to-the-nanosecond timestamp that foobar uses internally. What are you saying is different now?

Re: Georgia: A dynamically generated fb2k theme

Reply #284
@linuxlight You can ignore georgia-theme.js for now. The font code in georgia-main.js hasn't been touched in 8-12 months at least. What doesn't work if you change, say, fontThin to a different font? Are you positive you've got the name right? Right click the otf/ttf font in Windows and select Preview and then usually the correct font name to use will be listed as Font Name up at the top. Sometimes it's not the correct way to address it though.

Finally I found what I've missed, the problem was that I passed 'Non-English' font name to the Spider Monkey Panel!
It seems that Spider Monkey Panel decodes javascript file as US-ASCII charset, so SMP couldn't understand my 'Non-English' font name.
Using
Code: [Select]
fc-list | grep
in MacOS, I found all my fonts name in English and all problems has been solved. ;)

Thanks for all your consideration for Georgia-Theme fans, and as always thanks for your wonderful masterpiece! O:)  O:)


Re: Georgia: A dynamically generated fb2k theme

Reply #286
It seems that Spider Monkey Panel decodes javascript file as US-ASCII charset
PS: If you save your script file with UTF8 BOM, SMP will correctly use UTF8 to decode it.

Re: Georgia: A dynamically generated fb2k theme

Reply #287
It seems that Spider Monkey Panel decodes javascript file as US-ASCII charset
PS: If you save your script file with UTF8 BOM, SMP will correctly use UTF8 to decode it.

Actually, I did a little bit of search about setting script file with UTF-8 BOM, but couldn't figure out how to save script file into UTF-8.  :))  :))
I struggled with my Windows Notepad's "save as..." feature to change script file charset, but couldn't resolve my problem.  :-[
Maybe in the near future I should try UTF-8 BOM once more! Thanks for noticing me a good tip.  :)

PS : I love SMP! Making Spider Monkey into foobar2k panel made fb2k even better, thanks!

Re: Georgia: A dynamically generated fb2k theme

Reply #288
As I am using Georgia regularly with youtube or soundcloud playlists: I am experiencing that since Georgia 2.0.0 the artwork assigned to a youtube or soundcloud link is not in all cases updated when track is changing ('Cycle through all artwork' has to switched on in all cases for yt artwork):
- Artwork is updated as intended when track is changed manually by 'Next'.
- Artwork remains with previous track if track is changed automatically at the end of the previous track.
I think even with the SMP beta versions 2.0.0-bx the update of yt artwork still worked as well for automatic track change (sorry, didn't test), limitation seems to be introduced with 2.0.0

Just found by chance a workaround to get back to intended behaviour:
1. Switch off 'Cycle through all artwork'
2. do a manual track change
3. Switch on 'Cycle through all artwork'
So - don't bother, it's a great theme!!



Re: Georgia: A dynamically generated fb2k theme

Reply #290
Great, thanks for the upcoming fix!!
Do you prefer opening an issue at GitHub vs reporting here at HA?

Re: Georgia: A dynamically generated fb2k theme

Reply #291
Do you prefer opening an issue at GitHub vs reporting here at HA?
If it's a support question, then here is best. If it's a bug or you think something isn't working right, github ticket is the easiest way to make sure I don't forget about it.

Re: Georgia: A dynamically generated fb2k theme

Reply #292
Everything's working pretty well, I'm surprised how far you've come along with this theme! It's all I use.

I'm not sure how to get the lyrics to work though. I downloaded the Lyrics show component because I wanted the words for a Johnny Cash song I'm trying to learn for a cover. So I did a search through the component (right click>Download lyrics) and it said "nothing found." I thought no big deal, I'll just copy and paste them from Google into the file itself, so I right clicked on the track in playlist view > properties > added a metadata field called "lyrics" and pasted the lyrics. Georgia still will not display the lyrics, it says "No lyrics found" no matter how many times I refresh and restart. What could I be doing wrong? My jsonc file definitely has %lyrics% under title format strings.

Re: Georgia: A dynamically generated fb2k theme

Reply #293
Thanks for your amazing work @MordredKLB:)

I'm using Georgia v2.0.2 and everything is perfectly, I have just one question, the option "Refresh" in the Library has been disabled? now I can only see the option "View by folder structure"



Re: Georgia: A dynamically generated fb2k theme

Reply #295
Thanks for your amazing work @MordredKLB:)

I'm using Georgia v2.0.2 and everything is perfectly, I have just one question, the option "Refresh" in the Library has been disabled? now I can only see the option "View by folder structure"
So does Refresh do anything other than reload the Library? I thought it was refreshing the theme (as the other options were Configure and Panel Properties which I didn't want people messing with) so I just removed the whole thing. I can't really figure out what the point of Refresh is though.

If the idea is to refresh the Library because it doesn't notice songs that were added to the Media Library after starting, it seems like it'd be easier to just watch the events and auto-refresh. Let me know if that's what you're using it for and I'll try and make that change, otherwise I can just add Refresh back in.

Re: Georgia: A dynamically generated fb2k theme

Reply #296
Thanks for your amazing work @MordredKLB:)

I'm using Georgia v2.0.2 and everything is perfectly, I have just one question, the option "Refresh" in the Library has been disabled? now I can only see the option "View by folder structure"
So does Refresh do anything other than reload the Library? I thought it was refreshing the theme (as the other options were Configure and Panel Properties which I didn't want people messing with) so I just removed the whole thing. I can't really figure out what the point of Refresh is though.

If the idea is to refresh the Library because it doesn't notice songs that were added to the Media Library after starting, it seems like it'd be easier to just watch the events and auto-refresh. Let me know if that's what you're using it for and I'll try and make that change, otherwise I can just add Refresh back in.
Yes, I used "Refresh" to reload the library when I added new albums/songs, because sometimes songs/albums were not displayed after adding them.

Re: Georgia: A dynamically generated fb2k theme

Reply #297
Yes, I used "Refresh" to reload the library when I added new albums/songs, because sometimes songs/albums were not displayed after adding them.
I just click "View by folder structure" and it's the same as hitting refresh. The same should apply for if you view by artist or whatever.

Re: Georgia: A dynamically generated fb2k theme

Reply #298
I added refresh back in, but I also attempted to remove the need for Refresh, and now the Library watches for changes and updates accordingly, although I still need to do some more tests.

That said, don't download master at the moment. I'm in the middle of redoing the Library code and bringing it more up to date than the version I've got, and this has caused tons of new issues/crashes/bugs. On the plus side, I think I probably won't need to revert everything, but it's definitely not ready for primetime at the moment.

Re: Georgia: A dynamically generated fb2k theme

Reply #299
Hello, I really love your theme and have been using it for a couple years now. I'm trying to upgrade to the newest version from v1.1.6. I replace everything in my Georgia folder with the update but get a crash immediately upon opening foobar. The error says:

JScript Panel v2.2.2.4 (Georgia by Mordred)
JavaScript compilation error:
Syntax error
File: C:\Users\CRE\AppData\Roaming\foobar2000\georgia\js\helpers.js
Line: 2, Col: 1
const lodash = _.noConflict();

Thank you for any help

 
SimplePortal 1.0.0 RC1 © 2008-2021