Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Georgia: A dynamically generated fb2k theme (Read 94879 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Georgia: A dynamically generated fb2k theme

Reply #100 –
Thanks ravenmyst, playlist font is much better now! Only thing on my side - the menu list on the left upper side got lost.

Re: Georgia: A dynamically generated fb2k theme

Reply #101 –
Quote from: PrinceSnake on
Hello, thank for your work, I have followed every step closely you told but it does not open properly, FOOBAR just crash.

What the console says :

JScript Panel v2.3.6 (Georgia by Mordred)
Erreur d’exécution JavaScript:
Impossible d’obtenir la propriété  « 0 » d’une référence null ou non définie
File: C:\Users\Username\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2996, Col: 2
--

Where are located the js files :
C:\Users\Username\AppData\Roaming\foobar2000\georgia\js
Where Foobar is currently installed :
C:\Program Files (x86)\foobar2000

What did I have done wrong to get that result?


If you check the console you'll probably see a message that starts with:
"ATTENTION: Buttons could not be created, most likely because the images were not found in...."?

It'll tell you location it's looking for button images in.

Re: Georgia: A dynamically generated fb2k theme

Reply #102 –
Quote from: ravenmyst on
Love the work so far on this. Just wanted to let you know, I found the playlist font to be uneditable for some reason; either through the menu, or anything else I had tried. Weirdly, the when switching to 4K version that switched the playlist font size; however, everything else was then too big. I started tinkering around, and here's my custom fork: https://github.com/ravenmyst/Georgia

I increased the playlist font size, increased the icon size (got rid of the lyrics one for example, since I dont use it). I am starting to fall behind master though. My resolution is 1920x1080 / 2560x1440. Hope this can help; not sure how to PR this since it's guesswork on my end.
Yeah, at the moment the playlists fonts aren't configurable. I'm wondering if I should try and base them off DPI, and just ditch the `is_4k` stuff for fonts. That's a lot of work and for now I'll probably add two configurable font sizes for playlists (one for Headers, and one for individual rows).

Did you find them too small in 1920x1080 resolution? 2560x1440 is probably way too small to read if you disable 4k mode (i.e. you're sitting directly in front of the screen) engaged.

Re: Georgia: A dynamically generated fb2k theme

Reply #103 –
I could read it, but in my opinion, it was too small on both my 1920x1080 and 2560x1440 displays.


Quote from: MojoBass on
Thanks ravenmyst, playlist font is much better now! Only thing on my side - the menu list on the left upper side got lost.
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189

Re: Georgia: A dynamically generated fb2k theme

Reply #104 –
Also, my playlist row height is 40 for anyone else wondering!

Re: Georgia: A dynamically generated fb2k theme

Reply #105 –
Quote from: ravenmyst on
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Just for the record, if you do this, you'll be hiding the Options menu and then there's no way to get access to some of the display options which you might want to play around with.

Re: Georgia: A dynamically generated fb2k theme

Reply #107 –
It has been ages since I last updated my skin used for tagging in DUI. Then searching on the forum out of the blue and stumbled upon this! The setup is conveniently easy since everything is wrapped in a JScript panel. Loaded flawlessly on foobar 1.5.3.

Just one question though, I downloaded the latest release and noticed that the whole window will show the artwork + info properly, but then it will just mysterious dissapear after some time. Checked my console and found "<Error: Image could not be properly parsed: G:\Music (unsorted)\!! By Series [copied to mybook]\Professor Layton\Profesor Layton and the Curious Village\folder.tags>". The .tags is generated from External Tags plugin. Seems like it's trying to load folder.tags, failed, then display nothing instead. Is there an option to specify which image to use as album art, or rather a pattern matching? Or even better, an exception handler for this?

Ah found it, it's in the global.js. Changed to folder.jpg instead of .* Perhaps it's good to include this option in the Options?
// GLOB PICTURES
tf.glob_paths = [ // simply add, change or re-order entries as needed
   '$replace(%path%,%filename_ext%,)folder.jpg',
   '$replace(%path%,%filename_ext%,)*.jpg',
   '$replace(%path%,%filename_ext%,)*.png',
   '$replace(%path%,%directoryname%\\%filename_ext%,)folder.jpg' // all folder images in parent directory
];

Anothoer question, is it possible to change cd.png to disc.jpg, or a field to change the pattern? I have all my disc named as disc.jpg. Would be awesome if can make it spinning in real time like XBMC.

Found it,I changed to pref.cdart_path = "$replace(%path%,%filename_ext%,)disc.png". Is it possible to have a list of possible cd source just like the album art source to cycle to?

Most of my disc are in non transparent .jpg with white background instead of .png. Not sure if there's a way to apply chroma key on those .

Re: Georgia: A dynamically generated fb2k theme

Reply #108 –
Quote from: MojoBass on
Quote from: ravenmyst on
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Hmm, even if I change line 189 in globals.js from 'false' to 'true', the menu is not shown...
Just checked and my theme doesn't actually use that setting, so ravenmyst must have actually removed the code in his version.

Re: Georgia: A dynamically generated fb2k theme

Reply #109 –
Quote from: D.Sync on
Seems like it's trying to load folder.tags, failed, then display nothing instead. Is there an option to specify which image to use as album art, or rather a pattern matching? Or even better, an exception handler for this?
Thanks for finding this. Just added a filter to remove anything that isn't a .jpg or .png.

Quote
Anothoer question, is it possible to change cd.png to disc.jpg, or a field to change the pattern? I have all my disc named as disc.jpg. Would be awesome if can make it spinning in real time like XBMC :)
This problem is that a disc.jpg is not transparent, and there's no automatic way to make it transparent. It'll stay as cd.png for now.

Re: Georgia: A dynamically generated fb2k theme

Reply #110 –
Thanks for the reply Mordred!

As for the chroma key on JPEG, perhaps not important but something that can be look into:
I found a jslibrary that can apply chroma key to JPEG https://www.w3.org/2013/chroma/chroma-key.js. Unfornately it is written to parse <img> tag in HTML. I tried to embed into your script but not sure how to get the frame data, or in this case, the cdart data parsed by the gdi. Using console.log(cdart) return 0 so it's hard to see what attribute are there in that object.

It has beeen quite some time since I last programmed in jS.

  apply_key: function (canvas, ctx, key, d)
  {
    var frame = ctx.getImageData(0, 0, canvas.width, canvas.height);

    for (var j = 0; j < frame.data.length; j += 4)
    {
      var r = frame.data[j];
      var g = frame.data[j+1];
      var b = frame.data[j+2];

      if (key.r - d <= r && r < key.r + d &&
          key.g - d <= g && g < key.g + d &&
          key.b - d <= b && b < key.b + d)
      {
        frame.data[j + 3] = 0;
      }
    }

    ctx.putImageData(frame, 0, 0);
  },

Re: Georgia: A dynamically generated fb2k theme

Reply #111 –
Interesting code, but that's actually for drawing on an HTML canvas control which the jscript_panel doesn't support.

Re: Georgia: A dynamically generated fb2k theme

Reply #112 –
Quote from: MojoBass on
Quote from: ravenmyst on
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Hmm, even if I change line 189 in globals.js from 'false' to 'true', the menu is not shown...

https://github.com/ravenmyst/Georgia/blob/master/js/georgia-main.js#L2953

Sorry about that. Try unncommenting this block ( remove ln 2953 and 2983 )

Re: Georgia: A dynamically generated fb2k theme

Reply #113 –
Quote from: ravenmyst on
Try unncommenting this block ( remove ln 2953 and 2983 )
Thanks ravenmyst, the menu is back.
Is it possible that CD Art is as well deactivated?

Re: Georgia: A dynamically generated fb2k theme

Reply #114 –
Quote from: dwmartin0906 on
3.  The new randomize function works well, but does have what may be an unintended consequence.  I started playing on track 1, then pressed the randomize button.  This moved track 1 down to the next to the last track.  After it and the next tracked finished playing, playing stopped until I pressed the play button again.
Just pushed a fix for this to the repo. If playing a song, the playlist it's in will be randomized and that song will move to the top of the playlist. If no song is being played, the entire playlist is randomized and the first song begins to play. In both cases the now playing song will scroll into view.

Re: Georgia: A dynamically generated fb2k theme

Reply #115 –
Quote from: MojoBass on
Quote from: ravenmyst on
Try unncommenting this block ( remove ln 2953 and 2983 )
Thanks ravenmyst, the menu is back.
Is it possible that CD Art is as well deactivated?

Not afaik. CD Art/including the disc/boxes work for me. I did change the regex slightly to be more expansive (discart.png can also  be cd image) because Kodi digests it that way. But it should read files all the same, though don't name them discart if it's not art of the disc.  e.g. my disc is discart.png, and album can be folder.jpg or something

I'm assuming of course that it was working in the other version.

..So I have a question. I am using default ui (not columns) and it works 99% of what I want, though I was wondering if there's a way to snugly fit other jscript panels like equalizer, volume, etc, or something, to give it the full app feel, that way nothing foobar is left.

Re: Georgia: A dynamically generated fb2k theme

Reply #116 –
Hi.  I downloaded your latest version and the randomize function works great now.  I did notice there is still the issue where scrolling the volume bar also scrolls the library and playlist panels if displayed.  This is a very small issue and not worth spending much time on, but you indicated it had been fixed in a previous post so I just wanted to mention it.  Otherwise, everything is working great, and I greatly appreciate all the time and effort you continue to put into this wonderful theme.

Re: Georgia: A dynamically generated fb2k theme

Reply #117 –
Quote from: dwmartin0906 on
Hi.  I downloaded your latest version and the randomize function works great now.  I did notice there is still the issue where scrolling the volume bar also scrolls the library and playlist panels if displayed.  This is a very small issue and not worth spending much time on, but you indicated it had been fixed in a previous post so I just wanted to mention it.  Otherwise, everything is working great, and I greatly appreciate all the time and effort you continue to put into this wonderful theme.
Oops, didn't realize that was happening. marc2k3 submitted a PR that fixed the issue. It's been merged along with a ton of other new crap including:

Refactored options menu. I wrote brand new helper functions for this stuff to make creating new menus/options a breeze to manage, and so I'm able to cram anything I want in there without any of the painful issues I had before. So I've added tons of stuff under Options.

New Options:
 * Resizable playlist row and header fonts
 * transport controls below artwork (still tweaking this slightly)
 * exposed more transport settings
 * lots of new playlist settings moved out of the Playlist Appearances right click menu (although it's still there too)

This is a big release so I'm gonna need to do a beta very soon. Hopefully in the next 48 hours that'll be coming.

Re: Georgia: A dynamically generated fb2k theme

Reply #118 –
I'm looking forward to checking out your latest changes.  Georgia is more than just another theme for me.  I was a mainframe COBOL programmer for almost 40 years, since the days of paper punch cards, and really miss coding.  Georgia is an opportunity for me to finally learn Java and I'm having a lot of fun with it.  You mentioned adding some new transport options.  I wanted to mention the ones I have added in case you thought others might be interested in them.  These include volume muting, console display, minimize, maximize/restore, full screen and exit.  I did see some existing code for some of these, but it seemed to be incomplete.  I'll download your new version as soon as it's available and run it through its paces before I retrofit my own changes to see if I can find any issues.  I don't expect to find many.  I'll let you know what I find.

Re: Georgia: A dynamically generated fb2k theme

Reply #119 –
v1.1.8-beta1 now available here: https://github.com/kbuffington/Georgia/releases

Re: Georgia: A dynamically generated fb2k theme

Reply #120 –
Quote from: dwmartin0906 on
I wanted to mention the ones I have added in case you thought others might be interested in them.  These include volume muting, console display, minimize, maximize/restore, full screen and exit.  I did see some existing code for some of these, but it seemed to be incomplete.
Some of those like, min/max/close are meant to only work when ui_hacks is enabled. For a long time that was considered a banned component and so I left in some of the code that was there for it but mostly commented it out. It's been probably 7 years since I had ui_hacks installed, so I should probably go back and get that stuff working again at some point (any uncommented code for ui_hacks is probably hopelessly broken right now) because I know people like it. I've just learned to live without it :)

Re: Georgia: A dynamically generated fb2k theme

Reply #121 –
I've finished checking out your latest version and only found a couple of minor issues.  When using the mouse to scroll the volume bar, the tooltips only appear the first time and I have to reload to get them back.  I think you fixed this earlier, but it's back.  And Properties won't let me change the user row height for the playlist panel.  Oddly, it was stock on 30 before my retrofits, and on 23 after.  Everything else worked great.  I can now scroll the volume bar without effecting the other panels.  Moving the transport buttons below the artwork works well and even picked up the new buttons I added.  Resizing the playlist header and row works great and I can now get rid of my hard coded sizes.  I was pleased that the web links work now.  Trying to use them before crashed Georgia. The eCover link doesn't seem to work, but I don't even know what that is.  I don't use CD art, so I couldn't test that.  I tested before retrofitting my code and was pleasantly surprised that I didn't break anything with my changes.

I didn't realize UI Hacks was banned, but it hasn't caused any issues and I really like some of its features.  Thank you again for all your time and effort.
 

Re: Georgia: A dynamically generated fb2k theme

Reply #122 –
Thanks MordredKLB, these are great improvements! Can change the playlist font sizes without restrictions.
CD Art works as well as always.
Some more ideas:
Would be nice to be able to change the font size of the menu as well + the size of the transport control icons.
I somehow miss some of WilBs Library settings options such as Node Style (Squares/Angles/...) or Theme mode (Dark/Blend/Light/Cover).

Re: Georgia: A dynamically generated fb2k theme

Reply #123 –
Quote from: dwmartin0906 on
When using the mouse to scroll the volume bar, the tooltips only appear the first time and I have to reload to get them back.  I think you fixed this earlier, but it's back.  And Properties won't let me change the user row height for the playlist panel.  Oddly, it was stock on 30 before my retrofits, and on 23 after.
Tooltips are still a little flaky. I haven't messed with them since I thought I had them working again, so I can't 100% explain what's happening, but I've seen it.
The row_h in the properties is now calculated based on the playlist row font size. I should probably figure out how to pull it out of the properties as it's not needed anymore, but it's used in a bunch of places.
I also fully removed eCover from the list of weblinks.

Quote
I didn't realize UI Hacks was banned, but it hasn't caused any issues and I really like some of its features.  Thank you again for all your time and effort.
It's no longer banned. Policy has changed. Someday I'll revisit that functionality as it would be cool to get rid of the title bar.

Re: Georgia: A dynamically generated fb2k theme

Reply #124 –
Quote from: MojoBass on
Would be nice to be able to change the font size of the menu as well + the size of the transport control icons.
I somehow miss some of WilBs Library settings options such as Node Style (Squares/Angles/...) or Theme mode (Dark/Blend/Light/Cover).
Changing menu font and transport control sizes are also on my list of things to do. Might even do it before 1.1.8 releases, but no promises.
I pulled a ton of stuff out of WillB's library stuff just for simplicity and because I wanted control over how everything looked. There were also about 100 properties that WillB used, and I had 100 properties and his didn't always have clear or consistent naming, and it become hard to find anything in that damn dialog, etc. That wouldn't be a problem with a good menu setup, but I still require users to go in there to edit Title Formatting strings if they want. I tried to see how much work it'd be to add the theme mode back in, and apparently I removed some required code instead of just commenting it out, and it seemed more trouble than it's worth for now.