HydrogenAudio

Hosted Forums => foobar2000 => 3rd Party Plugins - (fb2k) => Topic started by: MordredKLB on 2018-06-29 16:33:02

Title: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-29 16:33:02
(https://i.imgur.com/pspQQeb.png)

At long last I'm pleased to announce that my theme Georgia is available for public use. Georgia is a dynamically generated theme which uses album art to choose colors for it's panels. It was originally designed for running full screen on HTPCs, but also works well in a standard desktop environment. Georgia also looks amazing in 4k.

Gallery of what's possible with Georgia (https://imgur.com/a/TtjUS)

Inspired by XBMC/Kodi, I might have created the first fanart based fb2k theme years ago, and Georgia is the logical conclusion of that work. It supports band logos, record label images, cdArt/vinylArt, multiple covers, etc. It's designed primarily to look good, and look good on a big screen, so it is lacking some functionality that other themes have.

Get Georgia now (https://github.com/kbuffington/Georgia). Be sure to follow the installation instructions.

NOTE: Georgia is currently in beta. There will probably be some bugs/crashes. I'm pretty sure the lyrics display is not working correctly. I'm hoping some of you folks will be kind enough to help me test this out and iron out any kinks.

Components recommended for this theme:

This theme would not be possible without the hard work of Peter, marc2003, and TheQwertiest.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-29 16:34:28
Reserved
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2018-06-29 16:59:40
So you are that Mordred! I didn't connect until today, but the reason I got into foobar2000 is because about three years ago, while searching for inspiring music player layouts, I stumbled on this one (https://www.deviantart.com/mordredklb/art/WSHtpc-Mordred-0-8-0-427251767) which definitely looks like Georgia's forefather. Well, thanks for inspiring me  :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Vicas on 2018-06-29 17:09:18
Looks nice! I might give it a try. ;)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-29 17:09:46
So you are that Mordred! I didn't connect until today, but the reason I got into foobar2000 is because about three years ago, while searching for inspiring music player layouts, I stumbled on this one (https://www.deviantart.com/mordredklb/art/WSHtpc-Mordred-0-8-0-427251767) which definitely looks like Georgia's forefather. Well, thanks for inspiring me  :)
Haha, yep! If by some crazy chance you're still running that one, you should definitely upgrade. It hurts me to look at now (and I was running it up until December!) Glad you stumbled onto my stuff and the fb2k community!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-06-30 13:26:53
It doesn't load properly:

Code: [Select]
Error: JScript Panel v2.1.5.2 (Georgia by Mordred)
Error in JavaScript execution time:
'PanelProperties' is not defined
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\globals.js
Line: 2, Col: 1
<source text only available at compile time>

 :'(
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-06-30 21:23:53
It doesn't load properly:

 :'(
Thanks! Right before releasing I updated some file paths for TheQwertiest's playlist manager, but apparently didn't push the commit. There's a new release which should fix the problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-06-30 23:12:31
Got it working, thank you!

Hmm...

It crashes foobar if I add music through foo-input-spotify...
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-01 05:03:15
And this is why I need beta testers. Never used foo-input-spotify, but I'll check it out and see what's going on. Thanks for reporting!

Edit: The crash of foobar is either a bug in foobar itself or foo_input_spotify. What's causing it is attempting to retrieve %directoryname%. I was able to replicate it with 3 lines of Javascript. I reported a bug to Peter as I think it's foobar's problem, but can't tell for certain.

Skipping any calls that would process that field, I did run into a couple other issues which I've fixed but not pushed up yet. Doesn't look like I'm getting any album art though. Do you typically see art in other themes?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-07-01 12:17:33
Quote
... Doesn't look like I'm getting any album art though. Do you typically see art in other themes?

I was thinking that no art was possible through foo-input-spotify, at least not in the themes I tried (mainly foobox 4.2), buy yesterday I tried it with Br3tt js-smooth-playlist and it gets Spotiy art.



Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-01 15:45:34
Quote
... Doesn't look like I'm getting any album art though. Do you typically see art in other themes?

I was thinking that no art was possible through foo-input-spotify, at least not in the themes I tried (mainly foobox 4.2), buy yesterday I tried it with Br3tt js-smooth-playlist and it gets Spotiy art.
Yeah, I saw in the console it was attempting to retrieve art, but it didn't appear available to the theme. I'll need to look into that.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-02 00:52:38
I was thinking that no art was possible through foo-input-spotify, at least not in the themes I tried (mainly foobox 4.2), buy yesterday I tried it with Br3tt js-smooth-playlist and it gets Spotiy art.
I've got artwork working with spotify now, and fixed some crashes. Give it a try and let me know if you're still having issues there.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-07-02 12:30:28
 Wow! Working now with Spotify and showing the Spotify art!!! Also working the flags, band logos etc.

I'll tell you if something doesn't go.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2018-07-04 13:41:19
MordredKLB: good job on the theme! Probably gonna end up stealing some features getting some inspiration from it :D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-07-23 22:46:06
Version 0.9.9 released.

Change log:
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-12 08:58:14
MordredKLB, can you share a portable version, because I can not install it, yet I followed the information. thank you very much
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-08-13 05:53:05
MordredKLB, can you share a portable version, because I can not install it, yet I followed the information. thank you very much
Are you saying you have a portable version of foobar and it doesn't work, or you want me to give you .fcl files?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-13 08:04:43
MordredKLB, share portable version please, I want one. Thank
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: jazzthieve on 2018-08-13 23:12:10
He's probably asking for the complete foobar folder as portable.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-14 04:13:35
that's it, jazzthieve.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-08-14 16:49:03
I apologize, but that's not something I'm able to provide at the moment. I can try and walk you through the issues you're having installing the theme if you like. What exactly isn't working for you?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: IP974 on 2018-08-14 17:44:54
JScript Panel v2.1.6 (Georgia by Mordred): initialised in 10 ms
Error: JScript Panel v2.1.6 (Georgia by Mordred)
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\polyfills.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\helpers.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\hyperlinks.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\js_marc2003\js\lodash.min.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\js_marc2003\js\helpers.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Common.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Utility_LinkedList.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\globals.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_ContextMenu.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_HtaMsgBox.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_HtaGroupPresetsMngr.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_Scrollbar.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_List.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Panel_Playlist.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\CaTRoX_QWR\Control_Button.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\color.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\themes.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\Image_Caching.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\georgia-main.js
Failed to load: C:\Users\hld97\Desktop\Georgia-master\foobar2000\georgia\js\lyrics.js
JScript Panel v2.1.6 (Georgia by Mordred): initialised in 8 ms
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-08-14 19:01:58
@IP974 Looks like the issue is your paths are wrong. It's looking for the theme in "C:\Users\hld97\Desktop\Georgia-master\foobar2000\" but it doesn't seem the files are there.

Find where those files are and move them to the correct location.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-11-03 05:34:35
v1.0.0 was just released (https://github.com/kbuffington/Georgia/releases). Major addition this time around is the integration of WilB's LibraryTree. There are also a ton of bug fixes, speed improvements, fit-and-finish updates, etc. It's a much more solid theme this time around, with a lot more configurable options in the Options menu.

A selected changelist:

As always, let me know if you have any issues setting this up.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2018-11-04 19:49:01
Working fine here, thanks!!
Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: 3vilgenius on 2018-11-05 18:31:05
Hi, I'm on a QHD screen and for somereason the scaling of the library tree gets really wonky and scrunched together when full screen. and it looks pretty small when it is not full screen up to a certain size. Not only that but the scroll bar will not go away even when unchecked in the options for that. I'm attaching a pic so you can see the scaling issue I'm talking about:  https://imgur.com/u4JzksF

Btw thanks for all your work on this, its just a plain beautiful theme and I look forward to helping let ya know the kinks I find.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: 3vilgenius on 2018-11-05 19:12:34
Also, what are the metadata sections for things like the Record label and such that I can add to file properties so that they will show up in the theme? Should I add to the metadata a section called "Record Label" and then add the name for example?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2018-11-05 20:41:24
Hi, I'm on a QHD screen and for somereason the scaling of the library tree gets really wonky and scrunched together when full screen. and it looks pretty small when it is not full screen up to a certain size. Not only that but the scroll bar will not go away even when unchecked in the options for that. I'm attaching a pic so you can see the scaling issue I'm talking about:  https://imgur.com/u4JzksF

Btw thanks for all your work on this, its just a plain beautiful theme and I look forward to helping let ya know the kinks I find.
Crap, I thought I had that fixed, and unfortunately no longer have a 4k display to test on.

For now you can right click on the background, select Properties, and then scroll down to the bottom and change user.row.height from the default of 20 to 40. That ought to fix the problem.

Also, what are the metadata sections for things like the Record label and such that I can add to file properties so that they will show up in the theme? Should I add to the metadata a section called "Record Label" and then add the name for example?
All metadata tag definitions are set in globals.js (although some reference Properties). Record label is a special case which currently exists, and already looks for both label and publisher tags. These are set in the tf.labels array in globals.js. If you're using another one, let me know and I can add it to that array so that other people don't have to manually update it.

If you want to add a completely new field you can do that in the tf.grid object. Just add a label, and then a titleformatting value.

Let me know if you're still having issues.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: 3vilgenius on 2018-11-29 00:53:39
Hey thanks for the info! It took me a while to remember this site. I'll let you know if I got any more problems for sure :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-01-25 18:00:52
I published v1.0.1 of this theme a couple days ago which was primarily a bug fix release.

Changelist:
 - Fixed a bunch of errors related to 4k mode
 - Added ability to set 4k detection mode (auto, always, never)
 - Pre-init Library tree after delay for snappier initial load of the library tab (if you wait 10 seconds first)
 - Much improved handling of long artist names (optimal font detection)

I've got some more stuff in the works so hopefully I'll have a 1.1 release out in a week or two.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-08 16:49:46
Hi @MordredKLB , I'm taking a look at your scripts because I'm trying to figure out how you managed to clip the graphic elements (including text) in the playlist view. I've been going through the Panel_Playlist.js script, especially the Row() function, but I was not able to extrapolate the code I'm looking for. Would you mind explaining how it works?










Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-08 18:15:10
Re-reading my previous post, I realized if I were you I wouldn't understand what I'm talking about. So here's a picture to illustratre what I mean:

Spoiler (click to show/hide)

If the playlist viewer was actually a panel itself, the x and y coordinates of the clipped elements on top (circled in red in the picture) would be virtually outside of the panel and only the pixels inside the panel area would be painted, but since the whole layout is just one panel, how did you achieve this effect? The drawimage function takes cropping coordinates, but what about the text?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-05-13 23:03:44
@davideleo First off in that screen shot you're missing the installed fonts. You should install them and restart foobar and things will look better :)

As for the clipping, that's something @TheQwertiest did in his CatRoX update, and I might have slightly modified for my theme (can't remember right now). For speed purposes, each group Header block is initialized only once and drawn in full to a header_image. Then we clip that header_image to the playlist "viewport". This does mean the playlist uses a much bigger memory footprint than you'd expect, but that's mitigated a bit because we only draw the Header the first time if at least one pixel is visible on the screen. Until that happens the header_image is undefined for every non-drawn header. Switching playlists will cause the entire cache to be destroyed (freeing the memory) and rebuilt if needed.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-13 23:39:13
@davideleo First off in that screen shot you're missing the installed fonts. You should install them and restart foobar and things will look better :)
Ah ah ah, I knew you were going to say that! I actually thought of cropping the screenshot, but it was too late to edit the post  :P


As for the clipping, that's something @TheQwertiest did in his CatRoX update, and I might have slightly modified for my theme (can't remember right now).
Yes, the scripts I've looking at were taken from the Catrox theme, but comparing it with the original ones I noticed your mods and I thought they were an adaptation to the singe panel environment, since Catrox is a multiple panel theme. I guess I'll take a look at the Catrox scripts and eventually ask @TheQwertiest. Hopefully your explanation above will help me understand the code better.
BTW I posted a more general question on the issue in the spider monkey thread.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-13 23:41:09
@davideleo First off in that screen shot you're missing the installed fonts. You should install them and restart foobar and things will look better :)
Ah ah ah, I knew you were going to say that! I actually thought of cropping the screenshot, but it was too late to edit the post  :P


As for the clipping, that's something @TheQwertiest did in his CatRoX update, and I might have slightly modified for my theme (can't remember right now).
Yes, the scripts I've been looking at were taken from the Catrox theme, but comparing it with the original ones I noticed your mods and I thought they were an adaptation to the singe panel environment, since Catrox is a multiple panel theme. I guess I'll take a look at the Catrox scripts and eventually ask @TheQwertiest . Hopefully your explanation above will help me understand the code better.
BTW I posted a more general question (https://hydrogenaud.io/index.php/topic,116669.msg971353.html#msg971353) on the issue in the spider monkey thread.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-05-14 18:29:41
Yeah, I did have to make some adaptations to handle the single pane stuff. Primarily though it was just that I now pass an X & Y offset everywhere in draw, resize callbacks, and then make sure it's handled properly so that the theme doesn't assume that it'll draw or clip against (0,0) but rather (xOffset, yOffset). It was pretty simple to get working though. Functionally that's the only difference I can remember between mine and TheQwertiest's version, although there is some cosmetic stuff. (The hyperlink code is also new to mine and does require some additional functionality, but it's still mostly cosmetic)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: davideleo on 2019-05-14 21:05:26
...and then make sure it's handled properly so that the theme doesn't assume that it'll draw or clip against (0,0) but rather (xOffset, yOffset). It was pretty simple to get working though. Functionally that's the only difference I can remember between mine and TheQwertiest's version

That sounds exactly like what I was asking for! Would you mind explaining me in detail how you managed it or pointing me to the relevant code lines, as far as the playlist viewer is concerned?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 03:18:56
I'm playing around with the theme and it's growing on me a lot, but I have some questions:

1. The lyrics panel doesn't seem to do anything, it just doesn't load the lyrics to anything. Do I need a component (I can't see it documented anywhere) or is this a known bug?

2. Can I increase the font size in your playlist view? There seems to be a setting for it but if I increase the number it doesn't make any difference to the font in that panel.

Then, I also have a minor suggestion: It would be nice if the country field accepted codes and not just very specific versions of the names. United States is the form for the USA, but US and USA would also be good to have valid. Likewise, UK for United Kingdom. Ideally, it'd supported all of the standard two-letter and three-letter codes, I guess. It seems minor but it does save time if you're setting tags!

Finally, do you have a label suggestion thread or anything anywhere? I don't know how you decide which labels to add to the packages.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: jazzthieve on 2019-05-25 04:15:03
Then, I also have a minor suggestion: It would be nice if the country field accepted codes and not just very specific versions of the names. United States is the form for the USA, but US and USA would also be good to have valid. Likewise, UK for United Kingdom. Ideally, it'd supported all of the standard two-letter and three-letter codes, I guess. It seems minor but it does save time if you're setting tags!

It would probably only take a few seconds work to change all tags UK to United Kingdom and likewise for USA or US to United States. While it would be a bit more work for the developer to adapt only to your wishes.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 04:48:04
Then, I also have a minor suggestion: It would be nice if the country field accepted codes and not just very specific versions of the names. United States is the form for the USA, but US and USA would also be good to have valid. Likewise, UK for United Kingdom. Ideally, it'd supported all of the standard two-letter and three-letter codes, I guess. It seems minor but it does save time if you're setting tags!

It would probably only take a few seconds work to change all tags UK to United Kingdom and likewise for USA or US to United States. While it would be a bit more work for the developer to adapt only to your wishes.

Not sure why my comment needed your critique, it was reasonable feedback. All suggestions are adapting to someone or other's wishes and suggestions can be freely taken up or ignored. :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: jazzthieve on 2019-05-25 04:59:28
My critique was also very reasonable also given the fact it only takes a very small amount of effort, seriously about a couple of seconds work but somehow you're not willing. There's a word for that: laziness. That's why your suggestion needed some critical adjustments. Sure, suggestions can be taken up and ignored, and hope such a lazy suggestion gets ignored. Anything else?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 13:01:27
I really don't want to get into a flame war over something so trivial, I really like this theme and just wanted to offer a minor suggestion to the person (who I've spoken to before elsewhere, under other usernames though) who makes it.

I'll explain a bit more, though: Yes, I know I can just mass edit all of the tags, and I did that a long time ago in seconds. But the point is that as you're adding the information to new albums, it does take significantly longer to type "United States" than it does to type "US". Sure, it's a split second maybe, and you may find that pedantic, but a lot of foobar2000 usability things are about that split second, and the time adds up. After all, how many keyboard shortcuts can't just be accessed from a menu? Additionally, which I didn't mention because this was a minor minor suggestion that honestly didn't need five posts, but might be the better reason for suggesting this: It wasn't obvious how to get a U.S. flag to show - I tried US, USA and United States of America before United States. (Tip for others: It matches the spelling of the flag image files, minus the hyphens.) Supporting the variations would just make it a little bit more user friendly, but yes, it's a little thing and I wouldn't want nor expect a developer to slave over it if it wasn't easy for them. Their code may mean it's easy and they may be looking to build the theme into something with wide appeal, so it's still feedback I'd give. I'm sorry that you dislike that form of suggestion, but given this is a beta, it seemed fair.

To Mordred: Please don't mind us and do keep up your good work on this and AlbumArtDownloader things and so on :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 13:10:25
I have another question, also:

Is there a full list of tags that are supported for display in the information section (as in this: https://i.imgur.com/gigACuQ.png) on the theme? I've looked in the Properties list at the various settings but there's support for some with no reference there it seems. I'm struggling to figure out what the field name you use for Release Type is, for example. Also, is it easy (or possible to add as a feature) to customise what's shown, as in adding additional fields? For example, if I wanted to show a "Hometown" tag, is that something I can add to that area in the theme somewhere fairly intuitively?

(Edit: The Release Type field seems to be just %releasetype% but doesn't display if the type is Album, which I assume is your own choice of not having that data unless it's not an album. That'd be a nice thing to be able to toggle, if possible!)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-05-25 15:55:30
Just figured out my above post! For other users, there's a section in js/globals.js called tf.grid that has the list of metadata shown. You can reorder it there or add new fields, it's quite easy in any decent text editor. :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-06-11 17:05:08
Just figured out my above post! For other users, there's a section in js/globals.js called tf.grid that has the list of metadata shown. You can reorder it there or add new fields, it's quite easy in any decent text editor. :)
Yup! Sorry, I know the documentation is lacking in several areas. If I ever get time to work on this again.... :)

As for your flag question, there's a super simple solution (and one I might do as well). The flags I use come from gosquared's (https://github.com/gosquared/flags) repo of country flags. I have both 32x32 and 64x64 (for 4K) sizes, and just do simple pattern matching. If you're using the 4K setting, and your %artistcountry% value is United Kingdom, I just look for /images/flags/64/United Kingdom.png. If your %artistcountry% value is UK, then it won't find anything. Fortunately for you, gosquared includes their country flags by full name, and also by ISO code.

You can get the folder you need and just put them in the appropriate flags folder.
64x64 2-digit country flags: https://github.com/gosquared/flags/tree/master/flags/flags-iso/flat/64
32x32 2-digit country flags: https://github.com/gosquared/flags/tree/master/flags/flags-iso/flat/32

If you're not familiar with git, you probably don't want to download 200 different images manually. Go to the project root (https://github.com/gosquared/flags) and click the "Clone or Download" button in the top right, find the folder you need, and copy the contents to the flags/32 or 64 folder.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-08-10 01:11:19
I'm about to release a new version, but while everyone is waiting I've heard that it's hard to get older versions of foo_jscript that still works. Here's 2.1.4 which should work with the publicly available version of Georgia.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: artins90 on 2019-08-10 23:45:23
There are no interface elements to control volume or did I miss something during the configuration?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-08-11 00:47:23
There are no interface elements to control volume or did I miss something during the configuration?
You're currently correct. I'm going to be testing out an option which will enable volume control shortly, so stay tuned.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-08-11 03:09:17
I officially released v1.1.0 this afternoon. Adds a Dark Mode and a whole bunch of other fixes.
(https://i.imgur.com/Eu9Q1Mv.jpg)

You can get it here (https://github.com/kbuffington/Georgia).

v1.1.0 Changelog - 2019-08-10
 - Dark mode (new default)! Switch between the two in the options menu
 - A ton more 4k fixes
 - Re-initing playlist when 4k mode switches to avoid scrollbar issues
 - accurate date difference code based on human accepted norms of what a date difference is (i.e. 1 month ago)
 - correctly handling forbidden characters when attempting to find artwork/files
 - better sorting of results when clicking on hyperlinks
 - searching dates by year only
 - Fixed a bunch of issues with Multi-channel display
 - Highlight colors in library/playlist should still allow text to be legible
 - Drastically reduced console spam
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: CyPha on 2019-09-09 11:29:17
Hi, nice theme you have here, i'd love to try it out, but so far i'm just getting this error once i've entered the TXT lines into the JS Panel

JScript Panel v2.3.0-Beta.2 (Georgia by Mordred)
JavaScript runtime error:
Wrong number of arguments or invalid property assignment
File: C:\Users\CyPha\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\js_marc2003\js\helpers.js
Line: 295, Col: 9
and 'aw crashed' on the main.

Thanks in advance for any help :)

Edit; these are my versions, FoobarCore 1.4.6, Georgia 1.1.3
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-09-10 17:59:20
Hi, nice theme you have here, i'd love to try it out, but so far i'm just getting this error once i've entered the TXT lines into the JS Panel

JScript Panel v2.3.0-Beta.2 (Georgia by Mordred)
jscript 2.3.x has breaking changes. I'll be updating the script in the next day or two to support it, but for now, stick with v2.2.2.4 and you should be fine.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-09-30 01:02:45
Thanks for the updates! I'm still getting used to the new dark mode but I'm sure I'll prefer in the end.

(https://i.imgur.com/sfNlXj5.jpg)

I'm keen to see what you might add from here. I do use a totally different tab for my library and browsing through albums, I do feel that the built-in feature isn't great, mainly because it seems to lag so much when opening it (I think it's to do with loading the art?), it would be amazing to have a way to browse albums that's as pretty as the rest of the theme!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-10-18 09:00:50
I've had a semi-persistent problem of Georgia crashing on startup with the "Aw, Crashed :(" on startup.

Just tried upgrading(Georgia -> 1.1.4, JScriptPanel -> 2.2.2.4), but it's still happening.

Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Spoiler (click to show/hide)

I did notice from my font viewer that the names seem to be ever so slightly different than the strings in my console:
Code: [Select]
Full Name: HelveticaNeueLTStd-Th
Full Name: HelveticaNeueLTStd-Lt
Full Name: HelveticaNeueLTStd-Md
Full Name: HelveticaNeueLTStd-Bd

I tried changing them all to have spaces (Ex. 'Helvetica Neue LT Std'), but that didn't seem to help.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-21 01:22:29
It crashes for me on startup or a little after startup too, but after I "Reload" the panel it doesn't do it again, so it's never bothered me much.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-21 22:38:43
It crashes for me on startup or a little after startup too, but after I "Reload" the panel it doesn't do it again, so it's never bothered me much.
If you send me the error line from the console, I can fix that for ya :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-21 22:50:07
I've had a semi-persistent problem of Georgia crashing on startup with the "Aw, Crashed :(" on startup.
Again, send me the error from the console and I can fix it.

Quote
Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Spoiler (click to show/hide)

I did notice from my font viewer that the names seem to be ever so slightly different than the strings in my console:
Code: [Select]
Full Name: HelveticaNeueLTStd-Th
Full Name: HelveticaNeueLTStd-Lt
Full Name: HelveticaNeueLTStd-Md
Full Name: HelveticaNeueLTStd-Bd

I tried changing them all to have spaces (Ex. 'Helvetica Neue LT Std'), but that didn't seem to help.
The font names of the files is not what Windows reports as the names. To see those, you need to open up "Font Settings" (on Windows 10 at least) and then find the font in the list there. Things might look okay, but if the test is failing then you aren't seeing the correct fonts and are probably falling back to Arial or something.

There will be a new release in a couple days to handle JScript 2.3.x and fix a couple other minor issues. As part of that release I will be including brand new fonts which will hopefully make things a little simpler.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-22 04:20:02
It crashes for me on startup or a little after startup too, but after I "Reload" the panel it doesn't do it again, so it's never bothered me much.
If you send me the error line from the console, I can fix that for ya :)

This is the error that appears:

Error: JScript Panel v2.1.8 (Georgia by Mordred)
JavaScript runtime error:
Unable to get property '0' of undefined or null reference
File: C:\foobar2000x\georgia\js\georgia-main.js
Line: 2991, Col: 2
<source text only available at compile time>
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-22 19:56:53
Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Are you using foo_ui_hacks? Marc2k3 pointed out to me there's an issue where if you're using the UI Hacks method to load fonts locally that Utils.CheckFont returns false even though the font is available to foobar. If that's the case you can safely ignore that warning.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-22 22:56:39
Also, I poked around in my console and noticed the following even though I re-installed all of my fonts and everything looks OK.
Are you using foo_ui_hacks? Marc2k3 pointed out to me there's an issue where if you're using the UI Hacks method to load fonts locally that Utils.CheckFont returns false even though the font is available to foobar. If that's the case you can safely ignore that warning.

Yeah, I think that's installed as part of my setup.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-23 04:08:18
Yeah, I think that's installed as part of my setup.
I was actually asking @f9fb4d656d but that's a good datapoint. What version of Windows are you on? If it's XP or Vista I've got an idea of what's going wrong.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: katieinthecoconut on 2019-10-23 20:42:07
Yeah, I think that's installed as part of my setup.
I was actually asking @f9fb4d656d but that's a good datapoint. What version of Windows are you on? If it's XP or Vista I've got an idea of what's going wrong.

Oh, it's Windows 10...
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Fukuro on 2019-10-26 14:53:33
I'm bad at this...
How do I extract the component?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-27 15:08:00
Wow! Working now with Spotify and showing the Spotify art!!! Also working the flags, band logos etc.

I'll tell you if something doesn't go.



Updated to last version. Everything working fine except importing foo-spotify art

Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-29 17:17:55
Updated to last version. Everything working fine except importing foo-spotify art
What do you mean by "importing" exactly? Just that art isn't showing up from foo_input_spotify?

Also were you coming from Georgia 1.1.4 or an earlier version?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-30 09:54:46
Updated to last version. Everything working fine except importing foo-spotify art
What do you mean by "importing" exactly? Just that art isn't showing up from foo_input_spotify?

Also were you coming from Georgia 1.1.4 or an earlier version?

Actually I was using a previous versione. When updated to 1.1.5, it loads but then js panel crash. My foobar right now is a little bloated, will try with a fresh install with only the needed components.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-30 17:04:29
Actually I was using a previous versione. When updated to 1.1.5, it loads but then js panel crash. My foobar right now is a little bloated, will try with a fresh install with only the needed components.
Darn. Probably no easy way to determine what that version was then, unless you still have the old .zip file and can check out the top of globals.js.

When you say the js panel crashes, do you mean all the time (some are reporting a single crash at startup that I can't reproduce) or just when loading images from foo_input_spotify?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-30 22:46:36
Oki, I did a fresh install.
1.1.5 loads then crash, lods crash load crash, message is:
JScript Panel v2.3.1 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
El objeto no acepta la propiedad o el método 'GetLibraryRelativePath'
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Library.js
Line: 1205, Col: 224

It could be that Foobar is still scanning the library hard disk?
Windows 10, Foobar 1.5.beta 20

Ps. Tried with a previous version of Jscript Panel v.2.2.2 and the crash is no more.
Now it crashes when loading music from foo-input-spotify, and no spotify images are seen.
Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: WilB on 2019-10-30 23:23:09
GetLibraryRelativePath, which is causing the error, is incompatible with JScript panel v2.3.1. The new replacement method is significantly faster :) , but until its changed you can't use view by folder structure in the library panel. Since it's originally my panel I did offer to send @MordredKLB a version with the needed fixes a while ago. But it seems he wanted to wait until I released an updated version with the solution, or there was some confusion over the matter???

To stop Georgia 1.1.5/JScript panel v2.3.1 locking you out now, you can open (panel) properties, find SYSTEM.View By (its likely to be near the bottom of properties) and change it to 1. You will then be able to choose any of the available library views except View by Folder Structure because that will error.

HTH
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-10-31 05:44:56
GetLibraryRelativePath, which is causing the error, is incompatible with JScript panel v2.3.1. The new replacement method is significantly faster :) , but until its changed you can't use view by folder structure in the library panel. Since it's originally my panel I did offer to send @MordredKLB a version with the needed fixes a while ago. But it seems he wanted to wait until I released an updated version with the solution, or there was some confusion over the matter???
I had to make significant changes to your panel to get it to work in the theme (this is the issue with not using separate WSH panels for each piece of the theme). If you can send me the relevant changes I'll get them fixed ASAP, but unfortunately I can't just replace the file and have things work.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-10-31 10:24:54
The crash message with foo-input-spotify is:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setColors' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 1835, Col: 4
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-03 07:09:37
The crash message with foo-input-spotify is:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setColors' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 1835, Col: 4

Thanks for the debug help. Can you download this file https://raw.githubusercontent.com/kbuffington/Georgia/master/js/georgia-main.js and replace your existing georgia-main.js with it? Restart foobar and let me know if that fixes your problem with spotify. It might actually expose another issue so if you get a crash again, please post the file and linenumber like you did this time.

Unfortunately I don't have a Spotify premium account so I can't test this myself.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Rozzo on 2019-11-03 19:00:04
Replaced Georgia.main.js.
Crashed when loading spotify album:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setPlayTimes' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2610, Col: 2

Ys
Rozzo
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-11-03 22:04:51
Yeah, I think that's installed as part of my setup.
I was actually asking @f9fb4d656d but that's a good datapoint. What version of Windows are you on?

I do not have foo_ui_hacks. I'm on Windows 10.
Spoiler (click to show/hide)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-11-03 22:14:36
Installed 1.1.5, new jscript panel, and all the new fonts. Still crashes on startup, but seems to work after a reload.

New dump of my console:
Spoiler (click to show/hide)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-04 01:22:26
Replaced Georgia.main.js.
Crashed when loading spotify album:

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setPlayTimes' de referencia nula o sin definir
File: C:\Users\puran\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2610, Col: 2

Ys
Rozzo

I thought it might crash there. For some reason it seem on_playback_new_track() is not being called from foo_input_spotify. I'm gonna see if I can't borrow someones premium account for a day and try and figure this out.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-04 01:48:20
Installed 1.1.5, new jscript panel, and all the new fonts. Still crashes on startup, but seems to work after a reload.

New dump of my console:
This is super helpful. I think it's some kind of weird race condition that I can't duplicate. Let's see if I can't fix it on your machine though.

Can you open up georgia-main.js and find function createButtonObjects

At the very top of the function, right after the line that is btns = [] there's a 4 line if-else block. Can you delete that block and replace it with:

   if (ww <= 0 || wh <= 0) {
      return;
   } else if (typeof btnImg === 'undefined') {
      createButtonImages();
   }


Then close foobar and reopen and let me know if that fixes the problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-06 01:36:30
@katieinthecoconut You could also try replacing that code block to see if it fixes your problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: OryxCallotis on 2019-11-09 21:28:06
It seems like it crashes for me when I try to view my library by folder structure;

https://imgur.com/a/A6Q59ym

It looks like it's something to do with LibraryTree (https://hydrogenaud.io/index.php?topic=110938.0) that I think this skin uses;

http://i.imgur.com/YBmIWEM.png

The big issue is... I have no idea how to even make it stop trying to look via folder structure anymore. It's just an endless loop of crashing because I can't change it back.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-11 17:43:24
The big issue is... I have no idea how to even make it stop trying to look via folder structure anymore. It's just an endless loop of crashing because I can't change it back.
Yup, I have a fix, and will push an updated version of the theme tonight or tomorrow. I was hoping for some feedback from some of the other people complaining about different crashes first, but will just go ahead and hope someone else can test it later.

Until that happens you can stop the crash happening by going into Panel Properties, and changing the value of "SYSTEM.View By" to 0 (or any other number lower than what it's currently set to).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2019-11-14 05:51:33
v1.1.6 released. Let me know if you guys are still experiencing crashes.

I wasn't able to get a Spotify premium login. If someone is willing to share a password with me for a couple hours some day I wouldn't say no, but otherwise I'm not exactly sure how I can debug a baffling crash I can't reproduce.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-11-21 00:41:14
Installed 1.1.5, new jscript panel, and all the new fonts. Still crashes on startup, but seems to work after a reload.

Installed 1.1.6 and the new enhanced play count. Startup crash now gone!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ywoulditalk2u on 2019-12-20 00:20:06
Guys, can someone make a screen with your playlist switcher on and library list (artists with albums). Theme looks fkn astonishing. Super nice
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2019-12-21 04:44:49
Don't think I can attach screenshots here, but I took the standard provided layout and replaced the 2 Filter Hidden Tray with Coverflow (https://www.foobar2000.org/components/view/foo_chronflow) followed by 3x Filters. Works great for me.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Enigma776 on 2020-01-01 15:24:46
Getting a Jscript crash when trying to play a track

Code: [Select]
JScript Panel v2.3.5 (Georgia by Mordred)
JavaScript runtime error:
'Timeline' is undefined
File: C:\Program Files (x86)\foobar2000\georgia\js\georgia-main.js
Line: 1585, Col: 2

This is only happening with the latest version. plugins are up to date and I am unsure on what is happening.

--EDIT--

I am a fool and forgot to copy over the text from the georgia.txt. Sorry.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-02-24 00:18:36
Have you by any chance tested with the recently released Columns UI 1.4.0?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-02-24 16:53:43
Have you by any chance tested with the recently released Columns UI 1.4.0?
No, is there an issue?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-03-15 22:40:59
Have you by any chance tested with the recently released Columns UI 1.4.0?
No, is there an issue?

No, just curious if you had already tried, since I noticed the upgraded component. :)
I'm sticking with my working config for now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-12 05:17:16
Released version 1.1.7. Visual improvements and fixed a bunch of crashes. Unfortunately for some of you, clicking the upgrade button on the screen will cause a crash. You'll have to manually go to https://github.com/kbuffington/Georgia/releases/tag/1.1.7 to get the latest version. Make sure to read the note at the top.

Full changelist:
 - Invert logos when theme primary color is light (requires foo_jscript_panel v2.3.6)
 - Fixed crash when clicking the hyperlink to upgrade. Sorry!
 - Fixed crash when managing grouping presets
 - Added volume control
 - Album labels in playlist are now hyperlinks
 - Fixed some date timezone issues
 - Improved playlist look when songs don't have a genre tagged

Image packs were also updated today. You can get the incremental updates here (https://github.com/kbuffington/georgia-image-packs/releases/tag/2020-04).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-04-12 23:43:18
Hi.  I just recently discovered Georgia and like it so much that I replaced all of my various panels and tabs with just one full size panel for Georgia.  I really like the new volume control but do miss the ability to scroll with the mouse wheel.  I looked at your code and did see references to the wheel, but don't know enough java to really understand it.  Is there some setting I am missing or some change that could be made to activate it?  It's not a big deal, I was just curious.  Thank you very much for all your time and effort in providing us with this great theme.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-14 08:22:14
Hi.  I just recently discovered Georgia and like it so much that I replaced all of my various panels and tabs with just one full size panel for Georgia.  I really like the new volume control but do miss the ability to scroll with the mouse wheel.  I looked at your code and did see references to the wheel, but don't know enough java to really understand it.  Is there some setting I am missing or some change that could be made to activate it?  It's not a big deal, I was just curious.  Thank you very much for all your time and effort in providing us with this great theme.
Oversight on my part. Mouse wheel should work on the next released version coming in a week or two. It'll notify you at foobar startup when there's a new version.

BTW, you can re-enable this yourself by adding:

Code: [Select]
	if (pref.show_volume_button) {
volume_btn.on_mouse_wheel(delta);
}
to the top of on_mouse_wheel in georgia-main.js (line 2002ish).

Let me know if you have any issues.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-04-14 15:11:20
Thank you for your quick reply.  There was one small issue.  The volume scrolled when I used the mouse wheel anywhere on the screen, including the library or playlist view.  I solved this by moving the new code to the existing if/else statement.  The only (very minor) problem with this is that I can't use the wheel to adjust the volume when in one of these views.  One possibility might be to activate the wheel only when the volume button has been pressed, but only if this is fairly easy to do. 

if (displayPlaylist) {
      trace_call && console.log(qwr_utils.function_name());
      playlist.on_mouse_wheel(delta);
   } else if (displayLibrary) {
      // trace_call && console.log(qwr_utils.function_name());
      library.on_mouse_wheel(delta);}
      else if (pref.show_volume_button) {
      volume_btn.on_mouse_wheel(delta);
   }
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-14 17:40:14
Yeah I was just coming here to point this out. Fix is slightly more complicated than I thought. I don't have a mouse with wheel on my dev computer so I was just looking at the code and it appeared to be handled inside the volume_btn's on_mouse_wheel. I'll have to figure it out and get back to you.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: digitalfrog on 2020-04-15 21:32:18
Loving it !
Installed it today.

Couple of things.

1/ Clicking on Playlists-? Playlist manager crashes with:

JScript Panel v2.3.6 (Georgia by Mordred)
JavaScript runtime error:
Invalid procedure call or argument
File: C:\Users\digit\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Control_Button.js
Line: 330, Col: 4

Not a big deal since there are other ways to get there.

2/ Question: How do I make the song rating stars to be saved in the file tags ?



Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-16 05:49:12
1) That error seems to be on creating a new playlist. Was that what you were trying to do? It works fine for me. Did you install the latest foo_jscript_panel? Nevermind, I see 2.3.6. Did you have any playlists when you tried to add a new one?

2) That's a setting of foo_playcount, and not this theme. There's a good thread on this forum about that component which should be able to walk you through it.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: digitalfrog on 2020-04-16 14:40:50
1/ yep, already had playlist. Still crashes when I want to add one. It might just be me, so unless many other 'complain' it might not be worth spending time on it.

2/ that's it ! Found the way, thank you !
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-19 08:36:03
1/ yep, already had playlist. Still crashes when I want to add one. It might just be me, so unless many other 'complain' it might not be worth spending time on it.
I figured it out. That line needs to be:
Code: [Select]
plman.ActivePlaylist = plman.PlaylistCount - 1;

It'll be fixed in the next release.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-04-21 18:27:58
Hi.
I downloaded your latest changes this morning and everything looks good, but I do have some comments.  All of these are very minor and may not be issues at all, depending on your intent.  I just wanted to bring them to your intention before you released 1.18.  And thank you for all your hard work giving us this wonderful theme.

1.  I can now the scroll the volume bar with the wheel even when the playlist or library panel is displayed (thank you), but it also continues to scroll the displayed panel.

2.  When scrolling the volume bar with the wheel, the volume tooltip is correctly displayed and shows the changing value as I scroll,  But only the first time.  When I adjust the volume a second time, the tooltip shows initially, but does not continue to show the changing value as I scroll.  Reloading the panel corrects the issue, but again, only for the first time.  I added statements to set this,show_tt to true prior to checking it in each of the three places where it is checked in volume.js and this seems to solve the issue.

3.  The new randomize function works well, but does have what may be an unintended consequence.  I started playing on track 1, then pressed the randomize button.  This moved track 1 down to the next to the last track.  After it and the next tracked finished playing, playing stopped until I pressed the play button again.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-22 00:53:13
1 and 2 have already been fixed in the next version. Huge oversight for me not to test with a mouse wheel, and tooltips all over the place were broken.

3 is a very good point that I hadn't even considered. I need to figure out a way to move the currently playing or selected track to the top of the playlist. I'll look into it.

I'm messing with some display bugs at the moment, but depending on how much free time I get I'm hoping to do another release this weekend.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: PrinceSnake on 2020-04-23 17:33:07
Hello, thank for your work, I have followed every step closely you told but it does not open properly, FOOBAR just crash.

What the console says :

JScript Panel v2.3.6 (Georgia by Mordred)
Erreur d’exécution JavaScript:
Impossible d’obtenir la propriété  « 0 » d’une référence null ou non définie
File: C:\Users\Username\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2996, Col: 2
--

Where are located the js files :
C:\Users\Username\AppData\Roaming\foobar2000\georgia\js
Where Foobar is currently installed :
C:\Program Files (x86)\foobar2000

What did I have done wrong to get that result?

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-04-24 11:26:28
Love the work so far on this. Just wanted to let you know, I found the playlist font to be uneditable for some reason; either through the menu, or anything else I had tried. Weirdly, the when switching to 4K version that switched the playlist font size; however, everything else was then too big. I started tinkering around, and here's my custom fork: https://github.com/ravenmyst/Georgia

I increased the playlist font size, increased the icon size (got rid of the lyrics one for example, since I dont use it). I am starting to fall behind master though. My resolution is 1920x1080 / 2560x1440. Hope this can help; not sure how to PR this since it's guesswork on my end.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2020-04-25 06:08:28
Thanks ravenmyst, playlist font is much better now! Only thing on my side - the menu list on the left upper side got lost.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-26 03:12:55
Hello, thank for your work, I have followed every step closely you told but it does not open properly, FOOBAR just crash.

What the console says :

JScript Panel v2.3.6 (Georgia by Mordred)
Erreur d’exécution JavaScript:
Impossible d’obtenir la propriété  « 0 » d’une référence null ou non définie
File: C:\Users\Username\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 2996, Col: 2
--

Where are located the js files :
C:\Users\Username\AppData\Roaming\foobar2000\georgia\js
Where Foobar is currently installed :
C:\Program Files (x86)\foobar2000

What did I have done wrong to get that result?


If you check the console you'll probably see a message that starts with:
"ATTENTION: Buttons could not be created, most likely because the images were not found in...."?

It'll tell you location it's looking for button images in.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-26 03:29:02
Love the work so far on this. Just wanted to let you know, I found the playlist font to be uneditable for some reason; either through the menu, or anything else I had tried. Weirdly, the when switching to 4K version that switched the playlist font size; however, everything else was then too big. I started tinkering around, and here's my custom fork: https://github.com/ravenmyst/Georgia

I increased the playlist font size, increased the icon size (got rid of the lyrics one for example, since I dont use it). I am starting to fall behind master though. My resolution is 1920x1080 / 2560x1440. Hope this can help; not sure how to PR this since it's guesswork on my end.
Yeah, at the moment the playlists fonts aren't configurable. I'm wondering if I should try and base them off DPI, and just ditch the `is_4k` stuff for fonts. That's a lot of work and for now I'll probably add two configurable font sizes for playlists (one for Headers, and one for individual rows).

Did you find them too small in 1920x1080 resolution? 2560x1440 is probably way too small to read if you disable 4k mode (i.e. you're sitting directly in front of the screen) engaged.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-04-26 11:10:49
I could read it, but in my opinion, it was too small on both my 1920x1080 and 2560x1440 displays.


Thanks ravenmyst, playlist font is much better now! Only thing on my side - the menu list on the left upper side got lost.
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-04-26 15:44:53
Also, my playlist row height is 40 for anyone else wondering!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-26 17:57:55
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Just for the record, if you do this, you'll be hiding the Options menu and then there's no way to get access to some of the display options which you might want to play around with.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2020-04-27 05:24:09
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Hmm, even if I change line 189 in globals.js from 'false' to 'true', the menu is not shown...
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: D.Sync on 2020-04-27 08:35:04
It has been ages since I last updated my skin used for tagging in DUI. Then searching on the forum out of the blue and stumbled upon this! The setup is conveniently easy since everything is wrapped in a JScript panel. Loaded flawlessly on foobar 1.5.3.

Just one question though, I downloaded the latest release and noticed that the whole window will show the artwork + info properly, but then it will just mysterious dissapear after some time. Checked my console and found "<Error: Image could not be properly parsed: G:\Music (unsorted)\!! By Series [copied to mybook]\Professor Layton\Profesor Layton and the Curious Village\folder.tags>". The .tags is generated from External Tags plugin. Seems like it's trying to load folder.tags, failed, then display nothing instead. Is there an option to specify which image to use as album art, or rather a pattern matching? Or even better, an exception handler for this?

Ah found it, it's in the global.js. Changed to folder.jpg instead of .* Perhaps it's good to include this option in the Options?
// GLOB PICTURES
tf.glob_paths = [ // simply add, change or re-order entries as needed
   '$replace(%path%,%filename_ext%,)folder.jpg',
   '$replace(%path%,%filename_ext%,)*.jpg',
   '$replace(%path%,%filename_ext%,)*.png',
   '$replace(%path%,%directoryname%\\%filename_ext%,)folder.jpg' // all folder images in parent directory
];

Anothoer question, is it possible to change cd.png to disc.jpg, or a field to change the pattern? I have all my disc named as disc.jpg. Would be awesome if can make it spinning in real time like XBMC.

Found it,I changed to pref.cdart_path = "$replace(%path%,%filename_ext%,)disc.png". Is it possible to have a list of possible cd source just like the album art source to cycle to?

Most of my disc are in non transparent .jpg with white background instead of .png. Not sure if there's a way to apply chroma key on those .
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-27 08:44:26
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Hmm, even if I change line 189 in globals.js from 'false' to 'true', the menu is not shown...
Just checked and my theme doesn't actually use that setting, so ravenmyst must have actually removed the code in his version.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-27 09:01:53
Seems like it's trying to load folder.tags, failed, then display nothing instead. Is there an option to specify which image to use as album art, or rather a pattern matching? Or even better, an exception handler for this?
Thanks for finding this. Just added a filter to remove anything that isn't a .jpg or .png.

Quote
Anothoer question, is it possible to change cd.png to disc.jpg, or a field to change the pattern? I have all my disc named as disc.jpg. Would be awesome if can make it spinning in real time like XBMC :)
This problem is that a disc.jpg is not transparent, and there's no automatic way to make it transparent. It'll stay as cd.png for now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: D.Sync on 2020-04-27 21:27:34
Thanks for the reply Mordred!

As for the chroma key on JPEG, perhaps not important but something that can be look into:
I found a jslibrary that can apply chroma key to JPEG https://www.w3.org/2013/chroma/chroma-key.js. Unfornately it is written to parse <img> tag in HTML. I tried to embed into your script but not sure how to get the frame data, or in this case, the cdart data parsed by the gdi. Using console.log(cdart) return 0 so it's hard to see what attribute are there in that object.

It has beeen quite some time since I last programmed in jS.

  apply_key: function (canvas, ctx, key, d)
  {
    var frame = ctx.getImageData(0, 0, canvas.width, canvas.height);

    for (var j = 0; j < frame.data.length; j += 4)
    {
      var r = frame.data[j];
      var g = frame.data[j+1];
      var b = frame.data[j+2];

      if (key.r - d <= r && r < key.r + d &&
          key.g - d <= g && g < key.g + d &&
          key.b - d <= b && b < key.b + d)
      {
        frame.data[j + 3] = 0;
      }
    }

    ctx.putImageData(frame, 0, 0);
  },

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-28 01:11:27
Interesting code, but that's actually for drawing on an HTML canvas control which the jscript_panel doesn't support.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-04-28 21:31:44
I don't use the menu so I turned it off. It's located here:
https://github.com/ravenmyst/Georgia/blob/master/js/globals.js#L189
Hmm, even if I change line 189 in globals.js from 'false' to 'true', the menu is not shown...

https://github.com/ravenmyst/Georgia/blob/master/js/georgia-main.js#L2953

Sorry about that. Try unncommenting this block ( remove ln 2953 and 2983 )
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2020-04-30 04:52:02
Try unncommenting this block ( remove ln 2953 and 2983 )
Thanks ravenmyst, the menu is back.
Is it possible that CD Art is as well deactivated?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-04-30 08:18:08
3.  The new randomize function works well, but does have what may be an unintended consequence.  I started playing on track 1, then pressed the randomize button.  This moved track 1 down to the next to the last track.  After it and the next tracked finished playing, playing stopped until I pressed the play button again.
Just pushed a fix for this to the repo. If playing a song, the playlist it's in will be randomized and that song will move to the top of the playlist. If no song is being played, the entire playlist is randomized and the first song begins to play. In both cases the now playing song will scroll into view.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-04-30 22:03:50
Try unncommenting this block ( remove ln 2953 and 2983 )
Thanks ravenmyst, the menu is back.
Is it possible that CD Art is as well deactivated?

Not afaik. CD Art/including the disc/boxes work for me. I did change the regex slightly to be more expansive (discart.png can also  be cd image) because Kodi digests it that way. But it should read files all the same, though don't name them discart if it's not art of the disc.  e.g. my disc is discart.png, and album can be folder.jpg or something

I'm assuming of course that it was working in the other version.

..So I have a question. I am using default ui (not columns) and it works 99% of what I want, though I was wondering if there's a way to snugly fit other jscript panels like equalizer, volume, etc, or something, to give it the full app feel, that way nothing foobar is left.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-01 00:56:06
Hi.  I downloaded your latest version and the randomize function works great now.  I did notice there is still the issue where scrolling the volume bar also scrolls the library and playlist panels if displayed.  This is a very small issue and not worth spending much time on, but you indicated it had been fixed in a previous post so I just wanted to mention it.  Otherwise, everything is working great, and I greatly appreciate all the time and effort you continue to put into this wonderful theme.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-01 07:14:36
Hi.  I downloaded your latest version and the randomize function works great now.  I did notice there is still the issue where scrolling the volume bar also scrolls the library and playlist panels if displayed.  This is a very small issue and not worth spending much time on, but you indicated it had been fixed in a previous post so I just wanted to mention it.  Otherwise, everything is working great, and I greatly appreciate all the time and effort you continue to put into this wonderful theme.
Oops, didn't realize that was happening. marc2k3 submitted a PR that fixed the issue. It's been merged along with a ton of other new crap including:

Refactored options menu. I wrote brand new helper functions for this stuff to make creating new menus/options a breeze to manage, and so I'm able to cram anything I want in there without any of the painful issues I had before. So I've added tons of stuff under Options.

New Options:
 * Resizable playlist row and header fonts
 * transport controls below artwork (still tweaking this slightly)
 * exposed more transport settings
 * lots of new playlist settings moved out of the Playlist Appearances right click menu (although it's still there too)

This is a big release so I'm gonna need to do a beta very soon. Hopefully in the next 48 hours that'll be coming.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-01 11:52:13
I'm looking forward to checking out your latest changes.  Georgia is more than just another theme for me.  I was a mainframe COBOL programmer for almost 40 years, since the days of paper punch cards, and really miss coding.  Georgia is an opportunity for me to finally learn Java and I'm having a lot of fun with it.  You mentioned adding some new transport options.  I wanted to mention the ones I have added in case you thought others might be interested in them.  These include volume muting, console display, minimize, maximize/restore, full screen and exit.  I did see some existing code for some of these, but it seemed to be incomplete.  I'll download your new version as soon as it's available and run it through its paces before I retrofit my own changes to see if I can find any issues.  I don't expect to find many.  I'll let you know what I find.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-02 20:30:28
v1.1.8-beta1 now available here: https://github.com/kbuffington/Georgia/releases
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-02 20:34:11
I wanted to mention the ones I have added in case you thought others might be interested in them.  These include volume muting, console display, minimize, maximize/restore, full screen and exit.  I did see some existing code for some of these, but it seemed to be incomplete.
Some of those like, min/max/close are meant to only work when ui_hacks is enabled. For a long time that was considered a banned component and so I left in some of the code that was there for it but mostly commented it out. It's been probably 7 years since I had ui_hacks installed, so I should probably go back and get that stuff working again at some point (any uncommented code for ui_hacks is probably hopelessly broken right now) because I know people like it. I've just learned to live without it :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-03 00:17:23
I've finished checking out your latest version and only found a couple of minor issues.  When using the mouse to scroll the volume bar, the tooltips only appear the first time and I have to reload to get them back.  I think you fixed this earlier, but it's back.  And Properties won't let me change the user row height for the playlist panel.  Oddly, it was stock on 30 before my retrofits, and on 23 after.  Everything else worked great.  I can now scroll the volume bar without effecting the other panels.  Moving the transport buttons below the artwork works well and even picked up the new buttons I added.  Resizing the playlist header and row works great and I can now get rid of my hard coded sizes.  I was pleased that the web links work now.  Trying to use them before crashed Georgia. The eCover link doesn't seem to work, but I don't even know what that is.  I don't use CD art, so I couldn't test that.  I tested before retrofitting my code and was pleasantly surprised that I didn't break anything with my changes.

I didn't realize UI Hacks was banned, but it hasn't caused any issues and I really like some of its features.  Thank you again for all your time and effort.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2020-05-03 06:05:03
Thanks MordredKLB, these are great improvements! Can change the playlist font sizes without restrictions.
CD Art works as well as always.
Some more ideas:
Would be nice to be able to change the font size of the menu as well + the size of the transport control icons.
I somehow miss some of WilBs Library settings options such as Node Style (Squares/Angles/...) or Theme mode (Dark/Blend/Light/Cover).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-03 17:51:16
When using the mouse to scroll the volume bar, the tooltips only appear the first time and I have to reload to get them back.  I think you fixed this earlier, but it's back.  And Properties won't let me change the user row height for the playlist panel.  Oddly, it was stock on 30 before my retrofits, and on 23 after.
Tooltips are still a little flaky. I haven't messed with them since I thought I had them working again, so I can't 100% explain what's happening, but I've seen it.
The row_h in the properties is now calculated based on the playlist row font size. I should probably figure out how to pull it out of the properties as it's not needed anymore, but it's used in a bunch of places.
I also fully removed eCover from the list of weblinks.

Quote
I didn't realize UI Hacks was banned, but it hasn't caused any issues and I really like some of its features.  Thank you again for all your time and effort.
It's no longer banned. Policy has changed. Someday I'll revisit that functionality as it would be cool to get rid of the title bar.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-03 17:57:26
Would be nice to be able to change the font size of the menu as well + the size of the transport control icons.
I somehow miss some of WilBs Library settings options such as Node Style (Squares/Angles/...) or Theme mode (Dark/Blend/Light/Cover).
Changing menu font and transport control sizes are also on my list of things to do. Might even do it before 1.1.8 releases, but no promises.
I pulled a ton of stuff out of WillB's library stuff just for simplicity and because I wanted control over how everything looked. There were also about 100 properties that WillB used, and I had 100 properties and his didn't always have clear or consistent naming, and it become hard to find anything in that damn dialog, etc. That wouldn't be a problem with a good menu setup, but I still require users to go in there to edit Title Formatting strings if they want. I tried to see how much work it'd be to add the theme mode back in, and apparently I removed some required code instead of just commenting it out, and it seemed more trouble than it's worth for now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-03 21:31:47
Yeah, I saw that the eCover option didn't have any supporting code in Common.js.  I also couldn't find any reference to it with Google.  In case anyone might be interested, I added the following links.  The All Music links just perform a search and can return a lot of hits, but usually list the desired artist at the top.  I couldn't figure out how to go directly to the desired page because All Music appends a unique code to the link.
       
            case 'wikipediadisc':
                site = (artist ? 'http://en.wikipedia.org/wiki/' + artist.replace(/\+/g, '_') + '#Discography' : null);               
                break;
             case 'lastfm':
                site = (search_term ? 'http://www.last.fm/music/' + search_term.replace('/', '%252F') : null);
                break;
            case 'lastfmalbum':
                site = (search_term || album ? 'http://www.last.fm/music/' + search_term.replace('/', '%252F') + '/' + album : null);
                break;                       
            case 'allmusic':
                site = (artist ? 'https://www.allmusic.com/search/artist/' + artist.replace(/\+/g, '+') : null);
                break;
            case 'allmusicalbum':
                site = (search_term || album ? 'https://www.allmusic.com/search/album/' + search_term + '+' + album : null);
                break;  

There is probably a better solution, but I fixed the volume tooltip issue by just adding this.show_tt = true; to each of the three functions where it's checked.  Quick and dirty, but it seems to work.

When adding the caption buttons, you might want to consider also adding transport buttons for mute and console.  I find these very useful.


 
          
           
         
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-03 22:47:20
Hi, sorry to bother you again.  I was wondering why you changed how the playlist row height is calculated.  I personally like a larger album art and like the option to adjust it.  Fortunately I got it back by just commenting out one statement.  I'm not asking you to change it, but please don't remove this option from properties as it would just add to my already considerable retrofit woes.  For others who like to do their own customizing, I strongly recommend the freeware compare/merge program Diffuse.  Thank you again for this great theme.  To show my appreciation, I'll be making another PayPal donation when I get my next SS check and encourage others who appreciate your efforts as much as I do to do the same.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: D.Sync on 2020-05-04 02:15:20
Did some fiddling on the theme since I'm liking it :-) I owned mostly Anime/VGM and since I had previously did a massive Hyperspin project , I decided to pull out the logo from it and show it in this theme instead. I reckon this theme will look awesome if I could ever convert those franchise/logo for all my VGM collection and disc art.

Mod 1:
The logo changes whenever the %genre% has Game to show the franchise/series logo. The original implementation is show artist logo. Added some custom path too for those franchies logo.

Mod 2:
Show platform (if any) on the bottom right.

Mod 3:
Also implemented a simple SpinningCDArt using setInterval to mimic my XBMC setup, which can display the spinning art with fluid animation. Strangely setting it to too frequenty (e.g 16ms) in foobar causes spectrograph to stutter. Perhaps it's not well threaded. Can't really find any other way to optimize it. Right now I'm just going to settle at 1000ms, since I don't have much good transparent disc art to begin with.

Video demo:
https://youtu.be/QB4GqJHCTY4

Note: Most of my disc art is in .jpeg with nontranparent background. The disc art demonstrated is from my custom PS skill to crop the original disc to fit it. It's going to take a lot of time to manually did all this labor. I tried various AI Background removal tool and color key but the end result is not as good, most causes uneven trim at the CD edge. So the best way is still to manually crop them and fit them in a CD art template. Couldn't find any good website for these VGM disc art with transparent BG like fanart TV. Shout me out if you want to embark on these ambitious VGM Disc Art project, or know of any!

Not sure how often will Mordred change the revision. I'm still using the version I cloned last week.

Possible next mod I'm going to do:
- Show Disc Icon instead of CD text at the top right.
- Show and fit more tags since most of my VGM include the original album and title (to include both EN and JP language)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-04 03:26:09
v1.1.8-beta2 (https://github.com/kbuffington/Georgia/releases) available now.

Changes since beta1:
- Really fixed tooltips now
- New functions under the Help menu with a setup verification check.
- Hovering over timeline gives you tooltips about plays (and non-plays!)
- Fixed another random crash
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-04 03:33:32
Hi, sorry to bother you again.  I was wondering why you changed how the playlist row height is calculated.  I personally like a larger album art and like the option to adjust it.  Fortunately I got it back by just commenting out one statement.  I'm not asking you to change it, but please don't remove this option from properties as it would just add to my already considerable retrofit woes.  For others who like to do their own customizing, I strongly recommend the freeware compare/merge program Diffuse.  Thank you again for this great theme.  To show my appreciation, I'll be making another PayPal donation when I get my next SS check and encourage others who appreciate your efforts as much as I do to do the same.
I have to recalc the row_h whenever the row font size changes, otherwise things look terrible, and I didn't want to also add menu options for that as well, so I just do 1.667*row font size which was the same as the default 12 to 20. I wanted to remove the property, but it's used in a bunch of other files, and leaving it as a property seemed safest.

Depending on how large the Header font is, the playlist album art might take up 3 or 4 rows, so you can get larger art by playing around with the header size. That might be a simpler solution and remove one less diff.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-04 03:45:18
Mod 1:
The logo changes whenever the %genre% has Game to show the franchise/series logo. The original implementation is show artist logo. Added some custom path too for those franchies logo.

Mod 2:
Show platform (if any) on the bottom right.

Mod 3:
Also implemented a simple SpinningCDArt using setInterval to mimic my XBMC setup, which can display the spinning art with fluid animation. Strangely setting it to too frequenty (e.g 16ms) in foobar causes spectrograph to stutter. Perhaps it's not well threaded. Can't really find any other way to optimize it. Right now I'm just going to settle at 1000ms, since I don't have much good transparent disc art to begin with.
I like your ideas for Mod 1/2. I probably won't implement them by default as then I need to keep up with more artwork and I rarely listen to VGM, but it's still a cool idea.

Spinning art. That's pretty cool. I'm honestly surprised at how smooth it is. Unfortunately I can't see your menus so it's hard to tell what's going on, or whatever, but it's still awesome.

To get smooth artwork spinning you'd need to do the following (which you might already be doing some or all of):
Take your cdArt, and draw it rotated into a bitmap. Save that rotated bitmap image to a cache with X number of rotated images (18 or 36 seems best). Cycle through the cached rotated images when drawing.

If you're using my CreateRotatedCDImage() method, it's be pretty easy to modify it to create an array of multiple images. It'll be slow on first call though as drawing rotated 1000x1000 pngs takes time.

I'll probably have a crack at this since you proved how easy it was to do and I just talked myself through all the steps required. :D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: D.Sync on 2020-05-04 05:14:05
Mod 1:
The logo changes whenever the %genre% has Game to show the franchise/series logo. The original implementation is show artist logo. Added some custom path too for those franchies logo.

Mod 2:
Show platform (if any) on the bottom right.

Mod 3:
Also implemented a simple SpinningCDArt using setInterval to mimic my XBMC setup, which can display the spinning art with fluid animation. Strangely setting it to too frequenty (e.g 16ms) in foobar causes spectrograph to stutter. Perhaps it's not well threaded. Can't really find any other way to optimize it. Right now I'm just going to settle at 1000ms, since I don't have much good transparent disc art to begin with.
I like your ideas for Mod 1/2. I probably won't implement them by default as then I need to keep up with more artwork and I rarely listen to VGM, but it's still a cool idea.

Spinning art. That's pretty cool. I'm honestly surprised at how smooth it is. Unfortunately I can't see your menus so it's hard to tell what's going on, or whatever, but it's still awesome.

To get smooth artwork spinning you'd need to do the following (which you might already be doing some or all of):
Take your cdArt, and draw it rotated into a bitmap. Save that rotated bitmap image to a cache with X number of rotated images (18 or 36 seems best). Cycle through the cached rotated images when drawing.

If you're using my CreateRotatedCDImage() method, it's be pretty easy to modify it to create an array of multiple images. It'll be slow on first call though as drawing rotated 1000x1000 pngs takes time.

I'll probably have a crack at this since you proved how easy it was to do and I just talked myself through all the steps required. :D

Yea really appreciate the amazing work that you did on this theme, and I'm just refreshing my JS programming skill.

Strangely OBS didn't record the Option menus when I am choosing different options. The cursor you saw is merely me trying to select different options.

How silly am I didn't thought about the cache. I simply refer to your RotateCDImage function and modified it as follows. Not sure whether the delay is the constant redraw or the setInterval function itself. But having a cache that stores up to [360/rotation_degree] copies makes sense instead of redrawing and rotate on every call, especially at 16ms. The only question I have is how to store the bitmap of the rotated DrawImage. I think that is a void function?

Code: [Select]
function spinningCDImage() {
rotatedCD2 = disposeImg(rotatedCD2);
if (pref.display_cdart) { // drawing cdArt rotated is slow, so first draw it rotated into the rotatedCD image, and then draw rotatedCD image unrotated in on_paint
        if (cdart && cdart_size.w > 0) { // cdart must be square so just use cdart_size.w (width)
               
            if (!rotatedCD2) {
rotatedCD2 = gdi.CreateImage(cdart_size.w, cdart_size.w);
rotCDimg = rotatedCD2.GetGraphics();
            }

            rot_amt = (rot_amt + pref.spin_rotation_amt) % 360;
            // console.log("rotamt=" + rot_amt);

rotCDimg.DrawImage(cdart, 0, 0, cdart_size.w, cdart_size.h, 0, 0, cdart.Width, cdart.Height, rot_amt , 255);
// rotatedCD2.ReleaseGraphics(rotCDimg);
           
}
}
    RepaintWindow();
}
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: D.Sync on 2020-05-04 06:25:57
A cache function that I did using the path+rotation_amt as the key. Seems to work fine now, not sure whether it is the optimal way without memory leak haha.

Just found that this and the code in line 486 has to be together to draw the disc art. Not sure why we need to have 2 DrawImage function call?

Code snippet on line 486, found on function draw_ui(gr)
Code: [Select]
			if (!pref.cdart_ontop || displayLyrics) {
if (rotatedCD && !displayPlaylist && !displayLibrary && pref.display_cdart) {
if (showExtraDrawTiming) drawCD = fb.CreateProfiler('cdart');
gr.DrawImage(rotatedCD, cdart_size.x, cdart_size.y, cdart_size.w, cdart_size.h, 0, 0, rotatedCD.width, rotatedCD.height, 0);

Code: [Select]
// Spin CD Image with Cache
function spinningCDImage() {
    var temp_cdart;
    rot_amt = (rot_amt + pref.spin_rotation_amt) % 360; // use this as key
    key = cdartPath + '' + rot_amt;
if (pref.display_cdart) { // drawing cdArt rotated is slow, so first draw it rotated into the rotatedCD image, and then draw rotatedCD image unrotated in on_paint
        if (cdart && cdart_size.w > 0) { // cdart must be square so just use cdart_size.w (width)
               
            // check if rotated disc art exist in cache
            if (spinning_cdart_cache.getImage(key)) { // if this art at this rotation was cached
                rotatedCD2 = spinning_cdart_cache.getImage(key);
                console.log('cache hit!');
            }
           
            else {
                rotatedCD2 = gdi.CreateImage(cdart_size.w, cdart_size.w);
                rotCDimg = rotatedCD2.GetGraphics();
                rotCDimg.DrawImage(cdart, 0, 0, cdart_size.w, cdart_size.h, 0, 0, cdart.Width, cdart.Height, rot_amt , 255);
                // store the rotated bitmap as cache
                spinning_cdart_cache.encache(rotatedCD2, key);
                console.log("encache...");
                rotatedCD2 = spinning_cdart_cache.getImage(key);
                rotatedCD2.ReleaseGraphics(rotCDimg);
               
            }   
}

    RepaintWindow();
}

Another demo video with cache and showing the options. Notice how the timer stopped when I set the update interval in setInterval to 16ms. Not sure how to circumvene this.
https://youtu.be/jchpoe_I53s
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-04 06:58:56
Yeah, you're doing things the right way now. You just need to make sure that spinning_cdart_cache has a size >= 360/rotation degrees. Otherwise you'll continually overwrite cache entries.

The image is drawn twice because the first time you're drawing the rotated CD into a square bitmap which you then store in the cache. The 2nd time you just draw the square cached image.

It might not be obvious but this is potentially 20x faster than just drawing a rotated image. When I first did the cdArt and added a rotation, I found that it would take about 20ms to draw the rotated image at first, but it would get progressively slower until it was around 300ms. This is because as you rotate a square image (for example 45degrees) it's now occupying a diamond shape portion of screen real estate. Windows has no idea that everything outside the boundary circle of the cd is transparent and so it needs to calculate the update region of every line (i.e. when rotated 45degrees, first line is 1 pixel wide, then 3, then 5, then 7, etc..... full width of the rotated image .... then 5, then 3, then 1). This is incredibly computationally intensive. So we create a square bitmap, draw the rotated image into that (takes 16ms or so), then draw that square bitmap to the screen which takes 2-3ms.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-05 04:25:22
I just tried out your new menu resizing option.  It works great, one less line to retrofit.  I also eliminated my dependence on the properties user row height to get larger album art, although I did have to increase your multiplier from 1.667 to 2.15 to get the results I wanted.  After reading your recent discussion on CD art I decided to give it a try and was very impressed, although I did add a couple of higher rotation amounts.  I love eye candy.  I was also very impressed with what D.Sync did with the spinning.  Maybe you could consider adding it in the future.  I'm afraid it's way above my head to try adding it myself.  Thank you again for everything.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-05 16:48:29
Just to give you guys an idea of roadmap, as soon as 1.1.8 is released, I'm going to switch to editing foo_spidermonkey_panel to add my invertColors method there. Once @TheQwertiest is able to merge that, I'm going to take on the Herculean task of trying to convert everything over to use SMP instead of foo_jscript_panel. Once that happens I'll most likely stop updating Georgia for JSP and everybody will have to switch over to SMP if they want the latest changes.

It's time to start converting this theme into something that's a little more maintainable with an ES6+ compatible engine. Unfortunately that means a substantial rewrite of 10k lines of code written over the past 9 years... half of which before I was a professional JS developer :)

Anyway this is part of the reason I'm trying to cram as much goodness as I can into 1.1.8, since it might be the only feature release for the next couple months. Thanks everybody for testing the betas to work out the kinks.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-09 23:30:59
1.1.8 (https://github.com/kbuffington/Georgia/releases/tag/1.1.8) is now officially released. Thanks for everybody beta testing, providing feedback and making requests. I tried to fit in as many as I could.

Final changelog:
- Random now actually randomizes playlist
- Fixed volume control issues
- Improved tooltip handling for buttons
- Fixed issues with expanded volume bar disappearing and it's appearance in 4k mode
- Fixed crash when deleting last playlist
- CD Rotation values were bogus
- Refactored all menus using new Menu helper class, which cut menu code length in half and made adding new options much easier
- Fixed crash when using weblinks
- Playlist row and header fonts are scalable through Options >> Playlist settings
- Option to move transport controls below artwork
- Visual improvements in 4k mode (ensuring spacing between elements is scaled correctly)
- Adding Georgia entries to "Help" menu to quickly debug if the theme is installed correctly
- Added tooltips on hovering over timeline
- Adjust menu font sizes through options menu
- Adjust transport button sizes through options menu
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-05-10 04:10:57
Thank you so much for all of your hard work.  It is greatly appreciated.  All of your new sizing options will be a great help when I copy this over to my backup PC which has a non-4K display.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2020-05-10 05:36:13
As well from my side: thanks very much, the resizing works great and now the theme looks really great on my surface go!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-05-12 01:22:06
I have a open PR for transport control sizing controls and making user defined row height that is greater than the calculated one now override. I have other ideas too I can try to make upstream, mainly hiding the lyrics button, and leaving a space there, and optionally hiding the properties button as well. The settings button seems to be an anchor to the whole thing, so yeah.  There's already a menu stub to get started (font size) so, let me know if you want me to fiddle.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-12 06:39:30
I have a open PR for transport control sizing controls and making user defined row height that is greater than the calculated one now override. I have other ideas too I can try to make upstream, mainly hiding the lyrics button, and leaving a space there, and optionally hiding the properties button as well. The settings button seems to be an anchor to the whole thing, so yeah.  There's already a menu stub to get started (font size) so, let me know if you want me to fiddle.
Left some comments on your PR.

Next version will probably be 2.0.0 since I'll be porting this to SMP. As part of that release, or 2.0.1, I'll be adding some options to what the Right side icons to show, what size they are, and what they look like. All in due time though :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: PrinceSnake on 2020-05-12 17:26:56
Hello,

I have finally setup the theme, but I think I did it incorrectly.
However, old bars are still showing up.
The logos of artists bands and flags are not found when checking theme status, yet they are here :
C:\Users\xxxxx\AppData\Roaming\foobar2000\georgia\images

How to hide then ?
Is there anything I can do ?

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-12 17:52:29
Hello,

I have finally setup the theme, but I think I did it incorrectly.
However, old bars are still showing up.
The logos of artists bands and flags are not found when checking theme status, yet they are here :
C:\Users\xxxxx\AppData\Roaming\foobar2000\georgia\images

How to hide then ?
Is there anything I can do ?


Copy Artist/label/flags to C:\Users\xxxxx\AppData\Roaming\foobar2000\images. Don't put them inside the Georgia folder.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: PrinceSnake on 2020-05-12 18:13:55
Records label are still not shown, (some are in folders, is that okay?, beause I downloaded them that way)
I can't change anything in column UI.. I don't see "layout"
Maybe that's why I don't see the label panel?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-12 19:28:25
Records label are still not shown, (some are in folders, is that okay?, beause I downloaded them that way)
I can't change anything in column UI.. I don't see "layout"
Maybe that's why I don't see the label panel?
To see labels, your music has to be tagged with values in either %publisher% or %label% (or both!)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: PrinceSnake on 2020-05-12 20:40:37
In theme status the record labels pngs are not checkmarked.
They are installed here : C:\Users\Decim\AppData\Roaming\foobar2000\images\recordlabel
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-13 03:41:59
In theme status the record labels pngs are not checkmarked.
They are installed here : C:\Users\Decim\AppData\Roaming\foobar2000\images\recordlabel

That's the correct path. Did you install recordlabel.zip or recordlabel-2020-04.zip there? It currently looks for "Republic.png" to determine if the images were correctly installed in that location and if it can't find that image, the box won't be checked. Not sure if I should just check for the folder or not.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-05-15 05:48:52
Hey, just made an account to say that it's a pretty great skin, but I have a couple of things that aren't showing up for some reason.

Sometimes I will get the record label logo in the corner, but it's never listed along with the other metadata on the left. Neither is the catalog number. I've been storing this information for years on my own, so it should show up. I have the fields named "PUBLISHER" and "LABELNO" (just like CUETools), so I don't see why it won't show. Sometimes the RELEASETYPE field shows, oddly enough. I'm on a 720p monitor, so maybe there's not enough room?

Also I get no hyperlinks. I can't click on anything like it said in the features. And there's no volume bar, but that's not terrible.

Everything else looks pretty cool. One minor thing I would change is to have the Library list display by folder structure and not artists. This way I won't get artists from one-off compilation albums mixed in with the others. Also I have multiple different pressings of the same album sometimes, and it can't differentiate between them.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: PrinceSnake on 2020-05-16 22:03:01
In theme status the record labels pngs are not checkmarked.
They are installed here : C:\Users\Decim\AppData\Roaming\foobar2000\images\recordlabel

That's the correct path. Did you install recordlabel.zip or recordlabel-2020-04.zip there? It currently looks for "Republic.png" to determine if the images were correctly installed in that location and if it can't find that image, the box won't be checked. Not sure if I should just check for the folder or not.

Yes I did installed the zip you mentioned, but the "republic.png" is not present. I wonder also how to select several tracks like I was doing in the original default theme of foobar ? Because I must select them all with CTRL and for multi tagging this is not very easy.

Same as samsara the publisher and label fields are here but are not showing either, I have reinstalled everything to see if there was something wrong I did on my end, but no.. So I don't know how to display LYRICS when I tried to add it as a field, it says "LYRICS is not a valid field name" same when I try to add Publisher and Label, if we forget the small issues I have the theme is so freaking awesome, I can't imagine how much time you gave for it ! congrats
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-17 06:30:13
Yes I did installed the zip you mentioned, but the "republic.png" is not present. I wonder also how to select several tracks like I was doing in the original default theme of foobar ? Because I must select them all with CTRL and for multi tagging this is not very easy.
Then something didn't get fully extracted. Delete the recordlabel folder, download this archive (https://github.com/kbuffington/georgia-image-packs/raw/master/recordlabel.zip) and extract to the same location.

Same as samsara the publisher and label fields are here but are not showing either, I have reinstalled everything to see if there was something wrong I did on my end, but no.. So I don't know how to display LYRICS when I tried to add it as a field, it says "LYRICS is not a valid field name" same when I try to add Publisher and Label
I do not understand what you mean when you say you want to display LYRICS or add Publisher and Label. Where exactly are you adding these? Screenshots could be helpful.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-17 06:43:10
Sometimes I will get the record label logo in the corner, but it's never listed along with the other metadata on the left. Neither is the catalog number. I've been storing this information for years on my own, so it should show up. I have the fields named "PUBLISHER" and "LABELNO" (just like CUETools), so I don't see why it won't show. Sometimes the RELEASETYPE field shows, oddly enough. I'm on a 720p monitor, so maybe there's not enough room?
At the moment, the grid entries are hardcoded in globals.js. Just look in that file for tf.grid. Then you can easily change from %label% which is the default, to %PUBLISHER% and from %catalognumber% to %LABELNO%. Some values like these can be changed in the properties by scrolling down to the "Tag Fields: ...." section and updating them, but as of now, publisher and catalog number are not editable there.

This does mean that when you install a new version of the theme you'll have to redo your grid values. I should probably pull that out into its own file so that it can easily be copied over.

Quote
Also I get no hyperlinks. I can't click on anything like it said in the features. And there's no volume bar, but that's not terrible.
Hyperlinks only exist in the playlist. Hover over something there. Volume button is not enabled by default. Check the options menu >> transport controls.

Quote
One minor thing I would change is to have the Library list display by folder structure and not artists. This way I won't get artists from one-off compilation albums mixed in with the others. Also I have multiple different pressings of the same album sometimes, and it can't differentiate between them.
Open the library panel, then right click on the background (not an item) and select "View by Folder Structure".
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ocean1998 on 2020-05-18 12:51:09
Hi, everything is fine, but I cannot get albums and image art from Spotify, anyways can fix it?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-05-18 18:02:19
Hi, everything is fine, but I cannot get albums and image art from Spotify, anyways can fix it?
This was working fine recently. I'll have to take another look.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ocean1998 on 2020-05-21 19:04:08
any specific settings that I need to make?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Dr. Roboculous on 2020-05-23 01:42:33
hey MordredKLB, i love the theme but, is there any way to get it to just use only the embedded album art i already have in the files? I already set foobar2000 to that option [Prefer Embedded] in the  foobar preferences/advanced menu but the theme still shows only the art from the containing folder of the file i'm listening to. I swear i remember reading on the internet that something somewhere in Georgia had to be changed to $meta. or something. But for the life of me i can't find it again anywhere! Anyway, I just want to use the embedded album art in my files, is there a way to do that?
Thanks!

[P.S.: i'll post this in both the Hydrogenaudio forum and the foobar reddit page.]
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Dr. Roboculous on 2020-05-23 03:05:34
UPDATE TO REPLY #154: for anyone else who might happen upon this topic -[and also i don't see an edit or delete button on this forum] > Solution to my above problem is to just remove the image files from the folder containing whatever you're listening to and make sure the Cycle Through All Artwork option is checked on in the foobar/Georgia Options tab.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-05-28 17:20:43
At the moment, the grid entries are hardcoded in globals.js. Just look in that file for tf.grid

Wow, everything worked! Thanks!
I knew that cataloging the label and other information would pay off someday. When there are multiple labels, I would usually separate them with a semicolon and no space; as I recalled seeing it done automatically with CUETools that way. Unfortunately this doesn't look very pretty under your skin, unless I edit it so that they're separated by commas. I'm just wondering- is this a common way to do it in coding? I'm not a programmer so I just assumed that the semicolon was the default way to list multiple entries of something.

I tried getting the Release Date field to show up, but I've always set mine to MM/DD/YYYY instead of YYYY-MM-DD. I tried changing that part in the global.js, but it didn't do anything. I think I would have to go deep in there and rearrange the part that immediately precedes it. It would be cool to get Georgia to interpret the full release date and display it as actually writing out the month, date and year (ie "released on September 24th, 1995")

One thing I've noticed that seems to be "missing" is that there's no real way to check the composer field. Too much information could clutter up the page, but I think that if you were going to add one more bit of information on the display, composer credits would be first on the list. Also it would be cool to have hyperlinks for them too- to see who wrote what in a user's library.

If I could make another suggestion, I think it would be cool to have a display somewhere for a MEDIA or a FORMAT field. MEDIA is another common one I see people use to distinguish between CD, vinyl, or WEB releases. I personally have gotten more specific with mine to include CDr's, 12" singles, 45's, and MC's (cassettes). I'm sure some interesting stuff could be done with that.

Another very minor thing would be to maybe display the total number of tracks in the playlist, or album. Sometimes I just want to quickly check my player to see how close I am to the end of a certain album.

Great idea on the artist flags too. None of my files had the 'artistcountry' field before, but now I find myself adding them in whenever I use your skin.

Hyperlinks only exist in the playlist. Hover over something there. Volume button is not enabled by default. Check the options menu >> transport controls.

The only thing that doesn't seem to work for me is when I click the record label. Year, genre, artist, and everything else works fine, but for some reason not the label. Also the lyrics don't seem to work, but I think you said somewhere else that that still needs to be worked on. Or maybe I just need to add in the component, I don't remember.

I almost forgot to mention, that I had to turn off the option that makes it cycle through the album art. Any folder of mine that has album booklets would mash all of the text way over to the left side of the screen. If I could, I would set it to only cycle between the "cover", "back", and "disc" files.

I'm fairly new to foobar skins, but I think that yours is now my favorite. Everything is functional, it's not too needlessly complicated, and I can actually click a single track or album and it will stop after it's played without automatically going to the next record. I bet you could monetize this somehow. This thread just proves that there is a market for a real audio player, or "streaming service" for music lovers. Imagine if there were a streaming service with your theme: with full artwork scans, sorting by record label, aesthetic design, options to choose between different formats and album pressings... Very cool thing you've got going here. Thanks for answering my questions and designing this great player for us all.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Ohdengoh on 2020-06-03 23:53:29
Hello, I've been using the theme for a while now and I'm generally very happy with it. I've done a bit of fiddling with the code to make it look nice on my display but I've run into an issue I don't know how to change. It has to do with the "image" buttons, show playlist/lyrics/library etc. I would like to increase the size of the icons. Starting with the playlist view icon, i made a new 48x48 icon and modified the pref.list_img field to point to the new icon.

However, the display ends up looking like in the image below where the bottom part of the new icon is cut off. How can I fix this?

(https://i.imgur.com/KbORmRl.png)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-06-04 20:44:19
<lots of stuff>
Gonna try and respond point by point so hopefully I don't miss anything.

1) You were basically doing the right thing by seperating labels with a semicolon. However due to the esoteric nature of ID3 tags, and how different taggers encode things, there's a disconnect. For one, some taggers treat PUBLISHER and LABEL fields differently: PUBLISHER can only have a single value, while LABEL can have multiple values. Therefore if your tagger was writting to PUBLISHER and separating them with semicolons, the actual value foobar will see is "Atlantic Records; Interscope" and not "Atlantic Records" and "Interscope". Depending on the tagger, the same thing could be happening even in LABEL. If you tagged the files using foobar, the semicolons would denote multiple values and everything would look good and be separated with pretty bullets in the UI. Your best bet is using Foobars mass tagger to convert your fields with Semicolons into multi-value fields. You might need to do some research there.

2) MM/DD/YYYY is interesting. Javascript can handle that just fine, but I'll have to check why nothing else is. I'm probably making assumptions to expect the default YYYY-MM-DD format though.

3) I want to make the grid be a lot more extensible from the UI. That'll need to wait until after migration to SMP though.

4) MEDIA might make a lot of sense in the upper right under the year. What do you think?

5) Total tracks are displayed in the playlist view. Not sure where it makes sense in the main UI.

6) If hyperlinks for record labels aren't working, make sure you're trying it on a label with only a single value. Given that you have issues with the semicolons, I'm guessing it's related.

7) I don't keep booklets in my folders, and I didn't want to have an exhaustive list, so it's just *.jpg, *.png, etc. This makes me wonder if a JSON based preferences file might be a good idea. Could be a simpler alternative for controlling what's in the grid as well.

Thanks for all the kind words, and glad you love the theme!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-06-04 20:46:08
Hello, I've been using the theme for a while now and I'm generally very happy with it. I've done a bit of fiddling with the code to make it look nice on my display but I've run into an issue I don't know how to change. It has to do with the "image" buttons, show playlist/lyrics/library etc. I would like to increase the size of the icons. Starting with the playlist view icon, i made a new 48x48 icon and modified the pref.list_img field to point to the new icon.

However, the display ends up looking like in the image below where the bottom part of the new icon is cut off. How can I fix this?

(https://i.imgur.com/KbORmRl.png)
As of now those button image sizes are hardcoded, or at least based on the size of the first image in the list (the gear). I don't have the code in front of me right now, but try making a 48x48 version of the gear and see what happens.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-06-20 13:18:13
1) You were basically doing the right thing by seperating labels with a semicolon. However due to the esoteric nature of ID3 tags, and how different taggers encode things, there's a disconnect. For one, some taggers treat PUBLISHER and LABEL fields differently: PUBLISHER can only have a single value, while LABEL can have multiple values. Therefore if your tagger was writting to PUBLISHER and separating them with semicolons, the actual value foobar will see is "Atlantic Records; Interscope" and not "Atlantic Records" and "Interscope". Depending on the tagger, the same thing could be happening even in LABEL. If you tagged the files using foobar, the semicolons would denote multiple values and everything would look good and be separated with pretty bullets in the UI. Your best bet is using Foobars mass tagger to convert your fields with Semicolons into multi-value fields. You might need to do some research there.
I've been trying some of the things you said this morning, and I just can't seem to get it to display logos when there's more than one label. I've seen Georgia display logos for EMI America and Rolling Stones Records separately, so I know it has them. I have a record that's attributed to both of these labels, and it never shows me the logos. I do this manually by the way, using foobar's default tagger. I don't know how you got it to work in your sample image.

I tried changing the default value for 'label' back to LABEL in global,js, just to see if it would work, and it hasn't. Even though the bullet point shows up, the logos on the bottom right of the window never do. Then I tried adding in [%PUBLISHER%] and [%LABEL%], then after that I tried %ORGANIZATION%, none of which worked. I know that there's a bit of a disconnect with the PUBLISHER field; I don't know the exact specifics, but either ID3 tags or foobar have PUBLISHER interchangeable with ORGANIZATION for some reason. Which is why I thought that the default 'LABEL' would work. That WAS the default, right? I should have saved a backup early on. Luckily I have a backup of the global.js file before I messed with it this morning.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-06-22 12:57:21
Just looked at the code for you; it's on georgia-main.js. It aggregates off PUBLISHER and LABEL, by default. I tried "Metal Blade Records" as the publisher, and for the label, "Virgin" and then re-loaded and they both appeared. Good luck!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-06-22 18:49:10
Just looked at the code for you; it's on georgia-main.js. It aggregates off PUBLISHER and LABEL, by default. I tried "Metal Blade Records" as the publisher, and for the label, "Virgin" and then re-loaded and they both appeared. Good luck!

Oh my God it worked! Now what would you do if there were three labels? I believe in one of his sample images he shows the Bladerunner soundtrack and it has three logos. Thanks!
Now this is opening a whole new pandora's box of confusion. Seems like I can get the logos when I do it the way you described, but the text on the left side of the screen will only show the Publisher. I've been trying a bunch of different combinations and changes to global.js, but so far I can't seem to get the two labels displayed on the left-side information bar AND the right-side logos. The closest I got was the logos, and then on the left-side of the screen I got the two labels listed, but it didn't recognize them as two separate labels, so instead of showing that nice bullet point, it showed a comma, which also would only display one of the labels in the playlist view (hyperlinks). Anyway, I think I can live with that setup for now

Another update: Ok now it is showing the bullet point, but then it takes away one of the logos. also only a hyperlink for one of them in the playlist view

Final Update: I think I got it the way it was intended. I think in the case of the album I'm talking about, Rolling Stones records would be the label, and EMI America would be more of a publisher. I'm thinking that maybe you're not supposed to see a display or hyperlink for the publisher, and I personally wouldn't care to see what records would be on a major organization like that anyway. I'm sure as time goes on I will come across more examples where an album is legitimately on two or more labels, and I would want to see a display for those labels, but I digress. For now, I'm satisfied
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-06-23 00:11:07
So you can add any number of labels you want according to the code.

See globals.js (my line 195 begins like this...)
tf.labels = [ // Array of fields to test for publisher. Add, change or re-order as needed.
   'label', // DO NOT put %s around the field names because we are using $meta() calls
   'publisher',
    

if you add 'producer' or something to that array and save+reload, make a new tag on the songs with that same reference, (producer) and give value of 'Metal Blade Records' or whatever, you'll have 3 show up.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-06-23 16:38:45
hmm, is that really the only way to do it? only one label per field? Mordred was saying up above somewhere in response to me that separating the labels by semicolons should work - in theory. But the whole problem started for me when it had "Label" as the default field and not "publisher", only because for all this time I've been saving label information under that tag, as it seems to be the universal way of doing so.

So I just tried adding 'publisher' to the array of fields, and it makes Georgia crash. I get this message:

JScript Panel v2.3.6.1 (Georgia by Mordred)
JavaScript compilation error:
Expected ']'
File: C:\Users\[redacted]\Music\Audio players\Georgia\georgia\js\globals.js
Line: 196, Col: 2
   'publisher'

Edit: My bad, it was because I didn't add a comma at the end. But it also seems to have done nothing, because it still wont display the label name on the left side of the screen, at least when it's under 'publisher' and not 'label'. It actually made it worse somehow, because now it will only display one logo. I'm changing it back

Edit 2: Ahhh so confusing, it was because there was no logo for the second label i was looking at.
This is really strange, but it will only show one label in the playlist view in the hyperlinks. I can't remember if I saw it show two last time. But at first I thought it was because it would only show the 'label' field, but for files without a 'label' field, it will display the 'publisher' field. So i guess it recognizes both but can't show them both.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-06-23 17:27:52
So you can add any number of labels you want according to the code.

See globals.js (my line 195 begins like this...)
tf.labels = [ // Array of fields to test for publisher. Add, change or re-order as needed.
   'label', // DO NOT put %s around the field names because we are using $meta() calls
   'publisher',
    

if you add 'producer' or something to that array and save+reload, make a new tag on the songs with that same reference, (producer) and give value of 'Metal Blade Records' or whatever, you'll have 3 show up.
Just for clarification, the tf.labels array is only used for displaying images... and not what shows on the left hand metadata grid or in the playlist. The left hand side uses the tf.grid label value. The playlist uses either %label% if it exists, and if not, %publisher%. I should probably look at simplifying that to use the same logic tf.grid uses at least.

Samsara, you said you were seeing bullets between the labels on the left, but only a single logo image, correct? That's very confusing to me. Can you share a link to a file that shows this behavior so I can debug exactly what's going on? I think that'll be the simplest way to resolve this because it seems I'm missing something right now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2020-06-24 23:43:56
Hello, this skin is great and everything works fine. Many thanks to the author.
Anyway, I was wondering, is it possible to display the record label logos without the background color (or with a transparent background?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-06-25 04:27:21
Hello, this skin is great and everything works fine. Many thanks to the author.
Anyway, I was wondering, is it possible to display the record label logos without the background color (or with a transparent background?
Hmmm... I put the backdrop on there so that cd/vinyl art wouldn't overlap them and look stupid. It might look pretty good just drawing them on the background, below any cdart. I might give that a shot and make it an option. I'm intrigued with what it might look like.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2020-06-25 10:26:10
Thank you!
I believe it will look good. Sometimes its the backdrop that overlaps the cd art, and without it, it may present a cleaner look.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-06-26 12:58:05
I removed the backdrop and the logo looks great against the blue background I use.  However, I'm not sure how a black logo would look against the default dark mode background.  It also seems to have eliminated the overlap with CD art, at least with the logos I have seen so far, and definitely gives it a cleaner look.  I can see where you might need to drop it down a little to avoid overlapping with larger logos.  I definitely think this is an option people might like.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-06-26 21:46:19
I spent a lot of time and effort making sure the logos themselves do not touch the CD art in anyway (seriously that code is a minefield of intensive calculation loops and trigonometry) but with some very square labels it can look really stupid butting up against the cd art, which was one of the reasons I did the background to begin with (plus I kinda like how the little background tab looks). I'll definitely add this as an option though and set it so that it never uses the inverted color logo.

It also might not look as good in light mode, but I'll have to double check that.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-06-27 03:42:17
I reverted back to your default background color and, at least with the logos I tested, they didn't look too bad in either dark or light mode, even if they were inverted.  But I have to admit that I think they look a lot better with the backdrop when using your default background.  Thank you for all your hard work and your willingness to grant our requests.  I spend a lot of time studying your code and am amazed at the complexity and the effort required.  To those of you appreciate this theme, I strongly encourage you to please make a PayPal donation using the link at https://github.com/kbuffington/Georgia.  It is well deserved.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-06-28 02:59:23
I reverted back to your default background color and, at least with the logos I tested, they didn't look too bad in either dark or light mode, even if they were inverted.  But I have to admit that I think they look a lot better with the backdrop when using your default background.  Thank you for all your hard work and your willingness to grant our requests.  I spend a lot of time studying your code and am amazed at the complexity and the effort required.  To those of you appreciate this theme, I strongly encourage you to please make a PayPal donation using the link at https://github.com/kbuffington/Georgia.  It is well deserved.
Oh god, people looking at some of this code to learn gives me hives. Much of it was written 8+ years ago when JS was a hobby for me. A lot of it will be undergoing a rewrite shortly and I can excise some of the terrible crap in there and clean things up (and introduce new bugs!). I've been holding off starting that process while waiting for @TheQwertiest to release a new version of FSM and migrate over to that, but I should probably start that on it now, even if it'll take him a bit.

I definitely appreciate the love you've shown my through donations though. Means a lot that people enjoy this theme so much they're willing to pay for it even when they don't have to.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-07-06 09:46:24
Ah, I know it's been a while but I've been kind of busy with other stuff - figure I should stop putting this off and send you my globals.js. I thought I had the multiple logos and everything working for a minute there, but now I'm back to only seeing the 'label' field and not the 'publisher' field. Also I still don't know how to get more than two logos to show up. Closest I got was to seeing the multiple logos and labels, but there was no bullet point, comma, or space between the multiple labels. For example, if I had Columbia and Legacy it would show up on the left side as ColumbiaLegacy. So I tried to fix that and I don't know what I did, here it is:

Samsara, you said you were seeing bullets between the labels on the left, but only a single logo image, correct? That's very confusing to me. Can you share a link to a file that shows this behavior so I can debug exactly what's going on? I think that'll be the simplest way to resolve this because it seems I'm missing something right now.

https://pastebin.com/DPTJ09y1

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-06 16:49:04
Ah, I know it's been a while but I've been kind of busy with other stuff - figure I should stop putting this off and send you my globals.js. I thought I had the multiple logos and everything working for a minute there, but now I'm back to only seeing the 'label' field and not the 'publisher' field. Also I still don't know how to get more than two logos to show up. Closest I got was to seeing the multiple logos and labels, but there was no bullet point, comma, or space between the multiple labels. For example, if I had Columbia and Legacy it would show up on the left side as ColumbiaLegacy. So I tried to fix that and I don't know what I did, here it is:

Samsara, you said you were seeing bullets between the labels on the left, but only a single logo image, correct? That's very confusing to me. Can you share a link to a file that shows this behavior so I can debug exactly what's going on? I think that'll be the simplest way to resolve this because it seems I'm missing something right now.

https://pastebin.com/DPTJ09y1
I'll take a look at the globals.js, but it'd be better if you uploaded an audio file that shows this behavior.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-07-07 06:24:10
I'll take a look at the globals.js, but it'd be better if you uploaded an audio file that shows this behavior.

https://imgur.com/a/np2S6X4

Does this help? I suppose I could upload some files to mediafire, but I think some screenshots of the metadata and Georgia display should be enough, right? Let me know if you'd like a .zip with the files from the screenshots
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-07-07 12:09:47
I have two feature suggestions:  I may take a crack at them and issue a PR if that's okay

1) If the song playing has a blank or lyrics file that does not exist, but the lyrics are enabled, hide the backdrop as if lyrics didn't exist but don't cancel out of lyrics mode in case the next song has them. I cannot speak for the lyrics engine but I think it reloads itself and could potentially re-enable it if it suddenly finds it by itself.
2) Add a global menu setting that if you play a song, optionally it will go into the full view after n seconds automatically. (e.g. if you're in the library, double click an album, and go AFK, in 5 seconds it will take you to the full view with the CDart and other stuff.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-07 16:07:34
The problem with doing #1 is that there's not a good visual indicator in the UI that lyrics mode is enabled, unless the backdrop is there. Even highlighting the lyrics button isn't obvious enough because the highlights are relatively subtile.

#2 is interesting, but I don't know how many people would actually want that. It also creates a weird situation where I play a song, the library hides, and then I reopen the library, but don't do anything for a few seconds while I'm trying to remember the name of an artist... does the library hide again? It becomes pretty difficult to determine intent. Now I *might* be okay with a situation where if you move the mouse off of the playlist/library and wait X seconds without user input, then they auto hide. I think that's a better situation than just no user input.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-07-07 18:04:45
Definitely valid points.

1) Maybe the event could only fire if it previously had lyrics, the mode didn't change, and the song it has now is missing lyrics. That kind of solidifies that the user knows whats going on. Otherwise the 'Display Lyrics' tooltip could be a toggle based text instead. Like Show Lyrics, Hide Lyrics. Then people know what state its in anyways. It could even flash the backdrop to show that it is missing for a second, if the state goes from hasLyrics = true to hasLyrics = false. This is something I noticed when playing games; I'll set a song, forget to change the mode, and look on my other monitor and wish it was in the play mode.
2) I would suggest a median timer of 60 seconds. In theory, the library would hide based on the trigger of double clicking a song in the playlist or library. After you do that, it starts the timer. If you switch tabs, or click something in the current tab, before the timer goes off, the timer is nullified. The event will not be started again unless it has the same trigger (double click)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-07 20:20:07
https://imgur.com/a/np2S6X4

Does this help? I suppose I could upload some files to mediafire, but I think some screenshots of the metadata and Georgia display should be enough, right? Let me know if you'd like a .zip with the files from the screenshots
That does help. BTW, I forgot a little about how some of this stuff works, so I apologize for not steering you to the answer directly earlier.

What you should do now is stop using both LABEL and PUBLISHER. Just pick one. Using both works for images because I'm generous like that but it will only show the values of one or the other everywhere else. That won't be changing.

Let's say you decide to standardize on LABEL. Open up Foobar's preferences, select Advanced at the very bottom, and then expand Display >> Properties Dialog and edit the values under Multivalue fields to add LABEL (or PUBLISHER if you want!)

(https://i.imgur.com/s7nzOob.png)

(You can also add "Label=LABEL;" to the Standard Fields input which will make your properties dialog look much cleaner).

Now, go to a file that you want to have multiple labels, and go to the properties pane. Enter the values as "Roc-a-Fella Records; Freeze Records; Priority Records" (don't add a trailing ; as that might screw things up). Hit okay, and now you will have a single LABEL field with 3 multiple values in it. Everything will be separated with bullets and all 3 logos (if images exist) will show up.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-07-09 00:25:51
Hi.  I've just noticed another issue with Georgia and Jscript panel 2.4.  Tool tips on the main panel only work 3 or 4 times, then stop working until I do a reload.  Then they work another 3 or 4 times before I have to reload again.  This happens regardless of the Foobar version I am on.  Frankly, I think I'm going to stick with Foobar 1.5.5 anyway for other reasons.  But I thought you should know.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-07-09 10:30:14
What you should do now is stop using both LABEL and PUBLISHER. Just pick one. Using both works for images because I'm generous like that but it will only show the values of one or the other everywhere else. That won't be changing.

Let's say you decide to standardize on LABEL. Open up Foobar's preferences, select Advanced at the very bottom, and then expand Display >> Properties Dialog and edit the values under Multivalue fields to add LABEL (or PUBLISHER if you want!)

Ayee it works! Let the court records show that I did not want to use multiple fields in the first place, I was just following the other guy's suggestion. Thanks :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-07-09 11:06:07
Regarding broken tooltips in 2.4.0.... it's crappy docs which have led to the creation of buggy scripts compounded by buggy behaviour in the component as well. *sigh*

Basically, I've always known you're only supposed to call window.CreateTooltip once per panel instance but this rather important fact is missing from the docs. It's not even present in the WSH panel mod docs which is where the original code was inherited from. Unfortunately, library tree misuses it and is the cause of problems in the Georgia theme.

Current options:
If you're migrating to SMP, just ignore it. It will probably work there.
Strip tooltip support from library tree
Update Library tree to use the single g_tooltip instance created in georgia-main.js

Why does it break in v2.4.0 but work in earlier versions....well that's my half arsed attempt at rewriting tooltip support without realising any of the above was an issue. It's more luck than judgement that it "worked" before. The next version will be even less desirable because it's going to throw errors. :o
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2020-07-09 13:08:13
If you're migrating to SMP, just ignore it. It will probably work there.

*citation needed* :D

I think SMP handles tooltip exactly the same (iirc, I didn't touch tooltip handling logic at all), so current SMP versions will have the same problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-07-09 13:17:23
That's exactly why it'll work - you've not changed anything. I have.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-07-09 18:21:35
I changed Panel_Library.js  to use g_tooltip,  as suggested by snotlicker, when setting variables tt and but_tt.  So far so good using Jscript panel 2.4 with Foobar 1.6 beta 5.  Thank you very much.  I've made quite a few changes to Georgia and I'm not sure if I'm going to be able to retrofit my changes into the SMP version so I'm hoping to continue using the Jscript version as long as possible.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-07-11 06:11:31
I'm having a little trouble trying to customize the library view. In foobar, I've got the following code snippet to group everything into 3 buckets: (Soundtrack, Modern, and Classical). I cut/pasted it from the standard Foobar library views where itworks fine, but it renders strangely in Georgia. Any ideas?
Spoiler (click to show/hide)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-07-11 08:18:07
>=0 is nonsensical in title formatting terms. You can't use it.

Also your first puts is missing the $ but that's probably just a copy/paste error for the forum??
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ravenmyst on 2020-07-11 16:23:23
First of all, I wanted to thank you for the recent changes. The tags look fantastic now even when there's a lot.

I have another request/ suggestion.

When playing, the CODEC in the 'now playing' mode seems to be based on the "ENCODER" song tag or something similar? In the playlist, it shows the actual codec of the file.  (e.g. if I play 24bit flac, it shows "flac 24bit/44.1khz" in the playlist, and in the CODEC field, it shows 'FLAC'.) most of my files that dont have many tags dont show any 'CODEC'

I guess from a design perspective, what is there makes sense; it scrapes the music tags, but for the codec wouldn't it make sense to dig into the file itself? Maybe a preference to enable/disable scraping vs respecting tags if it would be something best left toggled?

This also happens under the album year under the menu buttons... e.g the album year says "1999" "flac", and I'd expect either one place or the other to specify what kind of flac.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-11 19:50:46
If you're migrating to SMP, just ignore it. It will probably work there.

*citation needed* :D

I think SMP handles tooltip exactly the same (iirc, I didn't touch tooltip handling logic at all), so current SMP versions will have the same problem.
FTR, I started migration to SMP yesterday and tooltips are completely messed up all over the place :) Not sure if it was related to the JSP issues or not though. I'll have to sort through it all.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-11 20:00:40
First of all, I wanted to thank you for the recent changes. The tags look fantastic now even when there's a lot.

I have another request/ suggestion.

When playing, the CODEC in the 'now playing' mode seems to be based on the "ENCODER" song tag or something similar? In the playlist, it shows the actual codec of the file.  (e.g. if I play 24bit flac, it shows "flac 24bit/44.1khz" in the playlist, and in the CODEC field, it shows 'FLAC'.) most of my files that dont have many tags dont show any 'CODEC'

I guess from a design perspective, what is there makes sense; it scrapes the music tags, but for the codec wouldn't it make sense to dig into the file itself? Maybe a preference to enable/disable scraping vs respecting tags if it would be something best left toggled?

This also happens under the album year under the menu buttons... e.g the album year says "1999" "flac", and I'd expect either one place or the other to specify what kind of flac.
So this the Codec definition:

[$if($not($strstr(%codec%,'MP3')),$replace($if2(%codec_profile%,%codec%),ATSC A/52,Dolby Digital)[ $replace($replace($replace($info(channel_mode), + LFE,),' front, ','/'),' rear surround channels',$if($strstr($info(channel_mode),' + LFE'),.1,.0))])]

Basically all I really use it for is correctly showing friendly names channels for multi-channel music. It doesn't use the ENCODER field at all. I don't listen to FLAC on my system, so it's obviously pretty overlooked. I'm assuming you'd want to see something like what the playlist does. I need to do more to reuse that code through the UI. I"ll add it to the TODO list.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-24 06:05:57
What am I doing? Oh, just rewriting all lyrics handling from the ground up....

(https://i.imgur.com/49zcoig.png)

...this process might be driving me crazy. At least the code will make sense and it'll be possible to fix bugs. No idea where I got the current lyrics code, but it was... not great.

Anyway, migration to Spider Monkey is going well. There'll be some really cool things coming down the pike that I think everybody will be excited about. Installation and upgrades are going to get simpler, changing settings/options will be easier (and there will be more of them!), the theme is faster and more responsive than before thanks to FSM, and the code will be maintainable. I keep finding things to change and improve though so we're probably a 3-4 weeks out before a beta release is available. Adventurous folks can pull down the spidermonkey branch and see what I'm working on as it's relatively stable now, but at the moment I'll be ignoring all bug/request/PRs on that branch. It's too in flux right now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-07-28 11:25:20
DELETED
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-07-28 11:35:56
NM, I'm an idiot. Figured out my problem as being a few other cut/paste things that I missed.
Corrected version below works great and now I have my albums sorted by release date that way I like them.

Spoiler (click to show/hide)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-07-29 04:07:45
Hi.  I've been playing around with your SMP version and so far so good except loading lyrics crashed with a "gLyrics undefined" message.  You had recently removed the two gLyrics lines below.  I added them back and lyrics load fine now.  I know you still have a lot of work to do and I won't be bugging you, but just wanted to let you know what I found.

function refresh_lyrics() {
   if (fb.IsPlaying || fb.IsPaused) {
      gLyrics = new Lyrics(fb.GetNowPlaying());
           gLyrics.on_size(albumart_size.x, albumart_size.y, albumart_size.w, albumart_size.h);
      let refreshLyricsProfiler = null;
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-07-29 08:37:01
Nitpick: fb.IsPaused can never be true if fb.IsPlaying is false so there is no point checking for it.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-07-29 11:16:51
Lyrics load fine now with your latest changes.  After I changed the spider monkey panel to load georgia-theme.js instead of georgia-configuration.js, which is still in Georgia.txt.  Oops.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-29 18:32:04
Nitpick: fb.IsPaused can never be true if fb.IsPlaying is false so there is no point checking for it.
That's old code that someone else wrote. It's all going away shortly :)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-07-29 18:37:45
Lyrics load fine now with your latest changes.  After I changed the spider monkey panel to load georgia-theme.js instead of georgia-configuration.js, which is still in Georgia.txt.  Oops.
Dangers of not committing every file I have checked out. You'll have to bear with me :D

BTW, check out the configuration stuff in georgia-config.jsonc. It's completely worthless since it gets rewritten each time the theme loads (you can temporarily prevent this by removing the "|| true" from line 289 of globals.js), but let me know if it at least makes sense.

I'm pretty excited to stop using panelProperties for most things.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-07-29 21:15:30
The JSONC file worked great once I figured out the syntax differences.  Using $meta_sep instead of $replace threw me for a loop at first because SMP evidently doesn't like $replace at all.  But, hey, I learned something new.  I'm getting really anxious to see the "new" Georgia once you release the beta.  I know it will be worth the wait.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-09-11 16:00:38
Hi.  I'm still having the issue with Georgia crashing on startup with Jscript Panel 2.4.1.1 under Foobar 1.6.  However, version 2.4.0 works just fine so I really don't have an issue.  I just wanted to let you know.  I hope everything is going well with your Spider Monkey conversion.  The label logo background option works great!

JScript Panel v2.4.1.1 (Georgia by Mordred)
JavaScript runtime error:
Object doesn't support this action
File: D:\Foobar2000g\profile\georgia\js\georgia-main.js
Line: 41, Col: 2
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2020-09-12 11:10:52
Hi, I've got a similar error to dwmartin0906. Upgraded to foobar 1.6 and the latest jscript panel and got this javascript error. Tried to download version 2.4.0 but can't find it.

JScript Panel v2.4.1.2 (Georgia by Mordred)
JavaScript runtime error:
Object doesn't support this action
File: C:\Users\Zoidberg\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Library.js
Line: 2697, Col: 3
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-09-12 12:34:33
I submitted a fix for Georgia before I released breaking changes in JScript Panel. I can only assume you don't have the latest version of the theme??
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2020-09-12 13:37:54
I submitted a fix for Georgia before I released breaking changes in JScript Panel. I can only assume you don't have the latest version of the theme??

The latest Georgia version I have is 1.1.9.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2020-09-12 15:45:31
The latest Georgia version I have is 1.1.9.
Georgia 1.1.10 (download here (https://github.com/kbuffington/Georgia/releases/tag/1.1.10)) seems to be stable with latest Jscript Panel.
Just download and unzip either 'Soure code (zip)' or 'Source code (tar.gz)', which contains the Georgia code.
The file 'foo_jscript_panel-2.4.1.1.fb2k-component' is the updated JScript Panel (by the way, there is now 2.4.1.2 available, see here (https://github.com/marc2k3/foo_jscript_panel/releases)).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2020-09-13 00:31:20
Thank you! It's working now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Enigma776 on 2020-09-13 20:19:28
Love this theme but I have yet to find a way to change the volume from within the theme itself, am I missing it or am I super stupid?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-09-14 05:20:54
Love this theme but I have yet to find a way to change the volume from within the theme itself, am I missing it or am I super stupid?
There's a volume button that can be enabled in the transport section of the settings menu.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-09-23 07:52:42
Hmm, just upgraded to 1.1.10 and foo_jscript_panel-2.4.1.2 and I get the following on startup with foobar 1.5.5 or 1.6.0. Works fine after a reload.

Code: [Select]
JavaScript runtime error:
Not implemented

File: C:\Users\jimmy\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 41, Col: 2
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2020-10-10 02:50:19
Hey Mordred, still love the skin, but I have a question/request. Is there a way to manually cycle through the artwork instead of having it on a 30 sec timer? I have a lot of artwork and booklet scans and I would absolutely love to be able to cycle through them in-app instead of opening up my folders and doing it manually. Also is there something wrong with my lyrics panel? Nothing seems to show up when I click it, I forgot if that was a bug or just me. Thanks
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: mist475 on 2020-10-14 09:42:19
I have recently been checking out the availability of logos, most artists that i own material of have a logo already present, however, the following artists have a proper fanart.tv logo that are not yet included with the theme:
*abba
*acoustic alchemy
*clannad
*elton john
*elvis presley
*john williams
*keane
*kraftwerk
*lenny kravitz
*mc hammer
*paul simon
*snowy white
*rick astley
*roger hodgson
*ry cooder
*sade
*steely dan
*sting
*styx
*talking heads
*carpenters
*the cranberries
*the flaming lips
*the police
*the verve
*toto
*bono
*rod stewart
*don johnson
*dinah washington
*foreigner
*a-ha
*bette midler
*the moody blues
*van morrison
*eagles
*sixpence none the richer
*george michael
*the house of love
*beck
*the kills
*miles davis
*yello
*the doors
I could probaply sent a zip file to save some time
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-10-19 06:29:27
Hey Mordred, still love the skin, but I have a question/request. Is there a way to manually cycle through the artwork instead of having it on a 30 sec timer? I have a lot of artwork and booklet scans and I would absolutely love to be able to cycle through them in-app instead of opening up my folders and doing it manually. Also is there something wrong with my lyrics panel? Nothing seems to show up when I click it, I forgot if that was a bug or just me. Thanks
For lyrics you have to have previously downloaded them and stored them somewhere that the theme can find. This will be easier in the 2.0 version which I need to get off my butt and release a beta for shortly.

As of now, there's not a way to manually cycle through artwork, but I'll think about how that could be implemented. Maybe a left-right arrow if the playlist/library panels aren't visible? Curious if you've got thoughts there.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-10-19 06:31:05
I have recently been checking out the availability of logos, most artists that i own material of have a logo already present, however, the following artists have a proper fanart.tv logo that are not yet included with the theme:
Thanks for the list. I went through and grabbed most of them, so they'll get added when I push a new update of the theme packs. Some of those artists didn't have white logos, or full size logos which I require to get added to the list.

You're welcome to make a Merge Request in the georgia-image-packs repo if you like. That's probably simplest for me.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: mist475 on 2020-10-22 12:25:29
I have recently been checking out the availability of logos, most artists that i own material of have a logo already present, however, the following artists have a proper fanart.tv logo that are not yet included with the theme:
Thanks for the list. I went through and grabbed most of them, so they'll get added when I push a new update of the theme packs. Some of those artists didn't have white logos, or full size logos which I require to get added to the list.

You're welcome to make a Merge Request in the georgia-image-packs repo if you like. That's probably simplest for me.
Sure, will do that next time i find logos that are missing
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: mist475 on 2020-10-22 13:40:31
When i play songs using foo_spotify or foo_youtube the album art doesn't update (https://github.com/kbuffington/Georgia/issues/53), is there an easy way to fix this?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-11-05 16:06:04
Hi Mordred.  I hope you are doing well.  No rush, but I was just curious if you plan to release the Spidermonkey beta anytime soon.  I'm using your current version and everything is working well.  I was glad I could finally remove the Jscript panel.  Just as an FYI, I am having the same issue mist475 has with the new artist not automatically updating when playing from a streaming source, but it's not really a big deal for me.  Thanks again for this great theme.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-11-17 17:59:51
After peeking at this github ticket https://github.com/kbuffington/Georgia/issues/52 I tried switching from "auto" to "always" and it appears to have fixed my crash on startup issue.

Hmm, just upgraded to 1.1.10 and foo_jscript_panel-2.4.1.2 and I get the following on startup with foobar 1.5.5 or 1.6.0. Works fine after a reload.

Code: [Select]
JavaScript runtime error:
Not implemented

File: C:\Users\jimmy\AppData\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 41, Col: 2
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-11-17 18:47:34
Yeah, this is related to the breaking tooltip changes in JSP v2.4.1 and later. I just had a quick poke around at the code and I thought the use of sizeInitialized variable inside the main on_size function prevented the fonts/tooltips being set more than once. I didn't realise that resizing the entire panel over/below 3000 pixels wide reset the variable to false which means the call to set the tooltip size is made again which is not permitted.

It can be "fixed" by editing Georgia\js\georgia-main.js line 41

Code: [Select]
	g_tooltip = window.CreateTooltip('Segoe UI', scaleForDisplay(15));
g_tooltip.setMaxWidth(scaleForDisplay(300));
g_tooltip.text = ''; // just in case

replace with

Code: [Select]
	if (!g_tooltip) {
g_tooltip = window.CreateTooltip('Segoe UI', scaleForDisplay(15));
g_tooltip.setMaxWidth(scaleForDisplay(300));
g_tooltip.text = ''; // just in case
}

However, this does mean the tooltip size won't change when the rest of the layout does. Only reloading the panel would fix that.

SMP doesn't have this issue so waiting for that is probably the best bet.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-11-17 21:05:19
JSP v2.4.3 released just now has a new window.SetTooltipFont method so the replacement code above could be improved...

Code: [Select]
if (!g_tooltip) {
    g_tooltip = window.CreateTooltip();
}
window.SetTooltipFont('Segoe UI', scaleForDisplay(15));
g_tooltip.SetMaxWidth(scaleForDisplay(300));
g_tooltip.text = ''; // just in case


Title: Re: Georgia: A dynamically generated fb2k theme
Post by: f9fb4d656d on 2020-11-17 21:47:50
JSP v2.4.3 released just now has a new window.SetTooltipFont method so the replacement code above could be improved...

Thanks, confirmed that both of your suggestions will fix the problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-11-18 00:35:43
Just an FYI.  I've been playing with the SMP version of Georgia since it first became available in July and have had no issues since the last update in September except for the new artist not automatically updating when playing from a streaming source as mentioned above (the Jscript version also has this issue).  Please just remember that Mordred stated in an earlier post that he will not be addressing any issues or requests for the SMP version until he releases the beta version.  I would hate for people to start bugging him because of this post.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2020-11-18 04:38:07
If the artist info isn't changing while listening to radio streams, I suspect the script isn't making use of the on_playback_dynamic_info_track callback which is built into JSP and SMP. This is specifically there for updating panels when artist/title changes from radio streams where the usual on_playback_new_track for local files isn't called.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2020-11-30 06:00:43
Hey guys, apologies for the delays with updates. I hurt my neck almost 2 months ago and have been in a lot of pain and on a lot of painkillers. I can't sit at a desk or work very comfortably from a laptop so I haven't been able to get much done on this. I'd love to say a beta will be coming out before the new year, but at the moment I don't want to make any promises.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-11-30 06:51:14
I'm so sorry to hear about your injury and hope you get better soon.  As for Georgia, I've been using your SM version since you last updated it in September.  It's great as it is and I haven't found any significant issues.  There's certainly no rush to get a beta out.
 Best wishes and thank you for all that you've done.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2020-12-01 13:07:43
Hey guys, apologies for the delays with updates. I hurt my neck almost 2 months ago and have been in a lot of pain and on a lot of painkillers. I can't sit at a desk or work very comfortably from a laptop so I haven't been able to get much done on this. I'd love to say a beta will be coming out before the new year, but at the moment I don't want to make any promises.
Sorry to hear that, neck injuries are a huge PITA. Hope that it heals up nicely in the end.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Dawn.Violet on 2020-12-04 01:47:44
Hello, I'm completely new to using themes for fb2k, and I really can't wrap my head around how to install Georgia. I am following the instructions on the github page, but I'm stuck at step 8 as I don't know how to "add JScript Panel to a new theme." I know basically nothing about how to configure fb2k, I've just used the default theme for years.
Thanks!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Ohdengoh on 2020-12-11 18:48:57
Hello, I've done some fiddling to make georgia look nice on my pc but when I ported my foobar installation to another computer the transport buttons broke, see attached image.

I figured it could have something to do with filepaths but I wasn't able to find where the actual transport icons are stored. Instead, in the code in gerogia-main.js the button icons are retrieved from a struct g_guifx which in turn is defined on line 362 in Common.js:
Code: [Select]
var g_guifx = {
    name:          'Guifx v2 Transports',
    play:          1,
    pause:         2,
    stop:          3,
    record:        4,
    rewind:        5,
    fast_forward:  6,
    previous:      7,
    next:          8,
    replay:        9,
    refresh:       0,
(...)
So this explains why the buttons look as they do. I'm assuming that somewhere else in the code the contents of g_guifx are modified with the actual button icons but I wasn't able to find it. Any help with fixing this would be much appreciated.

And yes, I'm aware that I can probably fix this by updating and reinstalling but, as mentioned, I've done some tweaks to the code and am loathe to have to redo them.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-12-12 00:22:16
The transport icons are obtained from the Guifx font.  You need to have this font (Guifx v2 Transports.ttf) installed on your new computer.  It can be found in the Fonts folder under the Georgia folder.  You may need to install the other fonts in this folder as well.  Hopefully this will solve your problem.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: juanix21 on 2020-12-31 17:52:23
I installed Georgia but I cannot make flags and record label appear, in the verification window it appears as correct

(https://ibb.co/9VwnzR7)

any help?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2020-12-31 21:46:38
Hi.  Be sure you have "Show artist country flags" turned on in the options menu.  You also need to add an ARTISTCOUNTRY field for the flags and a PUBLISHER field for the record label to the Properties menu for your albums or tracks if they don't already exist..  LABEL should also work for the record label.  And these fields need to be populated with valid values recognized by Georgia.  You will find these in the flags and recordlabel folders under the images folder in Foobar's profile folder.  Hopefully, this will solve your issues.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: juanix21 on 2021-01-03 04:43:51
Hi.  Be sure you have "Show artist country flags" turned on in the options menu.  You also need to add an ARTISTCOUNTRY field for the flags and a PUBLISHER field for the record label to the Properties menu for your albums or tracks if they don't already exist..  LABEL should also work for the record label.  And these fields need to be populated with valid values recognized by Georgia.  You will find these in the flags and recordlabel folders under the images folder in Foobar's profile folder.  Hopefully, this will solve your issues.
Thank you, I will review your observations, I have activated the option to show flags, I don't know very well how to see the tag information of the songs.

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2021-01-03 07:40:33
To access album or track properties, right click on the item in a library viewer, such as Album List, and select Properties at the bottom of the drop down menu.  You will see all the fields currently available for that item under  the first tab, Metadata.  If not already present, you will need to add new fields for ARTISTCOUNTRY and PUBLISHER.  There is a "+ add new" button at the bottom you can try, but I've never used it.  I added my fields by selecting Advanced at the bottom of the Preferences menu and adding them under Display/Properties dialog/Standard fields:  ARTISTCOUNTRY=ARTISTCOUNTRY;PUBLISHER=PUBLISHER;.  I've attached examples below.

X

X


Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-01-05 19:36:42
Hey guys, just wanted to give everybody a quick update. I had surgery on New Year's Eve, and things have definitely improved, although I'm still on a lot of painkillers and the recovery isn't complete yet.
 
I've got a tiny bit of testing to do but expect a beta of the new release coming shortly.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-01-07 03:51:04
Just published the first spider_monkey beta (https://github.com/kbuffington/Georgia/releases/tag/2.0.0-beta1). If you're able/willing, please give it a look. Once 2.0.0 goes official there will be no more jscript versions released.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2021-01-07 04:34:42
Perhaps it should come with 2 colour schemes... red or blue.  ;D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-01-07 04:50:11
Perhaps it should come with 2 colour schemes... red or blue.  ;D
It actually comes with several, they're just all disabled other than the current default blue one. I have plans to make that configurable as well  :D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2021-01-07 08:06:38
Hi.  So far so good.  I've been using your SM version since it came out in September and the only issue I had was with the track info not updating for streams.  Thank you for fixing that.  It works great now.  I have seen something odd, though.  The View menu doesn't display all the available options and it's not consistent.  Sometimes it only displays about a third of them, sometimes about 2 thirds and sometimes all but the last 2 or 3.  I got around it by adding a button for the Popup Main Menu which works fine, but it is kind of puzzling.  I'm not sure when it started happening.  It could have even happened under Jscript and I just didn't notice it until I recently added a component whose options are next to the last item.  Thank you again for all your hard work.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2021-01-07 09:47:16
re; menu problem, it might be the 200 defined on this line of code is not enough for all commands.

https://github.com/kbuffington/Georgia/blob/f25e4432017775f1c11b25d7624ddfe801d60ba9/js/helpers.js#L416

I always used 1000 in my samples because I remember a component named foo_softplaylists that generated silly amounts of items "back in the day".
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2021-01-07 13:53:28
Thank you snotlicker, that was it.  I bumped it up to 500 and it works fine now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-01-11 03:26:03
re; menu problem, it might be the 200 defined on this line of code is not enough for all commands.

https://github.com/kbuffington/Georgia/blob/f25e4432017775f1c11b25d7624ddfe801d60ba9/js/helpers.js#L416

I always used 1000 in my samples because I remember a component named foo_softplaylists that generated silly amounts of items "back in the day".
Damn you're good. Fix will be in the next release. Looks like we might be able to get through beta quickly though. Very few issues so far.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Drawshot on 2021-01-24 20:42:51
I started using Georgia a couple weeks ago, and have really been liking it.  However, is it possible to make it display the full date in the playlist instead of just the year?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-01-26 05:52:22
I started using Georgia a couple weeks ago, and have really been liking it.  However, is it possible to make it display the full date in the playlist instead of just the year?
There'll be a new option added in the playlist settings in the next beta.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: codeAEON on 2021-01-27 17:17:18
I'm not sure if it's just me but when I add a song to the playback queue, the playlist view doesn't show a [1] or [number] indicating which position the song is in queue. It does add the song to queue though. It was working before the update to spidermonkey panel.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: newbe on 2021-01-28 12:04:16
I'm not sure if it's just me but when I add a song to the playback queue, the playlist view doesn't show a [1] or [number] indicating which position the song is in queue. It does add the song to queue though. It was working before the update to spidermonkey panel.

This was a bug in foobar 1.6.3 Final, in the latest beta 1.6.4 it's fixed:
- Fixed playback queue display glitch regression from 1.6.3 final.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: codeAEON on 2021-01-28 20:02:45
I'm not sure if it's just me but when I add a song to the playback queue, the playlist view doesn't show a [1] or [number] indicating which position the song is in queue. It does add the song to queue though. It was working before the update to spidermonkey panel.

This was a bug in foobar 1.6.3 Final, in the latest beta 1.6.4 it's fixed:
- Fixed playback queue display glitch regression from 1.6.3 final.

Thanks for the info! However, I just updated to 1.6.4 beta and it still does not show queue position. I can confirm the queue is working, just no visual indicator of what song is in queue and what position.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: newbe on 2021-01-28 21:12:56
I'm not sure if it's just me but when I add a song to the playback queue, the playlist view doesn't show a [1] or [number] indicating which position the song is in queue. It does add the song to queue though. It was working before the update to spidermonkey panel.

This was a bug in foobar 1.6.3 Final, in the latest beta 1.6.4 it's fixed:
- Fixed playback queue display glitch regression from 1.6.3 final.

Thanks for the info! However, I just updated to 1.6.4 beta and it still does not show queue position. I can confirm the queue is working, just no visual indicator of what song is in queue and what position.

It's working in the latest, not published version.
Download the master from github:
https://github.com/kbuffington/Georgia/archive/master.zip
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: codeAEON on 2021-01-29 03:51:06
I'm not sure if it's just me but when I add a song to the playback queue, the playlist view doesn't show a [1] or [number] indicating which position the song is in queue. It does add the song to queue though. It was working before the update to spidermonkey panel.

This was a bug in foobar 1.6.3 Final, in the latest beta 1.6.4 it's fixed:
- Fixed playback queue display glitch regression from 1.6.3 final.

Thanks for the info! However, I just updated to 1.6.4 beta and it still does not show queue position. I can confirm the queue is working, just no visual indicator of what song is in queue and what position.

It's working in the latest, not published version.
Download the master from github:
https://github.com/kbuffington/Georgia/archive/master.zip

Thank you very much.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: dwmartin0906 on 2021-01-30 19:12:04
Hi.  I've been checking out your changes as they have become available and haven't come across any issues so far.  The queue position indicator and UI Hacks changes seem to be working fine using your original code.  I did take a slightly different approach with UI Hacks when retrofitting my changes.  I positioned the caption buttons to the right of the other buttons and added a separate button for switching to full screen instead of using the ctrl key with the maximize button.  I included an image below just in case you might be interested.  I tried it with the buttons at the top right as you had them, but it just didn't look right to me.  Of course I don't have to try to please everyone, just myself. 

I was wondering if you knew why I have to double click the minimize button. I'd seen this before with my code and also found this to be true with yours.  No problem, just curious.  I also wanted to ask you about the various code doing different things with shadowing and tinting for the dark mode.  I ask because I replaced both the dark and light themes with several different color themes selectable by a popup menu and wasn't sure how to handle this code.  Everything seems to look fine as far as I can tell.

I hope you don't mind my mentioning this, but with all the time and effort you put into this theme, I just wanted to encourage anyone who appreciates it as much as I do to make a paypal donation using the button on your github page.  Thank you again for all the hard work you have put into this theme.

X
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2021-01-31 01:32:15
how do i use foo_ui_hacks?

nvm i think i got it. Preferences>Display>Main Window. just set it to No Border. looks nice
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: ACiDxCHRiST on 2021-01-31 01:40:12
MordredKLB, dude, you are killing it.

The v2.0 changes are great. The way function buttons display around the min/max/close buttons with foo_ui_hacks in beta3 is fine IMO and looks exactly the way I would expect it to.

I am having one issue but I am not sure if it is Georgia or foo_ui_hacks that is the problem. In "Preferences > Display > Main Window", I have Minimize on close set to "Enable" but every time i click the x in the upper right corner, foobar2000 exits. If someone else could reproduce the behavior, I will open an issue on GitHub. (Frame Style is set to "No Border")

-Edit
Also, I am having an issue seeing the playback queue. Maybe I am confused but where am I supposed to see the songs in the queue? It is not in the playlist window. Could someone who has it working correctly post a screenshot of what it is supposed to look like. I am on [foobar2000 v1.6.4 beta3] + [Georgia v2.0.0 beta3]
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2021-01-31 02:06:35
Does anybody know why my PUBLISHER (Label) tags don't work with $meta_sep(?
Anytime I have more than one label now it doesn't show the logos in the bottom right corner, it just thinks it's one label, even though I separate them with semicolons.

Code: [Select]
{ "label": "Label", "val": "[$meta_sep(PUBLISHER, • )]" }, // The label(s) or publisher(s) that released the album.
-from my georgia-config.jsonc file

Really stumped on this
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-02-04 04:10:07
Does anybody know why my PUBLISHER (Label) tags don't work with $meta_sep(?
Anytime I have more than one label now it doesn't show the logos in the bottom right corner, it just thinks it's one label, even though I separate them with semicolons.

Code: [Select]
{ "label": "Label", "val": "[$meta_sep(PUBLISHER, • )]" }, // The label(s) or publisher(s) that released the album.
-from my georgia-config.jsonc file

Really stumped on this
You're saying this stopped working recently? Are you positive that you've set PUBLISHER as a Multi-value field (check it in Preferences: Advanced =>Display => Properties dialog => Multivalue fields).

The line from the config you referenced is just for the entry in the meta grid on the left. The images are actually generated by calling $meta_sep on both LABEL and PUBLISHER fields (customizable by editing the tf.labels found in settings.js).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2021-02-04 06:35:06
You're saying this stopped working recently? Are you positive that you've set PUBLISHER as a Multi-value field (check it in Preferences: Advanced =>Display => Properties dialog => Multivalue fields).

The line from the config you referenced is just for the entry in the meta grid on the left. The images are actually generated by calling $meta_sep on both LABEL and PUBLISHER fields (customizable by editing the tf.labels found in settings.js).
Yep, that fixed it. It's been so long since I've had to go into settings.js, I completely forgot about it. I didn't know it generated an image for the bullet point, interesting how that works.

Thank you, the theme looks especially flawless now with the ui hacks.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: NateHigs on 2021-02-04 19:25:59
Link to Georgia.txt is broken, can't install.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2021-02-04 20:50:29
Link to Georgia.txt is broken, can't install.
Georgia.txt is included in the download package (only for JSP, for SMP georgia-install.js is included)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: NateHigs on 2021-02-05 07:43:20
Link to Georgia.txt is broken, can't install.
Georgia.txt is included in the download package (only for JSP, for SMP georgia-install.js is included)

How do I know that as a first time user? Also I have no idea what JSP and SMP are.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: kode54 on 2021-02-05 09:11:10
JScript Panel vs Spider Monkey Panel.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2021-02-05 14:15:04
There's also WSH - WSH Panel :D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2021-02-06 09:36:36
Link to Georgia.txt is broken, can't install.
Georgia.txt is included in the download package (only for JSP, for SMP georgia-install.js is included)

How do I know that as a first time user? Also I have no idea what JSP and SMP are.
@NateHigs: sorry for having been too short here. Are the other steps of the installation guide here (https://github.com/kbuffington/Georgia) from @MordredKLB clear? Please do not hesitate to ask futher questions!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: linuxlight on 2021-02-26 11:08:48
Georgia Theme is literally gorgeous, and thanks for all your hard works.
I'm trying to change fonts since my native language isn't English, and 'HelveticaNeueLT Pro' font doesn't look good when printing other languages.
I modified all stuffs in fontList in 'georgia-theme.js' and 'georgia-main.js' which are look like this.
Code: [Select]
//georgia-theme.js
    const fontLight = 'HelveticaNeueLT Pro 45 Lt';
    const fontBold = 'HelveticaNeueLT Pro 65 Md';
Code: [Select]
//georgia-main.js
    const fontThin = 'HelveticaNeueLT Pro 35 Th';
    const fontLight = 'HelveticaNeueLT Pro 45 Lt';
    const fontRegular = 'HelveticaNeueLT Pro 55 Roman';
    const fontBold = 'HelveticaNeueLT Pro 65 Md';
    const fontLightAlternate = 'NeueHaasGroteskDisp Pro XLt';
    const fontGuiFx = 'Guifx v2 Transports';

    var fontList = [fontThin, fontLight, fontRegular, fontBold, fontLightAlternate, fontGuiFx];
This worked with past versions, but doesn't work with v2.0.0-beta4.
It may be rude to modify your code since I'm an user, not a developer, but I will be happy using Georgia with my nice looking native language.
Can you help me with where to edit code to change theme fonts?
Thanks a lot!


Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-02-27 09:38:30
@linuxlight You can ignore georgia-theme.js for now. The font code in georgia-main.js hasn't been touched in 8-12 months at least. What doesn't work if you change, say, fontThin to a different font? Are you positive you've got the name right? Right click the otf/ttf font in Windows and select Preview and then usually the correct font name to use will be listed as Font Name up at the top. Sometimes it's not the correct way to address it though.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-01 09:09:32
Version 2.0 has finally been released. It's been pretty much all I've worked on for the last 8 months. Thanks to the amazing folks who helped me beta test, reported issues, and prodded me for features/improvements. It's really improved the quality of this theme.

I also spent a ton of time over the last week creating all new documentation (https://kbuffington.github.io/Georgia/), and writing up everything I could think of and taking tons of screenshots. I even recorded a new installation walkthrough (https://www.youtube.com/watch?v=i7B1mT4iTUw).

Get the new version here (https://github.com/kbuffington/Georgia/releases).

Changelog is too big to post, but it can be found here (https://kbuffington.github.io/Georgia/docs/changelog.html).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2021-03-01 11:32:25
@MordredKLB , you can fix the bugged search bar text colour in gh pages by changing `.search-input` variable - https://github.com/TheQwertiest/foo_spider_monkey_panel/blob/gh-pages/_sass/custom/colours.scss (colours.scss is included via custom.css)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-01 17:29:00
@MordredKLB , you can fix the bugged search bar text colour in gh pages by changing `.search-input` variable - https://github.com/TheQwertiest/foo_spider_monkey_panel/blob/gh-pages/_sass/custom/colours.scss (colours.scss is included via custom.css)
Somehow I hadn't even noticed. Thanks for the tip!

Also, thanks for showing me that gh-pages could have a decent looking documentation format besides the mostly terrible defaults!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2021-03-02 00:10:34
Thank you very much for the new version of Georgia! However it keeps showing up an error from spider monkey panel and foobar crashes (I'm using latest version 1.6.4):

Error: Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred)
DrawString failed:
GdiPlus error: DrawString failed with error (0xb): ValueOverflow

File: georgia-main.js
Line: 408, Column: 8
Stack trace:
  draw_ui@georgia-main.js:408:8
  on_paint@georgia-main.js:949:2
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-02 00:16:25
Thank you very much for the new version of Georgia! However it keeps showing up an error from spider monkey panel and foobar crashes (I'm using latest version 1.6.4):
Before line 408 can you paste this line:
Code: [Select]
console.log('>>>>', infoLeft, geo.top_bg_h - trackInfoHeight - scaleForDisplay(15), maxInfoWidth, trackInfoHeight);
Open the console, and then get it to crash again, and then paste the contents of that line to me.

Also when encountering the crash do you have cdArt?
albumArt?
Have you edited settings.extraTrackInfo at all?

In the mean time you can just comment out the gr.DrawString line on 408 to skip the crash while I try and figure out what's going wrong.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2021-03-02 00:31:24
I have vinylArt and the crash happens when skipping songs. I didn't edit nothing on settings.extraTrackInfo.

How do I edit georgia-main.js to be able to paste that line?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-02 00:48:43
I have vinylArt and the crash happens when skipping songs. I didn't edit nothing on settings.extraTrackInfo.

How do I edit georgia-main.js to be able to paste that line?
Just replace it with the attached file.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2021-03-02 00:58:10
Ok, I've replaced it and now it gives this error:

Error: Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred)
DrawString failed:
GdiPlus error: DrawString failed with error (0xb): ValueOverflow

File: georgia-main.js
Line: 409, Column: 8
Stack trace:
  draw_ui@georgia-main.js:409:8
  on_paint@georgia-main.js:950:2
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-02 01:16:51
Yeah, sorry, I didn't disable the crash in that file. Can you paste the contents of the console? (I just need the line that starts with ">>>>")
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2021-03-02 01:22:35
Ok, here it is:

>>>> NaN 123.46200180053711 NaN 21.53799819946289

This line comes just before the error, when is fetching new art.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-02 02:52:27
Well that explains it, but I still can't figure out how it's getting in that state. Can you try this one and paste the same line from the console afterwards?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2021-03-02 08:16:15
With the new georgia-main.js the line is now:

>>>> 1918 20 516 NaN - flac | -4.38dB

One thing I noticed is that the error happens almost immediately in shuffle tracks or random mode, but if I play them in default mode, it takes many more time (several album covers changes) for it to occur.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-02 16:40:31
With the new georgia-main.js the line is now:

>>>> 1918 20 516 NaN - flac | -4.38dB

One thing I noticed is that the error happens almost immediately in shuffle tracks or random mode, but if I play them in default mode, it takes many more time (several album covers changes) for it to occur.
Fixed! I was able to reproduce and squashed it. Seems to have been a race condition that occurred when switching from an album that had disc art to one without. Didn't happen all the time but should be good now.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: souomaior on 2021-03-02 23:05:48
It's working perfectly now! Thank you very much for your help.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: innocentciv on 2021-03-08 12:21:05
Just a heads up, the png artist logo for Tame Impala caused georgia to crash for me.
Not sure if it's something on my end but I fixed it by deleting the (corrupted?) png file.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-09 03:18:50
Just a heads up, the png artist logo for Tame Impala caused georgia to crash for me.
Not sure if it's something on my end but I fixed it by deleting the (corrupted?) png file.
Weird, same thing happened to me. Created a new one which will be in the next image pack update.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: armourine on 2021-03-09 11:31:06
Hello Mordred, thanks for the new release of Georgia. I'm getting crashes with v2.0.1 and fed with this error:

Error: Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred)
DrawLine failed:
GdiPlus error: DrawLine failed with error (0xb): ValueOverflow

File: ui-components.js
Line: 219, Column: 24
Stack trace:
  draw@ui-components.js:219:24
  draw_ui@georgia-main.js:556:18
  on_paint@georgia-main.js:949:2

This crash happens when I click on the show/hide playlist on many of my tracks. Hope you would be able to help me out.
Thanks again!




Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-09 18:30:09
File: ui-components.js
Line: 219, Column: 24
Stack trace:
  draw@ui-components.js:219:24
  draw_ui@georgia-main.js:556:18
  on_paint@georgia-main.js:949:2

This crash happens when I click on the show/hide playlist on many of my tracks. Hope you would be able to help me out.
Thanks again!
This looks like it's going to be specific to your library (and probably will always happen on the same songs for you) so I'll need some help debugging. Can paste this line into ui-components.js, directly before the gr.DrawLine currently on 219.
Code: [Select]
					console.log(`>>> x: ${x}, y: ${this.y}, h: ${this.h}, col: ${this.playCol}`);
Then replicate the crash with the console open, and paste just the last output of that line (there will be a bunch!) before the crash occurs.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: armourine on 2021-03-10 03:51:57
Hello, I did as you said, this is what i got

Code: [Select]
Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred): initialized in 1 ms
in on_init()
in on_size() => width: 2560, height: 1104
Playlist initialized in 93ms
Fetching new art
on_metadb_changed()
lastfm: []
foobar: [1833029933771000, 1603800926000, 1605000650000, 1605006123000, 1605024247000, 1605604803000, 1605959717000, 1606415664000, 1608378028000, 1613116067000, 1613668340000, 1615289295000, 1615290057000]
Georgia loaded in 464ms
>>> x: -15915, y: 175, h: 18, col: 1275068415
>>> x: -20629, y: 175, h: 18, col: 1275068415
>>> x: -21724, y: 175, h: 18, col: 1275068415
>>> x: -22577, y: 175, h: 18, col: 1275068415
>>> x: -23971, y: 175, h: 18, col: 1275068415
>>> x: -24015, y: 175, h: 18, col: 1275068415
>>> x: -24028, y: 175, h: 18, col: 1275068415
>>> x: -3206, y: 175, h: 18, col: 1275068415
>>> x: -26910, y: 175, h: 18, col: 1275068415
>>> x: -4533, y: 175, h: 18, col: 1275068415
>>> x: 688, y: 175, h: 18, col: 1275068415
>>> x: 690, y: 175, h: 18, col: 1275068415
>>> x: 4399524046, y: 175, h: 18, col: 1275068415
foo_spider_monkey_panel:
Error: Spider Monkey Panel v1.4.1 (Georgia: Georgia v2.0.0 by Mordred)
DrawLine failed:
GdiPlus error: DrawLine failed with error (0xb): ValueOverflow

File: ui-components.js
Line: 220, Column: 24
Stack trace:
  draw@ui-components.js:220:24
  draw_ui@georgia-main.js:556:18
  on_paint@georgia-main.js:949:2

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-10 06:20:15
Thanks so much! Here's the issue:
foobar: [1833029933771000, 1603800926000,

>>> x: 688, y: 175, h: 18, col: 1275068415
>>> x: 690, y: 175, h: 18, col: 1275068415
>>> x: 4399524046, y: 175, h: 18, col: 1275068415
That 1833029933771000 timestamp = Sun May 28 60056 00:36:11 GMT-0500 (Central Daylight Time). Presumably you did not change your system time to be 58k years in the future, so the file is corrupted or there's a bug in the foo_enhanced_playcount component.

For now you can do 1 of 2 things: uninstall foo_enhanced_playcount, or more simply, just change the following line in ui-components.js:
Code: [Select]
if (!isNaN(x)) {
to
Code: [Select]
if (!isNaN(x) && x <= this.w) {
That should completely prevent the crash. I'll send you a PM about the foo_enhanced_playcount issue because currently there's no way to reset the foobar plays that it knows about.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: armourine on 2021-03-10 07:26:36
Replied to your PM, thanks again!

Also want to add that I am Japanese and my PC is using the Japanese locale, I'm not sure if that has any issues with the system time because I have encountered some programs that didn't work well with Japanese system time as well.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: kode54 on 2021-03-10 08:10:41
Could be that playcount stores play times in a different timestamp format now?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-10 09:08:27
Could be that playcount stores play times in a different timestamp format now?
foo_playcount_enhanced has always stored the full, down-to-the-nanosecond timestamp that foobar uses internally. What are you saying is different now?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: linuxlight on 2021-03-12 12:32:25
@linuxlight You can ignore georgia-theme.js for now. The font code in georgia-main.js hasn't been touched in 8-12 months at least. What doesn't work if you change, say, fontThin to a different font? Are you positive you've got the name right? Right click the otf/ttf font in Windows and select Preview and then usually the correct font name to use will be listed as Font Name up at the top. Sometimes it's not the correct way to address it though.

Finally I found what I've missed, the problem was that I passed 'Non-English' font name to the Spider Monkey Panel!
It seems that Spider Monkey Panel decodes javascript file as US-ASCII charset, so SMP couldn't understand my 'Non-English' font name.
Using
Code: [Select]
fc-list | grep
in MacOS, I found all my fonts name in English and all problems has been solved. ;)

Thanks for all your consideration for Georgia-Theme fans, and as always thanks for your wonderful masterpiece! O:)  O:)
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-12 21:35:02
Glad you got it resolved!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: TheQwertiest on 2021-03-13 11:24:54
It seems that Spider Monkey Panel decodes javascript file as US-ASCII charset
PS: If you save your script file with UTF8 BOM, SMP will correctly use UTF8 to decode it.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: linuxlight on 2021-03-14 14:36:36
It seems that Spider Monkey Panel decodes javascript file as US-ASCII charset
PS: If you save your script file with UTF8 BOM, SMP will correctly use UTF8 to decode it.

Actually, I did a little bit of search about setting script file with UTF-8 BOM, but couldn't figure out how to save script file into UTF-8.  :))  :))
I struggled with my Windows Notepad's "save as..." feature to change script file charset, but couldn't resolve my problem.  :-[
Maybe in the near future I should try UTF-8 BOM once more! Thanks for noticing me a good tip.  :)

PS : I love SMP! Making Spider Monkey into foobar2k panel made fb2k even better, thanks!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2021-03-20 05:48:09
As I am using Georgia regularly with youtube or soundcloud playlists: I am experiencing that since Georgia 2.0.0 the artwork assigned to a youtube or soundcloud link is not in all cases updated when track is changing ('Cycle through all artwork' has to switched on in all cases for yt artwork):
- Artwork is updated as intended when track is changed manually by 'Next'.
- Artwork remains with previous track if track is changed automatically at the end of the previous track.
I think even with the SMP beta versions 2.0.0-bx the update of yt artwork still worked as well for automatic track change (sorry, didn't test), limitation seems to be introduced with 2.0.0

Just found by chance a workaround to get back to intended behaviour:
1. Switch off 'Cycle through all artwork'
2. do a manual track change
3. Switch on 'Cycle through all artwork'
So - don't bother, it's a great theme!!

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-20 17:02:46
That's a bug :) Pushed a fix just now and it'll be available in 2.0.2.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2021-03-20 19:13:25
Great, thanks for the upcoming fix!!
Do you prefer opening an issue at GitHub vs reporting here at HA?
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-21 01:41:12
Do you prefer opening an issue at GitHub vs reporting here at HA?
If it's a support question, then here is best. If it's a bug or you think something isn't working right, github ticket is the easiest way to make sure I don't forget about it.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2021-03-21 23:40:13
Everything's working pretty well, I'm surprised how far you've come along with this theme! It's all I use.

I'm not sure how to get the lyrics to work though. I downloaded the Lyrics show component because I wanted the words for a Johnny Cash song I'm trying to learn for a cover. So I did a search through the component (right click>Download lyrics) and it said "nothing found." I thought no big deal, I'll just copy and paste them from Google into the file itself, so I right clicked on the track in playlist view > properties > added a metadata field called "lyrics" and pasted the lyrics. Georgia still will not display the lyrics, it says "No lyrics found" no matter how many times I refresh and restart. What could I be doing wrong? My jsonc file definitely has %lyrics% under title format strings.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Azemoth on 2021-03-27 23:51:16
Thanks for your amazing work @MordredKLB!  :)

I'm using Georgia v2.0.2 and everything is perfectly, I have just one question, the option "Refresh" in the Library has been disabled? now I can only see the option "View by folder structure"

Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2021-03-28 06:22:54
That's a bug :) Pushed a fix just now and it'll be available in 2.0.2.
Solved, thanks! And CD art spinning is great!
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-03-28 22:40:03
Thanks for your amazing work @MordredKLB!  :)

I'm using Georgia v2.0.2 and everything is perfectly, I have just one question, the option "Refresh" in the Library has been disabled? now I can only see the option "View by folder structure"
So does Refresh do anything other than reload the Library? I thought it was refreshing the theme (as the other options were Configure and Panel Properties which I didn't want people messing with) so I just removed the whole thing. I can't really figure out what the point of Refresh is though.

If the idea is to refresh the Library because it doesn't notice songs that were added to the Media Library after starting, it seems like it'd be easier to just watch the events and auto-refresh. Let me know if that's what you're using it for and I'll try and make that change, otherwise I can just add Refresh back in.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Azemoth on 2021-03-29 00:10:44
Thanks for your amazing work @MordredKLB!  :)

I'm using Georgia v2.0.2 and everything is perfectly, I have just one question, the option "Refresh" in the Library has been disabled? now I can only see the option "View by folder structure"
So does Refresh do anything other than reload the Library? I thought it was refreshing the theme (as the other options were Configure and Panel Properties which I didn't want people messing with) so I just removed the whole thing. I can't really figure out what the point of Refresh is though.

If the idea is to refresh the Library because it doesn't notice songs that were added to the Media Library after starting, it seems like it'd be easier to just watch the events and auto-refresh. Let me know if that's what you're using it for and I'll try and make that change, otherwise I can just add Refresh back in.
Yes, I used "Refresh" to reload the library when I added new albums/songs, because sometimes songs/albums were not displayed after adding them.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: samsara7 on 2021-04-04 14:15:41
Yes, I used "Refresh" to reload the library when I added new albums/songs, because sometimes songs/albums were not displayed after adding them.
I just click "View by folder structure" and it's the same as hitting refresh. The same should apply for if you view by artist or whatever.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-04-05 21:14:22
I added refresh back in, but I also attempted to remove the need for Refresh, and now the Library watches for changes and updates accordingly, although I still need to do some more tests.

That said, don't download master at the moment. I'm in the middle of redoing the Library code and bringing it more up to date than the version I've got, and this has caused tons of new issues/crashes/bugs. On the plus side, I think I probably won't need to revert everything, but it's definitely not ready for primetime at the moment.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Arylcyclohexylamine on 2021-04-10 05:11:48
Hello, I really love your theme and have been using it for a couple years now. I'm trying to upgrade to the newest version from v1.1.6. I replace everything in my Georgia folder with the update but get a crash immediately upon opening foobar. The error says:

JScript Panel v2.2.2.4 (Georgia by Mordred)
JavaScript compilation error:
Syntax error
File: C:\Users\CRE\AppData\Roaming\foobar2000\georgia\js\helpers.js
Line: 2, Col: 1
const lodash = _.noConflict();

Thank you for any help
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MojoBass on 2021-04-10 07:29:56
Since Georgia 2.0.0 the Spider Monkey Panel (https://github.com/TheQwertiest/foo_spider_monkey_panel) is required instead of the JScript Panel.
See the detailed Georgia installation instructions here (https://kbuffington.github.io/Georgia/docs/installation.html).
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-05-22 22:25:29
Version 2.0.3 released (https://github.com/kbuffington/Georgia/releases/tag/2.0.3).

Also added a video to explain some of the new cdArt options/settings:
https://www.youtube.com/watch?v=_jplUBlRNos
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Arado on 2021-06-06 18:14:57
 How to only use the embedded album art ? I try the cdArt setting to but cant seem to work. My folder usually contain many images, I dont want to delete all of them.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Arado on 2021-06-07 17:14:40
 Nevermind, found the setting in .json file.

 Sorry for double post cuz I cant delete it  :'(
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-06-07 17:55:35
All good. I'm working on something that will hopefully improve the discoverability of some of these settings/features, but we'll see if it makes it off the ground.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Arado on 2021-06-08 17:07:43
All good. I'm working on something that will hopefully improve the discoverability of some of these settings/features, but we'll see if it makes it off the ground.

@MordredKLB Can I change the upper font to look like the one at lower side ? The upper one is not looking good in my language.

X
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: MordredKLB on 2021-06-08 18:09:49
@MordredKLB Can I change the upper font to look like the one at lower side ? The upper one is not looking good in my language.
If you look closely the bottom one also does not look correct. Those characters just aren't available in the font so it's falling back to a thicker font that does contain them.

Fortunately this can be changed fairly easily. First let's change lines 94-96 to a font that will hopefully work better than either:
Code: [Select]
	ft.title_lrg = font(fontLightAlternate, 34, 0);
ft.title_med = font(fontLightAlternate, 30, 0);
ft.title_sml = font(fontLightAlternate, 26, 0);

If that still doesn't improve things, change them to this which is the font currently being used on the bottom.
Code: [Select]
	ft.title_lrg = font(fontLight, 34, 0);
ft.title_med = font(fontLight, 30, 0);
ft.title_sml = font(fontLight, 26, 0);
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: Arado on 2021-06-09 05:56:24

If that still doesn't improve things, change them to this which is the font currently being used on the bottom.
Code: [Select]
	ft.title_lrg = font(fontLight, 34, 0);
ft.title_med = font(fontLight, 30, 0);
ft.title_sml = font(fontLight, 26, 0);


This solution work, not perfect but I'm happy as it is. Thanks you very much ;) .

PS: It's done so pls ignore my PM  :D
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: up the irons on 2021-08-31 11:48:07
Hello, this is my first post on this forum, so apologies if I am breaking any rule.

Is there any way to remove the big pause icon located at the center of the album cover? I don't want it to show while the song is paused, I want to see that artwork clearly during the pause.
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: marc2k3 on 2021-08-31 12:05:26
It doesn't look like it's optional so as a workaround for now, you can browse the Georgia folder and browse inside js and open ui-components.js in a text editor.

On line 21, there is a function that starts with

Code: [Select]
    draw(gr) {

Insert this as the first line after it...

Code: [Select]
return;
Title: Re: Georgia: A dynamically generated fb2k theme
Post by: up the irons on 2021-08-31 12:25:03
Thank you. Definitely needs to be added as an option.
SimplePortal 1.0.0 RC1 © 2008-2021