HydrogenAudio

Hosted Forums => foobar2000 => 3rd Party Plugins - (fb2k) => Topic started by: Curi0us_George on 2003-03-30 05:40:30

Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 05:40:30
I'm starting a thread so people can post ideas and suggestions for my database search plugin.

Plugin announcement here (http://www.hydrogenaudio.org/forums/index.php?act=ST&f=27&t=5209&st=50)

I do have a question, for anyone who's using the plugin.  How many options are you seeing in the drop-down list?  There should be 11, but I've gotten a PM (and a screenshot) from someone's who's only seeing "all" in the drop-down list.

Also, are you seeing the same number of options in the drop-down list in the config as the one on the search window?

edit:
foo_shizzle.0.4.zip (UNICODE version) (http://gelaed.com/resources/cplusplus/foo_shizzle.0.4.zip)

edit:
No more ANSI version for now.  It doesn't run on Windows 98, so there's no point.  I'll try to get that fixed soon.
Title: foo_shizzle
Post by: voltron on 2003-03-30 06:43:00
i see 10 + the all option = 11.
any plans on individual search strings for each word.
what about esc closing the window?


i like it, thank you.



(http://www.crappyhosting.com/voltron/image.png)


is this plugin the same as the one by foosion, or is it your own?
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 07:06:30
It's my own, from scratch. (Actually, I used foo_delete as a starting point) 

I'll add the escape button in the next release.  I forgot about it.
I might add the individual search strings later.  That'd require a new interface, though.  It might be too cluttered for everyday use.  I'll look into it.  I might also add a "specific search" option to the dialog box, which would expect input in the format "%meta-name% value %other-meta-name% other-value . . . ".  It wouldn't require so much clutter, but it wouldn't be as conventient, either.

I'm glad you like it.  I'm glad you're not experiencing the drop-list bug, too. 

Would you prefer that when one of the "send to playlist" options is chosen, it plays automatically (like the album search), or should it work as it does now (clear the list, add the entries, don't touch the playback)?
Title: foo_shizzle
Post by: anza on 2003-03-30 08:50:07
Ok, here's the screenshot of my version of foo_shizzle (great plugin, great name B) ):
(http://koti.mbnet.fi/antsau/db.jpg)
I've tried both, ansi and the unicode versions and both have the same issue.
As I told George in PM, I can scroll the menu, so it isn't _so_ bad thing, and I use the "all" almost 99% of the time.

George, I think it'd be better if it started playing when you pressed the "send to playlist".
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 08:58:53
I misunderstood the problem at first.  I thought you were only seeing the "all" option.  I'll see if I can figure out what's going on.  It's really bizarre though, because I'm using the same code to construct the box in the config menu as I am the box in the search dialog.  Hmm.

I will have it play when data is sent to the playlist if that's what you want.    It actually bugged me in the Album List, but that's because I only used the album list+playlist search to simulate database search.

I'll have version 0.5 up within a few days.
Title: foo_shizzle
Post by: anza on 2003-03-30 09:10:27
Quote
It's really bizarre though, because I'm using the same code to construct the box in the config menu as I am the box in the search dialog.

Well as I said (or with my english, tried to tell) that the config menu has the same problem 

Quote
I will have it play when data is sent to the playlist if that's what you want.    It actually bugged me in the Album List, but that's because I only used the album list+playlist search to simulate database search.

That bugged me also at first, but now I'm used to it and think it's great that it works like that
Maybe you could add an option for that also? If that was possible, I believe it'd make all us, who use the plugin, satisfied.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 09:26:06
Quote
Well as I said (or with my english, tried to tell) that the config menu has the same problem

With my crappy brain, I misunderstood.    I'm still trying to figure out what's going on.  Have you ever experienced that problem with anything else?  Also, what version of Windows are you running?  (2000 or XP?) And which language?

Quote
That bugged me also at first, but now I'm used to it and think it's great that it works like that
Maybe you could add an option for that also? If that was possible, I believe it'd make all us, who use the plugin, satisfied.

I already have.    The option will be in 0.5.  (Pawlowsky did a really good job with the configs.  It's nice and simple.)
Title: foo_shizzle
Post by: anza on 2003-03-30 09:47:48
I'm on an English Win2k+SP3. I can't remember if this issue has occured before, I think not.

Great that you bother to try to hunt the bug  I'd do it myself if I knew coding :/

EDIT:
Actually I got the plugin to work well now!  I remembered I had Resource Hacker and just made the menu a bit longer  Here's a screenshot to make it clearer

(http://koti.mbnet.fi/antsau/reshack.jpg)
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 10:22:45
Well, I'm glad that you got it to work.    I've got no idea why it wasn't working to start with, though.  I'm not setting the size at all.  I'm just adding the strings.  Windows is supposed to handle resizing it.
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-30 10:34:50
You and foosion are doing some great job here. Now here are my remarks :

-I do have only 1 option in the drop-down list. I can use the two little arrows on the right to get to the other options but that's all, and yes, I only have 1 in the preferences too. I'm using win2k SP3.

Quote
i just realised the (annoying) search logic. first it would only search one field so i changed "%artist%|%album%|%title%" to "%artist% - %album% - %title%" (i prefer the dashes than just a space)

ok that makes sense. but say artist is "123" and title is "blah (remix)". search for "123 remix" you wont get any results

It seems to treat the search as one string, playlist search doesn't behave like this, it will separate the strings at spaces.

Maybe this could be a option?


This is what musicmusic told about foosion's plug-in, and it also applies to yours. I guess searching like the playlist does is slower, but this could be an option.
Title: foo_shizzle
Post by: anza on 2003-03-30 10:43:17
George, yeah really a weird thing. But now it works and it's fine for me

BlueScreenJunky, so you have the same problem as I had? If you want, I can give you my edited version so you have all the options there. The thing musicmusic told about is "tokenizing" and it should be in some later version
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 10:46:04
Search string tokenization will arrive soon.  Hopefully it'll be included in 0.5.

I'm going to have to look into the drop-down list problem some more.  It's probably something that the compiler (VC++.NET) is doing.  It's not a bug in my code, I'm pretty sure.  (I've had my share of bugs already.  )
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-30 11:33:28
okay guys, thanx, I'm looking forward to your next releases George.

PS : "tokenization"... you live and learn 
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 12:58:09
Well, the latest "internal" version has tokenization.  Tokenization will definitely be in 0.5.

I fought with it for an hour and a half, finally got it to work, and then realized that the standard C library has the functionality to do that already.  :\  So I wiped out my tokenization code.

One thing needs to be added to the tokenization, though.  Right now I've got it matching "any words".  I should really have it searching "all words".  (Or maybe a toggle)  String tokenization can really bring it to its knees, though.  Pasting in "a b c d e f g h i j k l m o p q r s t u v w x y z" will cause it to take about three or four seconds for the search.  Typining it in is even worse, because it searches "a", "a ", "a b", "a b ", "a b c", etc.  I might add a toggle for that, too.  i.e. "search only on enter"

I'm going to have to add another config screen if it gets much bigger. 
Title: foo_shizzle
Post by: anza on 2003-03-30 13:10:08
Any way you could give us the internal version?  Sounds like it's going to be great!
Title: foo_shizzle
Post by: musicmusic on 2003-03-30 13:25:56
Nice! My only issues where the tokenization and the Search in.. thing only allows you to search one field (even in all)., but if I understood you correctly you'll be adding a search string like title formatting? That would be great then.
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-30 13:26:01
damn you're working fast ! I thought tokenization would keep you busy for some time 

when you're done with tokenization, how about binding a function to double click (enqueue, enqueue+play, or play), and maybe a right click menu with these 3 functions, go to directory, edit tags etc.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 13:26:34
Sure, if you really need your fix. 

http://gelaed.com/resources/cplusplus/foo_...nal.alpha.1.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.0.5.internal.alpha.1.zip)

Be forewarned, it's not complete.  I don't think it has any actual bugs (except that you'll probably still have the drop-list bug), but it's not fully finished.  There are options in the config that don't do anything (yet), and the tokenization is searching for "any words" rather than "all words".

I'm only putting up the UNICODE version, though.

Quote
damn you're working fast ! I thought tokenization would keep you busy for some time 

It did.    It was about an hour and a half of coding to get it to work.  (And then about 3 minutes to delete all my work once I realized that the standard C library comes with that functionality.)

Quote
when you're done with tokenization, how about binding a function to double click (enqueue, enqueue+play, or play), and maybe a right click menu with these 3 functions, go to directory, edit tags etc.

I've got the double-click to enqueue added to the internal version, along with escape to exit and play on "send to playlist".  I like the idea of the context menu.  I'm not sure if it'll be appearing anytime soon, though.  There's still a number of other things I want to add.
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-30 13:51:03
edit : forget that...
Quote
Right now I've got it matching "any words". I should really have it searching "all words".

I can't read
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 15:53:56
Freaky.  I just wrote a big chunk of code to add some new logic to my code.  Those different search options in the 0.5alpha1 config (standard, thrifty, and formatted) all work now.  I can't believe it.  The only error I had was a syntax error.  I've never written more a big chunk of code and had it work perfectly.  I'm waiting for the huge bug to jump out of nowhere, but it seems to be working. 

I still need to add "search for all" in addition to "search for any".

edit: Found two bugs. (Fixed one.  The other will be fixed shortly.) I feel better now. 
Title: foo_shizzle
Post by: foosion on 2003-03-30 16:46:11
I updated foo_dbsearch to fix some issues (tokenization, code cleanup and restructuring, ...).

I don't think I'm going to do further work on it, unless this is requested. I don't see the need for two competing database search plugins (waste of time of the developers), and Curi0us_George seems to do a good work with foo_shizzle. 

@Curi0us_George: You can use my tokenization function, if you like. I'm also going to have a look at foo_shizzle (running under Win98).
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 17:03:20
Well, yours is an excellent plugin.    I have it installed.  They aren't really "competing" plugins, because they work differently.  Yours searches a specific string (e.g. %artist|%title%), while mine searches all meta-data entries.  It's a different type of search.  The most recent "internal" 0.5 has a "preformatted search" mode which works similar to yours, but it's slower (for some reason).  Basically, though, mine's a heavier search.  It needs more memory.  Having a lighter search is definitely nice, though.  I've got no plans to uninstall your search plugin.  It duplicates the playlist search extremely well, which is the main thing that I wanted in a database search plugin.  (So I can stop using the albumlist to send add everything to the playlist and then search.)

I do have plans to change some of the text in mine, so it doesn't clash with your so much.  "Database Search..." and "Database search..." don't really belong next to each other in a menu.    I'll have to come up with something else.  I might just change mine to "Search Database...".

I appreciate the offer to let me use your tokenizing code.  Right now I'm just using the standard C strtok/wcstok function.  If I get around to adding that nifty tokenization escape character, though, I just might use your code. 

I hope you don't completely abandon yours.  I like it.  (I really like the separation of the search, display, and sort strings.)

P.S.  That second bug I found is fixed now. 
Title: foo_shizzle
Post by: foosion on 2003-03-30 17:15:33
Quote
Well, yours is an excellent plugin. 

Thanks.
Quote
It duplicates the playlist search extremely well, which is the main thing that I wanted in a database search plugin. 

Me too, that's why I won't improve on it much more (got different plugins to write, you know  ).

Quote
I do have plans to change some of the text in mine, so it doesn't clash with your so much.  "Database Search..." and "Database search..." don't really belong next to each other in a menu.    I'll have to come up with something else.  I might just change mine to "Search Database...".

Yeah, this would be nice. What about "Investigate database..." because it has more search options B) (as far as I know from the screenshots and discussion here).
Quote
I hope you don't completely abandon yours.  I like it.  (I really like the separation of the search, display, and sort strings.)

Cool, now I don't have to ask, if anyone uses this (the seperation)  .

EDIT: I was not going to abandon it, I just won't add much more features.
If anyone has suggestions for better labels in the configuration dialog, just post away. It's not that I don't know English, but my thoughts seem to be quite complicated at times.
Title: foo_shizzle
Post by: anza on 2003-03-30 19:37:13
Damn these both plugins are so great
George: the drop-down list is still fucked up, but it's not a big deal. The tokenization should (IMHO) search for "all words", maybe we should have one more selection in the configuration "search all words", if unchecked it searches any words?

Maybe you two, foosion and george should merge your plugins if possible?  I have found that foosion's one searches faster and has a couple of better parts (it searches for all words and the configurable sorting string), but then George's one has also many great features, it's impossible to decide which one to use
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-30 19:44:05
Tokenization will be "search all" in the 0.5 (or else there'll be an option).

Mine should actually be faster than fooshion's when tokenization is turned off.  (Though fooshions actually seems to be faster with tokenization than it was without.)  I guess it depends on how you're searching, though.  The "standard search" in 0.5 is quite fast, though.  (0.5 alpha 1 is using thrifty search)

I need to find out if there's a method call I can use to resize that drop-down list.  There's no option that I can find in the dialog editor to set that.  (And I don't know of a method call to do it, either.)
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 13:00:37
I've uploaded a new version:
http://gelaed.com/resources/cplusplus/foo_...nal.alpha.3.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.0.5.internal.alpha.3.zip)

I'd appreciate it if you guys could try it and let me know if the drop-down bug is still there.  I changed a few things, but since I don't know why its happening (on just Win2000 SP3?), I don't really know how to fix it.  Give it a try, though. 

That file contains both the ANSI and the UNICODE versions.  I think the ANSI version is working for Windows 98/ME now, but I'm not certain.  I know it's apparently having some problems with extended characters (e.g. ü,Ü) on Windows 98.  I'm looking into fixing that.

If you're wondering why it suddenly got bigger, it's because I statically linked to the C runtimes, because Windows 98 (and ME?) doesn't come with msvcr70.dll.  The other option is to bundle it, but I think it's probably simpler just to statically link, so it doesn't need the DLL.  As for why the ANSI version is so much larger (more than double size, actually), ask Microsoft.  :\  I don't really need to link statically in the UNICODE version, but since it doesn't seem to affect the size very much, I don't really see a reason not to.
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-31 15:02:43
Yup, the drop down menu is working now, congratulations ! but it displays 10 items instead of 11, so you have to scroll to see "track number". It doesn't bother me at all, but I think there should be 11.

and I was wondering : what's the difference between Standard and Thrifty (btw I think you misspelt it in the preferences) search ? also I guess the formatted search should enable you to use your own search string but I can't figure out how it works...

that's all, keep up the good work 
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 15:53:36
Well, I found a place to stretch out the drop-down menu size.  It shouldn't actually affect anything, because the "No Integral Height" (which tells windows not to resize the drop-down list) style isn't enabled, but apparently Windows 2000 (and possibly just SP3) doesn't like that.  I'll stretch it out a bit more when I release the next version, and maybe that'll fix it completely. 

From the changelog (it'll be included in the final release):
Quote
Added:   New search logic.  There are now 3 search options: standard, thrifty,
  and preformatted.
  Standard is the fastest.  It also uses more memory.
  Thrify saves memory at the expense of speed.
  Preformatted uses the same amount of memory as thrifty, but improves
  speed by only comparing the preformatted display names.
  i.e. if your display string is %artist% - %title%, preformatted search
  will only search in that exact string.
  Note, though that the "search in" box is useless (and in fact disabled)
  when preformatted search is selected.


Basically:
Standard keeps all database info in memory for faster searches.  This avoids all database communication.
Thrifty keeps only a list of the files in memory.  This avoids some database communication.
Preformatted search uses the display string.  This also avoids all database communication, but it's far more limited.

Of course, no matter which mode you're in, there'll be communication with the database when you load the search screen for the first time, and whenever you add/delete/move/modify a file entry in the database.

There are some bugs in alpha 3, though. (search filename with thrifty search and you probably won't get any results)

P.S.  Yes, I misspelled "thrifty".  I'll get it fixed before 0.5 final is released.    You should see some of the variable names.  When I first added "preformatted", I spelled it "prefomatted".  I've got it in so many places that I'm not even bothering to try to fix it.  Today I added some new "prefomatted" handling code. 
Title: foo_shizzle
Post by: anza on 2003-03-31 18:26:28
Hey, looking VERY good. The drop-down list works now, but as BlueScreenJunky said, you have to scroll down to the "Track Number", but if you're correcting this, no problem then
I've found that thrifty search is actually faster than standard, for me at least, and that's a great thing if it uses less memory  Nice work here! Could you maybe add same kind of display and sorting formatting strings as foosion's one has?
Title: foo_shizzle
Post by: foosion on 2003-03-31 18:33:26
Short version:

You broke it. No, this would mean it was working before.  (No offense intended.)

Now comes the long version:
I just tried out the new ANSI version on Win98, and really tested it instead of just typing in some umlauts, which I feared would be broken. When I typed "fire" in the "Search for" box, the following number of results where found (after each character typed): 0 - 10 - 2 - 2.  I cleared the input and typed it in again: 0 - 2 - 2 - 2. This is also the result of all further tries. Different settings did not affect the outcome.
Then I tried out version 0.4 again. The result was the same.

Just for comparison: Doing the same with foo_dbsearch gave me: 216 - 10 - 2 - 2.

Fixing this isn't urgent (for me), as I'm quite content with foo_dbsearch. Perhaps it's also some secret "feature", because 216=6*6*6 

Oh yeah, and no drop-down bug here either.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 18:34:02
That's rather bizarre that it's faster on thrifty search, but I guess that's good for you.  On my system, I find that it's just a tiny bit slower than standard search.  Right now, I'm using thrifty search.  Standard search isn't really worth the extra 2 megs of memory.

My settings:
display format: %artist% - ['['[%album% ] [#[%disc%/]$num(%tracknumber%,2)]']'] %title%
"search all"
display empty results list when search string is empty is OFF
auto-update results is OFF
default search: artist
search filename when searching all is ON
play on send to playlist is ON
thrifty search

Of course, I completely stole that formatting string from fooshion's plugin. 

I'll be uploading 0.5 final momentarily. 
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 18:45:48
change log:
Quote
[0.5]
Fixed:   a search bug.
Fixed:   Searching for arbitrary meta-data now works properly.
  i.e. searching in "snorf" is now as valid as searching in "title".
Fixed:   Changing the config string now works.  Close the config window or click
  on a different component's config to apply.
Added:   close on escape
Added:   add to playlist on double-click
Added:   play on "send to playlist"
Added:   search string tokenization ("any word", instead of "exact match")
Added:   better cleanup on exit
Added:   New search logic.  There are now 3 search options: standard, thrify,
  and preformatted.
  Standard is the fastest.  It also uses more memory.
  Thrify saves memory at the expense of speed.
  Preformatted uses the same amount of memory as thrifty, but improves
  speed by only comparing the preformatted display names.
  i.e. if your display string is %artist% - %title%, preformatted search
  will only search in that exact string.
  Note, though, that the "search in" box is useless (and in fact
  disabled) when preformatted search is selected.
Added:   bug in preferences
Fixed:   same bug in preferences
Added:   Database callback; changes to the database after the search
  window is first displayed are now reflected in the search.
  i.e. deleting/modifying/adding songs' meta-data will now affect
  the search results (after you search again, of course)
Fixed:   ANSI version now runs under Windows 98/ME (maybe) (many thanks to fooshion)
Added:   search string tokenization: "all words"
Added:   config option for tokenization
Added:   "Auto-update search results" toggle
Added:   "add to playlist on enter" when the results list has the focus
  (thanks fooshion)
Added:   "refresh on enter" when anything other than the results list has
  the focus (thanks fooshion)
Fixed:   "exact match" bug
Fixed:   a couple of filename search bugs
Fixed:   "Thrify Search" is now "Thrifty Search" (thanks BlueScreenJunky)
Fixed:   drop-down menu bug (thanks anza and BlueScreenJunky)
Added:   Search screen titlebar now includes type of search i.e. standard,
  thrifty, preformatted
Changed:
  Now named "Meta Search" to avoid confusion with foosion's plugin:
  "Database Search"
Added:   "search in" tokenization.  i.e. if "artist album" is entered in the
  "search in" combo-box and "foo" is entered in the "search for" edit
  box, Meta Search will find all songs with "foo" in the artist field
  or the album field.
Fixed:   The "search in" combobox is no longer highlighted when the search
  window loads.  Finally.


http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)
ansi link removed

I'm not sure if that ANSI version will work on Windows 98 or not, but you can give it a try. 

It's now named Meta Search.

anza, I'm not sure if I'm going to be adding separate search/display/sort strings or not.  It would take a bit of memory, because one of the things my app does is keep all the strings ready to display.  It saves a lot of processing time, at the expense of some memory.  I don't know if I want to keep all those search strings in memory.

I honestly don't understand how fooshions plugin is as fast as it is, since it doesn't keep those strings in memory.    Mine is faster on preformatted mode than his, for sure, but his is remarkably fast, considering all the processing it's doing.
Title: foo_shizzle
Post by: foosion on 2003-03-31 18:58:42
Quote
I'm not sure if that ANSI version will work on Windows 98 or not, but you can give it a try. 

Hm, nice config window, but the quirks mentioned above still persist... talk about strange behaviour.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:02:45
Darn.  I don't understand why it's breaking.  I obviously don't expect the ANSI version to work for Japanese characters, but I expect it to work for stardard characters. 

edit: I might try adding some code into the ansi version to record data, and see exactly what it's doing.  I don't know if it's getting the information in the wrong format from the edit box (extremely unlikely) or if it's somewhere in the conversion to the standard char from utf8 used during database communication.
Title: foo_shizzle
Post by: Jan S. on 2003-03-31 19:09:00
Could you make custom keys work so that fx. this search (http://qas.united.net.kg/metasearch.png) would work?
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:11:53
I'll look into that.  It should be working already.

edit:  I can't reproduce that bug.  It works correctly on my system.

http://gelaed.com/images/metasearch-band.gif (http://gelaed.com/images/metasearch-band.gif)

Obviously that's a contrived example, because I added the meta-data just so I could search for it, but it does work on my system.  I can assume that you are using Windows 2000/XP, right?
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:28:41
If you search for all (with search for filenames turned off), does it show up then?  Have you tried any other meta-data searches?  i.e. producer?  ("sound engineer" will definitely not work.  The plugin now breaks keys into tokens, so you can search in "artist album" and it will search for the search string in both.

P.S.  I noticed that you are using an early version of Foobar 0.6.  Is it possible that the database is a little borked?  I hate to insinuate that it's Peter's fault, but it works peachy keen on my system.
Title: foo_shizzle
Post by: anza on 2003-03-31 19:31:24
Ok now with the official release the thrifty search is noticably slower, but it doesn't matter.
And for me, the custom keys don't work either.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:32:44
Damn.  I don't know custom keys aren't working for you guys.

The thrifty search was probably faster because it had bugs.    It was skippin some stuff in the last alpha.
Title: foo_shizzle
Post by: anza on 2003-03-31 19:38:17
Ok now I can't understand this anymore! The plugin just broke down. It wont display any results anymore. It only says "0 found". If I use preformatted search, then it works, but otherwise it don't.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:42:01
Hmm.  Can you tell me what you did before it broke?  I'd like to get these bugs fixed.
Title: foo_shizzle
Post by: anza on 2003-03-31 19:44:02
The only thing I did was that I changed some of the options. Now after I installed the plugin again, it works well. Can't understand what happened.

EDIT: Ok, now I got it broken again  I disabled the "Auto-update search results" and it don't work anymore. Even if I enable it again it wont work. Hope this helps you hunt the bug

MORE INFO: The plugin brokes when disabling the auto-update, and if I want it to work again, I have to enable it and then restart foobar again. BUT, if I disable it and restart foobar, it still won't work. So it has something to do with the auto-updating.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:49:16
Well, you should never have to reinstall the plugin.  (In fact, if you delete the plugin, and copy it in again, absolutely nothing is changed.  foobar2000 actually stores the configs, so they the same.)  Restarting foobar should fix the plugin.

I'm going to look at some options and see if I can duplicate the bug.
Title: foo_shizzle
Post by: anza on 2003-03-31 19:51:43
Ok, but the restarting got it to work. I got just still more info. It seems that whatever I search, and whatever options I have, when I press ENTER, it brokes down!

I mean I have to press the enter on the search-box.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 19:51:44
Damn.  There's definitely a bug in there somewhere.  I just crashed foobar.

edit: This is really frustrating.  I don't know how I crashed foobar.  I can't duplicate that bug, and I cant duplicate the bugs you guys are having.
Title: foo_shizzle
Post by: anza on 2003-03-31 19:59:43
A crash here, too. Actually a few of them. Occur when searching, nothing special, they're just random crashed, I think. Of course I mean that there is a bug somewhere, but it doesn't seem like that it occurs everytime I do something specific.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 20:02:31
Well, the only crash I caused was when I was playing with the preferences.  I wasn't searching.  I haven't a clue what I did to make it crash, though.

Just out of curiosity, did you modify/delete/add any meta-data to any files before any of these crashes.  I wouldn't expect that the bug was there, but it's the least tested part of the plugin.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 20:04:42
Two more questions.
Did you have the search window open while you were modifying preferences? (and caused a crash)
Have you caused a crash without modifying the preferences first?
Title: foo_shizzle
Post by: anza on 2003-03-31 20:06:10
Actually I didn't at first edit any meta-data, BUT after you said that, I added a comment line to one of my songs (having the search-window still open) and then I searched for the artist. And there it was. A crash.

EDIT: Actually I think I have had the search-window open nearly always I have changed some settings, so yes, it was open

PS. Now I have to go to sleep :/ I'll get in business later
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 20:19:14
Ok, I've made a couple of changes.  It now clears the search window every time the preferences are changed.  That might fix some of the bugs.  (It definitely eliminates some possible bugs.)

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

I'm still looking to see if there's anything I'm not seeing.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 20:36:12
Hotfix 0.5a.  I think it fixes the reported bugs.  I know it fixes some possible bugs.

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

(It turns out that the database monitoring wasn't working quite right.  It should now.)
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-31 20:45:14
I got it I got it ! I can "break" your plug in as much as I want 

If I uncheck the "auto-update" box, then type in something and press enter, it doesn't return any result.
After that if I recheck the "auto-update" box, I don't get any result, no matter what I do. I have to restart foobar and it works fine again. Doesn't bother me since I always use the auto-update feature, but that makes the option rather useless ;-)
(still using win2k SP3)
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 20:47:17
What are your other settings?

I can't seem to duplicate that problem.

P.S.  I uploaded a "new " 0.5a hotfix.  The other copy still has a debug note in it, so any time you modify, move, or delete an entry, it will pop up a messagebox with the word "Match" in it. 
Title: foo_shizzle
Post by: Jan S. on 2003-03-31 20:57:27
I still can't get custom keys to work: metasearch2 (http://qas.united.net.kg/metasearch2.png)
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-03-31 20:57:38
-search all
-Display empty result : Off
-Auto update : On then Off
-Default search : All
-Search Filename when searching "All" : On
-Standard search
-Play on "send to playlist" : On

Display formatting :
$if(%artist%,%artist%,'Unknown Artist') $if(%album%, - %album%,)  :  $if(%title%,%title%,%_filename%)

I'll try to play with it some more. BTW would it be hard to use all the string commands you can use in the playlist, like $char(9) colors etc. ? I mean do you have to do it yourself or can you just grab the one foobar uses ? because I use the database search more than the playlist itself, so it would be cool if it could look a little nicer.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 21:07:14
I think you guys are just making it up. 

Seriously, though.  I can't duplicate either of those problems. 

It's really hard to figure out bugs that you can't duplicate.

P.S.  No, I don't have to parse those strings myself, or you'd only get %meta-name% options.    However, I would have to mess with the colors myself, so you probably won't be seeing that any time soon.  (I also can't "automatically" do right-aligned numbers.)  I might add colored text in a future version, but that'll be quite a ways in the future, because I'd have to write a pretty big chunk of code to handle that.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 21:27:18
Jan, can you email me a copy of your database?  Or if you think it's too large, can you post a copy of it online, or send me your AIM name or something?  I'd like to see if I can duplicate the bug with your database.

Also, is that a German "Jan" or an American "Jan"? 
Title: foo_shizzle
Post by: Jan S. on 2003-03-31 21:45:20
You can grab my db (yes it is quite fucked and weird; a total mess) here: database.rar (http://qas.united.net.kg/database.rar) it actually quite small when compressed.

Quote
Also, is that a German "Jan" or an American "Jan"? smile.gif

More like an american "Jan" but with a short "a".
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 21:54:13
Search in "Band"
Search for "beatles"
164 found

  I was hoping this would shed some light on the bug.

(And damn.  That database really did compress a lot.)
Title: foo_shizzle
Post by: Jan S. on 2003-03-31 22:19:02
How do you get it to search?
I found that if I write "artist" (in  "Search in") fx. it doesn't search. I have to select it from the list.
Title: foo_shizzle
Post by: Curi0us_George on 2003-03-31 22:44:46
It works if I just type it in and hit enter.  (Actually, if auto-search is on, I don't even hit enter)
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 02:11:49
Uploaded 0.5b.  I hope it'll fix Jan's problem, but I don't really know.  It's apparently an unusual circumstance causing it to fail.  Windows doesn't always send messages quite the way it's supposed to.  (Or at least, it doesn't always behave in the expected manner for each message it sends.)  I already had some "bizarre occurence" code to fix a WinXP bug with that combo box.  Windows does really odd things with combo boxes, apparently.

Let me know if it works (or fails to work).

edit:  If you downloaded it before this edit was posted, download it again. 
Title: foo_shizzle
Post by: ExUser on 2003-04-01 03:03:26
Error message with latest version:
Quote
This application has failed to start because MSVCR70.dll was not found.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 03:26:50
http://www.dll-files.com/dllindex/dll-file...s.shtml?msvcr70 (http://www.dll-files.com/dllindex/dll-files.shtml?msvcr70)

Title: foo_shizzle
Post by: Jan S. on 2003-04-01 12:40:16
Without "auto update" enabled it doesn't search at all no matter what I do.
And I still have to select what to search in for it to do anything.
Actually I have to select what to search in as the last step.
If I select "all" and enter "beatles" nothing is found.
I have to select "all" again.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 12:56:57
Wierd.

I'll look into it some more.  I don't understand it at all.

Did the latest versino change anything at all?  For better or for worse?
Title: foo_shizzle
Post by: Jan S. on 2003-04-01 13:00:53
Quote
Wierd.

I'll look into it some more.  I don't understand it at all.

Did the latest versino change anything at all?  For better or for worse?

I'm quite sure I didn't have to select what to search in as last step before; though I still had to select from the list.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 14:36:19
That's significantly better than no change at all. 

I've uploaded 0.5c.  Let me know if that one works for you.

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)
Title: foo_shizzle
Post by: anza on 2003-04-01 19:28:37
Now if only you made a version that worked with 0.6beta
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 20:12:57
I have a version compiled that will work with 0.6beta, but I'm going to have to change some thing to make it work properly.  One of the classes I was using is completely worthless to me in 0.6.
Title: foo_shizzle
Post by: Jan S. on 2003-04-01 20:47:59
Still the same here; sorry :-/
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 20:52:26
I'm getting to the point where I hate Microsoft.    They apparently aren't standard between versions of Windows (even closely related ones i.e. 2000/XP).  I'll get around to playing with the code some more later.

Did the new version do anything different?  Did you still have to select the "search in" field last?
Title: foo_shizzle
Post by: Jan S. on 2003-04-01 21:00:29
Yes. I could find no difference between the two versions.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 21:12:54
I don't understand at all.  I'll try to hack at it some more later.  If I can't get it working, I guess I'll strip it down to a droplist with a "custom" option, and then add another edit box to enter the field(s) in.  But that's a really poor fix.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-01 22:54:55
0.6.0.000

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

New numbering scheme.  Some code changes.  Fixed "standard mode" memory leak.

Jan,  Maybe those bugs are fixed.  I seriously doubt it (I changed things, but I don't know why it's not working for you, so I don't know how to fix it), but at least now you can experience those same bugs with 0.6b.    Let me knowif any of my changes actually made a difference, though.

edit:  If you see any "WINDOWS ERROR" messages, please let me know.    I changed some code to popup useful messages in the case of two things that shouldn't happen at all.

Change Log:
Quote
Updated:
  to foobar2000 0.6 SDK
Changed:
  Numbering scheme; The first three numbers are now the minimum
  compatable version of foobar2000.  The last three digits are the
  Meta Search version number for that particular foobar2000 branch. 
Changed:
  Lots of new code restructuring.
Changed:
  Major behavior changes.  The necessary information is gathered every
  single time the search window is opened.  This simplifies the program
  logic.  It also accounts for the loss of some SDK functionality that
  the program was depending on.  Unfortunately this means a short pause
  before the window is displayed (similar in length to the pause while
  the Album List loads).
Fixed:   It's no longer possible to modify Meta Search preferences while the
  search window is open.  This is the simplest way to avoid several
  possible bugs.  This behavior may change in a future release.
Fixed:   memory leak
Misc:   still fighting with the combo boxes
Title: foo_shizzle
Post by: ExUser on 2003-04-02 00:43:39
Quote
Numbering scheme; The first three numbers are now the minimum
  compatable version of foobar2000.  The last three digits are the
  Meta Search version number for that particular foobar2000 branch.

Uhm. That adds to six. There are only 5 numbers.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 00:58:38
I posted the number wrong.  It should be: 0.6.0.000
Title: foo_shizzle
Post by: anza on 2003-04-02 06:27:15
Now meta search gives error like this every time I try to run it: "Error during window construction"
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 09:48:44
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 13:10:04
Quote
Now meta search gives error like this every time I try to run it: "Error during window construction"

Are you also getting this error when you try to open the config window?  Or is it only the search window?
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 13:15:32
Quote
  • Search for something selecting from list what to search in.

  • Clicking the "search in" field.

  • --> WINDOWS ERROR: IDC_SEARCH__COMBO_CBN_EDITCHANGE

So you're actually getting this message when you are selecting?  Not when typing into the combo?
Windows is bizarre.  Can you tell me exactly when you're getting this message?  Is it when you click on the field and it displays the drop-down list, or is it when you ctually choose a different selection from that drop-down list?

Oh, wait.  I see.  You're actually getting that message when you first click on the drop-down list.  Hmm.  At least this is more useful that knowing that it just doesn't work. 

edit:  Windows 2000 might not be quite as bizarre as I thought.  I typed in one of the errors wrong.  I'll bet you were supposed to see "IDC_SEARCH_COMBO__CBN_SELCHANGE", and I should be able to fix that.
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 13:30:21
hmmm...now I only get the error when I try to write something in the "search in" field...and not as I wrote: when I click it.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 13:49:57
Wait.  So you're actually seeing that message when you type into the "search in" field?  Ok.  Windows is as bizarre as I thought earlier.

I've posted a new version: 0.6.0.002 (uploaded 001 and then made another change)
http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

I don't know if it will fix your problem, Jan, but it might.  The problem is that Microsoft isn't very clear on which messages are sent, or when, or in what order.  I've changed some code, though, so it should be handling things differently.

anza, I think it will probably fix your problem, but I'd still like to know if you were seeing that same message when you openned the config window. 
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 14:04:23
The error is gone but I still can't search in anything not listed in the drop-down.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 14:23:05
So even if you hit the enter key and force it to re-search, you're still limited to only what's in the drop-down list?

Also, is the "auto-search" bug fixed, or do you still have to have auto-search on?
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 14:31:35
Hitting enter never did anything for me (other than a short flash indicating that something was updated).

What auto-search bug are you refering to?

Auto-update search in enabled.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 14:45:28
Didn't you say earlier that you had to have auto-search turned on in order to search at all?

edit:
Quote
Without "auto update" enabled it doesn't search at all no matter what I do.


Is that still the case?

By the way, I really appreciate your help with this.
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 14:54:46
No, if I select something from the list I can search manually (with auto-search off and hitting enter to search instead).

And np  I love to help if I can.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 15:16:55
Quote
No, if I select something from the list I can search manually (with auto-search off and hitting enter to search instead).

And np  I love to help if I can.

Well, that's good.  I don't know where the "auto-search" bug came from, but I'm the restructuring fixed that, at least.

If you feel like doing some more testing, I've uploaded 0.6.0.003 annoying version.  It'll pop up messages telling what windows is doing when you search.  Just try typing something into the combo-box, and let me know what messages pop up. (Title and Message)

http://gelaed.com/resources/cplusplus/foo_...le.annoying.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.annoying.zip)
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 15:32:08
This happens when I try searching using something not on the list:
metasearch3 (http://qas.united.net.kg/metasearch3.png)
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 15:41:23
That's what I expected, but I don't know why it's doing that.  I'm going to have to figure it out.

Thanks.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 16:03:45
0.6.0.004

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Should work fine now. 
Title: foo_shizzle
Post by: anza on 2003-04-02 16:16:22
Ok, I was getting the error also in the config screen, and it wiped out all the settings also  When I put the settings back, it started working greatly again. Haven't tried 0.6.0.004 yet, but hope it works fine also
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 16:22:48
I fixed that bug in 0.6.0.003, because it happened to me, too.    It's in the changelog.
Title: foo_shizzle
Post by: Jan S. on 2003-04-02 16:29:15
Everything works perfectly now!!!
(http://www.click-smilies.de/sammlung/grinser/grinning-smiley-004.gif)
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-02 16:41:36
Yeah, it helps when the developer stops using messages that don't work on your system.    (long story that involves me trying to optimize)

I'll see about changing it so that you can search for "sound engineer" soon.    Then I might try again to get it working on Win98.
Title: foo_shizzle
Post by: anza on 2003-04-02 17:06:07
Yeah, working great right now! Everything's just as it should!
Title: foo_shizzle
Post by: Jan S. on 2003-04-03 19:21:37
Could you please make it search in filename also when searching in "all"?
Title: foo_shizzle
Post by: anza on 2003-04-03 19:53:12
I believe there is an option for that
Title: foo_shizzle
Post by: anza on 2003-04-03 19:59:28
Hey just got an idea. Could you make it so, that when searching for filename, it shows the filename, not the results display formatting? It'd be so cool if it was possible and you could make this happen.
Title: foo_shizzle
Post by: Jan S. on 2003-04-03 20:20:09
Quote
I believe there is an option for that

oh yes..    sorry
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-03 20:43:36
Quote
Hey just got an idea. Could you make it so, that when searching for filename, it shows the filename, not the results display formatting? It'd be so cool if it was possible and you could make this happen.

I'll consider it.  Don't expect it any time really soon, though.    I really should change the name of that option, too.  The "filename" search is actually searching the entire path, not just the name of the specific file.

Mine's actually setup to display the path.
Title: foo_shizzle
Post by: Jan S. on 2003-04-03 20:50:07
Could you make it possible to use colors? like in the playlist.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-03 21:03:35
I honestly haven't a clue how to do that.  At some point in the future, I might do that, but honestly, it's not a huge priority right now.  :\  I've got some other things I'd like to work out first. (e.g. Larger text sizes on Windows 2000 mess the buttons up.)

I think to add colors, it would require implementing an owner-drawn listbox, and I've got no clue how much effort it would be to code something like that.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-03 22:16:43
[0.6.0.005]
Fixed:   Windows 2000 sizing bug. (Buttons were breaking with larger text sizes)
Fixed:   "Filename" search option is now "Path", reflecting the actual search.

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)
Title: foo_shizzle
Post by: anza on 2003-04-04 08:58:04
A request again (who would have guessed?)
Could you make a "remove from database" button similiar to the one album list has?
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-04 14:06:34
The problem is how many buttons do we want.  :\  It's already crowded.

There won't actually be any updates for a little while.  I'm doing some major code restructuring, so there won't be any new features (or releases) for at least a few days.
Title: foo_shizzle
Post by: anza on 2003-04-04 14:32:51
What about making it to a right-click menu in your plugin?
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-04 14:37:49
Yesj, I realized what you wanted after I posted that.    I might see about adding a right-click menu later.  I want to finish the code work I'm doing first, though.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-05 23:40:46
0.6.0.006 released.  Lots of little changes that you can see and use.  Lots of big changes behind the scenes that make it easer to update the plugin.

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)


Code: [Select]
[0.6.0.006]
Changed:
 Major changes "under the hood"
Changed:
 New layout for the config window.
Fixed:    No more annoying "please close search/config window" popups
Added:    results list font is now selectable
Added:    Search Window context menu
Added:    "Remove from database" to context menu
Added:    "Activate search window" button
Changed:
 Preferences are now saved as soon as they are changed, rather than when
 the config window is destroyed.  To apply the new settings to the search
 window, click the refresh button, or close and re-open the window.
Added:    search window now has a refresh button
Fixed:    slightly less flicker on resizing
Changed:
 Resized search window buttons.
Added:    Text in quotation marks (in both the "search in" and the "search for"
 fields) is now considered to be a single token.  Now it's possible to
 search in "recording engineer" for "Ibbetson, Adrian", as opposed to
 searching "recording" and "engineer" for "Ibbetson," and/or "Adrian".
Added:    Remember window placement option.
Added:    "Display results as paths when searching in paths" option
Fixed:    Searching for "file://" in paths no longer returns all database entries
Fixed:    Minor tabbing glitch in search window
Changed:
 Context menu has more friendly behavior now.
Title: foo_shizzle
Post by: anza on 2003-04-05 23:45:48
COOL!
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-05 23:46:54
Let me know how you like it. 

(And of course any suggestions.)

Simple color choices might be in the next version.

P.S.  Would you guys want the font to apply to the "search in"/"search for" fields as well?
Title: foo_shizzle
Post by: Chun-Yu on 2003-04-06 03:19:09
Hey, Snoop Dogg already used "shizzle" in his Shizzolator (http://www.asksnoop.com/).
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-06 04:22:10
Indeed.  The plugin name was chosen to make a reference to the "slang" phrase "fo' shizzle".  Because I am that lame. 
Title: foo_shizzle
Post by: anza on 2003-04-06 07:40:18
It'd be a good thing to have all fonts used configurable. It makes it possible to fit the plugin yet a bit better to your Windows settings. But this is only a cosmetic thing, not very high priority  But as the plugin seems to be quite finishend (meaning that it works really well), it might be the time to do this cosmetic improvement soon. The same thing is with the color choices.
This plugin is looking very good right now, the searching works great, you've made options/improvements that really work!
Title: foo_shizzle
Post by: BlueScreenJunky on 2003-04-06 08:39:04
Quote
If I uncheck the "auto-update" box, then type in something and press enter, it doesn't return any result.
After that if I recheck the "auto-update" box, I don't get any result, no matter what I do. I have to restart foobar and it works fine again. Doesn't bother me since I always use the auto-update feature, but that makes the option rather useless ;-)
(still using win2k SP3)

it's now working perfectly, good job !

and the context menu is grrrrrreat ! It would be perfect if you could add "open directory" in the menu, because I often use foo_shizzle instead of the windows search engine to find my MP3s  :-)
There's another feature I'd like to see in the playlist and in foo_shizzle : tooltips, either configurable with a string, or displaying the tags and file location.

and finally, I think you could change the default display string for foo_shizzle, because it doesn't work if there is no tag (untagged MP3 or other filetypes like .mod, .it, .tfmx etc.). Mine is $if(%artist%,%artist%,'Unknown Artist') $if(%album%,- %album%,) :  $if(%title%,%title%,%_filename%), which is very similar to the default string for the playlist I guess.

that's it, keep up the good work 
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-06 09:37:52
Anza, I'll see about adding font coverage to the other elements.  It's not a feature I ever plan to use myself, but I thought that some people might like to have it.  Color choices is a bit of a problem.  I hope to add that eventually, but it might be a little while, because there is (as far as I know) no WM_SETCOLOR or equivalent.  I believe it'd require implementing an owner-drawn list box. (i.e. drawn by my plugin)  I might try to do that eventually though.  I just don't know when.

BlueScreenJunky, Open directory will be in the next version.  Don't worry. 

I'd like to add an edit tag option, but I haven't a clue how to do that (I'm not going to do parsing of tags myself, because that would be a waste of time since foobar already has features for that).  Feel free to let me know if you know how to add that using the SDK, or if you know of an example (with source) which uses the SDK to do tag editing.

Tooltips are a good idea.  I've never used tooltips before, though, so I'll have to find out how first.

I probably should change the default search string.  I have mine set to %_path%, and I've never really worried about it much because it is customizable.  I'll try to remember to set the default to something more useful that "%artist% - %album% - %title%" before the next release, though.  If nothing else, it needs a better search string that that one for sorting.

I'm glad you all seem to like it. 
Title: foo_shizzle
Post by: anza on 2003-04-06 09:52:46
Well I myself don't think the font coverage is a must have, but I think some people might like it. I propably would use it, but I'm perfectly fine without it also. What comes to the color choices, I really don't see them that important. If you some day add them, fine, but I don't need them. Again, I'd propably use that too, as I just happen to like to configure everything
I think something like this: "more configurability = more user friendly program / more better usability"  So every thing you add, that adds configurability, is a good thing IMO. Maybe this is also the reason I've changed from Winamp to foobar, who knows? 

EDIT: I think I found a "bug". Actually it's just a thing that you should fix, not a bug. But it's like this: When you have "display empty result list..." disabled it should show all the files that are in the database when you open up the window, right? Well, it does this *only* when you have "auto-update search results" enabled. If you have it disabled (as I do), it shows empty list when opening the window. Maybe you should fix this?
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-06 10:03:07
Well, the font thing is the first thing I've added to the plugin that I actually didn't care about.  Every other option has been something that I personally wanted, even if it wasn't originally my idea.  If I add more font choices (i.e. select label font and results list font and search fields fonts separately), it's just going to be for other people.  I'll never use them.  (Consequently, I'll probably push them into a sub-menu, so that people like me who just don't care about them don't have to worry about them.)  Colors are the same way.  I really don't care about them, but I've gotten a few requests for them, so I'll probably add them eventually.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-07 04:05:16
0.6.0.007

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Code: [Select]
[0.6.0.007]
Added:    "Delete selected files" and    "Recycle selected files" to context menu
Fixed:    Now stops currently playing if currently playing is one of the files
 selected for deletion.
Fixed:    Worked around some bizarre behavior involving files in the playlist
 being removed from the database.  After deleting or recycling files,
 a command is sent to foobar to remove dead playlist entries.
Added:    "Go to folder" option in context menu
Fixed:    Right-click in list will now set the "caret" where the mouse button was
 clicked.  (useful for "go to folder")
Changed:
 Default search string is now far more useful
Fixed:    Font bug.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-11 23:14:44
0.6.b11.001 available, for all your database searching needs. 

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Code: [Select]
[0.6.b11.001]
Fixed:    Works with b11.  (Quite a few SDK changes, so quite a few internal
 changes here, too.)
Fixed:    Possible bug in delete/recycle commands.
Fixed:    "Standard Search" bug.  Should be both faster starting and more
 accurate
Fixed:    No longer crashes when NULL pointers are returned by the database
Fixed:    Removed a small quirk with fonts when plugin loaded the first time
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-11 23:50:37
foo_shizzle 0.6.b11.002 uploaded

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Code: [Select]
[0.6.b11.002] <hotfix>
Fixed:    Playlist clearing "bug" (really slow)
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-12 03:28:15
[0.6.b11.003] <hotfix>
Fixed:   Minor bug in "remove selected from database"

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)
Title: foo_shizzle
Post by: anza on 2003-04-12 09:14:24
Ok it doesn't work with Win98 and v0.6 beta12.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-12 15:51:53
It never worked with 98.  :\

And it works fine for me with b12.

Are you having oroblems on an NT-based machine as well, or just 98?
Title: foo_shizzle
Post by: anza on 2003-04-12 17:18:10
Ok, I just wanted to make sure it was the w98, as I remembered something like that.
I don't know about the NT systems yet, but tomorrow I'll tell you if it works (as it propably does) as I get home.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-13 22:18:14
Quote
Ok, I just wanted to make sure it was the w98, as I remembered something like that.
I don't know about the NT systems yet, but tomorrow I'll tell you if it works (as it propably does) as I get home.

Yep.  I don't have a 98/ME test machine, so it's too much trouble to hunt down the bugs.  If I ever get it to a stable point, I might try to work on that, but otherwise, I just don't feel like fighting it.
Title: foo_shizzle
Post by: anza on 2003-04-14 05:24:39
Found a bug that crashes whole foobar. Put only one space to the search string, press enter and it crashes. Every time.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-14 05:59:05
You're right.  I think I know where the bug is.  I'll fix it tomorrow.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-14 06:48:02
foo_shizzle 0.6.b11.004 uploaded

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Code: [Select]
[0.6.b11.004]
Changed:
 Upgraded to 0.6b14 SDK
Fixed:    No longer crashes when tokenizing all-space "search in" strings.
Fixed:    When "search for" string is composed of all spaces, it is treated
 as an empty string.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-25 06:34:03
foo_shizzle 0.6.b11.005 uploaded
Compiled 25.Apr.2003

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Quote
[0.6.b11.005]
Changed:
  Upgraded to 0.6 final SDK
Added:   Font selection for search boxes
Added:   Search history
Added:   Format string history
Added:   Option to clear "Search for" box after each search
Fixed:   Completely invalid files (files with NULL file_info) are no longer
  returned in the search results.  Ever.
Fixed:   Error in thrifty search.  Now properly searches when "search in path
  when searching all" is checked.
Changed:
  Minor speed and size optimizations.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-25 07:33:47
foo_shizzle 0.6.b11.006 uploaded.

Hotfix.  There was a bug in the font selections.  (Wasn't saving properly on exit.)

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)
Title: foo_shizzle
Post by: teetee on 2003-04-25 12:57:09
ok this is I think a bug. I'll try to explain it clearly with an example:

system: WinXP SP1, foobar2k v6, Logitech mouse on Windows standard drivers
shizzle version latest as of 5mins ago

I'm searching in 'All'.
I type 'beethoven' in Search for.
I get my 61 results.

All fine and dandy. Until I do either of the following:
delete the Search for string
scroll down with the mouse wheel
choose a string from the drop down history that is longer than the current string

What then happens is:
The Results box clears (fine in the first case but unexpected in the second)
Then if I try to select a search term that I've used before from the drop down box it doesn't show the results.


so I type beethoven (get results), delete beethoven, choose beethoven (or anything else from the drop down history) and get no results.

I hope this is clear!

The other time this happens is if I choose a string from the drop down shorter than the current string, except it deals with that one fine but then refuses to show results if I select more strings from the drop down.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-25 13:41:28
Can you tell me what kind of config settings you're using?

Pretty much all of the info in the config screen in pertinent.

edit: I think I see what you're referring to.  I'll see if I can get it fixed soon.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-25 13:59:24
0.6.b11.007

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Should fix it.  I should also note that the search history is effectvely useless when auto-search is turned on.  There's no real way to make it useful whe auto-complete is on, because if you search for "beethoven", it searches for "b", "be", "bee", "beet", etc, for each additional letter typed.  But anyway, it should behave in a predictable manner now.

In addition, this is pretty much an "internal" build.  I added mass-tagger capabilities as a test.  I don't keep multiple backups on my system (I should, though), and I didn't feel like stripping out the masstagger functionality.  It should be working fine, though.  Let me know if you find any bugs with it.

Anyway, I hope you like the masstagger functionality, even though you weren't supposed to see it yet. 
Title: foo_shizzle
Post by: teetee on 2003-04-26 01:35:26
sorry I would have posted my shizzle config but as I hadn't changed anything from the out-of-the-box setup I assumed it wouldn't matter .

That certainly fixes the problematic part of the issue. It doesn't auto-show the results of the search when I choose from the history (have to press enter) but that could arguably be desirable behaviour..

Thanks for sorting that out so quickly.

I agree that a large proportion of the history is useless in auto-search mode but luckily the history is big enough that it retains at least some of the 1 previous search (eg. search for classical then beethoven, you can still see classical in the history.

1 more little niggle (may be part of it being an internal build - I don't recall if it did this before). When it opens it would be nice if the cursor was already in the search for box so one can open it and begin to type a search straight away. This would line it up with the basic search in foobar.

I don't know what you mean by masstagger functionality so I can't comment . I have tried to think what you mean but I can't seem to work it out - it could be the amount of beer in my system right now.. but I'd love to know (when I wake up sans hangover) so I can try it out!

cheers again for a great little plugin
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-26 02:36:55
It used to start with the cursor in the box.  I didn't notice that it had broken (tab order got messed up when I replaced the editbox with the combobox).  I'll get that fixed for the next release.  (Going to be a little while, though.  Working on some fairly big changes, and chasing some really wierd bugs that those changes have introduced.)

The masstagger is the same as the one that foobar provides.  i.e. When you right-click on the foobar playlist, you'll see the Masstagger options.  If you right-click on the results list in Meta Search, you'll see those same options.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-26 03:19:34
And unto the masses there came foo_shizzle 0.6.b11.008. 

http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Quote
[0.6.b11.008]
Changed:
  Masstagger capability is no longer hardcoded.  Only works if
  masstagger plugin is present.  This reduces foo_shizzle's filesize,
  and more importantly, allows the masstagger to be updated
  independently of Meta Search (and vice versa).
  Many thanks to Peter for help on this one.
Added:   "Show file info" option.  (Dependent upon the CORE Show file info
  functionality)
Fixed:   Search for box is selected when the plugin is opened.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-26 09:44:28
foo_shizzle 0.6.b11.009
http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Quote
[0.6.b11.009]
Fixed:   Now returns "Gelaed" for keyboard shortcuts group name
Added:   Now double-buffered on Windows XP, for that oh-so-smooth resizing
  action
Fixed:   No longer selects the text in the search in/search for fields when
  resizing
Title: foo_shizzle
Post by: teetee on 2003-04-26 10:59:03
Quote
The masstagger is the same as the one that foobar provides.  i.e. When you right-click on the foobar playlist, you'll see the Masstagger options.  If you right-click on the results list in Meta Search, you'll see those same options.

I see. Good idea.

Funnily I had a load of weird dreams (must have been the alcohol) but one was about the mass tagger thing.. It was that meta_search allowed you to get results on files with:

1. x or less tags
2. a missing x field

Then it would help with tagging a load of poorly tagged files.. Just an idea you might like to consider (if it isn't already possible)
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-26 11:42:30
I've actually thought about adding that.  There are several things that I would like to add, as far as searching capabilities go.
Title: foo_shizzle
Post by: musicmusic on 2003-04-26 13:27:38
hello Curious George, thanks for foo_playlistfind 

1 small request though, could you make an option so that it will only search from the beginning of the string? I.e. it will kinda be like autocomplete in internet explorer or mozilla.. So if you enter Sa for example, it will scroll to entries starting with Sa.

Thanks again..
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-26 13:43:27
Sure.  I'll add an option for that in the next version. 
Title: foo_shizzle
Post by: musicmusic on 2003-04-26 15:49:27
Quote
Sure.  I'll add an option for that in the next version. 

Thanks

BTW one minor thing about foo_addall - if you have the "play on send" option on, clear the playlist and then run send all from database, it will always play the first track even when shuffle is on. I know send all will clear the playlist it self, but its a habit ive got :/

foobar also does a similar thing (with shuffle on), that is if you leave it playing, clear the playlist, add tracks again, the next track it will play (by just letting it play) will be the first one..

Also, another thing about foo_addall, when running send all (again with "play on send" option on) when playback is paused will just unpause playback.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-26 16:10:25
Quote
Thanks

Welcome.

Quote
BTW one minor thing about foo_addall - if you have the "play on send" option on, clear the playlist and then run send all from database, it will always play the first track even when shuffle is on. I know send all will clear the playlist it self, but its a habit ive got :/

Well, that's really foobar's behavior.  I might look at changing it later, though.  I should be able to force it to play a random track. (I've never tried, but I assume the functionality is there.)

Quote
Also, another thing about foo_addall, when running send all (again with "play on send" option on) when playback is paused will just unpause playback.

I might look at changing this as well.


I'm not really sure if I want to change either of those behaviors.  That part of my code is straightforward and logical.  But I'll consider it.

P.S.  I'm glad to hear that someone uses foo_addall.  I thought it might just be me. 
Title: foo_shizzle
Post by: musicmusic on 2003-04-26 16:45:40
Quote
P.S.  I'm glad to hear that someone uses foo_addall.  I thought it might just be me. 

Lol. I only use it because its quick and supports custom sort strings. I wish that ZzZ would expand the "Sort incoming files" option.

PS. its only the second one that really annoys me.
Title: foo_shizzle
Post by: addicted on 2003-04-27 00:38:10
Very cool...... thanks!
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 01:53:13
Some updates.

foo_addall 0.6.b11.004
http://gelaed.com/resources/cplusplus/foo_addall.zip (http://gelaed.com/resources/cplusplus/foo_addall.zip)
Quote
[0.6.b11.004]
Changed:
  If a song is paused, and "Send all from database" is selected
  (and "play on send" is selected), Add All will stop the current
  song and start one of the new songs.
Changed:
  When shuffle is on, Add All now "forces" shuffle for "Play on
  send", rather than simply giving foobar the command to play (which
  results in playing the first track every time).


foo_shizzle 0.6.b11.010
http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)
Quote
[0.6.b11.010]
Changed:
  If a song is paused, and "Send Selected" or "Send All" is clicked
  (and "play on send" is selected), Meta Search will stop the current
  song and start one of the new songs.
Changed:
  When shuffle is on, Meta Search now "forces" shuffle for "Play on
  send", rather than simply giving foobar the command to play (which
  results in playing the first track every time).


foo_playlistfind 0.6.b11.003
http://gelaed.com/resources/cplusplus/foo_...laylistfind.zip (http://gelaed.com/resources/cplusplus/foo_playlistfind.zip)
Quote
[0.6.b11.003]
Added:   "Search only from front of entry strings" option
Added:   "Close Playlist Find and play currently focused" keyboard shortcut
Added:   Now passes unhandled keyboard messages to the main Foobar window


addicted, you're welcome. 
Title: foo_shizzle
Post by: anza on 2003-04-27 12:39:49
foo_playlistsearch won't work when using "Search only from front of entry strings".. It just doesn't do a thing. When using the "old behaviour" it works fine.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 12:43:31
Make sure the formatting matches that of your playlist exactly (sans numbers, unless you want to type those in . . . ), or it will appear to be working improperly.

It works fine here.
Title: foo_shizzle
Post by: anza on 2003-04-27 12:58:22
Oh damn, so I have to have the playlist number before anything else on the formatting if I have it so on my playlist? damn..
Well the option doesn't then work for me as I have something like "$num(%_playlist_number%,4)|··" in the beginning of the PL formatting (where the '··' are mp3pro/mpc and RG indicators..). Oh well, I actually like not to use the option anyway, but I just thought I should report this.
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 13:01:38
Well, you need to set the string to start at what you consider to be the beginning.

e.g.
Quote
$if(%_isplaying%,
A3D3F3|0051AA
>>657C66|7E9780.
A3D3F3|0051AA
//$num(%_playlist_number%,3).
[%artist% 0500D5|0500D5•A3D3F3|0051AA ]$if(%album%,'['%album%$if(%disc%, disc: %disc%,$if(%disk%, disk: %disk%))$if(%tracknumber%, #$num(%tracknumber%,2),$if(%track%, #$num(%track%,2)))'] 0500D5|0500D5•A3D3F3|0051AA ')$if(%title%,%title%,{%_filename_ext%})
[   A3D3F3|0051AA%_length%]
,
FFFFFF|FFFFFF
$num(%_playlist_number%,3).
000000|000000
[%artist%
0500D5|0500D5

000000|000000
]
$if(%album%,'['%album%$if(%disc%, disc: %disc%,$if(%disk%, disk: %disk%))$if(%tracknumber%, #$num(%tracknumber%,2),$if(%track%, #$num(%track%,2)))'] 0500D5|0500D5•000000|000000 ')$if(%title%,%title%,
{%_filename_ext%})

[   
FFFFFF|FFFFFF
%_length%]
)


Quote
[%artist% • ]$if(%album%,'['%album%$if(%disc%, disc: %disc%,$if(%disk%, disk: %disk%))$if(%tracknumber%, #$num(%tracknumber%,2),$if(%track%, #$num(%track%,2)))'] • ')$if(%title%,%title%,{%_filename_ext%})
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 13:03:38
Bugs in the board.  It displayed wrong and won't let me edit it.

Quote
[%artist% • ]$if(%album%,'['%album%$if(%disc%, disc: %disc%,$if(%disk%, disk: %disk%))$if(%tracknumber%, #$num(%tracknumber%,2),$if(%track%, #$num(%track%,2)))'] • ')$if(%title%,%title%,{%_filename_ext%})
Title: foo_shizzle
Post by: anza on 2003-04-27 13:09:26
Can't get it to work but maybe it's just me  Whatever..
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 13:13:34
Post your formatting string, and I'll see if I can help.

edit: strings.  Post both the playlist format and the playlistfind format.
Title: foo_shizzle
Post by: anza on 2003-04-27 13:19:03
Ok here's (http://koti.mbnet.fi/antsau/foobar/playlist.txt) the playlist string (it's the "normal" one I'm using) and this is the one I use with playlistfind:
Quote
[$if2(%performer%,%artist%) -] [%title%[ '('%comment%')']] /[ %album%][ -%disc%-][ #%tracknumber%][$if(%album%, -,) $if2(%albumdate%,%date%)] /
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 13:25:04
I just realized that I'm doing case-sensitive comparisons when searching only from the beginning of the string.  Check to see if that's the problem.
Title: foo_shizzle
Post by: anza on 2003-04-27 13:29:58
Heh, problem solved
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 14:03:41
foo_playlistfind 0.6.b11.006
http://gelaed.com/resources/cplusplus/foo_...laylistfind.zip (http://gelaed.com/resources/cplusplus/foo_playlistfind.zip)

Quote
[0.6.b11.006] <hotfix>
Fixed:   Search is now case insensitive when "Search only from front of entry
  strings" is selected.  (Searching has always been case insensitive
  when "Search only from front of entry strings" is not enabled.)
Changed:
  Using Window functions for string comparisons now, rather than
  mine.


Give it another shot. 
Title: foo_shizzle
Post by: anza on 2003-04-27 14:18:14
Yeah, works now, thanks  It's great to see that all plugin authors for fb2k are so willing to help and fix their plugins really fast. Great!
Title: foo_shizzle
Post by: musicmusic on 2003-04-27 15:28:59
Thanks Curious George

(for new foo_playlistfind).
Title: foo_shizzle
Post by: Curi0us_George on 2003-04-27 15:48:31
You guys are definitely welcome.  I couldn't track down bugs as quickly without your help, so I owe you all thanks, too. 

edit:
foo_shizzle 0.6.b11.011
http://gelaed.com/resources/cplusplus/foo_shizzle.zip (http://gelaed.com/resources/cplusplus/foo_shizzle.zip)

Quote
[0.6.b11.011]
Added:   Toggle for Double Buffering.  Apparently WindowBlinds doesn't like the
  WS_EX_COMPOSITED style, and it can result in flicker in the scrollbar.
Title: foo_shizzle
Post by: herr klang on 2003-05-26 23:56:11
so i'm not sure if it's in bad form to compliment winamp here, but i'm a pretty big fan of the media library recently introduced in winamp 2.9, and one of the reasons i love it happens to be absent from foo_shizzle - the ability to play either an entire album or all tracks by a given artist just by right-clicking on an entry returned from one of its searches and selecting "play all from <album>" or "play all by <artist>" in the popup menu. how difficult would this be to add to foo_shizzle?
Title: foo_shizzle
Post by: Curi0us_George on 2003-05-27 00:34:49
It would be pretty difficult to add anything to foo_shizzle.  I lost a big chunk of my work a while back in an accidental deletion.  So now I'm missing some fairly major parts of foo_shizzle.  I will resume work on foo_shizzle when we reach 0.7 (beta).  I'll consider your suggestion then.
Title: foo_shizzle
Post by: graham_mitchell on 2005-01-15 14:19:57
I tried the most recent version of foo_shizzle here and got this:

"INFO (CORE) : startup time: 110 ms
ERROR (CORE) : Failed to load DLL: foo_shizzle.dll, reason: Wrong version number; this component appears to have been built with outdated version of foobar2000 SDK and needs to be recompiled with newer version in order to load; please contact author of this component to obtain an updated version of this component."
Title: foo_shizzle
Post by: kalmark on 2005-01-15 14:34:31
Did you read the 1.5 years old post above yours? Did you read your own post? Try to combine  Developement has stopped, and the sources for it are lost.
Title: foo_shizzle
Post by: graham_mitchell on 2005-01-17 01:37:48
No, I didn't notice the date. Thanks!
SimplePortal 1.0.0 RC1 © 2008-2021