Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_dsp_effect (Read 258749 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: foo_dsp_effect

Reply #525 –
beta 2 out. Will look at feature requests I think in beta 4. I wanted to really clean up beta 1 as well as adding full x64/DarkMode support.
I read the entire thread and I think I now fixed that tag issue with tempo/rate/pitch.

edit: and now beta 3 for those stuck on 1.6

Re: foo_dsp_effect

Reply #526 –
thank you... i was waiting for this.

Re: foo_dsp_effect

Reply #527 –
when i attempt to load this, it fails out the component and i have to revert it back to pre beta version. i have windows 11 and the error message complains about the dll not being a valid system 32 repository

Re: foo_dsp_effect

Reply #528 –
Quote from: mrgypsum on
when i attempt to load this, it fails out the component and i have to revert it back to pre beta version. i have windows 11 and the error message complains about the dll not being a valid system 32 repository

Me Too

Cardiacs

Re: foo_dsp_effect

Reply #531 –
fixed. wrong dll. try now. did some ignoramous shit.

Re: foo_dsp_effect

Reply #532 –
Please can somebody explain why installing foo_dsp_effect v0.50 beta 3 in place of v0.47 changes my DUI config so dramatically?  It goes from this (0.47):

X
X

...to this (0.50b3):

X
X

...but (fortunately) it goes back to previous if I re-install 0.47.  FB2K 1.6.12.  I can understand why the tempo and graphic equaliser tabs might need to be re-configured, because they (presumably) are keyed to foo_dsp_effect, but why would the cover art tab go AWOL?  I guess the layout shift in the right hand pane is due to the width of the left hand pane previously being set by the tempo tab.
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #533 –
Yes the 'Tabs' element will revert to scroll buttons when the tabs no longer fit (see the arrow buttons on the right side of the left 'Tabs'?) Just move the middle splitter so the tabs fit again.

(Always been a pet peeve of mine because 'Playlist Tabs' element stacks tabs, and I wish the 'Tabs' one did the same or at least an option - that way you could make a vertical stack of tabs. But anyway...)

Re: foo_dsp_effect

Reply #534 –
I just worked that out for myself, sorry my bad.  All I had to do was move the divider back to where it was before.

Regarding 0.50b3/1.6.12:

  • Nice to have individual controls for tempo pitch and speed.
  • A tempo set in a tag for a track still cannot be over-ridden by the tempo slider.

Nonetheless, very grateful mudlord is supporting us v1 users.
It's your privilege to disagree, but that doesn't make you right and me wrong.
 

Re: foo_dsp_effect

Reply #536 –
Quote from: mudlord on
Try [0.50 beta 5]
An improvement with reservations.  I think it's now a problem of clarity in the user interface (and bear in mind I have only looked at the tempo section, not pitch nor speed, but I suspect the comments apply similarly).

  • Play a track with the tempo_amt tag set and tempo control not enabled, it plays at the original tempo.  Okay.

  • Play the track with tempo control enabled, it plays at the tempo adjusted as per tempo_amt.  Okay, but the UI still shows "0.00%" and it would be useful for the actual adjustment to be displayed.

  • Disable tempo control and playback reverts to original tempo.  Okay.

  • Re-enable tempo control, playback does not resume tempo_amt but takes the UI setting.  Okay-ish, but not intuitive.

  • With track playing at temp set by tempo_amt, make any adjustment to the UI setting and that overrides tempo_amt.  Okay-ish, but if tempo_amt is (say) +10% and the user wants to make a -5% adjustment to the actual live tempo that means a setting of +5% not -5%.

I think the shortcomings can be overcome very simply: take the tempo_amt value and instead of acting on it directly, use it to preset the UI setting (both percentage display and slider, and whether enabled or not), then the user gets to see exactly what's going on.  I'm undecided what to do at the end of the track - keep the setting as is or reset to 0%... maybe that could be an option tick box.

Add to that some buttons which increment/decrement the current percentage setting (again reflected in the percentage display and the slider), eg:

[ -10% ] [-3%] [-1%] [-0.5%] [Reset] [+0.5%] [+1%] [+3%] [+10%]

...and I'll be ecstatic.  I think somebody else wanted similar.  I can't imagine anyone needing finer control than that but if they do there's always direct typed input.  To cover all user requirements, maybe the buttons could be configurable in Preferences.

With grateful thanks for the continued support.

Incidentally, VirtualDJ's default settings automatically adjusts the next track's playback tempo (as auto-extracted on load) to match the measured beat rate of the current playing track.  Great for clubbing no doubt, not so clever if you're playing a jive followed by a waltz!  It wasn't until I realised what was going on that I was able to delve into the settings and disable it!

Beat detection in VirtualDJ is remarkably good... but not perfect, particularly when it comes to ballroom music, and can't be totally trusted.
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #537 –
Quote
use it to preset the UI setting (both percentage display and slider, and whether enabled or not), then the user gets to see exactly what's going on.  I'm undecided what to do at the end of the track - keep the setting as is or reset to 0%... maybe that could be an option tick box.

brilliant idea. why didn't I think of that.

Re: foo_dsp_effect

Reply #538 –
I'm holding my breath...
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #539 –
There is a conundrum though.

Is this to be done on track start? Programmatically I see the only way to do this is how I do it now. You cannot alter UI elements from playback_static callbacks AFAIK. You can only change things from the interfaces given, which is via DSP manager code.

Re: foo_dsp_effect

Reply #540 –
Can it be done on track select (which might be better anyway)?  Would track select interrupt existing current playing track (not sure)?
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #541 –
Okay, different tack:

  • Is it possible to display the value of tempo_amt in the control panel?  At least then the user can see what the effect of "enable" will be, even if not reflected in the controls.

  • Can the tempo set by tempo_amt be used as the baseline for the controls, so that (when enabled) "0.00" represents the track tempo already shifted by tempo_amt?

  • Can there be a separate enable for tempo_amt?  Then the user has the choice whether to respond to tempo_amt at all.  If not enabled (with the control enabled), 0 is the original tempo of the track, whereas with tempo_amt enabled, 0 represents the original tempo shifted by tempo_amt.

Obviously the same would apply to pitch and speed.
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #542 –
Quote from: fooball on
Can there be a separate enable for tempo_amt?  Then the user has the choice whether to respond to tempo_amt at all.  If not enabled (with the control enabled), 0 is the original tempo of the track, whereas with tempo_amt enabled, 0 represents the original tempo shifted by tempo_amt.[/li][/list]

To expand on this: two tick boxes, one for "Tempo Adjust Enable" and the other "tempo_amt Enable ([value])".

0 0 : no tempo alteration from original source;
0 1 : tempo_amt applied, adjustment controls ignored;
1 0 : tempo_amt ignored, adjustment controls operative with "0.00" representing original tempo;
1 1 : tempo_amt applied, adjustment controls operative with "0.00" representing original tempo after applying tempo_amt.

For the casual user (no tempo_amt tags), the tempo control panel operates exactly as before regardless of whether "tempo_amt Enable" is ticked.  For a serious listener to have set a tempo_amt tag, that will be the tempo they want and all they need is "tempo_amt Enable" ticked.

For my use-case, where I might have a baseline alteration of tempo for a ballroom track but still need to tweak that live, I have full options.
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #543 –
Quote from: fooball on
Can it be done on track select (which might be better anyway)?

No. Can be done on track start/new track.

Quote
Is it possible to display the value of tempo_amt in the control panel?  At least then the user can see what the effect of "enable" will be, even if not reflected in the controls.

It does now.

To be quite honest I think the elaborate set of options to me is getting tedious and unfun to implement, which is fairly important since I originally coded this component for myself and out of fun. It is no longer becoming fun.

At the moment to be honest I'd rather be implementing features I want at this stage, since I am rather done with the component and rather work on other things since to me personally, its complete.

Re: foo_dsp_effect

Reply #544 –
Fair enough, it is all appreciated.

As it stands, the tempo_amt tag remains pretty well useless for me (or at least very inconvenient to use).  0.50b5 is nice in that it separates the control panels for tempo, speed, and pitch, but I will continue to adjust tempos live and not use tempo_amt presets.
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #545 –
I'm a musician who likes to play along with recordings, and often the pitch is off up to two semitones in either direction, so I created DSP chain presets for each of those increments, then added buttons for each to my toolbar - including one in the middle for normalizing pitch.  It's much like what people are asking for here.

I had to redo all of those presets for the move to 2.0, too - using them on the new build would just give errors.  Pretty easy to correct, though.  Thanks for keeping one of my favorite components up and running!

Re: foo_dsp_effect

Reply #546 –
Is it just me who has a problem that tracks in which I change the tempo or pitch do not play smoothly? The track sounds choppy. I wish it worked more smoothly.
For example, in Aimp internal plugins do this more smoothly.

Re: foo_dsp_effect

Reply #547 –
Quote from: zizka90 on
Is it just me who has a problem that tracks in which I change the tempo or pitch do not play smoothly?
I find it's adequate when the adjustment is slight, but go beyond (say) 20% and artefacts are obtrusive.
It's your privilege to disagree, but that doesn't make you right and me wrong.

Re: foo_dsp_effect

Reply #548 –
Quote from: fooball on
I find it's adequate when the adjustment is slight, but go beyond (say) 20% and artefacts are obtrusive.

Is it possible for the developer to improve this point? So that the sound is free of artifacts, regardless of the level of tempo or pitch.

Re: foo_dsp_effect

Reply #549 –
Quote from: zizka90 on
Is it possible for the developer to improve this point? So that the sound is free of artifacts, regardless of the level of tempo or pitch.
I doubt it, for several reasons:
  • The FB2K implementation is simply using open-source code rather than proprietary implementations in (eg) VirtualDJ;
  • No such implementation is ever free from artifacts, just less audible ones;
  • The "cleaner" the algorithm, the more processing power it requires (with the risk it cannot be done in real time);
  • Some types of material are more suitable than others.
There are great tomes written on this subject, if you google.  Being prepared to do the processing ahead of time allows for non-real-time processing, and the high-quality option in the Audacity stretcher does a very good job.
It's your privilege to disagree, but that doesn't make you right and me wrong.