Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Georgia-ReBORN - A Clean foobar2000 Theme (Read 186459 times) previous topic - next topic
0 Members and 10 Guests are viewing this topic.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #825
I am not sure what are you trying to test with that, it's not doing what you think it does. New requests should also be directly skipped on shutdown.

Anyway here is a test file which crashes if you delete "window.IsUnload = true;" line; but works fine with it. Note the script will try to access a list of urls and close foobar immediately. So upon foobar restart, it will do the same and effectively make it unusable unless the last line of code closing foobar is removed.

Also note the interval ms affects how it's handled. 30 ms seems to work fine, but higher settings may crash too.  For sure 3000 ms will crash, there is a small window of time between the shutdown request and the actual shutdown and you have to use that.

That can be avoided with a direct abort routine at the callback and a stack of request similar to your approach, but the stack should be managed at the callback (not saying all this is needed, just that it would be the best approach, but the other one may be good enough).

Alternatively, wget or similar may be used to retrieve data from web without all these problems... it may be wise to apply this fix to xmlhttp requests too (and beware of similar behaviors on any activeX object).

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #826
@regor,

sorry for the confusion and never mind. I just tried a too unrealistic/aggressive approach just to illustrate the issue
that it should be gracefully handled by foobar itself when exiting abruptly during HTTP requests...

Your approach works just fine and is the correct way to handle this situation, we don't even need the safeguard
at the beginning of bioSend, I have tested it and it works just fine. As you pointed out:
Quote
there is a small window of time between the shutdown request and the actual shutdown and you have to use that.
With my unrealistic/aggressive approach it failed  ;)

Anyways, all is good, thx for that regor =)
Btw, can you add your workaround here:
https://github.com/Wil-B/Biography/pull/7 or make a new PR for WilB?

@Majestyk, I have already made a commit here:
https://github.com/TT-ReBORN/Georgia-ReBORN/commit/7032ff781487054a368cbd6f42cea521a932b4a8

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #827
Hi, I have been using this wonderful theme for a while. It is really great and I want to thank the creators for their awesome work. There are just some little things I would like to customize in the theme (specifically in the biography panel) that I didn't find a way to customize even looking into the files, maybe someone has a solution or he can give me a hint about where to look.

I upload a screenshot to explain better

A) In the area 2 of the screenshot it loads the country flag of the artist if the file has the tag "artistcountry". This flag is replicated in the area 1. If I select another entry in the area 3, it remains the same flag also if the other artist has another nationality.
If the file doesnt have the "artistcountry" tag, the theme loads the flag directly from the artist biography page instead (I suppose) and it changes if the artist changes. How is it possible to make the theme keep the "artistcountry" flag in the area 2 and let it load the flag in the area 1 in the same way it does when the "artistcountry" tag is missing?

B) In the area 3 there are different selectable entries under "more tags". I have two questions about this.
            1) Is it possible to add other fields in the list (like conductor, ensemble, engineer etc)?
            2) Is it possible to make it search the "performer" tag without the content between brackets (some sites like musicbrainz put the instrument played by the performer in brackets in that field)? The ideal solution would be to have the instrument in brackets still reported in the area 3 but using the tag without the brackets to let the biography query produce some result.


Thank you very much again. Cheers

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #828
Hi @fabwolf,

the artist flags will be displayed if you have tagged your music files with %artistcountry% in the lower bar and also use it
in the Biography. If there is no %artistcountry% metadata, no flag will be displayed in the lower bar, but it will use the Wikipedia
metadata ( if available ) in the Biography.

To add additional tags in the "More Tags:" section in the lookup menu of the biography,
open your "foobar2000\profile\cache\biography\biography.cfg" and go to the bottom and find these:
Code: [Select]
"tfAlbumArtist": "$if3($meta(album artist,0),$meta(artist,0),$meta(composer,0),$meta(performer,0))",
"tfArtist": "$if3($meta(artist,0),$meta(album artist,0),$meta(composer,0),$meta(performer,0))",
For example, to add conductor, we appended it like this:
Code: [Select]
"tfAlbumArtist": "$if3($meta(album artist,0),$meta(artist,0),$meta(composer,0),$meta(performer,0),$meta(conductor,0))",
"tfArtist": "$if3($meta(artist,0),$meta(album artist,0),$meta(composer,0),$meta(performer,0),$meta(conductor,0))",

I would advise to not add the instruments in the performer because of compatibility issues with not only foobar but also other
software when doing a query search on this metadata field. As you mentioned, it will not recognize and ignore the parentheses or brackets.
Although this could be done with additional title format pattern throughout library, biography and other parts,
but imo it is not recommended.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #829
So, I've been digging around the forums and reddit again as I'm trying to use foobar and the Georgia-ReBORN theme again but unfortunately I have either overlooked what the solution may be, or I just haven't found it.

Essentially, when using the Georgia-ReBORN theme foobar will constantly go "Not Responding" if I start using the search bar and I cannot seem to find an apparent fix to this issue.

I have done a clean, non-portable install of foobar a couple of times and then proceeded to follow the instructions for the non-portable addition of this theme to foobar, but the issue still seems to persist. I've gone and done this clean installation again using the 32bit version of foobar but unfortunately even then I'm still having the issue appear whenever I try and use the search bar.

When I open up the console in foobar and I hit "enter" to begin searching for the track I want to play, or begin deleting characters to type in a new word, it freezes up and goes into "Not Responding" mode again, but nothing is shown in the console for me to provide as a log or anything or narrow down what the issue could be.

I wanted to ask if any of y'all know how to deal with this issue if you've encountered it before, or if it's just something I'd need to wait for the next release of ReBORN to have it be cleared up. Thank you!

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #830
Is there a way to show album covers only, instead of album and tracks?

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #831
Hi @SnappDragon10,

I have never heard of such issue or encountered it...
Do you mean the `Playlist Search`, i.e top Menu > Edit > Search or Ctrl + F ?
If so, it's working just fine.

It seems there is an issue with your foobar but not with Georgia-ReBORN.
Are you using a third-party firewall? Maybe it is blocking your foobar or maybe you have used
additional user-components that could trigger this issue.

Try to install the latest foobar 32-bit version as PORTABLE on your desktop with the latest DEV version from here:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip
and just use the original files for testing.

-TT



Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #832
Hi @nputra,

- for the Playlist when no top menu panel buttons are active ( if one is active, click on it again ):
  Right click for context menu > Collapse/Expand > Auto.

- for the Library when top Menu > Library is active:
  Right click for context menu > Change layout to full.

-TT

 

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #833
Thank you for the information, TT. That helped a lot.

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #834
hi TT i am using Georgia-ReBORN_v3.0-RC2 is this the latest release

how do i get the pictures to change
been playing with it all day  :)


Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #836
i am using the georgia reborn as it appear in your signature all i see is album art

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #837
Your answer does not help and I still do not know what you want...

If you want to cycle through album art images of the album and you have additional scanned images ( booklet ),
you need to use these directory structures:

( Excerpt taken from the upcoming documentation )

Spoiler (click to show/hide)

If you have this directory structure, placed and named your images correctly, you can then use the mouse wheel
on the large album art ( on the left side of the player ) to cycle through them.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #838
thank you TT for the great work  :) now I have played with it sorry for all the silly questions that I asked just 1 more i am using Georgia-ReBORN_v3.0-RC2 is that ok

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #839
thank you TT for the great work  :) now I have played with it sorry for all the silly questions that I asked just 1 more i am using Georgia-ReBORN_v3.0-RC2 is that ok

Yes, it is "OK" to use the v3.0-RC2 version from the Github Release:
https://github.com/TT-ReBORN/Georgia-ReBORN/releases

The DEV version has newer code, with latest features, improvements and bugfixes.
If you want to try the DEV version, you can obtain it from the Github main page:
https://github.com/TT-ReBORN/Georgia-ReBORN
At the top, you click on the <> green "Code" button and "Download ZIP".
Or download it directly from this link here:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

The Georgia-ReBORN_v3.0-Final will be released when I finished the website with its documentation.
Once this is done, there will be regular Georgia-ReBORN release versions.

-TT


Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #840
hi TT 1 final question as I messed up big time how do i stop it going full screen please

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #841
To exit fullscreen mode, click on the 🗖 button on the top-right corner of the player 🗕 🗖 ✖
or just press F11 ( to enter or exit fullscreen ).

If you maximized the player, double click somewhere on the top menu bar.
Double clicking on the top menu bar also maximizes or resumes the player size.

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #842
okay thank you

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #843
hi TT as I am getting old i struggle to see the player controls all i require is a play button pause button and stop button all made larger like in the screenshots don't need to be at top but is it possible

many thanks telboy

p.s the screenshots is of foobar 2.1.5 (x86) using a jsscript

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #844
Hi @telboy1812,

try top Menu > Options > Player controls > Lower bar > Transport button size
and for fonts in general, it is top Menu > Options > Font size.

If you have the latest DEV version, it has implemented mouse wheel interface scaling
where you can automatically adjust the fonts and buttons sizes via mouse wheel:
Spoiler (click to show/hide)

-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #845
all sorted thank you  :)

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #846
hi TT sorry to be a pain but I am using Georgia-ReBORN-master but where do find the spoiler

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #847
Sorry, but I have no idea what you are talking about...
You always write cryptic and unfortunately I do not have the ability to read peoples minds.

hi TT sorry to be a pain but I am using Georgia-ReBORN-master but where do find the spoiler

Georgia-ReBORN-master is the DEV version.

If you mean the "Spoiler" in the posts written above, you just click on them like this one:
Spoiler (click to show/hide)


-TT

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #848
Hey guys using the latest DEV build and FB 2.1.5.

I keep receiving the following spidermonkey error.   It happens anytime, and once it happens and i refresh its almost bound to happen again within seconds.  Any insight would be great:

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-DEV by TT)
CreateImage failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: pl-list-header.js
Line: 390, Column: 21
Stack trace:
  draw_normal_header@pl-list-header.js:390:21
  draw@pl-list-header.js:378:9
  on_paint@pl-list.js:309:27
  on_paint@pl-callbacks.js:66:15
  drawPanels@gr-main.js:424:13
  drawMain@gr-main.js:328:8
  on_paint@gr-initialize.js:74:9

Re: Georgia-ReBORN - A Clean foobar2000 Theme

Reply #849
Secondary question: 

Is it possible to have the choice on country to always show the abbreviated version or the full name?  IE.  Always show CA or always show Canada, regardless if the metadata in the country field is full or abbreviated?  Well anything is possible with development but is it a feature anyone else would want as well?  :)