general tip for anyone else who may be experiencing panel crashes or SMP performance issues.

via @Regor (big thanks!)
in FB prefs>advanced>search "heap"
(under spider monkey panel) set Maximum Heap Size number by entering 999999999999 (it will auto populate with your max)

Quote from: mjm716 on 2023-02-11 15:58:22

general tip for anyone else who may be experiencing panel crashes or SMP performance issues.

via @Regor (big thanks!)
in FB prefs>advanced>search "heap"
(under spider monkey panel) set Maximum Heap Size number by entering 999999999999 (it will auto populate with your max)

No, this is one of the worst advices I've seen and nobody should *ever* follow it if they want their SMP (and fb2k by extension) to remain stable.

What this "general tip" does, is it effectively removes all limits on RAM usage by SMP. Problem being that the same RAM is used by fb2k and other components as well. So, what will happen, is that after some time fb2k process will run out of memory, because SMP will use up every last bit of it, and fb2k will crash randomly during memory allocation (which can happen in fb2k itself, in other components or in SMP itself). And by crash I mean literal crash to desktop, not a script crash in SMP.

TLDR: do *not* ever do this. It will break your fb2k with almost 100% certainty.

PS: this "tip" makes scripts work better, because it almost totally disables garbage collection (i.e. cleanup of the stuff that uses RAM), it's akin to removing breaks from the car that runs downhill to make it go faster...

Error: Spider Monkey Panel v1.6.1 ({B48F5B98-0687-4D8A-84E5-B5E3271D364B})
FbMetadbHandleList_Constructor failed:
allocation size overflow

What this "general tip" does, is it effectively removes all limits on RAM usage by SMP. Problem being that the same RAM is used by fb2k and other components as well. So, what will happen, is that after some time fb2k process will run out of memory, because SMP will use up every last bit of it, and fb2k will crash randomly during memory allocation (which can happen in fb2k itself, in other components or in SMP itself). And by crash I mean literal crash to desktop, not a script crash in SMP.

FB memory crashes regularly via SMP

You are conflating two different issues:
- SMP script crash: popup "your script uses too much memory X/Y" with SMP panel turning red. The player itself continues working normally and panel can be restarted.
- fb2k crash: whole player crashes. I.e. you can't continue using player and have to actually restart the application.

That "tip" turns the first scenario (SMP crash) into the second scenario (fb2k crash)

Well my theme is using "some" fonts and after the 20th window.Reload or so when using the new custom menu I've implemented,

Error: Spider Monkey Panel v1.6.2-dev+7c0928bf ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v2.3.0 by TT)
include failed:
Font failed:
WinAPI error:
  CreateFont failed with error (0x0):
    Function failed, but returned a `SUCCESS` error code, which is usually caused by a bugged WinAPI. One such case is when process runs out of GDI handles and can't create a new GDI object.

I don't think it's an ram issue but a GDI handle limit and good old GDI is just the culprit.
So if I close and reopen the new custom menu ( based on your Material design )
about 275 times ( didn't use window.Reload for this test ), and the menu uses one gdi.Font object:

Quote from: TT on 2023-02-14 00:47:17

I don't think it's an ram issue but a GDI handle limit and good old GDI is just the culprit.
So if I close and reopen the new custom menu ( based on your Material design )
about 275 times ( didn't use window.Reload for this test ), and the menu uses one gdi.Font object:

So just so I understand, the menu is calling gdi.Font everytime it initializes? Definitely those fonts need to be cached so you aren't creating them every time the menu is expanded. If you look at my original code I'm creating all the fonts I plan to use, and then just passing those in when creating the underlying controls, instead of calling gdi.font once for each control (which it sounds like you might be doing).

Elia might have deleted their post but if you're doing something different than I think, a memoized function that only calls gdi.font could be another really good idea.

Quote from: TT on 2023-02-14 00:47:17

I don't think it's an ram issue but a GDI handle limit and good old GDI is just the culprit.
So if I close and reopen the new custom menu ( based on your Material design )
about 275 times ( didn't use window.Reload for this test ), and the menu uses one gdi.Font object:

So just so I understand, the menu is calling gdi.Font everytime it initializes? Definitely those fonts need to be cached so you aren't creating them every time the menu is expanded. If you look at my original code I'm creating all the fonts I plan to use, and then just passing those in when creating the underlying controls, instead of calling gdi.font once for each control (which it sounds like you might be doing).

Elia might have deleted their post but if you're doing something different than I think, a memoized function that only calls gdi.font could be another really good idea.

function font(name, size, style) {
	let font;
	try {
		font = gdi.Font(name, Math.round(scaleForDisplay(size)), style);
	} catch (e) {
		console.log('\nFailed to load font >>>', name, size, style);
	}
	return font;
}

function _gdiFont(name, size, style) {
	let id = name.toLowerCase() + '_' + size + '_' + (style || 0);
	if (!fonts[id]) {
		fonts[id] = gdi.Font(name, size, style || 0);
	}
	if (fonts[id].Name !== name && fonts.notFound.indexOf(name) === -1) { // Display once per session, otherwise it floods the console with the same message...
		fonts.notFound.push(name);
		fb.ShowPopupMessage('Missing font: ' + name + '\n\nPlease install dependency found at (a restart is required):\n' + folders.xxx + '_resources', window.Name);
		console.log('Missing font: ' + name);
	}
	return fonts[id];
}

// Add caching
Object.defineProperty(fb, 'tfCache', {
  enumerable: false,
  configurable: false,
  writable: false,
  value: {}
});

// Augment fb.TitleFormat() with 'Expression' property and add caching
{
	const old = fb.TitleFormat;
	fb.TitleFormat = function TitleFormat() {
		const bCache = fb.tfCache.hasOwnProperty(arguments[0]);
		const that = bCache ? fb.tfCache[arguments[0]] : old.apply(fb, [...arguments]);
		that.Expression = arguments[0];
		if (!bCache) {fb.tfCache[arguments[0]] = that;}
		return that;
	}
}

Btw, is it possible if SMP could delete created font objects from cache on window.Reload?

- Then they tried changed the settings, following my suggestion, to find where the problem lied; since fb2k should not crash with the default config as you noted. They had no more FbMetadbHandleList_Constructor crashes AND no more fb2k crashes. So in fact crashes were gone with the debugging setting, not the opposite.

class BaseControl {
	constructor(x, y, label) {
		/** @protected */ this.x = x;
		/** @protected */ this.y = y;
		/** @protected */ this.label = label;
		this.state = {};
		this.doubleClickTime = 300;
		this.lastClickTime = null;
		this.focus = false;
		this.disabled = false;
		this._hovered = false;
		this.font = ft.popup;
		this.popupFontSize = pref.layout === 'artwork' ? pref.popupFontSize_artwork : pref.popupFontSize_default;
		this.closeBtn = this.label === '\u2715';
		/** @protected @private */ this.i = gdi.CreateImage(1, 1);
		/** @protected */ this.g = this.i.GetGraphics(); // GdiBitmap used for MeasureString and other functions
	}

function initCustomThemeMenu(playlist_section, main_section, library_section, biography_section, info) {
	if (pref.libraryLayout   === 'full') pref.libraryLayout   = 'normal'; setLibrarySize();
	if (pref.biographyLayout === 'full') pref.biographyLayout = 'normal'; setBiographySize();
	if (pref.lyricsLayout    === 'full') pref.lyricsLayout    = 'normal'; resizeArtwork(true);

	controlList = [];

	const margin = scaleForDisplay(40);
	const baseX = displayBiography || pref.displayLyrics ? ww * 0.5 + margin : !displayPlaylist && !displayLibrary && !displayBiography ? noAlbumArtStub ? ww * 0.3 : albumArtSize.x + margin : margin;
	let x = baseX;
	let y = geo.topMenuHeight + margin * 0.75;

	const mainSection      = ['main_bg', 'main_bar', 'main_text', 'main_btns', 'main_btns2', 'main_style'].includes(main_section);
	const playlistSection  = ['pl_bg',   'pl_text1', 'pl_text2',  'pl_misc', 'pl_btns'].includes(playlist_section);
	const librarySection   = ['lib_bg',  'lib_text', 'lib_node',  'lib_btns'].includes(library_section);
	const biographySection = ['bio_bg',  'bio_text', 'bio_misc',  'bio_btns'].includes(biography_section);

	const menu = new DropDownMenu(x, y, 'Main', ['Bg', 'Bar', 'Text', 'Btns', 'Btns 2', 'Style'], 0);
	controlList.push(menu);
	x += controlList[controlList.length - 1].w + 1; controlList.push(new DropDownMenu(x, y, 'Playlist',  ['Bg', 'Text', 'Text 2', 'Misc', 'Btns'], 0));
	x += controlList[controlList.length - 1].w + 1; controlList.push(new DropDownMenu(x, y, 'Library',   ['Bg', 'Text', 'Node', 'Btns'], 0));
	x += controlList[controlList.length - 1].w + 1; controlList.push(new DropDownMenu(x, y, 'Biography', ['Bg', 'Text', 'Misc', 'Btns'], 0));
	x += controlList[controlList.length - 1].w + 1; controlList.push(new DropDownMenu(x, y, 'Options',   ['Info', '', 'Theme 01', 'Theme 02', 'Theme 03', 'Theme 04', 'Theme 05', 'Theme 06', 'Theme 07', 'Theme 08', 'Theme 09', 'Theme 10', '', 'Reset'], 0));
	x += controlList[controlList.length - 1].w + 1; controlList.push(new DropDownMenu(x, y, '\u2715',    ['']));
	x = baseX;
	y += menu.h + margin * 0.75;

	switch (true) {
		case playlistSection:  customPlaylistColors(x, y, ww * 0.5, wh - geo.topMenuHeight - geo.lowerBarHeight, playlist_section); break;
		case mainSection:      customMainColors(x, y, ww * 0.5, wh - geo.topMenuHeight - geo.lowerBarHeight, main_section); break;
		case librarySection:   customLibraryColors(x, y, ww * 0.5, wh - geo.topMenuHeight - geo.lowerBarHeight, library_section); break;
		case biographySection: customBiographyColors(x, y, ww * 0.5, wh - geo.topMenuHeight - geo.lowerBarHeight, biography_section); break;
		case info:             customThemeInfo(x, y, ww * 0.5, wh - geo.topMenuHeight - geo.lowerBarHeight); break;
	}
}

Both versions are in the first post, it is the second download link right beneath Beta 11 ;-)
@MordredKLB, check also my PM.

ft.cached =  gdi.Font('fontAwesome', 22,  0);
// and then
ft.cached =  gdi.Font('fontAwesome', 30,  0);

setInterval(() => {
	displayCustomThemeMenu = true;
	displayPanel('playlist');
	initCustomThemeMenu('pl_bg');
	window.Repaint();
}, 500);

It will crash after some time with the WinAPI font error message...

		this.font.items.forEach(v => {
			const style = pptBio[v[0]] < 4 ? pptBio[v[0]] : (pptBio[v[0]] - 4) * 2;
			this.font[v[1]] = gdi.Font(pptBio[v[0]] < 4 ? this.font.main.Name : 'Segoe UI Semibold', this.font.main.Size, style);
		});

among others. gdi.Font is called 20x in that one single getFont from the on_size generated in setBiographySize. I'm guessing if you just displayed the biography panel and then resized the window multiple times you'd encounter the exact issue.

You should determine if setBiographySize should even be called first of all, and @WilB should probably use his own memoized version instead of gdi.Font inside getFont, and probably FSM itself should memoize the actual gdi.Font function if at all possible so that us programmers can continue doing dumb things

function initCustomThemeMenu(playlist_section, main_section, library_section, biography_section, info) {
	if (pref.libraryLayout   === 'full') pref.libraryLayout   = 'normal'; setLibrarySize();
	if (pref.biographyLayout === 'full') pref.biographyLayout = 'normal'; setBiographySize();
	if (pref.lyricsLayout    === 'full') pref.lyricsLayout    = 'normal'; resizeArtwork(true);

Do you mean this section here?

Code: [Select]

function initCustomThemeMenu(playlist_section, main_section, library_section, biography_section, info) {
	if (pref.libraryLayout   === 'full') pref.libraryLayout   = 'normal'; setLibrarySize();
	if (pref.biographyLayout === 'full') pref.biographyLayout = 'normal'; setBiographySize();
	if (pref.lyricsLayout    === 'full') pref.lyricsLayout    = 'normal'; resizeArtwork(true);

Haha, forgot the curly braces xD happens if you code till 3am and you should be sleeping.
But still as I've written, if you comment this out it still crashes with the interval...

		/** @protected @private */ this.i = gdi.CreateImage(1, 1);
		/** @protected */ this.g = this.i.GetGraphics(); // GdiBitmap used for MeasureString and other functions

let __i_ = undefined;
let __g_ = undefined;

class BaseControl {
	constructor(x, y, label) {
                . . . clipped other class members here
		/** @protected */ this.g;
		if (!__i_) {
			__i_ = gdi.CreateImage(1, 1);
			__g_ = __i_.GetGraphics(); // GdiBitmap used for MeasureString and other functions
		}
		this.g = __g_;
	}

	destructor() {
	}