Skip to main content

Topic: foo_dsp_effect (Read 113216 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • mudlord
  • [*][*][*][*][*]
  • Developer (Donating)
foo_dsp_effect
Reply #150
Again, I failed to see the logic in adding said features.

  • markanini
  • [*][*][*][*][*]
foo_dsp_effect
Reply #151
Please consider effect for adding a small delay in either channel controlled by a custom tag field. I often find commercial releases with 10-20 ms delay between L-R.

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #152
Again, I failed to see the logic in adding said features.


Hmmm... in post #135 you said that you can add bypassing when effect value is set to "0%". You wondered about DUI elements ncessity, but bypassing was accepted proposition. I will be pleased even if you could add only bypassing at 0% especially in Playback Rate Shift effect  . Without DUI/CUI elements  . I already explained why bypassing at 0% matters - in this case there's no unnecessary filtering and resampling added to output when effect is not used (set to 0%).

  • mudlord
  • [*][*][*][*][*]
  • Developer (Donating)
foo_dsp_effect
Reply #153
Please consider effect for adding a small delay in either channel controlled by a custom tag field. I often find commercial releases with 10-20 ms delay between L-R.


You mean differing behaviour IF such tags exists, and if not, acts as normal?

  • markanini
  • [*][*][*][*][*]
foo_dsp_effect
Reply #154
Please consider effect for adding a small delay in either channel controlled by a custom tag field. I often find commercial releases with 10-20 ms delay between L-R.

Oops, the measrements I was reading were reported in ?m, the delay in ms is more like 0.05 -0.1 ms. Still it's enough delay to skew the apparent stereo field.

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #155
This delay between channels is added intentionally - in purpose of widening stereo basis. Stereo widening effects (like making stereo from mono signal) are always based on adding interchannel delay. So such DSP will be destroying effect rather than sound tuning effect.

  • lvqcl
  • [*][*][*][*][*]
  • Developer
foo_dsp_effect
Reply #156
Please consider effect for adding a small delay in either channel controlled by a custom tag field. I often find commercial releases with 10-20 ms delay between L-R.

It is possible to do this with foo_dsp_yac (but IIRC it works only for stereo: no multichannel support).

  • markanini
  • [*][*][*][*][*]
foo_dsp_effect
Reply #157
This delay between channels is added intentionally - in purpose of widening stereo basis. Stereo widening effects (like making stereo from mono signal) are always based on adding interchannel delay. So such DSP will be destroying effect rather than sound tuning effect.

I'm talking about real stereo recordings with a consistent inter-channel delay, possibly due to a tape transport issue. One such example is Yes - Close to The Edge by Rhino.

Please consider effect for adding a small delay in either channel controlled by a custom tag field. I often find commercial releases with 10-20 ms delay between L-R.

It is possible to do this with foo_dsp_yac (but IIRC it works only for stereo: no multichannel support).

I could work with that, thanks!

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #158
I downloaded latest version of "foo_dsp_effect" but bypassing at "0%" is still missing... It's a matter of sound quality, not just my whims...

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #159
OK, in newest version (released on 2012-06-25) there is bypassing implemented and it works properly  Many thanks !!

  • Fandango
  • [*][*][*][*][*]
foo_dsp_effect
Reply #160
I really like the PRE_EMPHASIS feature, but there was one thing that was bothering me and it needed testing on my behalf: if this tag field is present and set to true, will it be in effect when converting the audio files?

My results are pleasing: when converting to a lossy format, it de-emphasis will be applied. When converting to a lossless format, it will not! And when using the dynamic range meter plugin, it again will be applied. When bit-comparing identical files, with and without the tag field, they are recognised as identical. Which all in all is exactly how it should be. 

  • kode54
  • [*][*][*][*][*]
  • Administrator
foo_dsp_effect
Reply #161
If it's a DSP filter, do you have it in your chain? If not, do you have additional processing enabled when converting?

  • CoRoNe
  • [*][*][*]
foo_dsp_effect
Reply #162
I don't know anything about foo_dsp_effect its inner workings, but why does Pitch Shift (and perhaps other effect-filters too, I don't know) change the duration?

Original test sample: 25.500s / 1124550 samples
SoundTouch plugin: 25.488s / 1124032 samples
Effects DSP (Pitch Shift) plugin: 25.479s / 1123640 samples
Avisynth (TimeStretch): 25.500s / 1124550 samples(!)

For everyday listening it's no problem, but for encoding I obviously prefer Avisynth at the moment.
DC-Bass Source Mod: http://reino.degeelebosch.nl

  • Fandango
  • [*][*][*][*][*]
foo_dsp_effect
Reply #163
If it's a DSP filter, do you have it in your chain? If not, do you have additional processing enabled when converting?

No and no. It's not in the DSP chain and there's no need to enable Processing when converting. So I don't need an extra preset and I don't have to sort out pre-emphased records for converting seperately, which is great! It just works anyway just because of the tag field. :thumbs: All I have to take care of is adding the tag field when adding a record to my library.

Would be great if the plugin supported the "FLAG PRE" line in embedded cue sheets, not that I use embedded cue sheets anymore... but I think it would be a good addition to the plugin.
  • Last Edit: 12 August, 2012, 12:30:09 PM by Fandango

  • mudlord
  • [*][*][*][*][*]
  • Developer (Donating)
foo_dsp_effect
Reply #164
there is no means atm to parse cuesheets, thats something Peter will need to add.

  • mudlord
  • [*][*][*][*][*]
  • Developer (Donating)
foo_dsp_effect
Reply #165
I don't know anything about foo_dsp_effect its inner workings, but why does Pitch Shift (and perhaps other effect-filters too, I don't know) change the duration?

Original test sample: 25.500s / 1124550 samples
SoundTouch plugin: 25.488s / 1124032 samples
Effects DSP (Pitch Shift) plugin: 25.479s / 1123640 samples
Avisynth (TimeStretch): 25.500s / 1124550 samples(!)

For everyday listening it's no problem, but for encoding I obviously prefer Avisynth at the moment.


Hmm, AVISynth returns complete samples?
In the effect source for dsp_soundtouch.cpp, for get_latency, I return the amount of buffered samples divided by the samplerate to get current latency of the DSP. I run a buffer to basically get samples, and output them. I guess in the process there is a bug of sorts?

https://github.com/mudlord/foobar2000/blob/..._soundtouch.cpp
  • Last Edit: 15 August, 2012, 12:57:06 AM by mudlord

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #166
Hello again.

I'm not a programmer, so I kindly ask you mudlord - would it be complicated for you, to add one more feature to foo_dsp_effect library? I think about possibility of preserving information about preferred Playback Rate Shift, Pitch Shift and Tempo Shift for certain files in tags. It could be done like this: user manually adds tag field to his file - for exampla tag named "PRS" (for "Playback Rate Shift") and puts there a value - for example "+5" or "-10". Active DSP reads tag field and automatically applies shift. If values in fields will be greater than maximum values that are possible ("-150", "+300") for certain DSP, then the maximum value could be used - with optional warning from console. No autotagging - only manuall tagging done by user, then autoloading info. Optionally there could be additional check box in DSP configuration dialog: "automatically use shift values from tags". That would be perfect

Regards
Epic

  • Rollin
  • [*][*][*][*]
foo_dsp_effect
Reply #167

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #168
Hmmm.. It could solve my problem but to be honest I think it's too complicated or I'm just to lazy to configure DSP chains for every single track where I decide to change playback rate... At the moment it's more than 20 tracks. foo_dsp_effect has feature similar as requested in my previous post - setting up de-emphasis filter based on tags. So I think that implementation of my request shouldn't be a big problem.

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #169
Could I ask for any "developement news" for this component ? Is it posssible to add feature from my post : http://www.hydrogenaudio.org/forums/index....mp;#entry806411  ?

  • mudlord
  • [*][*][*][*][*]
  • Developer (Donating)
foo_dsp_effect
Reply #170
current news: depends on my motivation to add features that I personally use. Since I don't use often features like this apart from de-emphasis, its very low on the current priority list.

  • EpicForever
  • [*][*][*][*][*]
foo_dsp_effect
Reply #171
Well, OK, but I understand that you have the procedure to read tags already coded. Only thing is to add it to other DSP and choose names for user tags... Numbers (values of tags) are just numbers, as the ones on fader. But I understand that you are doing it in your free time

  • Eli
  • [*][*][*][*][*]
foo_dsp_effect
Reply #172
Does foo_dsp_effect's de-emphasis recognize dBpoweram's pre-emphasis flag? If not, could this feature be added?

  • Rollin
  • [*][*][*][*]
foo_dsp_effect
Reply #173
Does foo_dsp_effect's de-emphasis recognize dBpoweram's pre-emphasis flag?


Quote
The tag "PRE_EMPHASIS" must be used on content which is supported by FB2Ks decode processor services, for this to work. Pre-emphasis can be signified in your media with the values "1" or "0".

  • Eli
  • [*][*][*][*][*]
foo_dsp_effect
Reply #174
I saw that but I'm not at home with my FLAC collection and don't know if this is the tag name dBpoweramp uses to flag pre-emphasis or not.