Re: foo_dsp_effect
Reply #536 – 2022-12-11 14:54:24
Try [0.50 beta 5] An improvement with reservations. I think it's now a problem of clarity in the user interface (and bear in mind I have only looked at the tempo section, not pitch nor speed, but I suspect the comments apply similarly).Play a track with the tempo_amt tag set and tempo control not enabled, it plays at the original tempo. Okay. Play the track with tempo control enabled, it plays at the tempo adjusted as per tempo_amt. Okay, but the UI still shows "0.00%" and it would be useful for the actual adjustment to be displayed. Disable tempo control and playback reverts to original tempo. Okay. Re-enable tempo control, playback does not resume tempo_amt but takes the UI setting. Okay-ish, but not intuitive. With track playing at temp set by tempo_amt, make any adjustment to the UI setting and that overrides tempo_amt. Okay-ish, but if tempo_amt is (say) +10% and the user wants to make a -5% adjustment to the actual live tempo that means a setting of +5% not -5%. I think the shortcomings can be overcome very simply: take the tempo_amt value and instead of acting on it directly, use it to preset the UI setting (both percentage display and slider, and whether enabled or not), then the user gets to see exactly what's going on. I'm undecided what to do at the end of the track - keep the setting as is or reset to 0%... maybe that could be an option tick box. Add to that some buttons which increment/decrement the current percentage setting (again reflected in the percentage display and the slider), eg: [ -10% ] [-3%] [-1%] [-0.5%] [Reset] [+0.5%] [+1%] [+3%] [+10%] ...and I'll be ecstatic. I think somebody else wanted similar. I can't imagine anyone needing finer control than that but if they do there's always direct typed input. To cover all user requirements, maybe the buttons could be configurable in Preferences. With grateful thanks for the continued support.Incidentally, VirtualDJ's default settings automatically adjusts the next track's playback tempo (as auto-extracted on load) to match the measured beat rate of the current playing track. Great for clubbing no doubt, not so clever if you're playing a jive followed by a waltz! It wasn't until I realised what was going on that I was able to delve into the settings and disable it! Beat detection in VirtualDJ is remarkably good... but not perfect, particularly when it comes to ballroom music, and can't be totally trusted.