Skip to main content

Topic: WSH Panel Mod script discussion/help (Read 844115 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2325
i bodged my spectrogram seekbar fix earlier. it was worse than the marker not showing on shorter tracks.  right click>Update script to try again. depending on size of panel, you may see a few percent CPU usage. 

@falstaff, thanks for fixes. i note the playlist header doesn't update when drag/drop adds tracks.

also a feature request rather than a bug. can you track the position of dropped tracks so they can be inserted between existing items in the playlist? i'm not sure if this is possible but no harm in asking.
  • Last Edit: 01 May, 2013, 09:43:28 AM by marc2003

  • Falstaff
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2326
@falstaff, thanks for fixes. i note the playlist header doesn't update when drag/drop adds tracks.
also a feature request rather than a bug. can you track the position of dropped tracks so they can be inserted between existing items in the playlist? i'm not sure if this is possible but no harm in asking.


thanx, refresh of the top playlist header will be fixed next (no refresh too on items add or remove)
for the insert point, i'll check that asap

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2327
another couple of requests   

when you have a short playlist with no scrollbar, could the group header text align to the last "proper" column - in this example, Time.

can you make your mood column heart stay red when the item is playing/selected?
  • Last Edit: 01 May, 2013, 10:34:53 AM by marc2003

  • ehrgeiz
  • [*]
WSH Panel Mod script discussion/help
Reply #2328
@marc2003's now playing script:
neither crop center nor crop top are imho good solutions

changing line 1103 of common7.js
Code: [Select]
var sy = type == "crop top" ? 0 : Math.round((img.Height - ch) / 2);

to
Code: [Select]
var sy = type == "crop top" ? 0 : Math.round((img.Height - ch) / 4);


gives a much more better crop focusing on the upper part of the picture (if you select the crop on center, thats what i changed here; actually i wanted to change the crop top but alas i'm too stupid to make it work)

  • godrick
  • [*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2329
marc2003, I think something recently (perhaps in an update in the last day or so) changed in common7 that results in no information found for artists in your musicbrainz script, and strange behavior of the "update script" action. .  I tried the "update script" action in one of your scripts, and it always returns that an update was available, downloaded, and asks to restart foobar2000.  It will continue to report that a new script was available and downloaded when I try "update script" even if I had just done so and restarted foobar2000, and it will continue to do so every time I now hit "update script".

None of the updated common7 files fixed the musicbrainz script.  I then tried deleting all json files in my stored image folders - no change in behavior.  I then reverted back to a April 3 version of common7 and the musicbrainz script now works.

Thanks very much for such great scripts!
  • Last Edit: 01 May, 2013, 11:01:31 AM by godrick

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2330
Quote
neither crop center nor crop top are imho good solutions


can you explain why, preferably with a screen shot? i really don't understand what the problem is. 

@godrick, thanks for pointing out i broke the Update script feature. i did this earlier today.  i think i've fixed it. of course another update/restart is required.

as for musicbrainz, not working, i have it active in my layout and it's been fine through all my recent changes?? the panel script hasn't changed so all i can suggest is holding shift when right clicking the panel>properties>clear. that will reset any settings.
  • Last Edit: 01 May, 2013, 11:18:46 AM by marc2003

  • godrick
  • [*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2331
Updates now works, and musicbrainz script works with the common7 that was automatically downloaded.  All is good - thanks again!

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2332
@falstaff, a couple more things:



overlapping text and inaccurate calcuation of group length.

  • godrick
  • [*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2333
marc2003, it looks like I was incorrect in thinking that my musicbrainz issue was fixed with the update script fix.  The old common7 created new json files for the artist I was viewing and I didn't check to see if the latest common7 would create new json files for another artist.  When I checked with a different artist that did not have existing json files, the new common7 did not create them.

In looking over the latest and old (from April 3) common7 scripts, I noticed the following:

for the April 3 version of common7,
    - the echoed url for links was
Code: [Select]
http://www.musicbrainz.org/ws/2/artist/8347dd6d-b9a2-4e96-a610-d1ed67b189f1
?inc=url-rels&fmt=json

    - the echoed url for releases was
Code: [Select]
http://www.musicbrainz.org/ws/2/release-group?artist=8347dd6d-b9a2-4e96-a610-d1ed67b189f1
&limit=100&offset=0&fmt=json


for the latest common7,
    - the echoed url for links was
Code: [Select]
 http://search.musicbrainz.org/ws/2/artist/?query=artist:steve%20roach&fmt=json

    - the echoed url for releases was
Code: [Select]
 http://search.musicbrainz.org/ws/2/artist/?query=artist:steve%20roach&fmt=json


...and the results of the latest common7 musicbrainz urls echoes the following in the console:
Code: [Select]
Musicbrainz: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-GB" lang="en-GB">
  <head>
    <title>502 Bad Gateway</title>
    <link rel="stylesheet" href="/.proxy/httperror.css" type="text/css" />
  </head>
  <body>
    <div id="bg">
      <img src="/.proxy/MusicBrainzLogo-Q.png" />
    </div>
    <h1>Server being naughty</h1>
    <p>One of our servers appears to be misbehaving.&nbsp; Please try again later.</p>
    <p id="http">502 Bad Gateway</p>
  </body>
</html>


I cleared the panel and restarted each time I changed which common7 script I was using.  I echoed the urls from the end of the "musicbrainz" case in this.get = function().  It looks like something isn't right with this.musicbrainz_id in the lastest common7 script in my setup.

If this doesn't make sense, isn't what you are seeing or more info is needed, please let me know.

edit: tried to fix the url references
  • Last Edit: 01 May, 2013, 02:28:13 PM by godrick

  • Falstaff
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2334
@falstaff, a couple more things:

thanx

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2335
@godrick, fixed. right click>yada yada.
  • Last Edit: 01 May, 2013, 02:54:24 PM by marc2003

  • godrick
  • [*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2336
marc2003, you probably figured this out or have something better, but if I replace the following in the latest common7:
Code: [Select]
                this.musicbrainz_id = p.eval("$if3(%musicbrainz_artistid%,%musicbrainz artist id%," + p.read(fn1) + ",)");
                if (this.musicbrainz_id.length == 0) {


with the equivalent in the April 3 version of common7:
Code: [Select]
                this.musicbrainz_id = p.eval("$if3(%musicbrainz_artistid%,%musicbrainz artist id%,)");
                if (this.musicbrainz_id.length == 0) this.musicbrainz_id = p.read(fn1);
                if (this.musicbrainz_id.length == 0) {


...I can get the latest common7 to work

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2337
i thought i tested abusing $if3 like that but evidently not well enough. anyway, i did spot it before you posted.

and i think that server error could appear when doing any MBID lookup so i'm pretty sure that part wasn't my fault.
  • Last Edit: 01 May, 2013, 03:09:00 PM by marc2003

  • Falstaff
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2338
another couple of requests   

when you have a short playlist with no scrollbar, could the group header text align to the last "proper" column - in this example, Time.

can you make your mood column heart stay red when the item is playing/selected?


1. right text now aligned to the last column as pointed, will be available in v0.0.5 (release this evening or tomorrow...)
2. making group header more editable is one of the things i've planed with the use of my WSH inputbox script object , you'll have to wait a little to let me finish this part
3. edit: maybe but only if i can draw an outline around the heart to give contrast when bg colour on selected track is near to the red/pink colour used

EDIT:
v0.0.5 released (http://fav.me/d63owft)
  • Last Edit: 01 May, 2013, 05:33:56 PM by Falstaff

  • Falstaff
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2339
edit: one more thing...  can you make your mood column heart stay red when the item is playing/selected?


done for v0.0.6 that will be released tomorrow, here is the look of the new "heart" of the mood columns

  • Last Edit: 01 May, 2013, 06:07:09 PM by Falstaff

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2340
^nice.

still a problem with length calculation though in 0.0.5 (changelog says it's fixed?)



the time in the playlist header is right but not the group.

also, thanks for all your updates so far.

  • ehrgeiz
  • [*]
WSH Panel Mod script discussion/help
Reply #2341
Quote
neither crop center nor crop top are imho good solutions


can you explain why, preferably with a screen shot? i really don't understand what the problem is. 


there is no real problem, just my preference and i wanted to share.
if you do classic photography the "rule of thirds" is very common and a lot of pics are following these principles. the head/eyes is usually on the level of the upper line


if you do a top crop of a classic portrait half the face is cut of or overlayed by the trackinfo/albumcover (green-box)
if you do a center crop the eyes are nearly cut off (blue-box)
based on my experience a crop focusing on the upper third-line works very good for a lot of photos. (i used 16:9 ratio for the crop-boxes as my "now playing" panel is)



but of course it's not perfect either, maybe you do some face recognition and crop on those ;P

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2342
thanks for the clear explanation. i had no idea about of any of that.

Quote
actually i wanted to change the crop top but alas i'm too stupid to make it work)


just change the value of the 0 in this line you posted.

Code: [Select]
var sy = type == "crop top" ? 0 : Math.round((img.Height - ch) / 2);


that code is just a shorthand way of writing this.

Code: [Select]
if (type == "crop top") {
    var sy = 0;
} else {
    var sy = Math.round((img.Height - ch) / 2);
}



  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2343
new permanent link for my scripts: https://dl.dropboxusercontent.com/u/22801321/wsh/samples.zip
changelog link is still the same: https://dl.dropboxusercontent.com/u/2280132...h/changelog.txt

(i just moved it into a folder making it easier for me to update)

  • Dario
  • [*][*][*]
WSH Panel Mod script discussion/help
Reply #2344
Can anybody direct me to information required to make the Volbar sample (included in WSH Panel Mod) use a logarithmic scale instead of a linear?

  • marc2003
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2345
if you search this thread or the main WSH panel mod thread, i'm pretty sure you'll find what you're looking for.

(use the box on the bottom left to search within a thread)
  • Last Edit: 03 May, 2013, 08:54:01 AM by marc2003

  • Dario
  • [*][*][*]
WSH Panel Mod script discussion/help
Reply #2346
The things that were previously posted here didn't make much sense, sorry. However, reading this thread helped me a lot, so now I have everything figured out.

  • Bratman
  • [*][*][*]
WSH Panel Mod script discussion/help
Reply #2347
About the rule of thirds, this is the exact problem I had with the thumbs script, top was cutting off the bottom of thier heads and center was cutting off the top, thanks ehrgeiz. You should make this part of the script marc. Also is thumbs discontinued now? Now playing does everything thumbs can do and more??

  • Bratman
  • [*][*][*]
WSH Panel Mod script discussion/help
Reply #2348
Putting my "faux-developer" cap on for a moment . . .

So I have a choice between
(1) programming a C++ component from scratch
(2) updating a current C++ component whose source code is freely available.

If I was to do this, then
if I choose (1), then I can not bypass the limited DUI color usage options, therefore the advantages are minimal when compared to Facets (foo_facets_.
if I choose (2), then we open up a new world of exploration for DUI users and programmers, and can bypass foobar2000 built-in limitations, and help bridge the gap between "DUI" and "[Seemingly Abandonware] CUI"

I would choose (2).


(3)

Track down musicmusic and give him lots of money

  • derty2
  • [*][*][*][*][*]
WSH Panel Mod script discussion/help
Reply #2349
Bratman, I think we are going off topic and too deep into this man. . .

My initial comments on this were left at Post #2320 (if anybody wants to go and have a read).

Firstly, I would like to say:
I WAS WRONG . . . IT IS POSSIBLE to have a DUI panel with ONLY Filter columns by using foo_facets (Facets) component.

Secondly, my discussion was related to this concept:
Using WSH Panel Mod to create Library viewing panels with RGB color options, bypassing the DUI limitations. Also, it would have the added benefit of bridging the gap between DUI and CUI, considering that CUI is seemingly abandonware.

Continued development of CUI was not really part of my discussion.