Skip to main content
Topic: foo_discogs (Read 787660 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

TITLE feat. Artist

Reply #2550
I've searched the thread but failed to see any formatting for Title feat. Artist1, Artist2

I've got it to work but maybe someone has a more tested/robust one?

Thanks.

Code: [Select]
$multi_if($multi_strcmp(%<TRACK_CREDITS_ROLES>%,'Featuring'),%TRACK_TITLE% feat. $join(%<TRACK_CREDITS_ARTISTS_NAME>%, ),%TRACK_TITLE%)

Re: foo_discogs

Reply #2551
Thx man, using this one already for many years...what a life saver...
Best plugin ever.

Re: TITLE feat. Artist

Reply #2552
Code: [Select]
$multi_if($multi_strcmp(%<TRACK_CREDITS_ROLES>%,'Featuring'),%TRACK_TITLE% feat. $join(%<TRACK_CREDITS_ARTISTS_NAME>%, ),%TRACK_TITLE%)
I spoke too soon. It's creating multiple values for the title of the same name if the release doesn't contain other roles it seems. Any help here would be great. Thanks.

Re: foo_discogs

Reply #2553
Heh, funny, I have trouble getting feat artist injection to work correctly too...
Maybe someone is keen to lend a syntax-hand... :D

I had this for a while - which is meant to add 'DISCOGS_CREDIT_FEATURING' to the title, IF it exists:

$if(%DISCOGS_CREDIT_FEATURING%,%TRACK_TITLE%' (Ft. '%DISCOGS_CREDIT_FEATURING%')',%TRACK_TITLE%))

Turns out, this only partially works... i.e. if I tag it fresh, it does not work... but, if I re-run the same through foo_discogs, it then, and only then (on 2nd run) does add the (Ft. '%DISCOGS_CREDIT_FEATURING%') tag to the title correctly.
If you see what might be causing this, and maybe even how to correct it so it does work on first run, that would be swish.
Churs.
c.

Re: foo_discogs

Reply #2554
only then (on 2nd run) does add the (Ft. '%DISCOGS_CREDIT_FEATURING%') tag to the title correctly.
Thanks for the code. It works for me 1st time. I've updated foobar2000 to the latest beta build v1.4 beta 11. Are you sure you have the lastest plugin for this installed?

I slightly modified it to suit my replace ' (Original Mix)' with blank setting and 'feat.' instead of your 'Ft.'

Code: [Select]
$pputs(title,$replace(%TRACK_TITLE%, '('Original Mix')',))$if(%DISCOGS_CREDIT_FEATURING%,$pget(title)' feat. '%DISCOGS_CREDIT_FEATURING%,$pget(title)))



Re: foo_discogs

Reply #2555
Heya,
yea, it does work if the files have discogs tag syntax previously... try tagging completely empty files, and it will fail to inject the feat artist correctly. So you will need to run it once, to get the main tags, then run it again where it injects the feat artist on top. Odd & an annoyance, but works, once just has to remembeer to run the foo_discogs tagger twice on each new tagged release...

ah, I think I know what it's due as well now... but no idea how to fix it.
When running first, the %DISCOGS_CREDIT_FEATURING% field on file is empty, so once it's run, it's filled correctly, and only then does the $if engage... just a hunch, and not sure why it's not detecting the incokming foo_discogs data correctly here, but needs it to sit in file tags seemingly for this to work.
c.



Why is the Composed By role not fetched ?

Reply #2558
Good evening everyone,

Here is another release, where a Composed By role is not fetched correctly by the fine component (while the same formatting string works great on other releases since months).
I'm talking about tracks 6-12. Tracks 1-5 will work.
The API shows all the Composed By correctly.

What is the difference why the fine component can not fetch the data?

Re: foo_discogs

Reply #2559
Good Sunday everyone,

I'm trying to get the "Text By" roles for each song of this release => https://www.discogs.com/x/release/9899755

But I cannot fetch it, although the API shows its there for each track. => https://api.discogs.com/releases/9899755

I've used the default formatting String and grabbed for "Text By", but no tag is written by the fine component.

Anybody an idea?
Use the default "DISCOGS_CREDIT_VOCALS" string and replace "Vocals" with "Text By". Works fine for me.

Good evening everyone,

Here is another release, where a Composed By role is not fetched correctly by the fine component (while the same formatting string works great on other releases since months).
I'm talking about tracks 6-12. Tracks 1-5 will work.
The API shows all the Composed By correctly.

What is the difference why the fine component can not fetch the data?
Currently foo_discogs doesn't support reading credits from index tracks. I will be releasing an update shortly that supports this.

Re: foo_discogs

Reply #2560
Heya,
yea, it does work if the files have discogs tag syntax previously... try tagging completely empty files, and it will fail to inject the feat artist correctly. So you will need to run it once, to get the main tags, then run it again where it injects the feat artist on top. Odd & an annoyance, but works, once just has to remembeer to run the foo_discogs tagger twice on each new tagged release...

ah, I think I know what it's due as well now... but no idea how to fix it.
When running first, the %DISCOGS_CREDIT_FEATURING% field on file is empty, so once it's run, it's filled correctly, and only then does the $if engage... just a hunch, and not sure why it's not detecting the incokming foo_discogs data correctly here, but needs it to sit in file tags seemingly for this to work.
c.
What you're doing is reading the value of the DISCOGS_CREDIT_FEATURING tag when creating your TITLE tag, but the DISCOGS_CREDIT_FEATURING tag hasn't been written yet so it's blank. None of the tags actually get written to file until the end.

What you can do is use the special $pput(N,V) function to store the value of the DISCOGS_CREDIT_FEATURING tag when it's created, then use the $pget(N) function to retrieve the value when creating the TITLE tag. Note that the DISCOGS_CREDIT_FEATURING tag should come first in the list of tags for this to work.

Re: foo_discogs

Reply #2561
Hi zoomorph,

another f2k-crash from your fine component.

(I deleted the foo_discogs.dll.cfg and only re-authorize for O-Auth.)

When the component writes the tags for this release, foobar2000 crashes.

It would be nice, if someone could double-check, but don't be offended by the tracktitles... 8-]

(componet version 2.13 from Feb 22 2017 and f2k 1.4b7 but also stable 1.3.x crashes)
No crash for me. Can anyone else confirm a crash?

It could be related to a specific custom tag you have defined... Perhaps you could share your tags with me and I can try it.

Re: foo_discogs

Reply #2562
Hi,
again, I have a release, which tracknumbering seems correct to me on the discogs website, but the fine component won't tag the files accordingly.
Also, when I try to edit the release, I cannot find any non-printing chars or something that looks like a reason, the first track is shown as a separate one.

please see screenshot.


makes no sense to me, would someone be so kind and explain to me, why?
This is another unfortunate case where the tracklist can't be parsed correctly because Discogs doesn't have a logical tracklist format.

Hi zoomorph,
a smalish error in the foo_discogs_help.html:
the example for $multi_wrap(A,S) is the same as for $multi_pad(A,N).
an example for $multi_pad(A,N) is missing
Will be fixed, thanks!

Re: foo_discogs

Reply #2563
hi zoomorph,
deleting the discogs.cfg, I found out, that the default string for Configuration->Searching->Master release formatting string
is
Code: [Select]
[master] $join($append(%MASTER_RELEASE_TITLE%,%MASTER_RELEASE_YEAR%))
but master releases do not show up as "[master]" in the Find Release Window.

So it should be:
Code: [Select]
'['master']' $join($append(%MASTER_RELEASE_TITLE%,%MASTER_RELEASE_YEAR%))

Also (for the picky ones) some default strings mentioned in the documentation html file are outdated.
Will be fixed. Thanks!

Hello everyone,

this release has cat# set to "ESO109" as you can also see via the api.

With foo_discogs default configuration, no cat# is shown in the Find Release Window,
Although %RELEASE_SEARCH_CATNOS% is in the formatting string.
Other releases reveal their cat#.

Anybody an idea, why?
(and how to get the cat# shown)


It's a problem on Discogs' end. No catalog numbers are provided by the API:
https://api.discogs.com/artists/164971/releases

Re: foo_discogs

Reply #2564
hi zoomorph,

this one is crashing f2k:

I'm trying to change the "Discogs track formatting string:" (Configuration->Matching) and while just pasting the single string "%DISC_FORMAT_QUANTITY%"* into the field, and loading a release , foobar crashes.
It would require too big of changes to make this work correctly, so for now it will just return unknown (?), rather than crashing. :-)

Re: foo_discogs

Reply #2565
Version 2.14 is released which contains a few minor fixes mentioned in the above posts.


Re: foo_discogs

Reply #2567
this release has cat# set to "ESO109" as you can also see via the api.

With foo_discogs default configuration, no cat# is shown in the Find Release Window,
Although %RELEASE_SEARCH_CATNOS% is in the formatting string.
Other releases reveal their cat#.

Anybody an idea, why?
(and how to get the cat# shown)


It's a problem on Discogs' end. No catalog numbers are provided by the API:
https://api.discogs.com/artists/164971/releases
@zoomorph
You mixed up the Releases, there is a Cat.No,
see my quote:
this release has cat# set to "ESO109" as you can also see via the api.

Re: foo_discogs

Reply #2568
this release has cat# set to "ESO109" as you can also see via the api.

With foo_discogs default configuration, no cat# is shown in the Find Release Window,
Although %RELEASE_SEARCH_CATNOS% is in the formatting string.
Other releases reveal their cat#.

Anybody an idea, why?
(and how to get the cat# shown)


It's a problem on Discogs' end. No catalog numbers are provided by the API:
https://api.discogs.com/artists/164971/releases
@zoomorph
You mixed up the Releases, there is a Cat.No,
see my quote:
this release has cat# set to "ESO109" as you can also see via the api.
No I didn't, it's a different API endpoint which is where the information you're asking about is taken from. Normally this endpoint returns catalog number but it's not here, which is a problem on Discogs' end.

 

Re: foo_discogs

Reply #2569
Quick question, can this component be used to only fetch the discogs artist id?

Re: foo_discogs

Reply #2570
Quick question, can this component be used to only fetch the discogs artist id?
Yes. You can disable all the other tag mappings (create duplicates that are blank if necessary for ones that can't be disabled).

Re: foo_discogs

Reply #2571
Any way to fix that error
Code: [Select]
(FATAL) Error: Authorization Failed (401) Is OAuth working?
Only way to parse data is through "release ID" field pasting url. Internal search do not work...

 
SimplePortal 1.0.0 RC1 © 2008-2018