Skip to main content
Topic: foo_discogs (Read 826613 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

foo_discogs

Reply #1575
Removing multi-disc options is all good but now %totaltracks% gets mapped with the total tracks of all discs combined. I would prefer total per disc like it was before. Not hard to edit manually but would be nice if you can add an option for this.

Also can you give an example of what "Discard numeric suffixes" does.

foo_discogs

Reply #1576
Maste, can you help me with this error: error



Thx...

foo_discogs

Reply #1577
i googled http error 429 and it looks like the limit of 1000 images per day has been reached (not you but everyone who uses the component)

Quote
The user has sent too many requests in a given amount of time. Intended for use with rate limiting schemes.[14]


edit: reading that again - it might be some other rate limiting thing?? zoomorph will know more.

foo_discogs

Reply #1578
Thank you, for explaining.
IMO your example is an incorrect use of Index/Sub-tracks. "Bonus Track" should be a heading instead. I would suggest editing it.

It might be possible to add an option to toggle sub-tracks along with the "Display/Replace ANVs" options in the future, but for cases like this I think the release ought to be changed. Garbage in, garbage out...

It might be a special case, because I prefer to add such information as  "Bonus Track" or "Remix by..." into the COMMENT tag.

Anyways,
I tried a lot with the "Automatic Track Lenght"-Feature and it did not work out properly. I saw a lot of cases, where the Information on the website included the track lenghts and the files I wanted to tag had the (mostly) identical times too, but the addon did'nt sort at all. (not wrong sorting, just no sorting at all).
The manually sorting did the job well for me, so I don't see a big problem here, buuuuuut:

Trying a lot and spending time, I think, it would be very handy, to include a button on the main addon-window which allows the user to sort the tacks just when the button was clicked.

this would save some time and hassle, turning the feature off and on again, because I don't need that neat feature all the time.

What do you think?
A small button to sort the tracks. Simple and useful :-)


foo_discogs

Reply #1579
Hmm... the URL looks correct to me. Given that nobody else has reported this, it seems likely to be a problem on your end.... We could open a ticket with Discogs to see if they are receiving your request.

I am getting pretty much same error:
Code: [Select]
foo_discogs: HTTP error status: HTTP/1.1 401 Unauthorized
foo_discogs: Exception handling: http://api.discogs.com/oauth/request_token?oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=141548746453c&oauth_signature=kvsjIBxC0TyqCvg8Ef9VPmPFM7k%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1415487464&oauth_version=1.0


 

foo_discogs

Reply #1581
Another issue I noticed. Album artist field gets written on every release whereas it should be written only if there are multiple track artists.

foo_discogs

Reply #1582
i googled http error 429 and it looks like the limit of 1000 images per day has been reached (not you but everyone who uses the component)

Correct. Discogs stupidly limits all foo_discogs users to 1000 images per day using the API. In your settings you can uncheck "Use Discogs API for art" and that error should go away as the API is bypassed.

foo_discogs

Reply #1583
Removing multi-disc options is all good but now %totaltracks% gets mapped with the total tracks of all discs combined. I would prefer total per disc like it was before. Not hard to edit manually but would be nice if you can add an option for this.

I'll change TOTALTRACKS to the total per disc by default, because I think this is how it's normally used. I'll add another tag RELEASE_TOTAL_TRACKS so users can map them if they want.

Also can you give an example of what "Discard numeric suffixes" does.

It simply drops the (2) from Artist (2).

I tried a lot with the "Automatic Track Lenght"-Feature and it did not work out properly. I saw a lot of cases, where the Information on the website included the track lenghts and the files I wanted to tag had the (mostly) identical times too, but the addon did'nt sort at all. (not wrong sorting, just no sorting at all).

If it's ambiguous it won't sort them. In the past it would often return wrong results in these cases. The sorting algorithm could definitely be greatly improved at some point... currently it's very simplistic.

A small button to sort the tracks. Simple and useful :-)

Not a bad idea.

Another issue I noticed. Album artist field gets written on every release whereas it should be written only if there are multiple track artists.

Thanks. This will be fixed shortly.

foo_discogs

Reply #1584
Removing multi-disc options is all good but now %totaltracks% gets mapped with the total tracks of all discs combined. I would prefer total per disc like it was before. Not hard to edit manually but would be nice if you can add an option for this.

I'll change TOTALTRACKS to the total per disc by default, because I think this is how it's normally used. I'll add another tag RELEASE_TOTAL_TRACKS so users can map them if they want.


This should be linked to the Configuration setting "Start track numbers at 1 for each disc."

Those that have this setting enabled will likely want the TOTALTRACKS count to be per disc while those who disable it will likely want the TOTALTRACKS count to be per release. Standard tags should be used instead of custom tags whenever possible to maximize portability/compatibility with other players.


foo_discogs

Reply #1586
Those that have this setting enabled will likely want the TOTALTRACKS count to be per disc while those who disable it will likely want the TOTALTRACKS count to be per release. Standard tags should be used instead of custom tags whenever possible to maximize portability/compatibility with other players.

Not a bad idea, but I'm sure someone will come along and disagree. This way, you can disable writing TOTALTRACKS and map RELEASE_TOTALTRACKS to TOTALTRACKS... no custom tags need be used. :-)

Thanks. This will be fixed shortly.

Rats! I loved that bug! 

Don't update. :-P

foo_discogs

Reply #1587
When i click Authorize NOTHING happens, what a problem??? Another time a got the same problem  Error: Authorization Failed (401) [Is OAuth working?] -
I installed foobar + component at another notebook and its working good, but on my main comp i clicked thousand of times this button, reinstalled dif versions of foobar and its still dont working, very horrible for me cause im getting psycho after that..
Can You fix this or what we should do?????????


foo_discogs

Reply #1589
When i click Authorize NOTHING happens, what a problem??? Another time a got the same problem  Error: Authorization Failed (401) [Is OAuth working?] -
I installed foobar + component at another notebook and its working good, but on my main comp i clicked thousand of times this button, reinstalled dif versions of foobar and its still dont working, very horrible for me cause im getting psycho after that..
Can You fix this or what we should do?????????

Nothing happens -- does the "View release page" button work? (File needs a DISCOGS_RELEASE_ID tag for it to be visible.)

401 error when clicking Authorize -- I'm investigating this one.

My suggestion is to copy the OAuth secret and token that are generated on your other notebook into the settings for this one. They should work.

foo_discogs

Reply #1590
Nothing happens -- does the "View release page" button work? (File needs a DISCOGS_RELEASE_ID tag for it to be visible.)

401 error when clicking Authorize -- I'm investigating this one.

My suggestion is to copy the OAuth secret and token that are generated on your other notebook into the settings for this one. They should work.

View release page button work
i copy paste pin code and secret token and it doesnt work, error

foo_discogs

Reply #1591
View release page button work
i copy paste pin code and secret token and it doesnt work, error

No pin code, just copy and paste the token and secret and press "Test"... it should say it's working. The token and secret aren't attached to a specific computer, so if they work on one computer they'll work on another.


foo_discogs

Reply #1593
look at this
what console say when i clicked authorize button

foo_discogs: error: Error requesting token: http://api.discogs.com/oauth/request_token oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=141573605929&oauth_signature=pIS0kQkgYxuFZV9lfbsgV2KeOkA%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1415736059&oauth_version=1.0

foo_discogs

Reply #1594
Weird. Does Test OAuth work on the computer where you generated those tokens? Are you sure you copied them exactly (no space at the end or anything)?

Can you try an older version of foo_discogs to see if the Authorize button works there? Here's a build of 1.38: https://www.sendspace.com/file/lkk2nu

I've opened a ticket with Discogs asking about 401s from the request_token endpoint. Maybe they can help.

foo_discogs

Reply #1595
Weird. Does Test OAuth work on the computer where you generated those tokens? Are you sure you copied them exactly (no space at the end or anything)?

Can you try an older version of foo_discogs to see if the Authorize button works there? Here's a build of 1.38: https://www.sendspace.com/file/lkk2nu

I've opened a ticket with Discogs asking about 401s from the request_token endpoint. Maybe they can help.

How can I test if OAuth working or not? This build's error:
Code: [Select]
foo_discogs: HTTP error status: HTTP/1.1 401 Unauthorized
foo_discogs: Exception handling: http://api.discogs.com/oauth/request_token?oauth_consumer_key=kQFLKuHXrEsVfZTDvOdz&oauth_nonce=141574936829&oauth_signature=xqe2aLqDnG%2BZ8q5t1qVgKd2cnXM%3D&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1415749368&oauth_version=1.0

foo_discogs

Reply #1596
Hello, this is a feature request,

for this release:
http://www.discogs.com/Anorganik-Sent-Back...release/2524366
I get the (correct) error:
Quote
(FATAL) Error [release 2524366]: Page Deleted or Missing (404) - (url: http://s.pixogs.com/image/R-150-2524366-1288709051.jpeg)

[ESCAPE to close]


Would it be possible to let the user just skip this dialog and continue tagging?

now, the user needs to go to the configuration dialogue, click the Album/artist art tab, turn off "fetch" and "display preview in release dialog", close the configuration dialogue and start the whole thing again.
when the tagging is done, the user needs to reverse all the changed settings again.
(its kinda inconvenient)

it would be nicer if the user is just told that there is a 404 error and the addon just continues its work w/o fetching the art after the error msg were showed.

is this possible?

foo_discogs

Reply #1597
Hello, this is a feature request,

for this release:
http://www.discogs.com/Anorganik-Sent-Back...release/2524366
I get the (correct) error:
Quote
(FATAL) Error [release 2524366]: Page Deleted or Missing (404) - (url: http://s.pixogs.com/image/R-150-2524366-1288709051.jpeg)

[ESCAPE to close]


Would it be possible to let the user just skip this dialog and continue tagging?

now, the user needs to go to the configuration dialogue, click the Album/artist art tab, turn off "fetch" and "display preview in release dialog", close the configuration dialogue and start the whole thing again.
when the tagging is done, the user needs to reverse all the changed settings again.
(its kinda inconvenient)

it would be nicer if the user is just told that there is a 404 error and the addon just continues its work w/o fetching the art after the error msg were showed.

is this possible?

Yes, it should probably ignore a 404 on the preview image and just skip it. However, this seems like a pretty rare use case. You should really edit the images on Discogs to remove the broken one.

foo_discogs

Reply #1598
Hi, i'm getting this error:

foo_discogs: HTTP error status: HTTP/1.1 500 Internal Server Error
<3 f00

foo_discogs

Reply #1599
Discogs' server returned HTTP/1.1 500 Internal Server Error. Must be a problem with their server. I suggest trying again later or asking on their API help forum.

 
SimplePortal 1.0.0 RC1 © 2008-2019