Skip to main content ↑ ↓

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: foo_discogs (Read 1477267 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Re: foo_discogs

Reply #3276 –
Quote from: BiOMeX on
Possibly bypass:  Tag mapping... - Action - Write+Update instead of Write (by default) ;)

Nice workaround, thanks. So maybe that´s why, could be because actions were fixed in Discogger.

bassstorm suggested on Github that the feature shouldn't deal with the mapping table at all, and should remove all pre-existing tags as preliminary step. I am considering this guideline for implementation.

Discogger v1.0.21

Acknowledgments to @mjm716 @frogworth for raising the release_ID disabled issue. Also to @bloniaq about the $filter function.

Change log:
- [fb2k v2] Custom list fonts.

Fixes:
- $filter function arrays as the second parameter.
- DISCOGS_RELEASE_ID tag map default mode.
- UTF file paths.

Note:
CONFIG FILE NOT BACKWARD COMPATIBLE
Please backup your config file and tag mappings before installing.

Re: foo_discogs

Reply #3277 –
Discogger v1.0.21

foo_discogger.fb2k-component - is still 1.0.20.5 and source code (zip) is 1.0.20.beta

Does 1.0.21 let 'write + update' DISCGOS_RELEASE_ID because now only 'write' is possible?

Re: foo_discogs

Reply #3278 –
Sure, hold the shift key on your keyboard and right-click over DISCOGS_RELEASE_ID.

Weird this is asked so often.
There might be a common use case or bug saving wrong IDs, aside from occasional mistakes.

About those versions, can´t replicate, here the latest binary is v1.0.21.
I can only suggest installing the component again.

Re: foo_discogs

Reply #3279 –
Quote from: da yuyu on
Weird this is asked so often.
There might be a common use case or bug saving wrong IDs, aside from occasional mistakes.

The usual use case is that you tagged the album with the wrong ID some time ago, and want to change it to the correct one.
Or there's a variant in Discogs with the full credits, and you want to use that one rather than the actual matching edition which was lazily added by someone without any details.
Also, I often get an album, either as a download promo or via Bandcamp or something, and when I first go to tag it, the only version in discogs is the LP. So again, I'll go and retag it later.

I actually don't understand why it wouldn't update the ID to be whatever it is you're tagging it with at the time.
It doesn't make any sense to me to leave it with the old ID!  :)) It seems particularly odd to make it forbidden to change to Write+Update without a secret key modifier!

Re: foo_discogs

Reply #3280 –
About the discogs_release_id....

After the last update, it is in disable state (only tag mapping or options that didn't update, the rest was updated just fine). After changing it to Write and Update it doesn't survive foobar2000 restart and return to disabled state.

I tried to restore to default, restart and import the tag mapping (that I back up before upgrade), but it doesn't work either.

Any solution to make it Write and Update permanently.

Edit:

I noticed the Plain wirte tag option. In this options you can't change the release, only click next in the search. In the track list windows (Track Matching & Artwork (PWT)), clicking preview and tag mapping DISCOGS_RELEASE_ID is in Write and Update state. In this method the changes in state (disabled, write, write and update) It is not remembered either.

Edit 2:

Deleting the .cfg file mahe all the ID have a write state. Changing the mapping to Write and update. Release_id doesn't remember the change, the other 3 remember the change (master release, artist and label)

Re: foo_discogs

Reply #3281 –
Quote from: frogworth on
The usual use case is that you tagged the album with the wrong ID some time ago, and want to change it to the correct one.
Or there's a variant in Discogs with the full credits, and you want to use that one rather than the actual matching edition which was lazily added by someone without any details.
Also, I often get an album, either as a download promo or via Bandcamp or something, and when I first go to tag it, the only version in discogs is the LP. So again, I'll go and retag it later.

You could use the fb2k tag manager to delete the wrong ID tag beforehand or 'Force Write and Update selected tag' in the preview panel. Or keep the right ID, that could be a different mixing, an write the credits from other releases. It is already possible to manage those situations without 'Write and Update' I believe.

Quote from: frogworth on
I actually don't understand why it wouldn't update the ID to be whatever it is you're tagging it with at the time.
It doesn't make any sense to me to leave it with the old ID!  :)) It seems particularly odd to make it forbidden to change to Write+Update without a secret key modifier!

I would not consider that too odd, honestly.
The shift key in the Tag mapping dialog just adds some leverage related to data consistency as release, master, label and artist IDs play an important role in the Discogs schema, they are relational database indexes.

Would the component, in you opinion, be better after removing all restrictions, including the shift key modifier?
 

Re: foo_discogs

Reply #3282 –
Quote from: da yuyu on
Hi,
Meaning:
The component is unable to open <profile>\configuration\foo_discogger.dll.db.

Posible solution:
Replace it with a fresh copy extracted from the distribution file (foo_discogger.fb2k-component).
Hey, that worked! Many thanks
I had to go to the component folder>discogger then copy that .db file and paste into configuration folder, as noticed that there wasn't any foo_discogger.dll.db there.

Regards.

Re: foo_discogs

Reply #3283 –
Quote from: paregistrase on
After the last update, it is in disable state (only tag mapping or options that didn't update, the rest was updated just fine). After changing it to Write and Update it doesn't survive foobar2000 restart and return to disabled state.

Bug found and fixed.
It should save and restore the Write and Update settings properly now.

Thanks for you feedback!

v1.0.21.1

Change log:

- Custom fonts: use fb2k list font instead of the playlist font.
- Rev. save and restore  DISCOGS_RELEASE_ID actions.
- Fix artwork path indexes.

Note:
CONFIG FILE NOT BACKWARD COMPATIBLE
v1.0.21.x configuration settings are not compatible with earlier versions.
Please backup your foo_discogger.cfg file and tag mapping before installing.

Re: foo_discogs

Reply #3284 –
Quote from: da yuyu on

Would the component, in you opinion, be better after removing all restrictions, including the shift key modifier?

A tiny bit I guess?
As you say, there are ways around it. It's a minor thing.
But I think it does cause confusion, and the use cases for replacing the Discogs ID may occur more frequently than expected. I'm not sure there would be any negative outcomes from unrestricting the mapping.

Re: foo_discogs

Reply #3286 –
@paregistrase

Finally... glad to hear it.

About the PWT mode, work on that feature stalled long ago.
As a refresher, it was meant to tag MP3 files without resorting to TXXX fields.
I am considering removing the feature or including it only in beta releases instead.

@frogworth

Maybe if unrestricted leads to inconsistent data.
For example, overwritting a release ID from a different master, artist, etc.
Weird tag mapping results are my first guess.
The component will only try not to crash.

Re: foo_discogs

Reply #3287 –
I have the same error with Discogger as I had with Discogs Tagger. I can't write tags because of this:

(FATAL) Error: Error loading release 31635865: JSON Parser ExceptionArray assertion failed.

Any idea how to get rid of it?

Re: foo_discogs

Reply #3289 –
Quote from: BiOMeX on
Quote from: heliosphaner on
Any idea how to get rid of it?
Same thing here:
"(FATAL) Error: Page Deleted or Missing (404)(url: https://api.discogs.com/artists/15037826)

[ESCAPE to close]"

foo_discogger 1.0.21.1

Yes, I used this one before I wrote. Eventually it worked after installing fb2k-component, but the one installed from zip caused errors.

Also, today I'm having error 500:

(FATAL) Error: Error loading release 31743548: HTTP Error (500)(url: https://api.discogs.com/releases/31743548)

[ESCAPE to close]

Re: foo_discogs

Reply #3290 –
Anyone having problems with release images?

Last days I noticed that there the option to manage images is not available, there is no album cover preview and no cover images are being downloaded.

I check in the console and I have a message that said.

Code: [Select]
foo_discogger: Unable to read album thumbnail from cache, index: 0

Re: foo_discogs

Reply #3293 –
Hi
Having JSON issue with foo discogs,, I switched to foo discogger, but would like to know how to configure serching on "artist name".
When I use it, it seems having a view on "performer" or "Album Artist"

Thank you in advance

Re: foo_discogs

Reply #3294 –
Hi @Marcus28
A shame to hear about the foo_discogs issues, I thought they were temporary and gone by now.

It is hard to say without further details... the current artist and album artist, maybe also a suitable release ID,
but Discogger prioritizes album artists. There might be no configuration option for that.

Re: foo_discogs

Reply #3295 –
Hi Da yuyu

Annoying if I can't tune discogger as I wish, but thank you for this information

With foo discogs, isn't there any work around with JSON issue ?

Re: foo_discogs

Reply #3296 –
You are welcome.
I understand that you have a problem here, and I really tried to solve that.

About foo_discogs, I can´t think of anything.
Maybe someone else in the forum might help you.

Re: foo_discogs

Reply #3297 –
I also get the same Json Parser exception:

(FATAL) Error: Error loading release 1032113: JSON Parser ExceptionArray assertion failed.

Using foobar2000 v2.1.6

Re: foo_discogs

Reply #3298 –
Getting errors like

(FATAL) Error: Error loading release 20973817: JSON Parser ExceptionArray assertion failed.
[ESCAPE to close]

with both foo_discogs and foo_discogger (10211). The corresponding console output is

foo_discogger: https://api.discogs.com/database/search?type=artist&q=Latin%20Quarter&per_page=100
foo_discogger: Url OAuth enabled
foo_discogger: Lapse: 376
foo_discogger: RL: 60 - Used: 0 - RMNG: 60
foo_discogger: https://api.discogs.com/releases/20973817
foo_discogger: Url OAuth enabled
foo_discogger: Lapse: 6.49
foo_discogger: RL: 60 - Used: 1 - RMNG: 59

Re: foo_discogs

Reply #3299 –
I had a look at the api output and noticed they have a) rate-limiting and b) cloudflare proxy. Going out on a limb here, but maybe Cloudflare is breaking the request by delaying the response? Something like flaresolver might help, or even a delayed request...