Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: REACT 2 Released (Read 1071194 times) previous topic - next topic
0 Members and 4 Guests are viewing this topic.

REACT 2 Released

Reply #600
If you are ripping to image you really should not be using CreatAllCuesheets to create the four cuesheets.  When ripping to image a cuesheet is automatically created, using the same name as the image.

I did have CreateAllCuesheets=1

So, if that's incorrect for image rips, why not internally force it to zero?  -- I think you're right. That setting sometimes conflicts with image-rip cuesheet creation and causes a possible race condition for file names, etc.

Quote
The fact that your image cuesheet is named "<album>.cue" is a concern.  What value do you have set for ImageNaming under [Settings] in the ini?  The default is "$artist$ - [$date$] $album$" IIRC (I use "$artist$ - $album$"). The image name must begin with $artist$!  Otherwise you will have problems with VA albums.


Fine. I'm using the default... I think I've seen a dynamic sequence as the process takes place, something like:
  <album>.cue
  Tempfilename.cue
  $artist$ - [$date$] $album$.cue (in the final image folder)

Quote
According to the wiki, when using images it will not wait (unless you set the value to 2 or 3).  if you are ripping to images perhaps you should set RunCoverDownloader to 2, in case.

Mine was set to 2 -- obviously by me and I didn't remember. Just Made Sense at the time

Quote
I'll upload 16d...should cope with GIF, PNG, BMP and JPG.


OK, we're mostly making progress. Unfortunately, one bug remembered, and one serious backtrack

Progress: the new XUI switch works perfectly!

Bug remembered: if you exit EAC while REACT is monitoring (i.e. any time after pressing F10 and before the the batch file has finished), REACT never exits on its own. It sits hidden in the systray.

Suggestion: be sure to code for user-abort at various points in the process. Be particularly read, at the least, to exit if EAC crashes or is closed.

Serious backtrack: under 16c and 16d, something gets badly scrambled in EAC. Going back to 16b "fixes" the following...

(I'm using gap-detection method A, accurate)
Normally, the pre-track gap detection counts from 2 to n and stops.

In 16c and 16d, gap detection counts up some, backtracks, counts up more, goes to various numbers, and ends at zero (!)... and locks. The rest of EAC continues ok, and the rip completes. Eventually, the gap detector times out with some horrible error message. Then EAC dies. Fortunately, the time out is a long time after the rip is done. But I get only one RIP and then must kill/restart EAC and REACT.

This is repeatable on every CD I've tried, and does NOT happen if I go back to 16b.

Waaah!


In 16c and 16d, gap detection...ends at zero (!)... and locks.


BTW, "locks" means the cancel button is grayed out and the detection popup is completely unresponsive.

--MrPete

REACT 2 Released

Reply #601
Serious backtrack: under 16c and 16d, something gets badly scrambled in EAC. Going back to 16b "fixes" the following...

(I'm using gap-detection method A, accurate)
Normally, the pre-track gap detection counts from 2 to n and stops.

In 16c and 16d, gap detection counts up some, backtracks, counts up more, goes to various numbers, and ends at zero (!)... and locks. The rest of EAC continues ok, and the rip completes. Eventually, the gap detector times out with some horrible error message. Then EAC dies. Fortunately, the time out is a long time after the rip is done. But I get only one RIP and then must kill/restart EAC and REACT.

This is repeatable on every CD I've tried, and does NOT happen if I go back to 16b.
That is so weird.  I can't see how REACT plays any part when this process is happening!!

I'll think on it.

NB: Of course, it works fine for me...
I'm on a horse.

REACT 2 Released

Reply #602
So, if that's incorrect for image rips, why not internally force it to zero? wink.gif -- I think you're right. That setting sometimes conflicts with image-rip cuesheet creation and causes a possible race condition for file names, etc.
I guess there are times when users may want both - I suppose it's possible that they may want a multi-file cuesheet also, so they could burn from track files created using ACDIR and still perfectly re-create the CD.  I don' think it is likely, or advisable though.  Still, I wouldn't want to restrict users completely, and Tycho obviously didn't.

Bug remembered: if you exit EAC while REACT is monitoring (i.e. any time after pressing F10 and before the the batch file has finished), REACT never exits on its own. It sits hidden in the systray.

Suggestion: be sure to code for user-abort at various points in the process. Be particularly read, at the least, to exit if EAC crashes or is closed.
I may have to investigate this.  I've not noticed this before - but then I tend to just rip one disc at a time, and leave things well alone once I've pressed F10.

In 16c and 16d, gap detection counts up some, backtracks, counts up more, goes to various numbers, and ends at zero (!)... and locks. The rest of EAC continues ok, and the rip completes. Eventually, the gap detector times out with some horrible error message. Then EAC dies. Fortunately, the time out is a long time after the rip is done. But I get only one RIP and then must kill/restart EAC and REACT.
I'm flabbergasted by the results you get.  I don't understand how you can have so many issues that I have never seen, or anyone else has reported.  I just cannot see how REACT is doing this, but the fact that b16b is OK for you must say something.  Have you set CreatAllCuesheets=0?  The only thing I can think that has changed around that time is the checking for the cuesheets' existence.  Perhaps you could use DebugMode (detailed previously) and see what gets written before this happens.  Maybe I do need to create a serious debug version for you to use...
I'm on a horse.

REACT 2 Released

Reply #603
I'm flabbergasted by the results you get.  I don't understand how you can have so many issues that I have never seen, or anyone else has reported.  I just cannot see how REACT is doing this, but the fact that b16b is OK for you must say something.

It's a gift  -- I used to get paid the Big Bucks to break (and fix) software :-D

Seriously, I have no idea. I just Do Stuff, and pay more attention than most when things go wrong. I usually know when something's a bug vs just me messing up. I don't just reboot and try again

Lemme play a little more. It helps knowing that all's well for you!

REACT 2 Released

Reply #604
It's a gift  -- I used to get paid the Big Bucks to break (and fix) software :-D
Indeed!

Don't get me wrong, I do appreciate the feedback.  It's just that it's quite frustrating for me, when I can't emulate the problem.  I don't really have the time to test for hours and hours, if the truth be told.

If you could try DebugMode with b16d it may help me out.

Thanks.
I'm on a horse.

REACT 2 Released

Reply #605
I think a bug has been introduced with mods after 16b. Its to do with album art, let me explain

If you rip 2 consecutive CD's, on the 2nd CD the 2nd time the album art runs it searches on the first albums & artists name, its a bit annoying, however the rip still works of course, no major problems like pholzmann is having.

16b works as expected, 16d does not, can anyone confirm?

Also wish the memory leeks cold e fixed with the art downloader  obviously not reacts fault though.

I'm using RunCoverDownloader=1

REACT 2 Released

Reply #606
I think a bug has been introduced with mods after 16b. Its to do with album art, let me explain

If you rip 2 consecutive CD's, on the 2nd CD the 2nd time the album art runs it searches on the first albums & artists name, its a bit annoying, however the rip still works of course, no major problems like pholzmann is having.

16b works as expected, 16d does not, can anyone confirm?
Yes, I can see it now.  Thanks for the report.  Silly bug on my part.

Please try ssb16e.
I'm on a horse.

REACT 2 Released

Reply #607
Hi Neil

Just wanted to say many thanks for this nice REACT mod of yours and that the 'Test=1' function simply rocks

I have been occupied with some other stuff lately and have not been using REACT for some time now(or ripping with anything else for that matter), but now when i return back to check out what's happening currently, then i happily find that EAC has now gotten both test & copy + AccurateRip support for images and also that you have faithfully continued the REACT development with great new features and fixes in Tycho's absence, so i just wanted to say many thank's for all your troubles, mate

CU, Martin.

REACT 2 Released

Reply #608
Hi Martin,

I'm glad that my mod has been useful to you.

I'm actually getting quite concerned that I have been causing tycho's absence, rather than helping.  I hope he will be back soon with REACT 3, at which point I will gladly step back into the shadows.

Anyway, good to see you back.
I'm on a horse.

REACT 2 Released

Reply #609
Hi Martin,

I'm glad that my mod has been useful to you.

I'm actually getting quite concerned that I have been causing tycho's absence, rather than helping.  I hope he will be back soon with REACT 3, at which point I will gladly step back into the shadows.

Anyway, good to see you back.

Hi. Don't be concerned - you have been a great help all the way. I don't think REACT 3 will appear anytime soon, unless EAC is changed a lot, which is not likely. However, as I've promised earlier, I will try to merge in some *smaller* updates I have done, and then at some point a new "official" release. Please, continue to develop and support REACT if you can (and want to).

REACT 2 Released

Reply #610
Hi. Don't be concerned - you have been a great help all the way.
...
Please, continue to develop and support REACT if you can (and want to).
That's a weight off my mind.  Thanks tycho.

I don't think  REACT 3 will appear anytime soon, unless EAC is changed a lot, which is  not likely. However, as I've promised earlier, I will try to merge in  some *smaller* updates I have done, and then at some point a new  "official" release.
Looking forward to it.
I'm on a horse.

REACT 2 Released

Reply #611
Hello,

I just started to look at using REACT with the newest EAC 0.99pb3.  I have tried to get REACT to create a FLAC image and Nero AAC tracks, as well as download Album Art (using AlbumArtDownloaderXUI).  I am having a couple of issues, and I am not sure where to go now.  I have tried searching, but the information I have found doesn't seem to help.

I set REACT to wait until the album art is downloaded before it copies (set to 2 in the INI file).  I want to have a "folder.jpg" file when the process is done, but I don't end up with an image in the final directory at all.  Is it possible to set the path and name that should always be used by the AlbumArtDownloaderXUI so that REACT can find it?  When the XUI window opens, the default destination is not the same as the folder where the temporary CUE/WAV/LOG files are being held, plus it is defaulting to a filename format of "cdartist"- "album".jpg, which I don't want.

When REACT creates the CUE file and starts copying the temporary WAV, it is not placing these tempory files in a directory I have not set.  In my INI file I have it set for
Code: [Select]
OutRoot="D:\Music\Test"
however, the temporary CUE/WAV/LOG files are being put into my "D:\MUSIC\FLAC" directory (which is where my current music library resides).  I don't know how or why it is using my current FLAC directory.

Basically, I was hoping that the temporary files (CUE/WAV/LOG) and the folder.jpg would be held in the same temporary directory.

Thanks.

REACT 2 Released

Reply #612
I dont use AlbumArtDownloaderXUI - and I currently don't have it installed on this laptop (looks like I need .Net 3) - but can't you just change the output directory?  In fact, thinking about it, I think if you resolve the issue below (D:\Music\FLAC > D:\Music\Test) this may resolve itself.

Using "<artist> - <album>.jpg" is standard naming for the source image, and can't be changed; however the source name is irrelevant.  By default REACT moves it to the destination directory renaming it to the same as the image file.  You can amend this behaviour by changing:

Code: [Select]
IF %have_cover%==1 COPY /Y "@cover@" %dest%\"@basename@.jpg"

...to:
Code: [Select]
IF %have_cover%==1 COPY /Y "@cover@" %dest%\folder.jpg

... in the FLAC image section of your REACT-image.cfg.

To change the folder that REACT is using for the source files go to EAC Options >  Directories.  Check "Use this directory" and select "D:\Music\Test".
I'm on a horse.

REACT 2 Released

Reply #613
Kockroach, what Synthetic Soul suggests is how i have mine set and works.

Synthetic Soul ssb16e has fixed the bug i posted, thanks again.

 

REACT 2 Released

Reply #614
Hi Synthethic Soul,

I had already made that change regarding the @basename@.jpg, changing it to folder.jpg.

Just to be safe, for your other suggestion, I started with a fresh directory.  I set the directory to "D:\Test"
Changing the directory in EAC Options doesn't help completely.  It is sending the folder.jpg image there, but it is not sending the temporary WAV/CUE/LOG files there.  They are going to "D:\Music\FLAC".  This is where my current FLAC library is held, so I would prefer it not be touched.  I don't know why EAC is throwing the files in there, especially since it is not the last directory I used, nor is it the one set in EAC Option --> Directories.

One thing I notice is that after selecting my Album Art, the "Save As" window from EAC pops up quickly, and I can see that it is using my "D:\Music\FLAC" directory, but it closes after about a second or two.

EDIT:  While I was writing this message, I was letting REACT/EAC do its thing on a CD.  Even though I have the "EAC Options/Directory" set to "D:\Test", the only thing that is going in there is the Album Art I downloaded.  The temporary files are being stored in "D:\Music\FLAC", while the final files are being put into "D:\Music\Test".  In the "D:\Music\Test", it has the proper directories, containing the music files, cue and logs, but no album art.

REACT 2 Released

Reply #615
Hmmm... if you look in the registry, under:

HKEY_CURRENT_USER\Software\AWSoftware\EAC\StartUp Options

... you will notice a couple of other file paths.  It seems to me that "Actual Path" is the one that needs to change.

I just managed this in EAC by doing the following:
  • I chose a new directory (let's call it "X:\") under "Use this directory".
  • I changed the radio button to "Ask every time".
  • I ripped using F10, ripping to the new directory, "X:\".
  • I closed EAC and re-opened it.
  • I ripped using F10, and EAC opened the dialogue in "X:\".
  • I changed the radio button to "Use this directory".
If you're happy with regedit you may just want to edit the paths in the registry.  For safety:
  • HKEY_CURRENT_USER\Software\AWSoftware\EAC\StartUp Options\Actual Path
  • HKEY_CURRENT_USER\Software\AWSoftware\EAC\StartUp Options\Process Path
  • HKEY_CURRENT_USER\Software\AWSoftware\EAC\Extraction Options\DirectorySpecification
REACT uses DirectorySpecification - the directory set under "Use this directory".

I think if you used regedit to change all the paths above to "D:\Test" and then opened REACT/EAC it would all work as expected.
I'm on a horse.

REACT 2 Released

Reply #616
I'm sorry, but I must be especially challenged today.

I have previously used EAC+FlackAttack to do ripping and compressing (to FLAC + Ogg, with embedded cue sheets). I then would tweak the tags and add album art using The Godfather. As I have a new computer and FlacAttack seems to have faded away, I thought I'd try REACT.

So far, no real luck. I downloaded both the REACT 2.0 (from the REACT 2/EAC plugin Uploads thread) and the latest ssb16e from this thread.

My problem is that neither of those appear to be a "full install" with the proper plugins in the "Tools" directory and the albumart cover downloader. They're just the REACT executable and a readme file.

I've grabbed and installed the AlbumArtDownloader, the EAC Ultimate Pack, newer FLAC and OggEnc2 encoders, figured out that REACT must be Run As Administrator under Vista to create the REACT.INI file - but this seems way too complicated considering that most members on this thread seem to be up and running within minutes.

Am I missing something? I just want to be able to rip a CD (with non-compliant cue sheets), create individual .FLAC and .ogg files, embed the album art into both the Oggs and FLACs and the cue sheets in the FLACs (I don't want one big FLAC image of the CD). Doable?

Thanks,

Derf!

REACT 2 Released

Reply #617
I just managed this in EAC by doing the following:
  • I chose a new directory (let's call it "X:\") under "Use this directory".
  • I changed the radio button to "Ask every time".
  • I ripped using F10, ripping to the new directory, "X:\".
  • I closed EAC and re-opened it.
  • I ripped using F10, and EAC opened the dialogue in "X:\".
  • I changed the radio button to "Use this directory".

I went with this route, and everything seems to work fine now.  Thanks for the help. 

I wonder if this problem arose since EAC (non-REACT) always asks for the directory to save when doing an Image based copy, but when doing track based, it uses the Directory path in the settings.  I think it may have been causing the problem.  But no worries, it is working now.

I do have one other question.  I had wanted to tag my files in a certain way regarding track number and total tracks.  My changes work for WavPack, FLAC and OGG tracks, but it will not work for MP3 and NeroAAC.

Here is what I have for the MP3 files (found in the Image CFG file):
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.mp3" --extra-opt "{3}@cover@" --pipe "TITLE $n/$N mp3 $#T & @tools@\lame.exe @Opt_LameMP3@ %ApplyAG_Lame% - $#o & @tools@\metamp3.exe %Cover_tag% %VA_tag% --artist $#a --album $#T --title $#t --track $n --totaltracks $N --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q --frame TENC:$q%USERNAME%$q --frame TSSE:$qLAME @Ver_LameMP3@ @Opt_LameMP3@$q $#o" "@sourcecuesheet@"


And this is in the NeroAAC section:
Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --extra-opt "@cover@" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\AtomicParsley.exe $#o -o REACT_tmp.m4a %Cover_tag% %VA_tag% --artist $#a --album $#T --tracknum $n --totaltracks $N --title $#t --year $q@year@$q --genre $q@genre@$q --comment $q@comment@$q --encodingTool $qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q & MOVE /Y REACT_tmp.m4a $#o" "@sourcecuesheet@"


When the encoder runs, it says that it doesn't recognize the "--totaltracks" option for MP3 and NeroAAC, and there are no tags at all in the files.  What should I change to get this to work?  I basically did the same type of change for WV, FLAC and OGG, and they work without a problem (I know the tag formats are different, so that is mainly why they do work in those files).

I know I could go back to the $n/$N format, and then open them in Mp3tag to change them, but I really don't want the extra step if it can be avoided.

Thanks again for your help!

REACT 2 Released

Reply #618
Neither metamp3 or atomicparsley have a "totaltracks" field, though Neroaactag does. I can post what I use (a combination of both neroaactag & atomicparsley) if you want to try it.

For mp3, try using Tag v2.0.53b2 from synthetic soul's site and use the "-t" option to create "totaltracks" field.
Surf's Up!
"Columnated Ruins Domino"

REACT 2 Released

Reply #619
Thanks for the info drbeachboy.  I took a look at Synthetic Soul's Tag program, and from a brief look through the readme file I think I should be able to make the proper changes to get it to work.  I just don't have the time right now.

As far as your config using NeroAacTag and AtomicParsley, yes, I would like to take a look at what you are doing to tag your files.  I would appreciate it if you could post your code.

Thanks again!

REACT 2 Released

Reply #620
Here you go!

Code: [Select]
@tools@\acdir.exe --overwrite --output "%TrackName%.m4a" --pipe "TITLE $n/$N aac $#T & @tools@\neroAacEnc.exe @Opt_NeroAac@ -ignorelength -if - -of $#o & @tools@\neroAacTag.exe $#o %VA_tag% -meta:artist=$#a -meta:album=$#T -meta:track=$n -meta:totaltracks=$N -meta:title=$#t -meta:year=$q@year@$q -meta:genre=$q@genre@$q -meta:comment=$q@comment@$q & @tools@\AtomicParsley.exe $#o -o REACT_tmp.m4a --encodingTool $qneroAacEnc @Ver_NeroAac@ @Opt_NeroAac@$q & MOVE /Y REACT_tmp.m4a $#o" "@sourcecuesheet@"
Surf's Up!
"Columnated Ruins Domino"

REACT 2 Released

Reply #621
Thanks drbeachboy!  I'll give it a try.

REACT 2 Released

Reply #622
@kockroach

When dealing with MP3s, then i would strongly advice against using any 'totaltracks' tags, as it's very non-standard and since most apps probably will not be able to parse them correctly. The ID3v2 spec clearly defines that any optional total tracks values should be appended to the track number in the TRCK frame and seperated by a '/' charachter, just like e.g. the 'discnumber' value and optionally the 'totaldiscs' value are to be stored in the TPOS frame and seperated by a '/' charachter and then e.g foobar2000 will then parse those TRCK and TPOS frames and display there values as though it where two seperate tags i.e. 'tracknumber' and 'totaltracks' and 'discnumber' and ''totaldiscs', even though they aren't, but are just mapped to those fields internally by foobar2000, for easing the metadata handling between the different tagging formats. If you absolutely want to, then you can make a 'totaltracks' TXXX ID3v2 frame with metamp3.exe, but i can't see why you would ever want to when there allready are frames available which is meant for storing exactly those values. The TXXX frames are meant for stuff which aren't covered by the frames defined in the spec.

REACT 2 Released

Reply #623
My problem is that neither of those appear to be a "full install" with the proper plugins in the "Tools" directory and the albumart cover downloader. They're just the REACT executable and a readme file.
The 1.99MB download in the REACT download thread contains all the tools.  Note that some may now be outdated, e.g.: FLAC.  The thread also has links to tools not included.

My mod only includes REACT.exe, to overwrite the exe included in tycho's original release (in that thread).

Make sure you let REACT configure EAC.  REACT should do this on first run, but if you are in any doubt hit Ctrl+F2 to re-do it.

I just want to be able to rip a CD (with non-compliant cue sheets), create individual .FLAC and .ogg files, embed the album art into both the Oggs and FLACs and the cue sheets in the FLACs (I don't want one big FLAC image of the CD). Doable?
Most definately.

For mp3, try using Tag v2.0.53b2 from synthetic soul's site and use the "-t" option to create "totaltracks" field.
Unfortunately Case's Tag won't write ID3v2 tags; I don't know what whould happen if you use -t "totaltracks=12" on an MP3 file - probably APEv2 would be used.

When dealing with MP3s, then i would strongly advice against using any 'totaltracks' tags, as it's very non-standard and since most apps probably will not be able to parse them correctly.
I 100% agree.

If you absolutely want to, then you can make a 'totaltracks' TXXX ID3v2 frame with metamp3.exe, but i can't see why you would ever want to when there allready are frames available which is meant for storing exactly those values. The TXXX frames are meant for stuff which aren't covered by the frames defined in the spec.
To clarify, I believe you would set a switch as below for metamp3:

Code: [Select]
--frame "TXXX[totaltracks]:@numtracks@"
I'm on a horse.

REACT 2 Released

Reply #624
The 1.99MB download in the REACT download thread contains all the tools.  Note that some may now be outdated, e.g.: FLAC.  The thread also has links to tools not included.

My mod only includes REACT.exe, to overwrite the exe included in tycho's original release (in that thread).

Make sure you let REACT configure EAC.  REACT should do this on first run, but if you are in any doubt hit Ctrl+F2 to re-do it.

I just want to be able to rip a CD (with non-compliant cue sheets), create individual .FLAC and .ogg files, embed the album art into both the Oggs and FLACs and the cue sheets in the FLACs (I don't want one big FLAC image of the CD). Doable?
Most definately.


Thanks! I'll try it out (after vacation).

 
SimplePortal 1.0.0 RC1 © 2008-2021