Skip to main content

Topic: Updated in_mad Winamp MAD MP3 input plugin (Read 245968 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • Big_Berny
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #25
In the mediamonkey-forum someone posted a gapless mad-version: http://www.mediamonkey.com/forum/viewtopic.php?t=10051

Maybe this feature can be ported?

Big_Berny

PS: I'm happy with otachan's often updated in_mpg123.

  • odyssey
  • [*][*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #26
In the mediamonkey-forum someone posted a gapless mad-version: http://www.mediamonkey.com/forum/viewtopic.php?t=10051

Maybe this feature can be ported?


This plugin actually REMOVES silence, and does not benefit from the LAME tags actually containing the missing samples:

Quote
This version examines the beginning and the end of each track for silence, and can remove up to approximately 78ms of silence from each end (3 frames). The unwanted silence is typically 50ms or less. If more than 78ms of silence is found - as is the case with normal albums - then the track will not be altered in any way. Therefore, only continuous live or mix type albums are altered.


I'd really like to have gapless playback, and maybe it can be ported from the in_mpg123 plugin?
Can't wait for a HD-AAC encoder :P

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #27
Hi,
I'm back from my short holiday now, ready to do some more to the plugin.

I've fixed the unknown internet stream hogging problem after looking at in_mpg123. It all relies on the user specified default extension for unknown file types. Another way to cure the hogging problem would be to change this from "mp3" to "aac" (or another file type supported by in_mp3 and NOT in_mad) in winamp preferences.

I'd like to add ReplayGain and the LAME gapless playback features. As for APEv2 tags, I'll add once I've cleaned up the ID3v2 code and am happy with that.

An updated file will be available shortly, I'll post again once its up.

Cheers for all comments :-)

  • odyssey
  • [*][*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #28
I'd like to add ReplayGain and the LAME gapless playback features. As for APEv2 tags, I'll add once I've cleaned up the ID3v2 code and am happy with that.


Best news EVER! Thumbs up. I'm already very happy with my new Title Formatting options, even though i miss the "Featuring artist" Helium tag         
Can't wait for a HD-AAC encoder :P

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #29
I've updated http://www.zen23652.zen.co.uk/in_mad.zip .

I've added preliminary support for ReplayGain, it attempts to read it from LAME tag first then foobar ID3v2 tags. It has to be enabled manually via regedit for now. Open and close the plugin configuration to write the defaults, then edit them - "rgenabled" to enable and "rgalbum" to select album gain (otherwise track gain).
  • Last Edit: 31 July, 2006, 06:14:43 PM by MoSPDude

Updated in_mad Winamp MAD MP3 input plugin
Reply #30
YAY!

I do hope you leave access to the advanced ID3v2 tagging options that are there now, I kinda like it.

I'm very glad to hear that something was done about the stream hijacking issue.  It would hijack anything that started with 'http' regardless of anything else (extention didn't matter, not even the default extention).  When I get a chance I will certainly see if what you did fixed the problem in all cases I can come up with.

Your work is very very much appreciated.  Thank you MoSPDude.
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #31
Another update,

I've added gapless playback for files with a LAME tag. ReplayGain options are also now fully working, its checks for foobar ID3v2 info first, then the LAME tag.

The LAME gapless playback needs more testing, so all feedback on that feature will be greatly appreciated. Download from the usual.

Thanks in advance!

  • MedO
  • [*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #32
Great work MoSPDude!
Is this, then, the first player/plugin to support the LAME replaygain tag?

  • haregoo
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #33
Great work MoSPDude!
Is this, then, the first player/plugin to support the LAME replaygain tag?

No. Otachan's in_!mpg123 has supported LAME tag replaygain since 2004.
Keep in mind that LAME tag replaygain adjustment is crap when you play MP3Gained file.

  • odyssey
  • [*][*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #34
Quote
Keep in mind that LAME tag replaygain adjustment is crap when you play MP3Gained file.

How can this be fixed/removed? (Or better yet, recovered if MP3Gain values are trashed?)
  • Last Edit: 02 August, 2006, 06:57:36 AM by odyssey
Can't wait for a HD-AAC encoder :P

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #35
Good point, I hadn't thought of that. I could make it check for APEv2 tags (which I was going to do eventually anyway), where MP3Gain stores undo and analysis information - and make a decision about ReplayGain based on that. For where MP3Gain hasn't stored tags, you could create 0dB gain and 1.00 max amp foobar ID3v2 ReplayGain tags, or disable the ReplayGain.

Anyone tried the LAME gapless decoding yet? I'm going to have to properly test it, I keep thinking I'm a few samples out.

  • haregoo
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #36
Anyone tried the LAME gapless decoding yet? I'm going to have to properly test it, I keep thinking I'm a few samples out.


in_mad outputs 1055 sample longer or shorter wav at 44100hz.
I've tried with latest in_mad + NullSoft Disk Writer Plugin.

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #37
Ok, after reading through LAME source and a few headaches, I've got the LAME gapless working properly, well at least on the test tones I've created and the files I've got. If haregoo could check this new version again, please.

I've also added reading of ID3v2 RVA2 field, but its untested as I don't personally have anything that writes them, if someone could point me in the right direction for a tagger.

Thanks for all your help

(Download from the usual http://www.zen23652.zen.co.uk/in_mad.zip )
  • Last Edit: 02 August, 2006, 07:05:00 PM by MoSPDude

  • haregoo
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #38
Ok, after reading through LAME source and a few headaches, I've got the LAME gapless working properly, well at least on the test tones I've created and the files I've got. If haregoo could check this new version again, please.

It worked and gapless sample sounds OK for me.

  • bladecgn
  • [*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #39
Hey MoSPDude!

I had been experimenting with various players / plugins and have to say yours is the best, most natural sounding! Keep up the good work!

One feature request: Can you add an option for files without replaygain info to be played some db quieter or louder (user configurable, maybe +/- 10 db)?

  • odyssey
  • [*][*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #40
Ok, after reading through LAME source and a few headaches, I've got the LAME gapless working properly

There seems to be a slighty problem with gapless files, splitted with pcutmp3 - It cuts off 3960 samples (at least in my quick test).
  • Last Edit: 03 August, 2006, 02:17:06 PM by odyssey
Can't wait for a HD-AAC encoder :P

  • TrNSZ
  • [*][*][*][*][*]
  • Developer
Updated in_mad Winamp MAD MP3 input plugin
Reply #41
I had been experimenting with various players / plugins and have to say yours is the best, most natural sounding!
TOS #8?

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #42
I'll have a look into why pcutmp3 files aren't working gaplessly - 3960 is a big number!. I'll also add a preamp option for files without replaygain. I have made some more changes to the LAME tag reading - I've abandoned the LAME routines, and migrated to the already (partially) present madplay XING/LAME routines.

At the moment, I've been working on updating the Id3v2 tag editor to show all fields in a frame, and cleaning up the code.

I'll post when the next update is available.

(Actually, thinking about it, the old LAME routines take any gapless clipping value above 3000 as rubbish so maybe its only that - I'll get the next release up ASAP for you to test)
  • Last Edit: 03 August, 2006, 02:59:17 PM by MoSPDude

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #43
Another update, download from the usual.

I've made some heavy changes to the ID3v2 editor, and need to make some finishing touches. I've also made the gapless buffer dynamic. odyssey, could you test the pcutmp3 files again please and post number of samples out.

Thanks in advance.

  • Big_Berny
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #44
Hi,
I just tried the the mad-plugin with MediaMonkey (winamp-compatible). But I have two problems:
First, the noise shaping adds really strange and loud noise/clicks. No need to ABX!
Second, somehow all the mad-settings get messed up after hearing a song.

Anyone else with this problems? I returned to otachans mpg123 for the moment.

Big_Berny

  • MoSPDude
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #45
Hi,
I just tried the the mad-plugin with MediaMonkey (winamp-compatible). But I have two problems:
First, the noise shaping adds really strange and loud noise/clicks. No need to ABX!
Second, somehow all the mad-settings get messed up after hearing a song.

Anyone else with this problems? I returned to otachans mpg123 for the moment.

Big_Berny


I've just installed MediaMonkey and tried it, and your right - all the settings are screwed, I think thats the main problem. I'll look into it for the next release ASAP.

  • MedO
  • [*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #46
Hi,
I just tried the the mad-plugin with MediaMonkey (winamp-compatible). But I have two problems:
First, the noise shaping adds really strange and loud noise/clicks. No need to ABX!
Second, somehow all the mad-settings get messed up after hearing a song.

Anyone else with this problems? I returned to otachans mpg123 for the moment.

Big_Berny


These problems happen here, too, but only when a DSP plugin is enabled.

  • Big_Berny
  • [*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #47
Thanks!

By the way, I have no DSP plugin activated.

Big_Berny

Updated in_mad Winamp MAD MP3 input plugin
Reply #48
After using this input plugin, I have some problems about the last.fm plugin.

All the tags are like "WM/MediaClassPrimaryID" .
Is this problem about the mad plugin or the last.fm plugin?

btw, i just heard of this plugin and loved it. nice work.

  • odyssey
  • [*][*][*][*][*]
Updated in_mad Winamp MAD MP3 input plugin
Reply #49
I've also made the gapless buffer dynamic. odyssey, could you test the pcutmp3 files again please and post number of samples out.

I still get 3960 samples cut out

Edit 3: It seems that the cut out is from the beginning of a track. I measured 3336 samples cut out from the first track of the two i'm testing gaplessy, which would be needed if i included the previous track in my test.

It looks funny with the 9 columns of ID3v2 tags, but if that's the way it work...  Do you have any information on why (/how?) recursive tags work - just out of curiosity

Is it possible to put these recursive tags into Title Formatting? (Although I would need some Advanced formatting to replace the funky Helium chars )

I also experienced a crash once I opened the "View file info"-dialog. I'll try to find out what caused that.

Edit: This way of tagging opens up a whole lot of possebilities... If you can use recursive tagging like that, you could put multiple artists under TPE1, and not just a comment field (Like HMM). If just any nice tagging app would do that...

Edit 2: How come "Advanced Title Formatting" don't support these ID3v2 fields??? Actually Winamp reads any field in both JTF and ML, it just needs the correct way of displaying fully tagged files.
  • Last Edit: 04 August, 2006, 11:44:39 AM by odyssey
Can't wait for a HD-AAC encoder :P