Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: Updated in_mad Winamp MAD MP3 input plugin (Read 265757 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Updated in_mad Winamp MAD MP3 input plugin

Reply #250
very clever my old buddy.

Updated in_mad Winamp MAD MP3 input plugin

Reply #251
I was wondering if it was possible to start including build/version info in the compiled DLL file so that it's much easier to see which version you have and thus report back any issues which might be version specific.

Normally when this info is included, windows will either show it on the explorer status bar or mouseover, and/or in the file properties, making it very easy to see at a glance.

I've been running the current version as of a couple days ago and have not had any crashes in Mediamonkey, but since I don't know what the current build is I have, it's difficult to relay any information.

Updated in_mad Winamp MAD MP3 input plugin

Reply #252
I'm preparing an update to be uploaded tomorrow.

Thanks to kairo for looking into the mad_killer problem  I've added a DLL version to help identify different builds at Teknojnky request.

Thanks to all for bug finding and problem reporting 


Updated in_mad Winamp MAD MP3 input plugin

Reply #254
I've uploaded the update. There is a DLL version included, that can be found by looking at the file properties, or from in Winamp in the title of the About plug-in box. Its currently at 0.1.1.26 .

@gameplaya15143, what are the URLs for the streams your testing? in_mad only attempts to connect to those starting http, https or ftp.

Updated in_mad Winamp MAD MP3 input plugin

Reply #255
Hi. I downloaded mad cause of old versions doesn't support id3v2 tags.
BUT this version  (0.15.1 beta) DOESN'T SUPPORT cyrillic symbols in 3v2!!
When i trying to save cyrillic to id3v2 after saving it looks like
.....-.....!! But if i save cyrillic to id3v1 mad saves it correctly.
Please fix this bug!! Cause I have great russian collection.

Updated in_mad Winamp MAD MP3 input plugin

Reply #256
International characters will always be a bit of a problem, what version of Winamp are you using? I'm planning, now Winamp supports Unicode, to redo the get_fileinfo and other DLL interfaces properly - but the plug-in as a whole won't become fully Unicode for a while as its a lot of work.

I'm also thinking about a rewrite from C to C++ code, and then try to access the Winamp global configuration classes again.

Cheers for comments and bug reports 

Updated in_mad Winamp MAD MP3 input plugin

Reply #257
Hello;
I love the new in_mad; I would like to use it more, but unfortunately it is not compatible with the Last.fm (Audioscrobbler) plugin. Actually, sometimes the scrobbling actually does occur, but both song title and artist name are "È9", "È:" or something similar. How hard is it to make in_mad Last.fm compatible?

Updated in_mad Winamp MAD MP3 input plugin

Reply #258
@fragmer, not too hard  I've uploaded a quick update to fix the last.fm gen/ml_audioscrobbler problem. The problem was down to audioscrobbler looking for "Artist", not "artist" etc. The DLL is now at version 0.1.1.36 .

I'm currently making changes to improve Unicode and international character support.

Cheers for all comments and help

Updated in_mad Winamp MAD MP3 input plugin

Reply #259
oh my gosh thanks for fixing audioscrobbler I use it too!

Updated in_mad Winamp MAD MP3 input plugin

Reply #260
I'm downloading the newest version now.

Earlier today I was listening to so MP3s off a CDR (data), when the track starts, it plays for a split second, then has to buffer more before it can play properly.  Would that have something to do with the 'faster decoding' thing you added in a long while back?  I tried playing with the buffer size with no success to fix the gap.  I also managed to crach winamp from in_mad (it got reported as being responsible by windows) while seeking in long files on the CD (ie. 60mins 112kbps cbr).

As for the streams that weren't working with in_mad, I just tried some from www.shoutcast.com/waradio

Other than that, it is working perfectly

edit: The new version seems to think that my mp3's are read-only.  The tag fields are 'grayed out' when the file is playing.  If I access the tag editor while the song is not playing, everything is fine.  I'm going back to the last version I had since I haven't had any problems with it.
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune

Updated in_mad Winamp MAD MP3 input plugin

Reply #261
Whoops  , the read-only problem was due to me playing with the access rights when opening the file for playback. I've uploaded the fixed version just now, its DLL version is 0.1.1.37. 

@gameplaya15143, what kind of internet connection do you have? The plug-in only uses windows InternetOpenUrl to create the connection. Also, what options are enabled in the General tab of the configuration page.
As for the CD reading problem, on playing back tracks does your CD drive spin down after an initial burst read? I've had a lot of trouble with this - my solution was to extend the Output plug-in buffer to give enough time for the CD drive to spin up again and fetch the data ready for the plug-in to decode more. I also tried a utility to extend the spin down time of the drive at the cost of more whirring noise. The hanging when seeking on CD will likely be caused by Accurate seeking - again does your CD drive appear to be heavy seeking when you tell Winamp to seek? Accurate seeking works by 'header skipping' its way from the start of the file to the desired output position - which on long/large files on CD could be a problem.

Updated in_mad Winamp MAD MP3 input plugin

Reply #262
I have everything enabled in the 'general' tab.  I generally use only 300ms for my output buffer.  I did compare how in_mad and in_mpg123 and in_mp3 handled input from my data CD.  I'll have to try seeking without accurate seeing enabled.  I rarely ever listen to mp3s directly off a CD, so increasing my output plugin buffer for those few times certainly isn't out of the question.  I wouldn't worry about it too much unless you have some idea of how to compensate for super-slow access speeds.  And yes my CDrom drive is working properly by not spinning at full speed the entire time  The 'skips' generally occur when reading the tags on other files when the winamp window scrolls.

As far as internet connection goes, I have tried it on both dialup and direct connection.  Both with the same result.  It would only decode the stream when I was running my own server on localhost.  I haven't done any stream tests with the latest version yet.. so, I don't know, maybe it's already working better.  I'll be sure to let you know how it goes.

Keep up the wonder work.. I already can't stand to go back to any other mp3 plugin (I did that a while back, and I ended up like this ->  )
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune

Updated in_mad Winamp MAD MP3 input plugin

Reply #263
With the playback from CD, it might help if I was to make it so it didn't require to read from the CD all the time, as reading into the buffer occurs synchronously so the plug-in stops sending data to the output plug-in. Maybe an option to set the percentage of buffer thats empty before it reads again, in the earlier versions it only used to read when the buffer had emptied completely, now it reads all the time - but a compromise say 75% buffer would make it read bigger chunks less of the time. Then again, if windows caches the whole file from the CD, the CD would still spin down as its not physically reading it all the time.

I'll make some tweaks to the internet open routines etc. and see if that helps the streaming issue.

The Unicode interfaces are coming along slowly. It detects what the winamp version is, and if 5.3 or over enables the Unicode interfaces. The Unicode interaction is only with Winamp, the plug-in is still ANSI - although rewriting all the tag routines as such will make it easier to move over to a Unicode plug-in.

Updated in_mad Winamp MAD MP3 input plugin

Reply #264
The CUE Player plugin (latest version here) doesn't work properly when MAD is the default MP3 decoder. I'm using Winamp 5.32, and its standard MP3 decoder has no problems with CUE Player. However, when I switch to MAD, I see two different behaviors:

- If "Enable accurate seeking" is off, Winamp cannot accurately seek to the beginning of the tracks in the CUE file. It is always off target by a few seconds, but the seek points are the same between consecutive plays; if one track starts playing from +2.5 secs, it does so everytime, while another track always starts at -1.3 secs, etc... I guess this is expected, since accurate seeking is disabled.

- If I turn on "Enable accurate seeking", playback is totally broken. All tracks start to play from the very beginning of the file, the handle of the Winamp time slider disappears, and the time display freezes at 00:00. Sometimes a track will start properly, but this happens once in maybe 30 tries.

Can you please look into this? If it turns out to be CUE Player's fault, I'll contact its author for a fix.

Thank you for all the work you put into this plugin. The APE tag support alone is enough reason for me to use MAD. Best regards...

Updated in_mad Winamp MAD MP3 input plugin

Reply #265
I've uploaded a new DLL version just to fix CUE player, DLL version 0.1.1.39. This still has NO WA5.3 Unicode support.

It was a welcome change to writing in Unicode stuff!!    Its coming along slowly, just over half done and working, I don't want to put it up until its functional. I've also prepared some changes to make the buffer filling level changable, and changes to paramters for internet routines but these will have to wait until Unicode stuff is ready.

Thanks, and please feel free to post questions, bugs and suggestions!

Updated in_mad Winamp MAD MP3 input plugin

Reply #266
Thanks for fixing the plugin with Last.fm a while back . You should seriously consider adding a paypal/donation link here; you're putting so much work into in_mad!

Updated in_mad Winamp MAD MP3 input plugin

Reply #267
CUE Player problem fixed in 20 hours, you are fast  Thanks a lot.

By the way, if accurate seeking is enabled, does MAD scan the whole file from the beginning whenever it performs a seek operation? Jumping back and forth seems to take longer with accurate seeking, especially towards the end of large MP3 files.

Updated in_mad Winamp MAD MP3 input plugin

Reply #268
@Cybermutant, essentially yes, it header skips its way from the start of the file, counting samples, to 2 frames before the desired point, decodes 2 frames properly and then sample skips to the exact sample location. I've thought about adding a kind of seek table look up to the accurate seek so while playing if it knows that at a fixed location its at such a sample number it wouldn't have to seek from the beginning.

@fragmer, I just wanted an in_mad plug-in that supported ID3v2 tags and worked! 

Updated in_mad Winamp MAD MP3 input plugin

Reply #269
Maybe an option to set the percentage of buffer thats empty before it reads again
Sounds like a good idea to me.

Quote
I'll make some tweaks to the internet open routines etc. and see if that helps the streaming issue.
It didn't like that I had IE set to 'work offline'.  Streaming works fine now ...once I figured that out.  I can't say I like the idea of going through IE though
Vorbis-q0-lowpass99
lame3.93.1-q5-V9-k-nspsytune

Updated in_mad Winamp MAD MP3 input plugin

Reply #270
I think its a case of we say Internet Explorer, MS say integral part of the operating system and API. I've just done a google search on it, and found documents relating the WinInet API to a global offline mode, that I didn't realise. I'll have a rethink about the connection API, or perhaps for now make it change the global offline state, which will have an effect on IE though  .

Thanks for all bug reports, comments and suggestions 

Updated in_mad Winamp MAD MP3 input plugin

Reply #271
I've thought about adding a kind of seek table look up to the accurate seek so while playing if it knows that at a fixed location its at such a sample number it wouldn't have to seek from the beginning.
A lookup table would be very nice. It can wait though, I know that your current priority is Unicode support

Updated in_mad Winamp MAD MP3 input plugin

Reply #272
Using Winamp 5.32 with MAD DLL v0.1.1.39, when I open an m3u playlist which contains some files that are missing (in my case, they are in queue to be downloaded but their download haven't started yet), Winamp crashes when it reaches the first missing file while trying to read file tags for displaying them in the playlist. The crash details given by Windows are:

AppName: winamp.exe    AppVer: 5.3.2.1003    ModName: in_mad.dll
ModVer: 0.1.1.39    Offset: 00040479

The offset is always 00040479. The same m3u file is loaded without problem after all files in it have been downloaded (actually, after all files have been created on disk, even if they have a size of zero).

Updated in_mad Winamp MAD MP3 input plugin

Reply #273
I've uploaded a fix for the problem of trying to read tags from a file thats not there! Whoops! The DLL version is now 0.1.1.42. I'm close to releasing the Unicode version now.

Thanks to everyone for the help! 

Updated in_mad Winamp MAD MP3 input plugin

Reply #274
Did a quick check and, yep, problem fixed. Thanks for the lightning fast update