Quote from: Porcus on 21 January, 2012, 10:38:28 AMand after-write-verify.(Is the outfile supposed to have identical length as the original? One of my test files did in fact not.)
The output file should be the same length as the input file, but errors in the input file may make that not be the case. It's also sometimes because mp3packer adds an XING/LAME tag, which can show up as an extra music frame by some programs. Is the resultant file longer or shorter than the input?
"--keep-bad in --keep-ok out"
@Omion:I think you may've introduced something problematic into your latest version of mp3packer -- when used in a command prompt window on my Windows 7 x64, the command prompt goes nuts after having run mp3packer once. The cmd starts spouting out "The system cannot write to the specified device." errors and closing the window randomly. Commands stop working and the command prompt crashes out.I have checked versions 1.20 and after that 1.24 to rule out a long-term incompatibility. It's only the 1.25 that messes up my W7/x64 comprompt.
> Now to see how to fix it:> Does this happen on every file you run?
> Do you have anything on the system that uses non-ASCII characters?
What is the output of the "chcp" command?
"Active code page: 850"
Also, if you could post the exact command you typed in and the response it would help.
E:\>mp3packer -helpMP3 Packer version 1.25-237Copyright 2006-2008 Reed "Omion" Wilson[...] -help Display this list of options --help Display this list of optionsE:\>dirThe system cannot write to the specified device.The system cannot write to the specified device.The system cannot write to the specified device.The system cannot write to the specified device.
It happens every time I run mp3packer in cmd, even if I don't define any parameters.
A bit of playing around back and forth with -z: [...]every now and then, a 320 CBR file proves its inefficiency – there was one album which was reduced by a whopping 15 percent. (No, not one of those with half an hour silence before a hidden bonus track, and yes, I checked the outfile was bit-identical). I have actually tried a few settings to try to provoke forth anything remotely close to this with a recent LAME, at no 'success'.
Repacking successful; deleting backupFatal error: exception Sys_error("Adam Green - (2002) Adam Green/01 - Apples, I'm Home_org.mp3: Permission denied")
System.UnauthorizedAccessException: Access to the path 'E:\Music\D\Das Pop - (2003) The Human Thing\09 - The Machine.mp3' is denied. at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) at System.IO.FileInfo.Delete() at WinMP3Packer.MainForm.KillFile(FileInfo fi) at WinMP3Packer.MainForm.KillFile(String fileName) at WinMP3Packer.MainForm.ProcessFile(PackerQueueItem item)Finished processing file.
Code: [Select]Repacking successful; deleting backupFatal error: exception Sys_error("Adam Green - (2002) Adam Green/01 - Apples, I'm Home_org.mp3: Permission denied")
As I expected there are more problems with a delayed file handle closing on Windows 7 x64 to be found on various fora, not specific to mp3packer, but it does seem mp3packer is somehow affected by it. As a result, when attempting to remove the old file, it still looks like mp3packer is using it. I read something about compatibility modes, so now I'm trying to run mp3packer.exe in Vista SP2 compatibility mode. No problems so far, but only with a small sample set.
Sounds like the typical pitfalls of RAII pattern, when a garbage collector is involved. But, neither do I know ocaml, nor the mp3packer source code. So it's only a guess.
One more question, undoubtedly posed before (sorry): is there any way to make MP3packer preserve the original file's modification date & time?These dates are nice to preserve, because those indicate the times around which I discovered the bands/albums.