Skip to main content

Topic: Latest In_faad.dll From 8-26 Is Buggy (Read 6078 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • JohnMK
  • [*][*]
Latest In_faad.dll From 8-26 Is Buggy
Very prominent and obvious decoding artifacts not present in earlier versions. I first noticed it on a Bach piece by Yo Yo Ma. Recommend you don't inform RJAMORIM about this as he may call you nasty names and stuff.

  • Jan S.
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #1
I deleted your double posting.

  • JohnMK
  • [*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #2
The post in the technical forum was intentional. If you were going to delete one, I'd recommend this one, but too late now, I'll have to post again in technical.

  • rjamorim
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #3
Quote
Very prominent and obvious decoding artifacts not present in earlier versions.

Oh, yeah, so says the guy that doesn't even have the original to compare!

And WTF are you saying about earlier versions? You didn't even know where to download in_faad!!!

Just FYI, FAAD2's accuracy has been measured and it complies with the MPEG standards. I.E: Decoding is flawless.
Get up-to-date binaries of Lame, AAC, Vorbis and much more at RareWares:
http://www.rarewares.org

  • john33
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #4
Actually, I have to agree with Keynes. The latest CVS sweep produces compiles of ALL modules that generate awful output. I was going to mention it myself, but I assumed as it was a beta, it was going to be fixed fairly rapidly.
John
----------------------------------------------------------------
My compiles and utilities are at http://www.rarewares.org/

  • rjamorim
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #5
Quote
Actually, I have to agree with Keynes. The latest CVS sweep produces compiles of ALL modules that generate awful output. I was going to mention it myself, but I assumed as it was a beta, it was going to be fixed fairly rapidly.

Yes, But that's a commit that Menno did recently, in the integerization process.

The 08-26 CVS is clean - and that's why I didn't update in_faad yet.
Get up-to-date binaries of Lame, AAC, Vorbis and much more at RareWares:
http://www.rarewares.org

  • JohnV
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #6
Quote
Just FYI, FAAD2's accuracy has been measured and it complies with the MPEG standards. I.E: Decoding is flawless.

Actually, just to tease you: Ivan found a bug in FAAD2 (and probably in faad) that is preventing faad from decoding Fhg files with PNS properly.
Menno has been informed.
Juha Laaksonheimo

  • rjamorim
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #7
Quote
Actually, just to tease you: Ivan found a bug in FAAD2 (and probably in faad) that is preventing faad from decoding Fhg files with PNS properly.
Menno has been informed.

Yes, I know of that bug. I was referring to LC files (That's how the Cello Suites were encoded)
Get up-to-date binaries of Lame, AAC, Vorbis and much more at RareWares:
http://www.rarewares.org

  • Ivan Dimkovic
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #8
Yes, this is a problem - because Envivio and  Apple (Dolby)  are decoding these files without problems - FAAD2 generates some strange clicks.

I believe that  Menno will resolve the issue soon 

  • wildboar
  • [*][*]
  • Members (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #9
Compared to the August 9 build, the August 26 build sounds like someone transcoded an Xing 64kbps encoding to 320, then zipped it and stuck it on a floppy disk that was left on the dash of a car over the weekend which was subsequently presented to a data recovery company who extracted the file and then someone at work stole the file and transcoded it to WMA and then finally back to AAC.
You can't kill the Elephant.

Latest In_faad.dll From 8-26 Is Buggy
Reply #10
sounds horrible!

  • JohnV
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #11
August 26th build FAAD is buggy. It sounds horrible with the sample I tested.

Here are 2 spectral pictures. First one is correct decoding.
http://sivut.koti.soon.fi/julaak/faad.png
http://sivut.koti.soon.fi/julaak/faadaug26.png
Juha Laaksonheimo

  • menno
  • [*][*][*][*][*]
  • Developer (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #12
Well, you shouldn't think that every change I make is ready for release versions.
I'll fix it really soon.

Menno

  • JohnV
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #13
Quote
Well, you shouldn't think that every change I make is ready for release versions.
I'll fix it really soon.

Menno

That's right. But the binaries which are online should be working..

Seems that Roberto did change at least the WinAmp plugin already in the rarewares page in all the silence.. 
faad2 commandline aug26 is buggy too, so that binary should be taken down also.
Juha Laaksonheimo

  • Mac
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #14
Quote
Recommend you don't inform RJAMORIM about this as he may call you nasty names and stuff.


Sadly for you, Roberto can read English    Secondly I'll call you a dribbler as he didn't!
< w o g o n e . c o m / l o l >

  • menno
  • [*][*][*][*][*]
  • Developer (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #15
The code in CVS now is fixed, I think (let's stay careful).
There was a bug in the new filterbank that produced some awful clicks on start transition windows.
The other bug had to do with the integerisation process, I thought I didn't change anything else in the floating point code, but I mad a little mistake. Fixed point still sounds like crap now, but floating point should be better now.

Menno

  • john33
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #16
Quote
The code in CVS now is fixed, I think (let's stay careful).

That seemed to do the trick!!  Everything seems OK now, thanks Menno.
John
----------------------------------------------------------------
My compiles and utilities are at http://www.rarewares.org/

  • rjamorim
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #17
New FAAD binaries available at RareWares.
Get up-to-date binaries of Lame, AAC, Vorbis and much more at RareWares:
http://www.rarewares.org

  • Case
  • [*][*][*][*][*]
  • Developer (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #18
Quote
New FAAD binaries available at RareWares.

New Winamp3 plugin makes Winamp crash when trying to play any other format but AAC and both Winamp2 and Winamp3 plugins still decode with bad quality.

  • JohnV
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #19
Verified. Do NOT use Aug30 release of FAAD from Rarewares either..

Absolutely horrible quality still... Something is badly wrong there.
This SHOULD be so obvious that no example sample is needed. I mean this is obviously very audbily with any track.

Seems like it's still similarly buggy. Lots of high frequencies missing etc.. Spectral view shows similar behaviour like Aug26 build... Quality with Psytel -normal is absolutely horrendous with this decoder build.
Juha Laaksonheimo

  • Case
  • [*][*][*][*][*]
  • Developer (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #20
It looks like the same bug. Here's a graph of working plugin vs. latest rarewares plugin: http://www.saunalahti.fi/~cse/bug.png

Ps. Plugin crashes if files have id3v1 tags.

  • john33
  • [*][*][*][*][*]
  • Developer
Latest In_faad.dll From 8-26 Is Buggy
Reply #21
These plugins were made from today's CVS sweep and work fine here (except I don't have Winamp 3 loaded, so that may, or may not, be OK!).

Temporarily, you can get them here.
John
----------------------------------------------------------------
My compiles and utilities are at http://www.rarewares.org/

  • Case
  • [*][*][*][*][*]
  • Developer (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #22
Now the files sound normal.

  • AgentMil
  • [*][*][*][*][*]
  • Members (Donating)
Latest In_faad.dll From 8-26 Is Buggy
Reply #23
Do these new plugins have any new quality related features added to them? Or is it still safe to use the August 9 builds?

Cheers
AgentMil
-=MusePack... Living Audio Compression=-

Honda - The Power of Dreams

  • rjamorim
  • [*][*][*][*][*]
Latest In_faad.dll From 8-26 Is Buggy
Reply #24
Quote
Now the files sound normal.

What in the flaming f**k...

Oh, well. I'm clueless.

Will do a clean CVS sweep and upload new binaries again. God help they will come out fine this time.
Get up-to-date binaries of Lame, AAC, Vorbis and much more at RareWares:
http://www.rarewares.org